Re: [PATCH v3 07/26] block: Use bio_sectors() more consistently

2012-09-24 Thread Ed Cashin
On Sep 24, 2012, at 6:34 PM, Kent Overstreet wrote: Bunch of places in the code weren't using it where they could be - this'll reduce the size of the patch that puts bi_sector/bi_size/bi_idx into a struct bvec_iter. The aoe changes look fine to me, thanks. -- Ed Cashin ecas

[PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index c491fba..3ce01f6 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe

[PATCH 2/8] aoe: provide ATA identify device content to user on request

2012-11-08 Thread Ed Cashin
This patch makes the aoe driver follow expected behavior when the user uses ioctl to get the ATA device identify information. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoeblk.c | 30 ++ drivers/block/aoe

[PATCH 3/8] aoe: improve network congestion handling

2012-11-08 Thread Ed Cashin
commands being retransmitted are transferred from one retransmit queue to another. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h| 16 +++-- drivers/block/aoe/aoecmd.c | 173 +++- drivers/block/aoe/aoedev.c |6 +- 3 files

[PATCH 4/8] aoe: err device: include MAC addresses for unexpected responses

2012-11-08 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index f849fa2..6ea27fd 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe

[PATCH 5/8] aoe: manipulate aoedev network stats under lock

2012-11-08 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 6ea27fd..9aefbe3 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe

[PATCH 6/8] aoe: use high-resolution RTTs with fallback to low-res

2012-11-08 Thread Ed Cashin
is relatively large. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|9 --- drivers/block/aoe/aoecmd.c | 57 ++- 2 files changed, 55 insertions(+), 11 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe

[PATCH 7/8] aoe: commands in retransmit queue use new destination on failure

2012-11-08 Thread Ed Cashin
for retransmits that need to be done are updated to use the new destination, so that retransmits will be sent through a working network path. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoecmd.c | 75

[PATCH 8/8] aoe: update driver-internal version to 64+

2012-11-08 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index c253cca..9655ce3 100644 --- a/drivers/block/aoe/aoe.h +++ b/drivers/block/aoe/aoe.h @@ -1,5

Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Ed Cashin
On Nov 8, 2012, at 2:26 PM, Andrew Morton wrote: On Thu, 8 Nov 2012 11:29:32 -0500 Ed Cashin ecas...@coraid.com wrote: Signed-off-by: Ed Cashin ecas...@coraid.com Could you please prepare decent changelogs for the patches? Several of these appear to be bugfixes but we have

Re: [PATCH] aoe: remove unused variable in resend()

2012-10-22 Thread Ed Cashin
frame *f) return; } h = (struct aoe_hdr *) skb_mac_header(skb); - ah = (struct aoe_atahdr *) (h+1); snprintf(buf, sizeof buf, %15s e%ld.%d oldtag=%08x@%08lx newtag=%08x s=%pm d=%pm nout=%d\n, -- Ed Cashin ecas...@coraid.com

[PATCH] Documentation/SubmittingPatches: implicit permission for public reports

2012-10-24 Thread Ed Cashin
The current text of SubmittingPatches recommends asking permission before using Reported-By: even when the report was made to a public forum. This patch updates the text to better reflect the current convention of including the tag when the report was public. Signed-off-by: Ed Cashin ecas

Re: [PATCH] Documentation/SubmittingPatches: implicit permission for public reports

2012-10-24 Thread Ed Cashin
On Oct 24, 2012, at 10:36 AM, Jonathan Corbet wrote: On Wed, 24 Oct 2012 10:22:02 -0400 Ed Cashin ecas...@coraid.com wrote: +contribution. Please note that this tag should not be added without +the reporter's permission unless the problem was reported in a public +forum. That said, if we

[PATCH] aoe: avoid using skb member after dev_queue_xmit

2012-10-24 Thread Ed Cashin
After calling dev_queue_xmit it is no longer safe to access the members of the skb. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoenet.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-09 Thread Ed Cashin
the sparse context feature and the locking annotations like __acquires and __must_hold would be a nice addition. I can take a stab at it if folks agree. -- Ed Cashin ecas...@coraid.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit

2012-10-25 Thread Ed Cashin
On Oct 25, 2012, at 2:33 AM, Dan Carpenter wrote: On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote: On Wed, 24 Oct 2012 14:26:13 -0400 Ed Cashin ecas...@coraid.com wrote: After calling dev_queue_xmit it is no longer safe to access the members of the skb. Reported-by: Dan

[PATCH 0/8] aoe: improved network congestion handling from v60 to v64+

2012-11-08 Thread Ed Cashin
This patch series is based on linux-next/akpm from 8 Nov, commit db3846344ad57222. Ed L. Cashin (8): aoe: avoid running request handler on plugged queue aoe: provide ATA identify device content to user on request aoe: improve network congestion handling aoe: err device: include MAC

[PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Ed Cashin
-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index c491fba..3ce01f6 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c

[PATCH 2/8] aoe: provide ATA identify device content to user on request

2012-11-08 Thread Ed Cashin
This patch makes the aoe driver follow expected behavior when the user uses ioctl to get the ATA device identify information, allowing access to model, serial number, etc. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoeblk.c | 30

[PATCH 3/8] aoe: improve network congestion handling

2012-11-08 Thread Ed Cashin
commands being retransmitted are transferred from one retransmit queue to another. Another upcoming patch increases the timing accuracy. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h| 16 +++-- drivers/block/aoe/aoecmd.c | 173

[PATCH 4/8] aoe: err device: include MAC addresses for unexpected responses

2012-11-08 Thread Ed Cashin
, so that when they occur, it's more easy to determine the network paths to which they belong. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe

[PATCH 5/8] aoe: manipulate aoedev network stats under lock

2012-11-08 Thread Ed Cashin
. Without this change, the effect of the bug would be rare unecessary but benign retransmissions. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe

[PATCH 6/8] aoe: use high-resolution RTTs with fallback to low-res

2012-11-08 Thread Ed Cashin
is relatively large. Otherwise the AoE targets could be considered failed inappropriately. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|9 --- drivers/block/aoe/aoecmd.c | 57 ++- 2 files changed, 55 insertions(+), 11

[PATCH 7/8] aoe: commands in retransmit queue use new destination on failure

2012-11-08 Thread Ed Cashin
failure before there's time for the retransmit timer to run again, decide to retransmit again, and finally update the destination to a working MAC address on the AoE target. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoecmd.c | 75

[PATCH 8/8] aoe: update driver-internal version to 64+

2012-11-08 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index c253cca..9655ce3 100644 --- a/drivers/block/aoe/aoe.h +++ b/drivers/block/aoe/aoe.h @@ -1,5

Re: [PATCH 2/8] aoe: provide ATA identify device content to user on request

2012-11-08 Thread Ed Cashin
On Nov 8, 2012, at 7:40 PM, Jeff Garzik wrote: On 11/08/2012 11:32 AM, Ed Cashin wrote: This patch makes the aoe driver follow expected behavior when the user uses ioctl to get the ATA device identify information. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h

[PATCH 0/9] aoe: various enhancements and cleanup from v50 to v60

2012-10-15 Thread Ed Cashin
This patch series is based on linux-next/akpm from 11 Oct. The patch that modifies aoenet.c:tx to print a warning does not affect locking but nonetheless causes a new sparse context warning to appear. Before a bug in sparse suppressed the warning. We will soon be able to use the new

[PATCH 1/9] aoe: describe the behavior of the err character device

2012-10-15 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoechr.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c index ed57a89..2bf6273 100644 --- a/drivers/block/aoe/aoechr.c +++ b/drivers/block/aoe

[PATCH 2/9] aoe: print warning regarding a common reason for dropped transmits

2012-10-15 Thread Ed Cashin
Dropped transmits are not common, but when they do occur, increasing the transmit queue length often helps. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoenet.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoenet.c b

[PATCH 3/9] aoe: update cap on outstanding commands based on config query response

2012-10-15 Thread Ed Cashin
or decreased, respectively. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|6 +++--- drivers/block/aoe/aoecmd.c |6 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index d2ed7f1..52f75c0 100644

[PATCH 4/9] aoe: support the forgetting (flushing) of a user-specified AoE target

2012-10-15 Thread Ed Cashin
-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoedev.c | 44 ++-- 1 files changed, 38 insertions(+), 6 deletions(-) diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index 90e5b53..63b2660 100644 --- a/drivers/block/aoe/aoedev.c

[PATCH 5/9] aoe: support larger I/O requests via aoe_maxsectors module param

2012-10-15 Thread Ed Cashin
The GPFS filesystem is an example of an aoe user that requires the aoe driver to support I/O request sizes larger than the default. Most users will not need large I/O request sizes, because they would need to be split up into multiple AoE commands anyway. Signed-off-by: Ed Cashin ecas

[PATCH 6/9] aoe: payload sysfs file exports per-AoE-command data transfer size

2012-10-15 Thread Ed Cashin
The userland aoetools package includes an aoe-stat command that can display a payload size column when the aoe driver exports this information. Users can quickly see what amount of user data is transferred inside each AoE command on the network, network headers excluded. Signed-off-by: Ed Cashin

[PATCH 7/9] aoe: cleanup: remove unused ata_scnt function

2012-10-15 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 2bb8c7d..82e16c4 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block

[PATCH 8/9] aoe: whitespace cleanup

2012-10-15 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- drivers/block/aoe/aoechr.c |2 +- drivers/block/aoe/aoecmd.c |6 +++--- drivers/block/aoe/aoemain.c |2 +- drivers/block/aoe/aoenet.c |4 ++-- 5 files changed, 8 insertions(+), 8 deletions

Re: [PATCH v4 05/24] block: Use bio_sectors() more consistently

2012-10-15 Thread Ed Cashin
The aoe changes look OK, thanks. -- Ed Cashin ecas...@coraid.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH 9/9] aoe: update driver-internal version number to 60

2012-10-15 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index 8e8da1c..536942b 100644 --- a/drivers/block/aoe/aoe.h +++ b/drivers/block/aoe/aoe.h @@ -1,5

[PATCH 0/9] aoe: various enhancements and cleanup from v50 to v60

2012-10-17 Thread Ed Cashin
Change since first submission: Go ahead and use the __must_hold() annotation provided recently by Josh Triplett, already in mm. This patch series is based on linux-next/akpm from 11 Oct. Ed L. Cashin (9): aoe: describe the behavior of the err character device aoe: print

[PATCH 1/9] aoe: describe the behavior of the err character device

2012-10-17 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoechr.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c index ed57a89..2bf6273 100644 --- a/drivers/block/aoe/aoechr.c +++ b/drivers/block/aoe

[PATCH 2/9] aoe: print warning regarding a common reason for dropped transmits

2012-10-17 Thread Ed Cashin
Dropped transmits are not common, but when they do occur, increasing the transmit queue length often helps. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoenet.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoenet.c b

[PATCH 3/9] aoe: update cap on outstanding commands based on config query response

2012-10-17 Thread Ed Cashin
or decreased, respectively. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|6 +++--- drivers/block/aoe/aoecmd.c |6 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index d2ed7f1..52f75c0 100644

[PATCH 4/9] aoe: support the forgetting (flushing) of a user-specified AoE target

2012-10-17 Thread Ed Cashin
-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoedev.c | 44 ++-- 1 files changed, 38 insertions(+), 6 deletions(-) diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index 90e5b53..63b2660 100644 --- a/drivers/block/aoe/aoedev.c

[PATCH 5/9] aoe: support larger I/O requests via aoe_maxsectors module param

2012-10-17 Thread Ed Cashin
The GPFS filesystem is an example of an aoe user that requires the aoe driver to support I/O request sizes larger than the default. Most users will not need large I/O request sizes, because they would need to be split up into multiple AoE commands anyway. Signed-off-by: Ed Cashin ecas

[PATCH 6/9] aoe: payload sysfs file exports per-AoE-command data transfer size

2012-10-17 Thread Ed Cashin
The userland aoetools package includes an aoe-stat command that can display a payload size column when the aoe driver exports this information. Users can quickly see what amount of user data is transferred inside each AoE command on the network, network headers excluded. Signed-off-by: Ed Cashin

[PATCH 7/9] aoe: cleanup: remove unused ata_scnt function

2012-10-17 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 2bb8c7d..82e16c4 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block

[PATCH 8/9] aoe: whitespace cleanup

2012-10-17 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- drivers/block/aoe/aoechr.c |2 +- drivers/block/aoe/aoecmd.c |6 +++--- drivers/block/aoe/aoemain.c |2 +- drivers/block/aoe/aoenet.c |4 ++-- 5 files changed, 8 insertions(+), 8 deletions

[PATCH 9/9] aoe: update driver-internal version number to 60

2012-10-17 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index 8e8da1c..536942b 100644 --- a/drivers/block/aoe/aoe.h +++ b/drivers/block/aoe/aoe.h @@ -1,5

[PATCH] Documentation/sparse.txt: document context annotations for lock checking

2012-10-18 Thread Ed Cashin
The context feature of sparse is used with the Linux kernel sources to check for imbalanced uses of locks. Document the annotations defined in include/linux/compiler.h that tell sparse what to expect when a lock is held on function entry, exit, or both. Signed-off-by: Ed Cashin ecas

Re: [Suggestion] drivers/block/aoe: using uninitialized variable.

2013-03-27 Thread Ed Cashin
-bv_len; 932 WARN_ON(buf-bv_resid == 0); 933 } -- Ed Cashin ecas...@coraid.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] aoe: replace kmalloc and then memcpy with kmemdup

2013-03-11 Thread Ed Cashin
); if (mp == NULL) { printk(KERN_ERR aoe: allocation failure, len=%ld\n, n); goto bail; } - memcpy(mp, msg, n); em-msg = mp; em-flags |= EMFL_VALID; em-len = n; -- 1.7.10.4 -- Ed Cashin ecas...@coraid.com

[PATCH 0/7] aoe: driver improvements and fixes through v81

2012-12-03 Thread Ed Cashin
This patch series applies to today's linux-next/akpm, commit a5944abc848a1b8e5329a631a84e35a3b0249ecb. Ed L. Cashin (7): aoe: improve handling of misbehaving network paths aoe: avoid races between device destruction and discovery aoe: use dynamic number of remote ports for AoE storage

[PATCH 1/7] aoe: improve handling of misbehaving network paths

2012-12-03 Thread Ed Cashin
is redeemed, and its taint is removed. This mechanism has been shown to be helpful in transparently handling and recovering from real-world network brown outs in ways that the earlier shoot the help-needing target in the head mechanism could not. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers

[PATCH 2/7] aoe: avoid races between device destruction and discovery

2012-12-03 Thread Ed Cashin
pointer remains from a time when about half of this patch was done, and it was possible for the bdev-bd_disk-private_data to become corrupted. The check should be removed eventually, but it is not expected to add significant overhead, occurring in the aoeblk_open routine. Signed-off-by: Ed Cashin

[PATCH 3/7] aoe: use dynamic number of remote ports for AoE storage target

2012-12-03 Thread Ed Cashin
there are many AoE targets with fewer than eight MAC addresses each. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|6 ++-- drivers/block/aoe/aoeblk.c |2 +- drivers/block/aoe/aoecmd.c | 50 ++- drivers/block/aoe/aoedev.c | 12

[PATCH 4/7] aoe: allow user to disable target failure timeout

2012-12-03 Thread Ed Cashin
marks the aoe device as down and fails all I/O. The new meaning of an aoe_deadsecs of zero is for the driver to retransmit commands indefinitely. Signed-off-by: Ed Cashin ecas...@coraid.com --- Documentation/aoe/aoe.txt |4 +++- drivers/block/aoe/aoecmd.c |4 +++- 2 files changed, 6

[PATCH 5/7] aoe: allow comma separator in aoe_iflist value

2012-12-03 Thread Ed Cashin
, modprobe aoe aoe_iflist=eth2,eth3 Before, it was inconvenient to get the quoting right in shell scripts when setting aoe_iflist to have more than one network interface. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|2 +- drivers/block/aoe/aoenet.c |2 +- 2

[PATCH 6/7] aoe: identify source of runt AoE packets

2012-12-03 Thread Ed Cashin
This change only affects experimental AoE storage networks. It modifies the console message about runt packets detected so that the AoE major and minor addresses of the AoE target that generated the runt are mentioned. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c

[PATCH 7/7] aoe: update internal version number to 81

2012-12-03 Thread Ed Cashin
This version number is printed to the console on module initialization and is available in sysfs, which is where the userland aoe-version tool looks for it. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff

Re: [PATCH 09/27] block: Use bio_sectors() more consistently

2013-02-20 Thread Ed Cashin
...@infradead.org CC: Alasdair Kergon a...@redhat.com CC: dm-de...@redhat.com CC: Neil Brown ne...@suse.de CC: Steven Rostedt rost...@goodmis.org Acked-by: Ed Cashin ecas...@coraid.com --- drivers/block/pktcdvd.c | 2 +- drivers/md/dm-raid1.c| 2 +- drivers/md/raid0.c

Re: [patch] aoe: cleanup an allocation a bit

2012-09-08 Thread Ed Cashin
Looks OK to me, thanks. On Sep 7, 2012, at 11:59 PM, Dan Carpenter dan.carpen...@oracle.com wrote: We changed this recently so we can just use kzalloc() here instead of kcalloc(1, ...). Kernel style prefers sizeof(*t) over sizeof *t. The kfree(t) is a no-op now as well so that can be

[PATCH] net: do not disable sg for AoE

2012-09-19 Thread Ed Cashin
could use payloads of greater than a page in size, but its users generally do not use the newest kernels. Signed-off-by: Ed Cashin ecas...@coraid.com --- net/core/dev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index d7fe32c

Re: [PATCH] net: do not disable sg for AoE

2012-09-19 Thread Ed Cashin
for the inconvenience. -- Ed Cashin ecas...@coraid.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 0/2] do not disable sg when packet requires no checksum

2012-09-19 Thread Ed Cashin
This two-part patchset replaces an earlier net-only patch that added an explicit check for the AoE protocol to harmonize_features in net/core/dev.c. Following the suggestion of Ben Hutchings, this patchset makes the decision in the network layer protocol agnostic instead of using ETH_P_AOE as a

[PATCH 1/2] aoe: mark AoE packets as requiring no checksumming

2012-09-19 Thread Ed Cashin
In order for the network layer to see that AoE requires no checksumming in a generic way, packets should be marked CHECKSUM_NONE. Rather than relying on the current behavior of alloc_skb, this change causes the aoe driver to explicitly mark its packets as requiring no checksum. Signed-off-by: Ed

[PATCH 2/2] net: do not disable sg for packets requiring no checksum

2012-09-19 Thread Ed Cashin
could use payloads of greater than a page in size, but its users generally do not use the newest kernels. Signed-off-by: Ed Cashin ecas...@coraid.com --- net/core/dev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index d7fe32c

Re: [PATCH 1/2] aoe: mark AoE packets as requiring no checksumming

2012-09-19 Thread Ed Cashin
On Sep 19, 2012, at 9:25 PM, Ben Hutchings wrote: Can be written as: skb_checksum_none_assert(skb); Another good idea. I'll resend. -- Ed Cashin ecas...@coraid.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH 0/2] do not disable sg when packet requires no checksum

2012-09-19 Thread Ed Cashin
This two-part patchset replaces an earlier net-only patch that added an explicit check for the AoE protocol to harmonize_features in net/core/dev.c. Following the suggestions of Ben Hutchings, this patchset makes the decision in the network layer protocol agnostic instead of using ETH_P_AOE as a

[PATCH 1/2] aoe: assert AoE packets marked as requiring no checksum

2012-09-19 Thread Ed Cashin
In order for the network layer to see that AoE requires no checksumming in a generic way, the packets must be marked as requiring no checksum, so we make this requirement explicit with the assertion. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |1 + 1 files

[PATCH 2/2] net: do not disable sg for packets requiring no checksum

2012-09-19 Thread Ed Cashin
could use payloads of greater than a page in size, but its users generally do not use the newest kernels. Signed-off-by: Ed Cashin ecas...@coraid.com --- net/core/dev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index d7fe32c

Re: [PATCH 1/9] drivers/block/aoe/aoecmd.c: Remove useless kfree

2012-09-12 Thread Ed Cashin
There's a patch in the mm tree that already makes this change, thanks. Sent from my iPhone On Sep 12, 2012, at 5:08 AM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The

[PATCH 00/14] aoe driver v49 performance and usability improvements

2012-08-28 Thread Ed Cashin
In this resubmission of the patchset, several suggestions from Andrew Morton have been incorporated to clean up the changes. I will not be able to be very responsive during the first part of September, so the sooner you can provide feedback, the better. These patches go a long way to updating

[PATCH 01/14] aoe: for performance support larger packet payloads

2012-08-28 Thread Ed Cashin
(). With that regression in place, transmits always linearize sg AoE packets, but in-kernel users did not have this patch. Before 2.6.38, though, these changes were working to allow sg to increase performance. 1. http://www.spinics.net/lists/linux-mm/msg15184.html Signed-off-by: Ed Cashin ecas...@coraid.com

[PATCH 02/14] aoe: kernel thread handles I/O completions for simple locking

2012-08-28 Thread Ed Cashin
becoming unusable. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h | 33 ++- drivers/block/aoe/aoechr.c |3 +- drivers/block/aoe/aoecmd.c | 729 --- drivers/block/aoe/aoedev.c | 84 +++-- drivers/block/aoe/aoemain.c |8

[PATCH 03/14] aoe: become I/O request queue handler for increased user control

2012-08-28 Thread Ed Cashin
hasn't finished yet and cap the resources we use with a pool of skbs.[2] Now that the block layer maintains the disk stats, the aoe driver's diskstats function can go away. 1. https://lkml.org/lkml/2007/3/1/374 2. https://lkml.org/lkml/2007/7/6/241 Signed-off-by: Ed Cashin ecas...@coraid.com

[PATCH 04/14] aoe: use a kernel thread for transmissions

2012-08-28 Thread Ed Cashin
The dev_queue_xmit function needs to have interrupts enabled, so the most simple way to get the locking right but still fulfill that requirement is to use a process that can call dev_queue_xmit serially over queued transmissions. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe

[PATCH 05/14] aoe: use packets that work with the smallest-MTU local interface

2012-08-28 Thread Ed Cashin
MTU of all those local interfaces greatly simplifies the driver, especially in failure scenarios. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|7 +- drivers/block/aoe/aoecmd.c | 151 2 files changed, 87 insertions

[PATCH 06/14] aoe: failover remote interface based on aoe_deadsecs parameter

2012-08-28 Thread Ed Cashin
in the driver code and comments means a {major, minor, MAC address} tuple, as in somewhere to send packets. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|1 - drivers/block/aoe/aoecmd.c |8 +++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 07/14] aoe: do revalidation steps in order

2012-08-28 Thread Ed Cashin
, reflecting the normal discovery sequence. The responses could come back in any order, so this change is fairly cosmetic. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoechr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe

[PATCH 08/14] aoe: disallow unsupported AoE minor addresses

2012-08-28 Thread Ed Cashin
prevents unexpected targets from being used by the driver when AoE targets with high minor numbers are on the AoE network. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/block/aoe

[PATCH 09/14] aoe: associate frames with the AoE storage target

2012-08-28 Thread Ed Cashin
becomes unusable. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|8 +++--- drivers/block/aoe/aoecmd.c | 65 +++- drivers/block/aoe/aoedev.c | 30 +++- 3 files changed, 49 insertions(+), 54 deletions(-) diff

[PATCH 10/14] aoe: increase net_device reference count while using it

2012-08-28 Thread Ed Cashin
This change eliminates the danger that the user could rmmod the driver for a network interface that is being used for AoE by the aoe driver. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |4 drivers/block/aoe/aoedev.c |7 +++ 2 files changed, 11

[PATCH 11/14] aoe: remove unused code and add cosmetic improvements

2012-08-28 Thread Ed Cashin
This change removes some unused code and attempts to increase code consistency. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h| 10 +++--- drivers/block/aoe/aoechr.c |1 + drivers/block/aoe/aoecmd.c | 13 - drivers/block/aoe/aoenet.c |3

[PATCH 12/14] aoe: update internal version number to 49

2012-08-28 Thread Ed Cashin
on the coraid.com website, it is a form of version 49. 1. http://aoetools.sourceforge.net/ Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index eb41fc5

[PATCH 13/14] aoe: update copyright year in touched files

2012-08-28 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- drivers/block/aoe/aoeblk.c |2 +- drivers/block/aoe/aoechr.c |2 +- drivers/block/aoe/aoecmd.c |2 +- drivers/block/aoe/aoedev.c |2 +- drivers/block/aoe/aoemain.c |2 +- drivers/block

[PATCH 14/14] aoe: update documentation with new URL and VM settings reference

2012-08-28 Thread Ed Cashin
The old area has a new URL. Also, now that the driver can perform better, it is worth mentioning the VM settings that help aoe to sink dirty pages out early, avoiding unecessary memory pressure when much I/O is going on. Signed-off-by: Ed Cashin ecas...@coraid.com --- Documentation/aoe/aoe.txt

[PATCH 06/14] aoe: failover remote interface based on aoe_deadsecs parameter

2012-08-23 Thread Ed Cashin
in the driver code and comments means a {major, minor, MAC address} tuple, as in somewhere to send packets. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|1 - drivers/block/aoe/aoecmd.c |8 +++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 07/14] aoe: do revalidation steps in order

2012-08-23 Thread Ed Cashin
, reflecting the normal discovery sequence. The responses could come back in any order, so this change is fairly cosmetic. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoechr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe

[PATCH 08/14] aoe: disallow unsupported AoE minor addresses

2012-08-23 Thread Ed Cashin
prevents unexpected targets from being used by the driver when AoE targets with high minor numbers are on the AoE network. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/block/aoe

[PATCH 00/14] aoe driver v49 performance and usability improvements

2012-08-23 Thread Ed Cashin
These patches go a long way to updating the in-kernel aoe driver with the changes that have been in the coraid.com-distributed version, bringing it from (aoe internal) version 47 to version 49. They apply to commit 23dcfa61bac244e1 of the mainline git tree. These updates have been too long in

[PATCH 04/14] aoe: use a kernel thread for transmissions

2012-08-23 Thread Ed Cashin
The dev_queue_xmit function needs to have interrupts enabled, so the most simple way to get the locking right but still fulfill that requirement is to use a process that can call dev_queue_xmit serially over queued transmissions. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe

[PATCH 05/14] aoe: use packets that work with the smallest-MTU local interface

2012-08-23 Thread Ed Cashin
MTU of all those local interfaces greatly simplifies the driver, especially in failure scenarios. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|7 +- drivers/block/aoe/aoecmd.c | 151 2 files changed, 87 insertions

[PATCH 01/14] aoe: for performance support larger packet payloads

2012-08-23 Thread Ed Cashin
(). With that regression in place, transmits always linearize sg AoE packets, but in-kernel users did not have this patch. Before 2.6.38, though, these changes were working to allow sg to increase performance. 1. http://www.spinics.net/lists/linux-mm/msg15184.html Signed-off-by: Ed Cashin ecas...@coraid.com

[PATCH 02/14] aoe: kernel thread handles I/O completions for simple locking

2012-08-23 Thread Ed Cashin
becoming unusable. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h | 33 ++- drivers/block/aoe/aoechr.c |3 +- drivers/block/aoe/aoecmd.c | 737 --- drivers/block/aoe/aoedev.c | 84 +++-- drivers/block/aoe/aoemain.c |8

[PATCH 09/14] aoe: associate frames with the AoE storage target

2012-08-23 Thread Ed Cashin
becomes unusable. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|8 +++--- drivers/block/aoe/aoecmd.c | 65 +++- drivers/block/aoe/aoedev.c | 30 +++- 3 files changed, 49 insertions(+), 54 deletions(-) diff

[PATCH 10/14] aoe: increase net_device reference count while using it

2012-08-23 Thread Ed Cashin
This change eliminates the danger that the user could rmmod the driver for a network interface that is being used for AoE by the aoe driver. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoecmd.c |4 drivers/block/aoe/aoedev.c |7 +++ 2 files changed, 11

[PATCH 11/14] aoe: remove unused code and add cosmetic improvements

2012-08-23 Thread Ed Cashin
This change removes some unused code and attempts to increase code consistency. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h| 10 +++--- drivers/block/aoe/aoechr.c |1 + drivers/block/aoe/aoecmd.c | 13 - drivers/block/aoe/aoenet.c |3

[PATCH 03/14] aoe: become I/O request queue handler for increased user control

2012-08-23 Thread Ed Cashin
hasn't finished yet and cap the resources we use with a pool of skbs.[2] Now that the block layer maintains the disk stats, the aoe driver's diskstats function can go away. 1. https://lkml.org/lkml/2007/3/1/374 2. https://lkml.org/lkml/2007/7/6/241 Signed-off-by: Ed Cashin ecas...@coraid.com

[PATCH 12/14] aoe: update internal version number to 49

2012-08-23 Thread Ed Cashin
on the coraid.com website, it is a form of version 49. 1. http://aoetools.sourceforge.net/ Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h index eb41fc5

[PATCH 13/14] aoe: update copyright year in touched files

2012-08-23 Thread Ed Cashin
Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h |2 +- drivers/block/aoe/aoeblk.c |2 +- drivers/block/aoe/aoechr.c |2 +- drivers/block/aoe/aoecmd.c |2 +- drivers/block/aoe/aoedev.c |2 +- drivers/block/aoe/aoemain.c |2 +- drivers/block

[PATCH 14/14] aoe: update documentation with new URL and VM settings reference

2012-08-23 Thread Ed Cashin
The old area has a new URL. Also, now that the driver can perform better, it is worth mentioning the VM settings that help aoe to sink dirty pages out early, avoiding unecessary memory pressure when much I/O is going on. Signed-off-by: Ed Cashin ecas...@coraid.com --- Documentation/aoe/aoe.txt

  1   2   3   4   >