[PATCH 7/7] net: tipc: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/tipc/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/core.c b/net/tipc/core.c index c2ff42900b53..8c0c45347c53

[PATCH 5/7] net: bridge: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/bridge/br.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bridge/br.c b/net/bridge/br.c index 401eeb9142eb..2502fdcbb8b2

[PATCH 4/7] net: bluetooth: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/bluetooth/6lowpan.c | 3 --- net/bluetooth/af_bluetooth.c | 1 - net/bluetooth/bnep/core.c| 1 - net/bluetooth/cmtp/core.c

[PATCH 6/7] net: vmw_vsock: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/vmw_vsock/af_vsock.c | 1 - net/vmw_vsock/hyperv_transport.c | 1 - net/vmw_vsock/vmci_transport.c | 1 - 3 files changed, 3

[PATCH 3/7] net: ipv4: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt --- net/ipv4/tcp_cubic.c| 1 - net/ipv4/tcp_illinois.c | 1 - net/ipv4/tcp_nv.c | 1 - 3 files changed, 3 deletions(-) diff --git a/net/ipv4

[PATCH v2] gpio: just plain warning when nonexisting gpio requested

2020-12-02 Thread Enrico Weigelt, metux IT consult
From: Enrico Weigelt When trying to export an nonexisting gpio ID, the kernel prints out a big warning w/ stacktrace, sounding like a huge problem. In fact it's a pretty normal situation, like file or device not found. So, just print a more relaxed warning instead. changes v2: drop defining

Re: [PATCH 1/2] x86: make vmware support optional

2020-12-02 Thread Enrico Weigelt, metux IT consult
On 17.11.20 21:31, Borislav Petkov wrote: > On Tue, Nov 17, 2020 at 09:23:07PM +0100, Enrico Weigelt, metux IT consult > wrote: >> Make it possible to opt-out from vmware support > > Why? Reducing the kernel size. Think of very high density virtualization (w/ specially strip

Re: [PATCH v3 00/17] Introducing Linux root partition support for Microsoft Hypervisor

2020-12-02 Thread Enrico Weigelt, metux IT consult
rschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

[PATCH v2 1/2] x86: make VMware support optional

2020-12-02 Thread Enrico Weigelt, metux IT consult
Make it possible to opt-out from VMware support, for minimized kernels that never will be run under Vmware (eg. high-density virtualization or embedded systems). Average distro kernel will leave it on, therefore default to y. Signed-off-by: Enrico Weigelt --- arch/x86/Kconfig

[PATCH v2 2/2] x86: make Hyper-V support optional

2020-12-02 Thread Enrico Weigelt, metux IT consult
Make it possible to opt-out from Hyper-V support, for minimized kernels that never will by run under Hyper-V. (eg. high-density virtualization or embedded systems) Average distro kernel will leave it on, therefore default to y. Signed-off-by: Enrico Weigelt --- arch/x86/Kconfig

[PATCH 07/11] drivers: staging: vc04_services: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose. For in-tree drivers, the kernel version really matters. OTOH, the module version doesn't seem to be actively maintained - the code received changes while the version remained constant. Signed-off-by: Enrico Weigelt

[PATCH 02/11] drivers: staging: gasket: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code has received lots of changes, w/o the versions being actively maintained, so it doesn't seem to have much practical meaning. Signed-off-by: Enrico Weigelt

[PATCH 11/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. The driver received lots of changes, but module remained constant since it landed in mainline, several years ago. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1

[PATCH 09/11] drivers: staging: rtl8192e: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose: the driver has received lots of changes, while the module version remained constant. Unmaintained version numbers aren't actually useful. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1

[PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/goldfish/goldfish_audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index 0c65a0121dde..4a23f40e549a 100644 --- a/drivers/staging

[PATCH 06/11] drivers: staging: qlge: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version really matters. The module version doesn't seem to be maintained and having much practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/qlge/qlge_main.c | 1

[PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
, it doesn't seem to have any practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/accessibility/speakup/main.c | 1 - drivers/accessibility/speakup/speakup_acntpc.c | 1 - drivers/accessibility/speakup/speakup_acntsa.c | 1 - drivers/accessibility/speakup/speakup_apollo.c | 2

[PATCH 10/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
really matters. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8192u/r8192U_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 27dc181c4c9b..da871f45042a 100644 --- a/drivers/staging/rtl8192u

[PATCH 08/11] drivers: staging: rtl8188eu: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters most. The driver received lots of changes, while module version remained constant, since it landed in mainline, back 7 years ago. Signed-off-by: Enrico Weigelt

[PATCH 03/11] drivers: staging: gdm724x: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/gdm724x/gdm_lte.h | 1 - drivers/staging/gdm724x/gdm_usb.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h index f2143a6e0e99..bf6478ab05dd 100644

[PATCH 05/11] drivers: staging: media: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/media/omap4iss/iss.c | 1 - drivers/staging/media/omap4iss/iss_video.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index e06ea7ea1e50..dae9073e7d3c

[PATCH] drivers: usb: storage: prefer pr_*() macros over bare printk()

2020-12-03 Thread Enrico Weigelt, metux IT consult
pr_*() printing helpers are preferred over using bare printk(). Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/usb/storage/alauda.c | 23 drivers/usb/storage/ene_ub6250.c | 20 - drivers/usb/storage/freecom.c| 2 +- drivers/usb/storage

[PATCH v2] drivers: usb: storage: prefer pr_*() macros over bare printk()

2020-12-03 Thread Enrico Weigelt, metux IT consult
pr_*() printing helpers are preferred over using bare printk(). changes v2: fixed ugly typo Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/usb/storage/alauda.c | 23 drivers/usb/storage/ene_ub6250.c | 20 - drivers/usb/storage/freecom.c

[PATCH] drivers: usb: core: prefer pr_*() macros over bare printk()

2020-12-03 Thread Enrico Weigelt, metux IT consult
pr_*() printing helpers are preferred over using bare printk(). Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/usb/core/devio.c | 10 +- drivers/usb/core/file.c | 5 ++--- drivers/usb/core/hcd.c | 2 +- drivers/usb/core/hub.c | 2 +- drivers/usb/core/sysfs.c | 2

[PATCH v2] drivers: clk: make gpio-gated clock support optional

2020-12-03 Thread Enrico Weigelt, metux IT consult
The gpio-gate-clock / gpio-mux-clock driver isn't used much, just by a few ARM SoCs, so there's no need to always include it unconditionally. Thus make it optional, but keep it enabled by default. changes v2: fixed meanwhile removed '---help---' Signed-off-by: Enrico Weigelt, metux IT consult

Re: [PATCH] (v2) drivers: clk: make gpio-gated clock support optional

2020-12-03 Thread Enrico Weigelt, metux IT consult
On 18.11.20 02:42, Stephen Boyd wrote: > Quoting Enrico Weigelt, metux IT consult (2020-11-17 08:03:06) >> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig >> index c715d4681a0b..99e0188a15be 100644 >> --- a/drivers/clk/Kconfig >> +++ b/drivers/clk/Kconfig >&

[PATCH] drivers: acpi: add opt-out of Apple-specific property parsing

2020-12-03 Thread Enrico Weigelt, metux IT consult
Most x86 machines aren't Apple machines, especially VMs. Therefore allow opt-out, making the kernel a few KBs smaller, eg. for embedded or high-density VMs. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/acpi/Kconfig| 9 + drivers/acpi/Makefile | 2 +- drivers/acpi

Re: [PATCH v2] drivers: acpi: add opt-out of apple-specific property parsing

2020-12-03 Thread Enrico Weigelt, metux IT consult
d, 74kb unstripped. --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

[PATCH 1/3] drivers: gpio: bt8xx: prefer dev_err()/dev_warn() over of raw printk

2020-12-03 Thread Enrico Weigelt, metux IT consult
For logging in device contexts, dev_*() functions are preferred over raw printk(), which also print out device name. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-bt8xx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH 3/3] drivers: gpio: amd8111: use SPDX-License-Identifier

2020-12-03 Thread Enrico Weigelt, metux IT consult
Prefer SPDX-License-Identifier over hand-written texts. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-amd8111.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c index 0e260950992d

[PATCH 2/3] drivers: gpio: amd8111: prefer dev_err()/dev_info() over raw printk

2020-12-03 Thread Enrico Weigelt, metux IT consult
For logging in device contexts, dev_*() functions are preferred over raw printk(), which also print out device name. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-amd8111.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH] drivers: gpio: put virtual gpio device into their own submenu

2020-12-03 Thread Enrico Weigelt, metux IT consult
Since we already have a few virtual gpio devices, and more to come, this category deserves its own submenu. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index

Re: [PATCH] drivers: gpio: add virtio-gpio guest driver

2020-12-03 Thread Enrico Weigelt, metux IT consult
uest= virtio_gpio_request; >> + priv->gc.direction_input= virtio_gpio_direction_input; >> + priv->gc.direction_output = virtio_gpio_direction_output; >> + priv->gc.get_direction = virtio_gpio_get_direction; >> + priv->gc.get= virtio_gpio_get; >> + priv->gc.set= virtio_gpio_set; >> + >> + priv->vdev = vdev; >> + vdev->priv = priv; >> + >> + priv->irq_base = devm_irq_alloc_descs(dev, -1, 0, priv->num_gpios, >> + NUMA_NO_NODE); >> + if (priv->irq_base < 0) { >> + dev_err(>dev, "failed to alloc irqs\n"); >> + priv->irq_base = -1; >> + return -ENOMEM; >> + } >> + >> + init_waitqueue_head(>waitq); >> + >> + priv->reply_wait = 0; >> + >> + virtio_gpio_alloc_vq(priv); >> + >> + return devm_gpiochip_add_data(dev, >gc, priv); >> +} > > I don't know virtio at all - Michael: could you take a look at the > code here and see if it looks good to you? > >> + >> +static void virtio_gpio_remove(struct virtio_device *vdev) >> +{ >> +} > > Just don't implement it. Or does virtio actually require the remove() > callback? yes, it does, unfortunately -- see: virtio_dev_remove() I'll propose a patch for virtio for fixing that. --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH] drivers: gpio: add virtio-gpio guest driver

2020-12-03 Thread Enrico Weigelt, metux IT consult
On 27.11.20 19:45, Randy Dunlap wrote: > On 11/27/20 10:30 AM, Enrico Weigelt, metux IT consult wrote: >> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig >> index 5d4de5cd6759..e8414d82cf75 100644 >> --- a/drivers/gpio/Kconfig >> +++ b/drivers/gpio/Kconfig >&

[PATCH v2 1/2] drivers: gpio: put virtual gpio device into their own submenu

2020-12-03 Thread Enrico Weigelt, metux IT consult
Since we already have a few virtual gpio devices, and more to come, this category deserves its own submenu. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index

[PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-03 Thread Enrico Weigelt, metux IT consult
* fixed formatting * fixed unneeded devm allocation - plain kzalloc/kfree is enough * fixed missing devm_kzalloc fail check * use devm_kcalloc() for array allocation * added virtio-gpio protocol specification Signed-off-by: Enrico Weigelt, metux IT consult --- Documentation

Re: [PATCH] drivers: gpio: add virtio-gpio guest driver

2020-12-03 Thread Enrico Weigelt, metux IT consult
On 29.11.20 23:10, Jonathan Neuschäfer wrote: > Hi, > > On Fri, Nov 27, 2020 at 07:30:03PM +0100, Enrico Weigelt, metux IT consult wrote: >> Introducing new gpio driver for virtual GPIO devices via virtio. >> >> The driver allows routing gpio control into VM guests, eg

Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI_PTR() macros

2020-11-27 Thread Enrico Weigelt, metux IT consult
r eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

[PATCH] drivers: gpio: add virtio-gpio guest driver

2020-11-27 Thread Enrico Weigelt, metux IT consult
Introducing new gpio driver for virtual GPIO devices via virtio. The driver allows routing gpio control into VM guests, eg. brigding virtual gpios to specific host gpios, or attaching simulators for automatic application testing. Signed-off-by: Enrico Weigelt, metux IT consult --- MAINTAINERS

Re: [PATCH v1 1/2] vsprintf: introduce %dE for error constants

2019-08-26 Thread Enrico Weigelt, metux IT consult
E(errorcodes); ++i) { > +if (num == errorcodes[i].err || num == -errorcodes[i].err) { why not taking the abs value only once, instead of duplicate comp on each iteration ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux

[PATCH v2] Makefile: rules for printing kernel architecture and localversion

2019-07-29 Thread Enrico Weigelt, metux IT consult
trivial rule to print out the kernel arch and localversion, so external tools, like distro packagers, can easily get it. v2: add help text Signed-off-by: Enrico Weigelt, metux IT consult --- Makefile | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Makefile b/Makefile index

[PATCH] platform/x86/pcengines-apuv2: add mpcie reset gpio export

2019-07-31 Thread Enrico Weigelt, metux IT consult
Acked-By: Enrico Weigelt Author: Florian Eckert --- drivers/platform/x86/pcengines-apuv2.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c index e4c68ef..56703656 100644 --- a/drivers/platform/x86/pcengines

Re: [PATCH v5 0/3] Enable ACPI-defined peripherals on i2c-piix4 SMBus

2019-08-19 Thread Enrico Weigelt, metux IT consult
. but just lacking time to get my hands dirty on this topic. You might find it helpful to look at the coreboot source for the APU2 (src/mainboard/pcengines/apu2/gpio_ftns.h) In which version ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net

[PATCH] platform: x86: pcengines-apuv2: detect apuv4 board

2019-08-20 Thread Enrico Weigelt, metux IT consult
GPIO stuff on APUv4 seems to be the same as on APUv2, so we just need to match on DMI data. Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe --- drivers/platform/x86/pcengines-apuv2.c | 27 +++ 1 file changed, 27 insertions(+) diff --git

RFC: is SIM connector switch a case for pinmux ?

2019-08-20 Thread Enrico Weigelt, metux IT consult
another subsystem is the optimal solution here. What's your oppinion on that ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH v5 0/3] Enable ACPI-defined peripherals on i2c-piix4 SMBus

2019-08-20 Thread Enrico Weigelt, metux IT consult
on board vendors to do that right and cope w/ old and incomplete firmware. (that's also the reason why I'm *not* using acpi gpio entries for the apu2+ board family). --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

[PATCH 2/2] drivers: input: mouse: alps: drop unneeded likely() call around IS_ERR()

2019-08-20 Thread Enrico Weigelt, metux IT consult
From: Enrico Weigelt IS_ERR() already calls unlikely(), so this extra unlikely() call around IS_ERR() is not needed. Signed-off-by: Enrico Weigelt --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input

[PATCH 1/2] fs: ntfs: drop unneeded likely() call around IS_ERR()

2019-08-20 Thread Enrico Weigelt, metux IT consult
From: Enrico Weigelt IS_ERR() already calls unlikely(), so this extra likely() call around the !IS_ERR() is not needed. Signed-off-by: Enrico Weigelt --- fs/ntfs/mft.c | 8 fs/ntfs/namei.c | 2 +- fs/ntfs/runlist.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH] input: misc: soc_button_array: use platform_device_register_resndata()

2019-08-20 Thread Enrico Weigelt, metux IT consult
rror' value here this goto will result in the function returning 0 even if platform_device_register_resndata() failed. Uh, thanks. IMHO it's even worse: 'error' could be uninitialized. I'm sending v2 separately. Thanks for your review. --mtx -- Enrico Weigelt, metux IT consult Free software and Li

[PATCH v2] input: misc: soc_button_array: use platform_device_register_resndata()

2019-08-20 Thread Enrico Weigelt, metux IT consult
From: Enrico Weigelt The registration of gpio-keys device can be written much shorter by using the platform_device_register_resndata() helper. v2: * pass >dev to platform_device_register_resndata() * fixed errval on failed platform_device_register_resndata() Signed-off-by: Enr

Re: [PATCH 2/2] drivers: input: mouse: alps: drop unneeded likely() call around IS_ERR()

2019-08-20 Thread Enrico Weigelt, metux IT consult
On 20.08.19 13:17, Pali Rohár wrote: On Tuesday 20 August 2019 12:56:12 Enrico Weigelt, metux IT consult wrote: From: Enrico Weigelt IS_ERR() already calls unlikely(), so this extra unlikely() call around IS_ERR() is not needed. Signed-off-by: Enrico Weigelt --- drivers/input/mouse/alps.c

[PATCH v2] (submitted) input: misc: soc_button_array: use platform_device_register_resndata()

2019-08-20 Thread Enrico Weigelt, metux IT consult
From: Enrico Weigelt The registration of gpio-keys device can be written much shorter by using the platform_device_register_resndata() helper. v2: * pass >dev to platform_device_register_resndata() * fixed errval on failed platform_device_register_resndata() Signed-off-by: Enr

[PATCH 8/9] drivers: ata: sata_gemini: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/sata_gemini.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/ata/sata_gemini.c b/drivers

[PATCH 1/9] drivers: ata: ahci_octeon: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/ahci_octeon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata

[PATCH 9/9] drivers: ata: sata_rcar: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/sata_rcar.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ata/sata_rcar.c b/drivers/ata

[PATCH 7/9] drivers: ata: sata_dwc_460ex: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/sata_dwc_460ex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers

[PATCH 5/9] drivers: ata: libahci_platform: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/libahci_platform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ata/libahci_platform.c b

[PATCH 4/9] drivers: ata: ahci_xgene: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/ahci_xgene.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/ata

[PATCH 6/9] drivers: ata: pata_bk3710: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/pata_bk3710.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/ata/pata_bk3710.c b/drivers/ata

[PATCH 2/9] drivers: ata: ahci_seattle: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/ahci_seattle.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ata/ahci_seattle.c b/drivers/ata

[PATCH 3/9] drivers: ata: ahci_tegra: use devm_platform_ioremap_resource()

2019-08-20 Thread Enrico Weigelt, metux IT consult
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/ata/ahci_tegra.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/ata/ahci_tegra.c b

Re: [PATCH 2/2] drivers: input: mouse: alps: drop unneeded likely() call around IS_ERR()

2019-08-21 Thread Enrico Weigelt, metux IT consult
) for stating/documenting such cases ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: Status of Subsystems

2019-08-21 Thread Enrico Weigelt, metux IT consult
g such documentation, if the individual maintainers feed me the necessary information ;-)). --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH v5 0/3] Enable ACPI-defined peripherals on i2c-piix4 SMBus

2019-08-08 Thread Enrico Weigelt, metux IT consult
documentation in the kernel tree (maybe Documentation/hardware/...) - do you folks think that's a good idea ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: Merge branch 'floppy'

2019-08-08 Thread Enrico Weigelt, metux IT consult
be working. If anyone's interested in the HW, just let me know. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH RFC] modpost: Support I2C Aliases from OF tables

2019-08-08 Thread Enrico Weigelt, metux IT consult
proposed table changes ... does that require userland upgrades ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH RFC] modpost: Support I2C Aliases from OF tables

2019-08-08 Thread Enrico Weigelt, metux IT consult
On 08.08.19 15:24, Andy Shevchenko wrote: On Thu, Aug 08, 2019 at 03:12:47PM +0200, Enrico Weigelt, metux IT consult wrote: On 06.08.19 19:12, Javier Martinez Canillas wrote: Right, we could add a macro for that. Although it should probably be called I2C_OF_MODULE_DEVICE_TABLE() or something

Re: Device to write to all (serial) consoles

2019-08-08 Thread Enrico Weigelt, metux IT consult
On 02.08.19 15:23, Paul Menzel wrote: Does a device exist, or can a device be configured so you can write to all (serial) consoles from user space? Why not just writing a little program that listens on a pipe or a pty and writes out everything to all the tty's you want ? --mtx -- Enrico

Re: [PATCH] sched/topology: One function call less in build_group_from_child_sched_domain()

2019-07-08 Thread Enrico Weigelt, metux IT consult
_span(sd->child ? sd->child : sd)); > > At runtime, Are we avoiding a function call? > However I think we are avoiding a branch instead of a conditional, which may > be beneficial. If you're assuming the compiler doesn't already optimize that (no idea whether gcc really does th

Re: [PATCH] mfd: asic3: One function call less in asic3_irq_probe()

2019-07-08 Thread Enrico Weigelt, metux IT consult
eptable output (unless the individual maintainer doing it himself). --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH] platform/x86: Fix PCENGINES_APU2 Kconfig warning

2019-07-08 Thread Enrico Weigelt, metux IT consult
olib in a way that pieces directly needed by gpio consumers or drivers (hmm, perhaps have separate dependency symbols for consumer vs driver) can be selected directly, even if the big gpio subsystem knob is disabled ? (but the other things like userland interfaces would remain disabled) ? OTOH,

Re: mfd: asic3: One function call less in asic3_irq_probe()

2019-07-08 Thread Enrico Weigelt, metux IT consult
sonal perception plays a big role here. We can't deduce it by pure logic. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition

2019-07-08 Thread Enrico Weigelt, metux IT consult
ield, before I can give my ack. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH 0/3] Update pcengines-apuv2 platform device

2019-07-08 Thread Enrico Weigelt, metux IT consult
se and is not recommend for > new design (deprecated) > https://pcengines.ch/alix.htm And it's an entirely different chipset, not related at all to apu. > I think we should leave the driver as it is because this is a different > design and has nothing to do with the PUs. Yes. --mtx

Re: [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions

2019-07-08 Thread Enrico Weigelt, metux IT consult
t;/sys/class/leds" and could not be configured. How so ? (I'm using exactly that all the day ...) --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH 1/3] platform/x86/pcengines-apuv2: add mpcie reset gpio export

2019-07-08 Thread Enrico Weigelt, metux IT consult
in. Are you sure they're also available on APUv2 (not just v3) ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH 0/3] Update pcengines-apuv2 platform device

2019-07-08 Thread Enrico Weigelt, metux IT consult
iously > upstreamed: > > drivers/leds/leds-apu.c Only supports the three front LEDs, nothing else. (we've got more gpios that are not LEDs, eg. the front button, simsw, ...) > arch/x86/platform/geode/alix.c completely unrelated - very different chipset. --mtx -- Enrico Weigelt, metu

[PATCH 3/4] scripts: checkpatch.pl: don't complain that debian/rules is executable

2019-07-09 Thread Enrico Weigelt, metux IT consult
checkpatch.pl complains when adding executable "debian/rules", obviously a false alarm. Therefore add an exception for that. Signed-off-by: Enrico Weigelt, metux IT consult --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl

[PATCH 2/4] scripts: mkdebian: allow renaming generated debian/rules via env

2019-07-09 Thread Enrico Weigelt, metux IT consult
Add new environment variable KDEB_RULES for controlling where the generated debian rules are written to. By defaults, it's debian/rules, but packagers might override it for providing their own rules file. Signed-off-by: Enrico Weigelt, metux IT consult --- scripts/package/mkdebian | 5 - 1

[PATCH 4/4] debian: add generic rule file

2019-07-09 Thread Enrico Weigelt, metux IT consult
- this is done similar to the 'deb-pkg' make rule, scripts/packaging/mkdebian. Signed-off-by: Enrico Weigelt, metux IT consult --- .gitignore | 1 + MAINTAINERS | 6 ++ debian/rules | 27 +++ 3 files changed, 34 insertions(+) create mode 100755 debian/rules diff --git

[PATCH 1/4] Makefile: rules for printing kernel architecture and localversion

2019-07-09 Thread Enrico Weigelt, metux IT consult
trivial rule to print out the kernel arch and localversion, so external tools, like distro packagers, can easily get it. Signed-off-by: Enrico Weigelt, metux IT consult --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 3e4868a..5afc3de 100644

Re: [PATCH v4] builddeb: generate multi-arch friendly linux-libc-dev package

2019-07-09 Thread Enrico Weigelt, metux IT consult
build process :) I'll give it some test cycles. thx. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: Warnings whilst building 5.2.0+

2019-07-09 Thread Enrico Weigelt, metux IT consult
atus, 0, > | ^~~ >44 | (char *)_params->hdr - > | ~~~ >45 | (char *)_params->kbd_status); > | ~~~~~~~~~ Can you check older versions, too

Re: [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions

2019-07-10 Thread Enrico Weigelt, metux IT consult
gpiod_lookup_table. > If I add the change to the pcengines-apuv2 device then the LEDs will be > visilbe under "/sys/class/leds" > and could be used, by OpenWrt userland. > > Mybe I miss something. Your patch is only valid for your backport onto this old kernel, not

Re: [PATCH] gpio: don't WARN() on NULL descs if gpiolib is disabled

2019-07-10 Thread Enrico Weigelt, metux IT consult
or drivers selectable w/o having the gpio subsystem enabled first ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH -next] x86: apuv2: Make two symbols static

2019-05-31 Thread Enrico Weigelt, metux IT consult
", > .table = { > GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_MODESW, > thanks. Acked-By: Enrico Weigelt, metux IT consult --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

How to inject fwnode/oftree/acpi data by platform driver ?

2019-06-01 Thread Enrico Weigelt, metux IT consult
magic all the rest under the hood. Such thing doesn't seem to exist yet. Does it make sense to implement that ? How could we do it ? Which other options do we have ? Or should we just leave everything as it is and stick w/ pdata structs ? thx --mtx -- Enrico Weigelt, metux IT consult Free

[PATCH] include: linux: gpio: fix build warnings on undefined struct pinctrl_dev

2019-06-13 Thread Enrico Weigelt, metux IT consult
From: Enrico Weigelt This fixes the warnings: * include/linux/gpio.h:254:11: warning: 'struct pinctrl_dev' declared inside parameter list will not be visible outside of this definition or declaration * include/linux/gpio/driver.h:602:11: warning: 'struct pinctrl_dev' declared inside

Re: [PATCH 1/2] pinctrl: remove unneeded #ifdef around declarations

2019-06-14 Thread Enrico Weigelt, metux IT consult
able cpu power, a kernel build can take a while, and it could be a huge waste of time when having to wait for link stage, just to find out about missing functions. @linus: what's your oppinion ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH] RDMA/ucma: Use struct_size() helper

2019-06-14 Thread Enrico Weigelt, metux IT consult
milar patches that also affected things like kzalloc(). Maybe for those it would be better candidates for putting everything into its own helper macro ? (I've already got that on my 2do list, but not sure whether maintainers really like to be bothered with those kind of patches ;-)). --mtx --

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Enrico Weigelt, metux IT consult
already have a maillist ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Enrico Weigelt, metux IT consult
On 14.06.19 16:20, Enrico Weigelt, metux IT consult wrote: Currently working through your branches. Smells like they really deserve a rebase and signed-off lines. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Enrico Weigelt, metux IT consult
On 14.06.19 17:45, Enrico Weigelt, metux IT consult wrote: > On 14.06.19 16:20, Enrico Weigelt, metux IT consult wrote: > > > > Currently working through your branches. Smells like they really deserve > a rebase and signed-off lines. rebased/applied your patches and got tes

Re: [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition

2019-07-23 Thread Enrico Weigelt, metux IT consult
On 23.07.19 09:06, Florian Eckert wrote: I'd like to ack only the keycode change, but not the deprecated .gpio field. I'll post a separate patch for the keycode change only. I am fine if we only change the keycode. Do I have to send a v2 patch set? already sent one. -- Enrico Weigelt

srvfs: file system for posting open file descriptors into fs namespace

2020-08-07 Thread Enrico Weigelt, metux IT consult
ll convert it to patches, once it reached a stable state. https://github.com/metux/linux-srvfs-oot Some quick background pointers on how it works on Plan9: http://man.cat-v.org/plan_9/4/exportfs https://9fans.github.io/plan9port/man/man3/dial.html have fun, -- Enrico Weigelt, metux IT c

Re: [Q] devicetree overlays

2020-08-07 Thread Enrico Weigelt, metux IT consult
- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: LPC 2020 Hackroom Session: summary and next steps for isolated user namespaces

2020-10-29 Thread Enrico Weigelt, metux IT consult
work > properly in on tmpfs. Or a fuse implementation of ext4 on top of a > file. At that point, we could run everything via 9P ... ;-) --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH 1/2] x86: Remove led/gpio setup from pcengines platform driver

2020-10-12 Thread Enrico Weigelt, metux IT consult
GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH 1/2] x86: Remove led/gpio setup from pcengines platform driver

2020-10-12 Thread Enrico Weigelt, metux IT consult
rivers. Gpio numbers are anything but stable. --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH] gpio: gpio-amd-fch: Fix typo on define of AMD_FCH_GPIO_REG_GPIO55_DEVSLP0

2020-10-12 Thread Enrico Weigelt, metux IT consult
Acked-by: Enrico Weigelt --mtx On 28.09.20 13:45, Andy Shevchenko wrote: > On Mon, Sep 28, 2020 at 1:33 PM Ed W wrote: >> >> Hi >> >> Could I get a final opinion (or signoff) on this patch please? >> >> The significant typo is the referenc

<    1   2   3   4   5   6   7   8   9   10   >