Introducing new gpio driver for virtual GPIO devices via virtio.
The driver allows routing gpio control into VM guests, eg. brigding
virtual gpios to specific host gpios, or attaching simulators for
automatic application testing.
Signed-off-by: Enrico Weigelt, metux IT consult
---
MAINTAINERS
E(errorcodes); ++i) { > +if
(num == errorcodes[i].err || num == -errorcodes[i].err) {
why not taking the abs value only once, instead of duplicate comp on
each iteration ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux
trivial rule to print out the kernel arch and localversion, so
external tools, like distro packagers, can easily get it.
v2: add help text
Signed-off-by: Enrico Weigelt, metux IT consult
---
Makefile | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Makefile b/Makefile
index
From: Florian Eckert
On APUx we have also mpcie2/mpcie3 reset pins. To make it possible to reset
the ports from the userspace, add the definition to this platform
device. The gpio can then be exported by the legancy gpio subsystem to
toggle the mpcie reset pin.
Signed-off-by: Florian Eckert
. but just lacking time to get my hands
dirty on this topic.
You might find it helpful to look at the coreboot source for the APU2
(src/mainboard/pcengines/apu2/gpio_ftns.h)
In which version ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net
GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
need to match on DMI data.
Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
---
drivers/platform/x86/pcengines-apuv2.c | 27 +++
1 file changed, 27 insertions(+)
diff --git
another subsystem is the optimal
solution here.
What's your oppinion on that ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
on board vendors to do that right and
cope w/ old and incomplete firmware. (that's also the reason why I'm
*not* using acpi gpio entries for the apu2+ board family).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
drivers/input/mouse/alps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/alps.c
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra likely() call
around the !IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
fs/ntfs/mft.c | 8
fs/ntfs/namei.c | 2 +-
fs/ntfs/runlist.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff
rror' value here this goto will result in the
function returning 0 even if platform_device_register_resndata() failed.
Uh, thanks. IMHO it's even worse: 'error' could be uninitialized.
I'm sending v2 separately.
Thanks for your review.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Li
From: Enrico Weigelt
The registration of gpio-keys device can be written much shorter
by using the platform_device_register_resndata() helper.
v2:
* pass >dev to platform_device_register_resndata()
* fixed errval on failed platform_device_register_resndata()
Signed-off-by: Enrico
On 20.08.19 13:17, Pali Rohár wrote:
On Tuesday 20 August 2019 12:56:12 Enrico Weigelt, metux IT consult wrote:
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
drivers/input/mouse/alps.c
From: Enrico Weigelt
The registration of gpio-keys device can be written much shorter
by using the platform_device_register_resndata() helper.
v2:
* pass >dev to platform_device_register_resndata()
* fixed errval on failed platform_device_register_resndata()
Signed-off-by: Enrico
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/sata_gemini.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/ata/sata_gemini.c b/drivers
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_octeon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/sata_rcar.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/sata_dwc_460ex.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/libahci_platform.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ata/libahci_platform.c b
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_xgene.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/pata_bk3710.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/ata/pata_bk3710.c b/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_seattle.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ata/ahci_seattle.c b/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_tegra.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/ata/ahci_tegra.c b
) for stating/documenting such cases ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
g such documentation, if the individual
maintainers feed me the necessary information ;-)).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
documentation in the
kernel tree (maybe Documentation/hardware/...) - do you folks think
that's a good idea ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
be working.
If anyone's interested in the HW, just let me know.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
proposed table changes ... does that require userland upgrades ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 08.08.19 15:24, Andy Shevchenko wrote:
On Thu, Aug 08, 2019 at 03:12:47PM +0200, Enrico Weigelt, metux IT consult
wrote:
On 06.08.19 19:12, Javier Martinez Canillas wrote:
Right, we could add a macro for that. Although it should probably be called
I2C_OF_MODULE_DEVICE_TABLE() or something
Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
_span(sd->child ? sd->child : sd));
>
> At runtime, Are we avoiding a function call?
> However I think we are avoiding a branch instead of a conditional, which may
> be beneficial.
If you're assuming the compiler doesn't already optimize that (no idea
whether gcc really does th
eptable output (unless the
individual maintainer doing it himself).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
olib in a way that pieces directly
needed by gpio consumers or drivers (hmm, perhaps have separate
dependency symbols for consumer vs driver) can be selected directly,
even if the big gpio subsystem knob is disabled ? (but the other things
like userland interfaces would remain disabled) ?
OTOH,
sonal perception plays a big role
here. We can't deduce it by pure logic.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
ield, before I can give my ack.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
se and is not recommend for
> new design (deprecated)
> https://pcengines.ch/alix.htm
And it's an entirely different chipset, not related at all to apu.
> I think we should leave the driver as it is because this is a different
> design and has nothing to do with the PUs.
Yes.
--mtx
t;/sys/class/leds" and could not be configured.
How so ? (I'm using exactly that all the day ...)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
in.
Are you sure they're also available on APUv2 (not just v3) ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
iously
> upstreamed:
>
> drivers/leds/leds-apu.c
Only supports the three front LEDs, nothing else. (we've got more gpios
that are not LEDs, eg. the front button, simsw, ...)
> arch/x86/platform/geode/alix.c
completely unrelated - very different chipset.
--mtx
--
Enrico Weigelt, metu
checkpatch.pl complains when adding executable "debian/rules",
obviously a false alarm. Therefore add an exception for that.
Signed-off-by: Enrico Weigelt, metux IT consult
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl
Add new environment variable KDEB_RULES for controlling where the
generated debian rules are written to. By defaults, it's debian/rules,
but packagers might override it for providing their own rules file.
Signed-off-by: Enrico Weigelt, metux IT consult
---
scripts/package/mkdebian | 5 -
1
- this is done similar to the 'deb-pkg' make rule,
scripts/packaging/mkdebian.
Signed-off-by: Enrico Weigelt, metux IT consult
---
.gitignore | 1 +
MAINTAINERS | 6 ++
debian/rules | 27 +++
3 files changed, 34 insertions(+)
create mode 100755 debian/rules
diff --git
trivial rule to print out the kernel arch and localversion, so
external tools, like distro packagers, can easily get it.
Signed-off-by: Enrico Weigelt, metux IT consult
---
Makefile | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index 3e4868a..5afc3de 100644
build process :)
I'll give it some test cycles.
thx.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
atus, 0,
> | ^~~
>44 | (char *)_params->hdr -
> | ~~~
>45 | (char *)_params->kbd_status);
> | ~~~~~~~~~
Can you check older versions, too
gpiod_lookup_table.
> If I add the change to the pcengines-apuv2 device then the LEDs will be
> visilbe under "/sys/class/leds"
> and could be used, by OpenWrt userland.
>
> Mybe I miss something.
Your patch is only valid for your backport onto this old kernel, not
or drivers selectable w/o
having the gpio subsystem enabled first ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
",
> .table = {
> GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_MODESW,
>
thanks.
Acked-By: Enrico Weigelt, metux IT consult
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
magic all the rest under the hood. Such thing doesn't
seem to exist yet. Does it make sense to implement that ? How could
we do it ?
Which other options do we have ?
Or should we just leave everything as it is and stick w/ pdata structs ?
thx
--mtx
--
Enrico Weigelt, metux IT consult
Free
From: Enrico Weigelt
This fixes the warnings:
* include/linux/gpio.h:254:11: warning: 'struct pinctrl_dev' declared
inside parameter list will not be visible outside of this definition
or declaration
* include/linux/gpio/driver.h:602:11: warning: 'struct pinctrl_dev'
declared inside
able cpu power, a kernel build can
take a while, and it could be a huge waste of time when having to
wait for link stage, just to find out about missing functions.
@linus: what's your oppinion ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
milar patches that also affected things like kzalloc().
Maybe for those it would be better candidates for putting everything
into its own helper macro ? (I've already got that on my 2do list, but
not sure whether maintainers really like to be bothered with those
kind of patches ;-)).
--mtx
--
already have a maillist ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 14.06.19 16:20, Enrico Weigelt, metux IT consult wrote:
Currently working through your branches. Smells like they really deserve
a rebase and signed-off lines.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 14.06.19 17:45, Enrico Weigelt, metux IT consult wrote:
> On 14.06.19 16:20, Enrico Weigelt, metux IT consult wrote:
>
>
>
> Currently working through your branches. Smells like they really deserve
> a rebase and signed-off lines.
rebased/applied your patches and got tes
On 23.07.19 09:06, Florian Eckert wrote:
I'd like to ack only the keycode change, but not the deprecated .gpio
field. I'll post a separate patch for the keycode change only.
I am fine if we only change the keycode.
Do I have to send a v2 patch set?
already sent one.
--
Enrico Weigelt
ll convert it to patches,
once it reached a stable state.
https://github.com/metux/linux-srvfs-oot
Some quick background pointers on how it works on Plan9:
http://man.cat-v.org/plan_9/4/exportfs
https://9fans.github.io/plan9port/man/man3/dial.html
have fun,
--
Enrico Weigelt, metux IT c
-
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
work
> properly in on tmpfs. Or a fuse implementation of ext4 on top of a
> file.
At that point, we could run everything via 9P ... ;-)
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
rivers.
Gpio numbers are anything but stable.
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
/gpio-amd-fch.h
>>>>> index 9e46678ed..255d51c9d 100644
>>>>> --- a/include/linux/platform_data/gpio/gpio-amd-fch.h
>>>>> +++ b/include/linux/platform_data/gpio/gpio-amd-fch.h
>>>>> @@ -19,7 +19,7 @@
>>>>> #define AMD_FCH_GPIO_REG_GPIO49
Hi folks,
the legacy apu LEDs driver has been superseded by the more complete
pcengines-apu2 platform driver, for APU >= 2. It only supports
the three front LEDs, but lacks all the other GPIOs (eg. button
or simsw), and conflicts with the pcengines-apu2 driver.
Old APUv1 has a very different
From: Enrico Weigelt
As this driver now only supports the APU1 boards, we don't need
to differenciate between board types anymore. Therefore optimize
away the now obsolete code.
Signed-off-by: Enrico Weigelt
---
drivers/leds/leds-apu.c | 12 ++--
1 file changed, 2 insertions(+), 10
From: Enrico Weigelt
As this driver now only supports the APU1 boards, we don't need
to handle different io sizes anymore.
Signed-off-by: Enrico Weigelt
---
drivers/leds/leds-apu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-apu.c
From: Enrico Weigelt
This driver only supports gpio-attached LEDs on apu1/2/3 boards,
but neither gpio's themselves, nor other gpio-attached devices
(eg. front button).
For apu2+ a newer, more complete driver exists, based on a generic
driver for the AMD SOCs gpio-controller, supporting LEDs as
From: Enrico Weigelt
Define pr_fmt() macro for prefixing the module name to all
pr_*() outputs, in order to increase log message clarity.
Signed-off-by: Enrico Weigelt
---
drivers/leds/leds-apu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/leds/leds-apu.c
From: Enrico Weigelt
As this driver now only supports the APU1 boards, we don't need
to handle profiles anymore and just can use the only one global
array directly.
Signed-off-by: Enrico Weigelt
---
drivers/leds/leds-apu.c | 19 +++
1 file changed, 7 insertions(+), 12
From: Enrico Weigelt
The current error message on failed probing tends to be a bit
misleading. Fix it to tell exactly that an APU v1 was not found.
Signed-off-by: Enrico Weigelt
---
drivers/leds/leds-apu.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
ations.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
modem doesn't appear ... I'll have to
check again whether i've got unstable hw or missing some kernel config.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
use Debian source packages with new
kernel trees, but had to give up after a few days. Then I've found out
that the kernel already has *almost* what I needed. The difference
between almost and fine is this patch queue (minus local .config files)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
uff, too.
> First, once it's checked in, I expect changes to the default
> debian/rules file will be relatively rare.
ACK. I currently don't see much reasons for future changes. If anybody
sees something missing, just let me know, and I'll take it up for the
next review round.
--mtx
-
been several
discussions on this matter, replying there should give the participants
an automatic mail.
So far, I haven't seen any distro that enabled the old driver, so I
guess the actual users all compiled the kernel on their own and should
notice the change early enough.
--mtx
--
Enrico We
e)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Hi folks,
is there any way for drivers to add aux data to user namespaces ?
I'm currently implementing plan9-like capabilities authentication,
and I'd like to keep this separate by user-ns.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net
rate from the actual drivers - they just
enable them automatically. Of course they'll have to be maintained by
the driver maintainers.
What do you think about this idea ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
From: "Enrico Weigelt, metux IT consult"
This driver implements the Plan9 capability devices, used for
switching user id via capability tokens.
https://9p.io/sys/doc/auth.html
---
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile| 1 +
drivers/staging/p9ca
v2 of the p9caps patch
From: "Enrico Weigelt, metux IT consult"
This driver implements the Plan9 capability devices, used for
switching user id via capability tokens.
https://9p.io/sys/doc/auth.html
---
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile| 1 +
drivers/staging/p9ca
On 11.07.19 15:01, Ywe Cærlyn wrote:
> I had the most brilliant idea - Fair Pay Project is now: Odén OS.
>
> Us norse always liked a bit faster OS.
What exactly do you wanna do differently ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engi
YBOARD_GPIO_POLLED if GPIOLIB
> select LEDS_GPIO
> help
> This driver provides support for the front button and LEDs on
That might compile but the driver won't work, if KEYBOARD_GPIO_POLLED
or GPIO_AMD_FCH isn't there.
--mtx
--
Enrico Weigelt, metux IT consult
Fre
r
point why I've decided to cope all of this in a separate tool.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
pin.
>
Just tested your patch on an apu3. The driver itself seems to work,
but the pins don't seem to actually do anything.
How exactly did you test it ? Do you have some test case ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 25.07.19 19:17, Andy Shevchenko wrote:
On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
wrote:
From: Enrico Weigelt
The keycode KEY_RESTART is more appropriate for the front button,
as most people use it for things like restart or factory reset.
Should it go as Fixes
On 25.07.19 20:57, Andy Shevchenko wrote:
On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
wrote:
On 25.07.19 19:17, Andy Shevchenko wrote:
On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
wrote:
From: Enrico Weigelt
The keycode KEY_RESTART is more
From: Enrico Weigelt
The keycode KEY_RESTART is more appropriate for the front button,
as most people use it for things like restart or factory reset.
Signed-off-by: Enrico Weigelt
Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2
gpio/leds/keys platform driver")
---
On 25.07.19 19:49, Andy Shevchenko wrote:
Hi,
On Wed, Jul 10, 2019 at 3:54 PM Florian Eckert wrote:
On 2019-07-08 21:45, Enrico Weigelt, metux IT consult wrote:
On 04.07.19 15:39, Andy Shevchenko wrote:
On Thu, Jul 4, 2019 at 12:02 PM Florian Eckert wrote:
This patchset adds
_pdata board_apu2 = {
Acked-by: Enrico Weigelt
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 07.06.19 02:41, James Bottomley wrote:
> On Thu, 2019-06-06 at 17:04 +0200, Enrico Weigelt, metux IT consult
> wrote:
>> From: Enrico Weigelt
>>
>> The MODULE_DEVICE_TABLE() macro already checks for MODULE defined,
>> so the extra check here is not necessary.
&
On 31.07.19 11:42, Andy Shevchenko wrote:
I'm not sure why you resend this, where is the changelog, where is the
version bump?..
I've just resent Florian's patch from my queue, as he didn't respond for
several days and I've already acked it.
--mtx
--
Enrico Weigelt, metux IT consult
Free
Hello folks,
I've seen a lot of drivers (eg. many arch specific board init code)
are still using raw gpio numbers, which AFAIK are deprecated.
Shall we start phasing them out and rewrite the corresponding drivers
to use match tables ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software
by mailing list,
but don't separate out stuff that's directly addressed to me - guess
I'll have to fix up my mail filter rules :o
Regarding your patch:
How should I now setup a proper swnode object and pass it to the
driver ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded
be kinda FAQ list.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
be one line lower and touch the comment instead of the
> EXPORT_SYMBOL() related to a different function.
Okay, that missing newline should be fixed (as well as the extra one
after the #ifdef). Besides that, I don't see any further problems.
--mtx
--
Enrico Weigelt, metux IT consult
Free software an
opefully not since we might probe later on if something registers a new
> device...
>
Common pitfall. Also fallen into this myself and wondered why
it oops'd :o.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 25.06.19 11:26, Linus Walleij wrote:
> On Mon, Jun 24, 2019 at 7:40 AM Enrico Weigelt, metux IT consult
> wrote:
>
>> From: Enrico Weigelt
>>
>> Add more helper macros for trivial driver init cases, similar to the
>> already existing module_platf
e bad news, the project already ran for several years
and nobody dared to restart board development. (in the meantime, long
after i've gone, they indeed create a new board w/ mx6).
Such things could easily prevented if people just wouldn't trust the
hw vendor at all and ask us (kernel hackers)
configure the gpio driver. Certainly, I would have
preferred doing everything via DT, but that's not available on x86/acpi
targets (if anybody knows a way to inject a DT snippet just for one
driver in such a scenario, please let me know).
--mtx
--
Enrico Weigelt, metux IT consult
Free software
-By: Enrico Weigelt
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
201 - 300 of 966 matches
Mail list logo
