From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra likely() call
around the !IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
net/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index 38eec15..963df5d 100644
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
net/sctp/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra likely() call
around the !IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
net/openvswitch/datapath.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/datapath.c
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
net/ipv4/fib_semantics.c | 2 +-
net/ipv4/inet_hashtables.c | 2 +-
net/ipv4/udp.c | 2 +-
net/ipv4/udp_offload.c | 2 +-
4
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
net/ipv6/inet6_hashtables.c | 2 +-
net/ipv6/udp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
fs/cifs/dfs_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
index
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra likely() call
around the !IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
fs/ntfs/mft.c | 8
fs/ntfs/namei.c | 2 +-
fs/ntfs/runlist.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra likely() call
around the !IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index
On 05.06.19 21:50, Marcelo Ricardo Leitner wrote:
On Wed, Jun 05, 2019 at 11:03:27PM +0200, Enrico Weigelt, metux IT consult
wrote:
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
Hi
On 05.06.19 21:52, Steve French wrote:
This duplicates a patch submitted earlier by Kefeng Wang
which I plan to merge later today into
cifs-2.6.git for-next
Great :)
Just ignore my patch.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net
On 05.06.19 21:23, Christoph Hellwig wrote:
> On Wed, Jun 05, 2019 at 01:36:25PM +0200, Enrico Weigelt, metux IT consult
> wrote:
>> Hello folks,
>>
>>
>> here's a patchset that allows enabling libata's tpm features (opal)
>> at runtime. Until now we need t
From: Enrico Weigelt
fix an uninitialized variable:
CC net/ipv4/fib_semantics.o
net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw':
net/ipv4/fib_semantics.c:1027:12: warning: 'err' may be used uninitialized in
this function [-Wmaybe-uninitialized]
if (!tbl || err) {
From: Enrico Weigelt
The MODULE_DEVICE_TABLE() macro already checks for MODULE defined,
so the extra check here is not necessary.
Changes v2:
* make dptids const to fix warning on unused variable
Signed-off-by: Enrico Weigelt
---
drivers/scsi/BusLogic.c | 2 --
drivers/scsi/dpt_i2o.c |
t the change is worth it, so would like you
>> to prove it is, unless davem overrides me. :-)
Depends on what you count as worthy ;-)
This patch just makes a source a bit more compact / easier to read.
But shouldn't have any actual consequence on the generated binary.
--mtx
--
Enr
On 06.06.19 17:47, David Ahern wrote:
>
> what compiler version?
>
> if tbl is set, then err is set.
>
gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
the board and then
instantiates the individual devices using classic pdata.
The gpio-keys-polled currently lacks support for specifying
input device name, which is fixed by this patch.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input
Hi,
this patch had already been sent a while ago, and a discussion arised
about whether pdata support should be dropped in favour of of/acpi.
Unfortunately, the open problems - lack of proper of/acpi data and sane
ways to inject this data - remain (theoretically, could be done by writing
special
From: Enrico Weigelt
Support the recently introduced gpio lookup tables for
attaching to gpio lines. So, harcoded gpio numbers aren't
needed anymore.
changes v3:
* fix printf string in gpio_keys_polled_get_gpiod()
* fix unused variable 'error' in gpio_keys_polled_get_gpiod()
* fix
optimize it away.
What's your oppinion on that ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 03.07.19 16:47, Greg KH wrote:
> On Wed, Jul 03, 2019 at 03:27:11PM +0200, Enrico Weigelt, metux IT consult
> wrote:
>>> /* UART Port Control Register */> -#define NI8430_PORTCON 0x0f> -#define
>>> NI8430_PORTCON_TXVR_ENABLE (1 << 3)
>> Can
Formatting of Kconfig files doesn't look so pretty, so let the
Great White Handkerchief come around and clean it up.
Also convert "---help---" as requested on lkml.
Signed-off-by: Enrico Weigelt, metux IT consult
---
arch/powerpc/Kconfig
system which didn't support it. Because of
> this, it seems you'd want *all* desirable configs and let a piece of
> software figure out what you need / can enable. And.. this is precisely
> where the SAT solver with MUSes could help...
Yes, but this piece of software first needs to know wheth
ll be opposed when these options are masked
behind CONFIG_EXPERT or CONFIG_EMBEDDED ? I can imagine this could be a
good compromise.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
there's a separate project for cleaning up
those things ?
maillist: linux-s...@vger.kernel.org
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
viewed-By: Enrico Weigelt
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
viewed-By: Enrico Weigelt
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
it and understand, what's the
actual problem you'd like to solve.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 26.07.19 16:56, Gerhard Wiesinger wrote:
Hello,
I saw that the apu4 board is completly missing (also on 5.3rc1). Can you
please add it. Should be very easy, see below.
Still in the pipeline - don't have an apu4 board for testing yet.
--mtx
--
Enrico Weigelt, metux IT consult
Free
From: Enrico Weigelt
The registration of gpio-keys device can be written much shorter
by using the platform_device_register_resndata() helper.
Signed-off-by: Enrico Weigelt
---
drivers/input/misc/soc_button_array.c | 24 ++--
1 file changed, 10 insertions(+), 14
From: Enrico Weigelt
When trying to export an nonexisting gpio ID, the kernel prints
outs a big warning w/ stacktrace, sounding like a huge problem.
In fact it's a pretty normal situation, like file or device not
found.
So, just print a more relaxed warning instead.
Signed-off-by: Enrico
From: Enrico Weigelt
The APU3+ boards have two SIM sockets, while only one of them
can be routed to the mpcie slots at a time. Selection is done
via simswap gpio.
We currently don't have a fitting subsystem for those cases yet,
so just wire it up to a LED for the time being. While this isn't
From: Enrico Weigelt
Reduce boilerplate by using generic implementation of the trivial
request_port/release_port operations. For that to work, we have to
set the mapsize field accordingly.
---
drivers/tty/serial/amba-pl011.c | 28 ++--
1 file changed, 6 insertions(+), 22
On 29.07.19 16:44, Enrico Weigelt, metux IT consult wrote:
From: Enrico Weigelt
Reduce boilerplate by using generic implementation of the trivial
request_port/release_port operations. For that to work, we have to
set the mapsize field accordingly.
Shit! Forget it. Somehow cherry-picked
From: Enrico Weigelt
Just make the indentions consistent with the rest of the file,
as well as most other Kconfig files.
Signed-off-by: Enrico Weigelt, metux IT consult
---
init/Kconfig | 54 +++---
1 file changed, 27 insertions(+), 27 deletions
Align the indentions to the common practise in Kconfig files,
make it look at little bit prettier. Just whitespace changes.
Signed-off-by: Enrico Weigelt
---
drivers/scsi/Kconfig | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/Kconfig
From: Enrico Weigelt
Explicitly return constants instead of variable (and rely on
it to be explicitly initialized), if the value is supposed
to be fixed anyways. Align it with the rest of the driver,
which does it the same way.
Signed-off-by: Enrico Weigelt
---
From: Enrico Weigelt
Support the recently introduced gpio lookup tables for
attaching to gpio lines. So, harcoded gpio numbers aren't
needed anymore.
changes v3:
* fix printf string in gpio_keys_polled_get_gpiod()
* fix unused variable 'error' in gpio_keys_polled_get_gpiod()
* fix
we don't need to build in oftree probing stuff when oftree isn't
enabled at all.
changes v2: use of_match_ptr() macro instead of ifdef's
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard/gpio_keys_polled.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion
should get rid of raw gpio IDs in
favour of gpiod lookup tables first.
I just recently re-posted patches for this, let's see if we can get them >
landed in the kernel.
Can you give me a pointer ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@
From: Enrico Weigelt
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt
---
net/sctp/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index
: a...@infradead.org
Cc: platform-driver-...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
MAINTAINERS| 5 +
drivers/platform/x86/Kconfig | 13 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/pcengines-apuv2.c | 259
device ? (which then could also maintain the base address, etc)
Note: the keyboard device needs separate patch for gpiod_lookup_table
support in gpio-keys-polled driver. I'll sent it separately.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i
: linux-g...@vger.kernel.org
Cc: linus.wall...@linaro.org
Cc: bgolaszew...@baylibre.com
Cc: dvh...@infradead.org
Cc: a...@infradead.org
Cc: platform-driver-...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
MAINTAINERS | 7 +
drivers/gpio
declare it's own bus and probe the individual devices by it's
own of subtree. Well, that's gonna take a lot more discussions ...
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Instead of hardcoding the input name to the driver name
('gpio-keys-polled'), allow the passing a name via platform data
('name' field was already present), but default to old behaviour
in case of NULL.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux
Hi folks,
here's v2 of my gpio-keys-polled enhancements queue.
I'm using this to allow it to be initialized by some other platform
driver (in my case for the APUv2 board), when no proper fw data
(oftree or acpi) is available.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux
Support the recently introduced gpio lookup tables for
attaching to gpio lines. So, harcoded gpio numbers aren't
needed anymore.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard/gpio_keys_polled.c | 167
ICs/SoCs, but i've seen such things
in some of my client's fpga designs. For example incomplete
decoders, gpios attached to internal state machines, etc, etc
So, I've learned to be *very* cautious with undocumented registers.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
struct resource res;
>> +int gpio_num;
>> +struct amd_fch_gpio_reg *gpio_reg;
>> +int gpio_base;
>> +};
>
> Drop gpio_base. We don't hardcode the GPIO base anymore.
Done. I had to patch gpio-keys-polled driver first.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
uot;gpio-keys-polled" in my case. I've just got one
instance of each right now and used PLATFORM_DEVID_NONE.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
't seem to have a corresponding flag :(
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 14.02.19 13:33, Andy Shevchenko wrote:
> It's there from several releases. But it's not a send-email option,
> it's format-patch one.
> send-email passes those commands to format-patch.
oh, wasn't aware of that.
thx.
--mtx
--
Enrico Weigelt, metux IT consult
Free software
: linux-g...@vger.kernel.org
Cc: linus.wall...@linaro.org
Cc: bgolaszew...@baylibre.com
Cc: dvh...@infradead.org
Cc: a...@infradead.org
Cc: platform-driver-...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
MAINTAINERS | 7 +
drivers/gpio
Hi folks,
this is version 3 of my APUv2/APUv3 series.
change in V3:
* gpio driver
* drop unncessary gpio id checks
* cleanup amd_fch_gpio_set()
* move iores outside probe()
* shorter NULL checks and correct error in probe()
* apu board driver
* drop unneeded init.h
* drop
: a...@infradead.org
Cc: platform-driver-...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
MAINTAINERS| 5 +
drivers/platform/x86/Kconfig | 12 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/pcengines-apuv2.c | 261
the
leds-gpio instance ?) and the gpio chip. In the example, these
seem to be autogenerated - how can I retrieve them from my
actual devices ?
By the way: does that also work with gpio-keys-polled ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
aybe the pin naming is just weird)
What I really don't want is undocumented registers or lines being
exposed as gpio somewhere (not knowing what they actually do).
Therefore, I'd like to add only those gpio registers that I can
confirm being safe - at least until I've managed to get more
information.
Instead of hardcoding the input name to the driver name
('gpio-keys-polled'), allow the passing a name via platform data
('name' field was already present), but default to old behaviour
in case of NULL.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard
trivial rule to print out the kernel arch and localversion, so
external tools, like distro packagers, can easily get it.
Signed-off-by: Enrico Weigelt, metux IT consult
---
Makefile | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index 86cf35d..68c3e08 100644
Add new environment variable KDEB_RULES for controlling where the
generated debian rules are written to. By defaults, it's debian/rules,
but packagers might override it for providing their own rules file.
Signed-off-by: Enrico Weigelt, metux IT consult
---
scripts/package/mkdebian | 5 -
1
We missed some build dependencies in the generated debian/control file.
Signed-off-by: Enrico Weigelt, metux IT consult
---
scripts/package/mkdebian | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index ff226be..1caaf0b
Hi folks,
here're some small patches for making mkdebian a bit more flexible, so it
can be used eg. with an given debian/rules file.
I'm using this along w/ local (adding debian/rules and .config) in order
to build the kernel via usual debian toolchains (git-buildpackage,
git-buildpackage, ...)
On 08.02.19 21:44, Joe Perches wrote:
> Warn when any SPDX-License-Identifier: tag is not created
> on the proper line number.
By the way: there are corner cases, which can't have it at the first
line, eg. scripts.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux em
order ?
thx
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 23.01.19 21:46, Ivan Ivanov wrote:
> Linux really needs to stop adding new features and
> refactor itself to a smaller and more secure codebase before going
> forward. Maybe 1 year break would be nice.
Do you have some actual proposals / patches ?
--mtx
--
Enrico Weigelt, metux I
Adding a generic debian rule file, so we can build the directly
via usual Debian package build tools (eg. git-buildpackage,
dck-buildpackage, etc). It expects the .config file already
placed in the source tree.
The rule file contains a rule for creating debian/control and
other metadata - this is
We missed some build dependencies in the generated debian/control file.
Signed-off-by: Enrico Weigelt, metux IT consult
---
scripts/package/mkdebian | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index ff226be..1caaf0b
Add new environment variable KDEB_RULES for controlling where the
generated debian rules are written to. By defaults, it's debian/rules,
but packagers might override it for providing their own rules file.
Signed-off-by: Enrico Weigelt, metux IT consult
---
scripts/package/mkdebian | 5 -
1
trivial rule to print out the kernel arch and localversion, so external tools,
like distro packagers, can easily get it.
Signed-off-by: Enrico Weigelt, metux IT consult
---
Makefile | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index 3142e67..2719907 100644
Hello folks,
here are some patches for build process that allow building debian packages
right the usual canonical way (eg. via dpkg-buildpackage or dck-buildpackage),
instead 'manually' setting up the build environment and calling make.
So, from a debian native perspective, turning it from head
Instead of hardcoding the input name to the driver name ('gpio-keys-polled'),
allow the passing a name via platform data ('name' field was already present),
but default to old behaviour in case of NULL.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard
Driver for PCengines APUv2 board that supports GPIOs via AMD PCH
and attached LEDs and keys.
Signed-off-by: Enrico Weigelt, metux IT consult
---
MAINTAINERS| 5 +
drivers/platform/x86/Kconfig | 9 ++
drivers/platform/x86/Makefile | 1
-off-by: Enrico Weigelt, metux IT consult
---
MAINTAINERS| 7 +
drivers/gpio/Kconfig | 10 ++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-amd-fch.c| 171
From: "Enrico Weigelt, metux IT consult"
Driver for PCengines APUv2 board that supports GPIOs via AMD PCH
and attached LEDs and keys.
Cc: linux-g...@vger.kernel.org
Cc: linus.wall...@linaro.org
Cc: bgolaszew...@baylibre.com
Cc: dvh...@infradead.org
Cc: a...@infradead.org
Cc: platf
From: "Enrico Weigelt, metux IT consult"
GPIO platform driver for the AMD G-series PCH (eg. on GX-412TC)
This driver doesn't registers itself automatically, as it needs to
be provided with platform specific configuration, provided by some
board driver setup code.
Didn't implem
dex
>> + * @name: signal name
>> + */
>> +struct amd_fch_gpio_reg {
>> +int reg;
>> +const char* name;
>> +};
>
> Isn't this provided by GPIO library? We have so called labels.
hmm, haven't found a proper struct yet.
struct gpio indeed has a label and two int fields. but it doesn't seem
to be designed for holding register addresses ... using this one here
feels quite abusive. (and a waste of memory, too).
for consistency, I could rename 'name' to 'label', if you wish.
thanks for your review.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
some
subsystem, similar to those for other bus'es (eg. pci, usb, ...) ?
Maybe that deserves a bit more documentation :p
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
sive security
hole) is disable suid for those processes (actually, one day i'd like to
get rid of it completely, but that's another story).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 15.04.19 21:59, Aleksa Sarai wrote:
> Just spit-balling -- is no_new_privs not sufficient for this usecase?> Not
> granting privileges such as setuid during execve(2) is the main>
point of that flag.
Oh, I wasn't aware of that. Thanks.
--mtx
--
Enrico Weigelt, metux IT
we handle things like cgroups ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
we don't need to build in oftree probing stuff when oftree isn't
enabled at all.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard/gpio_keys_polled.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/gpio_keys_polled.c
b
Instead of hardcoding the input name to the driver name
('gpio-keys-polled'), allow the passing a name via platform data
('name' field was already present), but default to old behaviour
in case of NULL.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux
Support the recently introduced gpio lookup tables for
attaching to gpio lines. So, harcoded gpio numbers aren't
needed anymore.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard/gpio_keys_polled.c | 167
Hello folks,
here're some improvements for the gpio-keys-polled driver.
The first patch isn't in the driver itself, but adds a little module helper
for conditionally declaring oftree module table if oftree is enabled
(only needed for the last patch)
have fun.
--mtx
Little helper macro that declares an oftree module device table,
if CONFIG_OF is enabled. Otherwise it's just noop.
This is also helpful if some drivers can be built w/ or w/o
oftree support.
Signed-off-by: Enrico Weigelt, metux IT consult
---
include/linux/mod_devicetable.h | 9 +
1
w down some limits and pass this to some other agent that
acts on behalf of him and is allowed to use his share of the system
resources for that.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
cess can define what the holder of the
fd can actually do.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Hello folks,
here're some fixes for libata to make NVME and TCG OPAL work:
* fix a little build break in nvme (forgotten include and Kconfig select)
* introduce sysctl knob for enabling tpm stuff at runtime
(sed-util expects since several years, so it seems that piece just might
have been
dealing just w/ a plain boolean value, that's
only checked when an tpm-related ioctl is called, we're fine w/ that.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/libata-core.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata
ing include to
2. SGL_ALLOC needs to be enabled
Therefore adding the missing include, as well as Kconfig dependency.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/nvme/target/Kconfig | 1 +
drivers/nvme/target/core.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/
Register a sysctl directory for libata, so upcoming knobs
can be added here.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/libata-core.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index adf2878
On 19.04.19 09:40, Dmitry Torokhov wrote:
> Hi Enrico,
>
> On Tue, Apr 16, 2019 at 09:57:22PM +0200, Enrico Weigelt, metux IT consult
> wrote:
>> Little helper macro that declares an oftree module device table,
>> if CONFIG_OF is enabled. Otherwise it's just noop.
&g
the generic solution will still take some time, so can we
take this one for the next merge window and rework it in the next one ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Little helper macro that declares an oftree module device table,
if CONFIG_OF is enabled. Otherwise it's just noop.
This is also helpful if some drivers can be built w/ or w/o
oftree support.
Signed-off-by: Enrico Weigelt, metux IT consult
---
include/linux/mod_devicetable.h | 9 +
1
be defined in asm/processor.h,>
> but proc_task_arch_status() has four parameters, I don't want
unnecessary> "struct pid_namespace *ns" and "struct pid *pid" leaked
into arch headers,> so I defined task_arch_status(m, task) to avoid that.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
gt; *ns,
>> + struct pid *pid, struct task_struct *task)
>> +{
>> +task_arch_status(m, task);
>> +return 0;
>> +}
Is that wrapper really neeeded ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
somebody who doesn't need
it, can just disable it.
(I, personally, tend to disable everything I don't need)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
es, so a lot of that memory is simply wasted.
I just wonder whether it has to be a fixed size array at all, instead
of an const char* pointer. Using a pointer should, IMHO, offer even
more savings while not having the size limit at all.
Is that struct copied as-is somewhere ?
--mtx
--
Enrico We
On 25.04.19 12:50, Thomas Gleixner wrote:
> On Thu, 25 Apr 2019, Enrico Weigelt, metux IT consult wrote:
>
>> On 25.04.19 12:42, Li, Aubrey wrote:
>>>
>>> Yep, I'll make it disabled by default and not switchable and let arch
>>> select it.
>>>
>
On 25.04.19 03:00, Chaitanya Kulkarni wrote:
> Thanks for the fix Enrico. I'm still wondering on what platform
> you got this error ?
a pretty standard x86/pc.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
401 - 500 of 966 matches
Mail list logo
