[PATCH 09/16] Unionfs: don't create whiteouts on rightmost branch

If we are unlinking/rmdir'ing an object on the rightmost branch, there's no need to create a whiteout there: this saves on storage space and inodes. Also, in the (degenerate) case of having only one branch, this really saves on whiteouts. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez

[PATCH 06/16] Unionfs: handle whiteouts more efficiently in filldir

an incorrect printk message that the file system may be corrupt, but set that filldir_node-whiteout to 1. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirfops.c | 13 ++--- fs/unionfs/dirhelper.c |2 +- fs/unionfs/rdstate.c | 11

Re: unionfs: several more problems

In message [EMAIL PROTECTED], Hugh Dickins writes: [...] Please try running LTP (e.g. ltp-full-20071031.tgz) after something like [...] Hugh, I just posted a series of patches to unionfs (already in unionfs.git on korg), which fix every problem LTP found, as well as other problems mentioned in

Re: unionfs: several more problems

In message [EMAIL PROTECTED], Hugh Dickins writes: On Mon, 26 Nov 2007, Erez Zadok wrote: [...] The small patch below fixed the problem. Let me know what you think. I've one issue with it: please move that wait_on_page_writeback before the clear_page_dirty_for_io instead of after

Re: unionfs: several more problems

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: [...] > > I deceived myself for a while that the danger of shmem_writepage > > hitting its BUG_ON(entry->val) was dealt with too; but that's wrong, > > I must go back to working out an escape from that one (despite never > > seeing it). > >

Re: unionfs: several more problems

In message [EMAIL PROTECTED], Hugh Dickins writes: [...] I deceived myself for a while that the danger of shmem_writepage hitting its BUG_ON(entry-val) was dealt with too; but that's wrong, I must go back to working out an escape from that one (despite never seeing it). Once I tried a

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > On Tue, 13 Nov 2007, Erez Zadok wrote: [...] > I'm glad to report that this unionfs, not the one in 2.6.24-rc2-mm1 > but the one including those 9 patches you posted, now gets through > my testing with tmpfs without a proble

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: On Tue, 13 Nov 2007, Erez Zadok wrote: [...] I'm glad to report that this unionfs, not the one in 2.6.24-rc2-mm1 but the one including those 9 patches you posted, now gets through my testing with tmpfs without a problem. I do still get

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > On Fri, 9 Nov 2007, Erez Zadok wrote: > > In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > > > > > Three, I believe you need to add a flush_dcache_page(lower_page) > > > after the copy_highp

[PATCH 4/9] Unionfs: writepage updates

Don't set/reset the PageUptodate flag on our page. Call flush_dcache_page on the lower page after copy_highpage, and set it uptodate. Call set_page_dirty right before clear_page_dirty_for_io. CC: Hugh Dickins <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> ---

[PATCH 9/9] Unionfs: move debugging checks inside locks

This is to ensure that the objects we want to check aren't being destroyed or changed by another thread. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |7 --- fs/unionfs/dentry.c |2 +- fs/unionfs/file.c | 10 +- fs/unionfs/i

[PATCH 5/9] Unionfs: clear partial read in readpage

Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 468dc61..bb00fd5 100644 --- a/fs/unionfs/mma

[PATCH 6/9] Unionfs: debugging updates

Don't perform dentry+inode checks unless both are valid. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 0066ccd..8464fbb 100644 --- a/fs/unionfs/d

[PATCH 8/9] Unionfs: fold do_readpage into unionfs_readpage

Simplify the code and reduce stack pressure a bit. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c | 44 ++-- 1 files changed, 14 insertions(+), 30 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 3

[PATCH 3/9] Unionfs: update cache-coherency detection heuristics

Use a small delay to reduce the number of times unionfs has to detect changed mtime's/ctime's, and also reduce the potential for false positives. See Documentation/filesystems/unionfs/concepts.txt for a detailed discussion. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- Documen

[PATCH 7/9] Unionfs: remove unnecessary lower atime updates

No need for this because our readpage calls vfs_read on the lower objects, which would update the atime as/if needed. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/file.c |8 fs/unionfs/mmap.c |6 -- 2 files changed, 0 insertions(+), 14 deletions(-)

[PATCH 2/9] Unionfs: use i_size wrappers

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 10 +- fs/unionfs/inode.c |4 ++-- fs/unionfs/rdstate.c|4 ++-- fs/unionfs/rename.c |4 ++-- fs/unionfs/super.c |2 +- 5 files changed, 12 insertions(+), 12 deletions(-)

[PATCH 1/9] Unionfs: flush and release updates

Remove the totalopens counter which was intended to reduce unnecessary processing of d_deleted dentries. Move that processing from file_release to flush. Cc: Hugh Dickins <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonf

[GIT PULL -mm] 0/9 Unionfs updates/cleanups/fixes

/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok (9): Unionfs: flush and release updates Unionfs: use i_size wrappers Unionfs: update cache-coherency detection heuristics Unionfs: writepage updates Unionfs: clear partial read in readpage Unionfs

[PATCH 2/9] Unionfs: use i_size wrappers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 10 +- fs/unionfs/inode.c |4 ++-- fs/unionfs/rdstate.c|4 ++-- fs/unionfs/rename.c |4 ++-- fs/unionfs/super.c |2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff

[PATCH 1/9] Unionfs: flush and release updates

Remove the totalopens counter which was intended to reduce unnecessary processing of d_deleted dentries. Move that processing from file_release to flush. Cc: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 30

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: On Fri, 9 Nov 2007, Erez Zadok wrote: In message [EMAIL PROTECTED], Hugh Dickins writes: Three, I believe you need to add a flush_dcache_page(lower_page) after the copy_highpage(lower_page): some architectures will need that to see

[PATCH 9/9] Unionfs: move debugging checks inside locks

This is to ensure that the objects we want to check aren't being destroyed or changed by another thread. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |7 --- fs/unionfs/dentry.c |2 +- fs/unionfs/file.c | 10 +- fs/unionfs/inode.c

[PATCH 6/9] Unionfs: debugging updates

Don't perform dentry+inode checks unless both are valid. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 0066ccd..8464fbb 100644 --- a/fs/unionfs/debug.c

[PATCH 3/9] Unionfs: update cache-coherency detection heuristics

Use a small delay to reduce the number of times unionfs has to detect changed mtime's/ctime's, and also reduce the potential for false positives. See Documentation/filesystems/unionfs/concepts.txt for a detailed discussion. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation

[PATCH 7/9] Unionfs: remove unnecessary lower atime updates

No need for this because our readpage calls vfs_read on the lower objects, which would update the atime as/if needed. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c |8 fs/unionfs/mmap.c |6 -- 2 files changed, 0 insertions(+), 14 deletions(-) diff --git

[GIT PULL -mm] 0/9 Unionfs updates/cleanups/fixes

/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok (9): Unionfs: flush and release updates Unionfs: use i_size wrappers Unionfs: update cache-coherency detection heuristics Unionfs: writepage updates Unionfs: clear partial read in readpage Unionfs

[PATCH 8/9] Unionfs: fold do_readpage into unionfs_readpage

Simplify the code and reduce stack pressure a bit. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 44 ++-- 1 files changed, 14 insertions(+), 30 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 34fd8aa..ef8822f

[PATCH 5/9] Unionfs: clear partial read in readpage

Signed-off-by: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 468dc61..bb00fd5 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs

[PATCH 4/9] Unionfs: writepage updates

Don't set/reset the PageUptodate flag on our page. Call flush_dcache_page on the lower page after copy_highpage, and set it uptodate. Call set_page_dirty right before clear_page_dirty_for_io. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c

[PATCH] NFSD: fix wrong mnt_writer count in rename (MMOTM 2007-11-10-19-05)

. If we can drop the ref earlier, it could improve scalability/performance just a bit, no? (i.e., what are the ramifications of holding on to this mnt writer ref longer than needed?) Cheers, Erez. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c

[PATCH] NFSD: fix wrong mnt_writer count in rename (MMOTM 2007-11-10-19-05)

. If we can drop the ref earlier, it could improve scalability/performance just a bit, no? (i.e., what are the ramifications of holding on to this mnt writer ref longer than needed?) Cheers, Erez. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index

[PATCH] arch/x86/kernel/setup_64.c compile error (MMOTM-2007-11-10-19-05)

I'm using -mm (MMOTM-2007-11-10-19-05) and getting $ make CC arch/x86/kernel/setup_64.o arch/x86/kernel/setup_64.c: In function 'setup_arch': arch/x86/kernel/setup_64.c:420: error: implicit declaration of function 'early_quirks' That's because the externs for early_quirks() aren't on

[PATCH] init/calibrate.c compile error (MMOTM-2007-11-10-19-05)

to fix the compilation error. Someone should verify that it's the proper fix. Cheers, Erez. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> diff --git a/include/linux/timex.h b/include/linux/timex.h index 40383f9..57bb18c 100644 --- a/include/linux/timex.h +++ b/include/linux/timex.h @@

Re: [PATCH] Unionfs: stop using iget() and read_inode()

patch, or a small incremental one; either way, you can choose to fold the above and below patches into one. Thanks, Erez. Unionfs: bugfix to initialize unionfs_inode_info node Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index 7

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

In message <[EMAIL PROTECTED]>, Ingo Molnar writes: > > * Erez Zadok <[EMAIL PROTECTED]> wrote: > > > Small patch below fixes compile error. > > > + char name[sizeof(current->comm)]; > > warne

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

In message [EMAIL PROTECTED], Ingo Molnar writes: * Erez Zadok [EMAIL PROTECTED] wrote: Small patch below fixes compile error. + char name[sizeof(current-comm)]; warned++; printk(KERN_INFO warning

Re: [PATCH] Unionfs: stop using iget() and read_inode()

patch, or a small incremental one; either way, you can choose to fold the above and below patches into one. Thanks, Erez. Unionfs: bugfix to initialize unionfs_inode_info node Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index 7408b0f..d6544f8

[PATCH] init/calibrate.c compile error (MMOTM-2007-11-10-19-05)

to fix the compilation error. Someone should verify that it's the proper fix. Cheers, Erez. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/include/linux/timex.h b/include/linux/timex.h index 40383f9..57bb18c 100644 --- a/include/linux/timex.h +++ b/include/linux/timex.h @@ -55,6

[PATCH] arch/x86/kernel/setup_64.c compile error (MMOTM-2007-11-10-19-05)

I'm using -mm (MMOTM-2007-11-10-19-05) and getting $ make CC arch/x86/kernel/setup_64.o arch/x86/kernel/setup_64.c: In function 'setup_arch': arch/x86/kernel/setup_64.c:420: error: implicit declaration of function 'early_quirks' That's because the externs for early_quirks() aren't on

NFSv4 broken in -mm (MMOM "10-Nov-2007 22:46")

I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 22:46". Creating dummy f/s and exporting it to localhost, mounting it as nfsv4, then # touch foo touch: setting times of `foo': No such file or directory # echo > bar bar: Invalid argument Erez. - To unsubscribe from

patch conflicts (MMOTM "10-Nov-2007 22:46")

Andrew, I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 22:46". 1. I was getting a bunch of patch conflicts, until I realized that this latest set of patches was to be applied against 2.6.24-rc2 (your mm.patch gave it away :-) The last snapshot was against

[PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

231: error: too few arguments to function 'get_task_comm' make[1]: *** [kernel/capability.o] Error 1 make[1]: Target `__build' not remade because of errors. make: *** [kernel] Error 2 Small patch below fixes compile error. Erez. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> dif

[PATCH] mm/memory.c follow_hugetlb_page compiler error (MMOTM)

fixes compile error. Erez. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index bb03660..2496879 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -106,7 +106,7 @@ static inline unsigned long hugetlb_total_pa

Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

Andrew, I'm getting minor warnings when applying two patches from It's probably not serious but I wonder if checkpatch catches this. Applying patch..git-net.patch Warning: commit message does not conform to UTF-8. You may want to amend it after fixing

Re: WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

In message <[EMAIL PROTECTED]>, Andrew Morton writes: > On Fri, 9 Nov 2007 21:12:47 -0500 Erez Zadok <[EMAIL PROTECTED]> wrote: > > > Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 > > That's a bit old. > > > and these two > > patches

Re: WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

In message [EMAIL PROTECTED], Andrew Morton writes: On Fri, 9 Nov 2007 21:12:47 -0500 Erez Zadok [EMAIL PROTECTED] wrote: Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 That's a bit old. and these two patches added: r-o-bind-mounts-track-number-of-mount-writer

Warning: commit message does not conform to UTF-8. (mmotm 10-Nov-2007 22:46)

Andrew, I'm getting minor warnings when applying two patches from http://userweb.kernel.org/~akpm/mmotm/ It's probably not serious but I wonder if checkpatch catches this. Applying patch..git-net.patch Warning: commit message does not conform to UTF-8. You may want to amend it after fixing the

[PATCH] mm/memory.c follow_hugetlb_page compiler error (MMOTM)

. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index bb03660..2496879 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -106,7 +106,7 @@ static inline unsigned long hugetlb_total_pages(void) return 0

[PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

: too few arguments to function 'get_task_comm' make[1]: *** [kernel/capability.o] Error 1 make[1]: Target `__build' not remade because of errors. make: *** [kernel] Error 2 Small patch below fixes compile error. Erez. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/kernel/capability.c b

patch conflicts (MMOTM 10-Nov-2007 22:46)

Andrew, I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped 10-Nov-2007 22:46. 1. I was getting a bunch of patch conflicts, until I realized that this latest set of patches was to be applied against 2.6.24-rc2 (your mm.patch gave it away :-) The last snapshot was against

NFSv4 broken in -mm (MMOM 10-Nov-2007 22:46)

I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped 10-Nov-2007 22:46. Creating dummy f/s and exporting it to localhost, mounting it as nfsv4, then # touch foo touch: setting times of `foo': No such file or directory # echo bar bar: Invalid argument Erez. - To unsubscribe from this

Re: [PATCH 1/2] create file_drop_write_access() helper

In message <[EMAIL PROTECTED]>, Dave Hansen writes: > > These should fix the bug that Erez Zadok <[EMAIL PROTECTED]> > reported: > > Stopping RPC idmapd: > > kernel: __fput() of writeable file with no mnt_want_write() > kernel: WARNING: at f

WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two patches added: r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch Booting the machine, waiting a few minutes (not logging

BUG: can't reboot -nf -mm 2007-11-06-02-32++

In message <[EMAIL PROTECTED]>, Erez Zadok writes: > Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two > patches added: > > r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch > r-o-bind-mounts-track-number-of-mount-writer-fix-

OOPSes + WARNING: at fs/file_table.c:262 __fput() in -mm 2007-11-06-02-32++

Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two patches added: r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch All I do is boot the system with said kernel, wait a

Re: [PATCH mm] unionfs: clear partial read

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > unionfs_do_readpage forgot to clear the rest of the page when vfs_read > does not fill the page: fix that. > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> > --- > > fs/unionfs/mmap.c |3 ++- > 1 file changed, 2 insertions(+), 1

WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two patches added: r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch Booting the machine, waiting a few minutes (not logging

Re: [PATCH 1/2] create file_drop_write_access() helper

In message [EMAIL PROTECTED], Dave Hansen writes: These should fix the bug that Erez Zadok [EMAIL PROTECTED] reported: Stopping RPC idmapd: kernel: __fput() of writeable file with no mnt_want_write() kernel: WARNING: at fs/file_table.c:262 __fput() kernel: [c010283e

Re: [PATCH mm] unionfs: clear partial read

In message [EMAIL PROTECTED], Hugh Dickins writes: unionfs_do_readpage forgot to clear the rest of the page when vfs_read does not fill the page: fix that. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- fs/unionfs/mmap.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

OOPSes + WARNING: at fs/file_table.c:262 __fput() in -mm 2007-11-06-02-32++

Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two patches added: r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch All I do is boot the system with said kernel, wait a

BUG: can't reboot -nf -mm 2007-11-06-02-32++

In message [EMAIL PROTECTED], Erez Zadok writes: Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two patches added: r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > [Dave, I've Cc'ed you re handle_write_count_underflow, see below.] > > On Wed, 31 Oct 2007, Erez Zadok wrote: > > > > Hi Hugh, I've addressed all of your concerns and am happy to report that the > > newly rev

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message <[EMAIL PROTECTED]>, Dave Hansen writes: > On Mon, 2007-11-05 at 15:40 +, Hugh Dickins wrote: [...] > I have a decent guess what the bug is, too. In the unionfs code: > > > int init_lower_nd(struct nameidata *nd, unsigned int flags) > > { > > ... > > #ifdef ALLOC_LOWER_ND_FILE > >

Re: unionfs and sys_readahead

In message <[EMAIL PROTECTED]>, Paul Albrecht writes: > On Wed, 2007-11-07 at 19:53 +, Denys Vlasenko wrote: > > On Tuesday 06 November 2007 22:01, Paul Albrecht wrote: > > > Hi, > > > > > > Whenever I use readahead-list on a union mounted file system I get a > > > segfault and kernel oops so

Re: unionfs and sys_readahead

In message [EMAIL PROTECTED], Paul Albrecht writes: On Wed, 2007-11-07 at 19:53 +, Denys Vlasenko wrote: On Tuesday 06 November 2007 22:01, Paul Albrecht wrote: Hi, Whenever I use readahead-list on a union mounted file system I get a segfault and kernel oops so I'm wondering

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Dave Hansen writes: On Mon, 2007-11-05 at 15:40 +, Hugh Dickins wrote: [...] I have a decent guess what the bug is, too. In the unionfs code: int init_lower_nd(struct nameidata *nd, unsigned int flags) { ... #ifdef ALLOC_LOWER_ND_FILE

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: [Dave, I've Cc'ed you re handle_write_count_underflow, see below.] On Wed, 31 Oct 2007, Erez Zadok wrote: Hi Hugh, I've addressed all of your concerns and am happy to report that the newly revised unionfs_writepage works even better

Re: [Unionfs] Re: [PATCH] IGET: Stop UnionFS from using iget() and read_inode()

In message <[EMAIL PROTECTED]>, Paul Albrecht writes: > On Wed, 2007-11-07 at 15:04 +, David Howells wrote: > > Paul Albrecht <[EMAIL PROTECTED]> wrote: > > > > > Does your test set include readahead-list? I can't get it to work with a > > > union mounted filesystem without segfault'ing and

Re: [Unionfs] Re: [PATCH] IGET: Stop UnionFS from using iget() and read_inode()

In message [EMAIL PROTECTED], Paul Albrecht writes: On Wed, 2007-11-07 at 15:04 +, David Howells wrote: Paul Albrecht [EMAIL PROTECTED] wrote: Does your test set include readahead-list? I can't get it to work with a union mounted filesystem without segfault'ing and kernel oops'ing.

[PATCH] Unionfs: stop using iget() and read_inode()

event of an error. unionfs_fill_super() returns any error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> diff --git a/fs/unionfs/main.c b/fs/unionfs/main.c index ffb0da1..89e3b31 100644 --- a

Re: [PATCH] IGET: Stop UnionFS from using iget() and read_inode()

In message <[EMAIL PROTECTED]>, David Howells writes: > From: David Howells <[EMAIL PROTECTED]> > > Stop the UnionFS filesystem from using iget() and read_inode(). Replace > unionfs_read_inode() with unionfs_iget(), and call that instead of iget(). > unionfs_iget() then uses iget_locked()

Re: [PATCH] IGET: Stop UnionFS from using iget() and read_inode()

In message [EMAIL PROTECTED], David Howells writes: From: David Howells [EMAIL PROTECTED] Stop the UnionFS filesystem from using iget() and read_inode(). Replace unionfs_read_inode() with unionfs_iget(), and call that instead of iget(). unionfs_iget() then uses iget_locked() directly and

[PATCH] Unionfs: stop using iget() and read_inode()

. unionfs_fill_super() returns any error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/fs/unionfs/main.c b/fs/unionfs/main.c index ffb0da1..89e3b31 100644 --- a/fs/unionfs/main.c +++ b

[PATCH 4/8] Unionfs: mmap updates

Rewrite unionfs_writepage to minimize dependence on AOP_WRITEPAGE_ACTIVEATE, handle memory pressure better, and update documentation. Remove unionfs_sync_page because it's not needed. CC: Hugh Dickins <[EMAIL PROTECTED]> CC: Pekka Enberg <[EMAIL PROTECTED]> Signed-off-by: Erez Z

[PATCH 8/8] Unionfs/VFS: no need to export 2 symbols in security/security.c

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- security/security.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/security/security.c b/security/security.c index 95a6733..0e1f1f1 100644 --- a/security/security.c +++ b/security/security.c @@ -409,7 +409,6

[PATCH 5/8] Unionfs: avoid a deadlock during branch-management on a pivot_root'ed union

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Herton Ronaldo Krzesinski <[EMAIL PROTECTED]> --- fs/unionfs/union.h | 39 +-- 1 files changed, 33 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h i

[PATCH 3/8] Unionfs: update usage.txt documentation

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- Documentation/filesystems/unionfs/usage.txt | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/Documentation/filesystems/unionfs/usage.txt b/Documentation/filesystems/unionfs/usage.txt index d8c15de..a

[PATCH 7/8] Unionfs: don't printk an error if it's due to common copyup

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c |9 + fs/unionfs/rename.c |2 +- fs/unionfs/subr.c |8 ++-- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 169365c..bcefe45

[PATCH 2/8] Unionfs: cleanup permission checking code

Use vfs helpers and avoid redundant checks performed by the VFS already. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |4 --- fs/unionfs/inode.c | 70 +-- 2 files changed, 13 insertions(+), 61 deletions(-)

[PATCH 6/8] Unionfs: don't bother validating inode if it has no lower branches

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 894bf7c..0066ccd 100644 --- a/fs/unionfs/debug.c +++ b/fs/unionfs/debug.c @@ -49,6 +49,9 @

[GIT PULL -mm] 0/8 Unionfs updates/cleanups/fixes

eceive the following: Erez Zadok (8): Unionfs: delete whiteouts in sticky directories Unionfs: cleanup permission checking code Unionfs: update usage.txt documentation Unionfs: mmap updates Unionfs: avoid a deadlock during branch-management on a pivot_root'ed union U

[PATCH 1/8] Unionfs: delete whiteouts in sticky directories

This is needed to maintain Unix semantics. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 6ca52f4..f4facf4 100644 --- a/fs/unionfs/i

[PATCH 1/8] Unionfs: delete whiteouts in sticky directories

This is needed to maintain Unix semantics. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 6ca52f4..f4facf4 100644 --- a/fs/unionfs/inode.c

[GIT PULL -mm] 0/8 Unionfs updates/cleanups/fixes

the following: Erez Zadok (8): Unionfs: delete whiteouts in sticky directories Unionfs: cleanup permission checking code Unionfs: update usage.txt documentation Unionfs: mmap updates Unionfs: avoid a deadlock during branch-management on a pivot_root'ed union Unionfs

[PATCH 2/8] Unionfs: cleanup permission checking code

Use vfs helpers and avoid redundant checks performed by the VFS already. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |4 --- fs/unionfs/inode.c | 70 +-- 2 files changed, 13 insertions(+), 61 deletions(-) diff

[PATCH 6/8] Unionfs: don't bother validating inode if it has no lower branches

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 894bf7c..0066ccd 100644 --- a/fs/unionfs/debug.c +++ b/fs/unionfs/debug.c @@ -49,6 +49,9 @@ void

[PATCH 5/8] Unionfs: avoid a deadlock during branch-management on a pivot_root'ed union

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Herton Ronaldo Krzesinski [EMAIL PROTECTED] --- fs/unionfs/union.h | 39 +-- 1 files changed, 33 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h index 6333488..0476f97

[PATCH 3/8] Unionfs: update usage.txt documentation

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/usage.txt | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/Documentation/filesystems/unionfs/usage.txt b/Documentation/filesystems/unionfs/usage.txt index d8c15de..a6b1aca

[PATCH 7/8] Unionfs: don't printk an error if it's due to common copyup

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c |9 + fs/unionfs/rename.c |2 +- fs/unionfs/subr.c |8 ++-- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 169365c..bcefe45 100644 --- a/fs

[PATCH 4/8] Unionfs: mmap updates

Rewrite unionfs_writepage to minimize dependence on AOP_WRITEPAGE_ACTIVEATE, handle memory pressure better, and update documentation. Remove unionfs_sync_page because it's not needed. CC: Hugh Dickins [EMAIL PROTECTED] CC: Pekka Enberg [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL

[PATCH 8/8] Unionfs/VFS: no need to export 2 symbols in security/security.c

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- security/security.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/security/security.c b/security/security.c index 95a6733..0e1f1f1 100644 --- a/security/security.c +++ b/security/security.c @@ -409,7 +409,6 @@ int

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

Hi Hugh, I've addressed all of your concerns and am happy to report that the newly revised unionfs_writepage works even better, including under my memory-pressure conditions. To summarize my changes since the last time: - I'm only masking __GFP_FS, not __GFP_IO - using find_or_create_page to

Re: [PATCH v3] 0/4 fs/ioctl.c coding style, function renaming/factoring

In message <[EMAIL PROTECTED]>, Andrew Morton writes: > On Tue, 30 Oct 2007 15:39:55 -0400 > Erez Zadok <[EMAIL PROTECTED]> wrote: > > > This series of 4 proposed patches (take 3) changes fs/ioctl.c and Unionfs as > > follows. > > The problem is of

Re: [PATCH v3] 0/4 fs/ioctl.c coding style, function renaming/factoring

In message [EMAIL PROTECTED], Andrew Morton writes: On Tue, 30 Oct 2007 15:39:55 -0400 Erez Zadok [EMAIL PROTECTED] wrote: This series of 4 proposed patches (take 3) changes fs/ioctl.c and Unionfs as follows. The problem is of course that you need these in your tree for ongoing

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

Hi Hugh, I've addressed all of your concerns and am happy to report that the newly revised unionfs_writepage works even better, including under my memory-pressure conditions. To summarize my changes since the last time: - I'm only masking __GFP_FS, not __GFP_IO - using find_or_create_page to

[PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names

because the names vfs_XXX should preferably be reserved to callable VFS functions which modules may call, as many other vfs_XXX functions already do. Export the new vfs_ioctl to GPL modules so others can use it (including Unionfs and eCryptfs). Add DocBook for new vfs_ioctl. Signed-off-by: Erez

[PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/ioctl.c | 129 +++- 1 files changed, 75 insertions(+), 54 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index 1ab7b7d..cd8c1a3 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@

[PATCH 1/4] VFS: apply coding standards to fs/ioctl.c

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/ioctl.c | 164 +++- 1 files changed, 84 insertions(+), 80 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index c2a773e..652cacf 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -12,8

[PATCH 4/4] Unionfs: use vfs_ioctl

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 36 ++-- 1 files changed, 6 insertions(+), 30 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index 7654bcb..c99b519 100644 --- a/fs/unionfs/common

<    1   2   3   4   5   6   7   8   9   >