[PATCH 18/25] Unionfs: add un/likely conditionals on super ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c | 98 ++- fs/unionfs/super.c | 90 2 files changed, 95 insertions(+), 93 deletions(-) diff --git a/fs/unionfs/main.

[PATCH 16/25] Unionfs: add un/likely conditionals on inode ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c | 160 ++-- 1 files changed, 80 insertions(+), 80 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 7ee4760..7ae4a25 100644 --- a/fs/unionfs/inode.c

[PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/copyup.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 23ac4c8..e3c5f15 100644 --- a/fs/unionfs/copyup.c

[PATCH 11/25] Unionfs: add un/likely conditionals on debug ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c | 108 +++ 1 files changed, 57 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 9546a41..09b52ce 100644 --- a/fs/unionfs/debug.c ++

[PATCH 09/25] Unionfs: add un/likely conditionals on common fileops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 94 +++--- 1 files changed, 47 insertions(+), 47 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index e69ccf6..db8f064 100644 --- a/fs/u

[PATCH 20/25] Unionfs: add un/likely conditionals on rename ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/rename.c | 96 +- 1 files changed, 48 insertions(+), 48 deletions(-) diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c index 7b8fe39..92c4515 100644 --- a/fs/unionfs/rename.c

[PATCH 12/25] Unionfs: add un/likely conditionals on dentry ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 68 ++ 1 files changed, 35 insertions(+), 33 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 52bcb18..3f3a18d 100644 --- a/fs/unionfs/dentry.c

[PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dirfops.c | 22 +++--- fs/unionfs/dirhelper.c | 30 +++--- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c index c923e58..f

[PATCH 17/25] Unionfs: add un/likely conditionals on lookup ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/lookup.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index 2109714..92b5e0a 100644 --- a/fs/unionfs/lookup.c ++

[PATCH 15/25] Unionfs: add un/likely conditionals on fileops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/file.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c index d8eaaa5..06ca1fa 100644 --- a/fs/unionfs/file.c +++ b/fs/unionfs/

[PATCH 23/25] Unionfs: add un/likely conditionals on unlink ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/unlink.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c index 3924f7f..33d08d9 100644 --- a/fs/unionfs/unlink.c +++ b/fs/u

[PATCH 06/25] Unionfs: minor coding style updates

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c |6 -- fs/unionfs/dentry.c |2 +- fs/unionfs/inode.c | 14 -- fs/unionfs/main.c |4 ++-- fs/unionfs/union.h |2 +- 5 files changed, 16 insertions(+), 12 deletions(-) diff --gi

[PATCH 07/25] Unionfs: add lower nameidata debugging support

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c | 20 fs/unionfs/dentry.c |4 +++- fs/unionfs/inode.c |8 +++- fs/unionfs/union.h |4 4 files changed, 34 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/u

[PATCH 22/25] Unionfs: add un/likely conditionals on common subr

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/sioq.c |4 ++-- fs/unionfs/subr.c | 26 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/fs/unionfs/sioq.c b/fs/unionfs/sioq.c index 2a8c88e..35d9fc3 100644 --- a/fs/unionfs/sioq.c

[PATCH 08/25] Unionfs: lower nameidata support for nfsv4

2007-09-25 Thread Erez Zadok
Pass nameidata structures as needed to the lower file system, support LOOKUP_ACCESS/OPEN intents. This makes unionfs work on top of nfsv4. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 11 +--

[PATCH 19/25] Unionfs: add un/likely conditionals on mmap ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 37af979..1cea075 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c @@

[PATCH 21/25] Unionfs: add un/likely conditionals on readdir ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/rdstate.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/rdstate.c b/fs/unionfs/rdstate.c index 0a18d5c..7ec7f95 100644 --- a/fs/unionfs/rdstate.c +++ b/fs/unionfs/rdstate.c @@

[PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-25 Thread Erez Zadok
This is to avoid filling the console/logs with messages that are primarily of debugging use. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |4 ++-- fs/unionfs/dentry.c |6 +++--- fs/uni

[PATCH 24/25] Unionfs: add un/likely conditionals on xattr ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/xattr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c index 7f77d7d..bd2de06 100644 --- a/fs/unionfs/xattr.c +++ b/fs/unionfs/xattr.c @@ -23,14 +23,14 @

[PATCH 14/25] Unionfs: add un/likely conditionals on headers

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/fanout.h | 13 - fs/unionfs/union.h |4 ++-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index 51aa0de..6405399 100644 --- a/fs/unionfs/fanout.h ++

[PATCH 05/25] Unionfs: cast page->index loff_t before shifting

2007-09-25 Thread Erez Zadok
Fixes bugs in number promotion/demotion computation, as per <http://lkml.org/lkml/2007/9/20/17> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-

[GIT PULL -mm] 00/25 Unionfs updates/cleanups/fixes

2007-09-25 Thread Erez Zadok
/ezk/unionfs.git to receive the following: Erez Zadok (22): Unionfs: display informational messages only if debug is on Unionfs: cast page->index loff_t before shifting Unionfs: minor coding style updates Unionfs: add lower nameidata debugging support Unionfs: lo

[GIT PULL -mm] 00/25 Unionfs updates/cleanups/fixes

2007-09-25 Thread Erez Zadok
/ezk/unionfs.git to receive the following: Erez Zadok (22): Unionfs: display informational messages only if debug is on Unionfs: cast page-index loff_t before shifting Unionfs: minor coding style updates Unionfs: add lower nameidata debugging support Unionfs: lower

[PATCH 05/25] Unionfs: cast page-index loff_t before shifting

2007-09-25 Thread Erez Zadok
Fixes bugs in number promotion/demotion computation, as per http://lkml.org/lkml/2007/9/20/17 Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/mmap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/unionfs

[PATCH 24/25] Unionfs: add un/likely conditionals on xattr ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/xattr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c index 7f77d7d..bd2de06 100644 --- a/fs/unionfs/xattr.c +++ b/fs/unionfs/xattr.c @@ -23,14 +23,14 @@ void

[PATCH 14/25] Unionfs: add un/likely conditionals on headers

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/fanout.h | 13 - fs/unionfs/union.h |4 ++-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index 51aa0de..6405399 100644 --- a/fs/unionfs/fanout.h +++ b/fs

[PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-25 Thread Erez Zadok
This is to avoid filling the console/logs with messages that are primarily of debugging use. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |4 ++-- fs/unionfs/dentry.c |6 +++--- fs/unionfs/union.h |4

[PATCH 21/25] Unionfs: add un/likely conditionals on readdir ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rdstate.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/rdstate.c b/fs/unionfs/rdstate.c index 0a18d5c..7ec7f95 100644 --- a/fs/unionfs/rdstate.c +++ b/fs/unionfs/rdstate.c @@ -45,7

[PATCH 19/25] Unionfs: add un/likely conditionals on mmap ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 37af979..1cea075 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c @@ -84,7

[PATCH 08/25] Unionfs: lower nameidata support for nfsv4

2007-09-25 Thread Erez Zadok
Pass nameidata structures as needed to the lower file system, support LOOKUP_ACCESS/OPEN intents. This makes unionfs work on top of nfsv4. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 11 +-- fs/unionfs/inode.c

[PATCH 07/25] Unionfs: add lower nameidata debugging support

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 20 fs/unionfs/dentry.c |4 +++- fs/unionfs/inode.c |8 +++- fs/unionfs/union.h |4 4 files changed, 34 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs

[PATCH 22/25] Unionfs: add un/likely conditionals on common subr

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/sioq.c |4 ++-- fs/unionfs/subr.c | 26 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/fs/unionfs/sioq.c b/fs/unionfs/sioq.c index 2a8c88e..35d9fc3 100644 --- a/fs/unionfs/sioq.c +++ b/fs

[PATCH 06/25] Unionfs: minor coding style updates

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |6 -- fs/unionfs/dentry.c |2 +- fs/unionfs/inode.c | 14 -- fs/unionfs/main.c |4 ++-- fs/unionfs/union.h |2 +- 5 files changed, 16 insertions(+), 12 deletions(-) diff --git a/fs/unionfs

[PATCH 23/25] Unionfs: add un/likely conditionals on unlink ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/unlink.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c index 3924f7f..33d08d9 100644 --- a/fs/unionfs/unlink.c +++ b/fs/unionfs/unlink.c

[PATCH 15/25] Unionfs: add un/likely conditionals on fileops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c index d8eaaa5..06ca1fa 100644 --- a/fs/unionfs/file.c +++ b/fs/unionfs/file.c

[PATCH 17/25] Unionfs: add un/likely conditionals on lookup ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index 2109714..92b5e0a 100644 --- a/fs/unionfs/lookup.c +++ b/fs

[PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirfops.c | 22 +++--- fs/unionfs/dirhelper.c | 30 +++--- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c index c923e58..fa2df88

[PATCH 12/25] Unionfs: add un/likely conditionals on dentry ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 68 ++ 1 files changed, 35 insertions(+), 33 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 52bcb18..3f3a18d 100644 --- a/fs/unionfs/dentry.c +++ b

[PATCH 20/25] Unionfs: add un/likely conditionals on rename ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rename.c | 96 +- 1 files changed, 48 insertions(+), 48 deletions(-) diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c index 7b8fe39..92c4515 100644 --- a/fs/unionfs/rename.c +++ b

[PATCH 09/25] Unionfs: add un/likely conditionals on common fileops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 94 +++--- 1 files changed, 47 insertions(+), 47 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index e69ccf6..db8f064 100644 --- a/fs/unionfs

[PATCH 11/25] Unionfs: add un/likely conditionals on debug ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 108 +++ 1 files changed, 57 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 9546a41..09b52ce 100644 --- a/fs/unionfs/debug.c +++ b/fs

[PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 23ac4c8..e3c5f15 100644 --- a/fs/unionfs/copyup.c +++ b

[PATCH 16/25] Unionfs: add un/likely conditionals on inode ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 160 ++-- 1 files changed, 80 insertions(+), 80 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 7ee4760..7ae4a25 100644 --- a/fs/unionfs/inode.c +++ b/fs

[PATCH 18/25] Unionfs: add un/likely conditionals on super ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c | 98 ++- fs/unionfs/super.c | 90 2 files changed, 95 insertions(+), 93 deletions(-) diff --git a/fs/unionfs/main.c b/fs

[PATCH 02/25] Unionfs: Remove unused #defines

2007-09-25 Thread Erez Zadok
From: Josef 'Jeff' Sipek [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/union.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h index 1cb2e1d

[PATCH 04/25] Unionfs: cache-coherency fixes

2007-09-25 Thread Erez Zadok
From: Olivier Blin [EMAIL PROTECTED] Do not update mtime if there is no upper branch for the inode. This prevents from calling unionfs_lower_inode_idx() with a negative index, which triggers a bug. Signed-off-by: Olivier Blin [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs

[PATCH 01/25] Unionfs: Simplify unionfs_get_nlinks

2007-09-25 Thread Erez Zadok
PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/subr.c | 41 +++-- 1 files changed, 7 insertions(+), 34 deletions(-) diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c index b7e7904..6b93b64 100644 --- a/fs/unionfs/subr.c +++ b/fs/unionfs

[PATCH 25/25] Unionfs: use poison.h for safe poison pointers

2007-09-25 Thread Erez Zadok
This also fixes a compile warning on 64-bit systems. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 16 ++-- fs/unionfs/union.h |1 + 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/fs

Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

2007-09-20 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Michael Halcrow writes: > On Wed, Sep 19, 2007 at 10:46:26PM -0700, Andrew Morton wrote: > (from ecryptfs_encrypt_page()): > > > + enc_extent_virt = kmalloc(PAGE_CACHE_SIZE, GFP_USER); > > > > I'd have thought that alloc_page() would be nicer. After all, we _are_

Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

2007-09-20 Thread Erez Zadok
In message [EMAIL PROTECTED], Michael Halcrow writes: On Wed, Sep 19, 2007 at 10:46:26PM -0700, Andrew Morton wrote: (from ecryptfs_encrypt_page()): + enc_extent_virt = kmalloc(PAGE_CACHE_SIZE, GFP_USER); I'd have thought that alloc_page() would be nicer. After all, we _are_ treating

[PATCH 6/6] Unionfs: cache coherency after lower objects are removed

2007-09-19 Thread Erez Zadok
Prevent an oops if a lower file is deleted and then it is stat'ed from the upper layer. Ensure that we return a negative dentry so the user will get an ENOENT. Properly dput/mntput so we don't leak references at the lower file system. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>

[PATCH 1/6] Unionfs: use bool type in dentry and file revalidation code

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef Sipek <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 12 ++-- fs/unionfs/dentry.c |2 +- fs/unionfs/dirfops.c|4 ++-- fs/unionfs/file.c | 12 ++-- fs/unionfs/mmap.c |

[PATCH 4/6] Unionfs: check integrity only if validated dentry successfully

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef Sipek <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 91f9780..9e0742d 100644 --- a/fs/unionfs/dentr

[PATCH 5/6] Unionfs: unionfs_lookup locking consistency

2007-09-19 Thread Erez Zadok
this behavior. This cleanup allowed us to remove two unnecessary int declarations. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef Sipek <[EMAIL PROTECTED]> --- fs/unionfs/inode.c |6 +- fs/unionfs/lookup.c | 38 +++--- 2 files changed, 2

[PATCH 2/6] Unionfs: remove unnecessary comment

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef Sipek <[EMAIL PROTECTED]> --- fs/unionfs/fanout.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index c5bf454..afeb9f6 100644 --- a/fs/unionfs/fanou

[PATCH 3/6] Unionfs: add missing newlines to printks

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef Sipek <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index f32922e..91f9780 100644 --- a/fs/unionfs/dentr

[GIT PULL -mm] 0/6 Unionfs updates/cleanups/fixes

2007-09-19 Thread Erez Zadok
4 ++-- fanout.h |1 - file.c | 12 ++-- inode.c |6 +- lookup.c | 52 +++- mmap.c |6 +++--- union.h |2 +- 9 files changed, 59 insertions(+), 45 deletions(-) Erez Zadok [EMAIL PROTECTED] -

[GIT PULL -mm] 0/6 Unionfs updates/cleanups/fixes

2007-09-19 Thread Erez Zadok
|1 - file.c | 12 ++-- inode.c |6 +- lookup.c | 52 +++- mmap.c |6 +++--- union.h |2 +- 9 files changed, 59 insertions(+), 45 deletions(-) Erez Zadok [EMAIL PROTECTED] - To unsubscribe from

[PATCH 2/6] Unionfs: remove unnecessary comment

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/fanout.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index c5bf454..afeb9f6 100644 --- a/fs/unionfs/fanout.h +++ b/fs/unionfs

[PATCH 3/6] Unionfs: add missing newlines to printks

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index f32922e..91f9780 100644 --- a/fs/unionfs/dentry.c +++ b/fs

[PATCH 1/6] Unionfs: use bool type in dentry and file revalidation code

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 12 ++-- fs/unionfs/dentry.c |2 +- fs/unionfs/dirfops.c|4 ++-- fs/unionfs/file.c | 12 ++-- fs/unionfs/mmap.c |6 +++--- fs

[PATCH 4/6] Unionfs: check integrity only if validated dentry successfully

2007-09-19 Thread Erez Zadok
Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 91f9780..9e0742d 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs

[PATCH 5/6] Unionfs: unionfs_lookup locking consistency

2007-09-19 Thread Erez Zadok
this behavior. This cleanup allowed us to remove two unnecessary int declarations. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c |6 +- fs/unionfs/lookup.c | 38 +++--- 2 files changed, 24 insertions

[PATCH 6/6] Unionfs: cache coherency after lower objects are removed

2007-09-19 Thread Erez Zadok
Prevent an oops if a lower file is deleted and then it is stat'ed from the upper layer. Ensure that we return a negative dentry so the user will get an ENOENT. Properly dput/mntput so we don't leak references at the lower file system. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef

Re: [RFC] Union Mount: Readdir approaches

2007-09-07 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, "Josef 'Jeff' Sipek" writes: > On Fri, Sep 07, 2007 at 01:28:55PM +0530, Bharata B Rao wrote: > > On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: > > > > > > When the first readdir is issued: > > > - call vfs_readdir for every underlying opened

Re: [RFC] Union Mount: Readdir approaches

2007-09-07 Thread Erez Zadok
In message [EMAIL PROTECTED], Josef 'Jeff' Sipek writes: On Fri, Sep 07, 2007 at 01:28:55PM +0530, Bharata B Rao wrote: On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: When the first readdir is issued: - call vfs_readdir for every underlying opened dir (file)

Re: [GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes

2007-09-03 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Al Boldi writes: > Erez Zadok wrote: > > Al, we have back-ports of the latest Unionfs to 2.6.{22,21,20,19,18,9}, > > all in http://unionfs.filesystems.org/. Before we release any change, we > > test it on all back-ports as well as t

Re: [GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes

2007-09-03 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Al Boldi writes: > Josef 'Jeff' Sipek wrote: > > The following is a series of patches related to Unionfs, which include > > three small VFS/fsstack patches and one eCryptfs patch; the rest are > > Unionfs patches. The patches here represent several months of work

Re: [GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes

2007-09-03 Thread Erez Zadok
In message [EMAIL PROTECTED], Al Boldi writes: Josef 'Jeff' Sipek wrote: The following is a series of patches related to Unionfs, which include three small VFS/fsstack patches and one eCryptfs patch; the rest are Unionfs patches. The patches here represent several months of work and

Re: [GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes

2007-09-03 Thread Erez Zadok
In message [EMAIL PROTECTED], Al Boldi writes: Erez Zadok wrote: Al, we have back-ports of the latest Unionfs to 2.6.{22,21,20,19,18,9}, all in http://unionfs.filesystems.org/. Before we release any change, we test it on all back-ports as well as the latest -rc/-mm code base (takes over

Re: [Ecryptfs-devel] [PATCH] eCryptfs: fix possible fault in ecryptfs_sync_page

2007-08-23 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Michael Halcrow writes: > On Thu, Aug 23, 2007 at 04:42:59PM +0900, Ryusuke Konishi wrote: > > This will avoid a possible fault in ecryptfs_sync_page(). > > Acked-by: Michael Halcrow <[EMAIL PROTECTED]> > > Note that there are other outstanding issues with

Re: [Ecryptfs-devel] [PATCH] eCryptfs: fix possible fault in ecryptfs_sync_page

2007-08-23 Thread Erez Zadok
In message [EMAIL PROTECTED], Michael Halcrow writes: On Thu, Aug 23, 2007 at 04:42:59PM +0900, Ryusuke Konishi wrote: This will avoid a possible fault in ecryptfs_sync_page(). Acked-by: Michael Halcrow [EMAIL PROTECTED] Note that there are other outstanding issues with eCryptfs on NFS.

[PATCH] 2.6.23-rc2 error compiling fs/drop_caches.c (struct super_block errors)

2007-08-11 Thread Erez Zadok
I'm getting a lot of warnings about struct super_block in 2.6.23-rc2. Then, a compile error when compiling fs/drop_caches.o: CC fs/drop_caches.o In file included from fs/drop_caches.c:7: include/linux/mm.h:1210: warning: 'struct super_block' declared inside parameter list

[PATCH] 2.6.23-rc2 error compiling fs/drop_caches.c (struct super_block errors)

2007-08-11 Thread Erez Zadok
I'm getting a lot of warnings about struct super_block in 2.6.23-rc2. Then, a compile error when compiling fs/drop_caches.o: CC fs/drop_caches.o In file included from fs/drop_caches.c:7: include/linux/mm.h:1210: warning: 'struct super_block' declared inside parameter list

Re: JFFS2/mtdsuper modprobe "unknown symbol" in 2.6.23-rc1

2007-08-09 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Adrian Bunk writes: > On Thu, Aug 09, 2007 at 10:38:18PM -0400, Erez Zadok wrote: > > I'm getting an error modprobing jffs2 due to mtdsuper failing to insmod: > >... > > Does anyone know what am I missing? > > You miss that 2

JFFS2/mtdsuper modprobe "unknown symbol" in 2.6.23-rc1

2007-08-09 Thread Erez Zadok
I'm getting an error modprobing jffs2 due to mtdsuper failing to insmod: # modprobe jffs2 WARNING: Error inserting mtdsuper (/lib/modules/2.6.23-rc1/kernel/drivers/mtd/mtdsuper.ko): Unknown symbol in module, or unknown parameter (see dmesg) FATAL: Error inserting jffs2

Re: JFFS2/mtdsuper modprobe unknown symbol in 2.6.23-rc1

2007-08-09 Thread Erez Zadok
In message [EMAIL PROTECTED], Adrian Bunk writes: On Thu, Aug 09, 2007 at 10:38:18PM -0400, Erez Zadok wrote: I'm getting an error modprobing jffs2 due to mtdsuper failing to insmod: ... Does anyone know what am I missing? You miss that 2.6.23-rc2 with this bug fixed has already been

JFFS2/mtdsuper modprobe unknown symbol in 2.6.23-rc1

2007-08-09 Thread Erez Zadok
I'm getting an error modprobing jffs2 due to mtdsuper failing to insmod: # modprobe jffs2 WARNING: Error inserting mtdsuper (/lib/modules/2.6.23-rc1/kernel/drivers/mtd/mtdsuper.ko): Unknown symbol in module, or unknown parameter (see dmesg) FATAL: Error inserting jffs2

Re: unionfs and snmpd kernle bug report

2007-08-02 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Jon Mansey writes: > kernel BUG at > /home/user/linux-modules-extra-2.6-2.6.18/debian/build/build_i386_none_686-bigmem_unionfs/build/commonfops.c:189! > Jon, please send such reports to the unionfs mailing list directly (see http://unionfs.filesystems.org/), esp.

Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 )

2007-08-02 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Josef Sipek writes: > On Wed, Aug 01, 2007 at 10:22:07AM -0700, Andrew Morton wrote: > > On Wed, 01 Aug 2007 12:33:18 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > fs/unionfs/file.c:147: error: 'file_fsync' undeclared here (not in a > > >

Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 )

2007-08-02 Thread Erez Zadok
In message [EMAIL PROTECTED], Josef Sipek writes: On Wed, Aug 01, 2007 at 10:22:07AM -0700, Andrew Morton wrote: On Wed, 01 Aug 2007 12:33:18 +0200 Gabriel C [EMAIL PROTECTED] wrote: fs/unionfs/file.c:147: error: 'file_fsync' undeclared here (not in a function) make[2]:

Re: unionfs and snmpd kernle bug report

2007-08-02 Thread Erez Zadok
In message [EMAIL PROTECTED], Jon Mansey writes: kernel BUG at /home/user/linux-modules-extra-2.6-2.6.18/debian/build/build_i386_none_686-bigmem_unionfs/build/commonfops.c:189! Jon, please send such reports to the unionfs mailing list directly (see http://unionfs.filesystems.org/), esp. when

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Dave Kleikamp writes: > On Wed, 2007-08-01 at 15:33 -0400, Josef Sipek wrote: > > On Wed, Aug 01, 2007 at 02:10:31PM -0500, Dave Kleikamp wrote: > > > On Wed, 2007-08-01 at 14:44 -0400, Josef Sipek wrote: > > > > Now what? How do you rename? Do you rename in the

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Erez Zadok
In message [EMAIL PROTECTED], Dave Kleikamp writes: On Wed, 2007-08-01 at 15:33 -0400, Josef Sipek wrote: On Wed, Aug 01, 2007 at 02:10:31PM -0500, Dave Kleikamp wrote: On Wed, 2007-08-01 at 14:44 -0400, Josef Sipek wrote: Now what? How do you rename? Do you rename in the same branch

Re: 2.6.22-rc6-mm1: UNION_FS=y + BLOCK=n = compile error

2007-07-08 Thread Erez Zadok
I'm adding Jens Axboe to the CC list (BLOCK layer maintainer). In message <[EMAIL PROTECTED]>, Adrian Bunk writes: > On Thu, Jun 28, 2007 at 03:43:21AM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.22-rc4-mm2: > >... > > git-unionfs.patch > >... > > git trees > >... > >

Re: 2.6.22-rc6-mm1: UNION_FS=y + BLOCK=n = compile error

2007-07-08 Thread Erez Zadok
I'm adding Jens Axboe to the CC list (BLOCK layer maintainer). In message [EMAIL PROTECTED], Adrian Bunk writes: On Thu, Jun 28, 2007 at 03:43:21AM -0700, Andrew Morton wrote: ... Changes since 2.6.22-rc4-mm2: ... git-unionfs.patch ... git trees ... CONFIG_UNION_FS=y,

Re: [RFD 1/4] Pass no useless nameidata to the create, lookup, and permission IOPs

2007-06-26 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, [EMAIL PROTECTED] writes: > The create, lookup, and permission inode operations are all passed a > full nameidata. This is unfortunate because in nfsd and the mqueue > filesystem, we must instantiate a struct nameidata but cannot provide > all of the same

Re: [RFD 1/4] Pass no useless nameidata to the create, lookup, and permission IOPs

2007-06-26 Thread Erez Zadok
In message [EMAIL PROTECTED], [EMAIL PROTECTED] writes: The create, lookup, and permission inode operations are all passed a full nameidata. This is unfortunate because in nfsd and the mqueue filesystem, we must instantiate a struct nameidata but cannot provide all of the same information

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-21 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Josef Sipek writes: > On Thu, Jun 21, 2007 at 10:55:45AM +0530, Bharata B Rao wrote: > ... > > Talking about copyup and whiteout at VFS layer, we have already > > demonstrated what complexity it takes to have these within VFS. Please > > take a look at the copyup

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-21 Thread Erez Zadok
In message [EMAIL PROTECTED], Josef Sipek writes: On Thu, Jun 21, 2007 at 10:55:45AM +0530, Bharata B Rao wrote: ... Talking about copyup and whiteout at VFS layer, we have already demonstrated what complexity it takes to have these within VFS. Please take a look at the copyup and

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Erez Zadok
t;http://www.filesystems.org/unionfs-odf.txt> So, to have a fully usable union mounts implementation, you're going to have to support a lot of existing features; but if you were to support them all at the VFS level, you will have bloated the VFS considerably with stuff that many would argu

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Erez Zadok
usable union mounts implementation, you're going to have to support a lot of existing features; but if you were to support them all at the VFS level, you will have bloated the VFS considerably with stuff that many would argue does not belong in the VFS. Sincerely, Erez Zadok. - To unsubscribe from

Re: [Unionfs] Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Erez Zadok
For what it's worth, the new branch-management code also needs realloc(): right now I do a kfree/kalloc instead. So I'm all for having a true krealloc function. Erez. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [Unionfs] Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Erez Zadok
For what it's worth, the new branch-management code also needs realloc(): right now I do a kfree/kalloc instead. So I'm all for having a true krealloc function. Erez. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-10 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Jan Kara writes: > > In message <[EMAIL PROTECTED]>, Jan Kara writes: [...] > > Jan, all of it is duable: we can downgrade the f/s to readonly, grab various > > locks, search through various lists looking for open fd's and such, then > > decide if to allow the mount

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-10 Thread Erez Zadok
In message [EMAIL PROTECTED], Jan Kara writes: In message [EMAIL PROTECTED], Jan Kara writes: [...] Jan, all of it is duable: we can downgrade the f/s to readonly, grab various locks, search through various lists looking for open fd's and such, then decide if to allow the mount or not.

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, "Raz Ben-Jehuda(caro)" writes: > On 1/9/07, Erez Zadok <[EMAIL PROTECTED]> wrote: > > In message <[EMAIL PROTECTED]>, Christoph Hellwig writes: > > > On Mon, Jan 08, 2007 at 07:03:35PM -0500, Erez Zadok wrote: > >

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Christoph Hellwig writes: > On Mon, Jan 08, 2007 at 07:03:35PM -0500, Erez Zadok wrote: > > However, I must caution that a file system like ecryptfs is very different > > from Unionfs, the latter being a fan-out file system---and both have ver

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Jan Kara writes: > > In message <[EMAIL PROTECTED]>, Andrew Morton writes: > > > On Sun, 7 Jan 2007 23:12:53 -0500 > > > "Josef 'Jeff' Sipek" <[EMAIL PROTECTED]> wrote: > > > > > > > +Modifying a Unionfs branch directly, while the union is mounted, is > > > >

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Trond Myklebust writes: > I'm saying that at the very least it should not Oops in these > situations. As to whether or not they are something you want to handle > more gracefully, that is up to you, but Oopses are definitely a > showstopper. > > Trond I totally

<    3   4   5   6   7   8   9   >