[PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-12 Thread Ethan Zhao
Hi, Len, Robert, Please help to check the following patch, add more conditions when validate the 64bit 32bit FACS/DSDT address in FADT to follow ACPI spec, In the meantime, keep the compatibility and latitude. Thanks, Ethan From c1116211a7b329c26b0370565c36b084ceb08f71 Mon Sep 17

Re: ACPI and NUMA guys, please help to check if this patch is OK

2012-11-13 Thread Ethan Zhao
proximity domains number %d\n, + d , pxd); + return 0; + } + for (i = 0; i d; i++) { for (j = 0; j d; j++) { u8 val = slit-entry[d*i + j]; -- 1.7.1 Thanks, Ethan On Thu, May 24, 2012 at 12:59 PM, ethan zhao

[patch] Add IVB model 3e support to /drivers/idle/intel_idle.c

2012-11-26 Thread Ethan Zhao
Hi, Len Please help to review and apply the patch if it is OK. I didn't go through all the related code, simply add the model 3e to the id list, I have tested it with stable branch kernel 3.6.7 on my Server with Intel ES0 installed. Thanks, Ethan commit

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-11-28 Thread Ethan Zhao
Joe, Possibly your customer is running a kernel without source code on a platform whose vendor wouldn't like to fix BIOS issue( Is that a HP/Dell server ?). Anyway, to see if is a payload issue or, you could change the payload size with setpci tool to those devices and set the link

[PATCH] arch/x86/pci/xen.c: fix a typo in comments

2012-12-19 Thread Ethan Zhao
Konrad, This patch fix a typo in comments of arch/x86/pci/xen.c Thanks, ethan.z...@oracle.com --- commit 333a48b76d5311ae370d65dfac293ca0d839c455 Author: ethan.zhao ethan.ker...@gmail.com Date: Thu Dec 20 20:23:31 2012 -0800 Fix a typo in comments

[patch]mpt2sas/mpt2sas_base.c temporarily mask the corrected AER bit while driver initializing to suppress AER

2012-11-15 Thread Ethan Zhao
Hi, Lsi guys, On our servers (Sun fire X3-2/2L/2B, Sun fire X4-2/2L/2B ), while loading mpt2sas driver, the _diag_reset action always triggers correct AER, So mask CRER bit before the reset action and restore it after successful resetting. Please help to check the attached patch, I

Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Ethan Zhao
Bob, Thanks for your detailed reviewing about the whole possible conditions. I.C. So that is impossible zero value for Xfacs /Xdsdt if facs/dsdt 0, for they are assigned in acpi_tb_convert_fadt(), I need to move my eyes one line code higher to see why it yelled twice but not using

Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Ethan Zhao
*/ if (acpi_gbl_reduced_hardware) { -- 1.7.1 Thanks, Ethan On Fri, Nov 16, 2012 at 11:49 AM, Moore, Robert robert.mo...@intel.com wrote: No decision(s) yet, we are still investigating -Original Message- From: Ethan Zhao [mailto:ethan.ker...@gmail.com] Sent: Thursday, November 15, 2012 7:47 PM

[PATCH] hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-07-25 Thread Ethan Zhao
commit 968320b hrtimer: Fix extra wakeups from __remove_hrtimer() introduced a significant scheduling performance regression, following is the test: a. Test environment: SUN FIRE X4170 M2 SERVER CPU model name: Intel(R) Xeon(R) CPU X5675 @ 3.07GHz 2 socket X 6 core X 2 thread b. To eliminate

[PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-26 Thread ethan zhao
Cleanup the -EINVAL return value handling and add warning message for invalid start,end,addr parameters. Signed-off-by: ethan.zhao ethan.z...@oracle.com --- arch/x86/pci/mmconfig-shared.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-27 Thread Ethan Zhao
On Sat, Jul 27, 2013 at 1:39 AM, Bjorn Helgaas bhelg...@google.com wrote: [+cc Jiang, linux-pci, -cc bjorn.helg...@hp.com (dead address)] On Fri, Jul 26, 2013 at 05:10:39PM +0800, ethan zhao wrote: Cleanup the -EINVAL return value handling and add warning message for invalid start,end,addr

Re: [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-27 Thread Ethan Zhao
Seems there are code style issues etc after I pasted it in my mail client. I will correct it and resend v2. Thanks. On Sun, Jul 28, 2013 at 12:09 AM, Bjorn Helgaas bhelg...@google.com wrote: On Sat, Jul 27, 2013 at 8:27 AM, Yinghai Lu ying...@kernel.org wrote: On Fri, Jul 26, 2013 at 10:39 AM,

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-07-30 Thread Ethan Zhao
On Tue, Jul 30, 2013 at 5:35 PM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Jul 30, 2013 at 05:12:49PM +0800, Ethan Zhao wrote: On Mon, Jul 29, 2013 at 6:18 PM, Thomas Gleixner t...@linutronix.de wrote: The test case does not involve anything hrtimer related. Do you have

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-10-04 Thread Ethan Zhao
Mike, Peter, Seems lots of work has been done these days, studious guys. those patches merged in last stable/dev branch (fix performance regression caused by extra rtimer programming and rescheduling IPI,confusing idle... etc) ? So I could just do a lazy pull for test with my environment. I

Re: Commit 07f9b61 breaks systems that don't implement a _CBA method

2013-10-05 Thread Ethan Zhao
On Sat, Oct 5, 2013 at 7:55 AM, Yinghai Lu ying...@kernel.org wrote: On Fri, Oct 4, 2013 at 3:11 PM, Bjorn Helgaas bhelg...@google.com wrote: On Thu, Oct 3, 2013 at 7:18 PM, Hedi Berriche h...@sgi.com wrote: It's regrettable that the code is so subtle. The obvious thing to do would be to

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-10-06 Thread Ethan Zhao
Got it. On Mon, Oct 7, 2013 at 12:41 PM, Mike Galbraith bitbuc...@online.de wrote: On Fri, 2013-10-04 at 20:06 +0800, Ethan Zhao wrote: Mike, Peter, Seems lots of work has been done these days, studious guys. those patches merged in last stable/dev branch (fix performance regression

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-12 Thread Ethan Zhao
On Fri, Oct 11, 2013 at 11:35 PM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Oct 11, 2013 at 10:58:18AM +0800, ethan.zhao wrote: From: ethan.zhao ethan.ker...@gmail.com While loading ixgbevf driver,every vf detected will be output as the same name 'eth4': ixgbevf: Intel(R) 10

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-12 Thread Ethan Zhao
On Sat, Oct 12, 2013 at 1:26 AM, Skidmore, Donald C donald.c.skidm...@intel.com wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, October 11, 2013 9:12 AM To: Bjorn Helgaas Cc: ethan.zhao; linux-kernel@vger.kernel.org; Skidmore, Donald C; e1000-

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-12 Thread Ethan Zhao
On Sat, Oct 12, 2013 at 12:08 AM, Bjorn Helgaas bhelg...@google.com wrote: [+cc Don, e1000-devel] On Fri, Oct 11, 2013 at 9:35 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Oct 11, 2013 at 10:58:18AM +0800, ethan.zhao wrote: From: ethan.zhao ethan.ker...@gmail.com While loading

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-12 Thread Ethan Zhao
On Sun, Oct 13, 2013 at 1:50 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Oct 12, 2013 at 02:52:51PM +0800, Ethan Zhao wrote: --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char *new_name) if (!dev

Re: Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-11-11 Thread Ethan Zhao
:44 +0800, Ethan Zhao wrote: Hi guys, We got network I/O performance degradation with latest stable kernel and the be2net driver as compared to old kernel 3.0.6. later we found even compared to the same latest stable kernel but the INTEL_IOMMU set to 'n', still got very noticeable

Re: Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-11-11 Thread Ethan Zhao
for last HTML mail, resend txt ) Ethan On Tue, Nov 12, 2013 at 9:34 AM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2013-11-12 at 09:03 +0800, Ethan Zhao wrote: Eric, We have tested the performance with the TSO and TSQ patches merged, the result not good, even worse than kernel

Re: [PATCH] PCI: Init NumVFs register to zero in sriov_init()

2013-11-13 Thread Ethan Zhao
Yinghai, Could you help to take a look, we need it in our downstream kernel. Thanks, Ethan On Wed, Nov 6, 2013 at 10:49 PM, ethan.zhao ethan.ker...@gmail.com wrote: Though no specification about NumVFs register initial value after POST, to void the confusion lspci output as following

Re: [PATCH] PCI: Init NumVFs register to zero in sriov_init()

2013-11-15 Thread Ethan Zhao
On Fri, Nov 15, 2013 at 2:59 PM, Yinghai Lu ying...@kernel.org wrote: On Wed, Nov 13, 2013 at 5:57 PM, Ethan Zhao ethan.ker...@gmail.com wrote: On Wed, Nov 6, 2013 at 10:49 PM, ethan.zhao ethan.ker...@gmail.com wrote: Though no specification about NumVFs register initial value after POST

Re: [PATCH] PCI: Init NumVFs register to zero in sriov_init()

2013-11-20 Thread Ethan Zhao
Bjorn, To be honest, the output above is picked up from other guy's mail, because I composed the patch mail at home and left the real bug material at company, they 'really' hit an issue confused by lspci output while SR-IOV is initialized to disabled . There is an error in above output as

Re: [PATCH] PCI: Init NumVFs register to zero in sriov_init()

2013-11-20 Thread Ethan Zhao
Bjorn, I revised the description part with the original bug material as below, help to take a look, will send V2 back to home, SMTP blocked by company network. PCI: Init NumVFs register to zero in sriov_init() Though no specification about NumVFs register initial value after POST, to

Re: NETDEV WATCHDOG: eth0 (e1000e): transmit queue 0 timed out

2013-12-02 Thread Ethan Zhao
Bjorn, Seems not the same bug as http://sourceforge.net/p/e1000/bugs/367/ , Nick is not running his kernel on bare metal, per the error log, he runs his kernel as HVM DomU guest or Dom0 on XEN ? so just a check of NULL will not fix that. Thanks, Ethan On Thu, Nov 21, 2013 at 5:22 AM, Bjorn

Re: [BUG] Re: [PATCH v10 1/3] aerdrv: Trace Event for AER

2013-12-04 Thread Ethan Zhao
Rui, Agree with that, there are really many such confusing error type definition need to be standardized or unified, some of them are ambiguous、inconsistent, some of them violates ACPI/PCI spec. According to the ACPI spec, the 'FATAL' in fact, is a sub-category of 'UNCORRECTABLE' , the

Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-10-30 Thread Ethan Zhao
Hi guys, We got network I/O performance degradation with latest stable kernel and the be2net driver as compared to old kernel 3.0.6. later we found even compared to the same latest stable kernel but the INTEL_IOMMU set to 'n', still got very noticeable performance regression: Kernel :

Re: Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-11-01 Thread Ethan Zhao
Eric, Thanks, hope it could kill the most pain of the regression. I will try them and report the result. Ethan You might hit a known problem for some 10Gb links. 3.12-rc6 has the fixes already, and stable has some pending backports : commit 95bd09eb27507691520d39ee1044d6ad831c1168 tcp:

[PATCH] [media] saa7146: check return value of saa7146_format_by_fourcc() to avoid NULL pointer

2014-01-06 Thread Ethan Zhao
Function saa7146_format_by_fourcc() may return NULL, reference of the returned result would cause NULL pointer issue without checking. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/media/common/saa7146/saa7146_hlp.c | 22 +++--- 1 file changed, 19 insertions(+), 3

[PATCH] [media] cx18: introduce a helper function to avoid array overrun

2014-01-06 Thread Ethan Zhao
cx18_i2c_register() is called in cx18_init_subdevs() with index greater than length of hw_bus array, that will cause array overrun, introduce a helper cx18_get_max_bus_num() to avoid it. V2: fix a typo and use ARRAY_SIZE macro Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/media

Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-06 Thread Ethan Zhao
David, Got it. thanks, Ethan On Sun, Jan 5, 2014 at 10:05 AM, David Miller da...@davemloft.net wrote: From: Ethan Zhao ethan.ker...@gmail.com Date: Wed, 11 Dec 2013 22:54:21 +0800 Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might

Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-06 Thread Ethan Zhao
cc sparcli...@vger.kernel.org On Wed, Dec 11, 2013 at 10:54 PM, Ethan Zhao ethan.ker...@gmail.com wrote: Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- arch/sparc

[PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-07 Thread Ethan Zhao
Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- arch/sparc/kernel/mdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/mdesc.c b

[PATCH] media: gspaca: check pointer against NULL before using it in create_urbs()

2014-01-07 Thread Ethan Zhao
function alt_xfer() may return NULL, should check its return value passed into create_urbs() as parameter. gspca_init_transfer() { ... ... ret = create_urbs(gspca_dev,alt_xfer(intf-altsetting[alt], xfer)); ... ... } Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/media/usb/gspca

[PATCH Trivial] intel-iommu: check return value of device_to_iommu() before using it

2014-01-08 Thread ethan zhao
in function iommu_support_dev_iotlb(),return value of device_to_iommu() is used without checking, this could cause NULL pointer issue. this patch is for v3.12.6 Signed-off-by: Ethan Zhao ethan.z...@oracle.com --- drivers/iommu/intel-iommu.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: [PATCH Trivial] intel-iommu: check return value of device_to_iommu() before using it

2014-01-09 Thread Ethan Zhao
On Thu, Jan 9, 2014 at 8:01 PM, Joerg Roedel j...@8bytes.org wrote: On Thu, Jan 09, 2014 at 09:58:42AM +0800, ethan zhao wrote: drivers/iommu/intel-iommu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c

Re: [PATCH 1/2 v2] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, I will check the patch and make it pass the building, seems encoding issue. Thanks, Ethan On Wed, Jan 15, 2014 at 11:46 AM, Brown, Aaron F aaron.f.br...@intel.com wrote: On Fri, 2013-12-27 at 01:02 -0800, Jeff Kirsher wrote: On Wed, 2013-12-25 at 00:12 +0800, Ethan Zhao wrote

[PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v2: fix a typo. v3: fix a encoding issue. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/net/ethernet/intel/ixgbe

[PATCH 2/2] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread Ethan Zhao
() before enable VFs with ixgbe_enable_sriov(). Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
On Thu, Jan 16, 2014 at 6:00 AM, Brown, Aaron F aaron.f.br...@intel.com wrote: On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote: Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Zhao wrote: On Thu, Jan 16, 2014 at 6:00 AM, Brown, Aaron F aaron.f.br...@intel.com wrote: On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote: Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Ok, Dave Miler's net-next tree. Thanks, Etan On Thu, Jan 16, 2014 at 10:51 AM, Brown, Aaron F aaron.f.br...@intel.com wrote: On Thu, 2014-01-16 at 09:58 +0800, Ethan Zhao wrote: Aaron, Is this your net-next repo ? if so, I rebuild the patch with this repo right now . git

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Revised those patches for Dave Miller's net-next OK, passed building. resent. Thanks, Ethan On Thu, Jan 16, 2014 at 11:08 AM, Ethan Zhao ethan.ker...@gmail.com wrote: Aaron, Ok, Dave Miler's net-next tree. Thanks, Etan On Thu, Jan 16, 2014 at 10:51 AM, Brown, Aaron F

[PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread ethan zhao
Because ixgbe driver limit the max number of VF functions could be enalbed to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v3: revised for net-next tree. Signed-off-by: Ethan Zhao ethan.z...@oracle.com Signed-off-by: Ethan Zhao ethan.ker...@gmail.com

[PATCH 2/2 Net-next] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread ethan zhao
() before enable VFs with ixgbe_enable_sriov(). V2: revised for net-next tree. Signed-off-by: Ethan Zhao ethan.z...@oracle.com Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
, 2014 at 1:57 PM, David Miller da...@davemloft.net wrote: From: ethan zhao ethan.z...@oracle.com Date: Thu, 16 Jan 2014 12:25:01 +0800 Signed-off-by: Ethan Zhao ethan.z...@oracle.com Signed-off-by: Ethan Zhao ethan.ker...@gmail.com Please don't give two signoffs for yourself

[PATCH 1/2 net-next v4] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread ethan zhao
Because ixgbe driver limit the max number of VF functions could be enalbed to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v3: revised for net-next tree. V4: remove one signoff of two. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/net

[PATCH 2/2 Net-next v4] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread ethan zhao
() before enable VFs with ixgbe_enable_sriov(). V2: revised for net-next tree. V4: remove one signoff of two. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-10 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 4:19 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Dec 10, 2013 at 04:03:41PM +0800, Ethan Zhao wrote: On Tue, Dec 10, 2013 at 2:40 AM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote: Greg, I am

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-10 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 10:11 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: Ethan Zhao ethan.ker...@gmail.com wrote: Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit

[PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2013-12-11 Thread Ethan Zhao
Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- arch/sparc/kernel/mdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/mdesc.c b

[PATCH] RDMA/cxgb4: replace __GFP_NOFAIL with GFP_ATOMIC

2013-12-11 Thread Ethan Zhao
. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/infiniband/hw/cxgb4/mem.c | 2 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 19 ++- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-12-12 Thread Ethan Zhao
' to all the buggy CPU, is that right ? Thanks, Ethan On Mon, Oct 7, 2013 at 12:57 PM, Ethan Zhao ethan.ker...@gmail.com wrote: Got it. On Mon, Oct 7, 2013 at 12:41 PM, Mike Galbraith bitbuc...@online.de wrote: On Fri, 2013-10-04 at 20:06 +0800, Ethan Zhao wrote: Mike, Peter, Seems

[PATCH] ghes: don't return 0 even when failed to read estatus in ghes_proc()

2013-12-27 Thread Ethan Zhao
ghes_proc() always return 0 even failed to read estatus, so when it is called in interrupt handler ghes_irq_func(), we don't know the interrupt was handled well or not, because the ghes_irq_func() will return only IRQ_HANDLED. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/acpi

[PATCH] [media] cx18: introduce a helper function to void array overrun

2014-01-04 Thread Ethan Zhao
cx18_i2c_register() is called in cx18_init_subdevs() with index greater than length of hw_bus array, that will cause array overrun, introduce a helper cx18_get_max_bus_num() to void it. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/media/pci/cx18/cx18-driver.c | 2 +- drivers

[PATCH] [media] saa7146: fix a possible NULL pointer reference in saa7146_set_position

2014-01-04 Thread Ethan Zhao
Function saa7146_format_by_fourcc() may return NULL, reference of the returned result would cause NULL pointer issue without checking. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/media/common/saa7146/saa7146_hlp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

Re: [PATCH] [media] saa7146: fix a possible NULL pointer reference in saa7146_set_position

2014-01-05 Thread Ethan Zhao
: On Sun, Jan 05, 2014 at 10:08:00AM +0800, Ethan Zhao wrote: Function saa7146_format_by_fourcc() may return NULL, reference of the returned result would cause NULL pointer issue without checking. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/media/common/saa7146/saa7146_hlp.c

Re: [PATCH] [media] cx18: introduce a helper function to void array overrun

2014-01-05 Thread Ethan Zhao
On Sun, Jan 5, 2014 at 2:09 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Ethan, On Sun, Jan 05, 2014 at 09:17:39AM +0800, Ethan Zhao wrote: cx18_i2c_register() is called in cx18_init_subdevs() with index greater than length of hw_bus array, that will cause array overrun, introduce

Re: [PATCH v10 1/3] aerdrv: Trace Event for AER

2013-12-06 Thread Ethan Zhao
On Fri, Dec 6, 2013 at 5:06 PM, rui wang ruiv.w...@gmail.com wrote: On 12/5/13, Borislav Petkov b...@alien8.de wrote: Yes, the AER tracepoint above should use the AER_* defines and not the HW_EVENT_ERR_* ones which are for memory errors. Wanna send a fix? Yes. Does it translate into

Re: Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-12-06 Thread Ethan Zhao
Jiang, Could you help to take a look such performance issue about Intel IOMMU, seems you go back this field of Intel. Is it possible to eliminate the performance side effect of mapping and unmapping operation ? some context information, please refer to the first mail of this loop. Thanks,

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-07 Thread Ethan Zhao
Rui, I like this patch. thanks your revision. Ethan On Sun, Dec 8, 2013 at 12:17 PM, Rui Wang ruiv.w...@gmail.com wrote: There's inconsistency between dmesg and the trace event output. When dmesg says severity=Corrected, the trace event says severity=Fatal. What happens is that

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-08 Thread Ethan Zhao
On Sun, Dec 8, 2013 at 10:01 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote: Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake

Re: NETDEV WATCHDOG: eth0 (e1000e): transmit queue 0 timed out

2013-12-08 Thread Ethan Zhao
, Ethan Zhao ethan.ker...@gmail.com wrote: Bjorn, Seems not the same bug as http://sourceforge.net/p/e1000/bugs/367/ , Nick is not running his kernel on bare metal, per the error log, he runs his kernel as HVM DomU guest or Dom0 on XEN ? so just a check of NULL will not fix that. Sorry

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
On Mon, Dec 9, 2013 at 4:25 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 09:43:16AM +0800, Ethan Zhao wrote: On Sun, Dec 8, 2013 at 10:01 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote: Should check debugfs

[PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Ethan Zhao
From: Ethan Zhao ethan.ker...@gmail.com Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/scsi/iscsi_boot_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
From: Ethan Zhao ethan.ker...@gmail.com Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake debugfs_create_dir() etc functions would be ERR_PTR(-ENODEV), checking with NULL will not work. V2: change

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
On Mon, Dec 9, 2013 at 4:55 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 04:44:05PM +0800, Ethan Zhao wrote: On Mon, Dec 9, 2013 at 4:25 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 09:43:16AM +0800, Ethan Zhao wrote: On Sun, Dec 8, 2013

[PATCH v3] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
From: ethan.zhao ethan.ker...@gmail.com Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake debugfs_create_dir() etc functions would be ERR_PTR(-ENODEV), checking with NULL will not work. V3: add warning

Re: [PATCH v2] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
All, Please ignore this one, sorry, see v3. Thanks, Ethan On Mon, Dec 9, 2013 at 5:42 PM, Ethan Zhao ethan.ker...@gmail.com wrote: From: Ethan Zhao ethan.ker...@gmail.com Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized

Re: [PATCH v3] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
Greg, How about the V3 ? Thanks, Ethan On Mon, Dec 9, 2013 at 5:56 PM, Ethan Zhao ethan.ker...@gmail.com wrote: From: ethan.zhao ethan.ker...@gmail.com Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value

[PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
From: Ethan Zhao ethan.ker...@gmail.com Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake debugfs_create_dir() etc functions would be ERR_PTR(-ENODEV), checking with NULL will not work. V3: Add warning

[PATCH v4] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
message about debugfs not configured or disabled. V4: make the warning clear. Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- arch/x86/xen/debugfs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/xen/debugfs.c b/arch/x86/xen/debugfs.c index c8377fb..7f3804c 100644

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
as zswap_debugfs, tracer_debugfs ,rproc_debugfs did. Is it useless ? if it could save me just 1 minute next time ? Thanks, Ethan On Mon, Dec 9, 2013 at 7:17 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 05:57:22PM +0800, Ethan Zhao wrote: On Mon, Dec 9, 2013 at 4:55 PM, Greg KH

Re: [PATCH v3] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
On Mon, Dec 9, 2013 at 7:19 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 05:56:52PM +0800, Ethan Zhao wrote: From: ethan.zhao ethan.ker...@gmail.com Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized

Re: [PATCH v2 04/10] PCI: Destroy pci dev only once

2013-12-09 Thread Ethan Zhao
On Sun, Dec 8, 2013 at 11:50 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Dec 07, 2013 at 07:31:21PM -0800, Yinghai Lu wrote: [+ GregKH] On Fri, Dec 6, 2013 at 5:27 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, December 05, 2013 10:52:36 PM Yinghai Lu

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Ethan Zhao
...@oracle.com wrote: On Mon, Dec 09, 2013 at 05:37:11PM +0800, Ethan Zhao wrote: From: Ethan Zhao ethan.ker...@gmail.com Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Is there a stack trace? Signed-off-by: Ethan Zhao

Re: [PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

2013-12-09 Thread Ethan Zhao
Laurent, Next time I scan the NULL check, if hit your driver again, I will resend it. Thanks, Ethan On Tue, Dec 10, 2013 at 10:24 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Ethan, Thank you for the patch. On Sunday 08 December 2013 10:41:46 ethan.zhao wrote:

Re: [PATCH] mm/slab.c: check pointer slabp before using it in alloc_slabmgmt()

2013-12-09 Thread Ethan Zhao
Christoph, Found in the latest stable release V3.12.3, yes, changed in 3.12.4. not needed for later release anymore. Thanks, Ethan On Tue, Dec 10, 2013 at 12:11 AM, Christoph Lameter c...@linux.com wrote: On Sun, 8 Dec 2013, ethan.zhao wrote: Move the NULL check of slabp to the right

Re: [PATCH v2 04/10] PCI: Destroy pci dev only once

2013-12-09 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 3:08 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 11:24:04PM +0800, Ethan Zhao wrote: On Sun, Dec 8, 2013 at 11:50 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Dec 07, 2013 at 07:31:21PM -0800, Yinghai Lu wrote

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-10 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 2:40 AM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote: Greg, I am the man who built a Xen dom0, but couldn't see debugfs directory and files as expected. there is no warning or tip for me to enable

Re: [PATCH] mm/slab.c: check pointer slabp before using it in alloc_slabmgmt()

2013-12-10 Thread Ethan Zhao
Christoph, No, stable 3.12.4 and 3.12.3 need this patch. 3.13RC doesn't need it anymore. Thanks, Ethan On Tue, Dec 10, 2013 at 3:08 PM, Ethan Zhao ethan.ker...@gmail.com wrote: Christoph, Found in the latest stable release V3.12.3, yes, changed in 3.12.4. not needed for later

Re: [PATCH NET-NEXT V2] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-09 Thread ethan zhao
On 2014/7/9 19:45, vaughan wrote: On 07/09/2014 07:32 PM, Manish Chopra wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of ethan zhao Sent: Wednesday, July 09, 2014 8:11 AM To: David Miller Cc: ba...@ti.com; netdev; linux

[PATCH 4/4] i40e: use PCI VFs assignment helper function simplify i40e_vfs_are_assigned()

2014-07-10 Thread Ethan Zhao
New VFs reference counter mechanism and VFs assignment helper functions are introduced to PCI SRIOV, use them instead of manipulating device flag directly. Signed-off-by: Ethan Zhao ethan.z...@oracle.com --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 17 ++--- 1 files

[PATCH 1/4] PCI: introduce VFs reference counter and simplify pci_vfs_assigned() implementation

2014-07-10 Thread Ethan Zhao
pci_sriov, and compose two more helper functions pci_sriov_assign_device(), pci_sriov_deassign_device() to replace manipulation to device flag and the meanwhile increase and decease the counter. Passed building on 3.15.5 Signed-off-by: Ethan Zhao ethan.z...@oracle.com --- drivers/pci/iov.c

[PATCH 3/4] KVM: use PCI VFs assignment helper functions

2014-07-10 Thread Ethan Zhao
New VFs reference counter mechanism and VFs assignment helper functions are introduced to PCI SRIOV, use them instead of manipulating device flag directly. Signed-off-by: Ethan Zhao ethan.z...@oracle.com --- virt/kvm/assigned-dev.c |2 +- virt/kvm/iommu.c|4 ++-- 2 files changed

[PATCH 2/4] xen-pciback: use PCI VFs assignment helper functions

2014-07-10 Thread Ethan Zhao
New VFs reference counter mechanism and VFs assignment helper functions are introduced to PCI SRIOV, use them instead of manipulating device flag directly. Signed-off-by: Ethan Zhao ethan.z...@oracle.com --- drivers/xen/xen-pciback/pci_stub.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [PATCH 1/4] PCI: introduce VFs reference counter and simplify pci_vfs_assigned() implementation

2014-07-10 Thread ethan zhao
-11 at 08:47 +0800, Ethan Zhao wrote: Current implementation of helper function pci_vfs_assigned() is a little complex, to get sum of VFs that assigned to VM, access low level configuration space register and then loop in traversing device tree. This patch introduce an atomic reference counter

Re: [PATCH 1/4] PCI: introduce VFs reference counter and simplify pci_vfs_assigned() implementation

2014-07-10 Thread ethan zhao
On 2014/7/11 10:22, Alex Williamson wrote: On Fri, 2014-07-11 at 10:10 +0800, ethan zhao wrote: Alex, Thanks for your reviewing, when I create the patch order, I thought about the question you concerned for quit a while, make every patch be independent to each other as possible as I could

Re: [PATCH 1/4] PCI: introduce VFs reference counter and simplify pci_vfs_assigned() implementation

2014-07-10 Thread ethan zhao
On 2014/7/11 10:33, Alex Williamson wrote: On Fri, 2014-07-11 at 10:29 +0800, ethan zhao wrote: On 2014/7/11 10:22, Alex Williamson wrote: On Fri, 2014-07-11 at 10:10 +0800, ethan zhao wrote: Alex, Thanks for your reviewing, when I create the patch order, I thought about the question

[PATCH 1/2 V2] PCI: introduce device assignment interface and refactory related code

2014-07-10 Thread Ethan Zhao
-by: Ethan Zhao ethan.z...@oracle.com --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 17 ++--- drivers/pci/iov.c | 20 drivers/xen/xen-pciback/pci_stub.c |4 ++-- include/linux/pci.h

[PATCH 2/2 V2] PCI: implement VFs assignment reference counter

2014-07-10 Thread Ethan Zhao
in struct pci_sriov. and simplify the code in pci_vfs_assigned(). v2: reorder the patchset according to the suggestion from alex.william...@redhat.com Signed-off-by: Ethan Zhao ethan.z...@oracle.com --- drivers/pci/iov.c | 45 + drivers/pci/pci.h |1

[PATCH 2/2 V3] PCI: implement VFs assignment reference counter

2014-07-11 Thread Ethan Zhao
-by: Ethan Zhao ethan.z...@oracle.com --- drivers/pci/iov.c | 42 -- drivers/pci/pci.h |1 + 2 files changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 090f827..10efe43 100644 --- a/drivers/pci/iov.c

[PATCH 1/2 V3] PCI: introduce device assignment interface and refactory related code

2014-07-11 Thread Ethan Zhao
and atomic, steps clear between interface defination and implemenation according to the suggestion from alex.william...@redhat.com Signed-off-by: Ethan Zhao ethan.z...@oracle.com --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 17 ++--- drivers/pci/iov.c

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-18 Thread Ethan Zhao
在 2014年7月19日,上午2:21,Rajesh Borundia rajesh.borun...@qlogic.com 写道: -Original Message- From: Ethan Zhao [mailto:ethan.z...@oracle.com] Sent: Friday, July 18, 2014 9:13 AM To: Manish Chopra; Sony Chacko; Rajesh Borundia; netdev Cc: linux-kernel; ethan.ker...@gmail.com; Ethan Zhao

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
On Sat, Jul 19, 2014 at 6:19 PM, Francois Romieu rom...@fr.zoreil.com wrote: Ethan Zhao ethan.ker...@gmail.com : ?? 2014??7??192:21??Rajesh Borundia rajesh.borun...@qlogic.com ?? [...] I think ethtool stats are adapter specific. Driver does not maintain rx_dropped stats and we

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
在 2014年7月20日,上午12:28,Francois Romieu rom...@fr.zoreil.com 写道: Ethan Zhao ethan.ker...@gmail.com : On Sat, Jul 19, 2014 at 6:19 PM, Francois Romieu rom...@fr.zoreil.com wrote: Ethan Zhao ethan.ker...@gmail.com : [...] I'd rather see ethtool stats provides one of those: 1. hardware

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
(stats.rxdropped)}, {tx_dropped, NETXEN_NIC_STAT(stats.txdropped)}, {csummed, NETXEN_NIC_STAT(stats.csummed)}, So fix the rx_dropped field with my patch is the right way. the patch is not intended to dump hardware statistic counters. Thanks, Ethan On Sun, Jul 20, 2014 at 8:43 AM, Ethan Zhao

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-20 Thread Ethan Zhao
-- Forwarded message -- From: Francois Romieu rom...@fr.zoreil.com Date: Mon, Jul 21, 2014 at 2:01 AM Subject: Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats() To: Ethan Zhao ethan.ker...@gmail.com Cc: Rajesh Borundia rajesh.borun

  1   2   3   4   5   6   7   >