Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register

2020-08-27 Thread Felipe Balbi
Hi, Paul Cercueil writes: > The 'reg' value was written to a hardware register in > ingenic_usb_phy_init(), while not being initialized anywhere. your patch does a lot more than fix the bug :-) > Fixes: 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new Ingenic SoCs.") > Signed-off-by: Paul

Re: [PATCH 2/2] usb: dwc3: Add driver for Xilinx platforms

2020-08-27 Thread Felipe Balbi
Manish Narani writes: > Add a new driver for supporting Xilinx platforms. This driver handles > the USB 3.0 PHY initialization and PIPE control & reset operations for PHY initialization should be done as part of a drivers/phy driver. > ZynqMP platforms. This also handles the USB 2.0 PHY

Re: [PATCH] usb: dwc3: Stop active transfers before halting the controller

2020-08-19 Thread Felipe Balbi
Hi, Wesley Cheng writes: > In the DWC3 databook, for a device initiated disconnect, the driver is > required to send dependxfer commands for any pending transfers. > In addition, before the controller can move to the halted state, the SW > needs to acknowledge any pending events. If the

Re: [PATCH] usb: gadget: aspeed: fixup vhub port irq handling

2020-08-17 Thread Felipe Balbi
Hi, rentao.b...@gmail.com writes: > From: Tao Ren > > This is a follow-on patch for commit a23be4ed8f48 ("usb: gadget: aspeed: > improve vhub port irq handling"): for_each_set_bit() is replaced with > simple for() loop because for() loop runs faster on ASPEED BMC. > > Signed-off-by: Tao Ren >

Re: [PATCH v8 2/2] phy: Add USB3 PHY support for Intel LGM SoC

2020-08-17 Thread Felipe Balbi
Hi On Mon, Aug 17, 2020 at 6:13 AM Ramuthevar,Vadivel MuruganX > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > index c27408e4daae..90030ff299eb 100644 > --- a/drivers/phy/Makefile > +++ b/drivers/phy/Makefile > @@ -1,4 +1,4 @@ > -# SPDX-License-Identifier: GPL-2.0 >

Re: [PATCH v11 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-08-12 Thread Felipe Balbi
"Sandeep Maheswaram (Temp)" writes: > Hi > > On 8/12/2020 12:27 PM, Felipe Balbi wrote: >> "Sandeep Maheswaram (Temp)" writes: >> >>> Hi Felipe, >>> >>> On 7/28/2020 12:50 AM, Matthias Kaehlcke wrote: >>>&g

Re: [PATCH v11 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-08-12 Thread Felipe Balbi
"Sandeep Maheswaram (Temp)" writes: > Hi Felipe, > > On 7/28/2020 12:50 AM, Matthias Kaehlcke wrote: >> On Mon, Jul 27, 2020 at 10:36:36PM +0530, Sandeep Maheswaram wrote: >>> Add interconnect support in dwc3-qcom driver to vote for bus >>> bandwidth. >>> >>> This requires for two different

Re: [PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic

2020-08-11 Thread Felipe Balbi
Hi, Paras Sharma writes: > The current implementation reduces the sampling rate by half > if qup HW version greater is than 2.5 by checking if the geni ^^^ is greater than could, possibly, be fixed while applying. > SE major version is

Re: [PATCH 2/2] usb: dwc3: Host wake up support from system suspend

2020-08-11 Thread Felipe Balbi
Sandeep Maheswaram writes: > Avoiding phy powerdown in host mode so that it can be wake up by devices. > Set usb controller wakeup capable when wakeup capable devices are > connected to the host. > > Signed-off-by: Sandeep Maheswaram > --- > drivers/usb/dwc3/core.c | 47

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-11 Thread Felipe Balbi
Hi, Wesley Cheng writes: > On 8/10/2020 5:27 AM, Felipe Balbi wrote: >> Wesley Cheng writes: >> >> Hi, >> >>> Some devices have USB compositions which may require multiple endpoints >>> that support EP bursting. HW defined T

Re: [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency

2020-08-10 Thread Felipe Balbi
Arnd Bergmann writes: > On Fri, Aug 7, 2020 at 3:59 PM Felipe Balbi wrote: >> Krzysztof Kozlowski writes: > >> > +#include >> > + >> > #define S3C2443_CLKREG(x)((x) + S3C24XX_VA_CLKPWR) >> > >> > #define S3C2443_PLLCON_MD

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-10 Thread Felipe Balbi
Wesley Cheng writes: Hi, > Some devices have USB compositions which may require multiple endpoints > that support EP bursting. HW defined TX FIFO sizes may not always be > sufficient for these compositions. By utilizing flexible TX FIFO > allocation, this allows for endpoints to request the

Re: [PATCH 3/3] usb: dwc3: dwc3-qcom: Find USB connector and register role switch

2020-08-10 Thread Felipe Balbi
Hi, Wesley Cheng writes: > @@ -190,6 +195,73 @@ static int dwc3_qcom_register_extcon(struct dwc3_qcom > *qcom) > return 0; > } > > +static int dwc3_qcom_usb_role_switch_set(struct usb_role_switch *sw, > + enum usb_role role) > +{ > + struct

Re: [PATCH v4 7/7] irqchip: qcom-pdc: Reset all pdc interrupts during init

2020-08-10 Thread Felipe Balbi
Maulik Shah writes: > Clear previous kernel's configuration during init by resetting > interrupts in enable bank to zero. > > Suggested-by: Stephen Boyd > Signed-off-by: Maulik Shah > --- > drivers/irqchip/qcom-pdc.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > >

Re: [PATCH v2 08/41] usb: gadget: s3c: use platform resources

2020-08-07 Thread Felipe Balbi
his and the following patch through my tree, let me know. Otherwise: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency

2020-08-07 Thread Felipe Balbi
Krzysztof Kozlowski writes: > From: Arnd Bergmann > > There is no real phy driver, so s3c-hsudc just pokes the registers > itself. Improve this a little by making it a platform data callback > like we do for gpios. > > There is only one board using this driver, and it's unlikely > that another

Re: [PATCH] usb: dwc2: Fix parameter type in function pointer prototype

2020-07-25 Thread Felipe Balbi
Hi, Nathan Chancellor writes: > On Sat, Jul 25, 2020 at 08:19:47AM +0200, Greg Kroah-Hartman wrote: >> On Fri, Jul 24, 2020 at 11:03:54PM -0700, Nathan Chancellor wrote: >> > When booting up on a Raspberry Pi 4 with Control Flow Integrity checking >> > enabled, the following warning/panic

Re: [PATCH] usb: dwc2: Fix parameter type in function pointer prototype

2020-07-25 Thread Felipe Balbi
Greg Kroah-Hartman writes: > On Fri, Jul 24, 2020 at 11:03:54PM -0700, Nathan Chancellor wrote: >> When booting up on a Raspberry Pi 4 with Control Flow Integrity checking >> enabled, the following warning/panic happens: >> >> [1.626435] CFI failure (target: dwc2_set_bcm_params+0x0/0x4): >>

Re: [PATCH v2 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC

2020-07-25 Thread Felipe Balbi
"Ramuthevar,Vadivel MuruganX" writes: > From: Ramuthevar Vadivel Murugan > > Add support for USB PHY on Intel LGM SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan > use drivers/phy/ instead. -- balbi signature.asc Description: PGP signature

Re: [PATCH v6 3/5] USB: PHY: JZ4770: Add support for new Ingenic SoCs.

2020-07-25 Thread Felipe Balbi
Hi, 周琰杰 (Zhou Yanjie) writes: > Add support for probing the phy-jz4770 driver on the JZ4780 SoC, > the X1000 SoC and the X1830 SoC from Ingenic. > > Tested-by: 周正 (Zhou Zheng) > Co-developed-by: 漆鹏振 (Qi Pengzhen) > Signed-off-by: 漆鹏振 (Qi Pengzhen) > Signed-off-by: 周琰杰 (Zhou Yanjie) It

Re: 回复: [PATCH] usb: gadget: function: printer: Add gadget dev interface status judgment

2020-07-25 Thread Felipe Balbi
Greg KH writes: > On Wed, Jun 24, 2020 at 08:59:40AM +, Zhang, Qiang wrote: >> Hello, Greg KH >> Please have you review the patch? > > I am not the gadget driver maintainer :) > > Give Felipe a chance to catch up... It has been in my testing/next for a while, actually :-) -- balbi

Re: [PATCH v3 0/3] Add USB role switch support to DWC2

2020-07-24 Thread Felipe Balbi
Amelie DELAUNAY writes: > Hi, > > On 7/24/20 3:50 PM, Felipe Balbi wrote: >> >> (no top-posting, please) >> >> Hi, >> >> Amelie DELAUNAY writes: >>> Series dropped. >> >> what do you mean with this? Should I drop all patche

Re: [PATCH v3 0/3] Add USB role switch support to DWC2

2020-07-24 Thread Felipe Balbi
(no top-posting, please) Hi, Amelie DELAUNAY writes: > Series dropped. what do you mean with this? Should I drop all patches related with this series? -- balbi signature.asc Description: PGP signature

Re: [PATCH 0/3] Add USB role switch support to DWC2

2020-07-24 Thread Felipe Balbi
(please, no top-posting ;-) Hi, Amelie DELAUNAY writes: > Hi Felipe, > > I saw that you took DT patch (ARM: dts: stm32: enable usb-role-switch on > USB OTG on stm32mp15xx-dkx) in your next branch. As it was already in > Alex' stm32-next branch, a potential merge conflict could occurred.

Re: [PATCH] usb: gadget: epautoconf: claim smallest endpoints first

2020-07-23 Thread Felipe Balbi
Ruslan Bilovol writes: > UDC hardware may have endpoints with different maxpacket > size. Current endpoint matching code takes first matching > endpoint from the list. > > It's always possible that gadget allocates endpoints for > small transfers (maxpacket size) first, then larger ones. > That

Re: [RFC for-5.8] usb: dwc2: Cleanup debugfs when usb_add_gadget_udc() fails

2020-07-23 Thread Felipe Balbi
Minas Harutyunyan writes: > Hi Martin, > > On 6/29/2020 10:03 PM, Martin Blumenstingl wrote: >> Call dwc2_debugfs_exit() when usb_add_gadget_udc() has failed. This >> ensure that the debugfs entries created by dwc2_debugfs_init() are >> cleaned up in the error path. >> >> Fixes: 207324a321a866

Re: [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse

2020-07-23 Thread Felipe Balbi
doubt anyone is using it anymore. > > So just remove the file entirely, it was never documented, so obviously, > no one actually needed it :) > > Cc: Felipe Balbi > Signed-off-by: Greg Kroah-Hartman applied both, thanks Greg. -- balbi signature.asc Description: PGP signature

Re: [PATCH v5 0/4] Add USB PHY support for new Ingenic SoCs.

2020-07-23 Thread Felipe Balbi
周琰杰 (Zhou Yanjie) writes: > 1.separate the adjustments to the code style into > a separate patch. > 2.Modify the help message, make it more future-proof. > 3.Drop the unnecessary comment about hardware reset. > 4.Create 'soc_info' structures instead having ID_* as platform data. For v5.10,

Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

2020-07-21 Thread Felipe Balbi
Hi, Lee Jones writes: > On Tue, 21 Jul 2020, Felipe Balbi wrote: > >> Minas Harutyunyan writes: >> >> > Hi Felipe, >> > >> > On 7/21/2020 1:43 PM, Felipe Balbi wrote: >> >> Minas Harutyunyan writes: >> >> >> >>

Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

2020-07-21 Thread Felipe Balbi
Minas Harutyunyan writes: > Hi Felipe, > > On 7/21/2020 1:43 PM, Felipe Balbi wrote: >> Minas Harutyunyan writes: >> >>> On 7/15/2020 1:32 PM, Lee Jones wrote: >>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2 >>

Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

2020-07-21 Thread Felipe Balbi
Minas Harutyunyan writes: > On 7/15/2020 1:32 PM, Lee Jones wrote: >> The value obtained from GINTSTS2 should be masked with the GINTMSK2 >> value. Looks like this has been broken since >> dwc2_gadget_wkup_alert_handler() was added back in 2018. >> >> Also fixes the following W=1 warning: >>

Re: [v3 PATCH] usb: gadget: bdc: use readl_poll_timeout() to simplify code

2020-07-21 Thread Felipe Balbi
Hi, Chunfeng Yun writes: > Use readl_poll_timeout() to poll register status > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Reviewed-by: Florian Fainelli I had a lot of trouble to apply this patch, could you avoid base64 encoding on the patch body next time? Thanks -- balbi

Re: [PATCH 0/7] usb: bdc: Updates and fixes to the USB BDC driver

2020-07-21 Thread Felipe Balbi
Hi, Al Cooper writes: > Updates and fixes to the Broadcom USB BDC driver. > > Al Cooper (4): > dt-bindings: usb: bdc: Update compatible strings > usb: bdc: Add compatible string for new style USB DT nodes > usb: bdc: Adb shows offline after resuming from S2 > usb: bdc: driver runs out

Re: [PATCH v4 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC

2020-07-10 Thread Felipe Balbi
Hi, "Ramuthevar,Vadivel MuruganX" writes: > From: Ramuthevar Vadivel Murugan > > Add support for USB PHY on Intel LGM SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan > > --- > drivers/usb/phy/Kconfig | 11 ++ > drivers/usb/phy/Makefile | 1 + >

Re: [V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-07-09 Thread Felipe Balbi
Hi, Chunfeng Yun writes: >> > @@ -373,8 +380,8 @@ static int mtu3_gadget_dequeue(struct usb_ep *ep, >> > struct usb_request *req) >> > */ >> > static int mtu3_gadget_ep_set_halt(struct usb_ep *ep, int value) >> > { >> > - struct mtu3_ep *mep = to_mtu3_ep(ep); >> > - struct mtu3 *mtu =

Re: [V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-07-09 Thread Felipe Balbi
Chunfeng Yun writes: > Some pointers are dereferenced before successful checks. > > Reported-by: Markus Elfring > Signed-off-by: Chunfeng Yun do you need a Fixes tag here? Perhaps a Cc stable too? -- balbi signature.asc Description: PGP signature

Re: [PATCH] USB: Fix up terminology in include files

2020-07-02 Thread Felipe Balbi
Greg Kroah-Hartman writes: > USB is a HOST/DEVICE protocol, as per the specification and all > documentation. Fix up terms that are not applicable to make things > match up with the terms used through the rest of the USB stack. > > Signed-off-by: Greg Kroah-Hartman Acked-b

Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-07-01 Thread Felipe Balbi
Michał Mirosław writes: > On Sat, May 30, 2020 at 01:03:17AM +, Peter Chen wrote: >> >> > > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, >> > > > unsigned >> > intf, unsigned alt) >> > > >/* we know alt == 0, so this is an activation or a reset */ >> > > >

RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-07-01 Thread Felipe Balbi
Peter Chen writes: > >> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, >> > > unsigned >> intf, unsigned alt) >> > > /* we know alt == 0, so this is an activation or a reset */ >> > > >> > > if (intf == acm->ctrl_id) { >> > > -

Re: [PATCH] usb: cdns3: fix possible buffer overflow caused by bad DMA value

2020-07-01 Thread Felipe Balbi
Peter Chen writes: > On 20-05-30 11:24:00, Jia-Ju Bai wrote: >> In cdns3_ep0_setup_phase(): >> struct usb_ctrlrequest *ctrl = priv_dev->setup_buf; >> >> Because priv_dev->setup_buf (allocated in cdns3_gadget_start) is stored >> in DMA memory, and thus ctrl is a DMA value. >> >>

Re: [PATCH] USB: Fix up terminology

2020-07-01 Thread Felipe Balbi
want me to pick this up and send it back to you on a pull request? It's fine for me either way: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RFC 0/5] Introduced new Cadence USBSSP DRD Driver.

2020-06-26 Thread Felipe Balbi
Hi, Pawel Laszczak writes: > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Controller is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. > > The current

Re: [PATCH v3] usb: gadget: u_serial: improve performance for large data

2020-06-24 Thread Felipe Balbi
Hi, Macpaul Lin writes: > Nowadays some embedded systems use VCOM to transfer large log and data. > Take LTE MODEM as an example, during the long debugging stage, large > log and data were transfer through VCOM when doing field try or in > operator's lab. Here we suggest slightly increase the

Re: [PATCH 2/2] usb: gadget: u_serial: improve performance for large data

2020-06-24 Thread Felipe Balbi
Hi, Macpaul Lin writes: > If the hardware (like DMA engine) could support large usb request exceeds > maximum packet size, use larger buffer when performing Rx/Tx could reduce > request numbers and improve performance. > > Signed-off-by: Macpaul Lin > --- >

Re: [PATCH 1/2] usb: gadget: introduce flag for large request

2020-06-24 Thread Felipe Balbi
Hi, Macpaul Lin writes: > Some USB hardware like DMA engine can help to process (split) the data > of each URB request into small packets. For example, the max packet size > of high speed is 512 bytes. These kinds of hardware can help to split > the continue Tx/Rx data requests into packets

Re: [PATCH] usb: phy: tegra: Remove unnecessary spaces and tables

2020-06-24 Thread Felipe Balbi
Hi, Tang Bin writes: > The macros in phy-tegra-usb.c have inconsistent sapces between > the macro name and the value. Thus sets all the macros to have > a signal space between the name and value. > > Signed-off-by: Tang Bin > --- > drivers/usb/phy/phy-tegra-usb.c | 214

Re: linux-next: manual merge of the usb tree with the devicetree tree

2020-05-29 Thread Felipe Balbi
Hi, Rob Herring writes: >> >> > > > Today's linux-next merge of the usb tree got a conflict in: >> >> > > > >> >> > > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> >> > > > >> >> > > > between commit: >> >> > > > >> >> > > > 3828026c9ec8 ("dt-bindings: usb: qcom,dwc3: Convert

Re: linux-next: manual merge of the usb tree with the devicetree tree

2020-05-29 Thread Felipe Balbi
Hi, Greg KH writes: > On Fri, May 29, 2020 at 10:26:41AM +0200, Greg KH wrote: >> On Thu, May 28, 2020 at 08:14:36AM -0600, Rob Herring wrote: >> > On Thu, May 28, 2020 at 4:49 AM Greg KH wrote: >> > > >> > > On Thu, May 28, 2020 at 04:22:15PM +1000, Stephen Rothwell wrote: >> > > > Hi all, >>

Re: [PATCH for-5.8 2/2] usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs

2020-05-27 Thread Felipe Balbi
; >> > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c >> > b/drivers/usb/dwc3/dwc3-meson-g12a.c >> > index ce5388338389..1f7f4d88ed9d 100644 >> > --- a/drivers/usb/dwc3/dwc3-meson-g12a.c >> > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c >> >> [...] >> >> Fixes regression reported at [1] on SEI510 board based on Amlogic G12A. >> >> Felipe, Greg, can this be queued on uxb-next for 5.8 ? >> >> Acked-by: Neil Armstrong > > I can take this and patch 1/2 here if Felipe acks them. Sure thing, Greg. Thanks. Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-05-26 Thread Felipe Balbi
Hi, Georgi Djakov writes: > On 26.05.20 14:04, Sandeep Maheswaram (Temp) wrote: >> Hi Felipe, >> >> Please let me know how to go forward with this patch (don't top-post!) > Please just add a patch to fix the allmodconfig error. Felipe has > suggested to introduce a separate patch which

Re: [PATCH v2 0/2] usb: dwc3: keystone: Turn on USB3 PHY before controller

2020-05-25 Thread Felipe Balbi
Hi, Roger Quadros writes: > This series prepares for Super-Speed support for AM654 SoC. > > Patch 1 is already in your testing/next as commit > d47b0062a8ad6c5060c84439745c3ce7d21d6bb9. > Please revert that and apply the revised version in which we make > the USB3.0 PHY optional. Thanks. > >

Re: [PATCH v2 0/3] Re-introduce TX FIFO resize for larger EP bursting

2020-05-22 Thread Felipe Balbi
Wesley Cheng writes: > Changes in V2: > - Modified TXFIFO resizing logic to ensure that each EP is reserved a >FIFO. > - Removed dev_dbg() prints and fixed typos from patches > - Added some more description on the dt-bindings commit message > > Reviewed-by: Felipe Bal

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-21 Thread Felipe Balbi
Hi Jun, Felipe Balbi writes: >> In any case, increasing the timeout should be fine with me. It maybe >> difficult to determine the max timeout base on the slowest clock rate >> and number of cycles. Different controller and controller versions >> behave differentl

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-21 Thread Felipe Balbi
Hi, Thinh Nguyen writes: "Power Down Scale (PwrDnScale) The USB3 suspend_clk input replaces pipe3_rx_pclk as a clock source to a small part of the USB3 controller that operates when the SS PHY is in its lowest power (P3) state, and therefore does not provide

Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-18 Thread Felipe Balbi
Linus Walleij writes: > On Mon, May 18, 2020 at 10:18 AM Felipe Balbi wrote: >> Linus Walleij writes: >> >> gpiochip0 - 32 lines: >> >> line 0: "ethernet" unused input active-high >> >> line 1: &qu

Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-18 Thread Felipe Balbi
Linus Walleij writes: >> gpiochip0 - 32 lines: >> line 0: "ethernet" unused input active-high >> line 1: "ethernet" unused input active-high > > Why are the ethernet lines not tagged with respective signal name > when right below the SPI lines are

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-16 Thread Felipe Balbi
Hi, Jun Li writes: >> >> Hi Thinh, could you comment this? >> > >> > You only need to wake up the usb2 phy when issuing the command while >> > running in highspeed or below. If you're running in SS or higher, >> > internally the controller does it for you for usb3 phy. In Jun's case, >> > it

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-16 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > Jun Li wrote: >>> -Original Message- >>> From: Felipe Balbi On Behalf Of Felipe Balbi >>> Sent: 2020年5月15日 17:31 >>> To: Jun Li >>> Cc: John Stultz ; lkml >>> ; Yu >>> Chen ; Greg Kro

Re: [PATCH v2 1/7] usb: gadget: udc: atmel: use of_find_matching_node_and_match

2020-05-15 Thread Felipe Balbi
writes: > From: Claudiu Beznea > > Instead of trying to match every possible compatible use > of_find_matching_node_and_match() and pass the compatible array. > > Signed-off-by: Claudiu Beznea > --- please rebase on my testing/next checking file drivers/usb/gadget/udc/atmel_usba_udc.c Hunk

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-15 Thread Felipe Balbi
Hi, Jun Li writes: >> Jun Li writes: >> >> @@ -397,12 +407,18 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, >> >> unsigned >> cmd, >> >> dwc3_gadget_ep_get_transfer_index(dep); >> >> } >> >> >> >> - if (saved_config) { >> >> + if

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-15 Thread Felipe Balbi
Hi, Jun Li writes: >> @@ -397,12 +407,18 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, >> unsigned cmd, >> dwc3_gadget_ep_get_transfer_index(dep); >> } >> >> - if (saved_config) { >> + if (saved_hs_config) { >> reg =

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-05-15 Thread Felipe Balbi
Hi, Georgi Djakov writes: >> Sandeep Maheswaram writes: >>> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom) >>> +{ >>> + struct device *dev = qcom->dev; >>> + int ret; >>> + >>> + if (!device_is_bound(>dwc3->dev)) >>> +

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-05-14 Thread Felipe Balbi
Hi, Georgi Djakov writes: > On 5/14/20 20:13, Matthias Kaehlcke wrote: >> On Thu, May 14, 2020 at 02:30:28PM +0300, Felipe Balbi wrote: >>> Felipe Balbi writes: >>> >>>> Hi, >>>> >>>> Sandeep Maheswaram writes: >&

Re: [PATCH 00/13] usb: dwc3: meson: add OTG support for GXL/GXM

2020-05-14 Thread Felipe Balbi
Neil Armstrong writes: > Hi, > > On 14/05/2020 12:23, Felipe Balbi wrote: >> Felipe Balbi writes: >> >>> Neil Armstrong writes: >>> >>>> The USB support was initialy done with a set of PHYs and dwc3-of-simple >>>> because t

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-05-14 Thread Felipe Balbi
Felipe Balbi writes: > Hi, > > Sandeep Maheswaram writes: >> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom) >> +{ >> +struct device *dev = qcom->dev; >> +int ret; >> + >> +if (!device_is_bound(>dwc3->dev))

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-05-14 Thread Felipe Balbi
Hi, Sandeep Maheswaram writes: > +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom) > +{ > + struct device *dev = qcom->dev; > + int ret; > + > + if (!device_is_bound(>dwc3->dev)) > + return -EPROBE_DEFER; this breaks allmodconfig. I'm dropping this series

Re: [PATCH v7 0/4] ADD interconnect support for Qualcomm DWC3 driver

2020-05-14 Thread Felipe Balbi
"Sandeep Maheswaram (Temp)" writes: > Hi Felipe, > > Any update about landing this series. in my tree now -- balbi signature.asc Description: PGP signature

Re: [PATCH v3] usb: dwc3: support continuous runtime PM with dual role

2020-05-14 Thread Felipe Balbi
Martin Kepplinger writes: > On 24.04.20 09:48, Roger Quadros wrote: >> >> >> On 19/03/2020 12:02, Martin Kepplinger wrote: >>> The DRD module calls dwc3_set_mode() on role switches, i.e. when a >>> device is >>> being plugged in. In order to support continuous runtime power >>> management when

Re: [PATCH 00/13] usb: dwc3: meson: add OTG support for GXL/GXM

2020-05-14 Thread Felipe Balbi
Felipe Balbi writes: > Neil Armstrong writes: > >> The USB support was initialy done with a set of PHYs and dwc3-of-simple >> because the architecture of the USB complex was not understood correctly >> at the time (and proper documentation was missing...). >&g

Re: [PATCH 3/3] usb: dwc3: keystone: Turn on USB3 PHY before controller

2020-05-14 Thread Felipe Balbi
Roger Quadros writes: > On 14/05/2020 04:37, Chunfeng Yun wrote: >> On Wed, 2020-05-13 at 16:07 +0300, Roger Quadros wrote: >>> The Local Power Sleep Controller (LPSC) dependency on AM65 >>> requires SERDES0 to be powered on before USB. >>> >>> We need to power up SERDES0 power domain and hold

Re: [PATCH V3 0/8] Tegra XUSB charger detect support

2020-05-14 Thread Felipe Balbi
Nagarjuna Kristam writes: > This patch series adds charger detect support on XUSB hardware used in > Tegra210 and Tegra186 SoCs. > > This patchset is composed with : > - dt bindings of XUSB Pad Controller > - Tegra XUSB device mode driver to add vbus_draw support > - Tegra PHY driver for

Re: [PATCH] usb: gadget: u_serial: fix coverity warning: negative index at array

2020-05-14 Thread Felipe Balbi
Macpaul Lin writes: > This issue has been reported by coverity scanner. > Replace "int portnum" by "unsigned int", this void negative index at > array. > > Signed-off-by: Stan Lu > Signed-off-by: Macpaul Lin please rebase on testing/fixes error: patch failed:

Re: [PATCH v2] usb: raw-gadget: fix gadget endpoint selection

2020-05-12 Thread Felipe Balbi
Greg Kroah-Hartman writes: > On Sat, May 09, 2020 at 11:02:13AM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Andrey Konovalov writes: >> >> here you're changing userspace ABI. Aren't we going to possibly break >> >> some existing applications

Re: [PATCH v2] usb: raw-gadget: fix gadget endpoint selection

2020-05-09 Thread Felipe Balbi
Hi, Andrey Konovalov writes: >> here you're changing userspace ABI. Aren't we going to possibly break >> some existing applications? > > Hi Felipe, > > I've been working on tests for Raw Gadget for the last few weeks [1], > which revealed a few problems with the interface. This isn't yet >

Re: [PATCH USB v3 3/5] usb: raw-gadget: fix gadget endpoint selection

2020-05-09 Thread Felipe Balbi
Andrey Konovalov writes: > Currently automatic gadget endpoint selection based on required features > doesn't work. Raw Gadget tries iterating over the list of available > endpoints and finding one that has the right direction and transfer type. > Unfortunately selecting arbitrary gadget

Re: [PATCH] USB: gadget: fix illegal array access in binding with UDC

2020-05-09 Thread Felipe Balbi
Kyungtae Kim writes: > FuzzUSB (a variant of syzkaller) found an illegal array access > using an incorrect index while binding a gadget with UDC. > > Reference: https://www.spinics.net/lists/linux-usb/msg194331.html > > This bug occurs when a size variable used for a buffer > is misused to

Re: [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-05-08 Thread Felipe Balbi
Hi, Wesley Cheng writes: > Some devices have USB compositions which may require multiple endpoints > that support EP bursting. HW defined TX FIFO sizes may not always be > sufficient for these compositions. By utilizing flexible TX FIFO > allocation, this allows for endpoints to request the

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-08 Thread Felipe Balbi
Hi, Jun Li writes: > Jun Li 于2020年5月7日周四 上午11:08写道: >> >> John Stultz 于2020年5月7日周四 上午6:27写道: >> > >> > On Wed, May 6, 2020 at 2:00 AM Jun Li wrote: >> > > John Stultz 于2019年10月30日周三 上午5:18写道: >> > > > On Tue, Oct 29, 2019 at

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-08 Thread Felipe Balbi
Hi, Jun Li writes: > John Stultz 于2019年10月30日周三 上午5:18写道: >> >> On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: >> > John Stultz writes: >> > > From: Yu Chen >> > > >> > > It needs more time for the device controller

Re: [PATCH USB 2/2] usb: raw-gadget: fix typo in uapi headers

2020-05-05 Thread Felipe Balbi
Andrey Konovalov writes: > Signed-off-by: Andrey Konovalov return -ENOCHANGELOG -- balbi signature.asc Description: PGP signature

Re: [PATCH v2] usb: raw-gadget: fix gadget endpoint selection

2020-05-05 Thread Felipe Balbi
Hi, Andrey Konovalov writes: > Currently automatic gadget endpoint selection based on required features > doesn't work. Raw Gadget tries iterating over the list of available > endpoints and finding one that has the right direction and transfer type. > Unfortunately selecting arbitrary gadget

Re: [PATCH] dt-bindings: usb: dwc3: Move Amlogic G12A DWC3 Glue Bindings to YAML schemas

2019-10-22 Thread Felipe Balbi
Hi, Neil Armstrong writes: > Now that we have the DT validation in place, let's convert the device tree > bindings for the Amlogic G12A DWC3 Glue Bindings over to a YAML schemas, > the AXG and GXL glue bindings will be converted later. > > Signed-off-by: Neil Armstrong Is this a thing now?

Re: [PATCH] usb: gadget: udc: Fix assignment of 0/1 to bool variables

2019-10-22 Thread Felipe Balbi
Hi, Michal Simek writes: >> @@ -1952,9 +1952,9 @@ static void xudc_nonctrl_ep_handler(struct xusb_udc >> *udc, u8 epnum, >> ep = >ep[epnum]; >> /* Process the End point interrupts.*/ >> if (intrstatus & (XUSB_STATUS_EP0_BUFF1_COMP_MASK << epnum)) >> -

Re: [RFC PATCH 1/5] x86: tsc: add tsc to art helpers

2019-10-17 Thread Felipe Balbi
Hi, Thomas Gleixner writes: >> Thomas Gleixner writes: >> > On Thu, 15 Aug 2019, Felipe Balbi wrote: >> >> Thomas Gleixner writes: >> >> > On Tue, 16 Jul 2019, Felipe Balbi wrote: >> >> > >> >> > So some information

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-10 Thread Felipe Balbi
hi, Roger Quadros writes: >>> Peter Chen writes: On 19-10-07 07:39:11, Pawel Laszczak wrote: > Patch fixes issue with Halt Endnpoint Test observed %s/Endnpoint/Endpoint > > during using g_zero > driver as DUT. Bug occurred only on some testing board.

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-08 Thread Felipe Balbi
Hi, Peter Chen writes: > On 19-10-07 07:39:11, Pawel Laszczak wrote: >> Patch fixes issue with Halt Endnpoint Test observed > > %s/Endnpoint/Endpoint > >> >> during using g_zero >> driver as DUT. Bug occurred only on some testing board. > > g_zero is legacy, please use configfs function

Re: [PATCH 3/3] usb: dwc3: Remove dev_err() on platform_get_irq() failure

2019-10-06 Thread Felipe Balbi
Hi, Hans de Goede writes: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to > platform_get_irq*()"), platform_get_irq() will call dev_err() itself on > failure, so there is no need for the driver to also do this. > > Signed-off-by: Hans de

Re: [PATCH 2/3] usb: dwc3: Switch to platform_get_irq_byname_optional()

2019-10-06 Thread Felipe Balbi
t_irq_byname() to print an error > on failure, so switch to platform_get_irq_byname_optional() instead which > does not print an error. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205037 > Signed-off-by: Hans de Goede Acked-by: Felipe Balbi -- balbi

Re: [RFC PATCH 1/5] x86: tsc: add tsc to art helpers

2019-10-01 Thread Felipe Balbi
Hi, (sorry for the long delay, got caught up in other tasks) Thomas Gleixner writes: > On Thu, 15 Aug 2019, Felipe Balbi wrote: >> Thomas Gleixner writes: >> > On Tue, 16 Jul 2019, Felipe Balbi wrote: >> > >> > So some information what t

[PATCH v4 1/2] PTP: introduce new versions of IOCTLs

2019-09-11 Thread Felipe Balbi
-off-by: Felipe Balbi --- Changes since v3: - Remove bogus bitwise negation Changes since v2: - Define PTP_{PEROUT,EXTTS}_VALID_FLAGS - Fix comment above PTP_*_FLAGS Changes since v1: - Add a blank line after memset() - Move memset(req) to the three places

[PATCH v4 2/2] PTP: add support for one-shot output

2019-09-11 Thread Felipe Balbi
Some controllers allow for a one-shot output pulse, in contrast to periodic output. Now that we have extensible versions of our IOCTLs, we can finally make use of the 'flags' field to pass a bit telling driver that if we want one-shot pulse output. Signed-off-by: Felipe Balbi --- Changes since

Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs

2019-09-11 Thread Felipe Balbi
Hi, Richard Cochran writes: > On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote: > >> case PTP_PEROUT_REQUEST: >> +case PTP_PEROUT_REQUEST2: > > ... > >> +if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) || >

[PATCH v3 2/2] PTP: add support for one-shot output

2019-09-09 Thread Felipe Balbi
Some controllers allow for a one-shot output pulse, in contrast to periodic output. Now that we have extensible versions of our IOCTLs, we can finally make use of the 'flags' field to pass a bit telling driver that if we want one-shot pulse output. Signed-off-by: Felipe Balbi --- Changes since

[PATCH v3 1/2] PTP: introduce new versions of IOCTLs

2019-09-09 Thread Felipe Balbi
-off-by: Felipe Balbi --- Changes since v2: - Define PTP_{PEROUT,EXTTS}_VALID_FLAGS - Fix comment above PTP_*_FLAGS - Changes since v1: - Add a blank line after memset() - Move memset(req) to the three places where it's needed - Fix the accidental

Re: [PATCH v2 2/2] PTP: add support for one-shot output

2019-09-05 Thread Felipe Balbi
Hi, Richard Cochran writes: > On Fri, Aug 30, 2019 at 11:00:20AM +0300, Felipe Balbi wrote: >> seems like this should be defined together with the other flags? If >> that's the case, it seems like we would EXTTS and PEROUT masks. > > Yes, let's make the meanings of

Re: [PATCH v2 2/2] PTP: add support for one-shot output

2019-09-05 Thread Felipe Balbi
Hi, Richard Cochran writes: > On Fri, Aug 30, 2019 at 11:00:20AM +0300, Felipe Balbi wrote: >> >> @@ -177,9 +177,8 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int >> >> cmd, unsigned long arg) >> >> err =

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Felipe Balbi
Hi, writes: > The power budget for SuperSpeed mode should be 900 mA > according to USB3.0 specification, so set the power > budget to 900 mA for dummy_start_ss which is only used > for SuperSpeed mode. > > If the max power consumption of SuperSpeed device is > larger than 500 mA, insufficient

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Felipe Balbi
Hi, On Wed, Sep 4, 2019 at 9:47 AM wrote: > > The power budget for SuperSpeed mode should be 900 mA > > according to USB3.0 specification, so set the power > > budget to 900 mA for dummy_start_ss which is only used > > for SuperSpeed mode. > > > > If the max power consumption of SuperSpeed

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Felipe Balbi
Hi, "Kobayashi, Kento (Sony)" writes: > Hi, > > My company's member, Mr.Jacky, sent patch in June 26th. > But we didn't receive comment about our patch. > Could you confirm and tell us this patch is needed or not? I can't find the original patch in my inbox, could you resend it using git

Re: [PATCH v2 2/2] PTP: add support for one-shot output

2019-08-30 Thread Felipe Balbi
Hi, Richard Cochran writes: > Adding davem onto CC... > > On Thu, Aug 29, 2019 at 12:58:25PM +0300, Felipe Balbi wrote: >> diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c >> index 98ec1395544e..a407e5f76e2d 100644 >> --- a/drivers/ptp/ptp_cha

<    1   2   3   4   5   6   7   8   9   10   >