On Mon, 13 Aug 2007, Michael Schmitz wrote:
From: Geert Uytterhoeven [EMAIL PROTECTED]
m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible
With buttons emulation being available via uinput event devices, do we
still need the kernel mouse button emulation? At least on
On Thu, 11 Oct 2007, Geert Uytterhoeven wrote:
Reading the patch in that link, recent cross compilers from _where_?
Buildroot? Cross-tools? Gentoo embedded? Cross Linux From Scratch?
My Firmware Linux project?
You assume they all use the same name, yet your patch changes them
If your cross-compiler is called differently than the default on in
arch/*/Makefile,
Part of the problem is that there is no compelling default. The name of
the cross-compiler can vary depending on the chosen executable prefix or
the chosen target tuple.
Let's say I create new cross
code again. Besides, we already have two SONIC drivers in the tree,
seperating jazzsonic and macsonic would add a third.
-f
Signed-off-by: Finn Thain [EMAIL PROTECTED]
--- a/drivers/net/macsonic.c2005-03-25 04:01:51.0 +1100
+++ b/drivers/net/macsonic.c2005-03-25 04:48
On Wed, 23 Mar 2005, Ralf Baechle wrote:
On Tue, Mar 22, 2005 at 06:13:17PM +0100, Geert Uytterhoeven wrote:
On Fri, 28 Jan 2005, Linux Kernel Mailing List wrote:
ChangeSet 1.1986, 2005/01/28 00:12:28-05:00, [EMAIL PROTECTED]
[PATCH] Jazzsonic driver updates
o
On Tue, 29 May 2007, Geert Uytterhoeven wrote:
On Mon, 28 May 2007, Robert P. J. Day wrote:
i'm trying to keep track of kernel janitor projects that involve
removing dead content from the tree:
http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
currently, the
On Fri, 11 May 2007, Simon Arlott wrote:
- * Local routines to interrcept the standard I/O and vector handling
- * code. Don't include this 'till now - initialization code above needs
+ * Local routines to intercept the standard I/O and vector handling
+ * code. Don't include this
On Sat, 12 May 2007, Simon Arlott wrote:
On 12/05/07 02:03, Finn Thain wrote:
On Fri, 11 May 2007, Simon Arlott wrote:
- * Local routines to interrcept the standard I/O and vector
handling
- * code. Don't include this 'till now - initialization code above
On Sat, 12 May 2007, Kolbj??rn Barmen wrote:
On Sat, 12 May 2007, Finn Thain wrote:
To answer your question, I find it easier to parse the original idiom,
'til now. Your corruption, until now, loses information available to
anyone who can recognise the idiom. Granted
of this patch had a bug where a nubus sonic card would register
two interrupt handlers. Only a built-in sonic needs both.
Versions 2 and 3 needed some cleanups, as Raylynn Knight and Christoph
Hellwig pointed out (thanks).
Signed-off-by: Finn Thain [EMAIL PROTECTED]
drivers/net/jazzsonic.c
(Second attempt... sorry for the earlier spam.)
This patch series addresses several issues with NCR5380 drivers:
1. The complex network of #include directives.
2. Three inconsistent implementations of the core driver all attempting
to share the same macro definitions in NCR5380.h.
3.
BOARD_NORMAL is completely unused and BOARD_NCR53C400 is used only by
g_NCR5380 internally. Remove the unused definitions.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/arm/cumana_1.c |3 ---
drivers/scsi/arm/oak.c |3 ---
drivers/scsi/mac_scsi.h |3
) that caused compiler warnings.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/NCR5380.c | 14 +++---
drivers/scsi/sun3_NCR5380.c |4 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
Index: linux-m68k/drivers/scsi/sun3_NCR5380.c
-by: Finn Thain fth...@telegraphics.com.au
---
Here's a graph showing the present #include structure.
sun3_scsi_vme.c - sun3_scsi.h - NCR5380.h
:418: warning: 'NCR5380_print' defined but not used
drivers/scsi/NCR5380.c:459: warning: 'NCR5380_print_phase' defined but not used
The debugging code is now enabled when NDEBUG != 0.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/NCR5380.c |7 ---
drivers/scsi
SUN3_SCSI_DEBUG is undesirable. Dead code within #ifdef OLD_DMA is also
dropped, consistent with sun3_scsi_vme.c.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/sun3_scsi.c | 222
drivers/scsi/sun3_scsi_vme.c | 583 ---
2
Remove the unused (and divergent) debugging macro definitions from
the sun3_NCR5380 and atari_NCR5380 drivers. These drivers have been
converted to use the common macros in NCR5380.h.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/atari_scsi.h | 93
(NDEBUG_MAIN | NDEBUG_QUEUES, ...)
Replace the NCR_PRINT* macros from atari_NCR5380.h and sun3_NCR5380.h with
the equivalent macros from NCR5380.h.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/atari_NCR5380.c | 22 +++---
drivers/scsi/sun3_NCR5380.c
(NDEBUG_MAIN | NDEBUG_QUEUES, ...)
Replace the *_PRINTK macros from atari_NCR5380.h and sun3_NCR5380.h with
the equivalent macros from NCR5380.h.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/atari_NCR5380.c | 130 +--
drivers/scsi
on the variable argument list.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/NCR5380.c | 126 -
drivers/scsi/NCR5380.h |6 +-
2 files changed, 66 insertions(+), 66 deletions(-)
Index: linux-m68k/drivers/scsi/NCR5380.c
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/NCR5380.c |2 --
drivers/scsi/NCR5380.h |4
drivers/scsi/g_NCR5380.c |4
drivers/scsi/g_NCR5380.h |4
drivers/scsi/mac_scsi.c |4
drivers/scsi/mac_scsi.h |4
drivers/scsi
Only the NCR5380_dprint() macro should invoke the NCR5380_print() function.
That's why NCR5380.c only defines the function #if NDEBUG. Use the standard
macro.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/sun3_scsi.c |4 +---
1 file changed, 1 insertion(+), 3
HOSTS_C is always undefined. There is no hosts.c anymore.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/g_NCR5380.h |3 ---
drivers/scsi/mac_scsi.h |3 ---
drivers/scsi/pas16.h |3 ---
drivers/scsi/sun3_scsi.h |3 ---
drivers/scsi/t128.h |3
On Mon, 17 Mar 2014, Joe Perches wrote:
My preference would be to change dprintk to scsi_dbg
Can you be more specific? I gather you're not referring to the debugging
routines in include/scsi/scsi_dbg.h as they aren't equivalent.
Is it the name dprintk you object to?
I went looking in
Skip the futex_atomic_cmpxchg_inatomic() test in futex_init(). It causes a
fatal exception on 68030 (and presumably 68020 also).
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Acked-by: Geert Uytterhoeven ge...@linux-m68k.org
Index: linux-m68k/arch/m68k/Kconfig
On Tue, 18 Mar 2014, Joe Perches wrote:
On Tue, 2014-03-18 at 13:55 +0100, Geert Uytterhoeven wrote:
#define dprintk(flg, fmt, ...) no_printk(fmt, ##__VA_ARGS__)
Fine, but with a correction.
no_printk keeps all side effects like performing any function calls made
by the statement
On Tue, 18 Mar 2014, Joe Perches wrote:
But using if (0) prevents the no_printk from occurring at all so there
would be no side-effects and the format args would still be verified
by the compiler.
I'd prefer this (for symmetry and clarity):
#if NDEBUG
#define dprintk(flg, fmt, ...) \
This patch series addresses several issues with NCR5380 drivers:
1. The complex network of #include directives.
2. Three inconsistent implementations of the core driver all attempting
to share the same macro definitions in NCR5380.h.
3. Broken debugging code.
In the past these issues have
HOSTS_C is always undefined. There is no hosts.c anymore.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/g_NCR5380.h |3 ---
drivers/scsi/mac_scsi.h |3 ---
drivers/scsi/pas16.h |3 ---
drivers/scsi/sun3_scsi.h |3 ---
drivers/scsi/t128.h |3
(NDEBUG_MAIN | NDEBUG_QUEUES, ...)
Replace the NCR_PRINT* macros from atari_NCR5380.h and sun3_NCR5380.h with
the equivalent macros from NCR5380.h.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/atari_NCR5380.c | 22 +++---
drivers/scsi/sun3_NCR5380.c
) that caused compiler warnings.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
Changes since v1:
- Fixed a build failure in sun3_NCR5380.c with NDEBUG_LISTS.
---
drivers/scsi/NCR5380.c | 14 +++---
drivers/scsi/sun3_NCR5380.c | 10 +++---
2 files changed, 10
:418: warning: 'NCR5380_print' defined but not used
drivers/scsi/NCR5380.c:459: warning: 'NCR5380_print_phase' defined but not used
The debugging code is now enabled when NDEBUG != 0.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
Changes since v1:
- Use C99 __VA_ARGS__ for dprintk
Remove the unused (and divergent) debugging macro definitions from
the sun3_NCR5380 and atari_NCR5380 drivers. These drivers have been
converted to use the common macros in NCR5380.h.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/atari_scsi.h | 93
-by: Finn Thain fth...@telegraphics.com.au
---
Here's a graph showing the present #include structure.
sun3_scsi_vme.c - sun3_scsi.h - NCR5380.h
SUN3_SCSI_DEBUG is undesirable. Dead code within #ifdef OLD_DMA is also
dropped, consistent with sun3_scsi_vme.c.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/sun3_scsi.c | 222
drivers/scsi/sun3_scsi_vme.c | 583 ---
2
(NDEBUG_MAIN | NDEBUG_QUEUES, ...)
Replace the *_PRINTK macros from atari_NCR5380.h and sun3_NCR5380.h with
the equivalent macros from NCR5380.h.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/atari_NCR5380.c | 130 +--
drivers/scsi
on the variable argument list.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
Changes since v1:
- Use C99-style dprintk() macro.
---
drivers/scsi/NCR5380.c | 126 ++--
drivers/scsi/NCR5380.h |6 +-
drivers/scsi/sun3_NCR5380.c |2
3
Only the NCR5380_dprint() macro should invoke the NCR5380_print() function.
That's why NCR5380.c only defines the function #if NDEBUG. Use the standard
macro.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/sun3_scsi.c |4 +---
1 file changed, 1 insertion(+), 3
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/NCR5380.c |2 --
drivers/scsi/NCR5380.h |4
drivers/scsi/g_NCR5380.c |4
drivers/scsi/g_NCR5380.h |4
drivers/scsi/mac_scsi.c |4
drivers/scsi/mac_scsi.h |4
drivers/scsi
BOARD_NORMAL is completely unused and BOARD_NCR53C400 is used only by
g_NCR5380 internally. Remove the unused definitions.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/arm/cumana_1.c |3 ---
drivers/scsi/arm/oak.c |3 ---
drivers/scsi/mac_scsi.h |3
On Wed, 28 May 2014, Christoph Hellwig wrote:
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
Thanks for reviewing. There was a later submission (version 2) with
changes made to three of these patches,
[PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabled
the compiler to check the parameters of
disabled printk() calls so that the debugging code doesn't rot again.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
I know the whitespace is wrong throughout these drivers but when I put
this patch series together it seemed best to defer
On Sat, 26 Apr 2014, James Bottomley wrote:
OK, so this is a pretty big change to an unmaintained driver. I'll take
it if you're willing to maintain the driver afterwards ... in which case
I need another patch to add you to the MAINTAINERS file.
Sure, I'm happy to support these patches
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Cc: Michael Schmitz schmitz...@gmail.com
---
As requested:
http://marc.info/?l=linux-arm-kernelm=139853302724112w=2
diff --git a/MAINTAINERS b/MAINTAINERS
index e67ea24..60ea600 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5996,6 +5996,28
On Sun, 30 Jun 2013, Geert Uytterhoeven wrote:
+static void __init alloc_msg_queue(int iop_num)
+{
+ iop_send_queue[iop_num] =
+ kzalloc(NUM_IOP_CHAN * sizeof(**iop_send_queue), GFP_KERNEL);
+ iop_listeners[iop_num] =
+ kzalloc(NUM_IOP_CHAN *
On Sun, 30 Jun 2013, Brad Boyer wrote:
On Sun, Jun 30, 2013 at 12:02:22PM +0200, Geert Uytterhoeven wrote:
if (iop_scc_present) {
printk(IOP: detected SCC IOP at %p\n, iop_base[IOP_NUM_SCC]);
+ alloc_msg_queue(IOP_NUM_SCC);
Technically, this isn't actually
On Sun, 30 Jun 2013, Geert Uytterhoeven wrote:
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
arch/m68k/mac/iop.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/mac/iop.c b/arch/m68k/mac/iop.c
index 7d8d461..8a4c446 100644
---
On Wed, 2 Jul 2014, Nicholas Krause wrote:
Removes a FIXME comment in this file due to it not compiling as it now
compiles.
What got fixed?
It doesn't say FIXME - this doesn't compile.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
arch/m68k/include/asm/sun3_pgalloc.h | 1 -
On Fri, 4 Jul 2014, Nick Krause wrote:
What are these two lines for them another compile issue?
I don't see why those two lines are important.
-/* FIXME - when we get this compiling */
/* erm, now that it's compiling, what do we do with it? */
#define _KERNPG_TABLE 0
Presumably it is
On Sat, 29 Nov 2014, Rasmus Villemoes wrote:
These patches mostly replace seq_printf with simpler and faster
equivalents, e.g. seq_printf(m, something) = seq_puts(m, something)
and seq_printf(m, \n) = seq_putc(m, '\n). But before my Coccinelle
scripts could be unleashed I had to clean up
On Sun, 1 Feb 2015, Geert Uytterhoeven wrote:
On Sun, Feb 1, 2015 at 4:39 AM, Finn Thain wrote:
On Sun, 4 Jan 2015, Geert Uytterhoeven wrote:
On Sun, Jan 4, 2015 at 8:21 AM, Finn Thain wrote:
On Thu, 1 Jan 2015, Rickard Strandqvist wrote:
Removes some functions that are not used
On Sun, 1 Feb 2015, Russell King - ARM Linux wrote:
On Sun, Feb 01, 2015 at 02:39:42PM +1100, Finn Thain wrote:
I find the ARM support in drivers/char/nvram to be surprising, not to
say questionable. The /proc/driver/nvram implementation, given
defined(__arm__), decodes the NVRAM
Acked-by: Finn Thain fth...@telegraphics.com.au
On Sat, 3 Jan 2015, Geert Uytterhoeven wrote:
If CONFIG_SCSI_GENERIC_NCR5380=y:
drivers/scsi/g_NCR5380.c:727: warning: ?id_table? defined but not used
In the non-modular case, MODULE_DEVICE_TABLE() expands to nothing, and
id_table
I have one reservation about this patch series.
For example, the changes,
- seq_printf(m, %s, p);
+ seq_puts(m, p);
These calls are not equivalent because the bounds check is not the same.
seq_puts will fail when m-count + strlen(p) == m-size.
seq_write() does the same check as
Acked-by: Finn Thain fth...@telegraphics.com.au
On Sun, 21 Dec 2014, Wolfram Sang wrote:
This platform_driver does not need to set an owner, it will be populated by
the
driver core.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
Generated with coccinelle. SmPL file
On Sun, 4 Jan 2015, Geert Uytterhoeven wrote:
On Sun, Jan 4, 2015 at 8:21 AM, Finn Thain fth...@telegraphics.com.au wrote:
On Thu, 1 Jan 2015, Rickard Strandqvist wrote:
Removes some functions that are not used anywhere:
mac_pram_write() mac_pram_read()
... I'd rather not remove all
On Thu, 1 Jan 2015, Rickard Strandqvist wrote:
Removes some functions that are not used anywhere:
mac_pram_write() mac_pram_read()
If you remove those functions, you'd then find that all of the called
functions become unused:
maciisi_read_pram
maciisi_write_pram
pmu_read_pram
Reviewed-by: Finn Thain fth...@telegraphics.com.au
On Wed, 3 Dec 2014, Rasmus Villemoes wrote:
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes li
Reviewed-by: Finn Thain fth...@telegraphics.com.au
For the NCR5380 bits:
Acked-by: Finn Thain fth...@telegraphics.com.au
On Wed, 3 Dec 2014, Rasmus Villemoes wrote:
Using seq_putc to print a single character saves at least a strlen()
call and a memory access, and may also give a small
Reviewed-by: Finn Thain fth...@telegraphics.com.au
For the NCR5380 bits:
Acked-by: Finn Thain fth...@telegraphics.com.au
On Wed, 3 Dec 2014, Rasmus Villemoes wrote:
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace
Reviewed-by: Finn Thain fth...@telegraphics.com.au
On Wed, 3 Dec 2014, Rasmus Villemoes wrote:
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes li
, for
consistency with atari_NCR5380.
Reviewed-by: Finn Thain fth...@telegraphics.com.au
For the NCR5380 bits:
Acked-by: Finn Thain fth...@telegraphics.com.au
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
---
drivers/scsi/NCR5380.c | 20 ++-
drivers/scsi/aha152x.c
Reviewed-by: Finn Thain fth...@telegraphics.com.au
On Wed, 3 Dec 2014, Rasmus Villemoes wrote:
Consecutive seq_puts calls with literal strings may be replaced by a
single call, saving a little .text.
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
---
drivers/scsi/advansys.c
On Mon, 1 Jun 2015, Geert Uytterhoeven wrote:
Index: linux/arch/m68k/atari/nvram.c
===
--- linux.orig/arch/m68k/atari/nvram.c 2015-05-31 11:01:21.0
+1000
+++ linux/arch/m68k/atari/nvram.c 2015-05-31
On Tue, 2 Jun 2015, Darren Hart wrote:
On Tue, Jun 02, 2015 at 07:09:28AM -0300, Henrique de Moraes Holschuh
wrote:
Test results were sent to me privately, and they are correct, so...
Finn, unless there is some compelling reason not to - like they are MBs
worth of data, please
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Acked-by: Geert Uytterhoeven ge...@linux-m68k.org
---
drivers/macintosh/nvram.c | 130 --
1 file changed, 130 deletions(-)
Index: linux/drivers/macintosh/nvram.c
The nvram_read_byte() and nvram_write_byte() definitions in asm/nvram.h
duplicate those in linux/nvram.h. Get rid of the former to prepare for
adoption of struct arch_nvram_ops (which is defined in linux/nvram.h for
general use).
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
arch
Also give functions more sensible names: nvram_misc_* for misc device ops,
nvram_proc_* for proc file ops and nvram_module_* for init and exit
functions. This makes them distict from nvram_ops members.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/nvram.c | 194
, unimplemented ioctls return
-ENOTTY. Whereas, for the superseded generic_nvram module they would
return -EINVAL.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
This ioctl change is visible to userspace code but only in an error path.
I didn't find any userspace code that uses
and chrp_nvram_write, which break the naming convention used across
PowerPC platforms for NVRAM accessor functions.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
arch/powerpc/platforms/chrp/nvram.c | 14 ++
arch/powerpc/platforms/powermac/nvram.c |9 +
2 files changed, 19
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
Tested on a PowerBook 520 and Quadra 650.
---
arch/m68k/mac/misc.c | 35 +--
include/uapi/linux/pmu.h |2 ++
2 files changed, 31 insertions(+), 6 deletions(-)
Index: linux/arch/m68k/mac/misc.c
Adopt the existing *_read_byte and *_write_byte naming convention.
Rename via_pram_readbyte and via_pram_writebyte to avoid confusion.
Adjust calling conventions of mac_pram_* functions to match the
arch_nvram_ops struct methods.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
Changes
The generic NVRAM module, drivers/char/generic_nvram, implements a
/dev/nvram misc device. It is used only by 32-bit PowerPC platforms and
isn't generic enough to be more widely used.
The RTC NVRAM module, drivers/char/nvram, also implements a /dev/nvram
misc device. It is used by x86, ARM and
the requested PowerMac NVRAM partition is not found.
This is a userspace-visible change, in the non-existent partition case,
which would be in an error path for an IOC_NVRAM_GET_OFFSET ioctl syscall.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
BTW, the IOC_NVRAM_SYNC ioctl call returns
And thus eliminate some twisted CONFIG_GENERIC_NVRAM logic.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/Makefile|6 -
drivers/char/generic_nvram.c | 176 ---
2 files changed, 1 insertion(+), 181 deletions(-)
Index
A multi-platform kernel binary needs to decide at run-time how to dispatch
the arch_nvram_ops calls. Add platform-independent arch_nvram_ops, for use
when multiple platform-specific NVRAM ops implementations are needed.
Enable CONFIG_HAVE_ARCH_NVRAM_OPS for Macs.
Signed-off-by: Finn Thain fth
Make use of arch_nvram_ops in device drivers so that the nvram_*
function exports can be removed.
Since they are no longer global symbols, rename the PPC32 nvram_* functions
appropriately.
Add the missing CONFIG_NVRAM test to imsttfb to avoid a build failure.
Signed-off-by: Finn Thain fth
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/nvram.c |1 +
1 file changed, 1 insertion(+)
Index: linux/drivers/char/nvram.c
===
--- linux.orig/drivers/char/nvram.c 2015-06-14 17:45:46.0
on the latter.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/nvram.c | 162 +++
1 file changed, 114 insertions(+), 48 deletions(-)
Index: linux/drivers/char/nvram.c
the valkyriefb driver with powerpc, and since that driver uses
NVRAM, it is affected by CONFIG_ATARI_SCSI, because of the use of
select NVRAM.
Adopt the powerpc convention on m68k to avoid surprises.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
This patch temporarily disables
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/nvram.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
Index: linux/drivers/char/nvram.c
===
--- linux.orig/drivers/char/nvram.c
. Replace this
validate-checksum-and-read-byte sequence with the equivalent
rtc_nvram_ops.read() call and remove the now unused functions.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
The advantage of the new ops struct over the old global nvram_* functions
is that the misc device module can
Drivers now use the arch_nvram_ops calls so remove the function exports and
prototypes. nvram_check_checksum() is unused so remove it.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
arch/m68k/atari/nvram.c |6 +++---
drivers/char/nvram.c| 27
Implement arch_nvram_ops for PPC32 and make use of it in the generic_nvram
misc device module so that the nvram_* function exports can be removed.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
arch/powerpc/include/asm/nvram.h |3 ---
arch/powerpc/kernel/setup_32.c | 10
platforms and architectures.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
The #ifdefs here restrict the procfs and checksumming code to those
architectures with PC-style RTC NVRAM. There may be a better place for
that code but it's an open question. See https://lkml.org/lkml/2015/2/3/22
-platform kernel binary can do the right thing when
running on hardware without suitable NVRAM.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
Changed since v1:
- Don't bother acquiring the mutex for unimplemented ioctls.
---
drivers/char/nvram.c | 71
Make use of arch_nvram_ops in the thinkpad_acpi driver so that the
nvram_* function exports can be removed.
This patch series was tested on a ThinkPad T43.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Acked-by: Henrique de Moraes Holschuh h...@hmh.eng.br
Reviewed-by: Darren Hart dvh
Move the m68k-specific code elsewhere to make the driver generic.
Change the vmode calculation from logical OR to bitwise OR, since it is
obviously wrong.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
BTW, I didn't change the SCSI ID location in NVRAM. This code says 16
whereas
Add the powerpc-specific sync() method to struct nvram_ops and implement
the corresponding ioctl in the nvram module. This allows the nvram module
to replace the generic_nvram module.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
On PPC32, the IOC_NVRAM_SYNC ioctl call always returns
Atari RTC NVRAM has a checksum so implement the remaining arch_nvram_ops
methods for the set_checksum and initialize ioctls. Enable
CONFIG_HAVE_ARCH_NVRAM_OPS.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
This re-enables the nvram module for Atari.
---
arch/m68k/Kconfig
Hi Geert,
Further to my previous email,
On Tue, 16 Jun 2015, in which I wrote:
On Mon, 15 Jun 2015, Geert Uytterhoeven wrote:
More magic values...
[...] The only useful RTC documentation I've ever come across is this:
http://mac.linux-m68k.org/devel/plushw.php
This document
On Mon, 15 Jun 2015, Geert Uytterhoeven wrote:
Hi Finn,
On Sun, Jun 14, 2015 at 9:46 AM, Finn Thain fth...@telegraphics.com.au
wrote:
--- linux.orig/arch/m68k/mac/misc.c 2015-06-14 17:46:02.0 +1000
+++ linux/arch/m68k/mac/misc.c 2015-06-14 17:46:03.0 +1000
on Macs.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
The arch_nvram_ops struct can only be defined once, of course, so the
Mac and Atari ops structs are mutually exclusive. The final patch will
allow the two implementations to co-exist in a multi-platform kernel binary.
---
arch
And thus eliminate some twisted CONFIG_GENERIC_NVRAM logic.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/Makefile|6 -
drivers/char/generic_nvram.c | 176 ---
2 files changed, 1 insertion(+), 181 deletions(-)
Index
Also give functions more sensible names: nvram_misc_* for misc device ops,
nvram_proc_* for proc file ops and nvram_module_* for init and exit
functions. This makes them distict from nvram_ops members.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/nvram.c | 194
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/char/nvram.c |1 +
1 file changed, 1 insertion(+)
Index: linux/drivers/char/nvram.c
===
--- linux.orig/drivers/char/nvram.c 2015-05-31 11:01:11.0
Make use of arch_nvram_ops in the thinkpad_acpi driver so that the
nvram_* function exports can be removed.
This patch series was tested on a ThinkPad T43.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/platform/x86/thinkpad_acpi.c | 20 ++--
1 file changed
Drivers now use the arch_nvram_ops calls so remove the function exports and
prototypes. nvram_check_checksum() is unused so remove it.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
arch/m68k/atari/nvram.c |6 +++---
drivers/char/nvram.c| 27
and chrp_nvram_write, which break the naming convention used across
PowerPC platforms for NVRAM accessor functions.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
arch/powerpc/platforms/chrp/nvram.c | 14 ++
arch/powerpc/platforms/powermac/nvram.c |9 +
2 files changed, 19
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
Tested on a PowerBook 520 and Quadra 650.
---
arch/m68k/mac/misc.c | 35 +--
include/uapi/linux/pmu.h |2 ++
2 files changed, 31 insertions(+), 6 deletions(-)
Index: linux/arch/m68k/mac/misc.c
1 - 100 of 2949 matches
Mail list logo
