Re: [PATCH v10 0/9] firmware: add request_partial_firmware_into_buf

2020-07-07 Thread Florian Fainelli
On 7/6/2020 4:23 PM, Scott Branden wrote: > This patch series adds partial read support via a new call > request_partial_firmware_into_buf. > Such support is needed when the whole file is not needed and/or > only a smaller portion of the file will fit into allocated memory > at any one time. >

Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device

2020-07-07 Thread Florian Fainelli
Hi Chris, On 7/4/2020 6:26 PM, Chris Healy wrote: > Update MDIO configuration with zii-ultra device to fully utilize > MDIO endpoint capabilities. Device supports 12.5MHz clock and > doesn't require MDIO preamble. > > Signed-off-by: Chris Healy > --- >

Re: PHY reset handling during DT parsing

2020-07-07 Thread Florian Fainelli
On 7/7/2020 10:18 AM, Rob Herring wrote: > On Tue, Jul 7, 2020 at 10:39 AM Florian Fainelli wrote: >> >> >> >> On 7/7/2020 7:54 AM, Maxime Ripard wrote: >>> Hi Andrew, >>> >>> On Tue, Jul 07, 2020 at 04:19:18PM +0200, Andrew Lunn wrote:

Re: PHY reset handling during DT parsing

2020-07-07 Thread Florian Fainelli
On 7/7/2020 7:54 AM, Maxime Ripard wrote: > Hi Andrew, > > On Tue, Jul 07, 2020 at 04:19:18PM +0200, Andrew Lunn wrote: >> On Mon, Jul 06, 2020 at 08:13:31PM +0200, Maxime Ripard wrote: >>> I came across an issue today on an Allwinner board, but I believe it's a >>> core issue. >>> >>> That

Re: [GIT PULL 1/1] bcm2835-dt-next-2020-07-06

2020-07-06 Thread Florian Fainelli
On 7/6/2020 10:11 AM, Nicolas Saenz Julienne wrote: > Hi Florian, > > The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: > > Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) > > are available in the Git repository at: > >

[PATCH net-next] net: systemport: Add support for VLAN transmit acceleration

2020-07-06 Thread Florian Fainelli
SYSTEMPORT is capable of performing VLAN transmit acceleration, support that by configuring it appropriately, providing the VLAN ID and PCP/DEI where necessary. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 37 -- 1 file changed, 34

Re: [PATCH net-next v2 3/3] net: ethtool: Remove PHYLIB direct dependency

2020-07-06 Thread Florian Fainelli
On 7/6/2020 11:40 AM, Jakub Kicinski wrote: > On Sun, 5 Jul 2020 21:27:58 -0700 Florian Fainelli wrote: >> +ops = ethtool_phy_ops; >> +if (!ops || !ops->start_cable_test) { > > nit: don't think member-by-member checking is necessary. We don't > expect

[PATCH net-next v2 0/3] net: ethtool: Untangle PHYLIB dependency

2020-07-05 Thread Florian Fainelli
. Florian Fainelli (3): net: ethtool: Introduce ethtool_phy_ops net: phy: Register ethtool PHY operations net: ethtool: Remove PHYLIB direct dependency drivers/net/phy/phy_device.c | 7 +++ include/linux/ethtool.h | 25 + net/Kconfig | 1

[PATCH net-next v2 2/3] net: phy: Register ethtool PHY operations

2020-07-05 Thread Florian Fainelli
Utilize ethtool_set_ethtool_phy_ops to register a suitable set of PHY ethtool operations in a dynamic fashion such that ethtool will no longer directy reference PHY library symbols. Signed-off-by: Florian Fainelli --- drivers/net/phy/phy_device.c | 7 +++ 1 file changed, 7 insertions

[PATCH net-next v2 3/3] net: ethtool: Remove PHYLIB direct dependency

2020-07-05 Thread Florian Fainelli
Now that we have introduced ethtool_phy_ops and the PHY library dynamically registers its operations with that function pointer, we can remove the direct PHYLIB dependency in favor of using dynamic operations. Signed-off-by: Florian Fainelli --- net/Kconfig | 1 - net/ethtool

[PATCH net-next v2 1/3] net: ethtool: Introduce ethtool_phy_ops

2020-07-05 Thread Florian Fainelli
In order to decouple ethtool from its PHY library dependency, define an ethtool_phy_ops singleton which can be overriden by the PHY library when it loads with an appropriate set of function pointers. Signed-off-by: Florian Fainelli --- include/linux/ethtool.h | 25 + net

[PATCH net-next] net: bcmgenet: Allow changing carrier from user-space

2020-07-02 Thread Florian Fainelli
. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index af924a8b885f..ee84a26bd8f3 100644

Re: [net-next,PATCH 4/4] dt-bindings: mdio-ipq4019: add clock support

2020-07-02 Thread Florian Fainelli
On 7/2/2020 12:18 PM, Robert Marko wrote: > On Thu, Jul 2, 2020 at 3:38 PM Andrew Lunn wrote: >> >>> + clock-frequency: >>> +default: 1 >> >> IEEE 802.3 says the default should be 2.5MHz. Some PHYs will go >> faster, but 100MHz seems unlikely! > This MDIO controller has an

Re: [net-next,PATCH 2/4] net: mdio-ipq4019: add clock support

2020-07-02 Thread Florian Fainelli
On 7/2/2020 3:29 AM, Robert Marko wrote: > Some newer SoC-s have a separate MDIO clock that needs to be enabled. > So lets add support for handling the clocks to the driver. > > Signed-off-by: Robert Marko > --- > drivers/net/phy/mdio-ipq4019.c | 28 +++- > 1 file

Re: [net-next,PATCH 1/4] net: mdio-ipq4019: change defines to upper case

2020-07-02 Thread Florian Fainelli
On 7/2/2020 3:29 AM, Robert Marko wrote: > In the commit adding the IPQ4019 MDIO driver, defines for timeout and sleep > partially used lower case. > Lets change it to upper case in line with the rest of driver defines. > > Signed-off-by: Robert Marko Reviewed-by: F

Re: [PATCH net-next 0/4] net: ethtool: Untangle PHYLIB dependency

2020-07-02 Thread Florian Fainelli
On 7/2/2020 9:35 AM, Jakub Kicinski wrote: > On Thu, 2 Jul 2020 18:34:24 +0200 Andrew Lunn wrote: >> On Thu, Jul 02, 2020 at 05:56:52PM +0200, Michal Kubecek wrote: >>> On Wed, Jul 01, 2020 at 09:29:38PM -0700, Florian Fainelli wrote: >>>> Hi all, >>

[PATCH net-next 1/4] net: Add cable test netdevice operations

2020-07-01 Thread Florian Fainelli
In preparation for decoupling the ethtool cable test from the PHY library, add definitions for two new network device operations: * ndo_cable_test_start * ndo_cable_test_tdr_start In a subsequent patch we will start making use of those. Signed-off-by: Florian Fainelli --- include/linux

[PATCH net-next 2/4] net: phy: Change cable test arguments to net_device

2020-07-01 Thread Florian Fainelli
In order to untangle the ethtool/cabletest feature with the PHY library, make the PHY library functions take a net_device argument and derive the phy_device reference from there. No functional changes introduced. Signed-off-by: Florian Fainelli --- drivers/net/phy/phy.c | 18

[PATCH net-next 0/4] net: ethtool: Untangle PHYLIB dependency

2020-07-01 Thread Florian Fainelli
variants when a network device driver attaches to a PHY device. Florian Fainelli (4): net: Add cable test netdevice operations net: phy: Change cable test arguments to net_device net: phy: Automatically set-up cable test netdev_ops net: ethtool: Remove PHYLIB dependency drivers/net/phy

[PATCH net-next 4/4] net: ethtool: Remove PHYLIB dependency

2020-07-01 Thread Florian Fainelli
Now that we have converted the ethtool/cabletest code to use netdev_ops, we can remove the PHY library dependency since the function pointers will now be provided upon PHY attachment to the network device. Signed-off-by: Florian Fainelli --- net/Kconfig | 1 - net/ethtool

[PATCH net-next 3/4] net: phy: Automatically set-up cable test netdev_ops

2020-07-01 Thread Florian Fainelli
-off-by: Florian Fainelli --- drivers/net/phy/phy_device.c | 32 include/linux/phy.h | 2 ++ 2 files changed, 34 insertions(+) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index eb1068a77ce1..100d85541a06 100644 --- a/drivers

Re: [PATCH 1/5] hwrng: bcm2835 - Constify bcm2835_rng_devtype[]

2020-07-01 Thread Florian Fainelli
ers/char/hw_random/bcm2835-rng.o > > After: >textdata bss dec hex filename >2464 104 02568 a08 drivers/char/hw_random/bcm2835-rng.o > > Signed-off-by: Rikard Falkeborn Acked-by: Florian Fainelli -- Florian

Re: [PATCH] pinctrl: initialise nsp-mux earlier.

2020-06-30 Thread Florian Fainelli
On 6/30/2020 9:37 PM, Mark Tomlinson wrote: > On Tue, 2020-06-30 at 20:14 -0700, Florian Fainelli wrote: >> Sorry, it looks like I made a mistake in my testing (or I was lucky), >>> and this patch doesn't fix the issue. What is happening is: >>> 1) nsp-pinmux driver i

Re: [PATCH] pinctrl: initialise nsp-mux earlier.

2020-06-30 Thread Florian Fainelli
On 6/30/2020 7:23 PM, Mark Tomlinson wrote: > On Tue, 2020-06-30 at 15:08 -0700, Ray Jui wrote: >> May I know which GPIO driver you are referring to on NSP? Both the iProc >> GPIO driver and the NSP GPIO driver are initialized at the level of >> 'arch_initcall_sync', which is supposed to be

[PATCH net-next] net: dsa: Improve subordinate PHY error message

2020-06-29 Thread Florian Fainelli
It is not very informative to know the DSA master device when a subordinate network device fails to get its PHY setup. Provide the device name and capitalize PHY while we are it. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH] of: of_mdio: count number of regitered phys

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:45 PM, Andrew Lunn wrote: > On Mon, Jun 29, 2020 at 10:26:36AM +0300, Claudiu Beznea wrote: >> In case of_mdiobus_register_phy()/of_mdiobus_register_device() >> returns -ENODEV for all PHYs in device tree or for all scanned >> PHYs there is a chance that of_mdiobus_register() to

Re: [PATCH v2 06/10] phy: mdio: add kerneldoc for __devm_mdiobus_register()

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:03 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This function is not documented. Add a short kerneldoc description. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 03/10] net: devres: rename the release callback of devm_register_netdev()

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:03 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Make it an explicit counterpart to devm_register_netdev() just like we > do with devm_free_netdev() for better clarity. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 05/10] phy: un-inline devm_mdiobus_register()

2020-06-29 Thread Florian Fainelli
.c. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 5/9] usb: xhci-pci: Add support for reset controllers

2020-06-29 Thread Florian Fainelli
: Nicolas Saenz Julienne > Acked-by: Mathias Nyman > Reviewed-by: Philipp Zabel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 4/9] ARM: dts: bcm2711: Add reset controller to xHCI node

2020-06-29 Thread Florian Fainelli
the relevant PCI device. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle

2020-06-29 Thread Florian Fainelli
of the define, if you also remove it you can add: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle

2020-06-29 Thread Florian Fainelli
lse [-Wtype-limits] > > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you remove it as w

Re: [PATCH v2 01/10] net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init()

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:03 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This function may fail. Check its return value and propagate the error > code. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free()

2020-06-29 Thread Florian Fainelli
as the release > callback will be called automatically. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 04/10] Documentation: devres: add missing mdio helper

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:03 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We have a devres variant of mdiobus_register() but it's not listed in > devres.rst. Add it under other mdio devm functions. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 08/10] of: mdio: remove the 'extern' keyword from function declarations

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:03 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The 'extern' keyword in headers doesn't have any benefit. Remove them > all from the of_mdio.h header. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] ARM: dts: bcm: Align L2 cache-controller nodename with dtschema

2020-06-26 Thread Florian Fainelli
On Fri, 26 Jun 2020 10:06:46 +0200, Krzysztof Kozlowski wrote: > Fix dtschema validator warnings like: > l2-cache@22000: $nodename:0: > 'l2-cache@22000' does not match > '^(cache-controller|cpu)(@[0-9a-f,]+)*$' > > Signed-off-by: Krzysztof Kozlowski > --- Applied to

Re: [PATCH net-next v3 7/7] arm64: dts: add serdes and mdio description

2020-06-26 Thread Florian Fainelli
On 6/22/20 6:35 AM, Florinel Iordache wrote: > Add dt nodes with serdes, lanes, mdio generic description for supported > platform: ls1046. This is a prerequisite to enable backplane on device > tree for these platforms. > > Signed-off-by: Florinel Iordache > --- [snip] > @@ -21,7 +22,7 @@

Re: [EXT] Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

2020-06-26 Thread Florian Fainelli
On 6/22/20 7:39 AM, Florinel Iordache wrote: >> -Original Message- >> From: Andrew Lunn >> Sent: Monday, June 22, 2020 5:25 PM >> To: Florinel Iordache >> Cc: da...@davemloft.net; net...@vger.kernel.org; f.faine...@gmail.com; >> hkallwe...@gmail.com; li...@armlinux.org.uk;

Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

2020-06-26 Thread Florian Fainelli
On 6/22/20 8:08 AM, Madalin Bucur (OSS) wrote: >> -Original Message- >> From: Andrew Lunn >> Sent: Monday, June 22, 2020 5:25 PM >> To: Florinel Iordache >> Cc: da...@davemloft.net; net...@vger.kernel.org; f.faine...@gmail.com; >> hkallwe...@gmail.com; li...@armlinux.org.uk;

Re: [EXT] Re: [PATCH net-next v3 2/7] dt-bindings: net: add backplane dt bindings

2020-06-26 Thread Florian Fainelli
On 6/24/20 5:55 AM, Florinel Iordache wrote: >> -Original Message- >> From: Florian Fainelli >> Sent: Tuesday, June 23, 2020 1:21 AM >> To: Florinel Iordache ; da...@davemloft.net; >> net...@vger.kernel.org; and...@lunn.ch; hkallwe...@gmail.com; >>

Re: [PATCH 6/6] net: phy: mdio: reset MDIO devices even if probe() is not implemented

2020-06-26 Thread Florian Fainelli
ything in probe(). > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 5/6] net: phy: reset the PHY even if probe() is not implemented

2020-06-26 Thread Florian Fainelli
own reset line(s) during probe in a later changeset. Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 4/6] net: mdio: add a forward declaration for reset_control to mdio.h

2020-06-26 Thread Florian Fainelli
ut for the sake of correctness add the > forward declaration for struct reset_control. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [fedora-arm] Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

2020-06-26 Thread Florian Fainelli
On 6/26/2020 2:09 AM, Peter Robinson wrote: > On Fri, Jun 26, 2020 at 5:42 AM Florian Fainelli wrote: >> >> >> >> On 6/25/2020 4:23 PM, Peter Robinson wrote: >>>> I'm having troubles with the Banana Pi-R1 router with newer kernels. No >>>

Re: [fedora-arm] Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

2020-06-25 Thread Florian Fainelli
On 6/25/2020 4:23 PM, Peter Robinson wrote: >> I'm having troubles with the Banana Pi-R1 router with newer kernels. No >> config changes, config works well since a lot of lernel updates ... >> Banana Pi-R1 is configured via systemd-networkd and uses the DSA >> (Distributed Switch Architecture)

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Florian Fainelli
On 6/24/2020 4:34 PM, David Miller wrote: > From: Florian Fainelli > Date: Wed, 24 Jun 2020 15:10:51 -0700 > >> Did you mean that you applied v4? It does not look like you pushed your >> local changes to net-next yet, so I cannot tell for sure. > > I ended up app

Re: [PATCH net 1/3] net: bcmgenet: re-remove bcmgenet_hfb_add_filter

2020-06-24 Thread Florian Fainelli
t: remove unused function in > bcmgenet.c"") > Reported-by: kbuild test robot > Signed-off-by: Doug Berger Acked-by: Florian Fainelli -- Florian

Re: [PATCH net 2/3] net: bcmgenet: use __be16 for htons(ETH_P_IP)

2020-06-24 Thread Florian Fainelli
ethtool rxnfc flows") > Reported-by: kbuild test robot > Signed-off-by: Doug Berger Acked-by: Florian Fainelli -- Florian

Re: [PATCH net 3/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread Florian Fainelli
ardware also always appends the FCS value to the > frame. > > Fixes: 474ea9cafc45 ("net: bcmgenet: correctly pad short packets") > Signed-off-by: Doug Berger Acked-by: Florian Fainelli -- Florian

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Florian Fainelli
On 6/24/20 2:43 PM, David Miller wrote: > From: Jisheng Zhang > Date: Wed, 24 Jun 2020 11:25:16 +0800 > >> We face an issue with rtl8211f, a pin is shared between INTB and PMEB, >> and the PHY Register Accessible Interrupt is enabled by default, so >> the INTB/PMEB pin is always active in

Re: [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:48 AM, Bartosz Golaszewski wrote: > śr., 24 cze 2020 o 11:43 Mark Brown napisał(a): >> >> On Tue, Jun 23, 2020 at 12:49:15PM -0700, Florian Fainelli wrote: >>> On 6/22/20 6:51 AM, Mark Brown wrote: >> >>>> If the bus includes p

Re: [PATCH stable 4.9 00/21] Unbreak 32-bit DVB applications on 64-bit kernels

2020-06-24 Thread Florian Fainelli
On 6/23/2020 12:13 PM, Greg KH wrote: > On Fri, Jun 05, 2020 at 09:24:57AM -0700, Florian Fainelli wrote: >> Hi all, >> >> This long patch series was motivated by backporting Jaedon's changes >> which add a proper ioctl compatibility layer for 32-bit applications &

Re: reset-brcmstb-rescal.c:undefined reference to `devm_ioremap_resource'

2020-06-23 Thread Florian Fainelli
On 6/23/2020 6:26 PM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3e08a95294a4fb3702bb3d35ed08028433c37fe6 > commit: 4cf176e52397853e4a4dd37e917c5eafb47ba8d1 reset: Add Broadcom STB > RESCAL reset controller > date:

Re: [PATCH v3 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-23 Thread Florian Fainelli
Le 2020-06-23 à 20:26, Jisheng Zhang a écrit : > Call phy_disable_interrupts() in phy_init_hw() to "have a defined init > state as we don't know in which state the PHY is if the PHY driver is > loaded. We shouldn't assume that it's the chip power-on defaults, BIOS > or boot loader could have

Re: [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration

2020-06-23 Thread Florian Fainelli
On 6/22/20 6:51 AM, Mark Brown wrote: > On Mon, Jun 22, 2020 at 03:39:40PM +0200, Andrew Lunn wrote: > >> The PHY subsystem cannot be the first to run into this problem, that >> you need a device structure to make use of the regulator API, but you >> need the regulator API to probe the device.

Re: [PATCH 12/15] dt-bindings: mdio: add phy-supply property to ethernet phy node

2020-06-23 Thread Florian Fainelli
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The phy-supply property is often added to MAC nodes but this is wrong > conceptually. These supplies should be part of the PHY node on the > MDIO bus. Add phy-supply property at PHY level to mdio.yaml. > >

Re: [PATCH 06/15] net: phy: mdio: reset MDIO devices even if probe() is not implemented

2020-06-23 Thread Florian Fainelli
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Similarily to PHY drivers - there's no reason to require probe() to be > implemented in order to call mdio_device_reset(). MDIO devices can have > resets defined without needing to do anything in probe(). > >

Re: [PATCH 05/15] net: phy: reset the PHY even if probe() is not implemented

2020-06-23 Thread Florian Fainelli
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently we only call phy_device_reset() if the PHY driver implements > the probe() callback. This is not mandatory and many drivers (e.g. > realtek) don't need probe() for most devices but still can have reset >

Re: [PATCH 04/15] net: mdio: add a forward declaration for reset_control to mdio.h

2020-06-23 Thread Florian Fainelli
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This header refers to struct reset_control but doesn't include any reset > header. The structure definition is probably somehow indirectly pulled in > since no warnings are reported but for the sake of correctness add

Re: [PATCH 03/15] net: phy: arrange headers in phy_device.c alphabetically

2020-06-23 Thread Florian Fainelli
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Keeping the headers in alphabetical order is better for readability and > allows to easily see if given header is already included. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 02/15] net: phy: arrange headers in mdio_device.c alphabetically

2020-06-23 Thread Florian Fainelli
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Keeping the headers in alphabetical order is better for readability and > allows to easily see if given header is already included. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 01/15] net: phy: arrange headers in mdio_bus.c alphabetically

2020-06-23 Thread Florian Fainelli
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Keeping the headers in alphabetical order is better for readability and > allows to easily see if given header is already included. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH stable 4.9] arm64: entry: Place an SB sequence following an ERET instruction

2020-06-23 Thread Florian Fainelli
On 6/11/20 9:42 PM, Florian Fainelli wrote: > From: Will Deacon > > commit 679db70801da9fda91d26caf13bf5b5ccc74e8e8 upstream > > Some CPUs can speculate past an ERET instruction and potentially perform > speculative accesses to memory before processing the exception return. &g

Re: [PATCH 06/11] phy: un-inline devm_mdiobus_register()

2020-06-22 Thread Florian Fainelli
On 6/22/20 3:00 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Functions should only be static inline if they're very short. This > devres helper is already over 10 lines and it will grow soon as we'll > be improving upon its approach. Pull it into mdio_devres.c. > >

Re: [PATCH net-next v3 2/7] dt-bindings: net: add backplane dt bindings

2020-06-22 Thread Florian Fainelli
On 6/22/20 6:35 AM, Florinel Iordache wrote: > Add ethernet backplane device tree bindings > > Signed-off-by: Florinel Iordache > --- [snip] > +properties: > + $nodename: > +pattern: "^serdes(@[a-f0-9]+)?$" > + > + compatible: > +oneOf: > + - const: serdes-10g > +

Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

2020-06-21 Thread Florian Fainelli
Le 2020-06-20 à 12:37, Gerhard Wiesinger a écrit : > Hello Florian, > > On 20.06.2020 21:13, Florian Fainelli wrote: >> Hi, >> >> On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote: >> Can you share your network configuration again with me? > > Find the net

Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

2020-06-20 Thread Florian Fainelli
Hi, On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote: > Hello, > > I'm having troubles with the Banana Pi-R1 router with newer kernels. No > config changes, config works well since a lot of lernel updates ... > Banana Pi-R1 is configured via systemd-networkd and uses the DSA > (Distributed Switch

Re: [PATCH v5 2/2] phy: bcm63xx-usbh: Add BCM63xx USBH driver

2020-06-19 Thread Florian Fainelli
On 6/19/2020 3:00 AM, Álvaro Fernández Rojas wrote: > Add BCM63xx USBH PHY driver for BMIPS. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli This looks great, thanks Alvaro! -- Florian

[PATCH net v2 0/2] net: phy: MDIO bus scanning fixes

2020-06-19 Thread Florian Fainelli
of -ENODEV - added Andrew's Reviewed-by tag Florian Fainelli (2): of: of_mdio: Correct loop scanning logic net: phy: Check harder for errors in get_phy_id() drivers/net/phy/phy_device.c | 6 -- drivers/of/of_mdio.c | 9 +++-- 2 files changed, 11 insertions(+), 4 deletions

[PATCH net v2 2/2] net: phy: Check harder for errors in get_phy_id()

2020-06-19 Thread Florian Fainelli
Andrew Lunn Signed-off-by: Florian Fainelli --- drivers/net/phy/phy_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 04946de74fa0..85ba95b598b5 100644 --- a/drivers/net/phy/phy_device.c +

[PATCH net v2 1/2] of: of_mdio: Correct loop scanning logic

2020-06-19 Thread Florian Fainelli
65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()") Reviewed-by: Andrew Lunn Signed-off-by: Florian Fainelli --- drivers/of/of_mdio.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index a04afe79529c..ef6f8

Re: [PATCH net 2/2] net: phy: Check harder for errors in get_phy_id()

2020-06-19 Thread Florian Fainelli
On 6/19/2020 6:30 AM, Russell King - ARM Linux admin wrote: > On Fri, Jun 19, 2020 at 03:26:59PM +0200, Andrew Lunn wrote: >> On Thu, Jun 18, 2020 at 09:47:59PM -0700, Florian Fainelli wrote: >>> Commit 02a6efcab675 ("net: phy: allow scanning busses with missing >

Re: [PATCH v5 2/3] dt-bindings: net: mscc-vsc8531: add optional clock properties

2020-06-18 Thread Florian Fainelli
On 6/18/2020 5:11 AM, Heiko Stuebner wrote: > From: Heiko Stuebner > > Some mscc ethernet phys have a configurable clock output, so describe the > generic properties to access them in devicetrees. > > Signed-off-by: Heiko Stuebner > --- >

[PATCH net 1/2] of: of_mdio: Correct loop scanning logic

2020-06-18 Thread Florian Fainelli
65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()") Signed-off-by: Florian Fainelli --- drivers/of/of_mdio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index a04afe79529c..7496dc64d6b5 100644 --- a/drivers/of/of_mdio.

[PATCH net 0/2] net: phy: MDIO bus scanning fixes

2020-06-18 Thread Florian Fainelli
Hi all, This patch series fixes two problems with the current MDIO bus scanning logic which was identified while moving from 4.9 to 5.4 on devices that do rely on scanning the MDIO bus at runtime because they use pluggable cards. Florian Fainelli (2): of: of_mdio: Correct loop scanning logic

[PATCH net 2/2] net: phy: Check harder for errors in get_phy_id()

2020-06-18 Thread Florian Fainelli
eturn -EIO which will be treated as a hard error, thus preventing MDIO bus scanning loops to continue succesfully. Apply the same logic to both register reads, thus allowing the scanning logic to proceed. Fixes: 02a6efcab675 ("net: phy: allow scanning busses with missing phys") Signed-off-

Re: [PATCH net-next] of: mdio: preserve phy dev_flags in of_phy_connect()

2020-06-18 Thread Florian Fainelli
similar to commit e7312efbd5de ("net: phy: modify assignment > to OR for dev_flags in phy_attach_direct"). > > Signed-off-by: Tao Ren Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-18 Thread Florian Fainelli
On 6/18/2020 5:56 AM, Andrew Lunn wrote: > On Wed, Jun 17, 2020 at 08:42:44PM -0700, Florian Fainelli wrote: >> of_find_node_by_name() will do an of_node_put() on the "from" argument. > >> Fixes: afa3b592953b ("net: dsa: bcm_sf2: Ensure correct sub-node is p

[PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-17 Thread Florian Fainelli
increment the reference count prior to the call. Fixes: afa3b592953b ("net: dsa: bcm_sf2: Ensure correct sub-node is parsed") Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.

Re: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h

2020-06-17 Thread Florian Fainelli
ile included from tui.c:31:0: > tmon.h:54:17: error: field 'tv' has incomplete type > struct timeval tv; > ^~ > make[3]: *** [: tui.o] Error 1 > make[2]: *** [Makefile:83: tmon] Error 2 > > Signed-off-by: Markus Mayer Acked-by: Florian Fainelli -- Florian

Re: [GIT PULL 1/1] bcm2835-drivers-fixes-2020-0-17

2020-06-17 Thread Florian Fainelli
On 6/17/2020 4:14 AM, Nicolas Saenz Julienne wrote: > Hi Florian, > > The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: > > Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) > > are available in the Git repository at: > >

Re: [PATCH 2/3] dt-bindings: Document BCM6328 PCIe Host Controller

2020-06-17 Thread Florian Fainelli
On 6/17/2020 3:25 AM, Álvaro Fernández Rojas wrote: > BCM6328 PCIe host controller is found on BCM6328, BCM6362 and BCM63268 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > .../bindings/pci/brcm,bcm6328-pcie.yaml | 109 ++ > 1 file changed, 109 insertions(+) >

Re: [PATCH 6/8] mips: bmips: add BCM6368 clock definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Add header with BCM6368 definitions in order to be able to include it from > device tree files. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 8/8] clk: bcm63xx-gate: switch to dt-bindings definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Now that there are header files for each SoC, let's use them in the > bcm63xx-gate controller driver. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 7/8] mips: bmips: add BCM63268 clock definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Add header with BCM63268 definitions in order to be able to include it from > device tree files. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 2/8] mips: bmips: add BCM6318 clock definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Add header with BCM6318 definitions in order to be able to include it from > device tree files. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 5/8] mips: bmips: add BCM6362 clock definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Add header with BCM6362 definitions in order to be able to include it from > device tree files. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 4/8] mips: bmips: add BCM6358 clock definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Add header with BCM6358 definitions in order to be able to include it from > device tree files. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 3/8] mips: bmips: add BCM6328 clock definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Add header with BCM6328 definitions in order to be able to include it from > device tree files. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 1/8] mips: bmips: add BCM3368 clock definitions

2020-06-17 Thread Florian Fainelli
On 6/15/2020 2:02 AM, Álvaro Fernández Rojas wrote: > Add header with BCM3368 definitions in order to be able to include it from > device tree files. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v3 2/2] phy: bcm63xx-usbh: Add BCM63xx USBH driver

2020-06-17 Thread Florian Fainelli
On 6/16/2020 11:45 AM, Álvaro Fernández Rojas wrote: > Add BCM63xx USBH PHY driver for BMIPS. > > Signed-off-by: Álvaro Fernández Rojas As discussed in the v2 series, you also need to control the UTMI_CONTROL1 register for operating the port in device/host/otg mode. -- Florian

Re: [PATCH 1/2] dt-bindings: phy: add bcm63xx-usbh bindings

2020-06-17 Thread Florian Fainelli
On 6/17/2020 4:16 AM, Álvaro Fernández Rojas wrote: >> On 6328, the same register space allows the controlling of the USB PHY >> in either host or device mode, so I believe you would need to add a >> #phy-cells = 1 in order to distinguish the consumer (host versus device) >> if we get to the

Re: [PATCH v3 1/2] dt-bindings: phy: add bcm63xx-usbh bindings

2020-06-17 Thread Florian Fainelli
On 6/17/2020 2:20 PM, Florian Fainelli wrote: > > > On 6/16/2020 11:45 AM, Álvaro Fernández Rojas wrote: >> Document BCM63xx USBH PHY bindings. >> >> Signed-off-by: Álvaro Fernández Rojas > > > > Since the USB PHY supports both roles (host and devic

Re: [PATCH v3 1/2] dt-bindings: phy: add bcm63xx-usbh bindings

2020-06-17 Thread Florian Fainelli
ng/name accordingly. With that: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH stable 4.9 00/21] Unbreak 32-bit DVB applications on 64-bit kernels

2020-06-16 Thread Florian Fainelli
On 6/11/2020 9:45 PM, Florian Fainelli wrote: > > > On 6/5/2020 9:24 AM, Florian Fainelli wrote: >> Hi all, >> >> This long patch series was motivated by backporting Jaedon's changes >> which add a proper ioctl compatibility layer for 32-bit applications >

Re: [PATCH 1/2] dt-bindings: phy: add bcm63xx-usbh bindings

2020-06-16 Thread Florian Fainelli
On 6/16/2020 11:10 AM, Álvaro Fernández Rojas wrote: > Hello Florian, > >> El 16 jun 2020, a las 19:17, Florian Fainelli >> escribió: >> >> >> >> On 6/16/2020 1:34 AM, Álvaro Fernández Rojas wrote: >>> Document BCM63xx USBH PHY bind

Re: [PATCH v3 2/4] spi: bcm63xx-spi: allow building for BMIPS

2020-06-16 Thread Florian Fainelli
On 6/16/2020 10:25 AM, Mark Brown wrote: > On Tue, Jun 16, 2020 at 10:15:15AM -0700, Florian Fainelli wrote: >> On 6/16/2020 10:07 AM, Mark Brown wrote: > >>> Please do not submit new versions of already applied patches, please >>> submit incremental updates to

Re: [PATCH 2/2] phy: bcm63xx-usbh: Add BCM63xx USBH driver

2020-06-16 Thread Florian Fainelli
On 6/16/2020 1:34 AM, Álvaro Fernández Rojas wrote: > Add BCM63xx USBH PHY driver for BMIPS. > > Signed-off-by: Álvaro Fernández Rojas This looks good to me at first glance, just a few comments below. > --- > drivers/phy/broadcom/Kconfig| 10 + > drivers/phy/broadcom/Makefile

<    6   7   8   9   10   11   12   13   14   15   >