Re: [PATCH] PCI: Don't use Printk in raw_spinlocks

2020-09-10 Thread Florian Fainelli
On 9/10/2020 12:20 PM, Bjorn Helgaas wrote: On Thu, Sep 10, 2020 at 11:50:07AM -0700, Florian Fainelli wrote: On 9/10/2020 11:46 AM, Bjorn Helgaas wrote: On Thu, Sep 10, 2020 at 08:21:06AM -0600, Rob Herring wrote: On Wed, Sep 9, 2020 at 8:07 PM Bjorn Helgaas wrote: [+cc Mark, Florian

Re: [PATCH v11 04/11] PCI: brcmstb: Add suspend and resume pm_ops

2020-09-10 Thread Florian Fainelli
Broadcom Set-top (BrcmSTB) boards typically support S2, S3, and S5 suspend and resume. Now the PCIe driver may do so as well. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 47 +++ 1 file changed, 47 insertions(+) diff

Re: [PATCH v11 04/11] PCI: brcmstb: Add suspend and resume pm_ops

2020-09-10 Thread Florian Fainelli
, and S5 suspend and resume. Now the PCIe driver may do so as well. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers

Re: [PATCH] PCI: Don't use Printk in raw_spinlocks

2020-09-10 Thread Florian Fainelli
On 9/10/2020 11:46 AM, Bjorn Helgaas wrote: On Thu, Sep 10, 2020 at 08:21:06AM -0600, Rob Herring wrote: On Wed, Sep 9, 2020 at 8:07 PM Bjorn Helgaas wrote: [+cc Mark, Florian, Rob, Scott] On Sat, Aug 01, 2020 at 09:25:49AM +0800, Xingxing Su wrote: Do not use printk in raw_spinlocks,

Re: [PATCH v11 04/11] PCI: brcmstb: Add suspend and resume pm_ops

2020-09-10 Thread Florian Fainelli
-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index c2b3d2946a36..3d588ab7a6dd 100644 --- a/drivers/pci/controller/pcie

Re: [PATCH 1/4] dt-bindings: spi: Add compatible string for brcmstb SoCs

2020-09-10 Thread Florian Fainelli
On 9/10/2020 8:25 AM, Ray Jui wrote: Add compatible string for brcmstb 7445 SoCs. Signed-off-by: Ray Jui Acked-by: Florian Fainelli -- Florian

Re: [PATCH 2/4] spi: bcm-qspi: Add compatible string for BRCMSTB 7445 SoCs

2020-09-10 Thread Florian Fainelli
On 9/10/2020 8:25 AM, Ray Jui wrote: Add compatible string for BRCMSTB 7445 SoCs and indicate it has MSPI rev support. Signed-off-by: Ray Jui Acked-by: Florian Fainelli -- Florian

Re: [PATCH 4/4] spi: bcm-qspi: Clean up 7425, 7429, and 7435 settings

2020-09-10 Thread Florian Fainelli
On 9/10/2020 8:25 AM, Ray Jui wrote: The Broadcom QSPI driver now falls back to no MSPI_DEV support as the default setting in the generic compatible string, explicit settings for STB chips 7425, 7429, and 7435 can be removed. Signed-off-by: Ray Jui Acked-by: Florian Fainelli -- Florian

Re: [PATCH 3/4] spi: bcm-qspi: Fix probe regression on iProc platforms

2020-09-10 Thread Florian Fainelli
lack of MSPI_REV offset") Link: https://lore.kernel.org/linux-arm-kernel/20200909211857.4144718-1-f.faine...@gmail.com/T/#u Signed-off-by: Ray Jui Acked-by: Florian Fainelli -- Florian

Re: [GIT PULL 1/1] bcm2835-dt-next-2020-09-08

2020-09-09 Thread Florian Fainelli
On 9/8/2020 11:54 AM, Nicolas Saenz Julienne wrote: Hi Florian, The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) are available in the Git repository at:

Re: [PATCH 0/5] qspi binding and DTS fixes

2020-09-09 Thread Florian Fainelli
On 8/27/2020 11:18 AM, Florian Fainelli wrote: Hi all, This patch series fixes incorrectly defined compatible strings for the Broadcom QSPI controller which resulted in the strings not being ordered from most to least compatible. We will need to apply some changes to the spi-bcm-qspi.c

Re: [PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering

2020-09-09 Thread Florian Fainelli
On 9/9/2020 1:41 PM, Rob Herring wrote: On Thu, 27 Aug 2020 11:18:38 -0700, Florian Fainelli wrote: The binding is currently incorrectly defining the compatible strings from least specific to most specific instead of the converse. Re-order them from most specific (left) to least specific

[PATCH net-next v2] net: dsa: b53: Report VLAN table occupancy via devlink

2020-09-09 Thread Florian Fainelli
We already maintain an array of VLANs used by the switch so we can simply iterate over it to report the occupancy via devlink. Signed-off-by: Florian Fainelli --- Changes in v2: - make count u64 - correct typo: s/PARMA/PARAM/ drivers/net/dsa/b53/b53_common.c | 60

[PATCH net-next] net: dsa: b53: Report VLAN table occupancy via devlink

2020-09-08 Thread Florian Fainelli
We already maintain an array of VLANs used by the switch so we can simply iterate over it to report the occupancy via devlink. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 59 ++-- drivers/net/dsa/b53/b53_priv.h | 1 + drivers/net/dsa

Re: [PATCH stable 4.19 v2 0/2] arm64: entry: Place an SB sequence following an ERET instruction

2020-09-08 Thread Florian Fainelli
On 8/24/2020 11:35 AM, Florian Fainelli wrote: Changes in v2: - included missing preliminary patch to define the SB barrier instruction Will Deacon (2): arm64: Add support for SB barrier and patch in over DSB; ISB sequences arm64: entry: Place an SB sequence following an ERET

Re: [PATCH v11 00/11] PCI: brcmstb: enable PCIe for STB chips

2020-09-07 Thread Florian Fainelli
On 9/7/2020 10:43 AM, Jim Quinlan wrote: On Mon, Sep 7, 2020 at 5:16 AM Lorenzo Pieralisi wrote: On Thu, Aug 27, 2020 at 09:29:59AM -0400, Jim Quinlan wrote: On Thu, Aug 27, 2020 at 2:35 AM Christoph Hellwig wrote: On Tue, Aug 25, 2020 at 10:40:27AM -0700, Florian Fainelli wrote: Hi

[PATCH 1/2] dt-bindings: bus: Document breakpoint interrupt for gisb-arb

2020-09-06 Thread Florian Fainelli
The GISB arbiter can have a third and optional interrupt to handle GISB breakpoints. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb

[PATCH 2/2] bus: brcmstb_gisb: Add support for breakpoint interrupts

2020-09-06 Thread Florian Fainelli
GISB breakpoint interrupts can be raised when a breakpoint has been enabled to match a specific master and/or GISB register address. Being able to print a message, similar to those done during target abort or timeout greatly helps debug systems. Signed-off-by: Florian Fainelli --- drivers/bus

[PATCH 0/2] bus: brcmstb_gisb: Add support for breakpoint interrupts

2020-09-06 Thread Florian Fainelli
. Florian Fainelli (2): dt-bindings: bus: Document breakpoint interrupt for gisb-arb bus: brcmstb_gisb: Add support for breakpoint interrupts .../devicetree/bindings/bus/brcm,gisb-arb.txt | 3 +- drivers/bus/brcmstb_gisb.c| 96 ++- 2 files changed, 97 insertions

Re: [PATCH] MAINTAINERS: Add entry for Broadcom BDC driver

2020-09-06 Thread Florian Fainelli
On 7/9/2020 8:48 PM, Florian Fainelli wrote: The Broadcom BDC driver did not have a MAINTAINERS entry which made it escape review from Al and myself, add an entry so the relevant mailing lists and people are copied. Signed-off-by: Florian Fainelli This patch still does not seem to have

Re: [PATCH 0/4] soc: bcm: brcmstb: BIUCTRL updates

2020-09-06 Thread Florian Fainelli
On 9/4/2020 1:50 PM, Florian Fainelli wrote: This patch series adds support for two new STB chips: 72164 and 72165 and allows them to be tuned the same way other Brahma-B53 chips are. The last two changes are some minor configuration changes to the read-ahead cache logic to improve

Re: [PATCH] ARM: brcmstb: Add debug UART entry for 72615

2020-09-06 Thread Florian Fainelli
On 9/4/2020 1:42 PM, Florian Fainelli wrote: 72165 has the same memory map as 7278 and the same physical address for the UART, alias the definition accordingly. Signed-off-by: Florian Fainelli Applied to soc/next -- Florian

[PATCH net-next v2 1/2] of: Export of_remove_property() to modules

2020-09-04 Thread Florian Fainelli
We will need to remove some OF properties in drivers/net/dsa/bcm_sf2.c with a subsequent commit. Export of_remove_property() to modules so we can keep bcm_sf2 modular and provide an empty stub for when CONFIG_OF is disabled to maintain the ability to compile test. Signed-off-by: Florian Fainelli

[PATCH net-next v2 2/2] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-04 Thread Florian Fainelli
force of_phy_connect() to fail, and have DSA call to dsa_slave_phy_connect(), we must deactivate ethernet-phy@0 from mdio@403c0, and the best way to do that is by removing the phandle property completely. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 31 +++

[PATCH net-next v2 0/2] net: dsa: bcm_sf2: Ensure MDIO diversion is used

2020-09-04 Thread Florian Fainelli
Changes in v2: - export of_update_property() to permit building bcm_sf2 as a module - provided a better explanation of the problem being solved after explaining it to Andrew during the v1 review Florian Fainelli (2): of: Export of_remove_property() to modules net: dsa: bcm_sf2: Ensure

Re: [PATCH v2 3/6] ARM: dts: NSP: Fix SP804 compatible node

2020-09-04 Thread Florian Fainelli
On 9/3/2020 6:04 PM, André Przywara wrote: On 02/09/2020 00:04, Florian Fainelli wrote: Hi Florian, sorry, the mail got swamped in my inbox... On 8/28/2020 10:12 AM, Florian Fainelli wrote: On 8/28/20 7:20 AM, Andre Przywara wrote: The DT binding for SP804 requires to have an &quo

[PATCH 3/4] soc: bcm: brcmstb: biuctrl: Change RAC prefetch distance from +/-1 to +/- 2

2020-09-04 Thread Florian Fainelli
Change the RAC prefetch distance from +/- 1 to +/- 2 for Cortex-A72 CPUs since this provides an average of a 3.8% performance increase for synthetic memcpy benchmarks. Signed-off-by: Florian Fainelli --- drivers/soc/bcm/brcmstb/biuctrl.c | 20 1 file changed, 16 insertions

[PATCH 4/4] soc: bcm: brcmstb: biuctrl: Change RAC data line prefetching after 4 consecutive lines

2020-09-04 Thread Florian Fainelli
Change the RACPREFDATA(x) setting to prefetch the next 256-byte line after 4 consecutive lines have been used, instead of after 2 consecutive lines. This does improve the synthetic memcpy benchmark by an additional +0.5% on top of the previous change for Cortex-A72 CPUs. Signed-off-by: Florian

[PATCH 2/4] soc: bcm: brcmstb: biuctrl: Tune MCP settings for 72165

2020-09-04 Thread Florian Fainelli
72165 uses a Brahma-B53 CPU and its Bus Interface Unit, tune it according to the existing values we have. Signed-off-by: Florian Fainelli --- drivers/soc/bcm/brcmstb/biuctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb

[PATCH 2/4] soc: brcmstb: biuctrl: Tune MCP settings for 72165

2020-09-04 Thread Florian Fainelli
72165 uses a Brahma-B53 CPU and its Bus Interface Unit, tune it according to the existing values we have. Signed-off-by: Florian Fainelli --- drivers/soc/bcm/brcmstb/biuctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb

[PATCH 1/4] soc: bcm: brcmstb: biuctrl: Tune MCP settings for 72164

2020-09-04 Thread Florian Fainelli
72164 uses a Brahma-B53 CPU and its Bus Interface Unit, tune it according to the existing values we have. Signed-off-by: Florian Fainelli --- drivers/soc/bcm/brcmstb/biuctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb

[PATCH 0/4] soc: bcm: brcmstb: BIUCTRL updates

2020-09-04 Thread Florian Fainelli
This patch series adds support for two new STB chips: 72164 and 72165 and allows them to be tuned the same way other Brahma-B53 chips are. The last two changes are some minor configuration changes to the read-ahead cache logic to improve performance for Cortex-A72 based systems. Florian Fainelli

[PATCH] ARM: brcmstb: Add debug UART entry for 72615

2020-09-04 Thread Florian Fainelli
72165 has the same memory map as 7278 and the same physical address for the UART, alias the definition accordingly. Signed-off-by: Florian Fainelli --- arch/arm/include/debug/brcmstb.S | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/arch/arm

Re: [PATCH 00/10] dt-bindings: Convert SP805 to Json-schema (and fix users)

2020-09-04 Thread Florian Fainelli
On 9/4/2020 8:35 AM, André Przywara wrote: On 04/09/2020 16:29, Florian Fainelli wrote: Hi, On 9/4/2020 1:58 AM, Linus Walleij wrote:>> On Fri, Aug 28, 2020 at 9:34 PM Florian Fainelli wrote: On 8/28/20 6:05 AM, Andre Przywara wrote: What is the plan for merging this series?

Re: [PATCH 00/10] dt-bindings: Convert SP805 to Json-schema (and fix users)

2020-09-04 Thread Florian Fainelli
On 9/4/2020 1:58 AM, Linus Walleij wrote: On Fri, Aug 28, 2020 at 9:34 PM Florian Fainelli wrote: On 8/28/20 6:05 AM, Andre Przywara wrote: What is the plan for merging this series? Should Rob pick up all changes or since those are non critical changes, should we just leave it to the SoC

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-03 Thread Florian Fainelli
On 9/3/2020 3:03 PM, Andrew Lunn wrote: The firmware provides the Device Tree but here is the relevant section for you pasted below. The problematic device is a particular revision of the silicon (D0) which got later fixed (E0) however the Device Tree was created after the fixed platform, not

Re: [PATCH v2 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file

2020-09-03 Thread Florian Fainelli
On 9/3/2020 8:17 PM, Chunfeng Yun wrote: Hi Florian, On Thu, 2020-08-20 at 19:30 +0800, Chunfeng Yun wrote: For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used). Cc: Florian Fainelli Signed-off

Re: [PATCH v2 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: fix the warning: WARNING:REPEATED_WORD: Possible repeated word: 'and' Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: fix checkpatch.pl error: ERROR:SPACING: space prohibited before that ',' Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 08/11] usb: gadget: bdc: use the BIT macro to define bit filed

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: Prefer using the BIT macro to define bit fileds Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements WARNING:TABSTOP: Statements should start on a tabstop Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 07/11] usb: gadget: bdc: avoid precedence issues

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: Add () around macro argument to avoid precedence issues Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 05/11] usb: gadget: bdc: fix check warning of block comments alignment

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: fix the warning: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 06/11] usb: gadget: bdc: add identifier name for function declaraion

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: This is used to avoid the warning of function arguments, e.g. WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli

Re: [PATCH v2 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: Prefer kzalloc(sizeof(*bd_table)...) over kzalloc(sizeof(struct bd_table) Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: No definition for bdc_ep_set_halt(), so remove it. Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 04/11] usb: gadget: bdc: fix warning of embedded function name

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: Use '"%s...", __func__' to replace embedded function name Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file

2020-09-03 Thread Florian Fainelli
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used). Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli -- Florian

Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Florian Fainelli
On 9/3/2020 9:41 AM, Dan Murphy wrote: Florian On 9/3/20 11:34 AM, Florian Fainelli wrote: On 9/3/2020 7:15 AM, Dan Murphy wrote: Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Signed-off

Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Florian Fainelli
so with that fixed, and the subject correct to "net-next" (this is no bug fix material), you can add: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread Florian Fainelli
On 9/2/2020 6:13 PM, Andrew Lunn wrote: On Wed, Sep 02, 2020 at 02:03:27PM -0700, Florian Fainelli wrote: Registering our slave MDIO bus outside of the OF infrastructure is necessary in order to avoid creating double references of the same Device Tree nodes, however it is not sufficient

[PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread Florian Fainelli
diversion is being used. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 1c7fbb6f0447..8e215c148487 100644 --- a/drivers

Re: [PATCH net] net: dp83867: Fix WoL SecureOn password

2020-09-02 Thread Florian Fainelli
On 9/2/2020 12:27 PM, Dan Murphy wrote: Fix the registers being written to as the values were being over written when writing the same registers. Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN") Signed-off-by: Dan Murphy Reviewed-by: Florian Fainelli -- Florian

Re: [RFT 06/11] mmc: sdhci-brcmstb: Simplify with optional clock and dev_err_probe()

2020-09-02 Thread Florian Fainelli
deferred. Signed-off-by: Krzysztof Kozlowski This is actually an open coded version of devm_clk_get_optional(), so this is fine: Acked-by: Florian Fainelli -- Florian

Re: [PATCH 01/11] mmc: bcm2835: Simplify with dev_err_probe()

2020-09-02 Thread Florian Fainelli
On 9/2/2020 12:36 PM, Krzysztof Kozlowski wrote: Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Acked-by: Florian Fainelli -- Florian

Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate_flow()

2020-09-02 Thread Florian Fainelli
l.org Signed-off-by: Denis Efremov Acked-by: Florian Fainelli -- Florian

Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()

2020-09-02 Thread Florian Fainelli
On 9/2/2020 8:06 AM, Krzysztof Kozlowski wrote: Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 3/6] ARM: dts: NSP: Fix SP804 compatible node

2020-09-01 Thread Florian Fainelli
On 8/28/2020 10:12 AM, Florian Fainelli wrote: On 8/28/20 7:20 AM, Andre Przywara wrote: The DT binding for SP804 requires to have an "arm,primecell" compatible string. Add this string so that the Linux primecell bus driver picks the device up and activates the clock. Fixes: a0

[PATCH net-next 2/3] net: dsa: bcm_sf2: request and handle clocks

2020-09-01 Thread Florian Fainelli
Fetch the corresponding clock resource and enable/disable it during suspend/resume if and only if we have no ports defined for Wake-on-LAN. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 20 ++-- drivers/net/dsa/bcm_sf2.h | 2 ++ 2 files changed, 20 insertions

[PATCH net-next 3/3] net: dsa: bcm_sf2: recalculate switch clock rate based on ports

2020-09-01 Thread Florian Fainelli
Whenever a port gets enabled/disabled, recalcultate the required switch clock rate to make sure it always gets set to the expected rate targeting our switch use case. This is only done for the BCM7445 switch as there is no clocking profile available for BCM7278. Signed-off-by: Florian Fainelli

[PATCH net-next 1/3] dt-bindings: net: Document Broadcom SF2 switch clocks

2020-09-01 Thread Florian Fainelli
Describe the two possible clocks feeding into the Broadcom SF2 integrated Ethernet switch. BCM7445 systems have two clocks, one for the main switch core clock, and another for controlling the switch clock divider whereas BCM7278 systems only have the first kind. Signed-off-by: Florian Fainelli

[PATCH net-next 0/3] net: dsa: bcm_sf2: Clock support

2020-09-01 Thread Florian Fainelli
Hi David, This patch series adds support for controlling the SF2 switch core and divider clock (where applicable). Florian Fainelli (3): dt-bindings: net: Document Broadcom SF2 switch clocks net: dsa: bcm_sf2: request and handle clocks net: dsa: bcm_sf2: recalculate switch clock rate based

[PATCH net-next 0/3] net: systemport: Clock support

2020-09-01 Thread Florian Fainelli
Hi David, This patch series makes the SYSTEMPORT driver request and manage its main and Wake-on-LAN clocks appropriately. Florian Fainelli (3): dt-bindings: net: Document Broadcom SYSTEMPORT clocks net: systemport: fetch and use clock resources net: systemport: Manage Wake-on-LAN clock

[PATCH net-next 1/3] dt-bindings: net: Document Broadcom SYSTEMPORT clocks

2020-09-01 Thread Florian Fainelli
The Broadcom SYSTEMPORT adapters require the use of two clocks for normal operations and during Wake-on-LAN, document those in the binding document. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/brcm,systemport.txt | 5 + 1 file changed, 5 insertions(+) diff

[PATCH net-next 3/3] net: systemport: Manage Wake-on-LAN clock

2020-09-01 Thread Florian Fainelli
It is necessary to manage the Wake-on-LAN clock to turn on the appropriate blocks for MPD or CFP-based packet matching to work otherwise we will not be able to reliably match packets during suspend. Reported-by: Blair Prescott Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom

[PATCH net-next 2/3] net: systemport: fetch and use clock resources

2020-09-01 Thread Florian Fainelli
-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 30 +- drivers/net/ethernet/broadcom/bcmsysport.h | 1 + 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index

Re: RFC: backport of commit a32c1c61212d

2020-09-01 Thread Florian Fainelli
On 9/1/2020 9:06 AM, Doug Berger wrote: On 9/1/2020 7:00 AM, Greg Kroah-Hartman wrote: [snip] Sorry for the confusion, but thanks for the reply. There is functionality that exists in Linus' tree, but it is not the result of a single commit that can be easily backported. I have been

Re: [PATCH 1/2] serial: 8250: Simplify with dev_err_probe()

2020-09-01 Thread Florian Fainelli
n"); For 8250_bcm2835aux.c: Acked-by: Florian Fainelli -- Florian

Re: [PATCH 04/11] spi: bcm2835: Simplify with dev_err_probe()

2020-09-01 Thread Florian Fainelli
On 9/1/2020 8:27 AM, Krzysztof Kozlowski wrote: Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Acked-by: Florian Fainelli -- Florian

Re: [PATCH 1/1] ARM: dts: bcm2711: Enable ddr modes on emmc2 controller

2020-08-31 Thread Florian Fainelli
On 8/29/2020 4:15 PM, Tobias Schramm wrote: This patch enables ddr modes for eMMC and SD storage on emmc2, doubling transfer speed. Previously only single data rate modes were used, wasting half the available throughput. The bcm2711 supports both SD and eMMC storage using ddr modes. Testing

Re: [PATCH 0/5] qspi binding and DTS fixes

2020-08-31 Thread Florian Fainelli
On 8/27/2020 11:18 AM, Florian Fainelli wrote: Hi all, This patch series fixes incorrectly defined compatible strings for the Broadcom QSPI controller which resulted in the strings not being ordered from most to least compatible. We will need to apply some changes to the spi-bcm-qspi.c

Re: [PATCH 08/10] ARM: dts: Cygnus: Fix SP805 clocks

2020-08-30 Thread Florian Fainelli
On 8/30/2020 8:55 PM, Florian Fainelli wrote: On Fri, 28 Aug 2020 14:06:00 +0100, Andre Przywara wrote: The SP805 DT binding requires two clocks to be specified, but the Broadcom Cygnus DT currently only specifies one clock. In practice, Linux would pick a clock named "apb

Re: [PATCH 03/10] arm64: dts: broadcom: Fix SP805 clock-names

2020-08-30 Thread Florian Fainelli
On Fri, 28 Aug 2020 14:05:55 +0100, Andre Przywara wrote: > The SP805 binding sets the name for the actual watchdog clock to > "wdog_clk" (with an underscore). > > Change the name in the DTs for Broadcom platforms to match that. The > Linux and U-Boot driver use the *first* clock for this

Re: [PATCH 09/10] ARM: dts: NSP: Fix SP805 clock-names

2020-08-30 Thread Florian Fainelli
On Fri, 28 Aug 2020 14:06:01 +0100, Andre Przywara wrote: > The SP805 binding sets the name for the actual watchdog clock to > "wdog_clk" (with an underscore). > > Change the name in the DTs for the Broadcom NSP platform to match that. > The Linux and U-Boot driver use the *first* clock for

Re: [PATCH 08/10] ARM: dts: Cygnus: Fix SP805 clocks

2020-08-30 Thread Florian Fainelli
On Fri, 28 Aug 2020 14:06:00 +0100, Andre Przywara wrote: > The SP805 DT binding requires two clocks to be specified, but the > Broadcom Cygnus DT currently only specifies one clock. > > In practice, Linux would pick a clock named "apb_pclk" for the bus > clock, and the Linux and U-Boot SP805

Re: [PATCH 00/10] dt-bindings: Convert SP805 to Json-schema (and fix users)

2020-08-28 Thread Florian Fainelli
On 8/28/20 2:28 PM, Rob Herring wrote: > On Fri, Aug 28, 2020 at 1:34 PM Florian Fainelli wrote: >> >> On 8/28/20 6:05 AM, Andre Przywara wrote: >>> This is an attempt to convert the SP805 watchdog DT binding to yaml. >>> This is done in the first patch, the

Re: [PATCH 00/10] dt-bindings: Convert SP805 to Json-schema (and fix users)

2020-08-28 Thread Florian Fainelli
On 8/28/20 6:05 AM, Andre Przywara wrote: > This is an attempt to convert the SP805 watchdog DT binding to yaml. > This is done in the first patch, the remaining nine fix some DT users. > > I couldn't test any of those DT files on actual machines, but tried > to make the changes in a way that

Re: [PATCH 03/10] arm64: dts: broadcom: Fix SP805 clock-names

2020-08-28 Thread Florian Fainelli
this purpose anyway, > so it does not break anything. Not that it really matters because the driver does a devm_clk_get(>dev, NULL), but yes, this should be fixed to conform to the binding. > > Signed-off-by: Andre Przywara Acked-by: Florian Fainelli -- Florian

Re: [PATCH 09/10] ARM: dts: NSP: Fix SP805 clock-names

2020-08-28 Thread Florian Fainelli
for this purpose > anyway, so it does not break anything. > > Signed-off-by: Andre Przywara Acked-by: Florian Fainelli -- Florian

Re: [PATCH 08/10] ARM: dts: Cygnus: Fix SP805 clocks

2020-08-28 Thread Florian Fainelli
ot SP805 driver would use the first clock > to derive the actual watchdog counter frequency. > > Since currently both are the very same clock, we can just double the > clock reference, and add the correct clock-names, to match the binding. > > Signed-off-by: Andre Przywara Acked-by: Florian Fainelli -- Florian

Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()

2020-08-28 Thread Florian Fainelli
On 8/27/20 1:08 PM, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 3/6] ARM: dts: NSP: Fix SP804 compatible node

2020-08-28 Thread Florian Fainelli
dts: NSP: Add SP804 Support to DT") > Tested-by: Florian Fainelli > Signed-off-by: Andre Przywara This looks fine, however there is a ccbtimer1 instance that you missed, can you resubmit with it included? With that: Acked-by: Florian Fainelli -- Florian

Re: [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe()

2020-08-28 Thread Florian Fainelli
On 8/28/20 8:37 AM, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Florian Fainelli -- Florian

Re: [PATCH] net: dsa: mt7530: fix advertising unsupported

2020-08-27 Thread Florian Fainelli
pport for port 5") Signed-off-by: Landen Chao Reviewed-by: Florian Fainelli -- Florian

[PATCH 5/5] arm64: dts: ns2: Fixed QSPI compatible string

2020-08-27 Thread Florian Fainelli
The string was incorrectly defined before from least to most specific, swap the compatible strings accordingly. Fixes: ff73917d38a6 ("ARM64: dts: Add QSPI Device Tree node for NS2") Signed-off-by: Florian Fainelli --- arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +- 1 file

[PATCH 2/5] ARM: dts: bcm: HR2: Fixed QSPI compatible string

2020-08-27 Thread Florian Fainelli
The string was incorrectly defined before from least to most specific, swap the compatible strings accordingly. Fixes: b9099ec754b5 ("ARM: dts: Add Broadcom Hurricane 2 DTS include file") Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-hr2.dtsi | 2 +- 1 file changed, 1

[PATCH 1/5] dt-bindings: spi: Fix spi-bcm-qspi compatible ordering

2020-08-27 Thread Florian Fainelli
dings") Signed-off-by: Florian Fainelli --- .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.txt b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi

[PATCH 4/5] ARM: dts: BCM5301X: Fixed QSPI compatible string

2020-08-27 Thread Florian Fainelli
The string was incorrectly defined before from least to most specific, swap the compatible strings accordingly. Fixes: 1c8f40650723 ("ARM: dts: BCM5301X: convert to iProc QSPI") Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm5301x.dtsi | 2 +- 1 file changed, 1 inser

[PATCH 0/5] qspi binding and DTS fixes

2020-08-27 Thread Florian Fainelli
exist, and these patches are a preliminary step towards that goal. Florian Fainelli (5): dt-bindings: spi: Fix spi-bcm-qspi compatible ordering ARM: dts: bcm: HR2: Fixed QSPI compatible string ARM: dts: NSP: Fixed QSPI compatible string ARM: dts: BCM5301X: Fixed QSPI compatible string arm64

[PATCH 3/5] ARM: dts: NSP: Fixed QSPI compatible string

2020-08-27 Thread Florian Fainelli
The string was incorrectly defined before from least to most specific, swap the compatible strings accordingly. Fixes: 329f98c1974e ("ARM: dts: NSP: Add QSPI nodes to NSPI and bcm958625k DTSes") Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- 1 file

Re: [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node

2020-08-26 Thread Florian Fainelli
On 8/26/20 11:59 AM, Florian Fainelli wrote: > On 8/26/20 11:53 AM, André Przywara wrote: >> On 26/08/2020 19:42, Florian Fainelli wrote: >> >> Hi, >> >>> On 8/26/20 11:38 AM, Andre Przywara wrote: >>>> The DT binding for SP804 requires to have an

Re: [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node

2020-08-26 Thread Florian Fainelli
On 8/26/20 11:53 AM, André Przywara wrote: > On 26/08/2020 19:42, Florian Fainelli wrote: > > Hi, > >> On 8/26/20 11:38 AM, Andre Przywara wrote: >>> The DT binding for SP804 requires to have an "arm,primecell" compatible >>> string. >>>

Re: [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node

2020-08-26 Thread Florian Fainelli
On 8/26/20 11:38 AM, Andre Przywara wrote: > The DT binding for SP804 requires to have an "arm,primecell" compatible > string. > Add this string so that the Linux primecell bus driver picks the device > up and activates the clock. > > Signed-off-by: Andre Przywara The commit subject should be:

Re: [PATCH 1/6] pwm: bcm2835: Simplify with dev_err_probe()

2020-08-26 Thread Florian Fainelli
On 8/26/20 7:47 AM, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Florian Fainelli -- Florian

Re: [PATCH v11 00/11] PCI: brcmstb: enable PCIe for STB chips

2020-08-25 Thread Florian Fainelli
Hi, On 8/24/2020 12:30 PM, Jim Quinlan wrote: Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. See the 'v1' notes below for more info. We are

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread Florian Fainelli
On 8/24/2020 6:21 PM, David Miller wrote: From: Florian Fainelli Date: Mon, 24 Aug 2020 17:43:37 -0700 On 8/24/2020 4:19 PM, David Miller wrote: From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 Hi David, Heiner, Andrew, Russell, This patch series aims at allowing myself

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread Florian Fainelli
On 8/24/2020 4:19 PM, David Miller wrote: From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 Hi David, Heiner, Andrew, Russell, This patch series aims at allowing myself to keep track of the Ethernet PHY and MDIO bus drivers that I authored or contributed to without being listed

Re: [PATCH v1] ata: ahci_brcm: Fix use of BCM7216 reset controller

2020-08-24 Thread Florian Fainelli
ret = reset_control_reset(priv->rcdev); > - else > - ret = reset_control_deassert(priv->rcdev); > + ret = reset_control_deassert(priv->rcdev); > if (ret) > return ret; We are missing an equivalent path in the brcm_ahci_resume() function, with that fixed: Acked-by: Florian Fainelli -- Florian

Re: [PATCH 00/12] Convert WAR defines to config options

2020-08-24 Thread Florian Fainelli
On 8/24/20 10:28 AM, Thomas Bogendoerfer wrote: > On Mon, Aug 24, 2020 at 10:10:07AM -0700, Florian Fainelli wrote: >> On 8/24/20 9:32 AM, Thomas Bogendoerfer wrote: >>> This patches convert workaround (WAR) defines into config options and >>> gets rid of mach-*/w

[PATCH stable 4.9 v3 0/2] arm64: entry: Place an SB sequence following an ERET instruction

2020-08-24 Thread Florian Fainelli
Changes in v3: - included missing preliminary patch to define the SB barrier instruction, see patch change log for details on how it was back ported into v4.9 Changes in v2: - added missing hunk in hyp/entry.S per Will's feedback Will Deacon (2): arm64: Add support for SB barrier and patch

<    3   4   5   6   7   8   9   10   11   12   >