Re: [PATCH] tty: serial: msm: fix checkpatch warnings

2014-08-04 Thread Frank Rowand
On 8/4/2014 7:20 AM, Kiran Padwal wrote: This patch fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for any arm of this statement WARNING: Missing a blank line after declarations WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then

[request for help] tty: serial: kgdb: fix msm_serial for kgdb

2014-08-04 Thread Frank Rowand
Stephen, I made some changes to drivers/tty/serial/msm_serial.c to allow kgdb to work with the dragon board (which has a qcom,msm-uartdm-v1.4 serial port). I will reply to this email with the patches. With these fixes, kgdb properly communicates with the dragon board, but following the continue

[test patch 1/4] fix msm_serial for kgdb

2014-08-04 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com f7e54d7ad743 added support for poll_{get,put}_char() Additional fixes to cope with single character mode on RX FIFO for qcom,msm-uartdm-v1.4. With these fixes, kgdb properly communicates with the dragon board, but following the continue command

[test patch 2/4] add poll_post_exception framework

2014-08-04 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Add framework to allow serial driver to fixup state after operating in polled mode, before returning to interrupt mode. Not-signed-off-by-yet: Frank Rowand frank.row...@sonymobile.com --- drivers/tty/serial/kgdboc.c |3 +++ drivers/tty

[test patch 3/4] use poll_post_exception in msm_serial

2014-08-04 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com ** I need help with this patch - it does not fix the issue. ** Use framework to allow msm_serial driver to fixup state after operating

[test patch 4/4] debug hackery to trace msm_serial receive interrupts

2014-08-04 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Not intended to be applied to mainline. This is debug code that captures a trace of msm_serial reads by handle_rx_dm(). The trace is printed to the console when the sys_sync() system call is invoked (that is, when the sync user space command

Re: [request for help] tty: serial: kgdb: fix msm_serial for kgdb

2014-08-04 Thread Frank Rowand
On 8/4/2014 6:33 PM, Stephen Boyd wrote: On 08/04/14 17:59, Frank Rowand wrote: Stephen, I made some changes to drivers/tty/serial/msm_serial.c to allow kgdb to work with the dragon board (which has a qcom,msm-uartdm-v1.4 serial port). I will reply to this email with the patches

Re: [request for help] tty: serial: kgdb: fix msm_serial for kgdb

2014-08-05 Thread Frank Rowand
rid of the single character mode! Works for me on the dragonboard (1.4 hardware). Reviewed-by: Frank Rowand frank.row...@sonymobile.com Tested-by: Frank Rowand frank.row...@sonymobile.com Thanks for figuring this out. I'll send a patch to handle sysrq after I see this patch upstream. -Frank

[PATCH to be tested] serial: msm_serial: add missing sysrq handling

2014-08-06 Thread Frank Rowand
Stephen, Can you test this patch on v 1.3 hardware? It works on my v 1.4. If you use kdmx2, the way to send a break is '~B'. The previous key pressed must be enter for the '~' escape to be recognized. Thanks! -Frank From: Frank Rowand frank.row...@sonymobile.com Add missing sysrq

Re: [PATCH v5] init: Disable defaults if init= fails

2014-10-14 Thread Frank Rowand
On 10/14/2014 2:21 PM, Andy Lutomirski wrote: On Tue, Oct 14, 2014 at 2:00 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 1 Oct 2014 11:13:14 -0700 Andy Lutomirski l...@amacapital.net wrote: On Wed, Oct 1, 2014 at 11:05 AM, j...@joshtriplett.org wrote: On Tue, Sep 30, 2014 at

Re: [PATCH v5] init: Disable defaults if init= fails

2014-10-15 Thread Frank Rowand
On 10/14/2014 10:56 PM, Andy Lutomirski wrote: On Tue, Oct 14, 2014 at 10:46 PM, Frank Rowand frowand.l...@gmail.com wrote: On 10/14/2014 2:21 PM, Andy Lutomirski wrote: On Tue, Oct 14, 2014 at 2:00 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 1 Oct 2014 11:13:14 -0700 Andy

Re: [PATCH to be tested] serial: msm_serial: add missing sysrq handling

2014-10-03 Thread Frank Rowand
On 10/3/2014 2:34 PM, Stephen Boyd wrote: Hi Frank, On 08/13/14 19:42, Frank Rowand wrote: On 8/13/2014 7:33 PM, Frank Rowand wrote: On 8/12/2014 5:23 PM, Stephen Boyd wrote: On 08/06/14 17:16, Frank Rowand wrote: snip The patches you sent are a little hard to read since they modify

Re: [PATCH v5] init: Disable defaults if init= fails

2014-09-30 Thread Frank Rowand
The earliest mention I find of this on lkml is v4. Was there earlier discussion of this elsewhere? (Just so I have a clue as to the full context and don't repeat previous discussion.) The mention of names in the change logs tells me I should be able to find the discussion somewhere. On

Re: [PATCH v5] init: Disable defaults if init= fails

2014-09-30 Thread Frank Rowand
On 9/30/2014 5:58 PM, Rob Landley wrote: On 09/30/14 19:41, Frank Rowand wrote: The earliest mention I find of this on lkml is v4. Was there earlier discussion of this elsewhere? (Just so I have a clue as to the full context and don't repeat previous discussion.) The mention of names

Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-10-31 Thread Frank Rowand
On 10/31/2014 2:43 AM, Daniel Thompson wrote: On 31/10/14 06:41, Stephen Boyd wrote: On 10/30, Daniel Thompson wrote: On 29/10/14 18:14, Stephen Boyd wrote: + r_count = min_t(int, count, sizeof(buf)); + + for (i = 0; i r_count; i++) { + char flag =

Re: [PATCH] ARM: dts: Add initial DTS file for Sony Xperia Z1 phone

2014-09-19 Thread Frank Rowand
On 9/16/2014 4:14 PM, Tim Bird wrote: On 09/16/2014 04:08 PM, Kumar Gala wrote: On Sep 16, 2014, at 4:03 PM, Tim Bird tim.b...@sonymobile.com wrote: This DTS has initial support for just a serial console, for the Sony Xperia Z1 phone. This phone uses a QualComm 8074 processor.

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-10 Thread Frank Rowand
On 11/10/2014 11:42 AM, Stephen Boyd wrote: On 11/10/2014 10:54 AM, Kevin Hilman wrote: On Wed, Oct 22, 2014 at 5:33 PM, Stephen Boyd sb...@codeaurora.org wrote: We rely on probe order of this driver to determine the line number for the uart port. This makes it impossible to know the line

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-10 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com v2, changes from v1: - The patch this documents was updated to make the serialN alias optional instead of required. Update devicetree binding for msm_serial to reflect msm_serial_probe() getting line id from the serial alias. Signed-off

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-10 Thread Frank Rowand
On 11/10/2014 6:07 PM, Stephen Boyd wrote: On 11/10/2014 05:56 PM, Frank Rowand wrote: On 11/10/2014 11:42 AM, Stephen Boyd wrote: diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 09364dd8cf3a..d1bc6b6cbc70 100644 --- a/drivers/tty/serial/msm_serial.c

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-12 Thread Frank Rowand
On 11/10/2014 7:20 PM, Frank Rowand wrote: On 11/10/2014 6:07 PM, Stephen Boyd wrote: On 11/10/2014 05:56 PM, Frank Rowand wrote: On 11/10/2014 11:42 AM, Stephen Boyd wrote: diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 09364dd8cf3a..d1bc6b6cbc70

Re: [RFC] Add of_path property for all devices with a node

2014-11-12 Thread Frank Rowand
On 11/6/2014 10:33 PM, Benjamin Herrenschmidt wrote: Hey folks ! This is not (yet) a formal patch submission but... So I've been annoyed lately with having a bunch of devices such as i2c eeproms (for use by VPDs, server world !) and other bits and pieces that I want to be able to identify

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-13 Thread Frank Rowand
On 11/13/2014 11:31 AM, Stephen Boyd wrote: On 11/12/2014 10:14 AM, Frank Rowand wrote: On 11/10/2014 7:20 PM, Frank Rowand wrote: On 11/10/2014 6:07 PM, Stephen Boyd wrote: On 11/10/2014 05:56 PM, Frank Rowand wrote: On 11/10/2014 11:42 AM, Stephen Boyd wrote: diff --git a/drivers/tty

Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-11-03 Thread Frank Rowand
On 11/3/2014 2:05 AM, Daniel Thompson wrote: On 31/10/14 18:08, Frank Rowand wrote: On 10/31/2014 2:43 AM, Daniel Thompson wrote: On 31/10/14 06:41, Stephen Boyd wrote: On 10/30, Daniel Thompson wrote: On 29/10/14 18:14, Stephen Boyd wrote: +r_count = min_t(int, count, sizeof

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-06 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Update devicetree binding for msm_serial to reflect msm_serial_probe() getting line id from the serial alias. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt | 15

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-06 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Update msm8974 dtsi for msm_serial to reflect msm_serial_probe() getting line id from the serial alias. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- arch/arm/boot/dts/qcom-msm8974.dtsi |6 +- 1 file changed, 5 insertions

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-06 Thread Frank Rowand
On 11/6/2014 10:40 PM, Frank Rowand wrote: From: Frank Rowand frank.row...@sonymobile.com Update msm8974 dtsi for msm_serial to reflect msm_serial_probe() getting line id from the serial alias. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- arch/arm/boot/dts/qcom-msm8974

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-07 Thread Frank Rowand
On 11/7/2014 1:47 AM, Arnd Bergmann wrote: On Thursday 06 November 2014 22:42:47 Frank Rowand wrote: This same change is also needed in: qcom-ipq8064.dtsi qcom-msm8960.dtsi qcom-apq8084.dtsi qcom-apq8064.dtsi qcom-msm8660.dtsi but I did not want to just blindly apply those

[PATCH] tty: serial: msm_serial: document DT alias

2014-11-14 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Update devicetree binding for msm_serial to reflect msm_serial_probe() getting line id (port number) from the serialN alias. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt

Re: [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path

2014-12-02 Thread Frank Rowand
On 11/27/2014 9:56 AM, Leif Lindholm wrote: Add a global binding for the chosen node. Include a description of the stdout-path, and an explicit statement on its extra options in the context of a UART console. Opening description stolen from www.devicetree.org, and part of the remaining text

Re: [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path

2014-12-03 Thread Frank Rowand
On 12/3/2014 7:12 AM, Grant Likely wrote: On Wed, Dec 3, 2014 at 2:24 AM, Frank Rowand frowand.l...@gmail.com wrote: On 11/27/2014 9:56 AM, Leif Lindholm wrote: Add a global binding for the chosen node. Include a description of the stdout-path, and an explicit statement on its extra options

Re: [PATCH RFC] Docs: Modernize SubmittingPatches

2014-12-15 Thread Frank Rowand
On 12/15/2014 7:52 AM, Jonathan Corbet wrote: The SubmittingPatches file still shows a lot of its roots from the era when we all sent stuff straight to Linus and hoped for the best. I've gone in and thrashed it up to reflect an age where few of us type our own diff commands anymore. Also

Re: [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path

2014-12-03 Thread Frank Rowand
On 12/3/2014 1:45 PM, Grant Likely wrote: On Wed, Dec 3, 2014 at 7:46 PM, Frank Rowand frowand.l...@gmail.com wrote: On 12/3/2014 7:12 AM, Grant Likely wrote: On Wed, Dec 3, 2014 at 2:24 AM, Frank Rowand frowand.l...@gmail.com wrote: On 11/27/2014 9:56 AM, Leif Lindholm wrote: Add a global

[PATCH] checkpatch: include text files in SPACE_BEFORE_TAB test

2014-12-05 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com git-am whined about a patch that I submitted for the Documentation subtree, (https://lkml.org/lkml/2014/11/24/636) but checkpatch does not. Make checkpatch just as whiney. This patch moves the SPACE_BEFORE_TAB test before the check that excludes

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-19 Thread Frank Rowand
On 2/19/2015 6:41 AM, Pantelis Antoniou wrote: Hi Frank, On Feb 19, 2015, at 04:08 , Frank Rowand frowand.l...@gmail.com wrote: On 2/18/2015 6:59 AM, Pantelis Antoniou wrote: Implement a method of applying DT quirks early in the boot sequence. A DT quirk is a subtree of the boot DT

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-19 Thread Frank Rowand
On 2/19/2015 9:00 AM, Pantelis Antoniou wrote: Hi Frank, On Feb 19, 2015, at 18:48 , Frank Rowand frowand.l...@gmail.com wrote: On 2/19/2015 6:29 AM, Pantelis Antoniou wrote: Hi Mark, On Feb 18, 2015, at 19:31 , Mark Rutland mark.rutl...@arm.com wrote: +While this may in theory work

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-19 Thread Frank Rowand
On 2/19/2015 8:40 AM, Frank Rowand wrote: On 2/19/2015 6:41 AM, Pantelis Antoniou wrote: Hi Frank, On Feb 19, 2015, at 04:08 , Frank Rowand frowand.l...@gmail.com wrote: On 2/18/2015 6:59 AM, Pantelis Antoniou wrote: Implement a method of applying DT quirks early in the boot sequence

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-19 Thread Frank Rowand
On 2/19/2015 6:29 AM, Pantelis Antoniou wrote: Hi Mark, On Feb 18, 2015, at 19:31 , Mark Rutland mark.rutl...@arm.com wrote: +While this may in theory work, in practice it is very cumbersome +for the following reasons: + +1. The act of selecting a different boot device tree blob requires

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-18 Thread Frank Rowand
On 2/18/2015 6:59 AM, Pantelis Antoniou wrote: Implement a method of applying DT quirks early in the boot sequence. A DT quirk is a subtree of the boot DT that can be applied to a target in the base DT resulting in a modification of the live tree. The format of the quirk nodes is that of a

[patch 7/7] dt: dtb version: report dtb info

2015-03-18 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Report the /chosen/dtb-info properties on boot. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- The beginning of the context for hunk 2 includes a line from 2fa645cb2703d9b3786d850db815414dfeefa51d, which is in 4.0-rc4. The author

[patch 4/7] dt: dtb version: kernel Makefile

2015-03-18 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Capture the initial value of .version_dtb so that when multiple .dtb files are created in a single make the make scripts will be able to increment .version_dtb only once instead of for each .dtb. Signed-off-by: Frank Rowand frank.row

[patch 5/7] dt: dtb version: kbuild scripts

2015-03-18 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com After applying this patch, need to add execute permission to the new file scripts/version_dtb_increment_once Modify the dtb compile rules to generate dtb version header files. Create script to increment .version_dtb just once per make of one

[patch 3/7] dt: dtb version: arm dts Makefile

2015-03-18 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Remove generated files from the dependencies of .dtb files, where the generated files are created as a result of making a .dtb. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- arch/arm/boot/dts/Makefile | 10

[patch 6/7] dt: dtb version: dtsi files

2015-03-18 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Create a .dtsi file to contain the /chosen/dtb-info node and populate the properties in that node. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- arch/arm/boot/dts/skeleton.dtsi |2 include/dt-bindings/version.dtsi

[patch 0/7] dt: dtb version: add version info to dtb

2015-03-18 Thread Frank Rowand
Rob, Can this be added to the next trees to get some test exposure before submitting to Linus? There is currently no way to tie a device tree blob (DTB) back to the source and environment used to create it. Add this information, including a DTB version number, which is somewhat analogous to the

[patch 1/7] dt: dtb version: consolidate documentation of chosen node bindings

2015-03-18 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Documentation of bindings in node /chosen are scattered in several bindings files. If not already in Documentation/devicetree/bindings/chosen.txt, add a pointer in that file to where the property and node bindings are described. This is a clean up

[patch 2/7] dt: dtb version: document chosen/dtb-info node binding

2015-03-18 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Add /chosen/dtb-node binding. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- Documentation/devicetree/bindings/chosen.txt | 37 +++ Index: b/Documentation/devicetree/bindings/chosen.txt

Re: [patch 0/7] dt: dtb version: add version info to dtb

2015-03-19 Thread Frank Rowand
On 3/19/2015 1:12 AM, Gregory CLEMENT wrote: Hi, On 19/03/2015 04:29, Frank Rowand wrote: Rob, Can this be added to the next trees to get some test exposure before submitting to Linus? There is currently no way to tie a device tree blob (DTB) back to the source and environment used

Re: [patch 2/7] dt: dtb version: document chosen/dtb-info node binding

2015-03-19 Thread Frank Rowand
On 3/18/2015 8:33 PM, Frank Rowand wrote: From: Frank Rowand frank.row...@sonymobile.com Add /chosen/dtb-node binding. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- Documentation/devicetree/bindings/chosen.txt | 37 +++ Index: b/Documentation/devicetree/bindings

Re: [patch 2/7] dt: dtb version: document chosen/dtb-info node binding

2015-03-19 Thread Frank Rowand
On 3/19/2015 6:49 AM, Mark Rutland wrote: On Thu, Mar 19, 2015 at 03:33:22AM +, Frank Rowand wrote: From: Frank Rowand frank.row...@sonymobile.com Add /chosen/dtb-node binding. Why? It doesn't matter what the cover says, the commit message should have a rationale. Who needs

Re: [patch 2/7] dt: dtb version: document chosen/dtb-info node binding

2015-03-19 Thread Frank Rowand
On 3/19/2015 11:41 AM, Russell King - ARM Linux wrote: On Thu, Mar 19, 2015 at 08:23:29AM -0500, Rob Herring wrote: On Wed, Mar 18, 2015 at 10:33 PM, Frank Rowand frowand.l...@gmail.com wrote: +version + The version of the DTB. This is analagous to the linux kernel version

Re: [patch 2/7] dt: dtb version: document chosen/dtb-info node binding

2015-03-19 Thread Frank Rowand
On 3/19/2015 12:12 PM, Mark Rutland wrote: I'm not sure I see the point in adding a property which is not well-defined and not guarnateed to be in any way stable. This binding is kind of an odd ball to me. It is clearly _not_ describing hardware, which is really the central point of the dtb.

Re: [patch 2/7] dt: dtb version: document chosen/dtb-info node binding

2015-03-19 Thread Frank Rowand
On 3/19/2015 12:32 PM, Russell King - ARM Linux wrote: On Thu, Mar 19, 2015 at 12:01:42PM -0700, Frank Rowand wrote: On 3/19/2015 11:41 AM, Russell King - ARM Linux wrote: What??? Why would we ever accept code that tested the dtb version instead of the compatible strings and properties

[Patch v3 3/3] dt: OF_UNITTEST make dependency broken, fix unittest.c after move

2015-03-12 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix an of_unittest.c include path to account for the move of unittest.c into unittest-data/. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- drivers/of/unittest-data/unittest.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[Patch v3 2/3] dt: OF_UNITTEST make dependency broken, move unittest.c

2015-03-12 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Move of_unittest.c into unittest-data/ This is based on v4.0-rc3. All checkpatch errors are ignored, as this is just a file move. At least two of the checkpatch errors appear to be real bugs, to be addressed in a future patch. Signed-off

[Patch v3 1/3] dt: OF_UNITTEST make dependency broken, framework fixes

2015-03-12 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com This 3 patch series is not bisectable. If CONFIG_OF_UNITTEST=y then the kernel will not build with just patch 1 or just patches 1 and 2 applied. If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to be incremented, even

Re: [Patch v3 1/3] dt: OF_UNITTEST make dependency broken, framework fixes

2015-03-13 Thread Frank Rowand
On 3/13/2015 6:13 AM, Rob Herring wrote: On Thu, Mar 12, 2015 at 8:15 AM, Frank Rowand frowand.l...@gmail.com wrote: From: Frank Rowand frank.row...@sonymobile.com This 3 patch series is not bisectable. If CONFIG_OF_UNITTEST=y then the kernel will not build with just patch 1 or just

[Patch] dt: OF_UNITTEST make dependency broken

2015-03-13 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to be incremented, even if there are not source changes. This is caused by a lack of dependency tracking and checking for drivers/of/unittest-data/testcases.dtb.o. Signed

[Patch 0/5] dt: unittest: fix breakage and warnings

2015-03-13 Thread Frank Rowand
Running checkpatch on early versions of my patchset to fix the devicetree make dependency issues exposed a large number of warnings, including some that are actual bugs. http://lkml.iu.edu/hypermail/linux/kernel/1503.1/03335.html These patches fix those bugs, and another bug exposed by fixing

[Patch 5/5] dt: unittest: breadcrumbs to reduce pain of future maintainers

2015-03-14 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix warnings pointed out by checkpatch. Checkpatch warns: externs should be avoided in .c files Reducing pain for future maintainers - adding a comment so that anyone trying to find where the extern data is created will be able to find it. (grep

[Patch 4/5] dt: unittest: reduce checkpatch noise - line after declarations

2015-03-14 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix warnings pointed out by checkpatch. No bug fixes, but reduce the number of checkpatch warnings so that future problems will stand out better. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- drivers/of/unittest.c |5 + 1

[Patch 3/5] dt: unittest: add const where needed

2015-03-14 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix warnings pointed out by checkpatch. No bugs fixed, but the test code should be a good example of how to use the devicetree API. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- drivers/of/unittest.c |8 1 file changed

[Patch 1/5] dt: unittest: early return from test skips tests

2015-03-14 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix bugs pointed out by checkpatch. Mis-coding of two if statements caused early return from function. Number of tests completed increased from 102 to 107. Number of tests failed increased from 0 to 2. Signed-off-by: Frank Rowand frank.row

[Patch 2/5] dt: unittest: typo in error string

2015-03-14 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix bug pointed out by checkpatch. Splitting string incorrectly removed a space between two words. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- drivers/of/unittest.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[Patch v2 2/3] dt: OF_UNITTEST make dependency broken, move unittest.c

2015-03-12 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Move of_unittest.c into unittest-data/ This is based on v4.0-rc3. All checkpatch errors are ignored, as this is just a file move. At least two of the checkpatch errors appear to be real bugs, to be addressed in a future patch. Signed-off

[Patch v2 3/3] dt: OF_UNITTEST make dependency broken, fix unittest.c after move

2015-03-12 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix an of_unittest.c include path to account for the move of unittest.c into unittest-data/. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- drivers/of/unittest-data/unittest.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[Patch 1/3] dt: OF_UNITTEST make dependency broken, framework fixes

2015-03-11 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com This 3 patch series is not bisectable. If CONFIG_OF_UNITTEST=y then the kernel will not build with just patch 1 or just patches 1 and 2 applied. If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to be incremented, even

[Patch 2/3] dt: OF_UNITTEST make dependency broken, move unittest.c

2015-03-11 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Move of_unittest.c into unittest-data/ This is based on v4.0-rc3. All checkpatch errors are ignored, as this is just a file move. At least two of the checkpatch errors appear to be real bugs, to be addressed in a future patch. Signed-off

[Patch 3/3] dt: OF_UNITTEST make dependency broken, fix unittest.c after move

2015-03-11 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Fix an of_unittest.c include path to account for the move of unittest.c into unittest-data/. Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- drivers/of/unittest-data/unittest.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[Patch v2 1/3] dt: OF_UNITTEST make dependency broken, framework fixes

2015-03-12 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com This 3 patch series is not bisectable. If CONFIG_OF_UNITTEST=y then the kernel will not build with just patch 1 or just patches 1 and 2 applied. If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to be incremented, even

Re: [patch 2/7] dt: dtb version: document chosen/dtb-info node binding

2015-03-19 Thread Frank Rowand
On 3/19/2015 6:23 AM, Rob Herring wrote: On Wed, Mar 18, 2015 at 10:33 PM, Frank Rowand frowand.l...@gmail.com wrote: From: Frank Rowand frank.row...@sonymobile.com Add /chosen/dtb-node binding. Why? Please write better commit messages. Will update. Signed-off-by: Frank Rowand

Re: [PATCH/RFC] kbuild: Create a rule for building device tree overlay objects

2015-05-15 Thread Frank Rowand
On 5/12/2015 7:33 AM, Pantelis Antoniou wrote: Hi Geert, On May 12, 2015, at 14:56 , Geert Uytterhoeven geert+rene...@glider.be wrote: This allows to handle device tree overlays like plain device trees. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Questions: - Do we

Re: [PATCH] regulator: Add SPMI regulator driver

2015-05-15 Thread Frank Rowand
On 5/12/2015 2:39 PM, Stephen Boyd wrote: Add an SPMI regulator driver for Qualcomm's PM8941 and PM8916 PMICs. This driver is based largely on code from codeaurora.org[1]. [1] https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/regulator/qpnp-regulator.c?h=msm-3.10 Cc:

Re: [PATCH/RFC] kbuild: Create a rule for building device tree overlay objects

2015-05-15 Thread Frank Rowand
On 5/15/2015 5:47 PM, Frank Rowand wrote: On 5/12/2015 7:33 AM, Pantelis Antoniou wrote: Hi Geert, On May 12, 2015, at 14:56 , Geert Uytterhoeven geert+rene...@glider.be wrote: This allows to handle device tree overlays like plain device trees. Signed-off-by: Geert Uytterhoeven geert

Re: [PATCH] of/flattree: print memory scan node results in CPU endian

2015-04-08 Thread Frank Rowand
On 4/7/2015 11:44 PM, Florian Fainelli wrote: Commit 51975db0b7333 (of/flattree: merge early_init_dt_scan_memory() common code) consolidated some code from PowerPC (typically big-endian), and ended-up adding a pr_debug() printing reg properties in big-endian (DT native) format, not CPU endian.

Re: Device Tree at Plumbers, early registration ends Friday

2015-06-01 Thread Frank Rowand
On 5/30/2015 2:36 PM, Frank Rowand wrote: The Linux Plumbers Device Tree track was accepted by the Plumbers conference. The above is a pasto, ycch. The track is, of course: Device Tree Tools, Validation, and Troubleshooting The DEADLINE for EARLY BIRD REGISTRATION at a reduced price

Device Tree at Plumbers, looking for topics and session leaders

2015-05-30 Thread Frank Rowand
/ Plumbers will be co-located with LinuxCon North America in Seattle (Plumbers is Aug 19-21, Linuxcon is Aug 17-19). Hope to see many of you in Seattle. Regards, Frank Rowand -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Device Tree at Plumbers, early registration ends Friday

2015-05-30 Thread Frank Rowand
soon now. Preliminary results are that I will be presenting a talk on DT debugging in that track. LinuxCon North America info is at: http://events.linuxfoundation.org/events/linuxcon-north-america Hope to see many of you in Seattle. Regards, Frank Rowand -- To unsubscribe from this list

Re: [PATCH v5] dtb: Create a common home for cross-architecture dtsi files.

2015-08-03 Thread Frank Rowand
-v2m-rs1.dtsi (100%) Reviewed-by: Frank Rowand frank.row...@sonymobile.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [GIT PULL] On-demand device probing

2015-10-22 Thread Frank Rowand
On 10/22/2015 7:44 AM, Greg Kroah-Hartman wrote: > > > On Thu, Oct 22, 2015 at 11:05:11AM +0200, Tomeu Vizoso wrote: >> But that's moot currently because Greg believes that the time spent >> probing devices at boot time could be reduced enough so that the order >> in

Re: [GIT PULL] On-demand device probing

2015-10-21 Thread Frank Rowand
On 10/19/2015 5:34 AM, Tomeu Vizoso wrote: > On 18 October 2015 at 21:53, Mark Brown wrote: >> On Sun, Oct 18, 2015 at 12:37:57PM -0700, Greg Kroah-Hartman wrote: >>> On Sun, Oct 18, 2015 at 08:29:31PM +0100, Mark Brown wrote: On Fri, Oct 16, 2015 at 11:57:50PM -0700,

Re: Alternative approach to solve the deferred probe

2015-10-21 Thread Frank Rowand
On 10/21/2015 1:18 AM, Russell King - ARM Linux wrote: > On Tue, Oct 20, 2015 at 08:58:19PM -0700, Frank Rowand wrote: >> On 10/20/2015 8:46 AM, Russell King - ARM Linux wrote: < snip > >>> + >>> static bool dri

Re: Alternative approach to solve the deferred probe

2015-10-21 Thread Frank Rowand
On 10/21/2015 9:55 AM, Grygorii Strashko wrote: > On 10/21/2015 06:36 PM, Frank Rowand wrote: >> On 10/21/2015 1:18 AM, Russell King - ARM Linux wrote: >>> On Tue, Oct 20, 2015 at 08:58:19PM -0700, Frank Rowand wrote: >>>> On 10/20/2015 8:46 AM, Russell King -

Re: [GIT PULL] On-demand device probing

2015-10-21 Thread Frank Rowand
On 10/21/2015 9:27 AM, Mark Brown wrote: > On Wed, Oct 21, 2015 at 08:59:51AM -0700, Frank Rowand wrote: >> On 10/19/2015 5:34 AM, Tomeu Vizoso wrote: > >>> To be clear, I was saying that this series should NOT affect total >>> boot times much. > >> I

Re: [GIT PULL] On-demand device probing

2015-10-21 Thread Frank Rowand
On 10/21/2015 2:12 PM, Rob Herring wrote: > On Wed, Oct 21, 2015 at 1:18 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 10/21/2015 9:27 AM, Mark Brown wrote: >>> On Wed, Oct 21, 2015 at 08:59:51AM -0700, Frank Rowand wrote: >>>> On 10

Re: Alternative approach to solve the deferred probe

2015-10-21 Thread Frank Rowand
On 10/21/2015 1:35 PM, Russell King - ARM Linux wrote: > On Wed, Oct 21, 2015 at 08:36:23AM -0700, Frank Rowand wrote: >> On 10/21/2015 1:18 AM, Russell King - ARM Linux wrote: >>> On Tue, Oct 20, 2015 at 08:58:19PM -0700, Frank Rowand wrote: >>>> On 10/20/2015 8:4

regulator: build warning in regulator_lock_supply()

2015-11-09 Thread Frank Rowand
In the current Linus tree, new build warning. When CONFIG_DEBUG_LOCK_ALLOC is not enabled, drivers/regulator/core.c: In function 'regulator_lock_supply': drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable] Introduced by commit 9f01cd4a915e1 ("regulator:

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-11-11 Thread Frank Rowand
Adding devicetree list. Thread starts at http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354459.html On 11/5/2015 8:17 AM, Tony Lindgren wrote: > * Pali Rohár [151105 03:41]: >> On Tuesday 13 October 2015 16:37:46 Pali Rohár wrote: >>> On Monday 12 October

Re: [PATCH] Documentation: dt: Add bindings for Secure-only devices

2015-11-03 Thread Frank Rowand
On 10/30/2015 1:07 PM, Peter Maydell wrote: > On 30 October 2015 at 18:28, Rob Herring wrote: >> On Thu, Oct 29, 2015 at 9:01 AM, Peter Maydell >> wrote: >>> +Valid Secure world properties: >>> + >>> +- secure-status : specifies whether the device

Re: Alternative approach to solve the deferred probe

2015-10-20 Thread Frank Rowand
On 10/20/2015 8:46 AM, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 06:21:40PM +0200, Geert Uytterhoeven wrote: >> Hi Russell, >> >> On Mon, Oct 19, 2015 at 5:35 PM, Russell King - ARM Linux >> wrote: > What you can do is print those devices which have

Re: [PATCH v7 19/20] driver core: Allow deferring probes until late init

2015-10-14 Thread Frank Rowand
On 9/29/2015 2:10 AM, Tomeu Vizoso wrote: > Add a field to struct device that instructs the device-driver core to > defer the probe of this device until the late_initcall level. > > By letting all built-in drivers to register before starting to probe, we > can avoid any deferred probes by probing

Re: [PATCH v7 20/20] of/platform: Defer probes of registered devices

2015-10-14 Thread Frank Rowand
On 9/29/2015 2:10 AM, Tomeu Vizoso wrote: > Instead of trying to match and probe platform and AMBA devices right > after each is registered, delay their probes until device_initcall_sync.

Re: [PATCH] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

2015-09-06 Thread Frank Rowand
On 9/6/2015 1:46 PM, Rob Herring wrote: > On Fri, Sep 4, 2015 at 8:14 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 9/4/2015 12:12 PM, David Daney wrote: >>> From: David Daney <david.da...@cavium.com> >>> >>> It is perfectly legitimate f

Re: [PATCH] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

2015-09-06 Thread Frank Rowand
On 9/6/2015 7:16 PM, Frank Rowand wrote: > On 9/6/2015 1:46 PM, Rob Herring wrote: >> On Fri, Sep 4, 2015 at 8:14 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >>> On 9/4/2015 12:12 PM, David Daney wrote: >>>> From: David Daney <david.da...@cavium.co

Re: [PATCH] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

2015-09-07 Thread Frank Rowand
On 9/6/2015 8:50 PM, Frank Rowand wrote: > On 9/6/2015 7:16 PM, Frank Rowand wrote: >> On 9/6/2015 1:46 PM, Rob Herring wrote: >>> On Fri, Sep 4, 2015 at 8:14 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >>>> On 9/4/2015 12:12 PM, David Daney wrot

Re: [PATCH] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

2015-09-04 Thread Frank Rowand
On 9/4/2015 6:40 PM, David Daney wrote: > On 09/04/2015 06:14 PM, Frank Rowand wrote: >> On 9/4/2015 12:12 PM, David Daney wrote: >>> From: David Daney <david.da...@cavium.com> >>> >>> It is perfectly legitimate for a PCI device to have an >>

Re: [PATCH] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

2015-09-04 Thread Frank Rowand
On 9/4/2015 12:12 PM, David Daney wrote: > From: David Daney > > It is perfectly legitimate for a PCI device to have an > PCI_INTERRUPT_PIN value of zero. This happens if the device doesn't > use interrupts, or on PCIe devices, where only MSI/MSI-X are > supported. > >

Re: [PATCH v4 1/9] drivers/of: Introduce of_node_alloc

2015-09-28 Thread Frank Rowand
On 9/28/2015 9:42 AM, Marc Zyngier wrote: > We want to be able to generate "fake" device nodes that can be > used as an identifier for irq domains. For that, we reuse the > dynamic DT layer in order to generate DT nodes in a detached state > (so that it doesn't interfere with the rest of the

Re: [PATCH v2] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

2015-09-09 Thread Frank Rowand
exit. > > Signed-off-by: David Daney <david.da...@cavium.com> > --- > Changes in v2: Move the print function in to of_irq_parse_pci() at a > common error exit point (as suggested by Frank Rowand). > > > drivers/of/of_pci_irq.c | 17 ++---

Re: [PATCH v2] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

2015-09-09 Thread Frank Rowand
_PIN == 0 is not the > cause for an early exit. > > Signed-off-by: David Daney <david.da...@cavium.com> > --- > Changes in v2: Move the print function in to of_irq_parse_pci() at a > common error exit point (as suggested by Frank Rowand). > > > drivers/of/of_pc

Re: [PATCH v6 21/22] driver core: Start processing deferred probes earlier

2015-10-05 Thread Frank Rowand
On 9/21/2015 7:03 AM, Tomeu Vizoso wrote: > Some initcalls in the late level assume that some devices will have > already probed without explicitly checking for that. > > After the recent move to defer most device probes when they are > registered, pressure increased in the late initcall level. >

<    1   2   3   4   5   6   7   8   9   10   >