Re: [PATCH 00/10] Introduce Juniper PTXPMB CPLD driver

2016-10-07 Thread Frank Rowand
On 10/07/16 08:17, Pantelis Antoniou wrote: > Add Juniper's PTXPMB FPGA CPLD driver. Those FPGAs > are present in Juniper's PTX series of routers. > > The MFD driver provices watchdog/i2c/gpio/mtd devices. > > There are full device tree binding documents for the > master mfd driver and for all

Re: [PATCH] sdhci: Add quirk and device tree parameter to force SD test mode

2016-08-22 Thread Frank Rowand
On 08/22/16 15:55, Zach Brown wrote: > From: Jaeden Amero > > On some devices, CD is broken so that we must force the SDHCI into test > mode and set CD, so that it always detects an SD card as present. > > In order to get a device with broken CD working, we had previously >

Re: [RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable

2016-10-25 Thread Frank Rowand
On 10/25/16 13:58, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@am.sony.com> > > drivers/of/resolve.c is a bit difficult to read. Clean it up so > that review of future overlay related patches will be easier. < snip > Hi Pantelis, Can you test t

Re: [RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-27 Thread Frank Rowand
On 10/27/16 05:18, Rob Herring wrote: > On Tue, Oct 25, 2016 at 3:58 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@am.sony.com> >> >> Remove comments that state the obvious, to reduce clutter > > I'm probably not the best revie

Re: [RFC PATCH 02/13] of: Remove excessive printks to reduce clutter

2016-10-27 Thread Frank Rowand
On 10/27/16 05:21, Rob Herring wrote: > On Tue, Oct 25, 2016 at 3:58 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@am.sony.com> > > Maybe some should be debug? > >> Signed-off-by: Frank Rowand <frank.row...@am.sony.com

Re: [RFC PATCH 06/13] of: Remove prefix "__of_" and prefix "__" from local function names

2016-10-27 Thread Frank Rowand
On 10/27/16 09:58, Rob Herring wrote: > On Thu, Oct 27, 2016 at 11:35 AM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 10/27/16 05:47, Rob Herring wrote: >>> On Tue, Oct 25, 2016 at 3:58 PM, <frowand.l...@gmail.com> wrote: >>>> From: Frank Rowand &

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
On 11/21/16 08:20, Sudeep Holla wrote: > > > On 18/11/16 20:22, Frank Rowand wrote: >> On 11/18/16 02:41, Sudeep Holla wrote: >>> >>> >>> On 17/11/16 21:00, Frank Rowand wrote: >>>> On 11/17/16 07:32, Sudeep Holla wrote: >>>>&

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
On 11/21/16 08:23, Sudeep Holla wrote: > > > On 21/11/16 16:05, Frank Rowand wrote: >> Hi Sudeep, >> >> On 11/18/16 12:22, Frank Rowand wrote: >>> On 11/18/16 02:41, Sudeep Holla wrote: >>>> >>>> >>>> On 17/11/1

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
On 11/21/16 11:24, Frank Rowand wrote: > On 11/21/16 08:23, Sudeep Holla wrote: >> >> >> On 21/11/16 16:05, Frank Rowand wrote: >>> Hi Sudeep, >>> >>> On 11/18/16 12:22, Frank Rowand wrote: >>>> On 11/18/16 02:41, Sudeep Holla wr

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-23 Thread Frank Rowand
On 11/22/16 21:55, Sekhar Nori wrote: > On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: >> Please note that the compatible property might contain several strings, not >> just >> a single string. > > So I guess the best thing to do is to use > of_property

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-23 Thread Frank Rowand
On 11/23/16 10:13, Frank Rowand wrote: > On 11/22/16 21:55, Sekhar Nori wrote: >> On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: >>> Please note that the compatible property might contain several strings, not >>> just >>> a single string. >> &g

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Frank Rowand
Hi Sekhar, (And adding Sudeep since he becomes involved in this further down thread and at that point says he will re-work this proposed work around in a manner that is incorrect in a manner that is similar to this proposed work around.) On 11/21/16 08:33, Sekhar Nori wrote: > On Monday 31

Re: [PATCH] of: Fix issue where code would fall through to error case.

2016-11-28 Thread Frank Rowand
On 11/26/16 13:39, Frank Rowand wrote: > On 11/23/16 13:58, Rob Herring wrote: >> On Thu, Nov 17, 2016 at 6:10 PM, Moritz Fischer >> <moritz.fischer.priv...@gmail.com> wrote: >>> On Thu, Nov 17, 2016 at 4:02 PM, Frank Rowand <frowand.l...@gmail.com> >>>

Re: [PATCH] of: Fix issue where code would fall through to error case.

2016-11-26 Thread Frank Rowand
On 11/23/16 13:58, Rob Herring wrote: > On Thu, Nov 17, 2016 at 6:10 PM, Moritz Fischer > <moritz.fischer.priv...@gmail.com> wrote: >> On Thu, Nov 17, 2016 at 4:02 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >>> On 11/17/16 15:40, Frank Rowand wrote: >&

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-22 Thread Frank Rowand
On 11/21/16 22:25, Sekhar Nori wrote: > Hi Frank, > > On Tuesday 22 November 2016 07:13 AM, Frank Rowand wrote: >> On 11/21/16 08:33, Sekhar Nori wrote: >>> On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: >>>> +static int da8xx_ddrct

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-22 Thread Frank Rowand
Hi Rob, On 11/18/16 12:00, Frank Rowand wrote: > On 11/18/16 06:46, Rob Herring wrote: >> On Thu, Nov 17, 2016 at 03:32:54PM +, Sudeep Holla wrote: >>> Currently platforms/drivers needing to get the machine model name are >>> replicating the same sn

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-18 Thread Frank Rowand
On 11/18/16 02:41, Sudeep Holla wrote: > > > On 17/11/16 21:00, Frank Rowand wrote: >> On 11/17/16 07:32, Sudeep Holla wrote: >>> Currently platforms/drivers needing to get the machine model name are >>> replicating the same snippet of code. In some case, the OF

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-18 Thread Frank Rowand
code snippets doing exactly >> same thing later. >> >> Cc: Rob Herring <robh...@kernel.org> >> Cc: Frank Rowand <frowand.l...@gmail.com> >> Cc: Arnd Bergmann <a...@arndb.de> >> Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com> >> --- >

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-17 Thread Frank Rowand
On 11/17/16 13:00, Frank Rowand wrote: > On 11/17/16 07:32, Sudeep Holla wrote: >> Currently platforms/drivers needing to get the machine model name are >> replicating the same snippet of code. In some case, the OF reference >> counting is either missing or incorrect. >>

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-17 Thread Frank Rowand
/generic/proc.c The proposed patch matches the code used in one place, and thus current usage does not match the patch description. Is my search bad? Are you planning to add additional instances of reading "model" then "compatible"? -Frank > > Cc: Rob Herring <rob

Re: [PATCH] of: Fix issue where code would fall through to error case.

2016-11-17 Thread Frank Rowand
ree_symbols); > + > + return 0; > + > err_out: > pr_err("overlay phandle fixup failed: %d\n", err); > out: Thanks for catching that. Rob, please apply. Reviewed-by: Frank Rowand <frank.row...@am.sony.com> -Frank

Re: [PATCH] of: Fix issue where code would fall through to error case.

2016-11-17 Thread Frank Rowand
On 11/17/16 15:40, Frank Rowand wrote: > On 11/17/16 15:25, Moritz Fischer wrote: >> No longer fall through into the error case that prints out >> an error if no error (err = 0) occurred. >> >> Fixes d9181b20a83(of: Add back an error message, restructured) >&

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
Hi Sudeep, On 11/18/16 12:22, Frank Rowand wrote: > On 11/18/16 02:41, Sudeep Holla wrote: >> >> >> On 17/11/16 21:00, Frank Rowand wrote: >>> On 11/17/16 07:32, Sudeep Holla wrote: >>>> Currently platforms/drivers needing to get the machine model

Re: [RFC PATCH 02/13] of: Remove excessive printks to reduce clutter

2016-10-27 Thread Frank Rowand
On 10/27/16 06:51, Pantelis Antoniou wrote: > Hi Rob, Frank, > >> On Oct 27, 2016, at 15:21 , Rob Herring <robh...@kernel.org> wrote: >> >> On Tue, Oct 25, 2016 at 3:58 PM, <frowand.l...@gmail.com> wrote: >>> From: Frank Rowand <frank.row.

Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols

2016-10-27 Thread Frank Rowand
On 10/27/16 07:41, Pantelis Antoniou wrote: > Hi Frank, > > >> On Oct 25, 2016, at 23:59 , frowand.l...@gmail.com wrote: >> >> From: Frank Rowand <frank.row...@am.sony.com> >> >> This unused variable is a reminder that symbols in overlay

Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols

2016-10-27 Thread Frank Rowand
On 10/27/16 09:27, Frank Rowand wrote: > On 10/27/16 07:41, Pantelis Antoniou wrote: >> Hi Frank, >> >> >>> On Oct 25, 2016, at 23:59 , frowand.l...@gmail.com wrote: >>> >>> From: Frank Rowand <frank.row...@am.sony.com> >>>

Re: Linux Foundation Technical Advisory Board Elections updates and location

2016-10-28 Thread Frank Rowand
Hi Chris, It's time for the annual question of: where do I find the TAB minutes? I was sure I had a bookmark of the link, but I seem to have misplaced it. Thanks, Frank On 10/28/16 12:39, Chris Mason wrote: > Hello everyone, > > A few updates about the TAB election. It is scheduled for 5pm

Re: [RFC PATCH 06/13] of: Remove prefix "__of_" and prefix "__" from local function names

2016-10-27 Thread Frank Rowand
On 10/27/16 05:47, Rob Herring wrote: > On Tue, Oct 25, 2016 at 3:58 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@am.sony.com> > > I prefer to leave the prefixes and this is getting into pointless churn. > >> >> Signed-off-

Re: [RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable

2016-10-27 Thread Frank Rowand
On 10/27/16 05:03, Rob Herring wrote: > On Tue, Oct 25, 2016 at 4:02 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 10/25/16 13:58, frowand.l...@gmail.com wrote: >>> From: Frank Rowand <frank.row...@am.sony.com> >>> >>> drivers/of/resol

Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols

2016-10-27 Thread Frank Rowand
On 10/27/16 09:53, Frank Rowand wrote: > On 10/27/16 09:27, Frank Rowand wrote: >> On 10/27/16 07:41, Pantelis Antoniou wrote: >>> Hi Frank, >>> >>> >>>> On Oct 25, 2016, at 23:59 , frowand.l...@gmail.com wrote: >>>> >>>> From

Re: [PATCH] Add missing space at end of pr_fmt().

2016-10-17 Thread Frank Rowand
On 10/17/16 08:10, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@am.sony.com> > > Make pr_fmt() in fdt.c consistent with all other files in drivers/of/ > > Signed-off-by: Frank Rowand <frank.row...@am.sony.com> Rob, Please ignore due to bad su

Re: [PATCH] make of_device_make_bus_id() static

2016-10-17 Thread Frank Rowand
On 10/17/16 08:50, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@am.sony.com> > > of_device_make_bus_id() was changed to non-static by commit c66012253800 > ("of/device: Make of_device_make_bus_id() usable by other code") more than > 6 ye

Re: [PATCH 1/1] scripts: Fixing NULL pointer dereference when pos->file is NULL

2016-11-29 Thread Frank Rowand
On 11/29/16 02:34, Maninder Singh wrote: > This patch fixes NULL pointer dereference when pos->file is NULL. > > caught with static analysis tool. > Signed-off-by: Maninder Singh > Signed-off-by: Vaneet Narang > --- > scripts/dtc/srcpos.c | 3 +--

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-12-09 Thread Frank Rowand
On 12/09/16 08:03, Rob Herring wrote: > On Wed, Nov 23, 2016 at 4:25 AM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >> >> >> On 22/11/16 21:35, Rob Herring wrote: >>> >>> On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand <frowand.l...@gmail.com> >

Re: [PATCH v4] of: Fix issue where code would fall through to error case.

2016-12-01 Thread Frank Rowand
d-off-by: Moritz Fischer <m...@kernel.org> > Reviewed-by: Frank Rowand <frank.row...@am.sony.com> > --- > Hi Frank, Rob > > sorry for the noise before. I'm sure I created much more noise than you did. Thanks for persisting. I am confirming that this still applies for v4:

Re: [PATCH] of: Fix issue where code would fall through to error case.

2016-11-29 Thread Frank Rowand
On 11/29/16 07:06, Rob Herring wrote: > On Mon, Nov 28, 2016 at 9:30 AM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 11/26/16 13:39, Frank Rowand wrote: >>> On 11/23/16 13:58, Rob Herring wrote: >>>> On Thu, Nov 17, 2016 at 6:10 PM, Moritz Fischer &g

Re: [PATCH v3 1/2] of: Fix issue where code would fall through to error case.

2016-11-29 Thread Frank Rowand
gt; Fixes d9181b20a83(of: Add back an error message, restructured) > Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> > Reviewed-by: Frank Rowand <frank.row...@am.sony.com> > --- > Hi Rob, Frank > > this has already Frank's Reviewed-by: tag on it, but since I cha

Re: [PATCH] of: remove redundant memset in overlay

2017-01-09 Thread Frank Rowand
d_overlay_info(struct of_overlay *ov, > > cnt = 0; > for_each_child_of_node(tree, node) { > - memset([cnt], 0, sizeof(*ovinfo)); > err = of_fill_overlay_info(ov, node, [cnt]); > if (err == 0) > cnt++; > Reviewed-by: Fra

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-12-26 Thread Frank Rowand
On 12/25/16 01:02, Heinrich Schuchardt wrote: > The patch adds a new property "linux,hotpluggable" to memory nodes of the > device tree. > > memory@0 { > reg = <0x0 0x0100 0x0 0x7f00>; > linux,hotpluggable; > } > > Memory areas marked by this property can later be disabled

Re: [PATCH 0/4 v2] of/overlay: sysfs based ABI for dt overlays

2016-12-22 Thread Frank Rowand
Hi Heinrich, On 12/20/16 11:04, Heinrich Schuchardt wrote: > Currently the kernel only supplies an internal API for creating > and destroying device tree overlays. > > For some boards vendor specific kernel modules exist for > managing device tree overlays but they have not been > upstreamed or

Re: Fwd: [PATCH 1/1] of/fdt: failed to mark hotplug range message

2016-12-22 Thread Frank Rowand
And the patch to be fixed was merged via akpm, so adding him. Fixes: 41a9ada3e6b4 ("of/fdt: mark hotpluggable memory") -Frank On 12/21/16 21:52, Heinrich Schuchardt wrote: > scripts/get_maintainers.pl did not show the people involved in creating > the code to be changed. > > On 12/22/2016

Re: Query on DT overlay support.

2017-03-23 Thread Frank Rowand
(Adding Pantelis and dgibson to cc.) On 03/23/17 11:32, Rob Herring wrote: > On Thu, Mar 23, 2017 at 8:22 AM, Nava kishore Manne > wrote: >> Hi, >> >> >> >> This mail is regarding the DT overlay support in the Linux >> kernel >> >> I am able

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread Frank Rowand
On 04/06/17 07:03, Rob Herring wrote: > On Thu, Apr 6, 2017 at 1:18 AM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> of_dma_get_range() has workaround code to fixup a device tree that >> incorrectly specified a mas

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Frank Rowand
On 04/06/17 03:24, Robin Murphy wrote: > On 06/04/17 08:01, Frank Rowand wrote: >> On 04/04/17 03:18, Sricharan R wrote: >>> Size of the dma-range is calculated as coherent_dma_mask + 1 >>> and passed to arch_setup_dma_ops further. It overflows when >>> the

Re: [PATCH V10 00/12] IOMMU probe deferral support

2017-04-06 Thread Frank Rowand
On 04/04/17 18:23, Rob Herring wrote: > On Tue, Apr 4, 2017 at 5:18 AM, Sricharan R wrote: >> This series calls the dma ops configuration for the devices >> at a generic place so that it works for all busses. >> The dma_configure_ops for a device is now called during >>

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Frank Rowand
On 04/06/17 04:01, Sricharan R wrote: > Hi Frank, > > On 4/6/2017 12:31 PM, Frank Rowand wrote: >> On 04/04/17 03:18, Sricharan R wrote: >>> Size of the dma-range is calculated as coherent_dma_mask + 1 >>> and passed to arch_setup_dma_ops further. It overflo

Re: [PATCH V10 03/12] of: dma: Move range size workaround to of_dma_get_range()

2017-04-06 Thread Frank Rowand
On 04/04/17 03:18, Sricharan R wrote: > From: Laurent Pinchart > > Invalid dma-ranges values should be worked around when retrieving the > DMA range in of_dma_get_range(), not by all callers of the function. > This isn't much of a problem now that we

Re: [PATCH V11 00/11] IOMMU probe deferral support

2017-04-10 Thread Frank Rowand
On 04/10/17 04:20, Sricharan R wrote: > This series calls the dma ops configuration for the devices > at a generic place so that it works for all busses. > The dma_configure_ops for a device is now called during > the device_attach callback just before the probe of the > bus/driver is called.

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-10 Thread Frank Rowand
On 04/10/17 04:48, Sricharan R wrote: > Hi Frank, > > > Can we get back to the basic premise of the proposed patch? The current code in of_dma_configure() contains a hack that allows the dma-ranges property to specify a mask instead of a size. The binding in the

Re: [PATCH v2 0/3] of: Make of_match_node() an inline stub for CONFIG_OF=n

2017-04-12 Thread Frank Rowand
On 04/11/17 21:41, Florian Fainelli wrote: > Hi all, > > This patch series makes of_match_node() an inline stub for CONFIG_OF=n. kbuild > reported two build errors which are fixed as preriquisite patches. > > This is based on Linus' master, not sure which tree would merge this, Frank's? It

Re: [PATCH 1/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread Frank Rowand
Adding Stephen. On 04/14/17 20:55, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@sony.com> > > Remove "phandle" and "linux,phandle" properties from the internal > device tree. The phandle will still be in the struct device_node &g

Re: [PATCH 3/4] of: be consistent in form of file mode

2017-04-14 Thread Frank Rowand
Adding Stephen. On 04/14/17 20:55, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@sony.com> > > checkpatch whined about using S_IRUGO instead of octal equivalent > when adding phandle sysfs code, so used octal in that patch. > Change other instances

Re: [PATCH 4/4] of: detect invalid phandle in overlay

2017-04-14 Thread Frank Rowand
Adding Stephen. On 04/14/17 20:55, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@sony.com> > > Overlays are not allowed to modify phandle values of previously existing > nodes because there is no information available to allow fixup up > properties th

Re: [PATCH 0/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread Frank Rowand
Hi Stephen, I left you off the distribution list, sorry... On 04/14/17 20:55, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@sony.com> > > Remove "phandle" and "linux,phandle" properties from the internal > device tree. The phandle w

Re: [PATCH 2/4] of: make __of_attach_node() static

2017-04-14 Thread Frank Rowand
Adding Stephen. On 04/14/17 20:55, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@sony.com> > > __of_attach_node() is not used outside of drivers/of/dynamic.c. Make > it static and remove it from drivers/of/of_private.h. > > Signed-off-by: Frank Rowan

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-20 Thread Frank Rowand
On 04/20/17 09:51, Tyrel Datwyler wrote: > On 04/19/2017 09:43 PM, Frank Rowand wrote: > < snip > >> The call stack could easily be post-processed, for example using addr2line. >> Here is the call stack for when the refcount incremented to 23 from 22 (or >>

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-20 Thread Frank Rowand
On 04/19/17 19:37, Frank Rowand wrote: > On 04/19/17 11:45, Tyrel Datwyler wrote: >> On 04/18/2017 07:49 PM, Steven Rostedt wrote: >>> On Tue, 18 Apr 2017 18:42:32 -0700 >>> Frank Rowand <frowand.l...@gmail.com> wrote: >>> >>>> And of cour

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Frank Rowand
On 04/17/17 17:32, Tyrel Datwyler wrote: > This patch introduces event tracepoints for tracking a device_nodes > reference cycle as well as reconfig notifications generated in response > to node/property manipulations. > > With the recent upstreaming of the refcount API several device_node >

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Frank Rowand
On 04/19/17 16:27, Tyrel Datwyler wrote: > On 04/18/2017 06:31 PM, Michael Ellerman wrote: >> Frank Rowand <frowand.l...@gmail.com> writes: >> >>> On 04/17/17 17:32, Tyrel Datwyler wrote: >>>> This patch introduces event tracepoints for tracking a

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Frank Rowand
On 04/19/17 19:33, Steven Rostedt wrote: > On Wed, 19 Apr 2017 16:27:10 -0700 > Tyrel Datwyler wrote: > >> # echo stacktrace > /sys/kernel/debug/tracing/trace_options >> # cat trace | grep -A6 "/pci@8002018" > > Just to let you know that there is now

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Frank Rowand
On 04/19/17 21:43, Frank Rowand wrote: > On 04/19/17 16:27, Tyrel Datwyler wrote: >> On 04/18/2017 06:31 PM, Michael Ellerman wrote: < snip > >> >> To get that same info as far as I know is to add a dump_stack() after >> each pr_debug. > > Here is a pat

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Frank Rowand
On 04/19/17 11:45, Tyrel Datwyler wrote: > On 04/18/2017 07:49 PM, Steven Rostedt wrote: >> On Tue, 18 Apr 2017 18:42:32 -0700 >> Frank Rowand <frowand.l...@gmail.com> wrote: >> >>> And of course the other issue with using tracepoints is the extra space >

Re: [RFC/PATCH] of: Mark property::value as const

2017-03-11 Thread Frank Rowand
Hi Stephen, On 02/23/17 15:08, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. L

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-07 Thread Frank Rowand
On 04/07/17 07:46, Robin Murphy wrote: > On 06/04/17 20:34, Frank Rowand wrote: >> On 04/06/17 04:01, Sricharan R wrote: >>> Hi Frank, >>> >>> On 4/6/2017 12:31 PM, Frank Rowand wrote: >>>> On 04/04/17 03:18, Sricharan R wrote: >>>>&g

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-07 Thread Frank Rowand
On 04/06/17 00:01, Frank Rowand wrote: > On 04/04/17 03:18, Sricharan R wrote: >> Size of the dma-range is calculated as coherent_dma_mask + 1 >> and passed to arch_setup_dma_ops further. It overflows when >> the coherent_dma_mask is set for full 64 bits 0x,

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-07 Thread Frank Rowand
On 04/07/17 10:09, Rob Herring wrote: > + Robin, Sricharan > > On Fri, Apr 7, 2017 at 12:18 AM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 04/06/17 15:41, Rob Herring wrote: >>> On Thu, Apr 6, 2017 at 1:37 PM, Frank Rowand <frowand.l...@gmail.com>

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread Frank Rowand
On 04/06/17 15:41, Rob Herring wrote: > On Thu, Apr 6, 2017 at 1:37 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 04/06/17 07:03, Rob Herring wrote: >>> On Thu, Apr 6, 2017 at 1:18 AM, <frowand.l...@gmail.com> wrote: >>>>

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Frank Rowand
On 04/04/17 03:18, Sricharan R wrote: > Size of the dma-range is calculated as coherent_dma_mask + 1 > and passed to arch_setup_dma_ops further. It overflows when > the coherent_dma_mask is set for full 64 bits 0x, > resulting in size getting passed as 0 wrongly. Fix this by >

Re: [PATCH] usb: Make sure usb/phy/of gets built-in

2017-04-17 Thread Frank Rowand
On 04/13/17 05:33, Alexey Brodkin wrote: > DWC3 driver uses of_usb_get_phy_mode() which is > implemented in drivers/usb/phy/of.c and in bare minimal > configuration it might not be pulled in kernel binary. > > In case of ARC or ARM this could be easily reproduced with > "allnodefconfig"

Re: [PATCH 0/4] of: remove *phandle properties from expanded device tree

2017-04-18 Thread Frank Rowand
Hi Rob, Please do not apply this patch series. The more context I look at, the less this approach seems good. I hope to have a simpler version completed quickly. Thanks, - Frank On 04/14/17 20:58, Frank Rowand wrote: > Hi Stephen, > > I left you off the distribution li

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-18 Thread Frank Rowand
On 04/18/17 19:46, Steven Rostedt wrote: > On Tue, 18 Apr 2017 17:07:17 -0700 > Frank Rowand <frowand.l...@gmail.com> wrote: > > >> As far as I know, there is no easy way to combine trace data and printk() >> style data to create a single chronology of events.

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-18 Thread Frank Rowand
On 04/17/17 17:32, Tyrel Datwyler wrote: > This patch introduces event tracepoints for tracking a device_nodes > reference cycle as well as reconfig notifications generated in response > to node/property manipulations. > > With the recent upstreaming of the refcount API several device_node >

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-18 Thread Frank Rowand
On 04/18/17 17:07, Frank Rowand wrote: > On 04/17/17 17:32, Tyrel Datwyler wrote: >> This patch introduces event tracepoints for tracking a device_nodes >> reference cycle as well as reconfig notifications generated in response >> to node/property manipulations. >> >

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-18 Thread Frank Rowand
On 04/18/17 18:31, Michael Ellerman wrote: > Frank Rowand <frowand.l...@gmail.com> writes: > >> On 04/17/17 17:32, Tyrel Datwyler wrote: >>> This patch introduces event tracepoints for tracking a device_nodes >>> reference cycle as well as reconfig notificatio

Re: [PATCH 2/2] of: Add unit tests for applying overlays.

2017-04-24 Thread Frank Rowand
On 04/24/17 10:16, Rob Herring wrote: > On Mon, Apr 24, 2017 at 12:43 AM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Existing overlay unit tests examine individual pieces of the overlay >> code. The new test

Re: [RFC 2/3] of: reserved_mem: Accessor for acquiring reserved_mem

2017-04-24 Thread Frank Rowand
tatic inline struct reserved_mem *of_get_reserved_mem_by_idx(struct > device_node *np, > + int idx); > +{ > + return NULL; > +} > + > static inline void fdt_init_reserved_mem(void) { } > static inline void fdt_reserved_mem_save_node(unsigned long node, > const char *uname, phys_addr_t base, phys_addr_t size) { } > Reviewed-by: Frank Rowand <frank.row...@sony.com>

Re: [PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

2017-04-24 Thread Frank Rowand
On 04/24/17 14:40, Rob Herring wrote: > +Ben H > > On Mon, Apr 24, 2017 at 1:54 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 04/24/17 09:56, Rob Herring wrote: >>> On Mon, Apr 24, 2017 at 12:20 AM, <frowand.l...@gmail.com> wrote: >>&g

Re: [PATCH v6 1/4] of: remove *phandle properties from expanded device tree

2017-08-02 Thread Frank Rowand
te: > Hi Frank, > > frowand.l...@gmail.com writes: >> From: Frank Rowand <frank.row...@sony.com> >> >> Remove "phandle", "linux,phandle", and "ibm,phandle" properties from >> the internal device tree. The phandle will still be in the

Re: [PATCH] devicetree: Enable generation of __symbols__ in all dtb files

2017-08-15 Thread Frank Rowand
the filesize (and resident memory > usage) based on the number of __symbol__ entries added to match the > contents of the dts. > > Cc: Rob Herring <robh...@kernel.org> > Cc: Frank Rowand <frowand.l...@gmail.com> > Cc: Masahiro Yamada <yamada.masah...@socionext.c

Re: [PATCH] devicetree: Enable generation of __symbols__ in all dtb files

2017-08-15 Thread Frank Rowand
On 08/15/17 15:36, Rob Herring wrote: > On Tue, Aug 15, 2017 at 4:15 PM, Tom Rini wrote: >> With support for stacked overlays being part of libfdt it is now < snip > >> My proposal is that we do not want __symbols__ existence to be dependent >> on some part of the kernel

Re: [PATCH] devicetree: Enable generation of __symbols__ in all dtb files

2017-08-15 Thread Frank Rowand
to the dtb files generated by the kernel. This is done by >> passing -@ to dtc. This does increase the filesize (and resident memory >> usage) based on the number of __symbol__ entries added to match the >> contents of the dts. >> >> Cc: Rob Herring <robh...@kernel.org&g

Re: [PATCH] devicetree: Enable generation of __symbols__ in all dtb files

2017-08-15 Thread Frank Rowand
On 08/15/17 14:15, Tom Rini wrote: > With support for stacked overlays being part of libfdt it is now > possible and likely that overlays which require __symbols__ will be > applied to the dtb files generated by the kernel. This is done by > passing -@ to dtc. This does increase the filesize

Re: [PATCH] devicetree: Enable generation of __symbols__ in all dtb files

2017-08-15 Thread Frank Rowand
On 08/15/17 17:42, Tom Rini wrote: > On Tue, Aug 15, 2017 at 04:50:40PM -0700, Frank Rowand wrote: >> On 08/15/17 14:15, Tom Rini wrote: >>> With support for stacked overlays being part of libfdt it is now >>> possible and likely that overlays which require __sy

Re: [PATCH] devicetree: Enable generation of __symbols__ in all dtb files

2017-08-15 Thread Frank Rowand
On 08/15/17 16:57, Frank Rowand wrote: > On 08/15/17 15:36, Rob Herring wrote: >> On Tue, Aug 15, 2017 at 4:15 PM, Tom Rini <tr...@konsulko.com> wrote: >>> With support for stacked overlays being part of libfdt it is now >>> possible and likely that o

Re: [PATCH] ARM: dts: TI: Enable __symbols__ in dtb files for some platforms

2017-08-17 Thread Frank Rowand
On 08/16/17 17:33, Tom Rini wrote: > On Wed, Aug 16, 2017 at 03:57:21PM -0700, Frank Rowand wrote: >> On 08/16/17 15:33, Frank Rowand wrote: >>> On 08/16/17 14:59, Tom Rini wrote: >>>> Build the dtb file for these platfroms with __symbol__ information >>>

Re: [PATCH] dts: Make it easier to enable __symbols__ generation in dtb files

2017-08-17 Thread Frank Rowand
<robertcnel...@gmail.com> > Cc: Lokesh Vutla <lokeshvu...@ti.com> > Cc: Frank Rowand <frowand.l...@gmail.com> > Cc: Rob Herring <robh...@kernel.org> > Cc: Mark Rutland <mark.rutl...@arm.com> > Cc: Russell King <li...@armlinux.org.uk> > Cc: Masahiro Ya

Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes

2017-08-16 Thread Frank Rowand
I deleted most of the distribution list. My email server rejects an email with this many recipients. On 08/15/17 19:12, Chris Mi wrote: > IDR uses internally radix tree which uses unsigned long. It doesn't > makes sense to have index as signed value. > > Signed-off-by: Chris Mi

Re: [PATCH 2/3] of: overlay: correctly apply overlay node with unit-address

2017-07-10 Thread Frank Rowand
On 07/10/17 09:08, Rob Herring wrote: > On Fri, Jul 7, 2017 at 7:28 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Correct existing node name detection when overlay node name has >> a unit-address. >> &

Re: [PATCH v2 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-10 Thread Frank Rowand
On 07/10/17 19:31, Rob Herring wrote: > On Mon, Jul 10, 2017 at 2:05 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Add nodes and properties to overlay_base and overlay dts files to >> test for >>- incorr

panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

2017-07-17 Thread Frank Rowand
Hi Abhijeet, My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. I bisected the problem to commit 7f1d4e58dabb, "spmi: pmic-arb: optimize table lookups". The panic occurs at the top of pmic_arb_ppid_to_apid_v1(), due to pa->ppid_to_apid being null. A little more information that might

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

2017-07-17 Thread Frank Rowand
On 07/17/17 20:56, Rajendra Nayak wrote: > > On 07/18/2017 09:12 AM, Frank Rowand wrote: >> Hi Abhijeet, >> >> My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. >> >> I bisected the problem to commit 7f1d4e58dabb, "spmi: pmic-arb: >> optimiz

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

2017-07-17 Thread Frank Rowand
On 07/17/17 22:06, Frank Rowand wrote: > On 07/17/17 20:56, Rajendra Nayak wrote: >> >> On 07/18/2017 09:12 AM, Frank Rowand wrote: >>> Hi Abhijeet, >>> >>> My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. >>> >>> I bisected the p

Re: [PATCH] spmi: pmic-arb: Always allocate ppid_to_apid table

2017-07-18 Thread Frank Rowand
c-arb: optimize table lookups") >> Signed-off-by: Stephen Boyd <sb...@codeaurora.org> > Reviewed-by: Kiran Gunda <kgu...@codeaurora.org> Tested on a qcom-apq8074-dragonboard on 4.13-rc1 Tested-by: Frank Rowand <frank.row...@sony.com> >> --- >> drivers/spmi/

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

2017-07-18 Thread Frank Rowand
On 07/17/17 22:44, Frank Rowand wrote: > On 07/17/17 22:06, Frank Rowand wrote: >> On 07/17/17 20:56, Rajendra Nayak wrote: >>> >>> On 07/18/2017 09:12 AM, Frank Rowand wrote: >>>> Hi Abhijeet, >>>> >>>> My qcom-apq8074-dragonboar

Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-19 Thread Frank Rowand
On 07/19/17 06:39, Rob Herring wrote: > On Tue, Jul 18, 2017 at 10:52 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Add nodes and properties to overlay_base and overlay dts files to >> test for >>- incorr

Re: [PATCH 1/2] MAINTAINERS: device property: acpi: add fwnode.h

2017-07-21 Thread Frank Rowand
On 07/21/17 15:03, Rafael J. Wysocki wrote: > On Thursday, July 20, 2017 12:13:24 PM frowand.l...@gmail.com wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> ACPI is impacted by changes to fwnode.h, add a file entry >> to ACPI >> >> Signe

Re: [PATCH] docs: submitting-patches - change non-ascii character to ascii

2017-07-21 Thread Frank Rowand
On 07/21/17 10:27, Jonathan Corbet wrote: > On Thu, 20 Jul 2017 18:30:55 -0700 > frowand.l...@gmail.com wrote: > >> Documentation/process/submitting-patches.rst contains a non-ascii >> character. Change it to the ascii equivalent. > > You should know better than to tell somebody like me that a

Re: [PATCH] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF

2017-07-21 Thread Frank Rowand
ude/linux/of.h > +++ b/include/linux/of.h > @@ -735,6 +735,9 @@ static inline struct device_node *of_get_cpu_node(int cpu, > return NULL; > } > > +static inline int of_n_addr_cells(struct device_node *np) { return 0; } > +static inline int of_n_size_cells(struct device_node

Re: [PATCH 0/4] Removing full paths from DT full_name

2017-07-26 Thread Frank Rowand
Hi Rob, On 07/25/17 14:44, Rob Herring wrote: > This series is the last steps to remove storing the full path for every > DT node. Instead, we can create full path strings dynamically as needed > with printf %pOF specifiers (commit ce4fecf1fe15). There are a number of > remaining direct users

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Frank Rowand
On 07/19/17 09:02, Rob Herring wrote: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: >> On 07/18/2017 11:43 PM, Rob Herring wrote: >>> Now that we have a custom printf format specifier, convert users of >>> full_name to use %pOF instead. This is preparation

<    1   2   3   4   5   6   7   8   9   10   >