[PATCH v16 05/15] clocksource/drivers/arm_arch_timer: fix a bug in arch_timer_register about arch_timer_uses_ppi

2016-11-16 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch fix a potential bug about arch_timer_uses_ppi in arch_timer_register. On ARM64, we don't use ARCH_TIMER_PHYS_SECURE_PPI in Linux, so we will just igorne it in init code. If arch_timer_uses_ppi is ARCH_TIMER_PHYS_NONSECURE_PPI, the origna

[PATCH v16 09/15] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT

2016-11-16 Thread fu . wei
From: Fu Wei The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame. And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES These will be used for refactoring the memory-mapped timer init code to prepare for GTDT Signed-off-by: Fu Wei --- include

[PATCH v16 06/15] clocksource/drivers/arm_arch_timer: separate out arch_timer_uses_ppi init code to prepare for GTDT.

2016-11-16 Thread fu . wei
From: Fu Wei The patch refactor original arch_timer_uses_ppi init code: (1) Extract a subfunction: arch_timer_uses_ppi_init (2) Use the new subfunction in arch_timer_of_init and arch_timer_acpi_init Signed-off-by: Fu Wei --- drivers/clocksource/arm_arch_timer.c | 73

[PATCH v16 03/15] clocksource/drivers/arm_arch_timer: Improve printk relevant code

2016-11-16 Thread fu . wei
From: Fu Wei This patch defines pr_fmt(fmt) for all pr_* functions, then the pr_* doesn't need to add "arch_timer:" everytime. According to the suggestion from checkpatch.pl: (1) delete some Blank Spaces in arch_timer_banner; (2) delete a redundant Tab in a bland line of arch_timer

[PATCH v16 08/15] clocksource/drivers/arm_arch_timer: Refactor arch_timer_needs_probing, and call it only if acpi disabled.

2016-11-16 Thread fu . wei
From: Fu Wei The patch refactor original arch_timer_needs_probing function: (1) Separate out arch_timer_needs_probing from arch_timer_common_init, and call it only if acpi disabled. (2) Rename arch_timer_needs_probing to arch_timer_needs_of_probing. Signed-off-by: Fu Wei

[PATCH v16 05/15] clocksource/drivers/arm_arch_timer: fix a bug in arch_timer_register about arch_timer_uses_ppi

2016-11-16 Thread fu . wei
From: Fu Wei The patch fix a potential bug about arch_timer_uses_ppi in arch_timer_register. On ARM64, we don't use ARCH_TIMER_PHYS_SECURE_PPI in Linux, so we will just igorne it in init code. If arch_timer_uses_ppi is ARCH_TIMER_PHYS_NONSECURE_PPI, the orignal code of arch_timer_uses_ppi may go

[PATCH v16 02/15] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-11-16 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch add a new enum "arch_timer_spi_nr" and use it in the driver. Just for code's readability, no functional change. Signed-off-by: Fu Wei <fu@linaro.org> Acked-by: Mark Rutland <mark.rutl...@arm.com> --- drivers/cloc

[PATCH v16 02/15] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-11-16 Thread fu . wei
From: Fu Wei This patch add a new enum "arch_timer_spi_nr" and use it in the driver. Just for code's readability, no functional change. Signed-off-by: Fu Wei Acked-by: Mark Rutland --- drivers/clocksource/arm_arch_timer.c | 4 ++-- include/clocksource/arm_arch_timer.h | 6 +

[PATCH v16 04/15] clocksource/drivers/arm_arch_timer: rename some enums and defines, and some cleanups.

2016-11-16 Thread fu . wei
From: Fu Wei <fu@linaro.org> Rename some enums and defines, to unify the format of enums and defines in arm_arch_timer.h, also update all the users of these enums and defines: drivers/clocksource/arm_arch_timer.c virt/kvm/arm/hyp/timer-sr.c And do some cleanups, acc

[PATCH v16 04/15] clocksource/drivers/arm_arch_timer: rename some enums and defines, and some cleanups.

2016-11-16 Thread fu . wei
From: Fu Wei Rename some enums and defines, to unify the format of enums and defines in arm_arch_timer.h, also update all the users of these enums and defines: drivers/clocksource/arm_arch_timer.c virt/kvm/arm/hyp/timer-sr.c And do some cleanups, according to the suggestion from

[PATCH v16 01/15] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-11-16 Thread fu . wei
From: Fu Wei <fu@linaro.org> To support the arm_arch_timer via ACPI we need to share defines and enums between the driver and the ACPI parser code. Split out the relevant defines and enums into arm_arch_timer.h, and change "enum ppi_nr" to "enum arch_timer_ppi_nr" t

[PATCH v16 01/15] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-11-16 Thread fu . wei
From: Fu Wei To support the arm_arch_timer via ACPI we need to share defines and enums between the driver and the ACPI parser code. Split out the relevant defines and enums into arm_arch_timer.h, and change "enum ppi_nr" to "enum arch_timer_ppi_nr" to avoid the potentia

[PATCH v16 00/15] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-11-16 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patchset: (1)Preparation for adding GTDT support in arm_arch_timer: 1. Move some enums and marcos to header file; 2. Add a new enum for spi type; 3. Improve printk relevant code. 4. rename some enums and defines, an

[PATCH v16 00/15] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-11-16 Thread fu . wei
From: Fu Wei This patchset: (1)Preparation for adding GTDT support in arm_arch_timer: 1. Move some enums and marcos to header file; 2. Add a new enum for spi type; 3. Improve printk relevant code. 4. rename some enums and defines, and some cleanups. 5

Re: [PATCH v15 01/13] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-11-15 Thread Fu Wei
help improve the system] > > url: > https://github.com/0day-ci/linux/commits/fu-wei-linaro-org/acpi-clocksource-add-GTDT-driver-and-GTDT-support-in-arm_arch_timer/20161116-00 > config: arm-hisi_defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1

Re: [PATCH v15 01/13] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-11-15 Thread Fu Wei
t; > url: > https://github.com/0day-ci/linux/commits/fu-wei-linaro-org/acpi-clocksource-add-GTDT-driver-and-GTDT-support-in-arm_arch_timer/20161116-00 > config: arm-hisi_defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 >

[PATCH v15 12/13] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch add memory-mapped timer register support by using the information provided by the new GTDT driver of ACPI. Signed-off-by: Fu Wei <fu@linaro.org> --- drivers/clocksource/arm_arch_timer.c | 26 +- 1 file changed, 2

[PATCH v15 11/13] acpi/arm64: Add memory-mapped timer support in GTDT driver

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> On platforms booting with ACPI, architected memory-mapped timers' configuration data is provided by firmware through the ACPI GTDT static table. The clocksource architected timer kernel driver requires a firmware interface to collect timer configu

[PATCH v15 13/13] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> This driver adds support for parsing SBSA Generic Watchdog timer in GTDT, parse all info in SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the re

[PATCH v15 12/13] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-11-15 Thread fu . wei
From: Fu Wei The patch add memory-mapped timer register support by using the information provided by the new GTDT driver of ACPI. Signed-off-by: Fu Wei --- drivers/clocksource/arm_arch_timer.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git

[PATCH v15 11/13] acpi/arm64: Add memory-mapped timer support in GTDT driver

2016-11-15 Thread fu . wei
From: Fu Wei On platforms booting with ACPI, architected memory-mapped timers' configuration data is provided by firmware through the ACPI GTDT static table. The clocksource architected timer kernel driver requires a firmware interface to collect timer configuration and configure its driver

[PATCH v15 13/13] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver

2016-11-15 Thread fu . wei
From: Fu Wei This driver adds support for parsing SBSA Generic Watchdog timer in GTDT, parse all info in SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the resource of platform device

[PATCH v15 10/13] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei <fu@linaro.or

[PATCH v15 06/13] clocksource/drivers/arm_arch_timer: separate out arch_timer_uses_ppi init code to prepare for GTDT.

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch refactor original arch_timer_uses_ppi init code: (1) Extract a subfunction: arch_timer_uses_ppi_init (2) Use the new subfunction in arch_timer_of_init and arch_timer_acpi_init Signed-off-by: Fu Wei <fu@linaro.org> --- drivers

[PATCH v15 06/13] clocksource/drivers/arm_arch_timer: separate out arch_timer_uses_ppi init code to prepare for GTDT.

2016-11-15 Thread fu . wei
From: Fu Wei The patch refactor original arch_timer_uses_ppi init code: (1) Extract a subfunction: arch_timer_uses_ppi_init (2) Use the new subfunction in arch_timer_of_init and arch_timer_acpi_init Signed-off-by: Fu Wei --- drivers/clocksource/arm_arch_timer.c | 73

[PATCH v15 10/13] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

2016-11-15 Thread fu . wei
From: Fu Wei The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei Signed-off-by: Hanjun Guo --- drivers

[PATCH v15 08/13] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch refactor original memory-mapped timer init code: (1) Extract a subfunction for detecting a bast time frame: is_best_frame. (2) Refactor "arch_timer_mem_init", make it become a common code for memory-mapped timer i

[PATCH v15 09/13] acpi/arm64: Add GTDT table parse driver

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch adds support for parsing arch timer in GTDT, provides some kernel APIs to parse all the PPIs and always-on info in GTDT and export them. By this driver, we can simplify arm_arch_timer drivers, and separate the ACPI GTDT knowledge from it. Sign

[PATCH v15 07/13] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame. And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES These will be used for refactoring the memory-mapped timer init code to prepare for GTDT Signed-off-by:

[PATCH v15 08/13] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-11-15 Thread fu . wei
From: Fu Wei The patch refactor original memory-mapped timer init code: (1) Extract a subfunction for detecting a bast time frame: is_best_frame. (2) Refactor "arch_timer_mem_init", make it become a common code for memory-mapped timer init. (3) Add a ne

[PATCH v15 09/13] acpi/arm64: Add GTDT table parse driver

2016-11-15 Thread fu . wei
From: Fu Wei This patch adds support for parsing arch timer in GTDT, provides some kernel APIs to parse all the PPIs and always-on info in GTDT and export them. By this driver, we can simplify arm_arch_timer drivers, and separate the ACPI GTDT knowledge from it. Signed-off-by: Fu Wei Signed

[PATCH v15 07/13] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT

2016-11-15 Thread fu . wei
From: Fu Wei The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame. And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES These will be used for refactoring the memory-mapped timer init code to prepare for GTDT Signed-off-by: Fu Wei --- include

[PATCH v15 01/13] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> To support the arm_arch_timer via ACPI we need to share defines and enums between the driver and the ACPI parser code. Split out the relevant defines and enums into arm_arch_timer.h, and change "enum ppi_nr" to "enum arch_timer_ppi_nr" t

[PATCH v15 04/13] clocksource/drivers/arm_arch_timer: rename some enums and defines, and some cleanups.

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> Rename some enums and defines, to unify the format of enums and defines in arm_arch_timer.h, also update all the users of these enums and defines: drivers/clocksource/arm_arch_timer.c virt/kvm/arm/hyp/timer-sr.c And do some cleanups, acc

[PATCH v15 00/13] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patchset: (1)Preparation for adding GTDT support in arm_arch_timer: 1. Move some enums and marcos to header file; 2. Add a new enum for spi type; 3. Improve printk relevant code. 4. rename some enums and defines, an

[PATCH v15 01/13] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-11-15 Thread fu . wei
From: Fu Wei To support the arm_arch_timer via ACPI we need to share defines and enums between the driver and the ACPI parser code. Split out the relevant defines and enums into arm_arch_timer.h, and change "enum ppi_nr" to "enum arch_timer_ppi_nr" to avoid the po

[PATCH v15 04/13] clocksource/drivers/arm_arch_timer: rename some enums and defines, and some cleanups.

2016-11-15 Thread fu . wei
From: Fu Wei Rename some enums and defines, to unify the format of enums and defines in arm_arch_timer.h, also update all the users of these enums and defines: drivers/clocksource/arm_arch_timer.c virt/kvm/arm/hyp/timer-sr.c And do some cleanups, according to the suggestion from

[PATCH v15 00/13] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-11-15 Thread fu . wei
From: Fu Wei This patchset: (1)Preparation for adding GTDT support in arm_arch_timer: 1. Move some enums and marcos to header file; 2. Add a new enum for spi type; 3. Improve printk relevant code. 4. rename some enums and defines, and some cleanups. 5

[PATCH v15 03/13] clocksource/drivers/arm_arch_timer: Improve printk relevant code

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch defines pr_fmt(fmt) for all pr_* functions, then the pr_* doesn't need to add "arch_timer:" everytime. According to the suggestion from checkpatch.pl: (1) delete some Blank Spaces in arch_timer_banner; (2) delete a redundant Tab

[PATCH v15 02/13] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch add a new enum "arch_timer_spi_nr" and use it in the driver. Just for code's readability, no functional change. Signed-off-by: Fu Wei <fu@linaro.org> Acked-by: Mark Rutland <mark.rutl...@arm.com> --- drivers/cloc

[PATCH v15 05/13] clocksource/drivers/arm_arch_timer: fix a bug in arch_timer_register about arch_timer_uses_ppi

2016-11-15 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch fix a potential bug about arch_timer_uses_ppi in arch_timer_register. On ARM64, we don't use ARCH_TIMER_PHYS_SECURE_PPI in Linux, so we will just igorne it in init code. If arch_timer_uses_ppi is ARCH_TIMER_PHYS_NONSECURE_PPI, the origna

[PATCH v15 03/13] clocksource/drivers/arm_arch_timer: Improve printk relevant code

2016-11-15 Thread fu . wei
From: Fu Wei This patch defines pr_fmt(fmt) for all pr_* functions, then the pr_* doesn't need to add "arch_timer:" everytime. According to the suggestion from checkpatch.pl: (1) delete some Blank Spaces in arch_timer_banner; (2) delete a redundant Tab in a bland line of arch_timer

[PATCH v15 02/13] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-11-15 Thread fu . wei
From: Fu Wei This patch add a new enum "arch_timer_spi_nr" and use it in the driver. Just for code's readability, no functional change. Signed-off-by: Fu Wei Acked-by: Mark Rutland --- drivers/clocksource/arm_arch_timer.c | 4 ++-- include/clocksource/arm_arch_timer.h | 6 +

[PATCH v15 05/13] clocksource/drivers/arm_arch_timer: fix a bug in arch_timer_register about arch_timer_uses_ppi

2016-11-15 Thread fu . wei
From: Fu Wei The patch fix a potential bug about arch_timer_uses_ppi in arch_timer_register. On ARM64, we don't use ARCH_TIMER_PHYS_SECURE_PPI in Linux, so we will just igorne it in init code. If arch_timer_uses_ppi is ARCH_TIMER_PHYS_NONSECURE_PPI, the orignal code of arch_timer_uses_ppi may go

Re: [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-10-26 Thread Fu Wei
Hi Mark, On 26 October 2016 at 23:46, Mark Rutland <mark.rutl...@arm.com> wrote: > On Wed, Oct 26, 2016 at 11:24:32PM +0800, Fu Wei wrote: >> On 21 October 2016 at 19:32, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On Thu, Sep 29, 2016 at 02:17:15AM

Re: [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-10-26 Thread Fu Wei
Hi Mark, On 26 October 2016 at 23:46, Mark Rutland wrote: > On Wed, Oct 26, 2016 at 11:24:32PM +0800, Fu Wei wrote: >> On 21 October 2016 at 19:32, Mark Rutland wrote: >> > On Thu, Sep 29, 2016 at 02:17:15AM +0800, fu@linaro.org wrote: >> >> +static int __init

Re: [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-10-26 Thread Fu Wei
Hi Mark, On 21 October 2016 at 19:32, Mark Rutland <mark.rutl...@arm.com> wrote: > On Thu, Sep 29, 2016 at 02:17:15AM +0800, fu@linaro.org wrote: >> From: Fu Wei <fu@linaro.org> >> >> The patch refactor original memory-mapped timer init code: >> (

Re: [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-10-26 Thread Fu Wei
Hi Mark, On 21 October 2016 at 19:32, Mark Rutland wrote: > On Thu, Sep 29, 2016 at 02:17:15AM +0800, fu@linaro.org wrote: >> From: Fu Wei >> >> The patch refactor original memory-mapped timer init code: >> (1) extract some subfunction for reusing some common

Re: [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver

2016-10-26 Thread Fu Wei
Hi Marc, On 26 October 2016 at 20:11, Marc Zyngier <marc.zyng...@arm.com> wrote: > On 26/10/16 12:10, Fu Wei wrote: >> Hi Mark, >> >> On 21 October 2016 at 00:37, Mark Rutland <mark.rutl...@arm.com> wrote: >>> Hi, >>> >>> As a heads-up,

Re: [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver

2016-10-26 Thread Fu Wei
Hi Marc, On 26 October 2016 at 20:11, Marc Zyngier wrote: > On 26/10/16 12:10, Fu Wei wrote: >> Hi Mark, >> >> On 21 October 2016 at 00:37, Mark Rutland wrote: >>> Hi, >>> >>> As a heads-up, on v4.9-rc1 I see conflicts at least against >>&g

Re: [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver

2016-10-26 Thread Fu Wei
; >> + return -EINVAL; >> + } >> + acpi_gtdt_desc.platform_timer_start = start; >> + >> + return gtdt->platform_timer_count; >> +} > > This is never used as anything other than a status code. > > Just return zero; we haven't parsed the platform timers themselves at > this point anyway. Sorry, in my driver, I use this return value to inform driver negative number : error 0 : we don't have platform timer in GTDT table. positive number: the number of platform timer we have in GTDT table. please correct me, if I am doing it in wrong way. Thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver

2016-10-26 Thread Fu Wei
turn -EINVAL; >> + } >> + acpi_gtdt_desc.platform_timer_start = start; >> + >> + return gtdt->platform_timer_count; >> +} > > This is never used as anything other than a status code. > > Just return zero; we haven't parsed the platform timers themselves at > this point anyway. Sorry, in my driver, I use this return value to inform driver negative number : error 0 : we don't have platform timer in GTDT table. positive number: the number of platform timer we have in GTDT table. please correct me, if I am doing it in wrong way. Thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-10-26 Thread Fu Wei
Hi Mark On 26 October 2016 at 18:51, Mark Rutland <mark.rutl...@arm.com> wrote: > On Wed, Oct 26, 2016 at 04:31:55PM +0800, Fu Wei wrote: >> On 20 October 2016 at 22:45, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On Thu, Sep 29, 2016 at 02:17:09AM

Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-10-26 Thread Fu Wei
Hi Mark On 26 October 2016 at 18:51, Mark Rutland wrote: > On Wed, Oct 26, 2016 at 04:31:55PM +0800, Fu Wei wrote: >> On 20 October 2016 at 22:45, Mark Rutland wrote: >> > On Thu, Sep 29, 2016 at 02:17:09AM +0800, fu@linaro.org wrote: >> >> #include >>

Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

2016-10-26 Thread Fu Wei
lags. >> >> Please ignore this point; sorry for the noise. > > Actually, I misread the spec this time around; the flag *can* differ per > interrupt for the sysreg/cp15 timer, but not for the MMIO timers where > the flag is in a common field. > > So please *do* consider the above. yes , you are right , will do Thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

2016-10-26 Thread Fu Wei
;> Please ignore this point; sorry for the noise. > > Actually, I misread the spec this time around; the flag *can* differ per > interrupt for the sysreg/cp15 timer, but not for the MMIO timers where > the flag is in a common field. > > So please *do* consider the above. yes , you are right , will do Thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-10-26 Thread Fu Wei
For ARCH_TIMER_TYPE_*, maybe I should add a patch at the end of this patchset to fix it, OK ? Thanks for ACK :-) > > Thanks, > Mark. > >> + >> #define ARCH_TIMER_PHYS_ACCESS 0 >> #define ARCH_TIMER_VIRT_ACCESS 1 >> #define ARCH_TIMER_MEM_PHYS_ACCESS 2 >> -- >> 2.7.4 >> -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-10-26 Thread Fu Wei
t the end of this patchset to fix it, OK ? Thanks for ACK :-) > > Thanks, > Mark. > >> + >> #define ARCH_TIMER_PHYS_ACCESS 0 >> #define ARCH_TIMER_VIRT_ACCESS 1 >> #define ARCH_TIMER_MEM_PHYS_ACCESS 2 >> -- >> 2.7.4 >> -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code

2016-10-26 Thread Fu Wei
ARCH_MEM_TIMER) ? "/" : "", >> + type & ARCH_MEM_TIMER ? >> + arch_timer_mem_use_virtual ? "virt" : "phys" : >> + ""); > > ... and these two. > > No matter what checkpatch says, I prefer the cod

Re: [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code

2016-10-26 Thread Fu Wei
: "", >> + type & ARCH_MEM_TIMER ? >> + arch_timer_mem_use_virtual ? "virt" : "phys" : >> + ""); > > ... and these two. > > No matter what checkpatch says, I prefer the code that way so as to keep > the ternary clear. yes, NP, I have fixed it :-) > > [...] > >> @@ -768,7 +769,7 @@ static int __init arch_timer_init(void) >> return ret; >> >> arch_timer_kvm_info.virtual_irq = arch_timer_ppi[VIRT_PPI]; >> - >> + > > Please mention the whitespace fixup in the commit message. It's > surprising otherwise. OK, added this message. > > With all that: > > Acked-by: Mark Rutland Great thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-10-26 Thread Fu Wei
X_TIMER_SPI >> +}; > > Please rename this to arch_timer_spi_nr (as with patch 1 for > s/ppi_nr/arch_timer_ppi_nr/). With that: > > Acked-by: Mark Rutland <mark.rutl...@arm.com> OK, NP, done :-) Great thanks! > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-10-26 Thread Fu Wei
gt; Please rename this to arch_timer_spi_nr (as with patch 1 for > s/ppi_nr/arch_timer_ppi_nr/). With that: > > Acked-by: Mark Rutland OK, NP, done :-) Great thanks! > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat

Re: [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-10-26 Thread Fu Wei
016 at 02:17:08AM +0800, fu@linaro.org wrote: >> > > From: Fu Wei <fu@linaro.org> >> > >> > > This patchset depends on the following patchset: >> > > [UPDATE PATCH V11 1/8] ACPI: I/O Remapping Table (IORT) initial support >> > > ht

Re: [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-10-26 Thread Fu Wei
Hi Mark On 20 October 2016 at 23:17, Mark Rutland wrote: > On Thu, Oct 20, 2016 at 03:57:52PM +0100, Lorenzo Pieralisi wrote: >> On Thu, Oct 20, 2016 at 03:31:01PM +0100, Mark Rutland wrote: >> > Hi, >> > >> > On Thu, Sep 29, 2016 at 02:17:08AM +0800, fu....@l

Re: [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-10-05 Thread Fu Wei
Hi Xiongfeng Wang, On 30 September 2016 at 08:40, Xiongfeng Wang <wangxiongfe...@huawei.com> wrote: > for sbsa watchdog part, Tested-by: wangxiongfe...@huawei.com on D05 board. Got it, thanks again for your help > > On 2016/9/29 2:17, fu@linaro.org wrote: >

Re: [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-10-05 Thread Fu Wei
Hi Xiongfeng Wang, On 30 September 2016 at 08:40, Xiongfeng Wang wrote: > for sbsa watchdog part, Tested-by: wangxiongfe...@huawei.com on D05 board. Got it, thanks again for your help > > On 2016/9/29 2:17, fu@linaro.org wrote: >> From: Fu Wei >> >> This patc

Re: [PATCH v12 0/8] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-09-29 Thread Fu Wei
Hi Wang Xiongfeng On 29 September 2016 at 16:33, wangxiongfeng (C) <wangxiongfe...@huawei.com> wrote: > for sbsa watchdog part, Tested-by: wangxiongfe...@huawei.com on D05 board. Great thanks for your testing. :-) > > On 2016/9/13 18:38, fu@linaro.org wrote: >

Re: [PATCH v12 0/8] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-09-29 Thread Fu Wei
Hi Wang Xiongfeng On 29 September 2016 at 16:33, wangxiongfeng (C) wrote: > for sbsa watchdog part, Tested-by: wangxiongfe...@huawei.com on D05 board. Great thanks for your testing. :-) > > On 2016/9/13 18:38, fu@linaro.org wrote: >> From: Fu Wei >> >&g

[PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch refactor original memory-mapped timer init code: (1) extract some subfunction for reusing some common code a. get_cnttidr b. is_best_frame (2) move base address and irq code for arch_timer_mem to arch_timer_mem_register Signed-off-by: Fu W

[PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

2016-09-28 Thread fu . wei
From: Fu Wei The patch refactor original memory-mapped timer init code: (1) extract some subfunction for reusing some common code a. get_cnttidr b. is_best_frame (2) move base address and irq code for arch_timer_mem to arch_timer_mem_register Signed-off-by: Fu Wei --- drivers

[PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch defines pr_fmt(fmt) for all pr_* functions, then the pr_* doesn't need to add "arch_timer:" everytime. Also delete some Blank Spaces in arch_timer_banner, according to the suggestion from checkpatch.pl. No functional change. Signed-of

[PATCH v14 9/9] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> This driver adds support for parsing SBSA Generic Watchdog timer in GTDT, parse all info in SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the re

[PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code

2016-09-28 Thread fu . wei
From: Fu Wei This patch defines pr_fmt(fmt) for all pr_* functions, then the pr_* doesn't need to add "arch_timer:" everytime. Also delete some Blank Spaces in arch_timer_banner, according to the suggestion from checkpatch.pl. No functional change. Signed-off-by: Fu Wei --

[PATCH v14 9/9] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver

2016-09-28 Thread fu . wei
From: Fu Wei This driver adds support for parsing SBSA Generic Watchdog timer in GTDT, parse all info in SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the resource of platform device

[PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> To support the arm_arch_timer via ACPI we need to share defines and enums between the driver and the ACPI parser code. Split out the relevant defines and enums into arm_arch_timer.h. No functional change. Signed-off-by: Fu Wei <fu@linaro.org>

[PATCH v14 8/9] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch add memory-mapped timer register support by using the information provided by the new GTDT driver of ACPI. Signed-off-by: Fu Wei <fu@linaro.org> --- drivers/clocksource/arm_arch_timer.c | 92 +--- 1 file

[PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch adds support for parsing arch timer in GTDT, provides some kernel APIs to parse all the PPIs and always-on info in GTDT and export them. By this driver, we can simplify arm_arch_timer drivers, and separate the ACPI GTDT knowledge from it. Sign

[PATCH v14 8/9] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-09-28 Thread fu . wei
From: Fu Wei The patch add memory-mapped timer register support by using the information provided by the new GTDT driver of ACPI. Signed-off-by: Fu Wei --- drivers/clocksource/arm_arch_timer.c | 92 +--- 1 file changed, 85 insertions(+), 7 deletions(-) diff

[PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver

2016-09-28 Thread fu . wei
From: Fu Wei This patch adds support for parsing arch timer in GTDT, provides some kernel APIs to parse all the PPIs and always-on info in GTDT and export them. By this driver, we can simplify arm_arch_timer drivers, and separate the ACPI GTDT knowledge from it. Signed-off-by: Fu Wei Signed

[PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-09-28 Thread fu . wei
From: Fu Wei To support the arm_arch_timer via ACPI we need to share defines and enums between the driver and the ACPI parser code. Split out the relevant defines and enums into arm_arch_timer.h. No functional change. Signed-off-by: Fu Wei --- drivers/clocksource/arm_arch_timer.c | 11

[PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei <fu@linaro.or

[PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

2016-09-28 Thread fu . wei
From: Fu Wei The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei Signed-off-by: Hanjun Guo --- drivers

[PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> On platforms booting with ACPI, architected memory-mapped timers' configuration data is provided by firmware through the ACPI GTDT static table. The clocksource architected timer kernel driver requires a firmware interface to collect timer configu

[PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver

2016-09-28 Thread fu . wei
From: Fu Wei On platforms booting with ACPI, architected memory-mapped timers' configuration data is provided by firmware through the ACPI GTDT static table. The clocksource architected timer kernel driver requires a firmware interface to collect timer configuration and configure its driver

[PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patchset: (1)Preparation for adding GTDT support in arm_arch_timer: 1. Move some enums and marcos to header file; 2. Add a new enum for spi type; 3. Improve printk relevant code. (2)Introduce ACPI GTDT parser: driver

[PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-09-28 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch add a new enum "spi_nr" and use it in the driver. Just for code's readability, no functional change. Signed-off-by: Fu Wei <fu@linaro.org> --- drivers/clocksource/arm_arch_timer.c | 4 ++-- include/clocksource/arm_arch_timer

[PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer

2016-09-28 Thread fu . wei
From: Fu Wei This patchset: (1)Preparation for adding GTDT support in arm_arch_timer: 1. Move some enums and marcos to header file; 2. Add a new enum for spi type; 3. Improve printk relevant code. (2)Introduce ACPI GTDT parser: drivers/acpi/arm64/acpi_gtdt.c

[PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-09-28 Thread fu . wei
From: Fu Wei This patch add a new enum "spi_nr" and use it in the driver. Just for code's readability, no functional change. Signed-off-by: Fu Wei --- drivers/clocksource/arm_arch_timer.c | 4 ++-- include/clocksource/arm_arch_timer.h | 6 ++ 2 files changed, 8 insertions(+), 2

Re: [PATCH v13 7/8] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-09-15 Thread Fu Wei
HI On 15 September 2016 at 04:09, <fu@linaro.org> wrote: > From: Fu Wei <fu@linaro.org> > > The patch add memory-mapped timer register support by using the information > provided by the new GTDT driver of ACPI. > Also refactor original memory-mapped timer

Re: [PATCH v13 7/8] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-09-15 Thread Fu Wei
HI On 15 September 2016 at 04:09, wrote: > From: Fu Wei > > The patch add memory-mapped timer register support by using the information > provided by the new GTDT driver of ACPI. > Also refactor original memory-mapped timer dt support for reusing some common > code. > &g

[PATCH v13 8/8] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver

2016-09-14 Thread fu . wei
From: Fu Wei <fu@linaro.org> This driver adds support for parsing SBSA Generic Watchdog timer in GTDT, parse all info in SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the re

[PATCH v13 8/8] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver

2016-09-14 Thread fu . wei
From: Fu Wei This driver adds support for parsing SBSA Generic Watchdog timer in GTDT, parse all info in SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the resource of platform device

[PATCH v13 7/8] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-09-14 Thread fu . wei
From: Fu Wei <fu@linaro.org> The patch add memory-mapped timer register support by using the information provided by the new GTDT driver of ACPI. Also refactor original memory-mapped timer dt support for reusing some common code. Signed-off-by: Fu Wei <fu@linaro.org>

[PATCH v13 7/8] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer

2016-09-14 Thread fu . wei
From: Fu Wei The patch add memory-mapped timer register support by using the information provided by the new GTDT driver of ACPI. Also refactor original memory-mapped timer dt support for reusing some common code. Signed-off-by: Fu Wei --- drivers/clocksource/arm_arch_timer.c | 238

[PATCH v13 4/8] acpi/arm64: Add GTDT table parse driver

2016-09-14 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch adds support for parsing arch timer in GTDT, provides some kernel APIs to parse all the PPIs and always-on info in GTDT and export them. By this driver, we can simplify arm_arch_timer drivers, and separate the ACPI GTDT knowledge from it. Sign

[PATCH v13 6/8] acpi/arm64: Add memory-mapped timer support in GTDT driver

2016-09-14 Thread fu . wei
From: Fu Wei <fu@linaro.org> On platforms booting with ACPI, architected memory-mapped timers' configuration data is provided by firmware through the ACPI GTDT static table. The clocksource architected timer kernel driver requires a firmware interface to collect timer configu

[PATCH v13 1/8] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

2016-09-14 Thread fu . wei
From: Fu Wei <fu@linaro.org> To support the arm_arch_timer via ACPI we need to share defines and enums between the driver and the ACPI parser code. Split out the relevant defines and enums into arm_arch_timer.h. No functional change. Signed-off-by: Fu Wei <fu@linaro.org>

[PATCH v13 2/8] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

2016-09-14 Thread fu . wei
From: Fu Wei <fu@linaro.org> This patch add a new enum "spi_nr" and use it in the driver. Just for code's readability, no functional change. Signed-off-by: Fu Wei <fu@linaro.org> --- drivers/clocksource/arm_arch_timer.c | 4 ++-- include/clocksource/arm_arch_timer

[PATCH v13 4/8] acpi/arm64: Add GTDT table parse driver

2016-09-14 Thread fu . wei
From: Fu Wei This patch adds support for parsing arch timer in GTDT, provides some kernel APIs to parse all the PPIs and always-on info in GTDT and export them. By this driver, we can simplify arm_arch_timer drivers, and separate the ACPI GTDT knowledge from it. Signed-off-by: Fu Wei Signed

[PATCH v13 6/8] acpi/arm64: Add memory-mapped timer support in GTDT driver

2016-09-14 Thread fu . wei
From: Fu Wei On platforms booting with ACPI, architected memory-mapped timers' configuration data is provided by firmware through the ACPI GTDT static table. The clocksource architected timer kernel driver requires a firmware interface to collect timer configuration and configure its driver

<    1   2   3   4   5   6   7   8   9   10   >