2013/11/6 Steven Rostedt rost...@goodmis.org:
Sorry for the late review, I was busy getting ready for kernel summit
and then traveling too much.
No problem.
On Fri, 18 Oct 2013 17:59:42 -0300
Geyslan G. Bem geys...@gmail.com wrote:
In 'system_tr_open()':
Fix possible 'dir' assignment
2013/11/6 Steven Rostedt rost...@goodmis.org:
On Wed, 6 Nov 2013 16:02:51 -0300
Geyslan G. Bem geys...@gmail.com wrote:
In 'system_tr_open()':
Fix possible 'dir' assignment after freeing it.
I'll take this patch, but I'm going to reword the subject and the
change log. The assignment of
Please, disregard this due to problems reversing the commit.
I'll send the entire one soon.
Geyslan Gregório Bem
hackingbits.com
2013/9/18 Geyslan G. Bem geys...@gmail.com:
ia32_aout had no safe checks concerning the mmap and f_op in this module.
It's not necessary to verify f_op
Now it's ok.
Geyslan Gregório Bem
hackingbits.com
2013/9/18 Geyslan G. Bem geys...@gmail.com:
ia32_aout had no safe checks concerning the mmap and f_op in this module.
It's not necessary to verify f_op in the load_aout_library, since the
prior kernel_read/vfs_read function already does
more time.
Regards,
Geyslan Gregório Bem
hackingbits.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
more time.
Regards,
Geyslan Gregório Bem
hackingbits.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
2013/10/16 Takashi Iwai ti...@suse.de:
At Wed, 16 Oct 2013 13:21:45 -0300,
Geyslan G. Bem wrote:
Casting (void *) value returned by kcalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
You missed __user prefix. You can't
2013/10/16 Dmitry Torokhov dmitry.torok...@gmail.com:
Hi Geyslan,
On Wed, Oct 16, 2013 at 01:05:12PM -0300, Geyslan G. Bem wrote:
Casting (void *) value returned by kzalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
2013/10/16 Geyslan Gregório Bem geys...@gmail.com:
2013/10/16 Takashi Iwai ti...@suse.de:
At Wed, 16 Oct 2013 13:21:45 -0300,
Geyslan G. Bem wrote:
Casting (void *) value returned by kcalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G. Bem geys
2013/10/16 Joe Perches j...@perches.com:
On Wed, 2013-10-16 at 19:31 -0300, Geyslan G. Bem wrote:
Get rid of unnecessary (void *) casting in 'cypress_init' function.
[]
diff --git a/drivers/input/mouse/cypress_ps2.c
b/drivers/input/mouse/cypress_ps2.c
[]
@@ -680,7 +680,7 @@ int
2013/10/16 Greg KH gre...@linuxfoundation.org:
On Wed, Oct 16, 2013 at 12:57:35PM -0300, Geyslan G. Bem wrote:
Casting (void *) value returned by kzalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
2013/10/16 Tyler Hicks tyhi...@canonical.com:
On 2013-10-11 16:49:16, Geyslan G. Bem wrote:
In 'decrypt_pki_encrypted_session_key' function:
Initializes 'payload' pointer and releases it on exit.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
Thanks! This one was easy to verify by
2013/10/16 Geyslan Gregório Bem geys...@gmail.com:
2013/10/16 Greg KH gre...@linuxfoundation.org:
On Wed, Oct 16, 2013 at 12:57:35PM -0300, Geyslan G. Bem wrote:
Casting (void *) value returned by kzalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G
2013/10/16 Geyslan G. Bem geys...@gmail.com:
Casting (void *) value returned by kmalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
drivers/staging/dgap/dgap_parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
2013/10/17 Takashi Iwai ti...@suse.de:
At Wed, 16 Oct 2013 19:11:21 -0300,
Geyslan G. Bem wrote:
Partially restructures _snd_emu10k1_audigy_init_efx() and
_snd_emu10k1_init_efx() functions.
Removes useless casting (void *) from value returned by kcalloc;
see Documentation/CodingStyle, Chap
2013/10/17 Takashi Iwai ti...@suse.de:
At Thu, 17 Oct 2013 08:13:32 -0300,
Geyslan Gregório Bem wrote:
2013/10/17 Takashi Iwai ti...@suse.de:
At Wed, 16 Oct 2013 19:11:21 -0300,
Geyslan G. Bem wrote:
Partially restructures _snd_emu10k1_audigy_init_efx() and
_snd_emu10k1_init_efx
2013/10/17 Raphael S Carvalho raphael.sc...@gmail.com:
2013/10/17 Takashi Iwai ti...@suse.de:
Geyslan, you don't have to waste too much of your time (and my time
for review) for this kind of so old driver code unless it really fixes
the bugs. A clean up is good in general, but it can be
2013/10/17 Steven Rostedt rost...@goodmis.org:
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
Restructures function logic conditions testing 'tracing_open_generic'
return before the others. It avoids: unnecessary trace_array_get and
kzalloc when tracing is
2013/10/18 Geyslan Gregório Bem geys...@gmail.com:
2013/10/17 Steven Rostedt rost...@goodmis.org:
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
Restructures function logic conditions testing 'tracing_open_generic'
return before the others. It avoids: unnecessary
2013/10/18 Steven Rostedt rost...@goodmis.org:
On Fri, 18 Oct 2013 17:59:41 -0300
Geyslan G. Bem geys...@gmail.com wrote:
This patch creates the function 'tracing_is_disabled , which
can be used outside trace.c.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
kernel/trace/trace.c | 5
to be there indeed?
Let me know what was intended here.
Same here:
/net/sctp/endpointola.c (165)
static void sctp_transport_destroy_rcu(struct rcu_head *head)
{
struct sctp_transport *transport;
...
kfree(transport);
SCTP_DBG_OBJCNT_DEC(transport);
}
Regards,
Geyslan Gregório Bem
hackingbits.com
2013/10/19 Geyslan Gregório Bem geys...@gmail.com:
Hi maintainers,
I would like to know if these are catches:
/net/sctp/endpointola.c (281)
static void sctp_endpoint_destroy(struct sctp_endpoint *ep)
{
struct sock *sk;
...
kfree(ep);
SCTP_DBG_OBJCNT_DEC(ep);
}
The 'ep
2013/10/19 Oleg Nesterov o...@redhat.com:
On 10/17, Steven Rostedt wrote:
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
and fix the possible 'dir'
assignment after freeing it.
This should be safe afaics, nobody will use it anyway. Even
subsystem_release()
2013/10/19 Oleg Nesterov o...@redhat.com:
On 10/19, Geyslan Gregório Bem wrote:
2013/10/19 Oleg Nesterov o...@redhat.com:
On 10/17, Steven Rostedt wrote:
I'm thinking of just nuking the tracing_open_generic() here. The only
thing it does here is the tracing_disabled check
2013/10/19 Steven Rostedt rost...@goodmis.org:
On Sat, 19 Oct 2013 11:41:10 -0300
Geyslan Gregório Bem geys...@gmail.com wrote:
Let's wait Steve's reply about further use of tracing_is_disabled().
Might want to ping me later. This weekend I'm taking my daughter to
colleges, and early Monday
2013/10/19 David Miller da...@davemloft.net:
From: Geyslan G. Bem geys...@gmail.com
Date: Sat, 19 Oct 2013 10:09:31 -0300
This patch moves the '!err' condition into the above else scope,
what is more obvious and has the secondary goal of avoid false-positives
in statical analyze tools.
2013/10/19 David Miller da...@davemloft.net:
From: Geyslan Gregório Bem geys...@gmail.com
Date: Sat, 19 Oct 2013 19:42:35 -0300
2013/10/19 David Miller da...@davemloft.net:
From: Geyslan G. Bem geys...@gmail.com
Date: Sat, 19 Oct 2013 10:09:31 -0300
This patch moves the '!err' condition
At first, thanks for reply.
2013/10/20 Eric Van Hensbergen eri...@gmail.com:
On Sat, Sep 28, 2013 at 6:32 PM, Geyslan G. Bem geys...@gmail.com wrote:
In case of error in the p9_client_write, the function v9fs_fid_xattr_set
should return its negative value, what was never being done.
2013/10/20 Eric Van Hensbergen eri...@gmail.com:
I reckon we should probably just get rid of name if its not being used. I
doubt the indirection is going to hurt anything here.
-eric
Eric, you're right. Once that there's not assignment to name, the
cycles are the same.
I'll get rid of
.
For the other patches, anyone you didn't see a response from me on today is
being pulled into my for-next queue. Thanks for the cleanups.
-eric
Thanks for accept them.
On Mon, Oct 7, 2013 at 7:18 PM, Geyslan Gregório Bem geys...@gmail.com
wrote:
Joe,
Nice, I'll wait their reply
2013/11/21 Geyslan Gregório Bem geys...@gmail.com:
2013/11/20 Al Viro v...@zeniv.linux.org.uk:
On Wed, Nov 20, 2013 at 09:34:31PM -0300, Geyslan G. Bem wrote:
The member 'e_ehsize' that holds the ELF header size is compared
with the elfhdr struct size. If not equal, goes out.
If 'e_phoff
Coverity caught double free possibility (CID 1130962).
I can patch this, but I have to know if is correct to free comp_opts
in the function squashfs_decompressor_create() or it had to be done in
the caller. My bet is the caller.
128void *squashfs_decompressor_setup(struct super_block *sb,
2013/11/22 Richard Weinberger richard.weinber...@gmail.com:
On Fri, Nov 22, 2013 at 10:50 PM, Geyslan Gregório Bem
geys...@gmail.com wrote:
Coverity caught double free possibility (CID 1130962).
Just wondering, where can one find/verify such CIDs?
--
Thanks,
//richard
Anyone can sign
2013/11/22 Phillip Lougher phil...@lougher.demon.co.uk:
On 22/11/13 21:50, Geyslan Gregório Bem wrote:
Coverity caught double free possibility (CID 1130962).
I can patch this, but I have to know if is correct to free comp_opts
in the function squashfs_decompressor_create() or it had
2013/10/11 Stefan Behrens sbehr...@giantdisaster.de:
On Thu, 10 Oct 2013 19:11:22 -0300, Geyslan G. Bem wrote:
In add_inode_ref() function:
Initializes local pointers.
Reduces the logical condition with the __add_inode_ref() return
value by using only one 'goto out'.
Centralizes the
2013/10/14 Geyslan G. Bem geys...@gmail.com:
Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
fs/nfs/callback.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/nfs/callback.c
2013/10/14 Geyslan G. Bem geys...@gmail.com:
Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
fs/nfs/nfs4super.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/nfs/nfs4super.c
Hi,
Coverity detected in 'arch/x86/kernel/cpu/perf_event_intel_uncore.c' a
possible reliance on integer endianness. Is that a positive one?
static u64 ivt_uncore_irp_read_counter(struct intel_uncore_box *box,
struct perf_event *event)
1369{
1370struct pci_dev *pdev = box-pci_dev;
1371
2013/11/12 Måns Rullgård m...@mansr.com:
Geyslan Gregório Bem geys...@gmail.com writes:
Hi,
Coverity detected in 'arch/x86/kernel/cpu/perf_event_intel_uncore.c' a
possible reliance on integer endianness. Is that a positive one?
No, x86 is always little endian.
static u64
2013/11/12 Peter Zijlstra pet...@infradead.org:
On Tue, Nov 12, 2013 at 12:19:13PM -0200, Geyslan Gregório Bem wrote:
Cc: kernel...@googlegroups.com
Don't cross-post to lists that don't allow public posts, and very much
don't cross-post to lists that bounce in incomprehensible gibberish
Hello,
Coverity detected in 'fs/gfs2/glock.c' a possible dereference after
null check. Maybe a positive one.
There is a initial check for possible 'gl' NULL. After that 'gl' is
dereferenced in the looping check by __lockref_is_dead().
What do you think?
1875static int
2013/11/12 Steven Whitehouse swhit...@redhat.com:
Hi,
On Tue, 2013-11-12 at 12:53 -0200, Geyslan Gregório Bem wrote:
Hello,
Coverity detected in 'fs/gfs2/glock.c' a possible dereference after
null check. Maybe a positive one.
There is a initial check for possible 'gl' NULL. After that 'gl
2013/11/14 Tyler Hicks tyhi...@canonical.com:
On 2013-11-14 15:42:14, Geyslan G. Bem wrote:
If the condition 'ecryptfs_file_to_private(file)' takes false branch
lower_file is dereferenced when NULL.
Caught by Coverity: CIDs 1128834 and 1128833.
Signed-off-by: Geyslan G. Bem
2013/11/14 Tyler Hicks tyhi...@canonical.com:
On 2013-11-14 17:58:40, Geyslan Gregório Bem wrote:
2013/11/14 Tyler Hicks tyhi...@canonical.com:
On 2013-11-14 15:42:14, Geyslan G. Bem wrote:
If the condition 'ecryptfs_file_to_private(file)' takes false branch
lower_file is dereferenced when
2013/11/14 Geyslan G. Bem geys...@gmail.com:
If 'hsr_get_node_data()' returns error, going directly to 'fail' label
doesn't free the memory pointed by 'skb_out'.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
net/hsr/hsr_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
2013/11/15 Caizhiyong caizhiy...@hisilicon.com:
From: Cai Zhiyong caizhiy...@huawei.com
Date: Mon, 11 Nov 2013 19:26:14 +0800
Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value
This patch give a warning when calling regmap_register_patch with
parameter num_regs = 0.
2013/11/15 Levente Kurusa le...@linux.com:
2013-11-15 14:00 keltezéssel, Geyslan Gregório Bem írta:
2013/11/15 Caizhiyong caizhiy...@hisilicon.com:
From: Cai Zhiyong caizhiy...@huawei.com
Date: Mon, 11 Nov 2013 19:26:14 +0800
Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized
2013/11/15 Mark Brown broo...@kernel.org:
On Fri, Nov 15, 2013 at 01:52:19PM -0200, Geyslan Gregório Bem wrote:
+ if (WARN_ONCE(num_regs = 0, number of registers [%d] must be
major than 0, num_regs))
+ return 0;
must be more than but yes.
Tks. Sorry for my poor english
Hi guys,
In the function msgin_qtag() [line 2632], this dereference was intentional?
static struct ScsiReqBlk *msgin_qtag(struct AdapterCtlBlk *acb,
struct DeviceCtlBlk *dcb, u8 tag)
{
struct ScsiReqBlk *srb = NULL;
struct ScsiReqBlk *i;
dprintkdbg(DBG_0, msgin_qtag: (0x%p)
Hello Benjamin,
In file 'windfarm_pm121'.c:
If this branch is true:
if (param == NULL) {
printk(KERN_WARNING pm121: %s fan config not found
for this machine model\n,
loop_names[loop_id]);
goto fail;
}
control that is NULL will suffer a
2013/11/17 James Bottomley james.bottom...@hansenpartnership.com:
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote:
This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and
'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when
necessary.
You pointlessly
2013/11/17 James Bottomley james.bottom...@hansenpartnership.com:
On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote:
2013/11/17 James Bottomley james.bottom...@hansenpartnership.com:
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote:
This patch fix memory leakage in cases
2013/11/18 Caizhiyong caizhiy...@hisilicon.com:
From: Cai Zhiyong caizhiy...@huawei.com
Date: Mon, 18 Nov 2013 20:21:49 +0800
Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value
This patch give a warning when calling regmap_register_patch with
parameter num_regs = 0.
2013/11/18 James Bottomley james.bottom...@hansenpartnership.com:
On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote:
2013/11/17 James Bottomley james.bottom...@hansenpartnership.com:
On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote:
2013/11/17 James Bottomley
2013/11/18 James Bottomley james.bottom...@hansenpartnership.com:
On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote:
2013/11/18 James Bottomley james.bottom...@hansenpartnership.com:
On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote:
2013/11/17 James Bottomley
2013/11/18 Geyslan Gregório Bem geys...@gmail.com:
2013/11/18 James Bottomley james.bottom...@hansenpartnership.com:
On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote:
2013/11/18 James Bottomley james.bottom...@hansenpartnership.com:
On Sun, 2013-11-17 at 23:12 -0200, Geyslan
This patch add the specification System V Application Binary Interface
reference to header comment.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
fs/binfmt_elf.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index
2013/11/20 Geyslan G. Bem geys...@gmail.com:
The member 'e_ehsize' that holds the ELF header size is compared
with the elfhdr struct size. If not equal, goes out.
If 'e_phoff' holds 0 the object has no program header table, so
goes out.
Increasing the binary consistency reduces the use of
2013/11/20 Al Viro v...@zeniv.linux.org.uk:
On Wed, Nov 20, 2013 at 09:34:31PM -0300, Geyslan G. Bem wrote:
The member 'e_ehsize' that holds the ELF header size is compared
with the elfhdr struct size. If not equal, goes out.
If 'e_phoff' holds 0 the object has no program header table, so
2013/10/28 Geyslan Gregório Bem geys...@gmail.com:
2013/10/28 Geyslan Gregório Bem geys...@gmail.com
2013/10/27 Eric Van Hensbergen eri...@gmail.com
Looks like the right approach. The one other optional thing I mentioned
was support for passing NULL for rdev and not trying to parse
2013/10/30 Matt Fleming m...@console-pimps.org:
On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote:
This reorganization:
Adds 'attrsize' variable to make the code cleaner and more
understandable, replacing all 'sizeof(attributes)'.
Removes 'bytes' prior assignment due this new approach.
2013/10/30 Matt Fleming m...@console-pimps.org:
On Wed, 30 Oct, at 10:44:16AM, Geyslan Gregório Bem wrote:
Do you want that I undo that? I aggre that the variable use only
reduces the line code.
Yes please.
--
Matt Fleming, Intel Open Source Technology Center
Done:
[PATCH v2] efivarfs
2013/10/31 Ben Myers b...@sgi.com:
Hey Geyslan,
On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote:
On 10/23/13 3:34 PM, Ben Myers wrote:
xfs: fix possible NULL dereference in xlog_verify_iclog
In xlog_verify_iclog a debug check of the incore log buffers prints an
error if
2013/10/21 Geyslan Gregório Bem geys...@gmail.com:
2013/10/20 Eric Van Hensbergen eri...@gmail.com:
I reckon we should probably just get rid of name if its not being used. I
doubt the indirection is going to hurt anything here.
-eric
Eric, you're right. Once that there's
2013/10/21 Geyslan Gregório Bem geys...@gmail.com:
At first, thanks for reply.
2013/10/20 Eric Van Hensbergen eri...@gmail.com:
On Sat, Sep 28, 2013 at 6:32 PM, Geyslan G. Bem geys...@gmail.com wrote:
In case of error in the p9_client_write, the function v9fs_fid_xattr_set
should return its
2013/10/21 Geyslan G. Bem geys...@gmail.com:
In case of error in the p9_client_write, the function v9fs_fid_xattr_set
should return its negative value, what was never being done.
In case of success it only retuned 0. Now it returns the 'offset'
variable (write_count total).
Signed-off-by:
2013/10/21 Geyslan Gregório Bem geys...@gmail.com:
2013/10/20 Eric Van Hensbergen eri...@gmail.com:
Please resubmit a clean patch which includes the check of sscanf for exactly
the correct number of arguments and handles errors properly in other cases.
That last bit may be a bit problematic
2013/10/21 Dave Chinner da...@fromorbit.com:
On Mon, Oct 21, 2013 at 07:00:59PM -0500, Eric Sandeen wrote:
On 10/21/13 6:56 PM, Dave Chinner wrote:
On Mon, Oct 21, 2013 at 06:18:49PM -0500, Ben Myers wrote:
Hey,
On Mon, Oct 21, 2013 at 06:12:18PM -0500, Eric Sandeen wrote:
On 10/21/13
2013/10/21 Dirk Brandewie dirk.brande...@gmail.com:
On Monday, October 21, 2013, Rafael J. Wysocki wrote:
On Monday, October 21, 2013 03:43:51 PM Dirk Brandewie wrote:
On 10/21/2013 03:47 PM, Rafael J. Wysocki wrote:
On Monday, October 21, 2013 08:56:22 AM Dirk Brandewie wrote:
On
2013/10/21 Geyslan Gregório Bem geys...@gmail.com:
2013/10/21 Geyslan Gregório Bem geys...@gmail.com:
2013/10/20 Eric Van Hensbergen eri...@gmail.com:
Please resubmit a clean patch which includes the check of sscanf for exactly
the correct number of arguments and handles errors properly
2013/10/22 Eric Sandeen sand...@sandeen.net:
On 10/22/13 4:03 PM, Dave Chinner wrote:
On Tue, Oct 22, 2013 at 03:49:01PM -0500, Eric Sandeen wrote:
On 10/22/13 3:39 PM, Dave Chinner wrote:
On Tue, Oct 22, 2013 at 08:12:51AM -0200, Geyslan Gregório Bem wrote:
2013/10/21 Dave Chinner da
2013/10/23 Ben Myers b...@sgi.com:
Hey Geyslan,
On Wed, Oct 23, 2013 at 08:58:51AM -0200, Geyslan Gregório Bem wrote:
- Regarding the possible new patch subject, I humbly pass the ball to you.
Thank you for the attention.
Thank you for the patch. I would really prefer to commit
2013/10/28 Geyslan Gregório Bem geys...@gmail.com
2013/10/27 Eric Van Hensbergen eri...@gmail.com
Looks like the right approach. The one other optional thing I mentioned was
support for passing NULL for rdev and not trying to parse the device info
when rdev == NULL. Its a very slight
Felipe, thank you too.
I realized this after a code review.
Ben, what do you think?
Geyslan Gregório Bem
hackingbits.com
2013/10/7 Felipe Pena felipe...@gmail.com:
Hi,
On Mon, Oct 7, 2013 at 7:35 PM, Ben Skeggs bske...@redhat.com wrote:
- Original Message -
From: Geyslan G. Bem
Peter,
Yes, Really doesn't have leakage, I explained it. The changes are just
to cleanup the code following a secure pattern.
Geyslan Gregório Bem
hackingbits.com
2013/10/7 H. Peter Anvin h...@zytor.com:
On 10/07/2013 03:16 PM, Geyslan G. Bem wrote:
Even though the resource is released when
, minor);
Geyslan Gregório Bem
hackingbits.com
2013/10/7 Joe Perches j...@perches.com:
On Mon, 2013-10-07 at 19:19 -0300, Geyslan G. Bem wrote:
Changes the sign type to unsigned, avoiding the possibility of
wrap when ORing the p9 or unix bit modes.
[]
diff --git a/fs/9p/vfs_inode.c b/fs/9p
Joe,
Nice, I'll wait their reply, there are other p9 patches that I have
already sent and am awaiting Eric's.
Thank you again.
Geyslan Gregório Bem
hackingbits.com
2013/10/7 Joe Perches j...@perches.com:
On Mon, 2013-10-07 at 21:09 -0300, Geyslan Gregório Bem wrote:
Joe,
Thank you
2013/10/7 Joe Perches j...@perches.com:
On Mon, 2013-10-07 at 18:10 -0600, Bjorn Helgaas wrote:
On Mon, Oct 7, 2013 at 6:03 PM, Joe Perches j...@perches.com wrote:
On Mon, 2013-10-07 at 16:56 -0700, Andrew Morton wrote:
On Mon, 07 Oct 2013 16:45:23 -0700 Joe Perches j...@perches.com wrote:
Rather, the first member of nvbe is ttm (same address). Got it.
Please, disregard this patch. Thank you.
Geyslan Gregório Bem
hackingbits.com
2013/10/7 Ben Skeggs bske...@redhat.com:
- Original Message -
From: Geyslan Gregório Bem geys...@gmail.com
To: Felipe Pena felipe
Felipe, thank you,
Sending v2.
Geyslan Gregório Bem
hackingbits.com
2013/10/9 Felipe Pena felipe...@gmail.com:
Hi,
On Wed, Oct 9, 2013 at 8:13 PM, Geyslan G. Bem geys...@gmail.com wrote:
In some cases, add_inode_ref() is returning without freeing
the 'name' pointer.
Added bail out
Please,
Analyze [PATCH v3].
Regards,
Geyslan Gregório Bem
hackingbits.com
2013/10/9 Geyslan G. Bem geys...@gmail.com:
In some cases, add_inode_ref() is returning without freeing
the 'name' pointer.
Added bail out to explicitly call kfree when necessary.
Signed-off-by: Geyslan G. Bem
Josef,
Thank you. Sending v4.
Geyslan Gregório Bem
hackingbits.com
2013/10/9 Josef Bacik jba...@fusionio.com:
On Wed, Oct 09, 2013 at 08:40:30PM -0300, Geyslan G. Bem wrote:
In some cases, add_inode_ref() is returning without freeing
the 'name' pointer.
Added bail out to explicitly call
, reply.
Regards,
Geyslan Gregório Bem
hackingbits.com
2013/9/20 Geyslan G. Bem geys...@gmail.com:
file size used only once, so removed due its useless prior allocation.
It's not necessary to verify f_op in the load_aout_library, since the
prior kernel_read/vfs_read function already does.
Made
I would like to know when to do the NULL pointer checking.
Calling functions from different modules?
Calling functions in the same module?
Check again, after calling an outside function that already verifies
the pointer?
Always?
Best Regards,
Geyslan Gregório Bem
hackingbits.com
, lowstale,
highstale, lfloglow, lfloghigh);
The only place they are started up is within this condition:
L480:
if (compact)
xfs_dir3_leaf_compact_x1(leafhdr, ents, index, lowstale,
highstale, lfloglow, lfloghigh);
So, if it is not compact, both have garbage.
Best Regards.
Geyslan Gregório Bem
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem geys...@gmail.com:
file size used only once, so removed due its useless prior allocation.
It's not necessary to verify f_op in the load_aout_library, since the
prior kernel_read/vfs_read function
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem geys...@gmail.com:
Adjustment based on the checkpatch.pl.
Tested.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
fs/exec.c | 92
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem geys...@gmail.com:
ia32_aout had no safe checks concerning the mmap and f_op in this module.
It's not necessary to verify f_op in the load_aout_library, since the
prior kernel_read/vfs_read
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem geys...@gmail.com:
The *t variable in the fill_note_info function is only used if
siginfo-si_signo isn't 0. Moving t pointer to that inner scope.
Tested.
Signed-off-by: Geyslan G. Bem geys
Pavel,
Thank you.
Maintainers, is there some chance to fix it or a.out is really doomed?
2014-04-19 13:15 GMT-03:00 Pavel Machek pa...@ucw.cz:
Hi!
I was researching about old binary formats and did some tests.
Meantime, I was able to run sucessfully only the QMAGIC format.
Nonetheless,
Valdis,
2014-04-19 15:33 GMT-03:00 valdis.kletni...@vt.edu:
On Sat, 19 Apr 2014 13:37:27 -0300, Geyslan Gregório Bem said:
Maintainers, is there some chance to fix it or a.out is really doomed?
Is there an actual use case for a.out on a modern kernel?
Maybe retrocompatibility.
In other
Sirs,
I was researching about old binary formats and did some tests.
Meantime, I was able to run sucessfully only the QMAGIC format.
Nonetheless, the OMAGIC, NMAGIC and ZMAGIC didn't work anymore.
The test occurred using old slackware binaries and some new, the
latter compiled by me, using
Hello,
I have found a possible out of bounds reading in
arch/powerpc/kvm/book3s_64_mmu.c (kvmppc_mmu_book3s_64_xlate
function). pteg[] array could be accessed twice using the i variable
after the for iteration. What happens is that in the last iteration
the i index is incremented to 16, checked
2015-11-29 18:33 GMT-03:00 Paul Mackerras <pau...@ozlabs.org>:
> On Sun, Nov 29, 2015 at 05:14:03PM -0300, Geyslan Gregório Bem wrote:
>> Hello,
>>
>> I have found a possible out of bounds reading in
>> arch/powerpc/kvm/book3s_64_mmu.c (kvmppc_mmu_book3s_64_xlate
Hello,
I'm doing some static analysis and stumbled in this function
static void bitvector_process(struct seq_file *m, u64 vector)
{
int i,j;
static const char *units[]={ "", "K", "M", "G", "T" };
for (i=0, j=0; i < 64; i++ , j=i/10) {
if (vector & 0x1)
2013/11/6 Steven Rostedt :
> Sorry for the late review, I was busy getting ready for kernel summit
> and then traveling too much.
>
No problem.
>
> On Fri, 18 Oct 2013 17:59:42 -0300
> "Geyslan G. Bem" wrote:
>
>> In 'system_tr_open()':
>> Fix possible 'dir' assignment after freeing it.
>>
>> In
2013/11/6 Steven Rostedt :
> On Wed, 6 Nov 2013 16:02:51 -0300
> "Geyslan G. Bem" wrote:
>
>> In 'system_tr_open()':
>> Fix possible 'dir' assignment after freeing it.
>
> I'll take this patch, but I'm going to reword the subject and the
> change log. The assignment of dir to filp->private_data
2013/10/16 Takashi Iwai :
> At Wed, 16 Oct 2013 13:21:45 -0300,
> Geyslan G. Bem wrote:
>>
>> Casting (void *) value returned by kcalloc is useless
>> as mentioned in Documentation/CodingStyle, Chap 14.
>>
>> Signed-off-by: Geyslan G. Bem
>
> You missed __user prefix. You can't cast user and
2013/10/16 Dmitry Torokhov :
> Hi Geyslan,
>
> On Wed, Oct 16, 2013 at 01:05:12PM -0300, Geyslan G. Bem wrote:
>> Casting (void *) value returned by kzalloc is useless
>> as mentioned in Documentation/CodingStyle, Chap 14.
>>
>> Signed-off-by: Geyslan G. Bem
>> ---
>>
2013/10/16 Geyslan Gregório Bem :
> 2013/10/16 Takashi Iwai :
>> At Wed, 16 Oct 2013 13:21:45 -0300,
>> Geyslan G. Bem wrote:
>>>
>>> Casting (void *) value returned by kcalloc is useless
>>> as mentioned in Documentation/CodingStyle, Chap 14.
>&g
1 - 100 of 190 matches
Mail list logo
