Re: [PATCH]imx-drm coding style fixes

On 2014.09.19 01:57, Rene Kolarik wrote: Hello, I've fixed coding style issues in drivers/staging/imx-drm directory. This is a part of Eudyptula Challenge. Please submit your patches inline (look at /Documentation/SubmittingPatches section 7). Also, think about if it's worth seperating this

[PATCH] hid: Add a new id 0x501a for Genius MousePen i608X

-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- Only compile tested as I don't have this hardware to test it. drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-kye.c | 4 drivers/hid/usbhid/hid-quirks.c | 1 + 4 files changed, 7

Re: [PATCH] Sony-laptop: fix sparse warning

On 2015.02.05 16:49, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com

Re: [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten ahmad.hassan...@gmail.com

On 2015.01.19 01:38, Ahmadposten wrote: --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index f5cc78e..34e3a76 100644 ---

Re: [PATCH] sm750fb: Fix C99 Comments and if else braces

Hi Amitoj Kaur Chawla, On 2015.03.19 19:39, Amitoj Kaur Chawla wrote: The edits have been made to remove C99 Comments and properly indent the if-else statements in the file while taking care of the braces according to Linux coding style. Signed-off-by: Amitoj Kaur Chawla

Re: [PATCH] sm750fb: Fix Comment and if else braces

Hi Amitoj Kaur Chawla, On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: The edits have been made to add a space before the comment and the errors in braces in the if-else statements. Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed the C99 comments and errors in if-else

Re: [PATCH v2 1/7] dgnc: remove unused dgnc_ioctl_name() command

Greg, you probably missed these :) Could you look at these when you have some time? On 2015.03.13 15:56, Giedrius Statkevičius wrote: dgnc_ioctl_name() is never used anywhere so remove it Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Forgot to include

[PATCH] dgnc: Don't save boards in memory that have failed to initialize

where state was set to BOARD_FAILED which was even redundant before this patch. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 19 ++- drivers/staging/dgnc/dgnc_driver.h | 3 +-- drivers/staging/dgnc/dgnc_mgmt.c | 5

Re: [PATCH] dgnc: move more repeating code under 'failed' label

On 2015.03.09 15:06, Dan Carpenter wrote: Added Matteo to the CC list because he was working on this function as well and I remembered something I wanted to tell him. On Sun, Mar 08, 2015 at 07:46:37PM +0200, Giedrius Statkevičius wrote: Currently the label is only used to return a error

Re: [PATCH] dgnc: Don't save boards in memory that have failed to initialize

On 2015.03.09 17:27, Giedrius Statkevičius wrote: Remove BOARD_FAILED and don't save dgnc_boards which failed to initialize. Assign the result of kzalloc() to brd in dgnc_found_board() and only put it in the dgnc_Board[] if it successfully initializes. Also, remove BOARD_FAILED enum and all

[PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

where state was set to BOARD_FAILED which was even redundant before this patch. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Remove brd = dgnc_Board[dgnc_NumBoards]; line which I forgot to do in the first version drivers/staging/dgnc/dgnc_driver.c | 20

Re: [PATCH 2/3] Staging: dgnc: Use goto for error handling

On 2015.03.11 16:04, Quentin Lambert wrote: This patch introduces goto statments for error handling and in cases where a lock needs to be released. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @candidates exists@ identifier

Re: [PATCH 1/1] Drivers: Staging: ft1000: checkpatch warning fixes

On 2015.03.11 23:03, Janakarajan Natarajan wrote: Addition of blank line after declaration in ft1000_hw.c Minor changes to remove {} from single line if and remove extra parenthesis. Fixes checkpatch warning for asm/bitops.h and asm/io.h usage. Greg may complain that you've done too much in 1

[PATCH] dgnc: move more repeating code under 'failed' label

-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index fa1ee79..73ee667 100644 --- a/drivers/staging

Re: [PATCH] iee80211:Remove no longer required strutucre defintion, _STA_QOS in rtl819x_Qos.h

On 2015.03.06 23:20, Nicholas Krause wrote: Removes the no longer required structure definition,_STA_QOS due to no functions using any structures of this type anymore. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 48

[PATCH] dgnc: Remove redundant blank lines in dgnc_cls.c

There are a lot double of blank lines in dgnc_cls.c thus remove them to make the file follow the CodingStyle. Also, remove one blank line at the end of dgnc_cls.c. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c | 36

[PATCH 4/4] dgnc: Make all lines under 80 characters in dgnc_driver.h

Fix comments to make lines less than 80 characters by moving them, breaking the lines or making them neater. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_driver.h | 55 +- 1 file changed, 36 insertions

[PATCH] dgnc: Make all lines under 80 characters in dgnc_driver.c

Some of the lines are over 80 characters in dgnc_driver.c so fix them by moving the comments closer to the code, tidying the comments to make them smaller, and remove a redundant space after +. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc

[PATCH] dgnc: Make all lines under 80 characters in dgnc_cls.h

Some of the lines are over 80 characters so fix that by moving the comments before the struct definition and before #define's. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_cls.h | 40 1 file changed

[PATCH] Documentation/email-clients.txt: Fix one grammar mistake, add extra info about TB

to do it with gvim. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- Documentation/email-clients.txt | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index eede608..064eed5 100644

Re: [PATCH 4/4] dgnc: Make all lines under 80 characters in dgnc_driver.h

This one is bad. I've accidentally sent it, sorry. Don't pull/review this. On 2015.03.09 01:49, Giedrius Statkevičius wrote: Fix comments to make lines less than 80 characters by moving them, breaking the lines or making them neater. [...] -- Thanks, Giedrius -- To unsubscribe from

[PATCH] rt2x00: use rt2x00queue_flush_queues() instead of implementing the same action

. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/net/wireless/rt2x00/rt2x00mac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c index 300876d..5bc48c3 100644

Re: [PATCH 4/4] staging: sm750fb: fix undeclared function

On 2015.03.08 14:31, Sudip Mukherjee wrote: kbuild test robot reported that for microblaze-allyesconfig chan_to_field() and lynxfb_ops_set_par() were not defined. These two functions were defined under CONFIG_PM, so for any archtecture if CONFIG_PM is not defined we will have this error.

Re: [PATCH 1/4] staging: sm750fb: wrong type for print

On 2015.03.08 14:31, Sudip Mukherjee wrote: mention correct format specifier while printing Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- this patch will give checkpatch warnings about use of printk. this patch was mainly to fix the build warnings. printk will be converted to

Re: [PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID

On 2015.03.08 14:31, Sudip Mukherjee wrote: check if it is already defined before defining SM750LE_REVISION_ID again and at the same time mention correct data type. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- drivers/staging/sm750fb/ddk750_chip.h | 4 +++- 1 file changed, 3

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

Hi Greg, On 2015.03.12 12:08, Greg KH wrote: On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: Remove BOARD_FAILED and don't save dgnc_boards which failed to initialize. Assign the result of kzalloc() to brd in dgnc_found_board() and only put it in the dgnc_Board

[PATCH 1/3] dgnc: Remove unneeded dgnc_state array of strings

Dgnc_state array of strings is never used anywhere and it seems pretty useless anyway since the board state enum names speak for themselves. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 8 drivers/staging/dgnc

[PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro

to initialize and make sysfs files after initializing the board in dgnc_driver.c or IOW they are already set for successfully initialized boards before their sysfs files created (412 and 593 lines in dgnc_driver.c). Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers

[PATCH 3/3] dgnc: clean up comments at start of files

are responsible for these drivers - see TODO or MAINTAINERS for that. We can preserve the original copyright at the top of the most files because it shows who originally made them. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c | 16

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

On 2015.03.12 12:08, Greg KH wrote: On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: Remove BOARD_FAILED and don't save dgnc_boards which failed to initialize. Assign the result of kzalloc() to brd in dgnc_found_board() and only put it in the dgnc_Board

Re: [PATCH 10/10] mach-osiris-dvs.c : use (not ) with bool operands

On 2015.03.13 16:31, Ameen Ali wrote: itwise AND () was used in logical expressions with operands having bool type. Replaced bitwise AND operators with logical AND. Signed-off-by : ameenali...@gmail.com This line's messed up. The correct format is: Signed-off-by: Full name email Always use

[PATCH v2 1/7] dgnc: remove unused dgnc_ioctl_name() command

dgnc_ioctl_name() is never used anywhere so remove it Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Forgot to include this patch in the first version. Without this some of the other patches in this set will fail. drivers/staging/dgnc/dgnc_utils.c | 52

[PATCH v2 2/7] dgnc: clean up digi.h

Remove a lot of unused structs and defines from digi.h. We still have to be careful with TIOCM_LE and TIOCMSET/TIOCMBIC because termios.h and ioctls.h respectfully redefine them. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Updated commit msg and remove some more

[PATCH v2 7/7] dgnc: Clean up dgnc_sysfs.h

Remove redundant blank lines, move absolute include after relative include. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: no change drivers/staging/dgnc/dgnc_sysfs.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/dgnc

[PATCH v2 6/7] dgnc: remove unused stuff from dgnc_cls.h

Remove unused defines from dgnc_cls.h Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: No change drivers/staging/dgnc/dgnc_cls.h | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h index

[PATCH v2 5/7] dgnc: remove old 2.4-2.6 compat kernel defines

dgnc_kcompat.h contains some old legacy defines in case the kernel doesn't have __user defined but for current kernel versions these defines don't make sense and are useless so remove them. Move the TTY_FLIPBUF_SIZE define to digi.h because it's used in the code. Signed-off-by: Giedrius

[PATCH v2 4/7] dgnc: use linux/types.h instead of dgnc_types.h

Dgnc_types.h unnecesarily defines TRUE as 1 and FALSE as 0 because we already have a widely used linux/types.h so convert all TRUE to true, FALSE to false and edit the dgnc_board struct to make sure it uses bool. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- I'm still

[PATCH v2 3/7] dgnc: get rid of dpacompat.h, move remaining stuff to digi.h

Dpacompat.h contained a lot of unused #defines and only few things are used from it so since we've trimmed down digi.h, now we can delete dpacompat.h and move remaining stuff into digi.h. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: No change drivers/staging/dgnc

[PATCH 4/6] dgnc: remove old 2.4-2.6 compat kernel defines

dgnc_kcompat.h contains some old legacy defines in case the kernel doesn't have __user defined but for current kernel versions these defines don't make sense and are useless so remove them. Move the TTY_FLIPBUF_SIZE define to digi.h because it's used in the code. Signed-off-by: Giedrius

[PATCH 6/6] dgnc: Clean up dgnc_sysfs.h

Remove redundant blank lines, move absolute include after relative include. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_sysfs.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.h b

[PATCH 1/6] dgnc: clean up digi.h

/ioctls.h defines them too. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/digi.h | 235 1 file changed, 235 deletions(-) diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/dgnc/digi.h index 554fbeb

[PATCH 5/6] dgnc: remove unused stuff from dgnc_cls.h

Remove unused defines from dgnc_cls.h Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_cls.h | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h index 85042bd

[PATCH 2/6] dgnc: get rid of dpacompat.h, move remaining stuff to digi.h

Dpacompat.h contained a lot of unused #defines and only few things are used from it so since we've trimmed down digi.h, now we can delete dpacompat.h and move remaining stuff into digi.h. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c

Re: [PATCH 3/6] dgnc: convert TRUE/FALSE #defines to 1/0

On 2015.03.12 20:59, Dan Carpenter wrote: On Thu, Mar 12, 2015 at 08:14:25PM +0200, Giedrius Statkevičius wrote: TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it would be better to just use 1/0 to avoid unnecessary extra files and includes. Use true/false. I don't

[PATCH 3/6] dgnc: convert TRUE/FALSE #defines to 1/0

TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it would be better to just use 1/0 to avoid unnecessary extra files and includes. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_cls.h| 3 --- drivers/staging/dgnc

Re: [PATCH] mfd: rtsx: add support for rts522A

On Thu, 16 Apr 2015, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227. Add it to file mfd/rts5227.c to support this chip. Signed-off-by: Micky Ching micky_ch...@realsil.com.cn --- Maybe

Re: [PATCH v2 1/2 RESEND] staging: dgnc: remove dead code in dgnc_tty_write()

On Sat, 11 Apr 2015, Sudip Mukherjee wrote: On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote: Remove the dead code protected by in_user in dgnc_tty_write() because it is set to 0 and never changed to 1 thus the code in ifs never gets executed. dgnc_tty_write

[PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

kzalloc() could fail so add a check and return -ENOMEM if it does that gets propogated to the pci layer Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_tty.c b

Re: [PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Sudip Mukherjee wrote: On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote: kzalloc() could fail so add a check and return -ENOMEM if it does that gets propogated to the pci layer Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com

[PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

won't execute that if any of the allocations failed. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Only returning -ENOMEM if an allocation failed isn't enough as it was spotted by Sudip so create a new label that frees all successfully allocated stuff and only

Re: [PATCH 1/2] staging: dgnc: remove dead code in dgnc_tty_write()

to 1 thus the code in ifs never gets executed. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Just remove the dead code protected by in_user and join the first and third patches. drivers/staging/dgnc/dgnc_tty.c | 45

[PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

if we can't allocate enough memory means that this scenario isn't possible. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v3: Remove the wrong comment at dgnc_tty_init() that says the allocation could happen somewhere else before this and remove the check if (!brd

Re: [PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Sudip Mukherjee wrote: On Tue, Apr 07, 2015 at 05:11:15PM +0300, Giedrius Statkevičius wrote: If one of the allocations of memory for storing a channel information struct fails then free all the successful allocations and return -ENOMEM that gets propogated to the pci

Re: [PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Dan Carpenter wrote: On Tue, Apr 07, 2015 at 03:40:17PM +0300, Giedrius Statkevičius wrote: If one of the allocations of memory for storing a channel information struct fails then free all the successful allocations and return -ENOMEM that gets propogated to the pci

Re: [PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Dan Carpenter wrote: You will need to update the subject to reflect the new patch. The original code did check for kzalloc() failure but it had lots of checks scattered around instead nicely at the point where the memory was allocated. There are a lot missing too. For

[PATCH v4 2/3] staging: dgnc: don't forget to check if -channels[i] is NULL in dgnc_tty_uninit()

Add a check if -channels[i] is NULL because a NULL pointer may be dereferenced in case one of the allocations failed Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v4: new patch that fixes a bug reported by Dan

[PATCH v4 1/3] staging: dgnc: clean up allocation of -channels[i]

and check in the same loop because -channels[i] isn't allocated anywhere else. Finally, remove a unnecessary check if -channels[i] is NULL in the next loop because it can't be. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v4: Make this patch only for dgnc_tty.c and only

[PATCH v4 3/3] staging: dgnc: remove redundant !ch checks

Remove checks that are redundant since we don't have boards with partially initialized -channels[i]. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v4: splitted this from the one patch. drivers/staging/dgnc/dgnc_cls.c | 4 ++-- drivers/staging/dgnc/dgnc_neo.c | 2 +- 2

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

On Sat, 4 Apr 2015, Andreas Theodosiou wrote: This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit. Signed-off-by: Andreas Theodosiou andreas...@gmail.com --- drivers/staging/fbtft/fb_ili9163.c | 3 ++- 1 file

[PATCH] staging: dgnc: remove some dead code from dgnc_tty.c

Remove some dead code that will never be executed or which serves no purpose Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers

Re: [PATCH] staging: sm7xxfb: Fix sparse warning

On Sat, 4 Apr 2015, Nickolaus Woodruff wrote: This patch fixes the following sparse warning in sm7xx.h: drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' was not declared. Should it be static? Signed-off-by: Nickolaus Woodruff nickolauswoodr...@gmail.com ---

[PATCH v2] staging: ft1000: convert pack pragma to __packed

Convert a Microsoft compiler specific directive #pragma pack(1) to a GCC equivalent __packed. Also, by doing this we save ourselves from trouble if any other struct definitions are added after the #pragma because it will be applied to all of the definitions following it. Signed-off-by: Giedrius

[PATCH] staging: ft1000: convert pack pragma to __packed__ attribute

it. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_download.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c

Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: Made the comment into a new lineto remove a coding style error detected by checkpatch. The warning is given below: drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Resubmit it properly with PATCH v2 in the title and a good commit message. Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com ---

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Better. Also, submit it again with proper commit message and put PATCH v2 in the subject. Signed-off-by: Aparna Karuthodi

30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

Hello, I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" in /dev/sda2. After booting on linux-next and just after entering my password cryptsetup segfaults and a stack trace is printed from the kernel. Since writing down all those numbers is hard I've made a picture where

Re: 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

On Thu, 8 Oct 2015, Geliang Tang wrote: > On Wed, Oct 07, 2015 at 10:27:27PM +0300, Giedrius Statkevičius wrote: > > Hello, > > I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" > > in > > /dev/sda2. After booting on linux-nex

Re: [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis

On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote: Signed-off-by: Peng Sun sironhide0n...@gmail.com Please always add a changelog message. Also, you need to fix the subject. The convention is to use something like: a: b: ... So in this case it should be something like: staging: android:

Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD

On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote: > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module > is loaded with wapf=4 option. Add quirk for this. > --- You forgot Signed-off-by here. Always run your patch through scripts/checkpatch.pl. Also, I think the

[PATCH 1/2] asus-laptop: remove redundant initializers

Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH 2/2] asus-laptop: remove unused variable

`out' was assigned value but it was never used so remove it Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-la

Re: [PATCH 2/2] asus-laptop: remove unused variable

On Sat, Apr 09, 2016 at 08:21:21PM -0700, Darren Hart wrote: > On Thu, Apr 07, 2016 at 11:20:01PM +0300, Giedrius Statkevičius wrote: > > `out' was assigned value but it was never used so remove it > > > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.c

Re: [PATCH] asus-laptop: correct error handling in asus_read_brightness()

On Fri, Apr 22, 2016 at 02:09:22AM +0300, Andy Shevchenko wrote: > On Sat, Apr 16, 2016 at 3:27 AM, Giedrius Statkevičius > <giedrius.statkevic...@gmail.com> wrote: > > It is possible that acpi_evaluate_integer might fail and value would not be > > set to any valu

Re: [PATCH v2] rtl8712: Fixed alignment to match open parenthesis

On Mon, Apr 25, 2016 at 4:00 AM, Parth Sane wrote: > Added missing signed off by line and fixed alignment to match > open parenthesis. Put "Added missing signed off by line" below the ---. This is not what we want to have in change logs.

[PATCH] asus-laptop: correct error handling in asus_read_brightness()

-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 9a69734..15f1311 100644 --- a/drivers/platform/x8

[PATCH v2 1/2] asus-laptop: remove redundant initializers

Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set

Properly return rv back to the caller in the case of an error in parse_arg. In the process remove a unused variable 'out'. Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 del

Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set

On Wed, Apr 20, 2016 at 01:19:55PM -0700, Darren Hart wrote: > On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote: > > Properly return rv back to the caller in the case of an error in > > parse_arg. In the process remove a unused variable 'out'. > > The

Re: [PATCH] Staging: android: ion: ion.c: Compression of lines for

On Sun, Jul 31, 2016 at 6:44 PM, Nadim almas wrote: > This patch compresses two lines in to a single line in file > ion.c > if immediate return statement is found.It also removes variable > ret as it is no longer needed. > > ne using script Coccinelle. And coccinelle uses

Re: [PATCH 1651/1651] staging: i4l: pcbit: Remove explicit NULL comparison

Hello shyam saini, On Tue, Aug 2, 2016 at 2:33 PM, shyam saini wrote: > Remove the explicit NULL comparison and rewrite in a compact form using > Coccinelle > > Signed-off-by: shyam saini Where are the other 1650 patches? Also, a patch series

[PATCH] asus-laptop: get rid of parse_arg()

-23 parse_arg.part39 - -39 Total: Before=19160, After=19012, chg -0.77% Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 77 ++ 1 file changed, 36 inse

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > > function instead. There is no funcionality change except that

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote:

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Wed, Aug 17, 2016 at 11:23:15AM -0700, Darren Hart wrote: > On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: >

Re: [PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

Some more users complaining about this: https://bbs.archlinux.org/viewtopic.php?id=215978 On Thu, Sep 01, 2016 at 08:47:02PM +0300, Giedrius Statkevičius wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status

[PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

er.kernel.org> Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- This patch should be applied to all 4.7 and later kernels Another user complaining about probably the same problem: https://bugzilla.kernel.org/show_bug.cgi?id=151711 drivers/net/wireless/ath/ath9k/main.

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- [...] Why are you sending so many copies

Re: [PATCH 00/87] Fix some style warnings in hfa384x.h

On Wed, Sep 28, 2016 at 7:27 PM, Sergio Paracuellos wrote: > This patch series fix some warnings reported by checkpatch.pl script in > hfa384x.h: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a separate line >

[PATCH] power: supply: lp8788: prevent out of bounds array access

val might become 7 in which case stime[7] (array of length 7) would be accessed during the scnprintf call later and that will cause issues. Obviously, string concatenation is not intended here so just a comma needs to be added to fix the issue. Signed-off-by: Giedrius Statkevičius

Re: [PATCH] power: supply: lp8788: prevent out of bounds array access

Ping. On Tue, Mar 28, 2017 at 2:23 AM, Kim, Milo <milo@ti.com> wrote: > On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote: >> >> val might become 7 in which case stime[7] (array of length 7) would be >> accessed during the scnprintf call later and that will cause i

Re: [PATCH]imx-drm coding style fixes

On 2014.09.19 01:57, Rene Kolarik wrote: > Hello, > > I've fixed coding style issues in drivers/staging/imx-drm directory. This is > a part of Eudyptula Challenge. Please submit your patches "inline" (look at /Documentation/SubmittingPatches section 7). Also, think about if it's worth

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

On Sat, 4 Apr 2015, Andreas Theodosiou wrote: > This is a patch to the fb_ili9163.c file that inserts a line break in > line #92 to make the line fit into the 80 character limit. > > Signed-off-by: Andreas Theodosiou > --- > drivers/staging/fbtft/fb_ili9163.c | 3 ++- > 1 file changed, 2

Re: [PATCH] staging: sm7xxfb: Fix sparse warning

On Sat, 4 Apr 2015, Nickolaus Woodruff wrote: > This patch fixes the following sparse warning in sm7xx.h: > > drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' > was not declared. Should it be static? > > Signed-off-by: Nickolaus Woodruff > --- >

Re: [PATCH 1/2] staging: dgnc: remove dead code in dgnc_tty_write()

> to 0 and never changed to 1 thus the code in ifs never gets executed. > > Signed-off-by: Giedrius Statkevičius > --- > v2: Just remove the dead code protected by in_user and join the first and > third > patches. > > drivers/staging/dgnc/dgnc_tty.c | 45 > +

[PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

kzalloc() could fail so add a check and return -ENOMEM if it does that gets propogated to the pci layer Signed-off-by: Giedrius Statkevičius --- drivers/staging/dgnc/dgnc_tty.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc

Re: [PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote: > > kzalloc() could fail so add a check and return -ENOMEM if it does that gets > > propogated to the pci layer > > > > Signed-off-by: Giedrius Statkev

[PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

won't execute that if any of the allocations failed. Signed-off-by: Giedrius Statkevičius --- v2: Only returning -ENOMEM if an allocation failed isn't enough as it was spotted by Sudip so create a new label that frees all successfully allocated stuff and only then returns -ENOMEM. Also, remove

Re: [PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Dan Carpenter wrote: > On Tue, Apr 07, 2015 at 03:40:17PM +0300, Giedrius Statkevičius wrote: > > If one of the allocations of memory for storing a channel information struct > > fails then free all the successful allocations and return -ENOMEM that gets

[PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

obe failing if we can't allocate enough memory means that this scenario isn't possible. Signed-off-by: Giedrius Statkevičius --- v3: Remove the wrong comment at dgnc_tty_init() that says the allocation could happen somewhere else before this and remove the check if (!brd->channels[i]). Also, remo

  1   2   >