RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-17 Thread Gioh Kim
-by: Gioh Kim gioh@lge.com --- drivers/usb/host/ehci-q.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c index d34b399..779d9e8 100644 --- a/drivers/usb/host/ehci-q.c +++ b/drivers/usb/host/ehci-q.c @@ -501,6 +501,7

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Gioh Kim
Thanks a lot for your replay. -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, July 18, 2013 11:09 PM To: Ming Lei Cc: Gioh Kim; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Mark Salter; namhyung@lge.com; Minchan Kim; Chanho Min

[PATCH][RFC] mm: warning message for vm_map_ram about vm size

2014-03-09 Thread Gioh Kim
. Change-Id: I6f5919848cf03788b5846b7d850d66e4d93ac39a Signed-off-by: Gioh Kim gioh@lge.com --- mm/vmalloc.c |4 1 file changed, 4 insertions(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 0fdf968..2de1d1b 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1083,6 +1083,10

Subject: [PATCH] mm: use vm_map_ram for only temporal object

2014-03-10 Thread Gioh Kim
vmap for long-life but vm_map_ram for short-life. If we inform the user about the characteristic of vm_map_ram the user can choose one according to the page lifetime. Let's add some notice messages to user. Signed-off-by: Gioh Kim gioh@lge.com Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com

RE: Subject: [PATCH] mm: use vm_map_ram for only temporal object

2014-03-11 Thread Gioh Kim
[mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of SeongJae Park Sent: Tuesday, March 11, 2014 8:51 PM To: Gioh Kim Cc: Zhang Yanfei; Minchan Kim; Andrew Morton; Joonsoo Kim; linux- m...@kvack.org; linux-kernel@vger.kernel.org; 이건호; chanho@lge.com; Johannes Weiner Subject: Re: Subject: [PATCH

Re: [RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value

2014-05-19 Thread Gioh Kim
2014-05-20 오전 4:59, Michal Nazarewicz 쓴 글: On Sun, May 18 2014, Joonsoo Kim wrote: I think that this problem is originated from atomic_pool_init(). If configured coherent_pool size is larger than default cma size, it can be failed even if this patch is applied. The coherent_pool size

Re: [RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value

2014-05-19 Thread Gioh Kim
2014-05-20 오전 10:28, Michal Nazarewicz 쓴 글: On Mon, May 19 2014, Gioh Kim wrote: If CMA option is not selected, __alloc_from_contiguous would not be called. We don't need to the fallback allocation. And if CMA option is selected and initialized correctly, the cma allocation can fail in case

[RFC PATCH] arm: dma-mapping: fallback allocation for cma failure

2014-05-19 Thread Gioh Kim
05e389683ddd07027e8acb61c25f3284f762300e Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Tue, 20 May 2014 14:16:20 +0900 Subject: [PATCH] arm: dma-mapping: fallback allocation for cma failure If CMA is turned on and CMA size is set to zero, kernel should behave as if CMA was not enabled at compile

Re: [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure

2014-05-20 Thread Gioh Kim
That case, device-specific coherent memory allocation, is handled at dma_alloc_coherent in arm_dma_alloc. __dma_alloc handles only general coherent memory allocation. I'm sorry missing mention about it. 2014-05-20 오후 3:52, Joonsoo Kim 쓴 글: On Tue, May 20, 2014 at 02:57:47PM +0900, Gioh Kim

Re: [PATCH] Documentation/DMA-API-HOWTO.txt: update API descriptions

2014-05-20 Thread Gioh Kim
I'm glad that my patch is useful. Thank you. 2014-05-21 오전 8:19, Bjorn Helgaas 쓴 글: On Mon, May 12, 2014 at 08:45:52PM +0900, gioh.kim wrote: From: gioh.kim gioh@lge.com update descriptions for dma_pool_create and dma_pool_alloc Signed-off-by: Gioh Kim gioh@lge.com I applied

Re: [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure

2014-05-20 Thread Gioh Kim
2014-05-20 오후 5:32, Joonsoo Kim 쓴 글: On Tue, May 20, 2014 at 04:05:52PM +0900, Gioh Kim wrote: That case, device-specific coherent memory allocation, is handled at dma_alloc_coherent in arm_dma_alloc. __dma_alloc handles only general coherent memory allocation. I'm sorry missing mention

Re: [RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value

2014-05-20 Thread Gioh Kim
2014-05-20 오후 8:38, Marek Szyprowski 쓴 글: Hello, On 2014-05-20 02:50, Gioh Kim wrote: 2014-05-20 오전 4:59, Michal Nazarewicz 쓴 글: On Sun, May 18 2014, Joonsoo Kim wrote: I think that this problem is originated from atomic_pool_init(). If configured coherent_pool size is larger than

Re: [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure

2014-05-20 Thread Gioh Kim
2014-05-21 오전 3:22, Michal Nazarewicz 쓴 글: On Mon, May 19 2014, Joonsoo Kim wrote: On Tue, May 20, 2014 at 02:57:47PM +0900, Gioh Kim wrote: Thanks for your advise, Michal Nazarewicz. Having discuss with Joonsoo, I'm adding fallback allocation after __alloc_from_contiguous(). The fallback

Re: [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure

2014-05-21 Thread Gioh Kim
:00 2001 From: Gioh Kim gioh@lge.com Date: Tue, 20 May 2014 14:16:20 +0900 Subject: [PATCH] arm: dma-mapping: add checking cma area initialized If CMA is turned on and CMA size is set to zero, kernel should behave as if CMA was not enabled at compile time. Every dma allocation should check

Re: [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure

2014-05-21 Thread Gioh Kim
-- From 135c986cfaa5a7291519308b3d47e58bf9f5af25 Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Tue, 20 May 2014 14:16:20 +0900 Subject: [PATCH] arm: dma-mapping: add checking cma area initialized If CMA is turned on and CMA size is set to zero, kernel should behave

[RFC] I found an errataum at drivers/base/dma-contiguous.c:294

2014-05-21 Thread Gioh Kim
This is not a big deal but I think get_dev_cma_area is errataum of dev_get_cma_area. diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index b056661..6343f25 100644 --- a/drivers/base/dma-contiguous.c +++ b/drivers/base/dma-contiguous.c @@ -291,7 +291,7 @@ err: * *

Re: [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure

2014-05-21 Thread Gioh Kim
I'll resend the patch using git-send-email with your name. I also hope some ARM-guys took a look at it. 2014-05-22 오후 12:22, Michal Nazarewicz 쓴 글: On Thu, May 22 2014, Gioh Kim gioh@lge.com wrote: I appreciate your comments. The previous patch was ugly. But now it's beautiful! Just 3

[PATCH] drivers/base/dma-contiguous.c: erratum of dev_get_cma_area

2014-05-21 Thread Gioh Kim
fix erratum get_dev_cma_area into dev_get_cma_area Signed-off-by: Gioh Kim gioh@lge.com --- drivers/base/dma-contiguous.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index b056661..6343f25 100644

Re: [RFC] I found an errataum at drivers/base/dma-contiguous.c:294

2014-05-21 Thread Gioh Kim
Thanks your advice. I'll send a patch soon. 2014-05-22 오전 11:54, David Rientjes 쓴 글: On Thu, 22 May 2014, Gioh Kim wrote: This is not a big deal but I think get_dev_cma_area is errataum of dev_get_cma_area. Looks good, but you may want to read Documentation/SubmittingPatches when

[PATCH] arm: dma-mapping: add checking cma area initialized

2014-05-21 Thread Gioh Kim
If CMA is turned on and CMA size is set to zero, kernel should behave as if CMA was not enabled at compile time. Every dma allocation should check existence of cma area before requesting memory. Signed-off-by: Gioh Kim gioh@lge.com Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked

[PATCH] [RFC] ARM: MM: remove phy_base field of struct

2014-05-14 Thread Gioh Kim
cc0d98f4ef8b6f8f139a7c6179ed0b03e9ad7d07 Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Thu, 15 May 2014 11:26:20 +0900 Subject: [PATCH] [RFC] ARM: MM: remove phy_base field of struct l2x0_regs Remove unused field, phy_base of struct l2x0_regs Signed-off-by: Gioh Kim gioh@lge.com

[RFC PATCH] ARM: cache-l2x0: add setup entry for l2 in non-secure mode

2014-05-14 Thread Gioh Kim
. -- 8 --- From ee4b03fb2c12038c6bbb9f752558abae8d500c07 Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Thu, 15 May 2014 14:06:36 +0900 Subject: [PATCH] ARM: cache-l2x0: add setup entry for l2 in non-secure mode For some platforms using Trustzone and running

[PATCH] ARM: cache-l2x0: add error message when fail to enable cache

2014-05-14 Thread Gioh Kim
Add error message when fail to enable cache Signed-off-by: Gioh Kim gioh@lge.com --- arch/arm/mm/cache-l2x0.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c index 7abde2c..5102c62 100644 --- a/arch/arm/mm/cache

[RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value

2014-05-16 Thread Gioh Kim
] ---[ end trace 6f1857db5ef45cba ]--- I'm adding my patch to restrict CMA_SIZE_MBYTES. This patch is based on 3.15.0-rc5 8 -- From 9f8e6d3c1f4bdeeeb7af3df7898b773a612c62e8 Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh

Re: [PATCH] [RFC] ARM: MM: remove phy_base field of struct

2014-05-18 Thread Gioh Kim
Thank you. It's my mistake. 2014-05-18 오후 10:18, Barry Song 쓴 글: 2014-05-15 10:49 GMT+08:00 Gioh Kim gioh@lge.com: Hi, It's not a big deal but I've found that phy_base field of struct l2x0_regs is not used anywhere. I've removed it on my board. It seems to be working fine. Why do we need

Re: [RFC PATCH] ARM: cache-l2x0: add setup entry for l2 in non-secure mode

2014-05-18 Thread Gioh Kim
2014-05-18 오후 10:13, Barry Song 쓴 글: 2014-05-15 13:39 GMT+08:00 Gioh Kim gioh@lge.com: Hi, My board is using Trustzone and running kernel is non-secure mode. But setup function of PL310 driver is only for secure mode kernel. What about adding an entry for non-secure mode setup function

Re: [RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value

2014-05-18 Thread Gioh Kim
: Gioh Kim gioh@lge.com Date: Fri, 16 May 2014 16:15:43 +0900 Subject: [PATCH] drivers/base/Kconfig: restrict CMA size to non-zero value The size of CMA area must be larger than zero. If the size is zero, all physically-contiguous allocation can be failed. Signed-off-by: Gioh Kim gioh

Re: [RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value

2014-05-19 Thread Gioh Kim
of __alloc_from_contiguous and __alloc_from_pool should work together, or both of them do not work. 2014-05-19 오후 2:55, Joonsoo Kim 쓴 글: On Mon, May 19, 2014 at 10:47:12AM +0900, Gioh Kim wrote: Thank you for your advice. I didn't notice it. I'm adding followings according to your advice: - range

Re: [RFC PATCH] ARM: cache-l2x0: add setup entry for l2 in non-secure mode

2014-05-19 Thread Gioh Kim
2014-05-19 오후 6:11, Barry Song 쓴 글: 2014-05-19 8:29 GMT+08:00 Gioh Kim gioh@lge.com: 2014-05-18 오후 10:13, Barry Song 쓴 글: 2014-05-15 13:39 GMT+08:00 Gioh Kim gioh@lge.com: Hi, My board is using Trustzone and running kernel is non-secure mode. But setup function of PL310 driver

Re: [PATCH v2 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used

2014-05-29 Thread Gioh Kim
I've not understand your code fully. Please let me ask some silly questions. 2014-05-28 오후 4:04, Joonsoo Kim 쓴 글: CMA is introduced to provide physically contiguous pages at runtime. For this purpose, it reserves memory at boot time. Although it reserve memory, this reserved memory can be used

Re: [PATCH v2 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used

2014-05-29 Thread Gioh Kim
+ /* * Do the hard work of removing an element from the buddy allocator. * Call me with the zone-lock already held. @@ -1143,10 +1223,15 @@ __rmqueue_fallback(struct zone *zone, int order, int start_migratetype) static struct page *__rmqueue(struct zone *zone, unsigned int order,

Re: [PATCH v2 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used

2014-05-30 Thread Gioh Kim
Joonsoo, I'm attaching a patch for combination of __rmqueue and __rmqueue_cma. I didn't test fully but my board is turned on and working well if no frequent memory allocations. I'm sorry to send not-tested code. I just want to report this during your working hour ;-) I'm testing this this

Re: [PATCH v2 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used

2014-06-01 Thread Gioh Kim
call-stacks. 2014-05-30 오후 11:23, Joonsoo Kim 쓴 글: 2014-05-30 16:53 GMT+09:00 Gioh Kim gioh@lge.com: Joonsoo, I'm attaching a patch for combination of __rmqueue and __rmqueue_cma. I didn't test fully but my board is turned on and working well if no frequent memory allocations. I'm sorry

Re: [PATCH v2 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used

2014-06-02 Thread Gioh Kim
, movable); 786 2014-06-02 오후 3:23, Joonsoo Kim 쓴 글: On Mon, Jun 02, 2014 at 02:54:30PM +0900, Gioh Kim wrote: I found 2 problems at my platform. 1st is occured when I set CMA size 528MB and total memory is 960MB. I print some values in adjust_managed_cma_page_count(), the total value becomes 105439

RE: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

2014-05-13 Thread Gioh Kim
this be the same as the name and email used in the Signed-off-by line below. update some descriptions for API arguments and descriptions. Nit: Update since it's the beginning of a sentence. Signed-off-by: Gioh Kim gioh@lge.com --- Documentation/dma-buf-sharing.txt | 10 ++ 1

[PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

2014-05-13 Thread Gioh Kim
Update some descriptions for API arguments and descriptions. Signed-off-by: Gioh Kim gioh@lge.com --- Documentation/dma-buf-sharing.txt | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Documentation/dma-buf-sharing.txt b/Documentation/dma-buf-sharing.txt

[RFC] CMA page migration failure due to buffers on bh_lru

2014-06-23 Thread Gioh Kim
Hello, I am trying to apply CMA feature for my platform. My kernel version, 3.10.x, is not allocating memory from CMA area so that I applied a Joonsoo Kim's patch (https://lkml.org/lkml/2014/5/28/64). Now my platform can use CMA area effectively. But I have many failures to allocate memory

[PATCHv2] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-20 Thread Gioh Kim
I removed checking migratetype of v1: https://lkml.org/lkml/2014/7/18/82. Thanks a lot. 8 -- From 95addf7f1644cde3a0944629ff5c6a8d6f43e5d6 Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Gioh Kim
2014-07-21 오전 11:50, Minchan Kim 쓴 글: Hi Gioh, On Fri, Jul 18, 2014 at 03:45:36PM +0900, Gioh Kim wrote: Hi, For page migration of CMA, buffer-heads of lru should be dropped. Please refer to https://lkml.org/lkml/2014/7/4/101 for the history. Just nit: Please write *problem

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Gioh Kim
2014-07-22 오전 9:15, Minchan Kim 쓴 글: Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two things popped out at me during the

[PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-21 Thread Gioh Kim
for ext4 and others that want to hold page cache for a long time. I have 2 patchs: 1. Patch 1/2: introduce a new API that create page cache from non-movable area 2. Patch 2/2: have ext4 use the new API to read superblock This patchset is based on linux-next-20140717. Thanks a lot. Gioh Kim (2): fs

[PATCH 1/2] fs/buffer.c: allocate buffer cache from non-movable area

2014-07-21 Thread Gioh Kim
A buffer cache is allocated from movable area because it is referred for a while and released soon. But some filesystems are taking buffer cache for a long time and it can disturb page migration. A new API should be introduced to allocate buffer cache from non-movable area. Signed-off-by: Gioh

[PATCH 2/2] ext4: allocate buffer-cache for superblock in, non-movable area

2014-07-21 Thread Gioh Kim
A buffer-cache for superblock is disturbing page migration, because the buffer-cache is not released until unmount. The buffer-cache must be allocated from non-movable area. Signed-off-by: Gioh Kim gioh@lge.com --- fs/ext4/super.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [RFC] CMA page migration failure due to buffers on bh_lru

2014-06-26 Thread Gioh Kim
2014-06-27 오전 12:57, Michal Nazarewicz 쓴 글: On Tue, Jun 24 2014, Gioh Kim gioh@lge.com wrote: Hello, I am trying to apply CMA feature for my platform. My kernel version, 3.10.x, is not allocating memory from CMA area so that I applied a Joonsoo Kim's patch (https://lkml.org/lkml/2014/5

[RFC] squashfs: A possible memory leak in squashfs

2014-06-27 Thread Gioh Kim
Hello, I have been trying to apply CMA feature to my platform, based on ver. 3.10. And I am suffering failures of allocation in CMA area. I made a patch like below (I copied it after kernel log) and found that a buffer-head is not released. As you know the CMA try to migrate movable pages. If

Re: [RFC] CMA page migration failure due to buffers on bh_lru

2014-06-30 Thread Gioh Kim
change cpu-lru. Is my concern correct? 2014-06-30 오전 4:49, Laura Abbott 쓴 글: (cc-ing Hugh since he had comments on the patch before) On 6/26/2014 4:23 PM, Gioh Kim wrote: 2014-06-27 오전 12:57, Michal Nazarewicz 쓴 글: On Tue, Jun 24 2014, Gioh Kim gioh@lge.com wrote: Hello, I am trying

Re: [PATCH 03/10] mm/page_alloc: handle page on pcp correctly if it's pageblock is isolated

2014-07-07 Thread Gioh Kim
2014-07-04 오후 4:57, Joonsoo Kim 쓴 글: If pageblock of page on pcp are isolated now, we should free it to isolate buddy list to prevent future allocation on it. But current code doesn't do this. I think it is strage that pcp can have isolated page. I remember that The purpose of pcp is having

Re: [PATCH 08/10] mm/page_alloc: use get_onbuddy_migratetype() to get buddy list type

2014-07-07 Thread Gioh Kim
2014-07-08 오전 12:57, Vlastimil Babka 쓴 글: On 07/04/2014 09:57 AM, Joonsoo Kim wrote: When isolating free page, what we want to know is which list the page is linked. If it is linked in isolate migratetype buddy list, we can skip watermark check and freepage counting. And if it is linked in

Re: [PATCH] [RFC] CMA: clear buffer-head lru before page migration

2014-07-07 Thread Gioh Kim
It's my fault. I'm going to send another patch ASAP. 2014-07-08 오전 7:52, Andrew Morton 쓴 글: On Fri, 04 Jul 2014 17:25:09 +0900 Gioh Kim gioh@lge.com wrote: From: Gioh Kim gioh@lge.com Date: Fri, 4 Jul 2014 16:53:22 +0900 Subject: [PATCH] [RFC] CMA: clear buffer-head lru before page

Re: [PATCH] [RFC] CMA: clear buffer-head lru before page migration

2014-07-15 Thread Gioh Kim
2014-07-15 오전 5:37, Andrew Morton 쓴 글: On Mon, 14 Jul 2014 16:02:25 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: On Tue, Jul 08, 2014 at 06:46:31PM +0200, Michal Nazarewicz wrote: On Mon, Jul 07 2014, Andrew Morton a...@linux-foundation.org wrote: What I proposed is that CMA call

Re: [RFC] CMA page migration failure due to buffers on bh_lru

2014-07-03 Thread Gioh Kim
: On 6/30/2014 6:07 PM, Gioh Kim wrote: Hi,Laura. I have a question. Does the __evict_bh_lru() not need bh_lru_lock()? The get_cpu_var() has already preenpt_disable() and can prevent other thread. But get_cpu_var cannot prevent IRQ context such like page-fault. I think if a page-fault occured

[PATCH] [RFC] CMA: clear buffer-head lru before page migration

2014-07-04 Thread Gioh Kim
- From d90cd3d13b73f7278c60d8fe625840664adcbb6a Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 4 Jul 2014 16:53:22 +0900 Subject: [PATCH] [RFC] CMA: clear buffer-head lru before page migration When CMA try to migrate page, some buffer-heads can exist on lru

[PATCH] [RFC] ARM: mm: add configuration for the size of module space

2013-12-23 Thread Gioh Kim
that it can be configurable at most 32MB. I have changed the module space size to 18MB and tested my platform. It have been looking good. I am not sure my patch is proper solution. Anyway, could I configure the module space size? Signed-off-by: Gioh Kim gioh@lge.com --- arch/arm/Kconfig

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-30 Thread Gioh Kim
2014-07-22 오후 6:38, Jan Kara 쓴 글: On Tue 22-07-14 09:30:05, Peter Zijlstra wrote: On Tue, Jul 22, 2014 at 02:18:47PM +0900, Gioh Kim wrote: Hello, This patch try to solve problem that a long-lasting page cache of ext4 superblock disturbs page migration. I've been testing CMA feature on my

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-30 Thread Gioh Kim
2014-07-27 오전 10:01, Theodore Ts'o 쓴 글: Gioh, As follow up, if you want some further discussions about why these patches should be accepted, it would be good to get some hard data about why the keeping the ext4 superblock pinned is causing such a problem for page migation. Can you give us

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-30 Thread Gioh Kim
2014-07-22 오전 10:04, Gioh Kim 쓴 글: 2014-07-22 오전 9:15, Minchan Kim 쓴 글: Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two

[PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Gioh Kim
have you name on Acked-by line? Please let me represent my thanks. Thanks for any feedback. --- 8 -- From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Gioh Kim
2014-07-18 오후 4:50, Marek Szyprowski 쓴 글: Hello, On 2014-07-18 08:45, Gioh Kim wrote: For page migration of CMA, buffer-heads of lru should be dropped. Please refer to https://lkml.org/lkml/2014/7/4/101 for the history. I have two solution to drop bhs. One is invalidating entire lru

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-30 Thread Gioh Kim
2014-07-30 오후 7:19, Peter Zijlstra 쓴 글: On Wed, Jul 30, 2014 at 12:11:43PM +0200, Jan Kara wrote: sb_bread allocates page from movable area but it is not movable until the reference counter of the buffer-head becomes zero. There is no lock for the buffer but the reference counter acts like

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-30 Thread Gioh Kim
2014-07-30 오후 7:11, Jan Kara 쓴 글: On Wed 30-07-14 16:44:24, Gioh Kim wrote: 2014-07-22 오후 6:38, Jan Kara 쓴 글: On Tue 22-07-14 09:30:05, Peter Zijlstra wrote: On Tue, Jul 22, 2014 at 02:18:47PM +0900, Gioh Kim wrote: Hello, This patch try to solve problem that a long-lasting page cache

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-30 Thread Gioh Kim
2014-07-31 오전 9:03, Jan Kara 쓴 글: On Thu 31-07-14 08:54:40, Gioh Kim wrote: 2014-07-30 오후 7:11, Jan Kara 쓴 글: On Wed 30-07-14 16:44:24, Gioh Kim wrote: 2014-07-22 오후 6:38, Jan Kara 쓴 글: On Tue 22-07-14 09:30:05, Peter Zijlstra wrote: On Tue, Jul 22, 2014 at 02:18:47PM +0900, Gioh Kim

[PATCHv2] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-30 Thread Gioh Kim
. The reference count of bh is increased when it is installed into lru so that the bh of lru must be freed before migrating the page. This frees every bh of lru. We could free only bh of migrating page. But searching lru sometimes costs more than invalidating entire lru. Signed-off-by: Gioh Kim gioh

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-31 Thread Gioh Kim
2014-07-31 오후 9:21, Jan Kara 쓴 글: On Thu 31-07-14 09:37:15, Gioh Kim wrote: 2014-07-31 오전 9:03, Jan Kara 쓴 글: On Thu 31-07-14 08:54:40, Gioh Kim wrote: 2014-07-30 오후 7:11, Jan Kara 쓴 글: On Wed 30-07-14 16:44:24, Gioh Kim wrote: 2014-07-22 오후 6:38, Jan Kara 쓴 글: On Tue 22-07-14 09:30:05

Re: [PATCHv2] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-31 Thread Gioh Kim
2014-08-01 오전 7:57, Andrew Morton 쓴 글: On Thu, 31 Jul 2014 11:22:35 +0900 Gioh Kim gioh@lge.com wrote: The previous PATCH inserts invalidate_bh_lrus() only into CMA code. HOTPLUG needs also dropping bh of lru. So v2 inserts invalidate_bh_lrus() into both of CMA and HOTPLUG

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-31 Thread Gioh Kim
2014-08-01 오전 9:07, Gioh Kim 쓴 글: 2014-07-31 오후 9:21, Jan Kara 쓴 글: On Thu 31-07-14 09:37:15, Gioh Kim wrote: 2014-07-31 오전 9:03, Jan Kara 쓴 글: On Thu 31-07-14 08:54:40, Gioh Kim wrote: 2014-07-30 오후 7:11, Jan Kara 쓴 글: On Wed 30-07-14 16:44:24, Gioh Kim wrote: 2014-07-22 오후 6:38

Re: [PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific flag

2014-08-19 Thread Gioh Kim
2014-08-19 오후 10:03, Jan Kara 쓴 글: Hello, On Tue 19-08-14 15:52:38, Gioh Kim wrote: A buffer cache is allocated from movable area because it is referred for a while and released soon. But some filesystems are taking buffer cache for a long time and it can disturb page migration. A new

Re: [PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific flag

2014-08-19 Thread Gioh Kim
@@ -1381,12 +1383,7 @@ EXPORT_SYMBOL(__find_get_block); struct buffer_head * __getblk(struct block_device *bdev, sector_t block, unsigned size) { - struct buffer_head *bh = __find_get_block(bdev, block, size); - - might_sleep(); - if (bh == NULL) - bh =

Re: [PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific flag

2014-08-20 Thread Gioh Kim
2014-08-21 오전 7:02, Jan Kara 쓴 글: On Wed 20-08-14 11:38:10, Gioh Kim wrote: @@ -1381,12 +1383,7 @@ EXPORT_SYMBOL(__find_get_block); struct buffer_head * __getblk(struct block_device *bdev, sector_t block, unsigned size) { - struct buffer_head *bh = __find_get_block(bdev, block

[PATCH 0/2] new APIs to allocate buffer-cache for superblock in non-movable area

2014-08-13 Thread Gioh Kim
the new API to read superblock 3. Patch 3/3: have jbd/jbd2 use the new API to make journaling of superblock This patchset is based on linux-next-20140814. Thanks a lot. Gioh Kim (3): fs/buffer.c: allocate buffer cache from non-movable area ext4: allocate buffer-cache for superblock in non

[PATCH 1/2] fs/buffer.c: allocate buffer cache from non-movable area

2014-08-13 Thread Gioh Kim
A buffer cache is allocated from movable area because it is referred for a while and released soon. But some filesystems are taking buffer cache for a long time and it can disturb page migration. A new API should be introduced to allocate buffer cache from non-movable area. Signed-off-by: Gioh

[PATCH 2/3] ext4: allocate buffer-cache for superblock in, non-movable area

2014-08-13 Thread Gioh Kim
A buffer-cache for superblock is disturbing page migration, because the buffer-cache is not released until unmount. The buffer-cache must be allocated from non-movable area. Signed-off-by: Gioh Kim gioh@lge.com --- fs/ext4/super.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH 3/3] jbd/jbd2: allocate buffer-cache for superblock inode in, non-movable area

2014-08-13 Thread Gioh Kim
for a long time and it can distrub page migration. This patch make the buffer-cache be allocated from non-movable area not to distrub page migration. Signed-off-by: Gioh Kim gioh@lge.com --- fs/jbd/journal.c |2 +- fs/jbd2/journal.c |2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [PATCH 0/2] new APIs to allocate buffer-cache for superblock in non-movable area

2014-08-13 Thread Gioh Kim
I'm sorry for a typo at the tile. It is 0/3, not 0/2. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] fs/buffer.c: allocate buffer cache from non-movable area

2014-08-13 Thread Gioh Kim
I'm sorry for a typo at the title. It is 1/3, not 1/2. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/2] new APIs to allocate buffer-cache for superblock in non-movable area

2014-08-13 Thread Gioh Kim
2014-08-14 오후 2:12, Gioh Kim 쓴 글: Hello, This patch try to solve problem that a long-lasting page caches of ext4 superblock and journaling of superblock disturb page migration. I've been testing CMA feature on my ARM-based platform and found that two page caches cannot be migrated

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-08-06 Thread Gioh Kim
2014-08-02 오전 1:04, Peter Zijlstra 쓴 글: On Fri, Aug 01, 2014 at 05:24:59PM +0200, Jan Kara wrote: OK, makes sense. But then if there's heavy IO going on, anything that has IO pending on it is pinned and IO completion can easily take something close to a second or more. So meeting

Re: [PATCH 0/2] new APIs to allocate buffer-cache for superblock in non-movable area

2014-08-17 Thread Gioh Kim
2014-08-17 오전 3:52, Jan Kara 쓴 글: On Thu 14-08-14 14:26:10, Andrew Morton wrote: On Thu, 14 Aug 2014 14:12:17 +0900 Gioh Kim gioh@lge.com wrote: This patch try to solve problem that a long-lasting page caches of ext4 superblock and journaling of superblock disturb page migration. I've

Re: [PATCH 1/2] fs/buffer.c: allocate buffer cache from non-movable area

2014-08-17 Thread Gioh Kim
2014-08-15 오전 6:22, Andrew Morton 쓴 글: On Thu, 14 Aug 2014 14:15:40 +0900 Gioh Kim gioh@lge.com wrote: A buffer cache is allocated from movable area because it is referred for a while and released soon. But some filesystems are taking buffer cache for a long time and it can disturb page

Re: [PATCH 0/2] new APIs to allocate buffer-cache for superblock in non-movable area

2014-08-17 Thread Gioh Kim
2014-08-18 오후 12:24, Theodore Ts'o 쓴 글: On Mon, Aug 18, 2014 at 10:15:32AM +0900, Gioh Kim wrote: My test platform has totally 1GB memory, 256MB for CMA and 768MB for normal. I applied Joonsoo's patch: https://lkml.org/lkml/2014/5/28/64, so that 3/4 of allocation take place in normal area

[PATCHv2 0/3] new APIs to allocate buffer-cache with user specific flag

2014-08-19 Thread Gioh Kim
have 3 patchs: 1. Patch 1/3: introduce a new API that create page cache with allocation flag 2. Patch 2/3: have ext4 use the new API to read superblock 3. Patch 3/3: have jbd/jbd2 use the new API to make journaling of superblock This patchset is based on linux-next-20140814. Thanks a lot. Gioh Kim

[PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific flag

2014-08-19 Thread Gioh Kim
if user set flag to zero, buffer cache is allocated from non-movable area. Signed-off-by: Gioh Kim gioh@lge.com --- fs/buffer.c | 52 +-- include/linux/buffer_head.h | 12 +- 2 files changed, 46 insertions(+), 18 deletions(-) diff

[PATCHv2 2/3] ext4: allocate buffer-cache for superblock in non-movable area

2014-08-19 Thread Gioh Kim
A buffer-cache for superblock is disturbing page migration, because the buffer-cache is not released until unmount. The buffer-cache must be allocated from non-movable area. Signed-off-by: Gioh Kim gioh@lge.com --- fs/ext4/super.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCHv2 3/3] jbd/jbd2: allocate buffer-cache for superblock inode in non-movable area

2014-08-19 Thread Gioh Kim
for a long time and it can distrub page migration. This patch make the buffer-cache be allocated from non-movable area not to distrub page migration. Signed-off-by: Gioh Kim gioh@lge.com --- fs/jbd/journal.c |2 +- fs/jbd2/journal.c |2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [PATCH v2 2/2] fs: proc: Include cma info in proc/meminfo

2014-10-22 Thread Gioh Kim
2014-10-22 오후 11:06, Pintu Kumar 쓴 글: This patch include CMA info (CMATotal, CMAFree) in /proc/meminfo. Currently, in a CMA enabled system, if somebody wants to know the total CMA size declared, there is no way to tell, other than the dmesg or /var/log/messages logs. With this patch we are

[RFC 0/2] enable pool shrinking in page unit

2014-10-23 Thread Gioh Kim
unit. 2. Patch 2/2: enable debugfs to shrink pool directly This patch enable debugfs to specify shrink amount. Thanks for any feedback. This patchset is based on linux-next-20141023. Gioh Kim (2): staging: ion: shrink page-pool by page unit staging: ion: debugfs to shrink pool drivers

[RFC 2/2] staging: ion: debugfs to shrink pool

2014-10-23 Thread Gioh Kim
This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink, to shrink pool or get pool size. Reading the file returns pool size and writing occurs to shrink pool. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/ion.c | 31

[RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Gioh Kim
This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c |7 +-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android

Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Gioh Kim
2014-10-24 오전 5:36, Devendra Naga 쓴 글: Hello, On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim gioh@lge.com wrote: This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion

Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Gioh Kim
2014-10-24 오전 8:16, Gioh Kim 쓴 글: 2014-10-24 오전 5:36, Devendra Naga 쓴 글: Hello, On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim gioh@lge.com wrote: This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/ion_page_pool.c |5

[RFCv2 2/3] staging: ion: debugfs to shrink pool

2014-10-24 Thread Gioh Kim
This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink, to shrink pool or get pool size. Reading the file returns pool size and writing occurs to shrink pool. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/ion.c | 31

[RFCv2 3/3] staging: ion: limit pool size

2014-10-24 Thread Gioh Kim
This patch limits pool size by page unit. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/Kconfig |4 drivers/staging/android/ion/ion_page_pool.c | 26 -- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers

[RFCv2 0/3] enable pool shrinking in page unit

2014-10-24 Thread Gioh Kim
in page unit. 2. Patch 2/3: enable debugfs to shrink page directly This patch enables debugfs to specify shrink amount. 3. Patch 3/3: limit pool size This patch specifies pool size limit. This patchset is based on linux-next-20141023. Gioh Kim (3): staging: ion: shrink page-pool by page unit

[RFCv2 1/3] staging: ion: shrink page-pool by page unit

2014-10-24 Thread Gioh Kim
This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c |7 +-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android

Re: [PATCH v4 0/4] fix freepage count problems in memory isolation

2014-10-24 Thread Gioh Kim
2014-10-23 오후 5:10, Joonsoo Kim 쓴 글: Changes from v3 to v4 * Patch 1: Add code comment on nr_isolate_pageblock on struct zone (Naoya) Add one more check in free_one_page() that checks whether migratetype is MIGRATE_ISOLATE or not. * Patch 4: Use min() to prevent overflow of

Re: [PATCH v2 2/2] fs: proc: Include cma info in proc/meminfo

2014-10-24 Thread Gioh Kim
2014-10-24 오후 5:57, PINTU KUMAR 쓴 글: Hi, - Original Message - From: Gioh Kim gioh@lge.com To: Pintu Kumar pint...@samsung.com; a...@linux-foundation.org; r...@redhat.com; aqu...@redhat.com; paul.gortma...@windriver.com; jmarc...@redhat.com; lcapitul...@redhat.com

Re: [RFCv2 1/3] staging: ion: shrink page-pool by page unit

2014-10-26 Thread Gioh Kim
2014-10-25 오전 5:09, Laura Abbott 쓴 글: Hi, On 10/23/2014 11:47 PM, Gioh Kim wrote: This patch shrink page-pool by page unit. Can you explain a bit more about what this patch is fixing? The description in the cover letter would be helpful here. I'm sorry for the lack of explanation

Re: [RFCv2 2/3] staging: ion: debugfs to shrink pool

2014-10-26 Thread Gioh Kim
2014-10-25 오전 5:38, Laura Abbott 쓴 글: Hi, On 10/23/2014 11:47 PM, Gioh Kim wrote: This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink, to shrink pool or get pool size. Reading the file returns pool size and writing occurs to shrink pool. Can you clarify here

Re: [RFCv2 3/3] staging: ion: limit pool size

2014-10-26 Thread Gioh Kim
2014-10-25 오전 5:53, Laura Abbott 쓴 글: Hi, On 10/23/2014 11:47 PM, Gioh Kim wrote: This patch limits pool size by page unit. This looks useful. Might be nice to add a debugfs option to change this at runtime as well. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android

Re: How can I check creator of probe point?

2014-10-16 Thread Gioh Kim
you caller information so that you can filter your driver by postprocessing. Thank you, (2014/10/14 11:16), Gioh Kim wrote: Hi, I am trying to find a way to make statistics for memory allocation of my device driver. I want to know how much memory it allocates and how many times

Re: [PATCH] mm: cma: split cma-reserved in dmesg log

2014-10-20 Thread Gioh Kim
2014-10-20 오후 4:33, Pintu Kumar 쓴 글: When the system boots up, in the dmesg logs we can see the memory statistics along with total reserved as below. Memory: 458840k/458840k available, 65448k reserved, 0K highmem When CMA is enabled, still the total reserved memory remains the same.

  1   2   3   4   5   >