-documen.patch
...
In 2018, Rob Herring reviewed (and approved):
[V2,1/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document
I've just reviewed 2/3 and 3/3. You can add to those:
Reviewed-by: Grant Grundler
I compared 3/3 with the DTS entries that were submitted (and I
approved) to chromeos
Adding linux-...@vger.kernel.org since Andy's email in MAINTAINERs bounced.
Using Matthew's personal email since his codeaurora email bounced.
On Mon, Sep 7, 2020 at 11:35 PM Grant Grundler wrote:
>
> Alban, Andy,
> Can you please apply this patch series from 2018 or please explain
On Mon, Feb 18, 2008 at 05:40:42PM +0100, Ondrej Zary wrote:
> On Monday 18 February 2008 04:21:11 Grant Grundler wrote:
> > On Wed, Jan 30, 2008 at 09:23:06PM +0100, Ondrej Zary wrote:
> > > On Saturday 26 January 2008 21:58:10 Ondrej Zary wrote:
> > > > Hello,
On Mon, Feb 25, 2008 at 09:43:59AM +0800, Cai, Crane wrote:
> > On Fri, Feb 22, 2008 at 01:49:20PM +0800, Cai, Crane wrote:
> > > > On Thu, Feb 21, 2008 at 03:47:33PM -0800, Greg
> > Kroah-Hartman wrote:
> > > > > +static void __devinit quirk_amd_ide_mode(struct pci_dev *pdev)
> > > > > {
> > >
On Mon, Feb 25, 2008 at 02:30:00AM -0500, Jeff Garzik wrote:
> Grant Grundler wrote:
>> On Mon, Feb 18, 2008 at 05:40:42PM +0100, Ondrej Zary wrote:
>>> I think that de2104x driver should be removed (or at least its
>>> MODULE_DEVICE_TABLE) and MODULE_DEVICE_TABL
On Wed, Jan 09, 2008 at 03:30:58PM -0600, James Bottomley wrote:
...
> > Also, all of this is quite separate from the PCIe "loose ordering"
> > stuff. In fact, it's quite conceivable that SGI could hook up a PCIe
> > 3.0 host bridge to the Altix NUMA interconnect, so that you could have
> > a PCI
On Fri, Jan 11, 2008 at 02:27:16PM -0600, Kumar Gala wrote:
>>> I'm getting the following message from the kernel on an embedded ppc32
>>> system:
>>>
>>> PCI: Failed to allocate mem resource #9:[EMAIL PROTECTED] for :00:00.0
>>>
>>> The HW setup is a PCIe host controller and an e1000 NIC
On Tue, Jan 29, 2008 at 09:50:40PM -0800, [EMAIL PROTECTED] wrote:
>
> Document the new dma_{un}map_{single|sg}_attrs() functions.
Thank you!
Looks good to me...so far I've only found one nit.
...
> +struct dma_attrs encapsulates a set of "dma attributes". For the
> +definition of struct
On Sat, Feb 02, 2008 at 03:56:38PM +0100, Santiago Garcia Mantinan wrote:
> Hi!
>
> I've been experiencing problems with this (internal) card ever since I
> bought this motherboard, lately I've been doing some tests and I found out
> some things, maybe not enough to let us debug this, but I'll
On Tue, Jan 15, 2008 at 10:56:41AM -0700, Matthew Wilcox wrote:
> On Tue, Jan 15, 2008 at 09:46:43AM -0800, Greg KH wrote:
> > But so far, we have a zillion patches floating around, claiming
> > different things, some with signed-off-bys and others without, so for
> > now, I'll just stick with
atches to pci.txt that add
pci_enable_device_io() and _mmio() as well. )
Signed-off-by: Grant Grundler <[EMAIL PROTECTED]>
diff --git a/Documentation/pci.txt b/Documentation/pci.txt
index 7754f5a..72b20c6 100644
--- a/Documentation/pci.txt
+++ b/Documentation/pci.txt
@@ -274,8 +274,6 @@ th
Just a style nit...
On Tue, Dec 18, 2007 at 10:01:14AM +1100, Benjamin Herrenschmidt wrote:
> This patch converts users of pci_enable_device_bars() to the new
> pci_enable_device_{io,mem} interface.
>
> The new API fits nicely, except maybe for the QLA case where a bit of
> code re-organization
On Tue, Dec 18, 2007 at 10:01:15AM +1100, Benjamin Herrenschmidt wrote:
> This patch changes the PowerPC PCI code to disable IO and/or Memory
> decoding on a PCI device when a resource of that type failed to be
> allocated. This is done to avoid having unallocated dangling BARs enabled
> that
On Sun, Dec 23, 2007 at 03:16:24PM -0500, Loic Prylli wrote:
...
> I just realized one thing: the bar sizing code in pci_read_bases() (that
> writes 0x in the bars) does not seem to disable the
> PCI_COMMAND_MEM/PCI_COMMAND_IO bits in the cmd register before
> manipulating the BARs. And it
On Thu, Dec 20, 2007 at 02:40:06PM -0800, Greg KH wrote:
> Sure, I realize this, but it solves the problem in one way for broken
> hardware, such that it at least allows it to work, right? It also
> provides a better incentive for the manufacturer to fix their bios,
> which as you are on-site at
On Wed, Dec 26, 2007 at 08:26:27AM +1100, Benjamin Herrenschmidt wrote:
>
> > This is exactly what's supposed to be happening, but the code is buggy
> > and nobody noticed :-) (I'm mixing up IORESOURCE_* flags and
> > PCI_COMMAND_* flags). Thanks for reviewing !
>
> Note that this patch isn't in
On Mon, Jan 28, 2008 at 05:20:36PM -0800, Jason Gaston wrote:
> This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.
Jason,
two questions:
Have you submitted these to pciids.sf.net?
Where are these used in the kernel?
thanks,
grant
>
> Signed-off-by: Jason Gaston <[EMAIL
On Jan 29, 2008 11:08 AM, Robert Hancock <[EMAIL PROTECTED]> wrote:
...
> The last solution I tried was to set the DMA mask on both ports to
> 32-bit on slave_configure when an ATAPI device is connected. However,
> this runs into complications as well. This is run on initialization and
> when
On Wed, Feb 06, 2008 at 07:44:47PM +0100, Santiago Garcia Mantinan wrote:
> > Is this perhaps the same problem as described here?
> > http://bugzilla.kernel.org/show_bug.cgi?id=5839
>
> Seems right.
>
> > If you think it is, could you add (just cut/paste)
> > you email to that bug for me?
>
On Thu, Feb 07, 2008 at 11:36:18AM -0500, Tony Camuso wrote:
> Arjan van de Ven wrote:
>> On Thu, 07 Feb 2008 10:54:05 -0500
>> Tony Camuso <[EMAIL PROTECTED]> wrote:
>>> Matthew,
>>>
>>> Perhaps I missed it, but did you address Yinghai's concerns?
>>>
>>> Yinghai Lu wrote:
On Jan 28, 2008
On Sun, Feb 10, 2008 at 07:51:22AM -0700, Matthew Wilcox wrote:
> From: Matthew Wilcox <[EMAIL PROTECTED]>
> Date: Sun, 10 Feb 2008 09:45:28 -0500
> Subject: [PATCH] Change pci_raw_ops to pci_raw_read/write
...
> -static int
> -pci_read (struct pci_bus *bus, unsigned int devfn, int where, int
i_read(0, 0, 0x40, 0x4c, 2, );
> + /*
> + * read xTPR register. We may not have a pci_dev for device 8
> + * because it might be hidden until the above write.
> + */
> + pci_bus_read_config_word(dev->bus, PCI_DEVFN(8, 0), 0x4c, );
Yeah, this should work eve
On Mon, Feb 11, 2008 at 09:18:49AM -0800, Linus Torvalds wrote:
> I put it in the commit message, but it wasn't on page 34 when I checked (I
> changed it to 69),
Sorry - page 34 was just the first reference to "Extended Configuration
Registers" when I originally scrounged up the info for willy.
Andrew,
Please include in -mm. "Cosmetic" - but I appreciate correct spelling too.
On Mon, Dec 17, 2007 at 11:30:11AM -0800, Joe Perches wrote:
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
Signed-off-by: Grant Grundler <[EMAIL PROTECTED]>
thanks,
grant
>
Andrew,
ditto - thanks
On Mon, Dec 17, 2007 at 11:40:10AM -0800, Joe Perches wrote:
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
Signed-off-by: Grant Grundler <[EMAIL PROTECTED]>
thanks again,
grant
> ---
> drivers/parisc/ccio-dma.c |4 ++--
> drive
On Wed, Jan 30, 2008 at 09:23:06PM +0100, Ondrej Zary wrote:
> On Saturday 26 January 2008 21:58:10 Ondrej Zary wrote:
> > Hello,
> > I was having problems with these FreedomLine cards with Linux before but
> > tested it thoroughly today. This card uses DEC 21041 chip and has TP and
> > BNC
On Tue, Oct 23, 2012 at 1:02 PM, Kees Cook wrote:
> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summit, remove it.
>
> CC: Grant Grundler
Acked-by: Grant Grundler
It clearly
>
> Signed-off-by: Peter Senna Tschudin
Thanks! Looks good to me.
Acked-by: Grant Grundler
cheers,
grant
>
> ---
> drivers/net/ethernet/dec/tulip/dmfe.c | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/e
[grrhmail...sorry! resending as plain text]
Hallo Oliver!
On Mon, Sep 25, 2017 at 7:51 AM, Oliver Neukum wrote:
> Am Freitag, den 22.09.2017, 12:06 -0700 schrieb Grant Grundler:
> > This Linksys dongle by default comes up in cdc_ether mode.
> > This patch allows r8152 to c
This linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ether.c | 8
drivers/net/usb/r8152.c | 2 ++
2 files changed, 10 insertions
On Mon, Sep 25, 2017 at 1:17 PM, Grant Grundler wrote:
...
> I didn't realize cdc_ether has a blacklist to make sure
> RTL8152|RTL8153 devices are not picked up by cdc_ether. Would you
> prefer I add this device to the blacklist in the same patch?
I've sent a V2 which also updates the
On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote:
> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson:
>>
>> I know that for at least some of the adapters in the CDC Ethernet
>> blacklist it was claimed that the CDC Ethernet support in the adapter
>> was kinda broken anyway so
This linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ether.c | 10 ++
drivers/net/usb/r8152.c | 2 ++
2 files changed, 12 insertions
Hi Doug!
On Wed, Sep 27, 2017 at 4:47 PM, Doug Anderson wrote:
> Hi,
>
> On Wed, Sep 27, 2017 at 10:28 AM, Grant Grundler
> wrote:
>> This linksys dongle by default comes up in cdc_ether mode.
>> This patch allows r8152 to claim the device:
>>Bus 002 De
Hi Ryan!
Just some questions inline - in general I like the reset function.
On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee wrote:
>
> Signed-off-by: Ryan Lee
> ---
> Changes : Created max98373_reset function to minimize code duplication.
>Changed regmap_write to regmap_update_bits.
I just realized I had one more question...
On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler wrote:
>
> Hi Ryan!
>
> Just some questions inline - in general I like the reset function.
>
> On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee
> wrote:
> >
> > Signed-off-b
On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee wrote:
>
> >-Original Message-
> >From: Mark Brown
> >Sent: Wednesday, November 28, 2018 1:50 AM
> >To: Ryan Lee
> >Cc: Liam Girdwood ; Jaroslav Kysela
> >; Takashi Iwai ; Grant Grundler
> >; Kun
f function 'usleep_range'
[-Werror,-Wimplicit-function-declaration]
usleep_range(1, 11000);
^
Including delay.h "fixes" this.
Signed-off-by: Grant Grundler
---
sound/soc/codecs/max98373.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/max98373.
[resending as plain/text - sorry]
On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote:
>
>
>
> On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote:
>>
>> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
>> > Commit ca917f9f
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote:
>
> On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote:
> > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote:
>
> > > Note that this isn't causing a warning upstream, presumably due to an
> > > impl
_strncmp since it is not, in fact, a strncmp.
+1 I think your analysis is correct. The function appears to be
checking against a black list of MAC addresses that has two "broken"
devices MAC addresses.
Acked-by: Grant Grundler
thanks,
grant
ps. I don't like how de4x5_bad_srom() is st
[resending text-only]
On Wed, Sep 2, 2015 at 3:07 PM, Grant Grundler wrote:
>
>
> On Wed, Sep 2, 2015 at 11:28 AM, Olof Johansson wrote:
> ...
>> > +/**
>> > + * struct mmc_ioc_combo_cmd - combo command information
>> > + * @num_of_cmds: number of comm
on as this seems to make
> sense. However, I left num_of_cmds as an 8-bit value unless someone has
> a need for more than 256 commands ;-)
Awesome - thanks! I saw that in the new version you posted. LGTM.
You or Ulf can add "Reviewed by: Grant Grundler http://vger.kernel.org/majordomo-inf
On Thu, Sep 10, 2015 at 1:24 AM, Jon Hunter wrote:
...
>> - you have some implicit padding after the structure and should replace that
>> with explictit pad bytes to extend the structure to a multiple of its
>> alignment (8 bytes).
>
> Would padding with __u32 at the end be sufficient here? I
On Thu, Sep 10, 2015 at 11:20 AM, Jon Hunter wrote:
>
> On 10/09/15 18:10, Grant Grundler wrote:
...
>>>>>> struct mmc_ioc_multi_cmd {
>>>>>> __u64 num_of_cmds;
>>>>>> struct mmc_ioc_cmd cmds[0];
>>>>>> };
&
icient).
>
> Signed-off-by: Seshagiri Holi
> Cc: Arnd Bergmann
> Cc: Grant Grundler
Reviewed-by: Grant Grundler
One comment below. two actually. ;)
> Cc: Olof Johansson
> [ jonath...@nvidia.com: Rebased on linux-next from v3.18. Changed
> userspace pointer type for mult
On Wed, Aug 12, 2015 at 10:00 AM, James Bottomley
wrote:
> On Wed, 2015-08-12 at 09:05 +0200, Christoph Hellwig wrote:
...
>> However the ccio (parisc) and sba_iommu (parisc & ia64) IOMMUs seem
>> to be operate mostly on virtual addresses. It's a fairly odd concept
>> that I don't fully grasp,
se that default but no
> longer warn about it.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Grant Grundler
thanks!
grant
> diff --git a/drivers/net/ethernet/dec/tulip/winbond-840.c
> b/drivers/net/ethernet/dec/tulip/winbond-840.c
> index 6aa887e0e1cb..9beb3d34d4ba 100644
>
omain maintains a list of iommu devices which are
> attached. This driver relies on the iommu core to ensure that all devices
> have detached before destroying a domain.
>
> Signed-off-by: Daniel Kurtz
> Signed-off-by: Simon Xue
Reviewed-by: Grant Grundler
There are some
us mistake.
Acked-by: Grant Grundler
>
> ---
> The semantic patch is difficult to summarize, but is available in the cover
> letter of this patch series.
>
> drivers/net/ethernet/dec/tulip/dmfe.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sun, Dec 7, 2014 at 11:20 AM, Julia Lawall wrote:
> Replace a misspelled function name by %s and then __func__.
Patch is correct but this commit message is not. Please correct and
add my Ack-by.
cheers,
grant
> This was done using Coccinelle, including the use of Levenshtein distance,
> as
[resending as plain text only - sorry]
Ping? Any feedback on this patch?
LGTM.
cheers,
grant
On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote:
> 'perms' will never be NULL since it isn't a plain pointer but an array
> of u32 values.
>
> This fixes the following warning when building
On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore wrote:
> On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote:
>> Ping? Any feedback on this patch?
>
> It's on my list of patches to review, patience please.
No problem! Thank you!
just wanted confirmation it wasn't overlooked.
Ping? Any feedback on this patch?
Is this in someone's queue for review?
thanks,
grant
On Tue, Mar 14, 2017 at 12:40 PM, Matthias Kaehlcke wrote:
> jiffies_64 is defined in kernel/time/timer.c with
> cacheline_aligned_in_smp,
> however this macro is not part of the declaration of jiffies
On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote:
> Matthias Kaehlcke wrote:
>> The value passed by the two callers of the function is unsigned anyway.
>
> Indeed; and those are just simple wrappers.
>
>> Making the parameter unsigned fixes the following warning when building
>> with
Local "#define DRIVER_LICENSE" obfuscates which license is used
in MODULE_LICENSE(). "fgrep -R MODULE_LICENSE" is more informative
when the string is hard coded in MODULE_LICENSE.
Signed-off-by: Grant Grundler
---
Most of the kernel already uses hard coded strings.
The f
On Thu, Mar 23, 2017 at 11:54 PM, Greg Kroah-Hartman
wrote:
> On Thu, Mar 23, 2017 at 02:47:39PM -0700, Grant Grundler wrote:
>> On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote:
>> > Matthias Kaehlcke wrote:
>> >> The value passed by the two callers of t
On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä
wrote:
> On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote:
>> El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit:
>>
>> > In several instances the driver passes an 'enum pipe' value to a
>> > function expecting an
On Fri, May 5, 2017 at 1:08 PM, Ville Syrjälä
wrote:
...
>> > I'm not convinced the patch is making things any better really. To
>> > fix this really properly, I think we'd need to introduce a new enum
>> > pch_transcoder and thus avoid the confusion of which type of
>> > transcoder we're talking
On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote:
> On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote:
>
>> I'm not quite sure how the first From line was added, it
>> should not have been.
>> Grant Grundler is most definitely the author.
>>
>> Would you
Ping? Any additional feedback?
We've been holding off putting this code into ChromeOS since I'm happy
to integrate (just about) any addtional feedback on the code or DT
entries.
thanks!
grant
On Tue, May 10, 2016 at 7:07 PM, Grant Grundler wrote:
> From: Daniel Hung-yu Wu
>
> Add I
On Tue, May 3, 2016 at 7:01 PM, Guenter Roeck wrote:
> On 05/03/2016 06:36 PM, Grant Grundler wrote:
>>
>> Ping? Did this change get accepted?
>>
>
> Hi Grant,
>
> Should be. It is in my watchdog-next branch. I plan to send
> a pull request to Wim early next w
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote:
> On Tue, May 03, 2016 at 10:13:31AM -0700, Grant Grundler wrote:
>> Add I2C driver for AtmegaXX capacitive touch device.
>>
>> Signed-off-by: Hung-yu Wu
>> Signed-off-by: Grant Grundler
>> ---
>> .../bin
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote:
...
>> +Required properties:
>> +
>> + compatible: Must be "atmel,atmegaxx_captouch".
>
> No wildcards in the compatible strings. Use the specific devices.
>
> Also, use hyphen rather than underscore. However, if the device is only
> a
On Fri, May 6, 2016 at 2:19 AM, Nicolas Ferre wrote:
...
> Is it different from the Atmel QT1070 or QT2160 which have drivers
> already available in Linux: drivers/input/keyboard/qt1070.c
Yes. What Daniel said. I would describe it as "probe code and
interrupt handling protocol are different"
On Mon, May 9, 2016 at 9:29 AM, Dmitry Torokhov
wrote:
> On Fri, May 06, 2016 at 11:14:12PM +0800, Daniel Hung-yu Wu wrote:
>> The register set is different, and this chip does not support calibration.
>> The I2C protocol is not the same as well; there is an additional byte
>> indicating data
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 11 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
From: Daniel Hung-yu Wu
Add binding for Atmel Capacitive Touch Button device.
Signed-off-by: Daniel Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../devicetree/bindings/input/atmel,captouch.txt | 34 ++
1 file changed, 34 insertions(+)
create mode 100644 Documentation
Add I2C driver for AtmegaXX capacitive touch device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../bindings/input/atmel,atmegaxx_captouch.txt | 34 +++
drivers/input/misc/Kconfig | 11 +
drivers/input/misc/Makefile| 1
Ping? Did this change get accepted?
cheers,
grant
On Tue, Apr 5, 2016 at 12:07 PM, Grant Grundler wrote:
> On Mon, Apr 4, 2016 at 5:37 PM, Guenter Roeck wrote:
>> The Qualcom watchdog timer block reports if the system was reset by the
>> watchdog. Pass the information to user
[plain text this time...]
On Sat, May 14, 2016 at 9:35 AM, Wim Van Sebroeck wrote:
>
> Hi Guenter,
>
> > The Qualcom watchdog timer block reports if the system was reset by the
> > watchdog. Pass the information to user space.
> >
> > Cc: Grant Grundler
On Sat, May 14, 2016 at 7:52 AM, Rob Herring wrote:
> On Tue, May 10, 2016 at 07:07:48PM -0700, Grant Grundler wrote:
>> From: Daniel Hung-yu Wu
>>
>> Add binding for Atmel Capacitive Touch Button device.
>>
>> Signed-off-by: Daniel Hung-yu Wu
From: Daniel Hung-yu Wu
Add binding for Atmel Capacitive Touch Button device.
Signed-off-by: Daniel Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../devicetree/bindings/input/atmel,captouch.txt | 36 ++
1 file changed, 34 insertions(+)
create mode 100644 Documentation
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 13 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 13 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
On Wed, May 18, 2016 at 2:59 PM, Dmitry Torokhov
wrote:
> On Tue, May 17, 2016 at 12:29:32PM -0700, Grant Grundler wrote:
>> From: Daniel Hung-yu Wu
>>
>> Add I2C driver for Atmel Capacitive Touch Button device.
>>
>> Signed-off-by: Hung-yu Wu
>> Sig
On Wed, May 18, 2016 at 2:59 PM, Dmitry Torokhov
wrote:
> On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
>> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
>> > From: Daniel Hung-yu Wu
>> >
>> > Add binding for Atmel Capacitive T
On Tue, Dec 1, 2015 at 12:44 PM, Helge Deller wrote:
> On 01.12.2015 17:41, Bjorn Helgaas wrote:
>> There are no callers of pcibios_init_bus(), so remove it.
>
> True, pcibios_init_bus() isn't called anywhere, so it should be removed.
>
> But I wonder if we might need to initialize latency and
On Wed, Oct 21, 2015 at 2:00 AM, Ulf Hansson wrote:
To put a few more numbers on the "chunk size vs perf":
1EG (512KB) -> 44K commands -> ~20 minutes
32EG (16MB) -> 1375 commands -> ~1 minute
128EG (64MB) -> 344 commands -> ~30 seconds
8191EG (~4GB) -> 6 commands ->
On Tue, Oct 20, 2015 at 11:57 AM, Jeff Moyer wrote:
> Hi Grant,
>
> Grant Grundler writes:
>
>> Ping? Does no one care how long BLK_SECDISCARD takes?
>>
>> ChromeOS has landed this change as a compromise between "fast" (<10
>> seconds) and &
roblem if we care about data privacy since
consumers won't expect a "secure erase" operation to take 1/2h or more
and think the device is hung.
cheers,
grant
On Mon, Sep 28, 2015 at 2:45 PM, Grant Grundler wrote:
> [resending...I forgot to switch gmail back to text-only mode. grrrh
On Fri, Nov 6, 2015 at 4:22 AM, Vishnu Pratap Singh
wrote:
> This patch handles blk_register_region() return value.
> Earlier blk_register_region() function doesn't handle error
> cases, now it is added, so the callers of this function
> should also handle it.
>
> Verfied on X86 based ubuntu
Awesome! Thanks Ulf! :)
cheers
grant
On Mon, Oct 5, 2015 at 3:55 AM, Ulf Hansson wrote:
> On 24 September 2015 at 03:30, Grant Grundler wrote:
>> MMC_IOC_CMD and MMC_IOC_MULTI_CMD ioctl() code currently bails on
>> any eMMC errors. However, in case there is any resp[] dat
From: Grant Grundler
I haven't had any PCI tulip HW for the past ~5 years. I have
been reviewing tulip patches and can continue doing that.
Signed-off-by: Grant Grundler
---
I'm also proposing to add linux-parisc to the list since AFAIK, all
parisc systems but the C8000 workstations (PA8800
On Thu, Nov 19, 2015 at 6:29 PM, Florian Fainelli wrote:
> On 19/11/15 17:56, Grant Grundler wrote:
>> From: Grant Grundler
>>
>> I haven't had any PCI tulip HW for the past ~5 years. I have
>> been reviewing tulip patches and can continue doing that.
>>
On Mon, Apr 4, 2016 at 5:37 PM, Guenter Roeck wrote:
> The Qualcom watchdog timer block reports if the system was reset by the
> watchdog. Pass the information to user space.
>
> Cc: Grant Grundler
> Signed-off-by: Guenter Roeck
Reviewed-by: Grant Grundler
Tested-by: Grant Gr
On Fri, Jul 15, 2016 at 2:25 PM, David Miller wrote:
> From: Grant Grundler
> Date: Thu, 14 Jul 2016 11:27:16 -0700
>
>> ethtool -i provides a driver version that is hard coded.
>> Export the same value via "modinfo".
>>
>> Signed-off-by: Grant Gr
[as plain text this time...]
Robert,
On Mon, Jul 25, 2016 at 10:40 AM, wrote:
> From: Grant Grundler
For the record, I believe I am not the author of these patches.
I believe the original author is
Signed-off-by: Freddy Xin
as recorded in the following code reviews (and test
On Mon, Jul 25, 2016 at 10:40 AM, wrote:
> From: Vincent Palatin
>
> Check the answers from the USB stack and avoid re-sending multiple times
> the request if the device has disappeared.
>
> Signed-off-by: Vincent Palatin
The original chromium.org code review:
oglesource.com/#/q/Fix+AX88772x+resume+failures
And has substantial meta data regarding author and reviewers:
(summarized from https://chromium-review.googlesource.com/#/c/314520/)
Signed-off-by: Allan Chou
Signed-off-by: WK Tsai
Tested-by: Grant Grundler
Reviewed-by: Wang-Kai Tsai
Reviewed-b
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote:
...
> Thanks for the feedback (for this patch and the other ones)!
> I'm preparing a v2 and will submit it withing a day or two.
Excellent! very welcome and thanks again for picking this up.
...
>> FTR, current drivers/net/usb/ax88179_178a.c
ethtool -i provides a driver version that is hard coded.
Export the same value via "modinfo".
Signed-off-by: Grant Grundler
---
drivers/net/usb/r8152.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0da72d3..1c01
On Thu, Jun 2, 2016 at 5:27 PM, Gwendal Grignou wrote:
> If available, eMMC stack uses HC_ERASE_GRP_SIZE as preferred erase size.
> However, that size is the minimal size we must use, not the optimal size.
> Calculate the optimal size based on whole device size and fall back to
>
Hayes Wang realtek.com> writes:
> Replace using VID/PID with using tp->version to initialize the ops.
Hayes,
This patch breaks new HW with existing drivers. more below.
>
> Signed-off-by: Hayes Wang realtek.com>
> ---
> drivers/net/usb/r8152.c | 79
Jon, Ulf,
Can we first get the current implementation upstream and _then_ add
more patches to it?
On Mon, Sep 21, 2015 at 4:19 AM, Jon Hunter wrote:
...
+ for (i = 0; i < num_of_cmds; i++) {
+ err = __mmc_blk_ioctl_cmd(card, md, idata[i]);
+ if
Jens, Ulf,
I've run into a basic issue: BLK_SECDISCARD takes 15-35 minutes
perform a secure erase of ~23GB (mostly empty) partition on a 32GB
eMMC part (happens with two vendors). One of the vendors says it
should take less than 60 seconds. I've confirmed erasing 2GB takes
only ~6 seconds - so
On Wed, Sep 23, 2015 at 2:42 PM, Ulf Hansson wrote:
> On 22 September 2015 at 11:27, Jon Hunter wrote:
>> Certain eMMC devices allow vendor specific device information to be read
>> via a sequence of vendor commands. These vendor commands must be issued
>> in sequence and an atomic fashion. One
On Wed, Sep 23, 2015 at 2:42 PM, Ulf Hansson wrote:
> On 22 September 2015 at 11:27, Jon Hunter wrote:
>> Certain eMMC devices allow vendor specific device information to be read
>> via a sequence of vendor commands. These vendor commands must be issued
>> in sequence and an atomic fashion. One
On Wed, Sep 23, 2015 at 3:26 PM, Ulf Hansson wrote:
...
>> Ulf,
>> is the git repo visible publicly?
>
> git://git.linaro.org/people/ulf.hansson/mmc.git
Sorry - my bad : I had looked at mmc.git and saw "2014-10-15" as the
last commit.
Scrolling down to the bottom of the page shows the "next"
in both cases.
Gwendal Grignou provided the idea and it was previously implemented
and tested on v3.18 ChromeOS kernel:
https://chromium-review.googlesource.com/#/c/299956
Signed-off-by: Grant Grundler
Reviewed-by: Hyung Taek Ryoo
Reviewed-by: Gwendal Grignou
Tested-by: David Riley
---
I
501 - 600 of 626 matches
Mail list logo
