Re: [PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:13:59PM +0530, Anirudh Rayabharam wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index()

Re: [PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:13:59PM +0530, Anirudh Rayabharam wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index()

Re: [PATCH 1/4] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 08:45:51PM +0800, Yicong Yang wrote: > +static int hisi_ptt_create_trace_entries(struct hisi_ptt *hisi_ptt) > +{ > + struct hisi_ptt_debugfs_file_desc *trace_files; > + struct dentry *dir; > + int i, ret = 0; > + > + dir = debugfs_create_dir("trace",

Re: [PATCH 0/4] Add support for HiSilicon PCIe Tune and Trace device

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 08:45:50PM +0800, Yicong Yang wrote: > HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex > integrated Endpoint(RCiEP) device, providing the capability > to dynamically monitor and tune the PCIe traffic(tune), > and trace the TLP headers(trace). The driver

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:42:59PM +0600, Zhansaya Bagdauletkyzy wrote: > Match next line with open parentheses by adding tabs/spaces > to conform with Linux kernel coding style. > Reported by checkpatch. > > Signed-off-by: Zhansaya Bagdauletkyzy > --- > drivers/staging/greybus/camera.c | 10

Re: [PATCH 3/4] staging: rtl8723bs: core: reorganize characters so the lines are under 100 ch

2021-04-06 Thread Greg KH
On Mon, Apr 05, 2021 at 06:29:19PM +0100, Beatriz Martins de Carvalho wrote: > Cleans up warnings of "line over 100 characters" but avoinding > more than 90 characters in file rtw_ap.c > > Signed-off-by: Beatriz Martins de Carvalho > > --- > drivers/staging/rtl8723bs/core/rtw_ap.c | 22

Re: [PATCH] staging: sm750fb: Convert camel case to snake case

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote: > - struct dvi_ctrl_device *pCurrentDviCtrl; > + struct dvi_ctrl_device *p_current_dvi_ctrl; Does this change make sense? Why keep the "p_" here? We do not need or use, this type of variable naming in the kernel. Also,

Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-06 Thread 'Greg KH'
On Tue, Apr 06, 2021 at 09:25:18AM +, Pho Tran wrote: > Hi Greg! > Should I send the Patch with new version (PATCH v8) or keep version of the > Patch is v7? Again, please do not top-post. v8 is needed. thanks, greg k-h

Re: linux-next: manual merge of the tty tree with the net-next tree

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:48:14PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > net/nfc/nci/uart.c > > between commit: > > d3295869c40c ("net: nfc: Fix spelling errors in net/nfc module") > > from the net-next tree and

Re: linux-next: manual merge of the driver-core tree with the devicetree tree

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:19:45PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the driver-core tree got a conflict in: > > drivers/of/property.c > > between commit: > > 3915fed92365 ("of: property: Provide missing member description and remove > excess param")

Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-06 Thread 'Greg KH'
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? On Tue, Apr 06, 2021 at

Re: [RESEND PATCH v5 1/2] bio: limit bio max size

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 10:31:28AM +0900, Changheun Lee wrote: > > bio size can grow up to 4GB when muli-page bvec is enabled. > > but sometimes it would lead to inefficient behaviors. > > in case of large chunk direct I/O, - 32MB chunk read in user space - > > all pages for 32MB would be merged

Re: [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes

2021-04-05 Thread Greg KH
On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote: > "make versioncheck" shows: > > ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not > needed. Then you need to fix the tool, and always test-build patches before you send them out, as this is obviously wrong :(

Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-05 Thread Greg KH
On Tue, Apr 06, 2021 at 11:02:38AM +0700, Pho Tran wrote: > From: Pho Tran > > Similar to other CP210x devices, GPIO interfaces (gpiochip) should be > supported for CP2108. > > CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared > to all of those interfaces. So, just need to

Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 09:44:01AM -0300, Luiz Sampaio wrote: > On Mon, Apr 05, 2021 at 01:04:59PM +0200, Greg KH wrote: > > On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote: > > > Added a sysfs entry to support writing to the offset register on page1. > >

Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote: > Added a sysfs entry to support writing to the offset register on page1. > This register is used to calibrate the chip canceling offset errors in the > current ADC. This means that, over time, reading the IAD register will not > return

Re: [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 07:50:00AM -0300, Luiz Sampaio wrote: > The following patches aim to make a user able to calibrate the current > measurement of the DS2438. This chip uses a offset register in page1, which > is added to the current register to give the user the current measurement. If >

Re: [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 07:50:06AM -0300, Luiz Sampaio wrote: > Changed the permissions to preferred octal style. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/slaves/w1_ds2438.c

Re: [PATCH v4 2/9] w1: ds2438: fixed a coding style issue in iad_read

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 07:50:02AM -0300, Luiz Sampaio wrote: > Since there is only one statement inside the if clause, no brackets > are required. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) As this does the

Re: [PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements

2021-04-05 Thread Greg KH
On Sat, Apr 03, 2021 at 01:45:47AM -0300, Luiz Sampaio wrote: > The following patches aim to make a user able to calibrate the current > measurement of the DS2438. This chip uses a offset register in page1, which > is added to the current register to give the user the current measurement. If >

Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM

2021-04-05 Thread Greg KH
On Sun, Apr 04, 2021 at 10:20:26AM -0500, Dinh Nguyen wrote: > > > On 4/4/21 9:08 AM, Greg KH wrote: > > On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: > > > From: Krzysztof Kozlowski > > > > > > The Stratix10 service layer and RCU driv

Re: KASAN: use-after-free Read in cdev_del

2021-04-05 Thread Greg KH
On Sun, Apr 04, 2021 at 08:39:34PM +0800, Hillf Danton wrote: > On Sun, 4 Apr 2021 17:05:17 Hao Sun wrote: > > Besides, the 'refcount bug in cdev_del' bug still exists too. > > Thanks for your report, Hao. > > > > Here is the detailed information: > > commit:

Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements of condition.

2021-04-05 Thread Greg KH
On Sun, Apr 04, 2021 at 04:26:14PM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Fixed a coding style issue. Really? > > Signed-off-by: Dmitrii Wolf > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [PATCH] kpc2000: kpc2000: Removed extra blank line

2021-04-05 Thread Greg KH
On Sun, Apr 04, 2021 at 05:49:46PM -0500, David Villasana Jiménez wrote: > Fix checkpatch warning: > CHECK: Please don't use multiple blank lines > > Signed-off-by: David Villasana Jiménez > --- > drivers/staging/kpc2000/kpc2000/pcie.h | 1 - > 1 file changed, 1 deletion(-) Shouldn't the

Re: Patch "kbuild: Add resolve_btfids clean to root clean target" has been added to the 5.11-stable tree

2021-04-05 Thread Greg KH
On Sat, Apr 03, 2021 at 02:56:50PM -0400, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > kbuild: Add resolve_btfids clean to root clean target > > to the 5.11-stable tree which can be found at: > >

Re: [PATCH v6 1/4] usb: dwc3: of-simple: bail probe if no dwc3 child node

2021-04-05 Thread Greg KH
On Thu, Apr 01, 2021 at 11:36:49PM +0200, Johan Jonker wrote: > For some of the dwc3-of-simple compatible SoCs we > don't want to bind this driver to a dwc3 node, > but bind that node to the 'snps,dwc3' driver instead. > The kernel has no logic to decide which driver to bind > to if there are 2

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 01:52:39AM +, Min Li wrote: > > > > Any specific reason you are not using the misc_device api? That would clean > > up this driver a lot, there's no need to create a whole class just for a > > single > > driver. > > > > Hi Greg > > No specific reason. I just

Re: [PATCH] staging: qlge: remove else after break

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 06:11:43AM +0530, Mitali Borkar wrote: > linux-staging@lists,linux-kernel@vger.kernel.org > Bcc: > Subject: [PATCH] staging: qlge:remove else after break > Reply-To: Very odd, why is this in the body of the email? > > Fixed Warning:- else is not needed after break >

Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote: > From: Krzysztof Kozlowski > > The Stratix10 service layer and RCU drivers are useful only on > Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM > fails: > > drivers/firmware/stratix10-rsu.c: In function

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-04 Thread Greg KH
On Sat, Apr 03, 2021 at 06:08:34PM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide

Re: [BUG]: usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 11:29:00AM +0200, H. Nikolaus Schaller wrote: > it seems as if the patch > > 9de47c37 ("usb: dwc3: gadget: Prevent EP queuing while stopping > transfers") in v5.11.y > f09ddcfcb8c5 ("usb: dwc3: gadget: Prevent EP queuing while stopping > transfers") in

Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 08:15:00AM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Signed-off-by: Dmitrii Wolf > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Hi, This is the friendly patch-bot of Greg

Re: [PATCH 0/7] staging: media: zoran: Eliminate camelcase

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 12:08:57AM +0600, Zhansaya Bagdauletkyzy wrote: > This patchset fixes 'avoid camelcase' warning by converting local variables > to lowercase and separating words using '_'. > Renaming of each variable is implemented in separate patches. > > Zhansaya Bagdauletkyzy (7): >

Re: [PATCH] staging: rtl8188eu: replace goto with direct return

2021-04-04 Thread Greg KH
On Sat, Apr 03, 2021 at 10:40:08PM -0700, Deborah Brouwer wrote: > To conform with Linux kernel coding style, replace goto statement that > does no cleanup with a direct return. To preserve meaning, copy comments > from the original goto statement to the return statement. Identified by > the

Re: [PATCH] docs: driver-model: Update the documentation for device class

2021-04-03 Thread Greg KH
On Sat, Apr 03, 2021 at 05:30:50PM +0530, Manivannan Sadhasivam wrote: > The current documentation about the device class is out of date such > that it refers to non-existent APIs and structures. This commit updates > them to the current device class APIs and structures, removes wordings > that no

[GIT PULL] Driver core fix for 5.12-rc6

2021-04-03 Thread Greg KH
The following changes since commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b: Linux 5.12-rc4 (2021-03-21 14:56:43 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-5.12-rc6 for you to fetch changes up to

[GIT PULL] Char/Misc driver fixes for 5.12-rc6

2021-04-03 Thread Greg KH
The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git tags/char-misc-5.12-rc6 for you to fetch changes up to

[GIT PULL] Staging driver fix for 5.12-rc6

2021-04-03 Thread Greg KH
The following changes since commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b: Linux 5.12-rc4 (2021-03-21 14:56:43 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.12-rc6 for you to fetch changes up to

[GIT PULL] USB driver fixes for 5.12-rc6

2021-04-03 Thread Greg KH
The following changes since commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b: Linux 5.12-rc4 (2021-03-21 14:56:43 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.12-rc6 for you to fetch changes up to

[GIT PULL] Serial driver fix for 5.12-rc6

2021-04-03 Thread Greg KH
The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tags/tty-5.12-rc6 for you to fetch changes up to

Re: [PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery

2021-04-03 Thread Greg KH
On Fri, Apr 02, 2021 at 11:20:31PM -0700, Gwendal Grignou wrote: > When cros_ec_sysfs probe is called before cros_ec_sensorhub probe > routine, the |kb_wake_angle| attribute will not be displayed, even if > there are two accelerometers in the chromebook. > > Call sysfs_update_group() when

Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-03 Thread Greg KH
On Sat, Apr 03, 2021 at 09:48:06AM +0200, Fabio Aiuto wrote: > On Sat, Apr 03, 2021 at 09:40:08AM +0200, Greg KH wrote: > > On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote: > > > remove all RT_TRACE logs > > > > > > > I don't mean to be a pain,

Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-03 Thread Greg KH
On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote: > remove all RT_TRACE logs > I don't mean to be a pain, but this changelog text needs some work. This says _what_ it does, but not _why_ you are doing this. The kernel documentation has a section on how to write a good changelog

Re: [PATCH] firewire: nosy: Fix a use-after-free bug in nosy_ioctl()

2021-04-03 Thread Greg KH
On Sat, Apr 03, 2021 at 06:58:36AM +, Zheyu Ma wrote: > For each device, the nosy driver allocates a pcilynx structure. > A use-after-free might happen in the following scenario: > > 1. Open nosy device for the first time and call ioctl with command > NOSY_IOC_START, then a new client A

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-03 Thread Greg KH
On Fri, Apr 02, 2021 at 06:30:16PM +, Luis Chamberlain wrote: > On Fri, Apr 02, 2021 at 09:54:12AM +0200, Greg KH wrote: > > On Thu, Apr 01, 2021 at 11:59:25PM +, Luis Chamberlain wrote: > > > As for the syfs deadlock possible with drivers, this fixes it in a

Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 05:41:01PM +0200, Loic Poulain wrote: > On Fri, 2 Apr 2021 at 16:05, Greg KH wrote: > > > > On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote: > > > The MHI WWWAN control driver allows MHI QCOM-based modems to expose > > > differ

Re: [PATCH] zero-fill colormap in drivers/video/fbdev/core/fbcmap.c

2021-04-02 Thread Greg KH
On Wed, Mar 31, 2021 at 11:07:19PM +0100, Phillip Potter wrote: > Use kzalloc() rather than kmalloc() for the dynamically allocated parts > of the colormap in fb_alloc_cmap_gfp, to prevent a leak of random kernel > data to userspace under certain circumstances. > > Fixes a KMSAN-found infoleak

Re: [PATCH] drivers core: don't do anything in device_del() when device_add() fail

2021-04-02 Thread Greg KH
On Thu, Apr 01, 2021 at 09:01:38AM -0400, Yufen Yu wrote: > Recently, our syzbot test reported NULL pointer dereference in > device_del() by injecting memory allocation fail in device_add(). Don't do that :) > For now, callers of device_add(), such as add_disk(), may ignore > device_add()'s fail

Re: [PATCH] firmware: stratix10-svc: build only on 64-bit ARM

2021-04-02 Thread Greg KH
On Thu, Apr 01, 2021 at 10:13:29AM -0500, Dinh Nguyen wrote: > From: Krzysztof Kozlowski > > The Stratix10 service layer and RCU drivers are useful only on > Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM > fails: > > drivers/firmware/stratix10-rsu.c: In function

Re: [PATCH] firmware: qcom-scm: Fix QCOM_SCM configuration

2021-04-02 Thread Greg KH
On Wed, Mar 31, 2021 at 02:49:41AM -0400, He Ying wrote: > When CONFIG_QCOM_SCM is y while CONFIG_HAVE_ARM_SMCCC > is not set, compiling errors are encountered as follows: > > drivers/firmware/qcom_scm-smc.o: In function `__scm_smc_do_quirk': > qcom_scm-smc.c:(.text+0x36): undefined reference to

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-02 Thread Greg KH
On Mon, Mar 29, 2021 at 05:03:53PM +, Min Li wrote: > > > > Where is patch 1/2 of this series? > > > > Also, please fix up the errors that the testing bot found, and properly > > version > > your patch submission so I know which one is the "latest" one to look at. > > > > Hi Greg > > The

Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI QCOM-based modems to expose > different modem control protocols/ports via the WWAN framework, so that > userspace modem tools or daemon (e.g. ModemManager) can control WWAN > config and state

Re: [PATCH net-next v8 1/2] net: Add a WWAN subsystem

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 04:06:36PM +0200, Loic Poulain wrote: > This change introduces initial support for a WWAN framework. Given the > complexity and heterogeneity of existing WWAN hardwares and interfaces, > there is no strict definition of what a WWAN device is and how it should > be

Re: [PATCH] USB:ohci:fix ohci interruption problem

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 05:27:59PM +0800, Longfang Liu wrote: > The operating method of the system entering S4 sleep mode: > echo disk > /sys/power/state > > When OHCI enters the S4 sleep state, the USB sleep process will call > check_root_hub_suspend() and ohci_bus_suspend() instead of >

Re: [PATCH -next] staging/speakup: Switch to kmemdup_nul()

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 05:21:11PM +0800, Yang Yingliang wrote: > Use kmemdup_nul() helper instead of open-coding to > simplify the code. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/accessibility/speakup/i18n.c | 4 +--- > 1 file changed, 1 insertion(+), 3

Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 02:40:46PM +0200, Fabio Aiuto wrote: > On Fri, Apr 02, 2021 at 02:56:26PM +0300, Dan Carpenter wrote: > > On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > > > @@ -568,20 +561,11 @@ static s32 update_attrib_sec_info(struct adapter > > > *padapter, struct

Re: [PATCH] fs/debugfs: Convert to DEFINE_SHOW_ATTRIBUTE

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 08:11:41PM +0800, zuoqil...@163.com wrote: > From: zuoqilin Please use your full/real name. thanks, greg k-h

Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 01:10:51PM +0200, Daniel Lezcano wrote: > >> To answer your questions, there is a SoC vendor thermal daemon using > >> DTPM and there is a tool created to watch the thermal framework and read > >> the DTPM values, it is available at [4]. It is currently under > >>

Re: [PATCH] staging: fbtft: change snprintf() to scnprintf()

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 09:05:01AM +, Carlis wrote: > From: Xuezhi Zhang > > show() must not use snprintf() when formatting the value to > be returned to user space. Why not? The code is just fine as-is. > > Signed-off-by: Xuezhi Zhang > --- > drivers/staging/fbtft/fbtft-sysfs.c | 2 +-

Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 12:08:49AM +0200, Daniel Lezcano wrote: > > Hi Greg, > > On 01/04/2021 21:28, Greg KH wrote: > > On Thu, Apr 01, 2021 at 08:36:49PM +0200, Daniel Lezcano wrote: > >> A SoC can be differently structured depending on the platform and the > >

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-02 Thread Greg KH
On Thu, Apr 01, 2021 at 11:59:25PM +, Luis Chamberlain wrote: > As for the syfs deadlock possible with drivers, this fixes it in a generic > way: > > commit fac43d8025727a74f80a183cc5eb74ed902a5d14 > Author: Luis Chamberlain > Date: Sat Mar 27 14:58:15 2021 + > > sysfs: add

Re: [PATCH] media: pvrusb2: fix warning in pvr2_i2c_core_done

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 06:03:38PM +0530, Anirudh Rayabharam wrote: > syzbot has reported the following warning in pvr2_i2c_done: > > sysfs group 'power' not found for kobject '1-0043' > > When the device is disconnected (pvr_hdw_disconnect), the i2c adapter is > not unregistered along

Re: [PATCH 1/2] soundwire: add macro to selectively change error levels

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 01:43:53PM -0500, Pierre-Louis Bossart wrote: > > > > > My bigger issue with this is that this macro is crazy. Why do you need > > > > debugging here at all for this type of thing? That's what ftrace is > > > > for, do not sprinkle code with "we got this return value

Re: [PATCH 1/5] mm: reuse only-pte-mapped KSM page in do_wp_page()

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 11:17:37AM -0700, Suren Baghdasaryan wrote: > From: Kirill Tkhai > > Add an optimization for KSM pages almost in the same way that we have > for ordinary anonymous pages. If there is a write fault in a page, > which is mapped to an only pte, and it is not related to swap

Re: [PATCH v6 7/7] powercap/drivers/dtpm: Allow dtpm node device creation through configfs

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 08:36:54PM +0200, Daniel Lezcano wrote: > The DTPM framework is built on top of the powercap framework as a new > controller to act on the power of the devices. The approach is to > provide an unified API to do power limitation on devices which are > capable of that with

Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 08:36:49PM +0200, Daniel Lezcano wrote: > A SoC can be differently structured depending on the platform and the > kernel can not be aware of all the combinations, as well as the > specific tweaks for a particular board. > > The creation of the hierarchy must be delegated

Re: [PATCH 1/2] soundwire: add macro to selectively change error levels

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 01:07:49PM -0500, Pierre-Louis Bossart wrote: > > > > > > +#define sdw_dev_dbg_or_err(dev, is_err, fmt, ...) > > > > > \ > > > > > + do { > > > > > \ > > > > > + if (is_err)

Re: [PATCH 1/2] soundwire: add macro to selectively change error levels

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 09:30:27AM -0500, Pierre-Louis Bossart wrote: > > > On 4/1/21 2:24 AM, Vinod Koul wrote: > > On 31-03-21, 09:13, Bard Liao wrote: > > > From: Pierre-Louis Bossart > > > > > > We sometimes discard -ENODATA when reporting errors and lose all > > > traces of issues in the

Re: [PATCH] Revert "usb: dwc3: gadget: Prevent EP queuing while stopping transfers"

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 01:55:58PM +0200, Martin Kepplinger wrote: > This reverts commit 9de47c3737e0c0207beb03615b320cabe495. > You do not put a reason here, so I can not take this :( Please fix up and resend. thanks, greg k-h

Re: [PATCH 0/2] staging: media: omap4iss: Patchsets cleans up in iss.c

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 04:07:37PM +0100, Beatriz Martins de Carvalho wrote: > Clean up checks of "Alignment should match open parenthesis" and > "CHECK: Lines should not end with a '('" in iss.c > > Beatriz Martins de Carvalho (2): > staging: media: omap4iss: Ending line with argument >

Re: [PATCH v2] Revert "usb: dwc3: gadget: Prevent EP queuing while stopping transfers"

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 03:11:08PM +0200, Martin Kepplinger wrote: > commit 9de47c ("usb: dwc3: gadget: Prevent EP queuing while stopping > transfers") results in the below error every time I connect the type-c > connector to the dwc3, configured with serial and ethernet gadgets. > I also

Re: [PATCH] xhci: remove unused variable

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 06:17:15PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/usb/host/xhci.c:1346:15: warning: variable ‘len’ set but not > used [-Wunused-but-set-variable]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- >

Re: [PATCH] fix NULL pointer deference crash

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 09:21:54AM +0300, Hassan Shahbazi wrote: > On Wed, Mar 31, 2021 at 07:32:06PM +0200, Greg KH wrote: > > On Wed, Mar 31, 2021 at 07:34:29PM +0300, Hassan Shahbazi wrote: > > > The patch has fixed a NULL pointer deference crash in

Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

2021-04-01 Thread Greg KH
On Wed, Mar 31, 2021 at 10:46:48PM +0200, Daniel Lezcano wrote: > > Hi Greg, > > On 31/03/2021 20:06, Greg KH wrote: > > On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote: > >> +struct dtpm *dtpm_lookup(const char *name); > >> + > >> +int

Re: [PATCH -next v2] staging: greybus: camera: Switch to memdup_user_nul()

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 11:17:52AM +0800, Yang Yingliang wrote: > Use memdup_user_nul() helper instead of open-coding to > simplify the code. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/staging/greybus/camera.c | 13 +++-- > 1 file changed, 3

Re: [PATCH 0/3] Fix block comment warnings

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 01:05:34PM -0700, Deborah Brouwer wrote: > This patchset fixes checkpatch warnings arising > from the block comments Note, your 0/X email subject should also have the subsystem/driver prefix in there so that we know what this series is for. Much like your individual

Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote: > +struct dtpm *dtpm_lookup(const char *name); > + > +int dtpm_add(const char *name, struct dtpm *dtpm); > + > +void dtpm_del(const char *name); You can not add new kernel apis that have no user. How do you know if they actually

Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-31 Thread Greg KH
t; such node. There's no userspace portion here, so why talk about it? > > Cc: Greg KH > Signed-off-by: Daniel Lezcano > Reviewed-by: Lukasz Luba > --- > > V5: > - Decrease log level from 'info' to 'debug' > - Remove the refcount, it is pointless, lifetime cycle

Re: [PATCH] fix NULL pointer deference crash

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 07:34:29PM +0300, Hassan Shahbazi wrote: > The patch has fixed a NULL pointer deference crash in hiding the cursor. It > is verified by syzbot patch tester. > > Reported by: syzbot > https://syzkaller.appspot.com/bug?id=defb47bf56e1c14d5687280c7bb91ce7b608b94b > >

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 12:55:51PM +0200, Fabio Aiuto wrote: > On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > > replace private macro RT_TRACE for tracing with in-kernel > > > pr_* printk w

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 12:36:31PM +0200, Fabio Aiuto wrote: > On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > > replace private macro RT_TRACE for tracing with in-kernel > > > pr_* printk w

Re: [PATCH -next] staging: rtl8723bs: os_dep: remove unused variable 'ret'

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 05:42:47PM +0800, Yang Yingliang wrote: > GCC reports the following warning with W=1: > > drivers/staging/rtl8723bs/os_dep/recv_linux.c:101:6: warning: > variable ‘ret’ set but not used [-Wunused-but-set-variable] > 101 | int ret; > | ^~~ > > This variable

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > replace private macro RT_TRACE for tracing with in-kernel > pr_* printk wrappers > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_eeprom.c | 26 ++--- > 1 file changed, 13 insertions(+), 13

Re: [PATCH] binder: tell userspace to dump current backtrace when detecting oneway spamming

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 03:34:16PM +0800, Hang Lu wrote: > When async binder buffer got exhausted, some normal oneway transaction > will also be discarded and finally caused system/app stop. By that time, > the binder debug information we dump may not relevant to the root cause. > And this issue

Re: Memory leak in ath9k_hif_usb_dealloc_tx_urbs()

2021-03-31 Thread Greg KH
On Tue, Mar 30, 2021 at 10:36:52PM +0300, Pavel Skripkin wrote: > Hi! > > I did some debugging on this > https://syzkaller.appspot.com/bug?id=3ea507fb3c47426497b52bd82b8ef0dd5b6cc7ee > and, I believe, I recognized the problem. The problem appears in case of > ath9k_htc_hw_init() fail. In case of

Re: [PATCH] staging: rtl8723bs: fix block comments

2021-03-31 Thread Greg KH
On Tue, Mar 30, 2021 at 10:38:43PM -0700, Deborah Brouwer wrote: > Remove empty comment and fix checkpatch warnings: > WARNING: Block comments use * on subsequent lines > WARNING: Possible repeated word: 'very' > > Signed-off-by: Deborah Brouwer > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c

Re: [RFC PATCH v2 0/2] usb: typec: Add driver for Microchip sama7g5 tcpc

2021-03-31 Thread Greg KH
On Tue, Mar 30, 2021 at 11:54:40PM +0300, cristian.bir...@microchip.com wrote: > From: Cristian Birsan > > This patch set adds initial driver support for Microchip USB Type-C Port > Controller (TCPC) embedded in sama7g5 SoC. > > The controller does not implement power delivery and the driver

Re: [PATCH v2] wireless/nl80211.c: fix uninitialized variable

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 06:37:05PM +0200, Alaa Emad wrote: > This change fix KMSAN uninit-value in net/wireless/nl80211.c:225 , That > because of `fixedlen` variable uninitialized,So I initialized it by zero. > > Reported-by: syzbot+72b99dcf4607e8c77...@syzkaller.appspotmail.com > Signed-off-by:

Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 10:33:51AM -0600, Mathieu Poirier wrote: > On Tue, 30 Mar 2021 at 09:35, Greg KH wrote: > > > > On Tue, Mar 30, 2021 at 09:23:14AM -0600, Mathieu Poirier wrote: > > > On Tue, Mar 30, 2021 at 11:38:18AM +0100, Suzuki K Poulose wrote: > > &g

Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host

2021-03-30 Thread Greg KH
ns and Trace synchronization barrier (Patches 5 & 6) > > > > c) kvm-arm TRBE host support (Patch 7) > > > > d) TRBE driver support (and the ETE changes) > > > > > > (c) code merge depends on -> (a) + (b) > > (d) build (no conflicts) depends on ->

Re: [PATCH v1 1/4] docs: make reporting-issues.rst official and delete reporting-bugs.rst

2021-03-30 Thread Greg KH
igned-off-by: Thorsten Leemhuis > CC: Harry Wei > CC: Alex Shi > CC: Federico Vaga > CC: Greg KH Reviewed-by: Greg Kroah-Hartman

Re: [PATCH v1 1/4] docs: make reporting-issues.rst official and delete reporting-bugs.rst

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 04:13:04PM +0200, Thorsten Leemhuis wrote: > Removing Documentation/admin-guide/reporting-bugs.rst will break links > in some of the translations. I was unsure if simply changing them to > Documentation/admin-guide/reporting-issue.rst was wise, so I didn't > touch anything

Re: [PATCH 0/4] USB: serial: add support for multi-interface functions

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 04:38:16PM +0200, Johan Hovold wrote: > A single USB function can be implemented using a group of interfaces and > this is for example commonly used for Communication Class devices. > > This series adds support for multi-interface functions to USB serial > core and

Re: Compiling kernel-3.4.xxx with gcc-9.x. Need some help.

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 03:23:10PM +0200, Fawad Lateef wrote: > So can I still use kernel-3.4 compiled with gcc-5.5, and boot full > user-space with gcc-9.1? Yes, of course. > I was expecting it to be possible but might not work due to > incompatibility? As I know that when I tried to compile

Re: [PATCH] crypto: hisilicon - check if debugfs opened

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 08:40:07PM +0800, tanghui20 wrote: > > > On 2021/3/30 20:23, Greg KH wrote: > > On Tue, Mar 30, 2021 at 08:09:46PM +0800, tanghui20 wrote: > > > > > > > > > On 2021/3/28 23:09, Greg KH wrote: > > > > On

Re: [PATCH] crypto: hisilicon - check if debugfs opened

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 08:09:46PM +0800, tanghui20 wrote: > > > On 2021/3/28 23:09, Greg KH wrote: > > On Sat, Mar 27, 2021 at 04:33:00PM +0800, Hui Tang wrote: > > > 'xx_debugfs_init' check if debugfs opened. > > > > > > Signed-off-by: Hui Tang >

Re: [PATCH v26 07/13] mm/damon: Implement a debugfs-based user space interface

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 09:05:31AM +, sj38.p...@gmail.com wrote: > +static int __init __damon_dbgfs_init(void) > +{ > + struct dentry *dbgfs_root; > + const char * const file_names[] = {"monitor_on"}; > + const struct file_operations *fops[] = {_on_fops}; > + int i; > + > +

Re: [1/5] reporting-issues: header and TLDR

2021-03-30 Thread Greg KH
On Mon, Mar 29, 2021 at 04:44:21PM -0600, Jonathan Corbet wrote: > Thorsten Leemhuis writes: > > > FWIW, on another channel someone mentioned the process in the TLDR is > > quite complicated when it comes to regressions in stable and longterm > > kernels. I looked at the text and it seemed like

Re: Compiling kernel-3.4.xxx with gcc-9.x. Need some help.

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 09:20:32PM +0200, Fawad Lateef wrote: > Hi Greg, > > > > On Mon, 29 Mar 2021 at 06:57, Greg KH wrote: > > > > On Sun, Mar 28, 2021 at 10:20:50PM +0200, Fawad Lateef wrote: > > > Hi > > > > > > I am using a

Re: [PATCH] wireless/nl80211.c: fix uninitialized variable

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 08:41:38PM +0200, Alaa Emad wrote: > On Mon, 29 Mar 2021 at 20:20, Greg KH wrote: > > > On Mon, Mar 29, 2021 at 06:30:36PM +0200, Alaa Emad wrote: > > > Reported-by: syzbot+72b99dcf4607e8c77...@syzkaller.appspotmail.com > > > Signed-off-b

<    1   2   3   4   5   6   7   8   9   10   >