Re: [PATCH] usb: Add data checks in usbtmc_disconnect

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 08:47:17PM -0700, Lv Yunlong wrote: > In usbtmc_disconnect, data is got from intf with the > initial reference. There is no refcount inc operation > before usbmc_free_int(data). In usbmc_free_int(data), > the data may be freed. > > But later in usbtmc_disconnect, there is a

Re: [PATCH 1/3] w1: ds2438: fixed a coding style issues

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 11:42:09PM -0300, Luiz Sampaio wrote: > Fixed coding style issues. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 26 -- > 1 file changed, 12 insertions(+), 14 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah

Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 07:28:42PM +0100, Fabio Aiuto wrote: > On Mon, Mar 22, 2021 at 05:09:00PM +0100, Greg KH wrote: > > On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote: > > > fix the following checkpatch issues: > > > > > > WARNING: externs sh

Re: [PATCH] staging: wimax: Mundane typo fixes

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 09:14:43PM -0700, Randy Dunlap wrote: > On 3/22/21 6:06 PM, Bhaskar Chowdhury wrote: > > > > s/procesing/processing/ > > s/comunication/communication/ > > > > Signed-off-by: Bhaskar Chowdhury > > drivers/staging/wimax/ is in the process of being deleted. It's already go

Re: [PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote: > remove debug_priv argument so function prototype can be > easily moved away > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > dif

Re: [PATCH 04/11] staging: rtl8723bs: moved function prototypes out of core/rtw_recv.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:42PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 1190: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:1190: > +signed int validate_recv_mgnt_frame(struct adapter *padapter, union > recv_frame

Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40: > +u8 rtw_do_join(struct adapter *padapter); > > WARNING: externs should be avoided

Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > +bool > > moved two function prototypes in include/rtw_efuse.h > > Signed-off-by: Fa

Re: [PATCH 11/11] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:49PM +0100, Fabio Aiuto wrote: > remove unnecessary extern. > > The function is defined static in os_dep/os_intfs.c and used only once > in the same file > > remove also a blank line That needs to go to a separate patch :(

Re: [PATCH] staging: rtl8723bs: Mundane typo fixes

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 12:58:08PM +0530, Bhaskar Chowdhury wrote: > > s/stoping/stooping/ Huh? Are you _sure_ that is the correct replacement? Last I looked it wasn't... greg k-h

Re: [PATCH v4 2/2] staging: Add driver for XillyUSB (Xillybus variant for USB)

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 01:01:54PM +0200, Eli Billauer wrote: > Hello, Greg. > > Thanks for your comments. I'd like to address a couple of them. > > First, there's the lockless FIFO that is implemented in the driver: > > On 21/03/21 14:23, Greg KH wrote: > >

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 01:02:04PM +0200, Eli Billauer wrote: > On 21/03/21 14:24, Greg KH wrote: > > > +config XILLYBUS_CLASS > > > > + tristate > > > > + > > > >config XILLYBUS > > > > tristate "Xill

Re: [PATCH 5.10 267/290] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 07:16:25AM +0100, Christophe Leroy wrote: > > > Le 15/03/2021 à 15:15, Geert Uytterhoeven a écrit : > > On Mon, Mar 15, 2021 at 3:04 PM wrote: > > > From: Greg Kroah-Hartman > > > > > > From: Christophe Leroy > > > > > > commit bd73758803c2eedc037c2268b65a19542a832594

Re: [PATCH] Staging: wimax: i2400m: fixed a space coding style issue.

2021-03-22 Thread Greg KH
On Sun, Mar 21, 2021 at 09:26:02PM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Fixed a coding style. > > Signed-off-by: Dmitrii Wolf > --- > drivers/staging/wimax/i2400m/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wimax/i2400m

[GIT PULL] Staging/IIO driver fixes for 5.12-rc4

2021-03-21 Thread Greg KH
The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.12-rc4 for you to fetch changes up to 2cafd46a714a

[GIT PULL] USB/Thunderbolt driver fixes for 5.12-rc4

2021-03-21 Thread Greg KH
The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.12-rc4 for you to fetch changes up to 2b8c956ea6ba896ec18ae

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-21 Thread Greg KH
On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billa...@gmail.com wrote: > +EXPORT_SYMBOL(xillybus_init_chrdev); Given the license for this code, perhaps EXPORT_SYMBOL_GPL()? I have to ask :) thanks, greg k-h

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-21 Thread Greg KH
On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > This patch is a preparation for adding another related driver, XillyUSB. > In order to share some code between the existing Xillybus driver and the > one to be added, some functions are moved to xilly

Re: [PATCH v4 2/2] staging: Add driver for XillyUSB (Xillybus variant for USB)

2021-03-21 Thread Greg KH
On Thu, Mar 11, 2021 at 11:50:33AM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. > Even though it presents a nearly identical API on the FPGA and host, > it's almost a complete rewrite of the driver: The framewo

Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-21 Thread Greg KH
On Sat, Mar 20, 2021 at 03:49:12PM +0100, Fabio Aiuto wrote: > On Sat, Mar 20, 2021 at 11:59:44AM +0100, Greg KH wrote: > > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > > Hi, > > > > > > here's an issue in checkpatch.pl > >

Re: CHECKPATCH: missing a warning soon after include files decl -c

2021-03-20 Thread Greg KH
On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > Hi, > > here's an issue in checkpatch.pl > > $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c > > I get three warning related to an extern declaration > > WARNING: externs should be avoided in .c files > #14: F

Re: [PATCH stable 0/6] net: dsa: b53: Correct learning for standalone ports

2021-03-19 Thread Greg KH
On Tue, Mar 16, 2021 at 05:35:43PM -0700, Florian Fainelli wrote: > Hi Greg, Sasha, Jaakub and David, > > This patch series contains backports for a change that recently made it > upstream as f9b3827ee66cfcf297d0acd6ecf33653a5f297ef ("net: dsa: b53: > Support setting learning on port") however tha

Re: [RFC PATCH v5 1/4] topology: Represent clusters of CPUs within a die

2021-03-19 Thread Greg KH
On Fri, Mar 19, 2021 at 09:36:16AM +, Jonathan Cameron wrote: > On Fri, 19 Mar 2021 06:57:08 + > "Song Bao Hua (Barry Song)" wrote: > > > > -Original Message- > > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > Sent: Friday,

Re: Patch "arm64: Unconditionally set virtual cpu id registers" has been added to the 4.14-stable tree

2021-03-19 Thread Greg KH
On Fri, Mar 19, 2021 at 10:52:29AM +0100, gre...@linuxfoundation.org wrote: > > This is a note to let you know that I've just added the patch titled > > arm64: Unconditionally set virtual cpu id registers > > to the 4.14-stable tree which can be found at: > > http://www.kernel.org/git/?

Re: [PATCH 5.10 000/290] 5.10.24-rc1 review

2021-03-19 Thread Greg KH
On Mon, Mar 15, 2021 at 01:36:06PM -0700, Florian Fainelli wrote: > > > On 3/15/2021 6:51 AM, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.10.24 release. > > There are 290 patches in this series, all will be posted

Re: [PATCH 5.11 000/306] 5.11.7-rc1 review

2021-03-19 Thread Greg KH
On Tue, Mar 16, 2021 at 02:14:43PM -0700, Guenter Roeck wrote: > On Mon, Mar 15, 2021 at 02:51:03PM +0100, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.11.7 release. > > There are 306 patches in this series, all will

Re: [PATCH 4.19 000/120] 4.19.181-rc1 review

2021-03-19 Thread Greg KH
On Thu, Mar 18, 2021 at 07:59:59PM +0800, Samuel Zou wrote: > > > On 2021/3/15 21:55, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 4.19.181 release. > > There are 120 patches in this series, all will be posted as a r

Re: [PATCH] rtl8188eu: Removed Unnecessary ftrace-like logging

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 08:05:27PM +, Paul McQuade wrote: > prefer using ftrace You need to say more here than just this please. Also please fix up your subject line to have "staging:" in it, otherwise it gets easily lost. thanks, greg k-h

Re: [PATCH] X86: __set_clr_pte_enc() miscalculates physical address

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 01:26:57PM -0700, Isaku Yamahata wrote: > __set_clr_pte_enc() miscalculates physical address to operate. > pfn is in unit of PG_LEVEL_4K, not PGL_LEVEL_{2M, 1G}. > Shift size to get physical address should be PAGE_SHIFT, > not page_level_shift(). > > Fixes: dfaaec9033b8 ("x

Re: [PATCH] io_uring: Try to merge io requests only for regular files

2021-03-18 Thread Greg KH
On Fri, Mar 19, 2021 at 05:28:59AM +, Dmitry Monakhov wrote: > Otherwise we may endup blocking on pipe or socket. > > Fixes: 6d5d5ac ("io_uring: extend async work merge") > Testcase: > https://github.com/dmonakhov/liburing/commit/16d171b6ef9d68e6db66650a83d98c5c721d01f6 > Signed-off-by: Dmitr

Re: [RFC PATCH v5 1/4] topology: Represent clusters of CPUs within a die

2021-03-18 Thread Greg KH
On Fri, Mar 19, 2021 at 05:16:15PM +1300, Barry Song wrote: > diff --git a/Documentation/admin-guide/cputopology.rst > b/Documentation/admin-guide/cputopology.rst > index b90dafc..f9d3745 100644 > --- a/Documentation/admin-guide/cputopology.rst > +++ b/Documentation/admin-guide/cputopology.rst > @

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 09:02:22AM -0700, Florian Fainelli wrote: > > > On 3/18/2021 6:25 AM, Heiner Kallweit wrote: > > On 18.03.2021 10:09, Wong Vee Khee wrote: > >> When using Clause-22 to probe for PHY devices such as the Marvell > >> 88E2110, PHY ID with value 0 is read from the MII PHYID re

Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

2021-03-18 Thread Greg KH
On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote: > Only send "X1000_I2C_DC_STOP" when last byte, or it will cause > error when I2C write operation. > > Fixes: 21575a7a8d4c ("I2C: JZ4780: Add support for the X1000.") > > Signed-off-by: 周琰杰 (Zhou Yanjie) > --- > drivers/i2c/buss

Re: staging: rtl8723bs: prefer ftrace

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 10:14:15AM +0100, Fabio Aiuto wrote: > Hi, > > some suggestions before diving in a new task. > The following checkpatch issue: > > -- > WARNING: Unnecessary ftrace-like logging - prefer using ftrace > #559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559: > + DBG_871

Re: [PATCH 4.14 00/95] 4.14.226-rc1 review

2021-03-17 Thread Greg KH
On Thu, Mar 18, 2021 at 01:54:34PM +0800, Samuel Zou wrote: > > > On 2021/3/17 23:36, Greg KH wrote: > > On Tue, Mar 16, 2021 at 02:35:36PM +0800, Samuel Zou wrote: > > > > > > > > > On 2021/3/15 21:56, gre...@linuxfoundation.org wrote: > > >

Re: [PATCH char-misc v1] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-17 Thread Greg KH
On Wed, Mar 17, 2021 at 05:14:34PM -0400, min.li...@renesas.com wrote: > +static int > +rsmu_open(struct inode *iptr, struct file *fptr) > +{ > + struct rsmu_cdev *rsmu; > + > + rsmu = container_of(iptr->i_cdev, struct rsmu_cdev, rsmu_cdev); > + if (!rsmu) > + return -EAGAIN

Re: [PATCH net-next v1] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-17 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Mar 17, 2021 at 07:34

Re: [PATCH net-next v1] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-17 Thread Greg KH
On Wed, Mar 17, 2021 at 02:59:56PM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide support

Re: [PATCH 5.10 081/290] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-17 Thread Greg KH
On Mon, Mar 15, 2021 at 05:32:09PM +0100, Bartosz Golaszewski wrote: > On Mon, Mar 15, 2021 at 4:01 PM Marek Vasut wrote: > > > > On 3/15/21 2:52 PM, gre...@linuxfoundation.org wrote: > > > From: Greg Kroah-Hartman > > > > > > From: Andy Shevchenko > > > > > > commit b41ba2ec54a70908067034f139aa

Re: [PATCH 4.9 00/78] 4.9.262-rc1 review

2021-03-17 Thread Greg KH
On Mon, Mar 15, 2021 at 01:42:20PM -0700, Florian Fainelli wrote: > > > On 3/15/2021 6:51 AM, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 4.9.262 release. > > There are 78 patches in this series, all will be posted

Re: [PATCH 4.14 00/95] 4.14.226-rc1 review

2021-03-17 Thread Greg KH
On Tue, Mar 16, 2021 at 02:35:36PM +0800, Samuel Zou wrote: > > > On 2021/3/15 21:56, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 4.14.226 release. > > There are 95 patches in this series, all will be posted as a re

Re: staging: rtl8723bs: remove unused code blocks completed?

2021-03-17 Thread Greg KH
On Wed, Mar 17, 2021 at 10:59:32AM +0100, Fabio Aiuto wrote: > Hi, > > I'm trying to search other unused code blocks: > > grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' > drivers/staging/rtl8723bs/ > > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) > drivers/sta

Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 08:02:14PM +0200, Mihai Carabas wrote: > La 16.03.2021 19:29, Greg KH a scris: > > On Tue, Mar 16, 2021 at 07:08:38PM +0200, Mihai Carabas wrote: > > > ..snip.. > > > > > +}; > > > > > +static unsigned int capability = PV

Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 07:08:38PM +0200, Mihai Carabas wrote: > ..snip.. > > > +}; > > > +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED; > > > +static unsigned int events; > > > + > > > +static ssize_t capability_show(struct device *dev, > > > +st

Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 02:20:29PM +0200, Mihai Carabas wrote: > Add support for pvpanic PCI device added in qemu [1]. At probe time, obtain > the > address where to read/write pvpanic events and pass it to the generic handling > code. Will follow the same logic as pvpanic MMIO device driver. At r

Re: [PATCH v5 2/3] misc/pvpanic: probe multiple instances

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 02:20:28PM +0200, Mihai Carabas wrote: > Create the mecahism that allows multiple pvpanic instances to call > pvpanic_probe and receive panic events. A global list will retain all the > mapped addresses where to write panic events. > > Signed-off-by: Mihai Carabas > --- >

Re: [PATCH v5 1/3] misc/pvpanic: split-up generic and platform dependent code

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 02:20:27PM +0200, Mihai Carabas wrote: > +#ifdef pr_fmt > +#undef pr_fmt > +#endif > + > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt This isn't even needed given you do not have any pr_* calls in this code. As you shouldn't this is driver stuff, you should always use the

Re: [PATCH 5.11 000/306] 5.11.7-rc1 review

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 01:34:31PM +0100, Ronald Warsow wrote: > Hallo > > 5.11.7-rc1 compiles, boots and works fine here (Intel i7-6700) > > alas a fix doesn't made it in (correct english ?), but AFAIK it's known > and queued in drm-next or so > > bug/error (since 5.11.1 or 2): > > i915 :0

Re: [PATCH 00/15] staging: rtl8723bs: remove unused code blocks

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 11:13:49AM +0100, Fabio Aiuto wrote: > Remove unused code blocks as required in TODO file > > Fabio Aiuto (15): > staging: rtl8723bs: remove unused code blocks conditioned by never set > CONFIG_AUTO_AP_MODE > staging: rtl8723bs: remove unused code blocks conditioned

Re: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote: > remove conditional code blocks checked by unused CONFIG_PM > > cleaning required in TODO file: > > find and remove code blocks guarded by never set CONFIG_FOO defines > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs

Re: [PATCH] staging: rts5208: add empty line in general.c

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 07:12:20PM +0800, Hao Peng wrote: > Add one empty line upon return for easy reading. Why? Is this really needed?

Re: [PATCH] staging: rtl8192e: remove extra space in rtl819x_BAProc.c

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 06:33:20PM +0800, Hao Peng wrote: > Remove extra spaces in rtl819x_BAProc.c. That says what you did, but not _why_ you are doing this. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in or

Re: [PATCH] staging: rtl8192e: remove extra lines in rtl819x_BAProc.c

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 07:04:18PM +0800, Hao Peng wrote: > Remove extra lines in rtl819x_BAProc.c. > > Signed-off-by: Hao Peng Same issue here, please fix up the changelog text.

Re: [PATCH v2] staging:rtl8723bs:core:rtw_wlan_util:fixed indentation coding style issue

2021-03-16 Thread Greg KH
On Sun, Mar 14, 2021 at 09:58:55PM +0530, Shreya wrote: > Fixed the indentation of the else part of the conditional statement. > > Signed-off-by: Shreya > --- > v1 -> v2: > Changed name in signed-off-by to match name in From No, change it the other way around, you had your "real" name in the sig

Re: [PATCH] staging: rtl8192u: remove extra lines

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 05:59:22PM +0800, zhaoxiao wrote: > Remove extra lines in the struct r8192_private_args. > > Signed-off-by: zhaoxiao > --- > drivers/staging/rtl8192u/r8192U_wx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_wx.c > b/drivers/

Re: [PATCH 4.19 011/120] tcp: annotate tp->copied_seq lockless reads

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 10:41:37AM +0100, Pavel Machek wrote: > Hi! > > > From: Greg Kroah-Hartman > > > > From: Eric Dumazet > > Two From: fields here. This is a side-affect of me using git-send-email to talk to the remote smtp server directly instead of using my local email server. This wa

driverdev mailing list is moving!

2021-03-15 Thread Greg KH
Hi all, After almost 14 years of being hosted by OSUOSL, the driverdev mailing list is moving to lists.linux.dev. This should help out with the occasional mailman issues that driverdev had at times, and is one of the first lists to help stress-test the new linux.dev mailing lists infrastructure.

Re: Patch "net: bonding: fix error return code of bond_neigh_init()" has been added to the 5.11-stable tree

2021-03-15 Thread Greg KH
On Sun, Mar 14, 2021 at 11:10:50PM -0400, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > net: bonding: fix error return code of bond_neigh_init() > > to the 5.11-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kerne

Re: [GIT PULL] extcon fixes for v5.12-rc4

2021-03-15 Thread Greg KH
On Mon, Mar 15, 2021 at 11:37:18AM +0900, Chanwoo Choi wrote: > Dear Greg, > > This is extcon-fixes pull request for v5.12. I add detailed description of > this pull request on below. Please pull extcon with following updates. > > Best Regards, > Chanwoo Choi > > > The following changes since c

Re: [PATCH] staging: rtl8192u: remove extra lines

2021-03-15 Thread Greg KH
On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote: > Remove extra lines in many functions in r8192U_wx.c. > Signed-off-by: zhaoxiao You did mor than just remove extra lines :( Also we need an extra line right before your signed-off-by line, as checkpatch should have warned you about. Ple

Re: [PATCH] staging: vt6655: Fix camelcase

2021-03-14 Thread Greg KH
On Sat, Mar 13, 2021 at 12:30:19PM -0600, Madhumitha Prabakaran wrote: > Fix checkpatch.pl - Avoid CamelCase: > > Signed-off-by: Madhumitha Prabakaran > --- > drivers/staging/vt6655/baseband.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6655

Re: [PATCH] staging:rtl8723bs:core:rtw_wlan_util:fixed indentation coding style issue

2021-03-14 Thread Greg KH
On Sat, Mar 13, 2021 at 10:44:53PM +0530, Shreya wrote: > Fixed the indentation of the else part of the conditional statement. > > Signed-off-by: Shreya Ajith This name does not match your "From:" email name :( Please fix up and resend. thanks, greg k-h

Re: [PATCH v2 0/4] staging: rtl8723bs: remove unused code blocks

2021-03-14 Thread Greg KH
On Fri, Mar 12, 2021 at 07:33:13PM +0100, Fabio Aiuto wrote: > This patch set removes unused code blocks as required in TODO file: > > find and remove code blocks guarded by never set CONFIG_FOO defines > > Changes in v2: > - modified sunject lines to make them unique > - added

Re: [BUG] net: rds: rds_send_probe memory leak

2021-03-14 Thread Greg KH
On Sun, Mar 14, 2021 at 03:19:05PM +0300, Fatih Yildirim wrote: > On Sun, 2021-03-14 at 09:36 +0100, Greg KH wrote: > > On Sun, Mar 14, 2021 at 11:23:10AM +0300, Fatih Yildirim wrote: > > > Hi Santosh, > > > > > > I've been working on a memory

Re: [BUG] net: rds: rds_send_probe memory leak

2021-03-14 Thread Greg KH
On Sun, Mar 14, 2021 at 11:23:10AM +0300, Fatih Yildirim wrote: > Hi Santosh, > > I've been working on a memory leak bug reported by syzbot. > https://syzkaller.appspot.com/bug?id=39b72114839a6dbd66c1d2104522698a813f9ae2 > > It seems that memory allocated in rds_send_probe function is not freed.

Re: [PATCH] staging: octeon-usb: fixed precedence issue

2021-03-14 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH] staging: octeon-usb: fixed precedence issue

2021-03-13 Thread Greg KH
On Sat, Mar 13, 2021 at 11:02:47PM +0530, Selvakumar Elangovan wrote: > Added parenthesis around reg macro to avoid precedence issue identified by > checkpatch.pl > > Signed-off-by: Selvakumar Elangovan > --- > drivers/staging/octeon-usb/octeon-hcd.h | 16 > 1 file changed, 8 in

[GIT PULL] Char/Misc driver fixes for 5.12-rc3

2021-03-13 Thread Greg KH
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git tags/char-misc-5.12-rc3 for you to fetch changes up to 65527a51

[GIT PULL] Staging driver fixes for 5.12-rc3

2021-03-13 Thread Greg KH
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.12-rc3 for you to fetch changes up to 16d7586dccf8

[GIT PULL] TTY / Serial driver fixes for 5.12-rc3

2021-03-13 Thread Greg KH
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tags/tty-5.12-rc3 for you to fetch changes up to c776b77a279c327fe9e77

[GIT PULL] USB driver fixes for 5.12-rc3

2021-03-13 Thread Greg KH
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.12-rc3 for you to fetch changes up to d26c00e7276fc92b18c25

Re: [PATCH 5.4 00/24] 5.4.105-rc1 review

2021-03-13 Thread Greg KH
On Fri, Mar 12, 2021 at 02:55:49PM -0800, Florian Fainelli wrote: > On 3/11/21 9:41 AM, Florian Fainelli wrote: > > On 3/11/21 9:40 AM, Greg KH wrote: > >> On Thu, Mar 11, 2021 at 09:23:56AM -0800, Florian Fainelli wrote: > >>> On 3/11/21 5:08 AM, Greg KH wrote: >

Re: [PATCH] Staging: rtl8723bs/core: fix coding style issue

2021-03-12 Thread Greg KH
On Wed, Mar 10, 2021 at 07:35:03PM +0800, Longji Guo wrote: > Move operators and spaces before tabs to fix coding style issues. This change doesn't have anything to do with tabs. confused, greg k-h

Re: [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 11:42:04PM +0900, Daeho Jeong wrote: > So, do you want we protect the values here with spin_lock and just > read without spin_lock in sysfs read part? I would not use any lock at all if this were my code. Remember, this is for debugging/information only, right? And the da

Re: [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH] usb/usbtmc: Remove a redundant kref_put in usbtmc_disconnect

2021-03-12 Thread Greg KH
On Thu, Mar 11, 2021 at 07:03:54AM -0800, Lv Yunlong wrote: > In the implementation of usbtmc_free_int(), it already calls > kref_put() to free the data as shown below. So, in > usbtmc_disconnect, call an extra kref_put() is redundant. > > """ > static void usbtmc_free_int(struct usbtmc_device_dat

Re: [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 10:56:13PM +0900, Daeho Jeong wrote: > Thanks for suggesting me sysfs_emit(). > > For atomic values, actually, those are needed for writer part, not reader. > > +#define add_compr_block_stat(inode, blocks)\ > + do {

Re: systematic crash in amdgpu init since 5.10.20. Not fixed with 5.10.21

2021-03-12 Thread Greg KH
On Tue, Mar 09, 2021 at 07:12:43PM +0100, Eric Valette wrote: > On 09/03/2021 18:27, Holger Hoffstätte wrote: > > On 2021-03-07 17:18, Eric Valette wrote: > > > I have the following systematic crash at boot since 5.10.20 (.19 was ok) > > > > > > This laptop has two graphic cards: > > > > > > 03:0

Re: [PATCH 4.4 v2 0/3] Backport patch series to update Futex from 4.9

2021-03-12 Thread Greg KH
On Thu, Mar 11, 2021 at 11:25:57AM +0800, Zheng Yejian wrote: > Changelog for 'v2': > Complete commit messages with needed git commit ids as Greg and Lee > suggested. > > Lee sent a patchset to update Futex for v4.9, see > https://www.spinics.net/lists/stable/msg443081.html, > Then Xiaoming se

Re: [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 09:25:31PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > I've added new sysfs nodes to show runtime compression stat since mount. > compr_written_block - show the block count written after compression > compr_saved_block - show the saved block count with compression >

Re: [PATCH net-next v5 1/2] net: Add a WWAN subsystem

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 12:11:50PM +0100, Loic Poulain wrote: > Hi Greg, > > On Fri, 12 Mar 2021 at 07:56, Greg KH wrote: > > > > On Thu, Mar 11, 2021 at 09:41:03PM +0100, Loic Poulain wrote: > > > This change introduces initial support for a WWAN subsystem.

Re: [PATCH] [backport for 5.10] powerpc/603: Fix protection of user pages mapped with PROT_NONE

2021-03-12 Thread Greg KH
On Thu, Mar 11, 2021 at 06:24:30PM +, Christophe Leroy wrote: > (cherry picked from commit c119565a15a628efdfa51352f9f6c5186e506a1c) > > On book3s/32, page protection is defined by the PP bits in the PTE > which provide the following protection depending on the access > keys defined in the mat

Re: [PATCH] drivers: tty: vt: vt.c: fix NULL dereference crash

2021-03-12 Thread Greg KH
On Sun, Mar 07, 2021 at 12:56:43PM +0200, Hassan Shahbazi wrote: > Fix a NULL deference crash on hiding the cursor. > > Reported by: syzbot > https://syzkaller.appspot.com/bug?id=defb47bf56e1c14d5687280c7bb91ce7b608b94b > > Signed-off-by: Hassan Shahbazi > --- > drivers/tty/vt/vt.c | 4 +++- >

Re: [PATCH net-next v5 2/2] net: Add Qcom WWAN control driver

2021-03-12 Thread Greg KH
On Thu, Mar 11, 2021 at 09:41:04PM +0100, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI QCOM-based modems to expose > different modem control protocols/ports to userspace, so that userspace > modem tools or daemon (e.g. ModemManager) can control WWAN config > and state (APN config,

Re: [PATCH net-next v5 1/2] net: Add a WWAN subsystem

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 09:41:03PM +0100, Loic Poulain wrote: > This change introduces initial support for a WWAN subsystem. Given the > complexity and heterogeneity of existing WWAN hardwares and interfaces, > there is no strict definition of what a WWAN device is and how it should > be represente

Re: [PATCH 5.4 00/24] 5.4.105-rc1 review

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 09:23:56AM -0800, Florian Fainelli wrote: > On 3/11/21 5:08 AM, Greg KH wrote: > > On Wed, Mar 10, 2021 at 08:19:45PM -0800, Florian Fainelli wrote: > >> +Alex, > >> > >> On 3/10/2021 5:24 AM, gre...@linuxfoundation.org w

Re: [PATCH 5.10 00/47] 5.10.23-rc2 review

2021-03-11 Thread Greg KH
On Wed, Mar 10, 2021 at 08:34:07PM -0800, Florian Fainelli wrote: > > > On 3/10/2021 10:29 AM, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.10.23 release. > > There are 47 patches in this series, all will be posted

Re: [PATCH 5.10 00/47] 5.10.23-rc2 review

2021-03-11 Thread Greg KH
On Wed, Mar 10, 2021 at 09:24:19PM +0100, Pavel Machek wrote: > Hi! > > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.10.23 release. > > There are 47 patches in this series, all will be posted as a response > > to this one. If anyone has any issues wi

Re: [PATCH 5.11 00/36] 5.11.6-rc1 review

2021-03-11 Thread Greg KH
On Wed, Mar 10, 2021 at 10:09:55PM -0600, Ross Schmidt wrote: > On Wed, Mar 10, 2021 at 02:23:13PM +0100, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.11.6 release. > > There are 36 patches in this series, all will b

Re: [PATCH 5.11 00/36] 5.11.6-rc1 review

2021-03-11 Thread Greg KH
On Wed, Mar 10, 2021 at 02:59:43PM -0700, Shuah Khan wrote: > On 3/10/21 6:23 AM, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.11.6 release. > > There are 36 patches in this series, all will be posted as a response >

Re: [PATCH 5.11 00/36] 5.11.6-rc1 review

2021-03-11 Thread Greg KH
On Wed, Mar 10, 2021 at 03:53:01PM -0800, Guenter Roeck wrote: > On Wed, Mar 10, 2021 at 02:23:13PM +0100, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.11.6 release. > > There are 36 patches in this series, all will

Re: [PATCH net-next v4 1/2] net: Add a WWAN subsystem

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 05:39:05PM +0100, Loic Poulain wrote: > --- /dev/null > +++ b/drivers/net/wwan/Kconfig > @@ -0,0 +1,19 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Wireless WAN device configuration > +# > + > +menuconfig WWAN > + bool "Wireless WAN" > + help > + Thi

Re: [PATCH net-next v4 1/2] net: Add a WWAN subsystem

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 05:39:05PM +0100, Loic Poulain wrote: > This change introduces initial support for a WWAN subsystem. Given the > complexity and heterogeneity of existing WWAN hardwares and interfaces, > there is no strict definition of what a WWAN device is and how it should > be represente

Re: [PATCH 5.4 00/24] 5.4.105-rc1 review

2021-03-11 Thread Greg KH
On Wed, Mar 10, 2021 at 08:19:45PM -0800, Florian Fainelli wrote: > +Alex, > > On 3/10/2021 5:24 AM, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.4.105 release. > > There are 24 patches in this series, all will be p

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 09:34:38PM +0900, Tetsuo Handa wrote: > On 2021/03/11 3:33, Greg KH wrote: > > On Sun, Mar 07, 2021 at 08:53:25PM -0700, Shuah Khan wrote: > >> This patch series fixes the following problems founds in syzbot > >> fuzzing. > > > > Than

Re: [PATCH 5.10 00/47] 5.10.23-rc2 review

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 11:39:23AM +, r...@heitbaum.com wrote: > On Wed, Mar 10, 2021 at 07:29:23PM +0100, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.10.23 release. > > There are 47 patches in this series, all

Re: [PATCH 5.10 23/49] ACPI: video: Add DMI quirk for GIGABYTE GB-BXBT-2807

2021-03-11 Thread Greg KH
On Wed, Mar 10, 2021 at 09:04:58PM +0100, Pavel Machek wrote: > Hi! > > On Wed 2021-03-10 14:23:34, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > From: Jasper St. Pierre > > Something is funny with the From header here. But that's not main > thing -- this patch is evil

Re: [PATCH] init: do_mounts.c: Fix indentation errors.

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 05:36:50PM +0530, Shubhankar Kuranagatti wrote: > Switch and case have been aligned together, extra tab removed > Removed extra space before tab. > > Signed-off-by: Shubhankar Kuranagatti > --- > init/do_mounts.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 de

Re: [PATCH v2] configfs: Fix config_item refcnt error in __configfs_open_file()

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 12:39:40PM +0100, Christoph Hellwig wrote: > On Thu, Mar 11, 2021 at 12:35:10PM +0100, gre...@linuxfoundation.org wrote: > > From: Daniel Rosenberg > > > > __configfs_open_file() used to use configfs_get_config_item, but changed > > in commit b0841eefd969 ("configfs: provi

Re: [PATCH] configfs: Fix config_item refcnt error in __configfs_open_file()

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 12:16:25PM +0100, Christoph Hellwig wrote: > I've actually just queued up a similar patch from Daiyue Zhang. > > > - goto out_put_item; > > + goto out_put_module; > > > > if (type & CONFIGFS_ITEM_BIN_ATTR) { > > buffer->bin_attr = to_bi

<    1   2   3   4   5   6   7   8   9   10   >