Re: [PATCH] net: core: bpf_sk_storage.c: Fix bare usage of unsigned

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 03:13:49PM +0530, Shubhankar Kuranagatti wrote: > Changed bare usage of unsigned to unsigned int That says _what_ you did, but not _why_ you did it :( thanks, greg k-h

Re: [PATCH v1 1/3] binder: BINDER_FREEZE ioctl

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 01:36:26AM -0800, Li Li wrote: > On Wed, Mar 10, 2021 at 11:33 PM Greg KH wrote: > > > > On Wed, Mar 10, 2021 at 02:52:49PM -0800, Li Li wrote: > > > if (target_proc) { > > > binder_inner_proc_lock(target_proc)

Re: [PATCH v1 1/3] binder: BINDER_FREEZE ioctl

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 02:52:49PM -0800, Li Li wrote: > if (target_proc) { > binder_inner_proc_lock(target_proc); > + target_proc->outstanding_txns--; > + WARN_ON(target_proc->outstanding_txns < 0); WARN_* is a huge crutch, please just handle stuff like

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-10 Thread Greg KH
On Sun, Mar 07, 2021 at 08:53:25PM -0700, Shuah Khan wrote: > This patch series fixes the following problems founds in syzbot > fuzzing. Thanks for these, all now queued up. greg k-h

Re: [PATCH v4] add support for pci in the pvpanic driver

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 05:08:46PM +0100, Greg KH wrote: > On Sun, Feb 28, 2021 at 08:39:29PM +0200, Mihai Carabas wrote: > > Hello, > > > > Any feedback on this last series? > > Other than the "this breaks the build according to the kernel test > robot&qu

Re: [PATCH v4] add support for pci in the pvpanic driver

2021-03-10 Thread Greg KH
On Sun, Feb 28, 2021 at 08:39:29PM +0200, Mihai Carabas wrote: > Hello, > > Any feedback on this last series? Other than the "this breaks the build according to the kernel test robot"? I think that needs to be fixed before we can do anything here... thnaks, greg k-h

Re: [PATCH] Match alignment with open parenthesis

2021-03-10 Thread Greg KH
On Mon, Feb 22, 2021 at 05:14:09AM +0530, Mahak Gupta wrote: > This patches fixes the checks- 'Alignment should match open parenthesis' > of 'checkpatch.pl'. > > Signed-off-by: Mahak Gupta > --- > drivers/staging/octeon-usb/octeon-hcd.c | 32 + > 1 file changed, 17 insert

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warnings: > > WARNING: Block comments use * on subsequent lines > + /* > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > -- > WARNING: Block comments use * on subsequent lin

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 01:28:02PM +, Lee Jones wrote: > On Wed, 10 Mar 2021, Greg KH wrote: > > > On Tue, Mar 09, 2021 at 06:14:37PM +, Lee Jones wrote: > > > On Tue, 09 Mar 2021, Greg KH wrote: > > > > > > > On Tue, Mar 09, 2021 at 11:06:05AM

Re: [PATCH stable 5.10-5.11] iommu/amd: Fix sleeping in atomic in increase_address_space()

2021-03-10 Thread Greg KH
On Tue, Mar 09, 2021 at 09:24:29PM +0300, Andrey Ryabinin wrote: > commit 140456f994195b568ecd7fc2287a34eadffef3ca upstream. All now queued up, thanks. greg k-h

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-10 Thread Greg KH
On Tue, Mar 09, 2021 at 06:14:37PM +, Lee Jones wrote: > On Tue, 09 Mar 2021, Greg KH wrote: > > > On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > > > From: Thomas Gleixner > > > > > > The handle_exit_race() function is defined in c

Re: linux-next: Signed-off-by missing for commits in the char-misc.current tree

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 10:04:04PM +1100, Stephen Rothwell wrote: > Hi all, > > Commits > > 15097e9338ed ("habanalabs: fix debugfs address translation") > ffd123fe8397 ("habanalabs: Disable file operations after device is removed") > 27ac5aada024 ("habanalabs: Call put_pid() when releasing

Re: [PATCH] greybus/operation: Drop reference when message has been set

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 01:10:14AM -0800, Lv Yunlong wrote: > In gb_operation_response_send, get an extra reference > before gb_message_send() with this comment "/* Reference will > be dropped when message has been sent. */". Therefore, we > should drop the got reference not only in the error branc

Re: [PATCH] char/mwave: turn tp3780I_InitializeBoardData() into void function

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 04:46:03PM +0800, Yang Li wrote: > This function always return '0' and no callers use the return value. > So make it a void function. > > This eliminates the following coccicheck warning: > ./drivers/char/mwave/tp3780i.c:182:5-11: Unneeded variable: "retval". > Return "0" o

Re: [PATCH net-next v3] net: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 09:01:11AM -0700, Jeffrey Hugo wrote: > On 3/9/2021 3:33 AM, Greg KH wrote: > > On Tue, Mar 09, 2021 at 11:28:49AM +0100, Loic Poulain wrote: > > > Hi Greg, > > > > > > On Tue, 9 Mar 2021 at 10:35, Greg KH wrote: > > > >

Re: [PATCH] staging: wfx: remove unused included header files

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 02:45:56PM +0100, Jérôme Pouiller wrote: > On Tuesday 9 March 2021 14:07:43 CET Greg KH wrote: > > On Thu, Mar 04, 2021 at 10:43:45AM +0100, Jérôme Pouiller wrote: > > > Hello Greg, > > > > > > On Tuesday 2 March 2021 16:01:25 CET

Re: [PATCH v2] rtl8712: fixed whitespace coding style issue

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 07:47:21PM +0530, Selvakumar Elangovan wrote: > Removed additional whitespaces in the rtl8712_xmit.h file. > > Signed-off-by: Selvakumar Elangovan > --- > drivers/staging/rtl8712/rtl8712_xmit.h | 3 --- > 1 file changed, 3 deletions(-) What changed from v1? Always put t

Re: [PATCH] staging: rtl8712: fixed whitespace coding style issue

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 06:24:45PM +0530, Selvakumar Elangovan wrote: > Removed additional whitspaces and added space around the binary operator in > the rtl8712_xmit.h file Please wrap your changelog at 72 columns. And you are doing 2 different things in this patch, please only do one "logical"

Re: [PATCH] staging: wfx: remove unused included header files

2021-03-09 Thread Greg KH
On Thu, Mar 04, 2021 at 10:43:45AM +0100, Jérôme Pouiller wrote: > Hello Greg, > > On Tuesday 2 March 2021 16:01:25 CET Jérôme Pouiller wrote: > > Hello Muhammad, > > > > Sorry, I am a bit late for the review of this patch. Thank you for your > > contribution. > > > > On Thursday 11 February 20

Re: [PATCH 06/10] staging: greybus: spilib: use 'spi_delay_to_ns' for getting xfer delay

2021-03-09 Thread Greg KH
On Mon, Mar 08, 2021 at 04:54:58PM +0200, Alexandru Ardelean wrote: > The intent is the removal of the 'delay_usecs' field from the > spi_transfer struct, as there is a 'delay' field that does the same > thing. > > The spi_delay_to_ns() can be used to get the transfer delay. It works by > using th

Re: [PATCH 4.4 0/3] Backport patch series to update Futex from 4.9

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 11:06:02AM +0800, Zheng Yejian wrote: > Lee sent a patchset to update Futex for 4.9, see > https://www.spinics.net/lists/stable/msg443081.html, > Then Xiaoming sent a follow-up patch for it, see > https://lore.kernel.org/lkml/20210225093120.GD641347@dell/. > > These patch

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > From: Thomas Gleixner > > The handle_exit_race() function is defined in commit 9c3f39860367 > ("futex: Cure exit race"), which never returns -EBUSY. This results > in a small piece of dead code in the attach_to_pi_owner() function:

Re: [PATCH 4.4 1/3] futex: Change locking rules

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 11:06:03AM +0800, Zheng Yejian wrote: > From: Peter Zijlstra > > Currently futex-pi relies on hb->lock to serialize everything. But hb->lock > creates another set of problems, especially priority inversions on RT where > hb->lock becomes a rt_mutex itself. > > The rt_mute

Re: [PATCH net-next v3] net: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 11:28:49AM +0100, Loic Poulain wrote: > Hi Greg, > > On Tue, 9 Mar 2021 at 10:35, Greg KH wrote: > > > > On Tue, Mar 09, 2021 at 09:42:16AM +0100, Loic Poulain wrote: > > > The MHI WWWAN control driver allows MHI Qcom based modems to expose

Re: [PATCH 5.11 00/44] 5.11.5-rc1 review

2021-03-09 Thread Greg KH
On Mon, Mar 08, 2021 at 02:29:53PM -0800, Guenter Roeck wrote: > On Mon, Mar 08, 2021 at 01:34:38PM +0100, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.11.5 release. > > There are 44 patches in this series, all will

Re: [PATCH net-next v3] net: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 09:42:16AM +0100, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI Qcom based modems to expose > different modem control protocols/ports to userspace, so that userspace > modem tools or daemon (e.g. ModemManager) can control WWAN config > and state (APN config,

Re: [PATCH v2] bus: mhi: Add Qcom WWAN control driver

2021-03-09 Thread Greg KH
On Mon, Mar 08, 2021 at 09:59:27PM +0100, Loic Poulain wrote: > The MHI WWWAN control driver allows MHI Qcom based modems to expose > different modem control protocols to userspace, so that userspace > modem tools or daemon (e.g. ModemManager) can control WWAN config > and state (APN config, SMS, p

Re: [PATCH v10 01/20] dlb: add skeleton for DLB driver

2021-03-08 Thread Greg KH
On Mon, Mar 08, 2021 at 08:00:00PM +, Chen, Mike Ximing wrote: > > > > -Original Message- > > From: Dan Williams > > Sent: Tuesday, February 9, 2021 11:30 AM > > To: Greg KH > > Cc: Chen, Mike Ximing ; Linux Kernel Mailing > > List >

Re: [PATCH] bus: mhi: Add Qcom WWAN control driver

2021-03-08 Thread Greg KH
On Mon, Mar 08, 2021 at 07:40:51PM +0100, Loic Poulain wrote: > --- /dev/null > +++ b/drivers/bus/mhi/wwan_ctrl.c > @@ -0,0 +1,559 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* Copyright (c) 2018-2020, The Linux Foundation. All rights reserved.*/ It's 2021 now :)

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-08 Thread Greg KH
On Mon, Mar 08, 2021 at 05:03:58PM +0100, Alexander Graf wrote: > > > On 08.03.21 15:36, Greg KH wrote: > > > > On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > > > +static struct miscdevice sysgenid_misc = { > > > + .minor

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-08 Thread Greg KH
On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > +static struct miscdevice sysgenid_misc = { > + .minor = MISC_DYNAMIC_MINOR, > + .name = "sysgenid", > + .fops = &fops, > +}; Much cleaner, but: > +static int __init sysgenid_init(void) > +{ > + int ret; > + > +

Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA

2021-03-08 Thread Greg KH
On Mon, Mar 08, 2021 at 11:20:03AM +0800, Jing Xiangfeng wrote: > > > On 2021/3/7 23:24, Greg KH wrote: > > On Thu, Mar 04, 2021 at 04:09:28PM +0100, Nicolas Saenz Julienne wrote: > > > On Thu, 2021-03-04 at 15:17 +0100, Greg KH wrote: > > > > On Thu, Mar 0

Re: [PATCH v2] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-07 Thread Greg KH
On Mon, Mar 08, 2021 at 08:31:03AM +0100, Pawel Laszczak wrote: > From: Pawel Laszczak > > Fixes issue with priority of operator. Operator "|" priority is > higher then "? :". > To improve the readability the operator "? :" has been replaced with > "if ()" statement. > > Fixes: 3d82904559f4 ("us

Re: stable kernel checksumming fails

2021-03-07 Thread Greg KH
On Sun, Mar 07, 2021 at 10:43:54AM -0500, Konstantin Ryabitsev wrote: > On Sun, Mar 07, 2021 at 03:45:15PM +0100, Greg KH wrote: > > > checksumming the downloaded kernel manually gives an "Okay" though. > > > > > > > > > is this just

Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA

2021-03-07 Thread Greg KH
On Thu, Mar 04, 2021 at 04:09:28PM +0100, Nicolas Saenz Julienne wrote: > On Thu, 2021-03-04 at 15:17 +0100, Greg KH wrote: > > On Thu, Mar 04, 2021 at 03:05:32PM +0100, Nicolas Saenz Julienne wrote: > > > Hi Greg. > > > > > > On Thu, 2021-03-04 at 14:46 +0100

Re: stable kernel checksumming fails

2021-03-07 Thread Greg KH
On Sun, Mar 07, 2021 at 03:10:49PM +0100, Ronald Warsow wrote: > hello > > getting stable kernels with this script: > > https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/tree/get-verified-tarball > > > fails since the last 2 (?) stable releases with (last lines): > > ...

Re: [PATCH] Staging: android: ashmem: fixed a struct without const

2021-03-06 Thread Greg KH
On Sat, Mar 06, 2021 at 12:38:17PM +0600, nabil5352 wrote: > Fixed a struct without const > > Signed-off-by: nabil5352 > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c > b/drivers/staging/android/

Re: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-06 Thread Greg KH
On Sat, Mar 06, 2021 at 08:53:42AM +0800, Peter Chen wrote: > On 21-03-05 06:10:59, Pawel Laszczak wrote: > > From: Pawel Laszczak > > > > The value "start_cycle ? 0 : 1" in assignment caused > > implicit truncation whole value to 1 byte. > > To fix the issue, an explicit casting has been added.

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Greg KH
On Fri, Mar 05, 2021 at 03:20:27PM +0100, Bartosz Golaszewski wrote: > On Fri, Mar 5, 2021 at 12:27 PM Greg KH wrote: > > > > On Fri, Mar 05, 2021 at 11:58:18AM +0100, Bartosz Golaszewski wrote: > > > On Fri, Mar 5, 2021 at 11:24 AM Greg KH > > > wrote: > &

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Greg KH
On Fri, Mar 05, 2021 at 11:58:18AM +0100, Bartosz Golaszewski wrote: > On Fri, Mar 5, 2021 at 11:24 AM Greg KH wrote: > > > > On Fri, Mar 05, 2021 at 10:16:10AM +0100, Bartosz Golaszewski wrote: > > > On Fri, Mar 5, 2021 at 9:55 AM Greg KH wrote: > > > > &

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Greg KH
On Fri, Mar 05, 2021 at 10:16:10AM +0100, Bartosz Golaszewski wrote: > On Fri, Mar 5, 2021 at 9:55 AM Greg KH wrote: > > > > On Fri, Mar 05, 2021 at 09:45:41AM +0100, Bartosz Golaszewski wrote: > > > On Fri, Mar 5, 2021 at 9:34 AM Greg KH wrote: > > > > > &

Re: [PATCH 5.10 000/657] 5.10.20-rc4 review

2021-03-05 Thread Greg KH
On Fri, Mar 05, 2021 at 05:07:42PM +0800, Samuel Zou wrote: > On Tue, 02 Mar 2021 20:28:49 +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.20 release. > > There are 657 patches in this series, all will be posted as a response > > to this one. If anyon

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Greg KH
On Fri, Mar 05, 2021 at 09:45:41AM +0100, Bartosz Golaszewski wrote: > On Fri, Mar 5, 2021 at 9:34 AM Greg KH wrote: > > > > On Fri, Mar 05, 2021 at 09:18:30AM +0100, Geert Uytterhoeven wrote: > > > CC Greg > > > > > > On Thu, Mar 4, 2

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Greg KH
On Fri, Mar 05, 2021 at 09:18:30AM +0100, Geert Uytterhoeven wrote: > CC Greg > > On Thu, Mar 4, 2021 at 11:30 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > Export the symbol for device_is_bound() so that we can use it in gpio-sim > > to check if the simulated GPIO chip

Re: [PATCH] ANDROID: usb: core: Send uevent when USB TOPO layer over 6

2021-03-04 Thread Greg KH
On Fri, Mar 05, 2021 at 03:17:37PM +0800, Chien Kun Niu wrote: > Greg KH 於 2021年3月3日 週三 下午5:10寫道: > > > > On Wed, Mar 03, 2021 at 05:03:25PM +0800, Chien Kun Niu wrote: > > > Hi , Greg > > > > > > What tool will "catch" this? Where is that c

Re: linux-next: manual merge of the tty tree with the powerpc-fixes tree

2021-03-04 Thread Greg KH
On Fri, Mar 05, 2021 at 12:05:23PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > drivers/tty/hvc/hvcs.c > > between commit: > > 386a966f5ce7 ("vio: make remove callback return void") > > from the powerpc-fixes tree and commit:

Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA

2021-03-04 Thread Greg KH
On Thu, Mar 04, 2021 at 03:05:32PM +0100, Nicolas Saenz Julienne wrote: > Hi Greg. > > On Thu, 2021-03-04 at 14:46 +0100, Greg KH wrote: > > On Wed, Mar 03, 2021 at 03:33:12PM +0800, Jing Xiangfeng wrote: > > > Using two distinct DMA zones turned out to be problematic. He

Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA

2021-03-04 Thread Greg KH
On Wed, Mar 03, 2021 at 03:33:12PM +0800, Jing Xiangfeng wrote: > Using two distinct DMA zones turned out to be problematic. Here's an > attempt go back to a saner default. What problem does this solve? How does this fit into the stable kernel rules? thanks, greg k-h

Re: [PATCH 4.9.y] arm: kprobes: Allow to handle reentered kprobe on single-stepping

2021-03-04 Thread Greg KH
On Wed, Mar 03, 2021 at 09:18:27PM +0900, Masami Hiramatsu wrote: > Hi ShaoBo, > > Thanks for backporting and real bug report! > > On Wed, 3 Mar 2021 15:10:52 +0800 > ShaoBo Huang wrote: > > > From: Masami Hiramatsu > > > > commit f3fbd7ec62dec1528fb8044034e2885f2b257941 upstream > > > > Thi

Re: [PATCH] char: lp: remove redundant space

2021-03-04 Thread Greg KH
On Thu, Mar 04, 2021 at 04:17:52PM +0800, Qiang Ma wrote: > These two lines of code don't meet the kernel coding style, > so remove the redundant space. > > Signed-off-by: Qiang Ma > --- > drivers/char/lp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cha

Re: [PATCH 0/2] an additional path to control charging current

2021-03-04 Thread Greg KH
On Wed, Mar 03, 2021 at 04:26:38PM +0100, Heiko Thiery wrote: > Hi, > > Am Mi., 3. März 2021 um 16:01 Uhr schrieb Heiko Thiery > : > > > > Hi Ray, > > > > > > > Currently, VBUS draw callback does no action when the > > > generic PHYs are used. The patches add an additional path > > > to control c

Re: [PATCH] char: lp: remove redundant space

2021-03-03 Thread Greg KH
On Thu, Mar 04, 2021 at 03:21:47PM +0800, maqiang wrote: > These two lines of code don't meet the kernel coding style, > so remove the redundant space. > > Signed-off-by: Qiang Ma > Signed-off-by: maqiang Why do you have 2 signed-off-by lines with the same email address, but different names? I

Re: [V2][PATCH] vt: keyboard, fix uninitialized variables warning

2021-03-03 Thread Greg KH
On Thu, Mar 04, 2021 at 11:10:48AM +0800, Li Wang wrote: > drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl': > drivers/tty/vt/keyboard.c: warning: 'ret' may be used uninitialized in this > function [-Wmaybe-uninitialized] > return ret; > ^~~ > drivers/tty/vt/keyboard.c: warnin

Re: [PATCH 01/44] MAINTAINERS: orphan mxser

2021-03-03 Thread Greg KH
On Tue, Mar 02, 2021 at 07:21:31AM +0100, Jiri Slaby wrote: > I cannot maintain this driver for years due to missing HW. Let's orphan > the entry in MAINTAINERS. And likely drop the driver later as these > devices are likely gone from this world. Mxser provides different > (out-of-tree) drivers for

Re: [PATCH 38/44] USB: serial/io_edgeport, drop unneeded forward declarations

2021-03-03 Thread Greg KH
On Tue, Mar 02, 2021 at 07:22:08AM +0100, Jiri Slaby wrote: > Forward declarations make the code larger and rewrites harder. Harder as > they are often omitted from global changes. Remove forward declarations > which are not really needed, i.e. the definition of the function is > before its first u

Re: [PATCH 37/44] USB: serial/keyspan, drop unneeded forward declarations

2021-03-03 Thread Greg KH
On Tue, Mar 02, 2021 at 07:22:07AM +0100, Jiri Slaby wrote: > Forward declarations make the code larger, harder to follow and rewrite. > Harder as the declarations are often omitted from global changes. Remove > forward declarations which are not really needed, i.e. when the > definition of the fun

Re: [PATCH] char: lp: remove redundant space

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 07:39:38PM +0800, maqiang wrote: > These two lines of code don't meet the kernel coding style, > so remove the redundant space. > > Signed-off-by: maqiang Please use your "full" name that you sign legal documents with. thanks, greg k-h

Re: [PATCH] kcsan, debugfs: Move debugfs file creation out of early init

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 10:38:45AM +0100, Marco Elver wrote: > Commit 56348560d495 ("debugfs: do not attempt to create a new file > before the filesystem is initalized") forbids creating new debugfs files > until debugfs is fully initialized. This breaks KCSAN's debugfs file > creation, which happe

Re: [PATCH] ANDROID: usb: core: Send uevent when USB TOPO layer over 6

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 05:03:25PM +0800, Chien Kun Niu wrote: > Hi , Greg > > What tool will "catch" this? Where is that code located at? > => I prepare merge the code to Android phone , so I used Android HLOS > to catch this uevent. Very odd quoting style, perhaps you might want to read up on

Re: [PATCH] kcsan, debugfs: Move debugfs file creation out of early init

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 11:18:06AM +0100, Marco Elver wrote: > On Wed, 3 Mar 2021 at 10:57, Greg KH wrote: > > > > On Wed, Mar 03, 2021 at 10:38:45AM +0100, Marco Elver wrote: > > > Commit 56348560d495 ("debugfs: do not attempt to create a new file > > &g

Re: [git pull resend] habanalabs fixes for 5.12-rc2

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 10:13:21AM +0200, Oded Gabbay wrote: > Hi Greg, > > This pull request contains some fixes of the habanalabs driver for > 5.12-rc2. > Nothing too scary, more details are in the tag. > > Thanks, > Oded > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f

Re: [git pull] habanalabs fixes for 5.12-rc2

2021-03-03 Thread Greg KH
On Tue, Mar 02, 2021 at 10:54:05PM +0200, Oded Gabbay wrote: > Hi Greg, > > This pull request contains some fixes of the habanalabs driver for > 5.12-rc2. > Nothing too scary, more details are in the tag. > > Thanks, > Oded > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f

Re: [PATCH] vt: keyboard, fix uninitialized variables warning

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 03:33:23PM +0800, Wang, Li wrote: > > On 3/3/2021 3:14 PM, Greg KH wrote: > > On Wed, Mar 03, 2021 at 12:59:32PM +0800, Li Wang wrote: > > > drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl': > > > drivers/tty/v

Re: [PATCH] vt: keyboard, fix uninitialized variables warning

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 12:59:32PM +0800, Li Wang wrote: > drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl': > drivers/tty/vt/keyboard.c: warning: 'ret' may be used uninitialized in this > function [-Wmaybe-uninitialized] > return ret; > ^~~ > kernel-source/drivers/tty/vt/keyb

Re: [PATCH] usb: dwc3: document usb_psy in struct dwc3

2021-03-03 Thread Greg KH
On Wed, Mar 03, 2021 at 02:48:42PM +0800, Ray Chi wrote: > The new struct member was added to struct dwc3, but > a documentation was missing: > > drivers/usb/dwc3/core.h:1273: warning: Function parameter or member 'usb_psy' > not described in 'dwc3' > > Signed-off-by: Ray Chi You forgot the "R

Re: [PATCH 2/2] staging: rtl8192e: Change state information from u16 to u8

2021-03-02 Thread Greg KH
On Mon, Feb 22, 2021 at 10:53:30PM +0530, Atul Gopinathan wrote: > On Mon, Feb 22, 2021 at 04:26:33PM +0100, Greg KH wrote: > > On Sun, Feb 21, 2021 at 10:27:21PM +0530, Atul Gopinathan wrote: > > > On Sun, Feb 21, 2021 at 02:08:26PM +0100, Greg KH wrote: > > > > On S

Re: [PATCH] staging: rtl8192u avoid flex array of flex array

2021-03-02 Thread Greg KH
On Sat, Feb 27, 2021 at 07:06:14PM -0600, Darryl T. Agostinelli wrote: > Undo the flex array in struct ieee80211_info_element. It is used as the flex > array type in other structs (creating a flex array of flex arrays) making > sparse unhappy. This change maintains the intent of the code and sati

Re: [PATCH] This patch fixes the check-patch errors

2021-03-02 Thread Greg KH
On Tue, Mar 02, 2021 at 06:12:54PM +0530, Vikas Kumar Sharma wrote: > Disclaimer:This message is intended only for the designated recipient(s). > It may contain confidential or proprietary information and may be subject > to other confidentiality protections. If you are not a designated > recipi

Re: [PATCH] wimax: attempt to address style issues.

2021-03-02 Thread Greg KH
On Tue, Mar 02, 2021 at 10:11:02AM +0100, gabriele.mod...@gmail.com wrote: > From: Gabriele Modena > > When running checkpatch.pl on op-msg.c, op-rfkill.c > and stack.c I noticed that they contained a few style issues > at warning level of severity. This patch is both an attempt to > address the

Re: [PATCH v3] usb: typec: tcpm: Export partner Source Capabilities

2021-03-02 Thread Greg KH
On Sun, Feb 14, 2021 at 07:17:30PM +0800, Kyle Tso wrote: > Export a function for other drivers to get the partner Source > Capabilities. What driver? We need a user of new functions in the kernel, otherwise they are ripe for removal. thanks, greg k-h

Re: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev()

2021-03-02 Thread Greg KH
On Tue, Mar 02, 2021 at 02:17:02PM +0800, Tian Tao wrote: > fix the below warnning which reported by coccicheck. > /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for > kobj_to_dev(). > /drivers/w1/slaves/w1_ds2781.c:90:60-61: WARNING opportunity for > kobj_to_dev(). > > Signed-off-by

Re: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev()

2021-03-02 Thread Greg KH
On Tue, Mar 02, 2021 at 08:51:08AM +0800, tiantao (H) wrote: > Hi: > > 在 2021/3/1 21:09, Greg KH 写道: > > On Mon, Mar 01, 2021 at 08:58:55PM +0800, Tian Tao wrote: > > > fix the below warnning: > > > /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity

Re: [PATCH 4.9.258] futex: fix dead code in attach_to_pi_owner()

2021-03-01 Thread Greg KH
On Thu, Feb 25, 2021 at 09:17:38AM +, Lee Jones wrote: > On Wed, 24 Feb 2021, Xiaoming Ni wrote: > > > The handle_exit_race() function is defined in commit 9c3f39860367 > > ("futex: Cure exit race"), which never returns -EBUSY. This results > > in a small piece of dead code in the attach_to_p

Re: [PATCH 4.9.y 1/1] futex: Fix OWNER_DEAD fixup

2021-03-01 Thread Greg KH
On Tue, Feb 23, 2021 at 10:41:51PM +0800, Zheng Yejian wrote: > From: Peter Zijlstra > > commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream. > > Both Geert and DaveJ reported that the recent futex commit: > > c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") > > introduced

Re: [PATCH v2] printk: avoid prb_first_valid_seq() where possible

2021-03-01 Thread Greg KH
On Tue, Feb 23, 2021 at 10:02:14AM +0100, Petr Mladek wrote: > On Thu 2021-02-11 18:37:52, John Ogness wrote: > > If message sizes average larger than expected (more than 32 > > characters), the data_ring will wrap before the desc_ring. Once the > > data_ring wraps, it will start invalidating descr

Re: [PATCH for 5.10] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-03-01 Thread Greg KH
On Tue, Feb 23, 2021 at 03:39:20PM +0100, Christophe Leroy wrote: > > > Le 15/02/2021 à 15:30, Greg KH a écrit : > > On Fri, Feb 12, 2021 at 08:57:14AM +, Christophe Leroy wrote: > > > This is backport of 3642eb21256a ("powerpc/32: Preserve cr1 in > > &g

Re: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev()

2021-03-01 Thread Greg KH
On Mon, Mar 01, 2021 at 08:58:55PM +0800, Tian Tao wrote: > fix the below warnning: > /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for > kobj_to_dev() What creates that warning? > > Signed-off-by: Tian Tao > --- > drivers/w1/slaves/w1_ds2780.c | 3 ++- > drivers/w1/slaves/w1_ds

Re: [PATCH 4.4.y] arm: kprobes: Allow to handle reentered kprobe on single-stepping

2021-03-01 Thread Greg KH
On Sat, Feb 27, 2021 at 05:17:01PM +0800, huangshaobo wrote: > From: Masami Hiramatsu > > commit f3fbd7ec62dec1528fb8044034e2885f2b257941 upstream > > This is arm port of commit 6a5022a56ac3 ("kprobes/x86: Allow to > handle reentered kprobe on single-stepping") > > Since the FIQ handlers can in

Re: [PATCH] driver core: Switch to using the new API kobj_to_dev()

2021-03-01 Thread Greg KH
On Mon, Mar 01, 2021 at 05:13:24PM +0800, Yang Li wrote: > fixed the following coccicheck: > ./include/linux/device.h:590:46-47: WARNING opportunity for > kobj_to_dev() > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > include/linux/device.h | 2 +- > 1 file changed, 1 insertion(+),

Re: [RESEND PATCH v11 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-02-27 Thread Greg KH
On Sat, Feb 27, 2021 at 11:27:03PM +0800, Xu Yilun wrote: > This patch supports the DFL drivers be written in userspace. This is > realized by exposing the userspace I/O device interfaces. > > The driver now only binds the ether group feature, which has no irq. So > the irq support is not implemen

Re: [PATCH v11 0/2] UIO support for dfl devices

2021-02-27 Thread Greg KH
On Sat, Feb 27, 2021 at 10:57:33PM +0800, Xu Yilun wrote: > Hi Greg: > > On Fri, Feb 26, 2021 at 07:40:56AM +0100, Greg KH wrote: > > On Fri, Feb 26, 2021 at 09:22:37AM +0800, Xu Yilun wrote: > > > On Mon, Feb 22, 2021 at 10:56:45AM -0800, Tom Rix wrote: > > > &

Re: [GIT PULL] Driver core / debugfs changes for 5.12-rc1

2021-02-27 Thread Greg KH
On Wed, Feb 24, 2021 at 10:20:44AM -0800, Linus Torvalds wrote: > On Wed, Feb 24, 2021 at 6:27 AM Greg KH wrote: > > > > [..] I've reverted that change at > > the very end so we don't have to worry about regressions in 5.12. > > Side note: it would have

Re: [PATCH] staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan

2021-02-26 Thread Greg KH
On Fri, Feb 26, 2021 at 11:48:29AM +, Lee Gibson wrote: > Function _rtl92e_wx_set_scan calls memcpy without checking the length. > A user could control that length and trigger a buffer overflow. > Fix by checking the length is within the maximum allowed size. > > Signed-off-by: Lee Gibson > -

Re: Linux 5.11.2

2021-02-26 Thread Greg KH
On Fri, Feb 26, 2021 at 11:54:07AM +0100, Jörg-Volker Peetz wrote: > Hi, > > thanks for the upgrade. > There seems to be a dangling link in the git repository: > `scripts/dtc/include-prefixes/c6x` Is that new? What commit caused it? thanks, greg k-h

Re: [PATCH] USB: serial: xr: fix NULL-deref on disconnect

2021-02-26 Thread Greg KH
On Fri, Feb 26, 2021 at 11:08:26AM +0100, Johan Hovold wrote: > Claiming the sibling control interface is a bit more involved and > specifically requires adding support to USB-serial core for managing > either interface being unbound first, something which could otherwise > lead to a NULL-pointer d

Re: [PATCH] ANDROID: usb: core: Send uevent when USB TOPO layer over 6

2021-02-26 Thread Greg KH
On Fri, Feb 26, 2021 at 05:16:12PM +0800, Ricky Niu wrote: > When the topology of the nested hubs are over 6 layers > Send uevent to user space when USB TOPO layer over 6. > Let end user more understand what happened. > > Signed-off-by: Ricky Niu > --- > drivers/usb/core/hub.c | 22 +

Re: [PATCH] ANDROID: usb: core: Send uevent when USB TOPO layer over 6

2021-02-26 Thread Greg KH
On Fri, Feb 26, 2021 at 05:16:12PM +0800, Ricky Niu wrote: > When the topology of the nested hubs are over 6 layers > Send uevent to user space when USB TOPO layer over 6. > Let end user more understand what happened. > > Signed-off-by: Ricky Niu > --- > drivers/usb/core/hub.c | 22 +

Re: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller

2021-02-26 Thread Greg KH
On Fri, Feb 26, 2021 at 04:21:37PM +0800, Longfang Liu wrote: > Our current XHCI hardware controller has been customized to only > support USB 2.0 ports. That sounds like a spec violation, right? Why do you want to do this? greg k-h

Re: [PATCH] staging: rtl8192u: minor coding style fix

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 10:03:51AM +, Lee Gibson wrote: > Fixes this checkpatch warning > WARNING: Comparisons should place the constant on the right side of the test > > Signed-off-by: Lee Gibson > --- > drivers/staging/rtl8192u/r8192U_wx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH] kgdb: Fix to kill breakpoints on initmem after boot

2021-02-25 Thread Greg KH
On Fri, Feb 26, 2021 at 12:32:07PM +0530, Sumit Garg wrote: > + stable ML > > On Thu, 25 Feb 2021 at 21:26, Daniel Thompson > wrote: > > > > On Wed, Feb 24, 2021 at 01:46:52PM +0530, Sumit Garg wrote: > > > Currently breakpoints in kernel .init.text section are not handled > > > correctly while a

Re: [PATCH v8 1/1] mm/page_alloc.c: refactor initialization of struct page for holes in memory layout

2021-02-25 Thread Greg KH
On Fri, Feb 26, 2021 at 12:43:51AM +0200, Mike Rapoport wrote: > From: Mike Rapoport > > There could be struct pages that are not backed by actual physical memory. > This can happen when the actual memory bank is not a multiple of > SECTION_SIZE or when an architecture does not register memory ho

Re: [PATCH v11 0/2] UIO support for dfl devices

2021-02-25 Thread Greg KH
On Fri, Feb 26, 2021 at 09:22:37AM +0800, Xu Yilun wrote: > On Mon, Feb 22, 2021 at 10:56:45AM -0800, Tom Rix wrote: > > Yilun, > > > > Is there anything outstanding or remaining to be done ? > > Sorry for late reply. No, this is my lastest version now. > > > Hi Greg: > > Do you have some comm

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 08:53:22AM -0800, Florian Fainelli wrote: > > > On 2/25/2021 12:15 AM, Greg KH wrote: > > On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: > >> From: Florian Fainelli > >> > >> Hi Greg, Sasha, Jaakub and D

Re: [PATCH] driver core: Use unbound workqueue for deferred probes

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 04:03:50PM +0530, Yogesh Lal wrote: > Hi Greg, > > > On 2/24/2021 6:13 PM, Greg KH wrote: > > On Wed, Feb 24, 2021 at 05:25:49PM +0530, Yogesh Lal wrote: > > > Queue deferred driver probes on unbounded workqueue, to allow > > > schedu

Re: [PATCH v1 1/1] Kernel Config to make randomize_va_space read-only.

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 04:42:28AM +, Lan Zheng (lanzheng) wrote: > From ba2ec52f170a8e69d6c44238bb578f9518a7e3b7 Mon Sep 17 00:00:00 2001 > From: lanzheng > Date: Tue, 23 Feb 2021 22:49:34 -0500 Why is this here? > Subject: [PATCH] This patch adds a kernel build config knob that disallows >

Re: [PATCH] futex: fix dead code in attach_to_pi_owner()

2021-02-25 Thread Greg KH
On Mon, Feb 22, 2021 at 08:53:52PM +0800, Xiaoming Ni wrote: > From: Thomas Gleixner > > The handle_exit_race() function is defined in commit c158b461306df82 > ("futex: Cure exit race"), which never returns -EBUSY. This results > in a small piece of dead code in the attach_to_pi_owner() function

Re: [PATCH stable-5.9.y] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Wed, Feb 24, 2021 at 05:09:54PM -0800, Florian Fainelli wrote: > Standalone ports should not have learning enabled since all the frames > are always copied to the CPU port. This is particularly important in > case an user-facing port intentionally spoofs the CPU port's MAC > address. With learni

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: > From: Florian Fainelli > > Hi Greg, Sasha, Jaakub and David, > > This patch series contains backports for a change that recently made it > upstream as: > > commit f3f9be9c58085d11f4448ec199bf49dc2f9b7fb9 > Merge: 18755e270666 f

Re: linux-next: manual merge of the char-misc tree with the drivers-x86 tree

2021-02-24 Thread Greg KH
On Tue, Feb 23, 2021 at 02:28:33PM +1100, Stephen Rothwell wrote: > Hi all, > > On Mon, 15 Feb 2021 07:44:31 +1100 Stephen Rothwell > wrote: > > > > On Mon, 11 Jan 2021 13:08:51 +1100 Stephen Rothwell > > wrote: > > > > > > Today's linux-next merge of the char-misc tree got conflicts in: > > >

Re: Please apply "xen-netback: delete NAPI instance when queue fails to initialize" to v4.4.y

2021-02-24 Thread Greg KH
On Wed, Feb 24, 2021 at 06:03:56PM +0100, SeongJae Park wrote: > This is a request for merge of upstream commit 4a658527271b ("xen-netback: > delete NAPI instance when queue fails to initialize") on v4.4.y tree. > > If 'xenvif_connect()' fails after successful 'netif_napi_add()', the napi is > not

<    1   2   3   4   5   6   7   8   9   10   >