RTAS manipulates its input and output arguments in big endian order.
I have looked at factoring some lines with rtas_call() but it is not really
worth it because of the variable arguments.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
arch/powerpc/kernel/rtas.c | 15 +--
1
to RTAS, it is far better to stick with a simple
rationale: ppc_rtas() should be called with a big endian rtas_args
structure.
With this patch, it is now up to userspace to forge big endian arguments,
as expected by RTAS.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Ben,
The chunk
The current kernel code assumes big endian and parses RTAS events all
wrong. The most visible effect is that we cannot honor EPOW events,
meaning, for example, we cannot shut down a guest properly from the
hypervisor.
This patch fixes that.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
On Fri, 28 Mar 2014 09:29:22 +0100
Laurent Dufour laurent.duf...@fr.ibm.com wrote:
On 28/03/2014 08:33, Greg Kurz wrote:
The current kernel code assumes big endian and parses RTAS events all
wrong. The most visible effect is that we cannot honor EPOW events,
meaning, for example, we cannot
where the scope variable is not originally big endian.
-Nathan
Nathan,
rtas_call() in arch/powerpc/kernel/rtas.c already does the conversion for us.
Thanks.
On 03/28/2014 02:33 AM, Greg Kurz wrote:
The current kernel code assumes big endian and parses RTAS events all
wrong. The most
fields in the RTAS event structures (even the unused ones, for
consistency). We also introduce endian safe accessors for the fields used
by the kernel (trivial rtas_error_type() accessor added for consistency).
Cc: Nathan Fontenot nf...@linux.vnet.ibm.com
Signed-off-by: Greg Kurz gk
On Mon, 31 Mar 2014 09:27:16 +1100
Stewart Smith stew...@linux.vnet.ibm.com wrote:
Greg Kurz gk...@linux.vnet.ibm.com writes:
struct rtas_error_log {
+#ifdef __BIG_ENDIAN__
+ /* Byte 0 */
unsigned long version:8;/* Architectural version */
+ /* Byte 1 */
I
On Tue, 1 Apr 2014 12:26:32 +0200
Geert Uytterhoeven ge...@linux-m68k.org wrote:
On Mon, Mar 31, 2014 at 5:02 PM, Nathan Fontenot
nf...@linux.vnet.ibm.com wrote:
struct rtas_error_log {
- unsigned long version:8;/* Architectural version */
- unsigned long
:
- pass an intermediate well sized buffer to plpar_hcall(). This is acceptalbe
since we're not on a hot path.
- move to the new read API so that we know the return buffer size for sure.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Cc'ing stable as I could reproduce back to 3.15.10
On Fri, 31 Oct 2014 18:00:12 +1100
Michael Ellerman m...@ellerman.id.au wrote:
On Fri, 2014-10-31 at 07:50 +0100, Greg Kurz wrote:
The add_early_randomness() function in drivers/char/hw_random/core.c passes
a 16-byte buffer to pseries_rng_data_read(). Unfortunately, plpar_hcall()
returns
On Tue, 25 Nov 2014 18:41:22 +0200
Michael S. Tsirkin m...@redhat.com wrote:
From: Rusty Russell ru...@rustcorp.com.au
Change the u32 to a u64, and make sure to use 1ULL everywhere!
Cc: Brian Swetland swetl...@google.com
Cc: Christian Borntraeger borntrae...@de.ibm.com
[Thomas Huth: fix
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/vhost.h | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
Michael,
The vhost_is_little_endian() helper adds unconditionnal overhead to fixed
endian architectures: that is all architectures except arm
a legacy device, in case host and guest endianness differ.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/vhost.c |6 +-
drivers/vhost/vhost.h |3 +++
include/uapi/linux/vhost.h |2 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git
(big endian) instead of the hint
whether byteswap is needed or not (patch 1)
- rebased on top of the virtio-1 accessors (patch 2)
Patch 3 is a separate fix: I think it is also valid for virtio-1.
Please comment.
---
Greg Kurz (3):
vhost: add VHOST_VRING_F_LEGACY_BIG_ENDIAN flag
vhost
Without this patch, packets are being silently dropped by the tap backend.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/net.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
On Tue, 06 Jan 2015 16:55:30 -0700
Alex Williamson alex.william...@redhat.com wrote:
On Mon, 2014-12-01 at 18:05 +0200, Michael S. Tsirkin wrote:
I had to add an explicit tag to suppress compiler warning:
gcc isn't smart enough to notice that
len is always initialized since function is
in the future make the same mistake, let
common code handle KVM_CAP_IRQFD the same way as KVM_CAP_IRQFD_RESAMPLE.
Reported-by: Greg Kurz gk...@linux.vnet.ibm.com
Cc: sta...@vger.kernel.org
Fixes: 297e21053a52f060944e9f0de4c64fad9bcd72fc
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Thanks
On Sun, 22 Feb 2015 10:53:51 +0100
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Feb 20, 2015 at 11:07:24AM +0100, Greg Kurz wrote:
Hi,
This patchset allows vhost_net to be used with legacy virtio
when guest and host have a different endianness. It is based
on previous work
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/vhost.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 8c1c792..6a49960 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/vringh.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/vringh.h b/include/linux/vringh.h
index a3fa537..3ed62ef 100644
--- a/include/linux/vringh.h
+++ b/include/linux
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/virtio_config.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index ca3ed78..bd1a582 100644
--- a/include/linux
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/macvtap.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 27ecc5c..a2f2958 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -49,14
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/tun.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 857dca4..3c3d6c0 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -206,14 +206,19 @@ struct
, this
patch changes the logic to:
- little endian if little_endian
- big endian if !little_endian
The native endian case is handled by all users with a trivial helper. This
patch doesn't change any functionality, nor it does add overhead.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Changes
, little-endian wins.
Since this is isn't a common usecase, the feature is controlled by a kernel
config option (not set by default).
Both macvtap and tun are covered by this patch since they share the same
API with userland.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Changes since v4
that userspace may request a specific endianness. This field is
used to override the default when activating the ring of a legacy
device. It has no effect on modern devices.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Changes since v4:
- rewrote patch title to mention cross-endian
from a ppc64 to a ppc64le host and back. No regressions
on x86 as expected. My experimental QEMU tree is here:
https://github.com/gkurz/qemu.git vhost/cross-endian
I'd be glad if this series could make it to 4.1.
Cheers.
---
Greg Kurz (8):
virtio: introduce virtio_is_little_endian
On Fri, 17 Apr 2015 11:18:13 +0200
Greg Kurz gk...@linux.vnet.ibm.com wrote:
On Fri, 10 Apr 2015 12:15:00 +0200
Greg Kurz gk...@linux.vnet.ibm.com wrote:
Hi,
This patchset allows vhost to be used with legacy virtio when guest and host
have a different endianness.
Patch 7 got
On Tue, 7 Apr 2015 17:56:25 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 07, 2015 at 02:15:52PM +0200, Greg Kurz wrote:
The current memory accessors logic is:
- little endian if little_endian
- native endian (i.e. no byteswap) if !little_endian
If we want to fully
On Tue, 21 Apr 2015 16:04:23 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Apr 10, 2015 at 12:19:16PM +0200, Greg Kurz wrote:
This patch brings cross-endian support to vhost when used to implement
legacy virtio devices. Since it is a relatively rare situation, the
feature
On Fri, 24 Apr 2015 09:19:26 +0200
Cornelia Huck cornelia.h...@de.ibm.com wrote:
On Thu, 23 Apr 2015 17:29:42 +0200
Greg Kurz gk...@linux.vnet.ibm.com wrote:
This patch brings cross-endian support to vhost when used to implement
legacy virtio devices. Since it is a relatively rare
On Fri, 24 Apr 2015 09:04:21 +0200
Cornelia Huck cornelia.h...@de.ibm.com wrote:
On Thu, 23 Apr 2015 21:27:19 +0200
Thomas Huth th...@redhat.com wrote:
Thomas's e-mail did not make it to my mailbox... weird. :-\
On Thu, 23 Apr 2015 17:29:06 +0200
Greg Kurz gk...@linux.vnet.ibm.com wrote
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/vringh.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/vringh.h b/include/linux/vringh.h
index a3fa537..3ed62ef 100644
--- a/include/linux/vringh.h
+++ b/include/linux
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/tun.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 857dca4..3c3d6c0 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -206,14 +206,19 @@ struct
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/macvtap.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 27ecc5c..a2f2958 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -49,14
, this
patch changes the logic to:
- little endian if little_endian
- big endian if !little_endian
The native endian case is handled by all users with a trivial helper. This
patch doesn't change any functionality, nor it does add overhead.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Changes
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/vhost.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 8c1c792..6a49960 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
Only cosmetic and documentation changes since v5.
---
Greg Kurz (8):
virtio: introduce virtio_is_little_endian() helper
tun: add tun_is_little_endian() helper
macvtap: introduce macvtap_is_little_endian() helper
vringh: introduce vringh_is_little_endian() helper
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/virtio_config.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index ca3ed78..bd1a582 100644
--- a/include/linux
, little-endian wins.
Since this is isn't a common usecase, the feature is controlled by a kernel
config option (not set by default).
Both macvtap and tun are covered by this patch since they share the same
API with userland.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Changes since v5
that userspace may request a specific endianness. This field is
used to override the default when activating the ring of a legacy
device. It has no effect on modern devices.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
Changes since v5:
- fixed description in Kconfig
- fixed error
On Tue, 21 Apr 2015 20:30:23 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 21, 2015 at 06:22:20PM +0200, Greg Kurz wrote:
On Tue, 21 Apr 2015 16:06:33 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Apr 10, 2015 at 12:20:21PM +0200, Greg Kurz wrote
On Tue, 21 Apr 2015 20:25:03 +0200
Michael S. Tsirkin m...@redhat.com wrote:
[ ... ]
@@ -630,6 +634,53 @@ static long vhost_set_memory(struct vhost_dev *d,
struct vhost_memory __user *m)
return 0;
}
+#ifdef CONFIG_VHOST_SET_ENDIAN_LEGACY
+static long
On Tue, 21 Apr 2015 16:06:33 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Apr 10, 2015 at 12:20:21PM +0200, Greg Kurz wrote:
The VNET_LE flag was introduced to fix accesses to virtio 1.0 headers
that are always little-endian. It can also be used to handle the special
case
On Tue, 21 Apr 2015 16:10:18 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Apr 10, 2015 at 12:15:00PM +0200, Greg Kurz wrote:
Hi,
This patchset allows vhost to be used with legacy virtio when guest and host
have a different endianness.
Patch 7 got rewritten according
On Tue, 21 Apr 2015 16:09:44 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Apr 10, 2015 at 12:16:20PM +0200, Greg Kurz wrote:
The current memory accessors logic is:
- little endian if little_endian
- native endian (i.e. no byteswap) if !little_endian
If we want to fully
On Fri, 24 Apr 2015 15:31:54 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote:
Only cosmetic and documentation changes since v5.
---
Looks sane to me. I plan to review and apply next week.
Hi Michael,
I realize you just got
On Tue, 14 Apr 2015 16:20:23 +0200
Cornelia Huck cornelia.h...@de.ibm.com wrote:
On Fri, 10 Apr 2015 12:19:16 +0200
Greg Kurz gk...@linux.vnet.ibm.com wrote:
This patch brings cross-endian support to vhost when used to implement
legacy virtio devices. Since it is a relatively rare
On Fri, 10 Apr 2015 12:15:00 +0200
Greg Kurz gk...@linux.vnet.ibm.com wrote:
Hi,
This patchset allows vhost to be used with legacy virtio when guest and host
have a different endianness.
Patch 7 got rewritten according to Cornelia's and Michael's comments. I have
also introduced patch 8
Hi,
This patchset allows vhost to be used with legacy virtio when guest and host
have a different endianness.
Patches 1-6 remain the same as the previous post. Patch 7 was heavily changed
according to MST's comments.
---
Greg Kurz (7):
virtio: introduce virtio_is_little_endian() helper
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/virtio_config.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index ca3ed78..bd1a582 100644
--- a/include/linux
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/macvtap.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 27ecc5c..a2f2958 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -49,14
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/vhost.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 8c1c792..6a49960 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
, this
patch changes the logic to:
- little endian if little_endian
- big endian if !little_endian
The native endian case is handled by all users with a trivial helper. This
patch doesn't change any functionality, nor it does add overhead.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers
are returned EPERM.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/Kconfig | 10
drivers/vhost/vhost.c | 55
drivers/vhost/vhost.h | 17 +-
include/uapi/linux/vhost.h |5
4 files
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/tun.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 857dca4..3c3d6c0 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -206,14 +206,19 @@ struct
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/vringh.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/vringh.h b/include/linux/vringh.h
index a3fa537..3ed62ef 100644
--- a/include/linux/vringh.h
+++ b/include/linux
On Tue, 7 Apr 2015 17:55:08 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 07, 2015 at 02:09:29PM +0200, Greg Kurz wrote:
Hi,
This patchset allows vhost to be used with legacy virtio when guest and host
have a different endianness.
Patches 1-6 remain the same
On Tue, 7 Apr 2015 17:52:28 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 07, 2015 at 02:19:31PM +0200, Greg Kurz wrote:
This patch brings cross-endian support to vhost when used to implement
legacy virtio devices. Since it is a relatively rare situation, the
feature
On Tue, 7 Apr 2015 18:11:29 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 07, 2015 at 02:19:31PM +0200, Greg Kurz wrote:
This patch brings cross-endian support to vhost when used to implement
legacy virtio devices. Since it is a relatively rare situation, the
feature
On Tue, 7 Apr 2015 17:01:31 +0200
Cornelia Huck cornelia.h...@de.ibm.com wrote:
On Tue, 07 Apr 2015 14:19:31 +0200
Greg Kurz gk...@linux.vnet.ibm.com wrote:
This patch brings cross-endian support to vhost when used to implement
legacy virtio devices. Since it is a relatively rare
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/vhost.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 8c1c792..6a49960 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
, this
patch changes the logic to:
- little endian if little_endian
- big endian if !little_endian
The native endian case is handled by all users with a trivial helper. This
patch doesn't change any functionality, nor it does add overhead.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers
for both at the same time.
Hot paths are being preserved from any penalty when the config option is
disabled or when virtio 1.0 is being used.
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/vhost/Kconfig | 10 ++
drivers/vhost/net.c|5 +
drivers
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/macvtap.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 27ecc5c..a2f2958 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -49,14
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
drivers/net/tun.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 857dca4..3c3d6c0 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -206,14 +206,19 @@ struct
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/vringh.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/vringh.h b/include/linux/vringh.h
index a3fa537..3ed62ef 100644
--- a/include/linux/vringh.h
+++ b/include/linux
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com
---
include/linux/virtio_config.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index ca3ed78..bd1a582 100644
--- a/include/linux
vnet headers was dropped for the moment. As a consequnce,
vhost_net still fails to work with cross-endian. It will be fixed in another
patchset I'm currently working on.
---
Greg Kurz (7):
virtio: introduce virtio_is_little_endian() helper
tun: add tun_is_little_endian() helper
On Thu, 2 Apr 2015 16:20:46 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Thu, Apr 02, 2015 at 03:17:13PM +0200, Greg Kurz wrote:
This patch brings cross-endian support to vhost when used to implement
legacy virtio devices. Since it is a relatively rare situation, the feature
On Thu, 2 Jul 2015 08:01:28 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote:
On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin m...@redhat.com wrote:
virtio/vhost: cross endian support
Ugh. Does this really have to be
On Tue, 12 May 2015 12:52:55 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Tue, May 12, 2015 at 12:44:26PM +0200, Greg Kurz wrote:
On Fri, 24 Apr 2015 15:31:54 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote:
Only
On Thu, 9 Jul 2015 09:49:05 +0200
Thomas Huth th...@redhat.com wrote:
The option for supporting cross-endianness legacy guests in
the vhost and tun code should only be available on systems
that support cross-endian guests.
Signed-off-by: Thomas Huth th...@redhat.com
Acked-by: Greg Kurz gk
on LE host, vhost_is_little_endian is
> checking is_le flag so there's always a branch.
>
> To fix, simply check virtio_legacy_is_little_endian first.
>
> Cc: Greg Kurz <gk...@linux.vnet.ibm.com>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Oops my bad for th
On Fri, 30 Oct 2015 12:42:35 +0100
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> The vq->is_le field is used to fix endianness when accessing the vring via
> the cpu_to_vhost16() and vhost16_to_cpu() helpers in the following cases:
>
> 1) host is big endian and device is
On Thu, 12 Nov 2015 15:46:30 +0200
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Fri, Oct 30, 2015 at 12:42:35PM +0100, Greg Kurz wrote:
> > The vq->is_le field is used to fix endianness when accessing the vring via
> > the cpu_to_vhost16() and vhost16_to_cp
ur change.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
drivers/vhost/net.c |6 ++
drivers/vhost/scsi.c |3 +++
drivers/vhost/test.c |2 ++
drivers/vhost/vhost.c | 12 +++-
drivers/vhost/vhost.h |1 +
5 files changed, 19 insertions(+), 5 deleti
On Wed, 23 Sep 2015 19:45:08 +0100
David Woodhouse wrote:
> Commit 7d82410950aa ("virtio: add explicit big-endian support to memory
> accessors") accidentally changed the virtio_net header used by
> AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian.
>
Hi David,
On Thu, 24 Sep 2015 12:50:59 +0300
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Thu, Sep 24, 2015 at 09:25:45AM +0200, Greg Kurz wrote:
> > On Wed, 23 Sep 2015 19:45:08 +0100
> > David Woodhouse <dw...@infradead.org> wrote:
> >
> > > C
On Thu, 12 Nov 2015 15:28:19 +0100
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> On Thu, 12 Nov 2015 15:46:30 +0200
> "Michael S. Tsirkin" <m...@redhat.com> wrote:
>
> > On Fri, Oct 30, 2015 at 12:42:35PM +0100, Greg Kurz wrote:
> > > The vq->is_
ut didn't
> update tools/virtio, so vring_bench started failing.
>
Oops... yet another oversight...
> Update the copy under tools/virtio/ (TODO: find a way to avoid this code
> duplication).
>
> Cc: Greg Kurz <gk...@linux.vnet.ibm.com>
> Signed-off-by: Michael
On Fri, 10 Jun 2016 15:18:32 +1000 (AEST)
Michael Ellerman <m...@ellerman.id.au> wrote:
> On Mon, 2016-23-05 at 08:28:28 UTC, Greg Kurz wrote:
> > A strange behaviour is observed when comparing PCI hotplug in QEMU, between
> > x86 and pseries. If you consider the following st
On Mon, 23 May 2016 10:28:28 +0200
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> A strange behaviour is observed when comparing PCI hotplug in QEMU, between
> x86 and pseries. If you consider the following steps:
> - start a VM
> - add a PCI device via the QEMU monitor be
: Eric Van Hensbergen <eri...@gmail.com>
(changed v9fs_fid_find_global to v9fs_fid_find_inode in comment)
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
fs/9p/fid.c | 30 ++
fs/9p/vfs_inode.c |4
net/9p/client.c |5 -
3
in the guest, with the notable
exception of xattr related ones because more code is needed in QEMU.
Please comment. Test reports will also be appreciated :)
---
Eric Van Hensbergen (1):
fs/9p: fix create-unlink-getattr idiom
Greg Kurz (2):
fs/9p: track open fids
fs/9p: search
From: Greg Kurz <gk...@linux.vnet.ibm.com>
This patch adds accounting of open fids in a list hanging off the i_private
field of the corresponding inode. This allows faster lookups compared to
searching the full 9p client list.
The lookup code is modified accordingly.
Signed-off-by: Gre
alls, since file permissions are checked earlier
in the VFS layer.
With this patch, we get:
open("./test.txt", O_RDWR|O_CREAT, 0666) = 4
chmod("./test.txt", 0) = 0
truncate("./test.txt", 0) = -1 EACCES (Permission denied)
ftruncate(4, 0)
On Wed, 15 Jun 2016 22:26:41 +0200
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> A strange behaviour is observed when comparing PCI hotplug in QEMU, between
> x86 and pseries. If you consider the following steps:
> - start a VM
> - add a PCI device via the QEMU monitor be
they cannot be run before
fs_initcall.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
v2: - avoid behaviour change: don't create the proc entry if early init failed
Michael,
This was also tested under PowerVM: it doesn't fix anything there because the
HMC tells it won't honor DLPAR fe
On Wed, 10 Feb 2016 14:23:33 +0100
Cornelia Huck <cornelia.h...@de.ibm.com> wrote:
> On Wed, 10 Feb 2016 14:08:43 +0100
> Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
>
> > But you are right, there is a bug: we should rollback if vhost_init_used()
>
On Wed, 10 Feb 2016 17:08:52 +0200
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Wed, Feb 10, 2016 at 01:11:34PM +0100, Greg Kurz wrote:
> > On Wed, 10 Feb 2016 13:21:22 +0200
> > "Michael S. Tsirkin" <m...@redhat.com> wrote:
> >
>
On Wed, 10 Feb 2016 13:21:22 +0200
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Wed, Jan 13, 2016 at 06:09:41PM +0100, Greg Kurz wrote:
> > The default use case for vhost is when the host and the vring have the
> > same endianness (default native endiann
On Wed, 10 Feb 2016 13:48:09 +0200
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Wed, Jan 13, 2016 at 06:09:47PM +0100, Greg Kurz wrote:
> > The way vring endianness is being handled currently obfuscates
> > the code in vhost_init_used().
> >
>
On Wed, 13 Jan 2016 18:09:34 +0100
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> This series is a respin of the following patch:
>
> http://patchwork.ozlabs.org/patch/565921/
>
> Patch 1 is preliminary work: it gives better names to the helpers that are
> involved
We don't want side effects. If something fails, we rollback vq->is_le to
its previous value.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
drivers/vhost/vhost.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/vhost/vhost.c b/driv
This series is a new tentative to have cleaner cross-endian code.
Patches 1/3 is new: it fixes a side-effect in case vhost_init_used() fails.
Patch 2/3 comes from v1: it renames cross-endian helpers
Patch 3/3 is new: it simply renames vhost_init_used() as suggested by Michael.
---
Greg Kurz
n't related
to the vq used ring.
This patch simply renames vhost_init_used() to vhost_vq_init_access() as
suggested by Michael.
No behaviour change.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
drivers/vhost/net.c |2 +-
drivers/vhost/scsi.c |2 +-
drivers/vhost/test.
e is started. The
cross-endian mode is disabled when the device is stopped.
The current names of the helpers that manipulate vq->user_be are unclear.
This patch renames those helpers to clearly show that this is cross-endian
stuff and with explicit enable/disable semantics.
No behaviour change.
Sign
On Tue, 16 Feb 2016 17:34:13 +0200
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Tue, Feb 16, 2016 at 03:54:18PM +0100, Greg Kurz wrote:
> > This series is a new tentative to have cleaner cross-endian code.
> >
> > Patches 1/3 is new: it fixes a side-e
On Fri, 4 Mar 2016 06:24:50 -0500
Jason Wang wrote:
> This series tries to add basic busy polling for vhost net. The idea is
> simple: at the end of tx/rx processing, busy polling for new tx added
> descriptor and rx receive socket for a while. The maximum number of
> time
1 - 100 of 405 matches
Mail list logo