Re: [PATCH v1 1/6] usb: typec: tcpm: Address incorrect values of tcpm psy for fixed supply

2021-04-05 Thread Guenter Roeck
* Requested current / voltage to the port partner */ > + u32 req_current_limit; > + u32 req_supply_voltage; > + /* Acutal current / voltage limit of the local port */ Actual Otherwise makes sense. Reviewed-by: Guenter Roeck > u32 current_limit; >

Re: [PATCH 3/3] hwmon: intel-m10-bmc-hwmon: add sensor support of Intel D5005 card

2021-04-05 Thread Guenter Roeck
On 4/5/21 4:53 PM, matthew.gerl...@linux.intel.com wrote: > From: Matthew Gerlach > > Like the Intel N3000 card, the Intel D5005 has a MAX10 based > BMC. This commit adds support for the D5005 sensors that are > monitored by the MAX10 BMC. > > Signed-off-by: Matthew Gerlach > Signed-off-by:

Re: [PATCH 4.9 00/35] 4.9.265-rc1 review

2021-04-05 Thread Guenter Roeck
On Mon, Apr 05, 2021 at 10:56:29AM -0700, Guenter Roeck wrote: > On Mon, Apr 05, 2021 at 10:53:35AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.265 release. > > There are 35 patches in this series, all will be posted as a response

Re: [PATCH 1/1] of: properly check for error returned by fdt_get_name()

2021-04-05 Thread Guenter Roeck
f unittest you should see a warning about > testcases. > Trying again: With this patch applied, the kernel no longer crashes, and the log message is as expected: ### dt-test ### start of unittest - you will see error messages ### dt-test ### unittest_data_add: unflatten testcases tree faile

Re: [PATCH] hwmon: (sbtsi) Don't read sensor more than once if it doesn't respond

2021-04-05 Thread Guenter Roeck
On 4/1/21 2:45 PM, Konstantin Aladyshev wrote: > From: Konstantin Aladyshev > > SBTSI sensors don't work when the CPU is off. > In this case every 'i2c_smbus_read_byte_data' function would fail > by a timeout. > Currently temp1_max/temp1_min file reads can cause two such timeouts > for every

Re: [PATCH v3 5/6] usb: Iterator for ports

2021-04-05 Thread Guenter Roeck
On 3/31/21 11:37 PM, Heikki Krogerus wrote: > On Wed, Mar 31, 2021 at 09:41:22AM -0700, Guenter Roeck wrote: >>> diff --git a/include/linux/usb.h b/include/linux/usb.h >>> index ddd2f5b2a2827..ebcd03d835d04 100644 >>> --- a/include/linux/usb.h >>> +++ b/in

Re: [PATCH 5.11 000/152] 5.11.12-rc1 review

2021-04-05 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 460 pass: 460 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/126] 5.10.28-rc1 review

2021-04-05 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 454 pass: 454 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/74] 5.4.110-rc1 review

2021-04-05 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 433 pass: 433 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/56] 4.19.185-rc1 review

2021-04-05 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 423 pass: 423 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.14 00/52] 4.14.229-rc1 review

2021-04-05 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 408 pass: 408 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.9 00/35] 4.9.265-rc1 review

2021-04-05 Thread Guenter Roeck
y. No reason for concern; I'll try to track down what is going on. Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.4 00/28] 4.4.265-rc1 review

2021-04-05 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > Build results: total: 160 pass: 160 fail: 0 Qemu test results: total: 328 pass: 328 fail: 0 Tested-by: Guenter Roeck Guenter

Re: Linux 5.12-rc6

2021-04-05 Thread Guenter Roeck
On 4/5/21 10:14 AM, Linus Torvalds wrote: > On Mon, Apr 5, 2021 at 10:10 AM Guenter Roeck wrote: >> >> No change in test results since last week [..] > > Let's ping Frank for the alignment issue. If that promised patch > isn't timely (and trivial), I really think tha

Re: Linux 5.12-rc6

2021-04-05 Thread Guenter Roeck
On Sun, Apr 04, 2021 at 02:30:58PM -0700, Linus Torvalds wrote: > Well, if rc5 was bigger than usual, and I worried about what that > meant for this release, rc6 is positively tiny. > > So I think it was just due to the usual random timing fluctuations, > probably mainly networking updates (which

Re: [PATCH 1/1] of: properly check for error returned by fdt_get_name()

2021-04-05 Thread Guenter Roeck
t; commit 79edff12060f ("scripts/dtc: Update to upstream version > v1.6.0-51-g183df9e9c2b9") > as reported in: > https://lore.kernel.org/lkml/20210327224116.69309-1-li...@roeck-us.net/ > > Fixes: commit 79edff12060f ("scripts/dtc: Update to upstream version >

Re: [PATCH 11/13] kconfig: do not use allnoconfig_y option

2021-04-05 Thread Guenter Roeck
On 3/31/21 11:25 AM, Nick Desaulniers wrote: > On Wed, Mar 31, 2021 at 10:12 AM Guenter Roeck wrote: >> >> On Sun, Mar 14, 2021 at 04:48:34AM +0900, Masahiro Yamada wrote: >>> allnoconfig_y is a bad hack that sets a symbol to 'y' by allnoconfig. >>> >>&g

Re: [PATCH 1/1] watchdog: Fix a typo in Kconfig

2021-04-05 Thread Guenter Roeck
On 3/31/21 8:32 PM, Wong Vee Khee wrote: > s/thershold/threshold > > Cc: Vijayakannan Ayyathurai > Signed-off-by: Wong Vee Khee Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [PATCH 11/13] kconfig: do not use allnoconfig_y option

2021-03-31 Thread Guenter Roeck
On Sun, Mar 14, 2021 at 04:48:34AM +0900, Masahiro Yamada wrote: > allnoconfig_y is a bad hack that sets a symbol to 'y' by allnoconfig. > > allnoconfig does not mean a minimum set of CONFIG options because a > bunch of prompts are hidden by 'if EMBEDDED' or 'if EXPERT', but I do > not like to do

Re: [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist

2021-03-31 Thread Guenter Roeck
On Wed, Mar 31, 2021 at 12:02:11PM +0200, Pali Rohár wrote: > On Tuesday 30 March 2021 19:02:55 Sebastian Oechsle wrote: > > Allow manual PWM control on Dell Latitude 7440. > > > > Signed-off-by: Sebastian Oechsle > > > > Reviewed-by: Pali Rohár > > (Btw, in

Re: [PATCH v3 5/6] usb: Iterator for ports

2021-03-31 Thread Guenter Roeck
On 3/31/21 3:59 AM, Heikki Krogerus wrote: > Introducing usb_for_each_port(). It works the same way as > usb_for_each_dev(), but instead of going through every USB > device in the system, it walks through the USB ports in the > system. > > Signed-off-by: Heikki Krogerus > Acked-by: Alan Stern >

Re: [PATCH v1 1/1] driver core: platform: Declare early_platform_cleanup() prototype

2021-03-31 Thread Guenter Roeck
void __weak __init early_platform_cleanup(void) { } > |^~ > > Declare early_platform_cleanup() prototype in the header to make everyone > happy. > > Fixes: eecd37e105f0 ("drivers: Fix boot problem on SuperH") > Cc: Guenter Roeck > S

[PATCH] hwmon: (amd_energy) Restore visibility of energy counters

2021-03-31 Thread Guenter Roeck
Cc: Greg Kroah-Hartman Fixes: 60268b0e8258 ("hwmon: (amd_energy) modify the visibility of the counters") Signed-off-by: Guenter Roeck --- drivers/hwmon/amd_energy.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/hwmon/amd_ener

Re: [PATCH] blk-mq: fix alignment mismatch.

2021-03-30 Thread Guenter Roeck
n -Walign-mismatch in Clang is used. >> >> Link: >> http://crrev.com/c/1193732 >> >> Suggested-by: Guenter Roeck >> Signed-off-by: Jian Cai > > Thanks for the patch. This is effectively a revert of commit > 4ccafe032005 ("block: unalign

Re: [PATCH] blk-mq: fix alignment mismatch.

2021-03-30 Thread Guenter Roeck
rved error message is: block/blk-mq.c:622:44: error: passing 8-byte aligned argument to 32-byte aligned parameter 2 of 'smp_call_function_single_async' may result in an unaligned pointer access [-Werror,-Walign-mismatch] Thanks, Guenter > > Suggested-by: Guenter Roeck &

Re: linux-next: build warning after merge of the hwmon-staging tree

2021-03-30 Thread Guenter Roeck
On 3/30/21 1:25 PM, Chris Packham wrote: > My bad. I'll send a patch shortly > No need. I patched it up already. Thanks, Guenter > On 30/03/21 8:27 pm, Stephen Rothwell wrote: >> Hi all, >> >> After merging the hwmon-staging tree, today's linux-next build (htmldocs) >> produced this warning:

Re: Enabling pmbus power control

2021-03-30 Thread Guenter Roeck
On Tue, Mar 30, 2021 at 07:02:00PM +0100, Mark Brown wrote: > On Tue, Mar 30, 2021 at 12:56:56PM -0500, Zev Weiss wrote: > > > Okay, to expand a bit on the description in my initial message -- we've > > got a single chassis with multiple server boards and a single manager board > > that handles,

Re: [PATCH v2 1/4] iommu/vt-d: Enable write protect for supervisor SVM

2021-03-30 Thread Guenter Roeck
On 3/30/21 10:52 AM, Jacob Pan wrote: > Hi Guenter, > > On Mon, 22 Mar 2021 10:53:38 -0700, Guenter Roeck > wrote: > >> On Tue, Mar 02, 2021 at 02:13:57AM -0800, Jacob Pan wrote: >>> Write protect bit, when set, inhibits supervisor writes to the read-only >>&

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

2021-03-30 Thread Guenter Roeck
On Wed, Feb 10, 2021 at 01:44:34PM +0200, Tudor Ambarus wrote: > This is a follow-up for: > commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is > added/removed") > > The above commit updated the deprecated of_clk_add_provider(), > but missed to update the preferred

Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-30 Thread Guenter Roeck
On 3/29/21 11:27 PM, Jonas Malaco wrote: > On Mon, Mar 29, 2021 at 10:43:55PM -0700, Guenter Roeck wrote: >> On 3/29/21 8:16 PM, Jonas Malaco wrote: >>> On Mon, Mar 29, 2021 at 06:01:00PM -0700, Guenter Roeck wrote: >>>> On 3/29/21 5:21 PM, Jonas Malaco wrote: >&

Re: linux-next: build warning after merge of the hwmon-staging tree

2021-03-30 Thread Guenter Roeck
On 3/30/21 12:27 AM, Stephen Rothwell wrote: > Hi all, > > After merging the hwmon-staging tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/hwmon/bpa-rs600.rst: WARNING: document isn't included in any > toctree > > Introduced by commit > > 9a8210575cde

Re: Enabling pmbus power control

2021-03-30 Thread Guenter Roeck
On 3/30/21 1:17 AM, Zev Weiss wrote: > > Hello, > > I'm working on a board that has a handful of LM25066 PMICs controlling > the power supply to various devices, and I'd like to have both the > existing hwmon sensor functionality as well as userspace power on/off > control, which does not

Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-29 Thread Guenter Roeck
On 3/29/21 8:16 PM, Jonas Malaco wrote: > On Mon, Mar 29, 2021 at 06:01:00PM -0700, Guenter Roeck wrote: >> On 3/29/21 5:21 PM, Jonas Malaco wrote: >>> On Mon, Mar 29, 2021 at 02:53:39PM -0700, Guenter Roeck wrote: >>>> On Mon, Mar 29, 2021 at 05:22:01AM -0300, Jona

Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread Guenter Roeck
On 3/29/21 8:31 PM, Václav Kubernát wrote: > Hi Guenter, > > Thank you for the review. > > po 29. 3. 2021 v 19:47 odesílatel Guenter Roeck napsal: >> >> On 3/29/21 7:38 AM, Václav Kubernát wrote: >>> After some testing, I have found out there is a timi

Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

2021-03-29 Thread Guenter Roeck
On 3/28/21 6:52 PM, Quan Nguyen wrote: > This commit adds support for Ampere SMpro hwmon driver. This driver > supports accessing various CPU sensors provided by the SMpro co-processor > including temperature, power, voltages, and current. > > Signed-off-by: Quan Nguyen > --- >

Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-29 Thread Guenter Roeck
On 3/29/21 5:21 PM, Jonas Malaco wrote: > On Mon, Mar 29, 2021 at 02:53:39PM -0700, Guenter Roeck wrote: >> On Mon, Mar 29, 2021 at 05:22:01AM -0300, Jonas Malaco wrote: >>> To avoid a spinlock, the driver explores concurrent memory accesses >>> between _raw_event a

Re: [PATCH v2 2/2] hwmon: (pmbus/tps53679) Add support for TI TPS53676

2021-03-29 Thread Guenter Roeck
On Mon, Mar 22, 2021 at 08:37:34PM +0100, Erik Rosen wrote: > Add support for TI TPS53676 controller to the tps53679 pmbus driver > > The driver uses the USER_DATA_03 register to figure out how many phases > are enabled and to which channel they are assigned, and sets the number > of pages and

Re: [PATCH 1/2] dt-bindings: Add trivial device entry for TPS53676

2021-03-29 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 10:24:40PM +0100, Erik Rosen wrote: > Add trivial device entry for TPS53676 > > Signed-off-by: Erik Rosen > Reviewed-by: Guenter Roeck > Acked-by: Rob Herring Applied to hwmon-next. Thanks, Guenter > --- > Documentation/devicetree/bindings/tri

Re: [PATCH] hwmon: (ftsteutates): Rudimentary typo fixes

2021-03-29 Thread Guenter Roeck
On Tue, Mar 23, 2021 at 10:04:38AM +0530, Bhaskar Chowdhury wrote: > s/Temprature/Temperature/ > s/revsion/revision/ > > Signed-off-by: Bhaskar Chowdhury > Acked-by: Randy Dunlap Partially applied; a patch fixing the revsion typo was already queued. Thanks, Guenter > --- >

Re: [PATCH v3 3/3] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-29 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:31PM +1300, Chris Packham wrote: > The BPA-RS600 is a compact 600W AC to DC removable power supply module. > > Signed-off-by: Chris Packham > Reviewed-by: Guenter Roeck Applied to hwmon-next. Thanks, Guenter

Re: [PATCH v3 1/3] dt-bindings: Add vendor prefix and trivial device for BluTek BPA-RS600

2021-03-29 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:29PM +1300, Chris Packham wrote: > Add vendor prefix "blutek" for BluTek Power. > Add trivial device entry for BPA-RS600. > > Signed-off-by: Chris Packham > Reviewed-by: Guenter Roeck > Reviewed-by: Rob Herring Applied to hwmon-next. Thanks, Guenter

Re: [PATCH V2 3/5] watchdog: of_xilinx_wdt: Used dev_dbg()

2021-03-29 Thread Guenter Roeck
l Simek > Signed-off-by: Srinivas Neeli Reviewed-by: Guenter Roeck > --- > Changes in V2: > -Updated minor review comments. > --- > drivers/watchdog/of_xilinx_wdt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/of_xi

Re: [PATCH V2 2/5] watchdog: of_xilinx_wdt: Used BIT macro

2021-03-29 Thread Guenter Roeck
On Mon, Mar 29, 2021 at 09:49:36PM +0530, Srinivas Neeli wrote: > From: Srinivas Goud > > Used BIT macro instead of mask value. > > Signed-off-by: Srinivas Goud > Signed-off-by: Michal Simek > Signed-off-by: Srinivas Neeli Reviewed-by: Guenter Roeck > --- >

Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-29 Thread Guenter Roeck
On Mon, Mar 29, 2021 at 05:22:01AM -0300, Jonas Malaco wrote: > To avoid a spinlock, the driver explores concurrent memory accesses > between _raw_event and _read, having the former updating fields on a > data structure while the latter could be reading from them. Because > these are "plain"

Re: [PATCH 5.11 000/252] 5.11.11-rc2 review

2021-03-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 31 Mar 2021 10:13:07 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 458 pass: 458 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/219] 5.10.27-rc2 review

2021-03-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 31 Mar 2021 10:13:09 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 452 pass: 452 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 000/111] 5.4.109-rc1 review

2021-03-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 31 Mar 2021 07:55:56 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 431 pass: 431 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.14 00/59] 4.14.228-rc1 review

2021-03-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 31 Mar 2021 07:55:56 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 406 pass: 406 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/72] 4.19.184-rc1 review

2021-03-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 31 Mar 2021 07:55:56 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 421 pass: 421 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.9 00/53] 4.9.264-rc1 review

2021-03-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 31 Mar 2021 07:55:56 +. > Anything received after that time might be too late. > Build results: total: 163 pass: 163 fail: 0 Qemu test results: total: 381 pass: 381 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.4 00/33] 4.4.264-rc1 review

2021-03-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 31 Mar 2021 07:55:56 +. > Anything received after that time might be too late. > Build results: total: 160 pass: 160 fail: 0 Qemu test results: total: 328 pass: 328 fail: 0 Tested-by: Guenter Roeck Guenter

Re: Linux 5.12-rc5

2021-03-29 Thread Guenter Roeck
On 3/29/21 11:05 AM, Linus Torvalds wrote: > On Sun, Mar 28, 2021 at 7:07 PM Guenter Roeck wrote: >> >> This is not really a new problem. I enabled devicetree unit tests >> in the openrisc kernel and was rewarded with a crash. >> https://lore.kernel.org/lkml/2021032

Re: [PATCH] of/fdt: Improve error checking

2021-03-29 Thread Guenter Roeck
On 3/29/21 11:21 AM, Rob Herring wrote: > On Sat, Mar 27, 2021 at 5:41 PM Guenter Roeck wrote: >> >> If an unaligned pointer is passed to of_fdt_unflatten_tree(), >> populate_node() as called from unflatten_dt_nodes() will fail. >> unflatten_dt_nodes() will retur

Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread Guenter Roeck
On 3/29/21 7:38 AM, Václav Kubernát wrote: > After some testing, I have found out there is a timing issue with this > device. After setting page, the device doesn't immediately react and > gives values from the previous page for some time. This is why there > needs to be a delay between

Re: Linux 5.12-rc5

2021-03-28 Thread Guenter Roeck
On Sun, Mar 28, 2021 at 04:05:54PM -0700, Linus Torvalds wrote: > So if rc4 was perhaps a bit smaller than average, it looks like rc5 is > a bigger than average. We're not breaking any records, but it > certainly isn't tiny, and the rc's aren't shrinking. > > I'm not overly worried yet, but

[PATCH] of/fdt: Improve error checking

2021-03-27 Thread Guenter Roeck
nittest - you will see error messages ### dt-test ### unittest_data_add: No tree to attach; not running tests when trying to run devicetree unittests. Fixes: 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9") Signed-off-by: Guenter Roeck --- drivers/of/fdt.c

Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion

2021-03-27 Thread Guenter Roeck
On 3/26/21 6:20 PM, Zhen Lei wrote: > The header file is already included above and can be > removed here. > > Signed-off-by: Zhen Lei Already submitted: https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiab...@vivo.com/ In general, when removing duplicate

Re: [Ksummit-discuss] [1/5] reporting-issues: header and TLDR

2021-03-26 Thread Guenter Roeck
On 3/25/21 11:15 PM, Thorsten Leemhuis wrote: > On 26.03.21 07:13, Thorsten Leemhuis wrote: >> > mention if backporting is planed or considered too complex. If backporting was planned

Re: [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h

2021-03-25 Thread Guenter Roeck
On 3/25/21 4:29 AM, Wan Jiabing wrote: > linux/kernel.h has been included. Remove the duplicate. > Reorder include files to be in alphabetic order. > > Signed-off-by: Wan Jiabing Reviewed-by: Guenter Roeck > --- > Changelog: > v3: > - Reorder include files to be in a

Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature

2021-03-24 Thread Guenter Roeck
> Tested with and without "O=dir", both can build successfully. > > Reported-by: Guenter Roeck > Suggested-by: Steven Rostedt > Signed-off-by: Jisheng Zhang Tested-by: Guenter Roeck > --- > drivers/tee/optee/Makefile | 3 +++ > 1 file changed, 3 insertions(+

Re: [PATCH] tee: optee: add invoke_fn tracepoints

2021-03-24 Thread Guenter Roeck
On Wed, Mar 24, 2021 at 07:34:07AM -0700, Guenter Roeck wrote: > On Wed, Feb 10, 2021 at 02:44:09PM +0800, Jisheng Zhang wrote: > > Add tracepoints to retrieve information about the invoke_fn. This would > > help to measure how many invoke_fn are triggered and how long it takes >

Re: [PATCH 5.10 000/150] 5.10.26-rc3 review

2021-03-24 Thread Guenter Roeck
> let me know. > > Responses should be made by Fri, 26 Mar 2021 09:33:54 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 433 pass: 433 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH] tee: optee: add invoke_fn tracepoints

2021-03-24 Thread Guenter Roeck
On Wed, Feb 10, 2021 at 02:44:09PM +0800, Jisheng Zhang wrote: > Add tracepoints to retrieve information about the invoke_fn. This would > help to measure how many invoke_fn are triggered and how long it takes > to complete one invoke_fn call. > > Signed-off-by: Jisheng Zhang arm64:defconfig:

Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window watchdog support

2021-03-24 Thread Guenter Roeck
On 3/23/21 11:04 PM, Srinivas Neeli wrote: > Hi Guenter, > > Thanks for review > >> -Original Message- >> From: Guenter Roeck On Behalf Of Guenter Roeck >> Sent: Tuesday, March 16, 2021 8:01 AM >> To: Srinivas Neeli ; Michal Simek ; >> Shubh

Re: [PATCH] drivers: watchdog: Remove duplicate include of kernel.h

2021-03-22 Thread Guenter Roeck
On 3/22/21 6:43 PM, Wan Jiabing wrote: > linux/kernel.h has been included at line 17, so remove the > duplicate one at line 22. > > Signed-off-by: Wan Jiabing > --- > drivers/watchdog/dw_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/dw_wdt.c

Re: [PATCH 4.4 00/14] 4.4.263-rc1 review

2021-03-22 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 24 Mar 2021 12:19:09 +. > Anything received after that time might be too late. > Build results: total: 163 pass: 163 fail: 0 Qemu test results: total: 329 pass: 329 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.9 00/25] 4.9.263-rc1 review

2021-03-22 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 24 Mar 2021 12:19:09 +. > Anything received after that time might be too late. > Build results: total: 166 pass: 166 fail: 0 Qemu test results: total: 382 pass: 382 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.14 00/43] 4.14.227-rc1 review

2021-03-22 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 24 Mar 2021 12:19:09 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 406 pass: 406 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/60] 5.4.108-rc1 review

2021-03-22 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 24 Mar 2021 12:19:09 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 431 pass: 431 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/43] 4.19.183-rc1 review

2021-03-22 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 24 Mar 2021 12:19:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 420 pass: 420 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/156] 5.10.26-rc2 review

2021-03-22 Thread Guenter Roeck
On Mon, Mar 22, 2021 at 04:19:10PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.10.26 release. > There are 156 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.11 000/120] 5.11.9-rc1 review

2021-03-22 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 24 Mar 2021 12:19:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 437 pass: 437 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/156] 5.10.26-rc2 review

2021-03-22 Thread Guenter Roeck
On Mon, Mar 22, 2021 at 04:19:10PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.10.26 release. > There are 156 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: Linux 5.12-rc4

2021-03-22 Thread Guenter Roeck
On Sun, Mar 21, 2021 at 03:34:58PM -0700, Linus Torvalds wrote: > Very much an average rc4, possibly just a tad on the smaller side of average. > > Nothing here particularly stands out. The diffstat looks a bit more > spread out than it perhaps normally would do, because of the removal > of the

Re: [PATCH v2 1/4] iommu/vt-d: Enable write protect for supervisor SVM

2021-03-22 Thread Guenter Roeck
On Tue, Mar 02, 2021 at 02:13:57AM -0800, Jacob Pan wrote: > Write protect bit, when set, inhibits supervisor writes to the read-only > pages. In supervisor shared virtual addressing (SVA), where page tables > are shared between CPU and DMA, IOMMU PASID entry WPE bit should match > CR0.WP bit in

Re: [PATCH] platform/chrome: cros_ec_typec: fix clang -Wformat warning

2021-03-22 Thread Guenter Roeck
DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > ~~~ ^~~ > > Use an explicit bit mask to limit the number to its lower eight bits > instead. > > Fixes: ad7c0510c99e ("platform/chrome: cros_ec_typec: Update port info from > EC") > Signed-off-by: Arnd B

Re: [RFC RESEND PATCH v2 8/8] watchdog: retu_wdt: Clean-up by using managed work init

2021-03-22 Thread Guenter Roeck
ile-tested only. All testing is appreciated. > > Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck > --- > drivers/watchdog/retu_wdt.c | 22 ++ > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/drivers/watchdog/retu_wdt.c b

Re: [RFC RESEND PATCH v2 4/8] hwmon: raspberry-pi: Clean-up few drivers by using managed work init

2021-03-22 Thread Guenter Roeck
ile-tested only. All testing is appreciated. > > Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck > --- > drivers/hwmon/raspberrypi-hwmon.c | 17 ++--- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/hwmon/raspberrypi-hwmon.c &

Re: [PATCH] watchdog: Fix a typo

2021-03-22 Thread Guenter Roeck
On Sun, Mar 21, 2021 at 03:03:01AM +0530, Bhaskar Chowdhury wrote: > s/parmeter/parameter/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Guenter Roeck > --- > drivers/watchdog/sl28cpld_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] watchdog: fix syntactic kernel-doc issues

2021-03-22 Thread Guenter Roeck
the watchdog subsystem. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Guenter Roeck > --- > Guenter, Wim, please pick this minor clean-up patch. > > drivers/watchdog/booke_wdt.c | 2 +- > drivers/watchdog/eurotechwdt.c | 2 +- > drivers/watchdog/

Re: [PATCH v4] RISC-V: enable XIP

2021-03-21 Thread Guenter Roeck
On Sat, Mar 06, 2021 at 02:14:38PM +0200, Vitaly Wool wrote: > Introduce XIP (eXecute In Place) support for RISC-V platforms. > It allows code to be executed directly from non-volatile storage > directly addressable by the CPU, such as QSPI NOR flash which can > be found on many RISC-V platforms.

Re: [PATCH v2 net-next 2/2] net: socket: change MSG_CMSG_COMPAT to BIT(21)

2021-03-21 Thread Guenter Roeck
acket_recvmsg(struct socket *sock, struct msghdr *msg, > size_t len, > int flags) > > If MSG_CMSG_COMPAT is set in 'flags', it's value will be negative. > Once it perform bit operations with MSG_*, the upper 32 bits of > the res

Re: [PATCH v2 net-next 1/2] net: socket: use BIT() for MSG_*

2021-03-21 Thread Guenter Roeck
On 3/21/21 6:43 AM, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Signed-off-by: Menglong Dong With this patch sent as patch 1/2, any code trying to bisect a compat

Re: [PATCH] watchdog: Fix a typo

2021-03-20 Thread Guenter Roeck
On 3/20/21 2:33 PM, Bhaskar Chowdhury wrote: > s/parmeter/parameter/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Guenter Roeck > --- > drivers/watchdog/sl28cpld_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/

Re: [PATCH 11/14] watchdog: npcm: Add support for WPCM450

2021-03-20 Thread Guenter Roeck
On 3/20/21 11:16 AM, Jonathan Neuschäfer wrote: Patch description goes here. Guenter > Signed-off-by: Jonathan Neuschäfer > --- > drivers/watchdog/npcm_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/npcm_wdt.c b/drivers/watchdog/npcm_wdt.c > index

Re: [PATCH v3 3/3] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-19 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:31PM +1300, Chris Packham wrote: > The BPA-RS600 is a compact 600W AC to DC removable power supply module. > > Signed-off-by: Chris Packham For my reference (aiting for bindings approval): Reviewed-by: Guenter Roeck Guenter > --- > > Notes: &

Re: [PATCH v3 1/3] dt-bindings: Add vendor prefix and trivial device for BluTek BPA-RS600

2021-03-19 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:29PM +1300, Chris Packham wrote: > Add vendor prefix "blutek" for BluTek Power. > Add trivial device entry for BPA-RS600. > > Signed-off-by: Chris Packham For my reference (waiting for bindings approval): Reviewed-by: Guenter Roeck Gue

Re: [PATCH v3 2/3] hwmon: (pmbus): Replace - with _ in device names before registration

2021-03-19 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:30PM +1300, Chris Packham wrote: > The hwmon sysfs ABI requires that the `name` property doesn't include > any dashes. But when the pmbus code picks the name up from the device > tree it quite often does. Replace '-' with '_' before registering the > device. > >

Re: [PATCH 1/2] dt-bindings: Add trivial device entry for TPS53676

2021-03-19 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 10:24:40PM +0100, Erik Rosen wrote: > Add trivial device entry for TPS53676 > > Signed-off-by: Erik Rosen For my reference (waiting for dt maintainer acceptance): Reviewed-by: Guenter Roeck > --- > Documentation/devicetree/bindings/trivial-devices.y

Re: [PATCH v2] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-19 Thread Guenter Roeck
On Fri, Mar 19, 2021 at 01:55:44AM -0300, Jonas Malaco wrote: > These are "all-in-one" CPU liquid coolers that can be monitored and > controlled through a proprietary USB HID protocol. > > While the models have differently sized radiators and come with varying > numbers of fans, they are all

Re: [PATCH 5.11 00/31] 5.11.8-rc1 review

2021-03-19 Thread Guenter Roeck
let me know. > > Responses should be made by Sun, 21 Mar 2021 12:17:37 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 437 pass: 437 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 00/13] 5.10.25-rc1 review

2021-03-19 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 21 Mar 2021 12:17:37 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 432 pass: 432 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/18] 5.4.107-rc1 review

2021-03-19 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 21 Mar 2021 12:17:37 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 431 pass: 431 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 0/8] 4.19.182-rc1 review

2021-03-19 Thread Guenter Roeck
re full instead of %pure-parser I tried to fix the problem in v4.9.y and v4.4.y as well, but that is pretty much hopeless. I'll have to stop testing perf builds for those kernels. Anyway, Tested-by: Guenter Roeck Guenter

Re: [PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-19 Thread Guenter Roeck
On 3/19/21 1:58 AM, Wilken Gottwalt wrote: > On Thu, 18 Mar 2021 12:01:50 -0700 > Guenter Roeck wrote: > >> On Thu, Mar 18, 2021 at 03:17:14PM +0100, Wilken Gottwalt wrote: >>> Adds support for reading the critical values of the temperature sensors >>> and the

Re: [PATCH] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 08:15:06PM -0300, Jonas Malaco wrote: [ ... ] > > Either case, the spinlocks are overkill. It would be much easier to > > convert raw readings here into temperature and fan speed and store > > the resulting values in struct kraken2_priv_data, and then to > > just report

Re: [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for TPS53676

2021-03-18 Thread Guenter Roeck
On 3/18/21 2:24 PM, Erik Rosen wrote: > Add support for TI TPS53676 controller to the tps53679 pmbus driver > > The driver uses the USER_DATA_03 register to figure out how many phases are > enabled and to which channel they are assigned, and sets the number of pages checkpatch complains about

Re: [PATCH] hwmon: Fix spelling typo

2021-03-18 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 08:46:37PM +0800, zuoqil...@163.com wrote: > From: zuoqilin > > Change 'revsion' to 'revision'. > > Signed-off-by: zuoqilin Applied. In the future also please list the affected driver in the subject line. Thanks, Guenter > --- > drivers/hwmon/ftsteutates.c | 2 +- >

Re: [PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-18 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 03:17:14PM +0100, Wilken Gottwalt wrote: > Adds support for reading the critical values of the temperature sensors > and the rail sensors (voltage and current) once and caches them. Updates > the naming of the constants following a more clear scheme. Also updates > the

Re: [PATCH] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Guenter Roeck
On 3/18/21 9:48 AM, Jonas Malaco wrote: > These are "all-in-one" CPU liquid coolers that can be monitored and > controlled through a proprietary USB HID protocol. > > While the models have differently sized radiators and come with varying > numbers of fans, they are all indistinguishable at the

<    1   2   3   4   5   6   7   8   9   10   >