This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writeb'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'readw'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writew'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writew'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writew'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writew'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writew'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writew'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writel'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writel'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writel'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'readl'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writel'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writel'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writel'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writeb'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writeb'. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. It's also not used. Remove the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging
The macro 'devpriv' relies on a local variable having a specific
name and yeilds a pointer derived from that local variable. Replace
the macro with a local variable where used.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
The macro 'thisboard' relies on a local variable having a specific
name and yeilds a pointer derived from that local variable. Replace
the macro with a local variable where used and use the comedi_board()
helper to get the pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc
Factor the find pci device code out of the attach function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/rtd520.c | 74 ++---
1 file
Use for_each_pci_dev() instead of open-coding the for loop. Create
local variables for the bus and slot options as well as the thisboard
pointer in order to clarify the code. Consolidate the printk's when
a supported board is not found into one dev_warn message.
Signed-off-by: H Hartley Sweeten
Change the whitespace of the range tables to avoid the 80
character lines and the ugly line breaks. Convert a couple of
the RANGE() values into the appropriate {UNI,BIP}_RANGE().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Remove a couple unnecessary comments. For aesthetic reasons, add
some whitespace to the boardinfo to improve readability.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi
On Wednesday, July 11, 2012 3:20 AM, Ian Abbott wrote:
On 2012-07-11 00:36, H Hartley Sweeten wrote:
The 'devpriv' macro usage in this driver is holding up other cleanup
of the comedi drivers.
This patch series removes all the macros used to read/write the
hardware registers. All of them
: H Hartley Sweeten hswee...@visionengravers.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
To be applied after Hartley's 83 patches.
---
drivers/staging/comedi/drivers/rtd520.c | 23 ++-
1 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers
to remove some of the unneeded private data variables and to use the
comedi_device iobase variable.
H Hartley Sweeten (30):
staging: comedi: add pci_dev pointer to comedi_device
staging: comedi: adl_pci6208: use comedi_device pci_dev pointer
staging: comedi: adl_pci7230: use comedi_device pci_dev
Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedidev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci6208.c | 17
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci7230.c | 15
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci7230.c | 9 -
1 file changed, 9
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci7296.c | 15
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci7296.c | 9 -
1 file changed, 9
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci7432.c | 15
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci7432.c | 9 -
1 file changed, 9
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci8164.c | 15
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci8164.c | 9 -
1 file changed, 9
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9111.c | 25
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 23
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas.c | 31
Factor the find pci device code out of the attach function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidio.c | 56 --
1 file
the need for the 'goto'. Reword the messages
a bit. Also, move the setting of the dev-board_name back into the
attach.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidio.c | 21
Use the iobase in the comedi_device struct instead of carrying it
in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidio.c | 14
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidio.c | 23 ---
1 file
Factor the find pci device code out of the attach function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 91 +
1 file
Cleanup the find pci device code to follow the format of the
other comedi pci drivers.
Create local variables for the bus and slot options to clarify the
code. Change the pci ven/dev test to reduce the indent level. Change
the printk into a dev_warn.
Signed-off-by: H Hartley Sweeten hswee
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/contec_pci_dio.c
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 9 -
1 file changed, 9
Factor the find pci device code out of the attach function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 86 ++-
1 file
Cleanup the find pci device code to follow the format of the
other comedi pci drivers.
Use for_each_pci_dev() instead of open-coding the for loop. Reorder
and refactor some of the tests to reduce the indent level. Change
the printk's to dev_printk's.
Signed-off-by: H Hartley Sweeten hswee
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 25
These variables are set during the attach of the device but they are
never read. Just remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dyna_pci10xx.c
Use the iobase in the comedi_device struct instead of carrying it
in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 11
Factor the find pci device code out of the attach function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ke_counter.c | 46 ++---
1 file
-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ke_counter.c | 58 -
1 file changed, 23 insertions(+), 35 deletions(-)
diff --git a/drivers/staging
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Since the pci_dev pointer was the only variable in the private
data, remove it as well.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah
On Thursday, July 19, 2012 4:35 PM, gregkh wrote:
On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote:
If the comedi pci drivers have the attach_pci callback defined, the
PCI api does correctly probe the driver. The comedi_pci_auto_config()
then passes the pci_dev directly
The patchset to store the pci_dev in the comedi_device had a couple
issues pointed out by Ian Abbott. This patchset addresses all of
them except checking the bustype in the detach of the amplc drivers.
Ian is going to address those.
H Hartley Sweeten (5):
staging: comedi: remove pci_is_enabled
.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reported-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 3 ---
drivers/staging/comedi/drivers/adv_pci1723.c | 2 --
drivers/staging/comedi/drivers
As mentioned by Ian Abbott, this driver originally checked
the pci_dev subsystem_device in order to make sure that the
pci_dev was compatible with this driver. The cleanup of the
find pci device code removed this check. Add it back.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
to know that comedi_pci_disable() needs to
be called.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reported-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/daqboard2000.c | 14 +++---
1 file changed, 7
to know that comedi_pci_disable() needs to
be called.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reported-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt3000.c | 6 --
1 file changed, 4 insertions(+), 2
to know that comedi_pci_disable() needs to
be called.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reported-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/rtd520.c | 26 ++
1 file changed, 10
Hello all,
I was just trying a allyesconfig build of next-20121126 and got this:
CC fs/cifs/cifs_debug.o
In function 'copy_from_user',
inlined from 'cifs_security_flags_proc_write' at fs/cifs/cifs_debug.c:593:
/home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211:
Hello all,
Another build failure with next-20121126:
CC security/integrity/evm/evm_secfs.o
In function 'copy_from_user',
inlined from 'evm_write_key' at security/integrity/evm/evm_secfs.c:71:
/home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211:
error: call to
Introduce, and use, the helper macro module_hid_driver to allow removing
the init/exit boilerplate code from the HID drivers.
H Hartley Sweeten (3):
HID: introduce helper for hid_driver boilerplate
HID: hid.h: remove unused hid_generic_{init,exit} prototypes
HID: Use module_hid_driver macro
Introduce the module_hid_driver macro which is a convenience macro
for HID driver modules similar to module_usb_driver. It is intended
to be used by drivers with init/exit sections that do nothing but
register/unregister the HID driver.
Signed-off-by: H Hartley Sweeten hswee
These functions are not defined. Remove the extern declarations.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Jiri Kosina jkos...@suse.cz
---
include/linux/hid.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index d6c71a6
-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Jiri Kosina jkos...@suse.cz
---
drivers/hid/hid-a4tech.c | 13 +
drivers/hid/hid-apple.c| 19 +--
drivers/hid/hid-aureal.c | 13 +
drivers/hid/hid-axff.c | 14
On Thursday, November 15, 2012 9:28 AM, Arpith Easow Alexander wrote:
On Tue, Nov 13, 2012 at 11:52:52AM -0800, Greg KH wrote:
So a macro called dbgcm tests a variable called dbgcm? Gotta love c at
times...
Just delete the macro, and the variable, and call dev_dbg() directly
please.
Ok.
On Saturday, January 12, 2013 7:11 PM, Peter Huewe wrote:
This patch introduces a new macro 'module_comedi_pcmcia_driver'
for comedi PCMCIA drivers which do not do anything special in module
init/exit. This eliminates a lot of boilerplate.
Adapted from 'module_comedi_pci_driver'
On Monday, January 07, 2013 3:40 PM, Greg KH wrote:
On Sat, Jan 05, 2013 at 06:12:55PM +0400, Lijo Antony wrote:
Reduced line lengths to 80 chars by removing extra spaces.
Signed-off-by: Lijo Antony lijo.ker...@gmail.com
---
.../staging/comedi/drivers/addi-data/addi_common.h | 20
On Monday, January 07, 2013 9:30 PM, Stephen Rothwell wrote:
On Mon, 7 Jan 2013 20:27:30 -0800 Greg KH g...@kroah.com wrote:
On Tue, Jan 08, 2013 at 01:23:52PM +1100, Stephen Rothwell wrote:
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
On Wednesday, July 24, 2013 3:05 PM, Greg Kroah-Hartman wrote:
The dev_attrs field of struct class is going away soon, dev_groups
should be used instead. This converts the comedi class code to use the
correct field.
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee
On Monday, July 01, 2013 3:52 PM, H Hartley Sweeten wrote:
Tidy up this driver a bit.
v2: redo patch 4 based on suggestions from Alan Stern
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get
On Friday, August 16, 2013 8:02 AM, Vivien Didelot wrote:
Hi Linus,
You wrote:
But:
drivers/gpio/gpio-pca953x.c | 2 +-
(...)
diff --git a/drivers/gpio/gpio-pca953x.c
b/drivers/gpio/gpio-pca953x.c
index 426c51d..8804aec 100644
--- a/drivers/gpio/gpio-pca953x.c
+++
On Tuesday, June 11, 2013 12:48 PM, Thierry Reding wrote:
I'm tempted to take your v5 patch and make a note to clean that up
separately at some point (along with similar changes for the DEBUG_FS
support).
Thierry,
So you want a v6 of this patch or are you ok with v5?
Thanks,
Hartley
--
To
/vision_ep9307.c| 2 +-
For the ep93xx change:
Acked-by: H Hartley Sweeten hswee...@visionengravers.com
Thanks
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
301 - 400 of 988 matches
Mail list logo
