[PATCH 07/90] staging: comedi: adl_pci7432: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci7432.c | 19 +++ 1 file changed, 11 insertions

[PATCH 08/90] staging: comedi: adl_pci7432: remove the private data

The private data is no longer needed by this driver. Remove the struct, devpriv macro, and the allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci7432.c | 9 - 1 file changed, 9 deletions(-) diff --git

[PATCH 09/90] staging: comedi: adl_pci8164: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci8164.c | 19 +++ 1 file changed, 11 insertions

[PATCH 10/90] staging: comedi: adl_pci8164: remove the private data

The private data is no longer needed by this driver. Remove the struct, devpriv macro, and the allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci8164.c | 9 - 1 file changed, 9 deletions(-) diff --git

[PATCH 11/90] staging: comedi: adl_pci9111: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 29 +++- 1 file changed, 16

[PATCH 12/90] staging: comedi: adl_pci9118: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 33 +++- 1 file changed, 18

[PATCH 13/90] staging: comedi: adv_pci1723: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 42 +--- 1 file changed, 26 insertions(+), 16 deletions(-) diff --git

[PATCH 14/90] staging: comedi: adv_pci1723: cleanup "find pci device" code

Use for_each_pci_dev() instead of open-coding the loop using pci_get_device(). Drop the printk error messages. They just add noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 63 1

[PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

Use pci_is_enabled() in the "find pci device" function to determine if the found pci device is not in use and move the comedi_pci_enable() call into the attach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1

[PATCH 16/90] staging: comedi: adv_pci1723: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 23 +-- 1 file changed, 13

[PATCH 17/90] staging: comedi: adv_pci1710: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 42 ++-- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git

[PATCH 19/90] staging: comedi: adv_pci1710: move comedi_pci_enable() into the attach

Use pci_is_enabled() in the "find pci device" function to determine if the found pci device is not in use and move the comedi_pci_enable() call into the attach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1

[PATCH 20/90] staging: comedi: adv_pci1710: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 25 ++--- 1 file changed, 14

[PATCH 21/90] staging: comedi: adv_pci_dio: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 48 +--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git

[PATCH 22/90] staging: comedi: adv_pci_dio: remove CheckAndAllocCard()

This driver creates a linked list of all the pci devices in the system while it's looking for a match. It's only use is to determine if a device is "free" to use. The pci_is_enabled() helper can give us the same information. Use that instead and remove the linked list. Signed-off-by:

[PATCH 23/90] staging: comedi: adv_pci_dio: cleanup "find pci device" code

Add a couple local variables to make the tests more concise. Reorder the tests to make the for() loop checking for a matching boardtype quicker. Drop the dev_dbg message for a match. It's just add noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers

[PATCH 24/90] staging: comedi: adv_pci_dio: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 23 --- 1 file changed, 12

[PATCH 25/90] staging: comedi: cb_pcidas: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 32 -- 1 file changed, 17

[PATCH 26/90] staging: comedi: cb_pcidio: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidio.c | 54 ++ 1 file changed, 25 insertions(+), 29 deletions(-) diff --git

[PATCH 27/90] staging: comedi: cb_pcidio: cleanup "find pci device" code

Add a couple local variables to make the tests more concise. Reorder the tests to make the for() loop checking for a matching boardtype quicker. Drop the dev_dbg for a match. It's just add noise. Reword the dev_err when no match is found. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc

[PATCH 28/90] staging: comedi: cb_pcidio: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidio.c | 25 - 1 file changed, 12

[PATCH 29/90] staging: comedi: amplc_dio200: cleanup "find pci device" code

Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_dio200.c | 42 ++- 1 file changed, 15 insertions(+), 27 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_dio200.c b/drivers/staging/comedi/drivers/amplc_dio200.c

[PATCH 30/90] staging: comedi: amplc_dio200: store the pci_dev in the comedi_device

device otherwise it's an ISA device. Using IS_ENABLED() to omit the code paths makes the code a bit confusing and doesn't save much. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_dio200.c | 31 +++ 1 file

[PATCH 31/90] staging: comedi: amplc_pc236: cleanup "find pci device" code

Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pc236.c | 43 +++- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pc236.c b/drivers/staging/comedi/drivers/amplc_pc236.c

[PATCH 32/90] staging: comedi: amplc_pc236: store the pci_dev in the comedi_device

device otherwise it's an ISA device. Using IS_ENABLED() to omit the code paths makes the code a bit confusing and doesn't save much. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pc236.c | 28 1 file

[PATCH 33/90] staging: comedi: amplc_pc263: cleanup "find pci device" code

Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pc263.c | 42 +++- 1 file changed, 16 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pc263.c b/drivers/staging/comedi/drivers/amplc_pc263.c

[PATCH 34/90] staging: comedi: amplc_pc263: store the pci_dev in the comedi_device

device otherwise it's an ISA device. Using IS_ENABLED() to omit the code paths makes the code a bit confusing and doesn't save much. Since the pci_dev was the only thing in the private data, remove the struct, and it's allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

[PATCH 35/90] staging: comedi: amplc_pci224: cleanup "find pci device" code

Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci224.c | 43 ++- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/amplc_pci224.c

[PATCH 37/90] staging: comedi: amplc_pci230: cleanup "find pci device" code

For aesthetic reasons, rename the function and pass the comedi_devconfig struct instead of pre-parsing out the bus/slot information. Consolidate the dev_err messages when a pci device is not found. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging

[PATCH 38/90] staging: comedi: amplc_pci230: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci230.c | 25 +++-- 1 file changed, 11

[PATCH 39/90] staging: comedi: cb_pcidas64: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 57 ++-- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git

[PATCH 40/90] staging: comedi: cb_pcidas64: cleanup "find pci device" code

Add a couple local variables to make the tests more concise. Reorder the tests to make the for() loop checking for a matching boardtype quicker. Drop the dev_dbg for a match. It's just add noise. Reword the dev_err when no match is found. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc

[PATCH 41/90] staging: comedi: cb_pcidas64: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Save the pci bar in dev->iobase so the detach is consistent with the other comedi pci drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- driv

[PATCH 42/90] staging: comedi: cb_pcidda: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidda.c | 60 -- 1 file changed, 32 insertions(+), 28 deletions(-) diff --git

[PATCH 43/90] staging: comedi: cb_pcidda: cleanup "find pci device" code

Add a couple local variables to make the tests more concise. Reorder the tests to make the for() loop checking for a matching boardtype quicker. Drop the dev_dbg for a match. It's just add noise. Reword the dev_err when no match is found. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc

[PATCH 44/90] staging: comedi: cb_pcidda: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Save the pci bar in dev->iobase so the detach is consistent with the other comedi pci drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- driv

[PATCH 45/90] staging: comedi: cb_pcidio: store the iobase in the comedi_device

Save the pci bar in dev->iobase instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidio.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCH 46/90] staging: comedi: cb_pcidio: remove the private data

The private data is no longer needed by this driver. Remove the struct, devpriv macro, and the allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidio.c | 24 1 file changed, 24 deletions(-) diff

[PATCH 47/90] staging: comedi: cb_pcimdas: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 61 +++-- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git

[PATCH 48/90] staging: comedi: cb_pcimdas: cleanup "find pci device" code

the dev_err when no match is found. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 38 - 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b

[PATCH 49/90] staging: comedi: cb_pcimdas: remove the debug print of the pci bars

Remove the dev_dbg output of the pci addresses. It's just add noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b

[PATCH 50/90] staging: comedi: cb_pcimdas: cleanup the private data

Remove the unused variables from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b/drivers/staging

[PATCH 51/90] staging: comedi: cb_pcimdas: remove BADR1 from the private data

The pci resource bar 1 address is not used in the driver. Remove it from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 52/90] staging: comedi: cb_pcimdas: remove BADR4 from the private data

The pci resource bar 4 address is only needed to initialize the 8255 subdevice. Use a local variable to hold it and remove it from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 7 +++ 1 file

[PATCH 53/90] staging: comedi: cb_pcimdas: remove BADR2 from the private data

The pci resource bar 2 address is the primary i/o address used by this device. Store it in dev->iobase and remove it from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 12 +--- 1 file chan

[PATCH 54/90] staging: comedi: cb_pcimdas: remove BADR0 from the private data

The pci resource bar 0 address is only used as a "flag" to let the datach function know that the pci device has been enabled. Use dev->iobase in the detach instead and remove BADR0 from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 55/90] staging: comedi: cb_pcimdas: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 29 + 1 file changed, 13

[PATCH 56/90] staging: comedi: contec_pci_dio: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/contec_pci_dio.c | 92 ++--- 1 file changed, 50 insertions(+), 42 deletions(-) diff --git

[PATCH 57/90] staging: comedi: contec_pci_dio: cleanup "find pci device" code

Add a couple local variables and reorder the tests to make to make the more concise. Change the printk to a dev_err when no match is found and reword the message. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/contec_pci_dio.c | 27

[PATCH 58/90] staging: comedi: contec_pci_dio: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/contec_pci_dio.c | 13 ++--- 1 file changed, 6 insertions(+), 7

[PATCH 59/90] staging: comedi: contec_pci_dio: remove the private data

The private data is no longer needed by this driver. Remove the struct, devpriv macro, and the allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/contec_pci_dio.c | 9 - 1 file changed, 9 deletions(-) diff --git

[PATCH 60/90] staging: comedi: daqboard2000: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/daqboard2000.c | 68 +++ 1 file changed, 39 insertions(+), 29 deletions(-) diff --git

[PATCH 61/90] staging: comedi: daqboard2000: cleanup "find pci device" code

found. Consolidate the dev_err messages when a device is not found into a single message. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/daqboard2000.c | 56 ++- 1 file changed, 20 insertions(+), 36 deletions(-)

[PATCH 62/90] staging: comedi: daqboard2000: remove 'got_regions' from private data

The 'got_regions' variable in the private data is used as a flag for the detach to know if the pci device has been enabled. Typically the dev->iobase variable is used to indicate this in all the other comedi drivers. Do the same here for consistancy. Signed-off-by: H Hartley Sweeten Cc:

[PATCH 63/90] staging: comedi: daqboard2000: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/daqboard2000.c | 15 --- 1 file changed, 8 insertions(+), 7

[PATCH 64/90] staging: comedi: daqboard2000: void *plx should be a void __iomem *

The private data variable 'plx' is an ioremap'ed pci resource and should be a void __iomem *. This quiets a number of sparse warnings about "different address spaces". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/daqboard

[PATCH 65/90] staging: comedi: dt3000: cleanup "find pci device" code

The "find pci device" code for this driver was split between two functions which could cause the driver to walk the pci bus multiple times while looking for a match. Consolidate the functions into the format that is more standard for the comedi pci drivers. Signed-off-by: H Hartley S

[PATCH 66/90] staging: comedi: dt3000: move the setup_pci() code into the attach

The setup_pci() function simply calls comedi_pci_enable() to enable the device then ioremaps the pci address. Move the code directly into the attach function as is more typical for the comedi pci drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers

[PATCH 67/90] staging: comedi: dt3000: remove 'phys_addr' from the private data

The 'phys_addr' variable in the private data is simply used as a flag for the detach function to know that the pci device has been enabled. Use the 'dev->iobase' variable instead as is more typical for other comedi pci drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kr

[PATCH 68/90] staging: comedi: dt3000: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 16 1 file changed, 8 insertions(+), 8

[PATCH 71/90] staging: comedi: dyna_pci10xx: remove the 'start_stop_sem' mutex

The comedi core already has a mutex protecting the attach/detach of the comedi drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git

[PATCH 72/90] staging: comedi: dyna_pci10xx: remove 'valid' from the private data

This variable is set at the end of the attach but never used in the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 73/90] staging: comedi: dyna_pci10xx: remove unused bars from the private data

All of the pci device base address registers are saved in the private data but only bar2 and bar3 are used by the driver. Remove the others. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 7 +-- 1 file changed, 1

[PATCH 74/90] staging: comedi: dyna_pci10xx: use dev->iobase

Use dev->iobase to hold one of the pci base addresses used by the driver instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 10 +- 1 file changed, 5 insertions(+)

[PATCH 75/90] staging: comedi: dyna_pci10xx: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 76/90] staging: comedi: dyna_pci10xx: fix detach

The detach for this driver is missing the check to make sure that the pci device is enabled before disabling it. It's also missing the pci_dev_put(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 +++- 1 file

[PATCH 77/90] staging: comedi: ke_counter: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ke_counter.c | 37 - 1 file changed, 26 insertions(+), 11 deletions(-) diff --git

[PATCH 78/90] staging: comedi: ke_counter: cleanup "find pci device" code

Cleanup the "find pci device" code so that it follows the style of the other comedi pci drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ke_counter.c | 60 +++-- 1 file changed, 23 inserti

[PATCH 79/90] staging: comedi: ke_counter: minor cleanup of cnt_attach()

Cleanup the attach function a bit to follow the style of the other comedi pci drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ke_counter.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 80/90] staging: comedi: ke_counter: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Since the pci_dev was the only thing in the private data, remove the struct, the devpriv macro, and it's allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

[PATCH 81/90] staging: comedi: ke_counter: remove the cnt_board_nbr macro

This macro is an open-coded version of ARRAY_SIZE(). Use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ke_counter.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 82/90] staging: comedi: me_daq: factor out the "find pci device" code

Factor the "find pci device" code out of the attach function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 49 - 1 file changed, 30 insertions(+), 19 deletions(-) diff --git

[PATCH 83/90] staging: comedi: me_daq: cleanup "find pci device" code

Cleanup the "find pci device" code so that it follows the style of the other comedi pci drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 63 - 1 file changed, 23 inserti

[PATCH 84/90] staging: comedi: me_daq: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Since the pci_dev was the only thing in the private data, remove the struct, the devpriv macro, and it's allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

[PATCH 85/90] staging: comedi: rtd520: remove the debug print of the pci addresses

This is just noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c index 9998d6b

[PATCH 86/90] staging: comedi: rtd520: remove 'got_regions' from private data

The 'got_regions' variable in the private data is used as a flag for the detach to know if the pci device has been enabled. Typically the dev->iobase variable is used to indicate this in all the other comedi drivers. Do the same here for consistancy. Signed-off-by: H Hartley Sweeten Cc:

[PATCH 87/90] staging: comedi: rtd520: remove the '#if 0' code in the attach

This driver has code #if 0'ed out that would allow cleaning up the attach if there was an error. The comedi core currently calls the detach function to do this if the attach fails. Remove the #if 0'ed out code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 88/90] staging: comedi: rtd520: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 48 - 1 file changed, 24

[PATCH 89/90] staging: comedi: aio_iiro_16: remove the private data

The private data is not used by this driver. Remove the struct, devpriv macro, and the allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_iiro_16.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers

[PATCH 90/90] staging: comedi: s526: remove unused variables in the private data

The 'data' and 'pci_dev' variables in the private data are not used. They appear to be cut-and-paste from the skel driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/s526.c | 8 1 file changed, 8 deletions

RE: [PATCH 01/90] staging: comedi: comedidev.h: introduce comedi_to_pci_dev() helper

On Thursday, July 19, 2012 2:23 AM, Ian Abbott wrote: > On 2012-07-19 02:24, H Hartley Sweeten wrote: >> Introduce a wrapper for to_pci_dev() to allow the comedi pci drivers >> to store the pci_dev pointer in the comedi_device hw_dev variable and >> retrieve it easily. &

RE: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

On Thursday, July 19, 2012 2:38 AM, Ian Abbott wrote: > On 2012-07-19 02:30, H Hartley Sweeten wrote: >> Use pci_is_enabled() in the "find pci device" function to determine if >> the found pci device is not in use and move the comedi_pci_enable() call >> into the

RE: [PATCH 30/90] staging: comedi: amplc_dio200: store the pci_dev in the comedi_device

On Thursday, July 19, 2012 3:11 AM, Ian Abbott wrote: > On 2012-07-19 02:37, H Hartley Sweeten wrote: >> Use the hw_dev pointer in the comedi_device struct to hold the >> pci_dev instead of carrying it in the private data. >> >> Since the pci_dev is no longer held

RE: [PATCH 30/90] staging: comedi: amplc_dio200: store the pci_dev in the comedi_device

On Thursday, July 19, 2012 3:27 AM, Ian Abbott wrote: > On 2012-07-19 11:10, Ian Abbott wrote: >> On 2012-07-19 02:37, H Hartley Sweeten wrote: >>> Use the hw_dev pointer in the comedi_device struct to hold the >>> pci_dev instead of carrying it in the private data

RE: [PATCH 01/90] staging: comedi: comedidev.h: introduce comedi_to_pci_dev() helper

On Thursday, July 19, 2012 9:32 AM, Dan Carpenter wrote: > On Thu, Jul 19, 2012 at 11:20:52AM -0500, H Hartley Sweeten wrote: >> On Thursday, July 19, 2012 2:23 AM, Ian Abbott wrote: >>> That needs to be something like: >>> >>> return dev->hw_dev ? to_

[PATCH 01/90 v2] staging: comedi: comedidev.h: introduce comedi_to_pci_dev() helper

Introduce a wrapper for to_pci_dev() to allow the comedi_pci_drivers to store the pci_dev pointer in the comedi_device hw_dev variable and retrieve it easily. Signed-off-by: H Hartley Sweeten Cc: Ian Abbot Cc: Greg Kroah-Hartman --- v2: Ian Abbott pointed out that the dev->hw_dev ne

RE: [PATCH 88/90] staging: comedi: rtd520: store the pci_dev in the comedi_device

On Thursday, July 19, 2012 5:42 AM, Ian Abbott wrote: > On 2012-07-19 03:05, H Hartley Sweeten wrote: >> Use the hw_dev pointer in the comedi_device struct to hold the >> pci_dev instead of carrying it in the private data. > > My reply to patch 86 has a knock-on

RE: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

On Thursday, July 19, 2012 4:17 PM, gregkh wrote: > On Thu, Jul 19, 2012 at 12:12:02PM -0500, H Hartley Sweeten wrote: >> I was planning on making a comedi_find_pci_dev() function that the >> drivers could call with a "match" callback. This would allow a co

RE: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

On Thursday, July 19, 2012 4:35 PM, gregkh wrote: > On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote: >> If the comedi pci drivers have the "attach_pci" callback defined, the >> PCI api does correctly probe the driver. The comedi_pci_auto_config() &

RE: [PATCH 00/90] staging: comedi: cleanup the pci_dev usage

On Thursday, July 19, 2012 4:53 PM, Greg KH wrote: > On Wed, Jul 18, 2012 at 06:23:20PM -0700, H Hartley Sweeten wrote: >> All the comedi pci drivers currently store a pointer to the pci_dev >> in their private data. We can use the 'struct device *hw_dev' variable >> in the

RE: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

On Thursday, July 19, 2012 4:35 PM, gregkh wrote: > On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote: >> If the comedi pci drivers have the "attach_pci" callback defined, the >> PCI api does correctly probe the driver. The comedi_pci_auto_config() &

[PATCH 0/5] staging: comedi: fix issues with the pci_dev patchset

The patchset to store the pci_dev in the comedi_device had a couple issues pointed out by Ian Abbott. This patchset addresses all of them except checking the "bustype" in the detach of the amplc drivers. Ian is going to address those. H Hartley Sweeten (5): staging: come

[PATCH 1/5] staging: comedi: remove pci_is_enabled() tests

. Signed-off-by: H Hartley Sweeten Reported-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 3 --- drivers/staging/comedi/drivers/adv_pci1723.c | 2 -- drivers/staging/comedi/drivers/adv_pci_dio.c | 2 -- 3 files changed, 7 deletions(-) diff --git

[PATCH 2/5] staging: comedi: daqboard2000: add back subsystem_device check

As mentioned by Ian Abbott, this driver originally checked the pci_dev subsystem_device in order to make sure that the pci_dev was compatible with this driver. The cleanup of the "find pci device" code removed this check. Add it back. Signed-off-by: H Hartley Sweeten Reported-by: Ian

[PATCH 3/5] staging: comedi: daqboard2000: ioremap'ed addresses are resource_size_t

it as a flag to know that comedi_pci_disable() needs to be called. Signed-off-by: H Hartley Sweeten Reported-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/daqboard2000.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/c

[PATCH 4/5] staging: comedi: dt3000: ioremap'ed addresses are resource_size_t

it as a flag to know that comedi_pci_disable() needs to be called. Signed-off-by: H Hartley Sweeten Reported-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/driver

[PATCH 5/5] staging: comedi: rtd520: ioremap'ed addresses are resource_size_t

it as a flag to know that comedi_pci_disable() needs to be called. Signed-off-by: H Hartley Sweeten Reported-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/s

build failure next-20121126

Hello all, I was just trying a allyesconfig build of next-20121126 and got this: CC fs/cifs/cifs_debug.o In function 'copy_from_user', inlined from 'cifs_security_flags_proc_write' at fs/cifs/cifs_debug.c:593: /home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211:

build failure next-20121126

Hello all, Another build failure with next-20121126: CC security/integrity/evm/evm_secfs.o In function 'copy_from_user', inlined from 'evm_write_key' at security/integrity/evm/evm_secfs.c:71: /home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211: error: call to

Q: Kconfig option VIRT_TO_BUS

Hello all, Does anyone know what the Kconfig option VIRT_TO_BUS does? There are a number of "depends on" that option but it does not seem to directly enable any code in the kernel. Thanks for any reply. Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

<    3   4   5   6   7   8   9   10   >