On 09/02/2021 17:24, Stanimir Varbanov wrote:
> Introduce Content light level and Mastering display colour
> volume Colorimetry compound controls with relevant payload
> structures and validation.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 67
`.
> +* - ``V4L2_CTRL_CLASS_COLORIMETRY``
> + - 0xa50000
> + - The class containing colorimetry controls. These controls are
> + described in :ref:`colorimetry-controls`.
>
> Return Value
>
>
Reviewed-by: Hans Verkuil
Regards,
Hans
D_COLORIMETRY_CLASS_BASE (V4L2_CTRL_CLASS_COLORIMETRY |
> 0x900)
> +#define V4L2_CID_COLORIMETRY_CLASS (V4L2_CTRL_CLASS_COLORIMETRY | 1)
> +
> /* MPEG-compression definitions kept for backwards compatibility */
> #ifndef __KERNEL__
> #define V4L2_CTRL_CLASS_MPEGV4L2_CTRL_CLASS_CODEC
>
Reviewed-by: Hans Verkuil
Regards,
Hans
> (V4L2_CID_CODEC_BASE+228)
> #define V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME
> (V4L2_CID_CODEC_BASE+229)
> #define V4L2_CID_MPEG_VIDEO_BASELAYER_PRIORITY_ID
> (V4L2_CID_CODEC_BASE+230)
> +#define V4L2_CID_MPEG_VIDEO_DEC_CONCEAL_COLOR
> (V4L2_CID_CODEC_BASE+231)
>
> /* CIDs for the MPEG-2 Part 2 (H.262) codec */
> #define V4L2_CID_MPEG_VIDEO_MPEG2_LEVEL
> (V4L2_CID_CODEC_BASE+270)
>
After fixing the typos:
Reviewed-by: Hans Verkuil
Regards,
Hans
Hi Ricardo,
On 15/03/2021 18:36, Ricardo Ribalda wrote:
> From: Hans Verkuil
>
> When uvc was written the vb2 ioctl and file operation helpers didn't exist.
>
> This patch switches uvc over to those helpers, which removes a lot of
> boilerplate
> code and simp
> only control
> test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
>
> Signed-off-by: Ricardo Ribalda
> Reviewed-by: Hans Verkuil
> ---
> drivers/media/usb/uvc/uvc_v4l2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uv
break;
> }
>
> - strscpy(vdev->name, dev->name, sizeof(vdev->name));
> + snprintf(vdev->name, sizeof(vdev->name), "%s %u", name,
> + stream->header.bTerminalLink);
>
> /*
>* Set the driver data before calling video_register_device, otherwise
>
With those changes:
Reviewed-by: Hans Verkuil
Regards,
Hans
Hi Ricardo, Laurent,
On 15/03/2021 18:36, Ricardo Ribalda wrote:
> Hans has discovered that in his test device, for the H264 format
> bytesused goes up to about 570, for YUYV it will actually go up
> to a bit over 5000 bytes, and for MJPG up to about 2706 bytes.
>
> Credit-t
On 15/03/2021 16:59, Robert Foss wrote:
> In order to support Qualcomm ISP hardware architectures that diverge
> from older architectures, the VFE subdevice driver needs to be refactored
> to better abstract the different ISP architectures.
>
> Gen1 represents the CAMSS ISP architecture. The ISP a
nst-variable=]
This array needs to be moved to camss-csid.c and declared as an extern
here. Also, this menu array needs to be terminated with a NULL, and the
right capitalization needs to be used (first character of each word must
be a capital). This is a suggested patch I made to verify that this solv
On 15/03/2021 18:36, Ricardo Ribalda wrote:
> Create all the class controls for the device defined controls.
>
> Fixes v4l2-compliance:
> Control ioctls (Input 0):
> fail: v4l2-test-controls.cpp(216): missing control class for
> class 0098
> fail: v4l2-test-control
On 16/03/2021 09:16, Xiaofeng Cao wrote:
> Hi Hans Verkuil,
>
> I'm sorry to make you confused. Please use Xiaofeng Cao
> mailto:caoxiaof...@yulong.com>>
Thanks, I've updated this to keep checkpatch happy.
BTW, for your next patch: it is good practice to add a
Hi Dinghao Liu,
Thank you for the patch, but I've decided not to take it. While the
patch looks fine, it is not very useful since the return code of the
em28xx_capture_start() function is never checked. And I am hesitant
to change the behavior here in case it might break something subtle.
Ideally
Hi Xiaofeng Cao,
The patch is good, but scripts/checkpatch.pl complains about a mismatch:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Xiaofeng Cao
' != 'Signed-off-by: Xiaofeng Cao
'
Which is the one I should use?
Regards,
Hans
On 11/03/2021 08:20, Xiaofeng Cao wrote
On 12/03/2021 13:48, Ricardo Ribalda wrote:
> From: Hans Verkuil
>
> When uvc was written the vb2 ioctl and file operation helpers didn't exist.
>
> This patch switches uvc over to those helpers, which removes a lot of
> boilerplate
> code and simplifies VIDIOC_G/S_PR
On 12/03/2021 11:13, Laurent Pinchart wrote:
> Hi Ricardo,
>
> On Fri, Mar 12, 2021 at 10:57:33AM +0100, Ricardo Ribalda Delgado wrote:
>> On Fri, Mar 12, 2021 at 2:25 AM Laurent Pinchart wrote:
>>> On Thu, Mar 11, 2021 at 11:19:45PM +0100, Ricardo Ribalda wrote:
Create all the class controls
On 12/03/2021 00:38, Laurent Pinchart wrote:
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Mar 11, 2021 at 11:19:46PM +0100, Ricardo Ribalda wrote:
>> All the entities must have a unique name.
>>
>> Fixes v4l2-compliance:
>> Media Controller ioctls:
>> fail: v4l2-test-med
w the
API was designed."
>
> Fixes v4l2-compliance:
> Control ioctls (Input 0):
> fail: v4l2-test-controls.cpp(645): invalid error index write
> only control
> test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
>
> Signed-off-by: Ricardo Ribalda
After improvin
4l2-test-controls.cpp(448): s_ctrl returned an error
> (22)
> test VIDIOC_G/S_CTRL: FAIL
> fail: v4l2-test-controls.cpp(698): s_ext_ctrls returned an
> error (22)
> test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
>
> Signed-off-by: Ricardo Ribalda
Reviewe
node->has_frmintervals &&
> !cap->capability
>
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Thanks!
Hans
> Signed-off-by: Ricardo Ribalda
> ---
> drivers/media/usb/uvc/uvc_v4l2.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(
On 11/03/2021 19:09, Robert Foss wrote:
> This series implements support for the camera subsystem found in
> the SDM845 SOCs and the Titan 170 ISP. The support is partial
> in that it implements CSIPHY, CSID, and partial VFE support.
>
> The Titan generation of the ISP diverges a fair amount from
On 11/03/2021 18:37, Randy Dunlap wrote:
> On 3/10/21 9:14 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Warning: Some of the branches in linux-next are still based on v5.12-rc1,
>> so please be careful if you are trying to bisect a bug.
>>
>> News: if your -next included tree is based on Linus' tre
On 11/03/2021 13:20, Ricardo Ribalda wrote:
> Do not create Control Classes for empty classes.
Shouldn't this be squashed with patch 06/10?
Regards,
Hans
>
> Fixes v4l2-compliance:
>
> Control ioctls (Input 0):
> fail: v4l2-test-controls.cpp(255): no controls in
On 11/03/2021 13:20, Ricardo Ribalda wrote:
> Fixes v4l2-compliance:
>
> Control ioctls (Input 0):
> fail: v4l2-test-controls.cpp(448): s_ctrl returned an error
> (22)
> test VIDIOC_G/S_CTRL: FAIL
> fail: v4l2-test-controls.cpp(698): s_ext_ctrls returned an
Hi Mirela,
On 11/03/2021 01:28, Mirela Rabulea (OSS) wrote:
> From: Mirela Rabulea
>
> Add jpeg decoder/encoder nodes, for now on imx8qxp only.
> The same should work on imx8qm, but it was not tested.
FYI: I've posted a pull request for this driver, and once it is merged
in our media tree this
Hi Mirela,
On 11/03/2021 01:28, Mirela Rabulea (OSS) wrote:
> +static const struct of_device_id mxc_jpeg_match[] = {
> + {
> + .compatible = "nxp,imx8qxp-jpgdec",
> + .data = (void *)MXC_JPEG_DECODE,
Don't do this, just say:
static const int mxc_decode_mode =
On 10/03/2021 13:33, Mirela Rabulea wrote:
> Hi Hans,
>
> On Thu, 2021-03-04 at 14:03 +0100, Hans Verkuil wrote:
>> Caution: EXT Email
>>
>> On 22/02/2021 20:09, Mirela Rabulea wrote:
>>> Hi Hans,
>>> appologies for my late response, please see below 2
Hi Dikshita,
On 03/03/2021 12:09, Dikshita Agarwal wrote:
> Long Term Reference (LTR) frames are the frames that are encoded
> sometime in the past and stored in the DPB buffer list to be used
> as reference to encode future frames.
> This change adds controls to enable this feature.
>
> Signed-o
Hi Maxime,
Some more code review comments:
On 19/02/2021 09:15, Maxime Chevallier wrote:
> The Techwell video decoder supports PAL, NTSC and SECAM input formats,
> and outputs a BT.656 signal.
>
> This commit adds support for this device, with basic support for NTSC
> and PAL, along with brightn
On 22/02/2021 20:09, Mirela Rabulea wrote:
> Hi Hans,
> appologies for my late response, please see below 2 comments.
Replies below:
>
> On Tue, 2021-01-19 at 11:31 +0100, Hans Verkuil wrote:
>> Caution: EXT Email
>>
>> On 11/01/2021 20:28, Mirela Rabulea w
On 10/02/2021 13:29, Vladimir Lypak wrote:
> Because of u32 type being used to store pixel clock rate, expression used
> to calculate pipeline clocks (pixel_clock * bpp) produces wrong value due
> to integer overflow. This patch changes data type used to store, pass and
> retrieve pixel_clock from
Hi Ezequiel,
This series looks very good. There is just one define that needs a V4L2_ prefix:
On 02/03/2021 21:54, Ezequiel Garcia wrote:
> Until now, the VP8 V4L2 API was not exported as a public API,
> and only defined in a private media header (media/vp8-ctrls.h).
>
> The reason for this was
On 01/03/2021 14:47, Mauro Carvalho Chehab wrote:
> Em Mon, 1 Mar 2021 13:27:39 +0100
> Hans Verkuil escreveu:
>
>> Hi Mauro,
>>
>
> Thanks for your review. I'm addressing the points on a v5.
>
> Yet, there's one that, IMHO, we should elaborate more,
On 01/03/2021 13:42, Mauro Carvalho Chehab wrote:
> Em Mon, 1 Mar 2021 12:31:34 +0200
> Sakari Ailus escreveu:
>
>>> +Sensor drivers:
>>> + Sakari Ailus
>>
>> Could you add me:
>>
>> v4l2-async, v4l2-fwnode, v4l2-flash-led-class.
>
> Adding in v5:
>
> v4l2-async, v4l2-fwnode, v4l2-fla
edia subsystem, we have a group of experienced developers that
> +are responsible for doing the code reviews at the drivers (called
> +sub-maintainers), and another senior developer responsible for the
> +subsystem as a hole. For core changes, whenever possible, multiple
hole -> whole
timecode field is gone, since there doesn't seem to be
> in-kernel users. We can be added back in the reserved area if needed or
> use the Request API to collect more metadata information from the
> frame.
>
> Signed-off-by: Hans Verkuil
> Signed-off-by: Boris Brezillon
>
Hi Helen,
On 14/01/2021 19:07, Helen Koike wrote:
> This is part of the multiplanar and singleplanar unification process.
> v4l2_ext_pix_format is supposed to work for both cases.
>
> We also add the concept of modifiers already employed in DRM to expose
> HW-specific formats (like tiled or compr
On 10/02/2021 17:03, Nicolas Dufresne wrote:
> Le jeudi 04 février 2021 à 11:05 +0100, Hans Verkuil a écrit :
>> On 04/02/2021 06:01, diksh...@codeaurora.org wrote:
>>> On 2021-02-01 16:50, Hans Verkuil wrote:
>>>> On 25/01/2021 06:51, Dikshita Agarwal wrote:
>>
On 17/02/2021 19:11, Helen Koike wrote:
> The script was trying to load vivid and run some commands on top of it
> even when $vivid = 0.
> Wrap all vivid code under $vivid variable.
>
> Signed-off-by: Helen Koike
> ---
> contrib/test/test-media | 66 -
> 1
On 17/02/2021 09:36, Greg KH wrote:
> On Wed, Feb 17, 2021 at 09:28:09AM +0100, Benjamin Gaignard wrote:
>>
>> Le 17/02/2021 à 09:08, Greg KH a écrit :
>>> On Wed, Feb 17, 2021 at 09:02:48AM +0100, Benjamin Gaignard wrote:
The IMX8MQ got two VPUs but until now only G1 has been enabled.
Th
On 16/02/2021 09:56, Stanimir Varbanov wrote:
>
>
> On 2/15/21 1:57 PM, Hans Verkuil wrote:
>> On 15/02/2021 12:32, Stanimir Varbanov wrote:
>>>
>>>
>>> On 2/9/21 1:05 PM, Hans Verkuil wrote:
>>>> On 09/02/2021 10:45, Stanimir Varbanov wrot
On 15/02/2021 12:32, Stanimir Varbanov wrote:
>
>
> On 2/9/21 1:05 PM, Hans Verkuil wrote:
>> On 09/02/2021 10:45, Stanimir Varbanov wrote:
>>> Add decoder v4l2 control to set conceal color.
>>>
>>> Signed-off-by: Stanimir Varbanov
>>> ---
>
On 09/02/2021 14:02, Greg Kroah-Hartman wrote:
> On Tue, Feb 09, 2021 at 01:45:35PM +0100, Dafna Hirschfeld wrote:
>>
>>
>> Am 08.02.21 um 21:46 schrieb Hans Verkuil:
>>> On 08/02/2021 18:57, Sasha Levin wrote:
>>>> From: Daf
On 09/02/2021 10:45, Stanimir Varbanov wrote:
> Add decoder v4l2 control to set conceal color.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../media/v4l/ext-ctrls-codec.rst | 20 +++
> drivers/media/v4l2-core/v4l2-ctrls.c | 9 +
> include/uapi/linux
ld
> Acked-by: Helen Koike
> Signed-off-by: Hans Verkuil
> Signed-off-by: Mauro Carvalho Chehab
> Signed-off-by: Sasha Levin
> ---
> drivers/staging/media/rkisp1/uapi/rkisp1-config.h | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/
On 08/02/2021 12:28, Laurent Pinchart wrote:
> Hi Hans,
>
> On Mon, Feb 08, 2021 at 12:21:01PM +0100, Hans Verkuil wrote:
>> On 14/01/2021 18:04, Jacopo Mondi wrote:
>>> The RDACM21 is a GMSL camera supporting 1280x1080 resolution images
>>> developed by IMI base
Hi Jacopo,
On 14/01/2021 18:04, Jacopo Mondi wrote:
> The RDACM21 is a GMSL camera supporting 1280x1080 resolution images
> developed by IMI based on an Omnivision OV10640 sensor, an Omnivision
> OV490 ISP and a Maxim MAX9271 GMSL serializer.
>
> The driver uses the max9271 library module, to max
Hi Jacopo,
On 14/01/2021 18:04, Jacopo Mondi wrote:
> The RDACM21 is a GMSL camera supporting 1280x1080 resolution images
> developed by IMI based on an Omnivision OV10640 sensor, an Omnivision
> OV490 ISP and a Maxim MAX9271 GMSL serializer.
>
> The driver uses the max9271 library module, to max
On 06/02/2021 10:48, Mauro Carvalho Chehab wrote:
> Em Sat, 6 Feb 2021 10:29:10 +0100
> Greg Kroah-Hartman escreveu:
>
>> On Sat, Feb 06, 2021 at 10:24:02AM +0100, Mauro Carvalho Chehab wrote:
>>> Em Sat, 6 Feb 2021 08:20:45 +0100
>>> Greg Kroah-Hartman escreveu:
>>>
On Fri, Feb 05, 2021
On 05/02/2021 14:24, Ville Syrjälä wrote:
> On Fri, Feb 05, 2021 at 04:17:51PM +1100, Sam McNally wrote:
>> On Thu, 4 Feb 2021 at 21:19, Hans Verkuil wrote:
>>>
>>> On 01/02/2021 23:13, Ville Syrjälä wrote:
>>>> On Wed, Sep 23, 2020 at 12:13:53PM +1000, Sam
On 05/02/2021 14:53, Andrew Lunn wrote:
> On Fri, Feb 05, 2021 at 02:42:23PM +0100, Takashi Iwai wrote:
>> On Fri, 05 Feb 2021 14:13:02 +0100,
>> Andrew Lunn wrote:
>>>
>>> Hi Takashi
>>>
Indeed, looks so. In most cases, this doesn't matter since both point
to the same device object. In
Hi Takashi,
Thank you for this patch, but it clashes with another patch trying to do the
same thing
that has already been merged in our tree:
https://patchwork.linuxtv.org/project/linux-media/patch/20210104170007.20625-1-mat...@sai.msu.ru/
I do prefer your patch over the one already merged sinc
he right approach for the other
> two though.
>
> On Wed, 3 Feb 2021 at 20:57, Hans Verkuil <mailto:hverk...@xs4all.nl>> wrote:
>
> Hi Sam,
>
> Are you able to work on a v4?
>
> I haven't heard from you for some time now. I would be willing t
ll MST connectors, ensuring their
> drm_dp_aux_cec struct won't be accessed uninitialized.
>
> Reviewed-by: Hans Verkuil
> Signed-off-by: Sam McNally
> ---
>
> Changes in v3:
> - Fixed whitespace in drm_dp_cec_mst_irq_work()
> - Moved drm_dp_cec_mst_set_edid_work()
On 01/02/2021 23:13, Ville Syrjälä wrote:
> On Wed, Sep 23, 2020 at 12:13:53PM +1000, Sam McNally wrote:
>> From: Hans Verkuil
>>
>> For adapters behind an MST hub use the correct AUX channel.
>>
>> Signed-off-by: Hans Verkuil
>> [sa...@chromium.o
On 04/02/2021 06:01, diksh...@codeaurora.org wrote:
> On 2021-02-01 16:50, Hans Verkuil wrote:
>> On 25/01/2021 06:51, Dikshita Agarwal wrote:
>>> Long Term Reference (LTR) frames are the frames that are encoded
>>> sometime in the past and stored in the DPB buffer list
Hi Sam,
Are you able to work on a v4?
I haven't heard from you for some time now. I would be willing to take over
this series if it wasn't for the fact that I do not have any hardware to test
this with.
Regards,
Hans
On 01/02/2021 22:56, Lyude Paul wrote:
> On Wed, 2020-09-23 at 12:13
On 25/01/2021 06:51, Dikshita Agarwal wrote:
> Long Term Reference (LTR) frames are the frames that are encoded
> sometime in the past and stored in the DPB buffer list to be used
> as reference to encode future frames.
> This change adds controls to enable this feature.
>
> Signed-off-by: Dikshit
On 25/01/2021 06:51, Dikshita Agarwal wrote:
> Long Term Reference (LTR) frames are the frames that are encoded
> sometime in the past and stored in the DPB buffer list to be used
> as reference to encode future frames.
> This change adds controls to enable this feature.
>
> Signed-off-by: Dikshit
patch).
Regards,
Hans
On 12/01/2021 10:24, Hans Verkuil wrote:
> Hi Sam,
>
> This series still hasn't been merged. It still applies cleanly to v5.11-rc1.
>
> Daniel, can you merge this series for 5.12? Or Ack this series so I can merge
> it?
>
> The first thre
Hi Daniel,
On 05/01/2021 14:17, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida"
>
> Add support for vidtv at the test-media script so that automated testing
> is possible. Proper compliance tests are still pending.
I've tried this, but something is wrong: 'media-ctl -p' shows an empt
On 18/01/2021 14:55, Hans Verkuil wrote:
> On 12/01/2021 16:24, Hans Verkuil wrote:
>> Hi Maxime,
>>
>> On 11/01/2021 15:22, Maxime Ripard wrote:
>>> Hi,
>>>
>>> Here's a series introducing the CEC support for the BCM2711 found on the
>>
or any codec.
>
> Signed-off-by: Stanimir Varbanov
Acked-by: Hans Verkuil
Thanks!
Hans
> ---
> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 15 +++
> drivers/media/v4l2-core/v4l2-ctrls.c | 4
> include/uapi/linux/v4l2-controls.h
On 15/01/2021 10:26, Stanimir Varbanov wrote:
> Deprecate mfc private display delay and display enable controls for
> new clients and use the standard controls instead.
>
> Signed-off-by: Stanimir Varbanov
Acked-by: Hans Verkuil
Thanks!
Hans
> ---
> .../userspace
Hi Maxime,
Note: typo in subject: Rockhip -> Rockchip
Review comments below:
On 29/12/2020 17:17, Maxime Chevallier wrote:
> Introduce a driver for the camera interface on some Rockchip platforms.
>
> This controller supports CSI2 and BT656 interfaces, but for
> now only the BT656 interface cou
dtv_bridge.c | 32 +--
> .../media/test-drivers/vidtv/vidtv_bridge.h | 7
> 2 files changed, 36 insertions(+), 3 deletions(-)
>
For this series:
Acked-by: Hans Verkuil
Mauro, it would be very nice to merge this. It will make it possible
to add vidtv to the test-media script for regression testing.
Regards,
Hans
On 19/01/2021 10:39, Wolfram Sang wrote:
> The version here is identical to the one in the I2C core, so use the
> latter version directly.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Hans Verkuil
Looks good to me!
Hans
> ---
>
> Changes since RFC:
On 22/01/2021 10:24, Uwe Kleine-König wrote:
> Instead of an unconditional return 0, return no value. One of the two
> callers ignored the return value already before.
>
> This simplifies the next patch.
>
> Signed-off-by: Uwe Kleine-König
Reviewed-by: Hans Verkuil
Tha
On 19/01/2021 10:39, Wolfram Sang wrote:
> The open coded version differs from the one in the core in one way: the
> buffer will be always copied back, even when the transfer failed. Be
> more robust: use the block read from the I2C core and propagate a
> potential errno further to the sanity check
On 20/01/2021 10:26, Stanimir Varbanov wrote:
> Document Content Light Level and Mastering Display v4l2 colorimetry
> controls.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../media/v4l/ext-ctrls-colorimetry.rst | 71 +++
> .../media/videodev2.h.rst.exceptions |
On 25/01/2021 15:51, AngeloGioacchino Del Regno wrote:
> Il 25/01/21 11:40, Hans Verkuil ha scritto:
>> On 18/01/2021 18:45, AngeloGioacchino Del Regno wrote:
>>> Il 18/01/21 18:21, Stanimir Varbanov ha scritto:
>>>> Hi Angelo,
>>>>
>>>&
On 20/01/2021 10:26, Stanimir Varbanov wrote:
> Add a document for ext control colorimetry class.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../userspace-api/media/v4l/common.rst| 1 +
> .../media/v4l/ext-ctrls-colorimetry.rst | 19 +++
> .../media/v4l/vidioc-g-
>
> Acked-by: Marc Kleine-Budde # for
> drivers/net/can/sja1000/tscan1.c
> Acked-by: William Breathitt Gray
> Acked-by: Wolfram Sang # for drivers/i2c/
> Reviewed-by: Takashi Iway # for sound/
> Signed-off-by: Uwe Kleine-König
For the media/radio drivers:
Reviewed
On 14/01/2021 19:01, Helen Koike wrote:
> sizeimage field should be set to zero for unused planes, even when
> v4l2_pix_format_mplane.num_planes is smaller then the index of planes.
then -> than
>
> Signed-off-by: Helen Koike
>
> ---
>
> I caught this with v4l2-compliance, which throws an err
On 19/01/2021 02:09, chiguoqing wrote:
> Repeated references string.h
>
> Signed-off-by: Wen Zhang
checkpatch gives me:
ERROR: Missing Signed-off-by: line by nominal patch author 'chiguoqing
'
Can you fix this?
Regards,
Hans
> ---
> drivers/media/test-drivers/vidtv/vidtv_psi.c | 1
On 18/01/2021 18:45, AngeloGioacchino Del Regno wrote:
> Il 18/01/21 18:21, Stanimir Varbanov ha scritto:
>> Hi Angelo,
>>
>> Thanks for the patch!
>>
>> On 1/15/21 8:52 PM, AngeloGioacchino Del Regno wrote:
>>> Add the SDM660 DT compatible and its resource structure, also
>>> including support for
On 20/01/2021 10:26, Stanimir Varbanov wrote:
> Add Colorimetry control class for colorimetry controls
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 5 +
> include/uapi/linux/v4l2-controls.h | 4
> 2 files changed, 9 insertions(+)
>
> diff --git
On 12/01/2021 12:07, Kieran Bingham wrote:
> Hi Ricardo,
>
> On 11/01/2021 14:54, Ricardo Ribalda wrote:
>> Core code already clears reserved fields of struct
>> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
>> v4l2_plane_pix_format reserved fields").
>>
>> Cc: Mikhail Ulya
ffects
> the zerocopy userptr usage enabled in 50ac952d2263 ("[media]
> videobuf2-dma-sg: Support io userptr operations on io memory").
>
> Acked-by: Tomasz Figa
Acked-by: Hans Verkuil
Regards,
Hans
> Signed-off-by: Daniel Vetter
> Cc: Jason Gunthorpe
On 11/01/2021 20:28, Mirela Rabulea wrote:
> From: Mirela Rabulea
>
> V4L2 driver for the JPEG encoder/decoder from i.MX8QXP/i.MX8QM application
> processors.
> The multi-planar buffers API is used.
>
> Baseline and extended sequential jpeg decoding is supported.
> Progressive jpeg decoding is n
On 12/01/2021 16:24, Hans Verkuil wrote:
> Hi Maxime,
>
> On 11/01/2021 15:22, Maxime Ripard wrote:
>> Hi,
>>
>> Here's a series introducing the CEC support for the BCM2711 found on the
>> RaspberryPi4.
>>
>> The BCM2711 HDMI controller uses a
On 12/01/2021 17:41, Wolfram Sang wrote:
> The version here is identical to the one in the I2C core, so use a
> define to keep the original name within the driver but call the I2C core
> function instead.
>
> Signed-off-by: Wolfram Sang
> ---
> drivers/media/i2c/adv7842.c | 14 +-
>
Hi Wolfram,
On 12/01/2021 17:41, Wolfram Sang wrote:
> The open coded version differs from the one in the core in one way: the
> buffer will be always copied back, even when the transfer failed. It
> looks like it is expected that the sanity check for a correct CRC and
> header will bail out later
Hi Dikshita,
On 04/01/2021 06:41, Dikshita Agarwal wrote:
> This series adds base layer priority id control for encoder
> and support for the same in venus driver.
Posted a pull request for this series and the "Add new controls for QP and
layer bitrate" series.
Note that because the "Add encoder
_device *v4l2_dev)
> +{
> + struct zr364xx_camera *cam =
> + container_of(v4l2_dev, struct zr364xx_camera, v4l2_dev);
> +
> + videobuf_mmap_free(&cam->vb_vidq);
> + video_unregister_device(&cam->vdev);
video_unregister_device() is calle
Hi Maxime,
On 11/01/2021 15:22, Maxime Ripard wrote:
> Hi,
>
> Here's a series introducing the CEC support for the BCM2711 found on the
> RaspberryPi4.
>
> The BCM2711 HDMI controller uses a similar layout for the CEC registers, the
> main difference being that the interrupt handling part is now
On 08/12/2020 15:59, Stanimir Varbanov wrote:
> Document Content light level and Mastering display colour volume.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../userspace-api/media/v4l/common.rst| 1 +
> .../media/v4l/ext-ctrls-colorimetry.rst | 88 +++
> 2 files
On 08/12/2020 15:59, Stanimir Varbanov wrote:
> Here we introduce a new Colorimetry control class and add
> Content light level and Mastering display colour volume v4l2
> compound controls, relevant payload structures and validation.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../media/videode
On 06/12/2020 11:27, Stanimir Varbanov wrote:
> Add a control to enable inserting of AUD NALU into encoded
> bitstream.
>
> Signed-off-by: Stanimir Varbanov
Reviewed-by: Hans Verkuil
Looks good!
Hans
> ---
> Documentation/userspace-api/media/v4l/ext-c
On 06/12/2020 11:27, Stanimir Varbanov wrote:
> Add a control to set intra-refresh period.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 11 +++
> drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
> include/uapi/linux/v4
Hi Sam,
This series still hasn't been merged. It still applies cleanly to v5.11-rc1.
Daniel, can you merge this series for 5.12? Or Ack this series so I can merge
it?
The first three patches deal with DP MST support, and this needs review from
you or David.
Regards,
Hans
On 23/09/202
On 04/01/2021 06:09, Dikshita Agarwal wrote:
> Add support for below LTR controls in encoder:
> - V4L2_CID_MPEG_VIDEO_LTR_COUNT
> - V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
> - V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
This patch does not add any Request API support to the venus driver,
so it makes no sense t
On 04/01/2021 06:09, Dikshita Agarwal wrote:
> Long Term Reference (LTR) frames are the frames that are encoded
> sometime in the past and stored in the DPB buffer list to be used
> as reference to encode future frames.
> This change adds controls to enable this feature.
>
> Signed-off-by: Dikshit
On 05/01/2021 08:59, Dinghao Liu wrote:
> When videobuf_waiton() fails, we should execute clean
> functions to prevent memleak. It's the same when
> __videobuf_copy_to_user() fails.
>
> Fixes: 7a7d9a89d0307 ("V4L/DVB (6251): Replace video-buf to a more generic
> approach")
> Signed-off-by: Dingha
On 08/12/2020 16:55, Adrian Ratiu wrote:
> Some configurations built by the ktest bot produce the following
> warn, so mark the struct as __maybe_unused to avoid unnecessary
> ML spam.
>
>>> drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable
>>> 'of_rkvdec_match' [-Wunused-con
: Add multi-planar ioctl handling code")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 31 +---
> 1 file changed, 14 insertions(+), 17 deletions
On 17/12/2020 11:49, Maxime Ripard wrote:
> Hi Hans,
>
> On Wed, Dec 16, 2020 at 01:35:43PM +0100, Hans Verkuil wrote:
>> Hi Maxime,
>>
>> On 10/12/2020 14:46, Maxime Ripard wrote:
>>> Hi,
>>>
>>> Here's a series introducing th
Hi Rob,
You can add my
Acked-by: Hans Verkuil
to these two patches.
Regards,
Hans
On 10/12/2020 22:16, Rob Herring wrote:
> This series converts video-interfaces.txt to DT schema which in turn is
> based on converting the graph binding to a schema. All the media users
Hi Maxime,
On 10/12/2020 14:46, Maxime Ripard wrote:
> Hi,
>
> Here's a series introducing the CEC support for the BCM2711 found on the
> RaspberryPi4.
>
> The BCM2711 HDMI controller uses a similar layout for the CEC registers, the
> main difference being that the interrupt handling part is now
On 08/12/2020 17:44, diksh...@codeaurora.org wrote:
> Hi Hans,
>
> On 2020-12-02 19:18, Hans Verkuil wrote:
>> On 01/12/2020 09:13, Dikshita Agarwal wrote:
>>> Long Term Reference (LTR) frames are the frames that are encoded
>>> sometime in the past and stored
101 - 200 of 1001 matches
Mail list logo
