Re: [RFC PATCH v2] media: cec: expose HDMI connector to CEC dev mapping

2019-05-09 Thread Hans Verkuil
On 5/9/19 9:52 AM, Dariusz Marcinkiewicz wrote: > Hi Hans. > > On Wed, Apr 24, 2019 at 2:09 PM Hans Verkuil wrote: >> >> Hi Dariusz, >> >> This is getting close, so I think for the next version you can drop >> the RFC tag. >> >> Some comments:

Re: [PATCH v4] media: docs-rst: Document m2m stateless video decoder interface

2019-04-29 Thread Hans Verkuil
On 4/27/19 2:06 PM, Nicolas Dufresne wrote: > Le vendredi 26 avril 2019 à 16:18 +0200, Hans Verkuil a écrit : >> On 4/16/19 9:22 AM, Alexandre Courbot wrote: >> >> >> >>> Thanks for this great discussion. Let me try to summarize the status >>> of th

Re: KASAN: use-after-free Read in dvb_usb_device_exit

2019-04-24 Thread Hans Verkuil
On 4/15/19 1:12 PM, Oliver Neukum wrote: > On Fr, 2019-04-12 at 04:46 -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:9a33b369 usb-fuzzer: main usb gadget fuzzer driver >> git tree: https://github.com/google/kasan/tree/usb-fuzzer >> console outp

Re: [PATCH 1/3] media: atmel: atmel-isc: limit incoming pixels per frame

2019-04-12 Thread Hans Verkuil
On 4/12/19 12:19 PM, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > This will limit the incoming pixels per frame from the sensor. > Currently, the ISC will stop sampling the frame only when the vsync/hsync > are detected. > If we misconfigure the resolution in the sensor w.r.t. res

Re: [PATCH v9 1/4] cx25840: add pin to pad mapping and output format configuration

2019-04-12 Thread Hans Verkuil
Hi Maciej, Yes, I know, I have been ignoring this patch series for too long, mostly because reviewing this is time consuming and because it is so easy to break existing functionality. But I finally have some time to do a review and I do think it is close to being ready for merging. Some comments

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-04-05 Thread Hans Verkuil
On 4/5/19 7:53 AM, Tomasz Figa wrote: > On Tue, Jan 29, 2019 at 10:53 PM Hans Verkuil wrote: >> >> Hi Tomasz, >> >> Some comments below. Nothing major, so I think a v4 should be ready to be >> merged. >> >> On 1/24/19 11:04 AM, Tomasz Figa wrote

Re: [PATCH 1/3] media: dt-bindings: media: meson-ao-cec: Add G12A AO-CEC-B Compatible

2019-03-27 Thread Hans Verkuil
On 3/25/19 6:34 PM, Neil Armstrong wrote: > The Amlogic G12A embeds a second CEC controller named AO-CEC-B, and > the other one is AO-CEC-A described by the current bindings. > > The registers interface is very close but the internal architecture registers -> register > is totally different. >

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-03-25 Thread Hans Verkuil
Another comment found while creating compliance tests: On 1/24/19 11:04 AM, Tomasz Figa wrote: > +Drain > += > + > +To ensure that all the queued ``OUTPUT`` buffers have been processed and the > +related ``CAPTURE`` buffers are given to the client, the client must follow > the > +drain sequen

Re: [PATCH 8/8] media: vimc: propagate pixel format in the stream

2019-03-08 Thread Hans Verkuil
Hi Helen, On 3/6/19 11:42 PM, Helen Koike wrote: > Media bus codes were being mapped to pixelformats, which causes a > limitation on vimc because not all pixelformats can be mapped to media > bus codes. > Also, media bus codes are an internal configuration from the device. > Userspace only assures

Re: [PATCH] media: uvcvideo: Read support

2019-03-04 Thread Hans Verkuil
On 3/4/19 1:35 PM, Hugues Fruchet wrote: > Add support of read() call from userspace by implementing > uvc_v4l2_read() with vb2_read() helper. > > Signed-off-by: Hugues Fruchet > --- > drivers/media/usb/uvc/uvc_queue.c | 15 ++- > drivers/media/usb/uvc/uvc_v4l2.c | 11 --- >

Re: [PATCH] media: uvcvideo: Read support

2019-03-04 Thread Hans Verkuil
On 3/4/19 1:35 PM, Hugues Fruchet wrote: > Add support of read() call from userspace by implementing > uvc_v4l2_read() with vb2_read() helper. > > Signed-off-by: Hugues Fruchet > --- > drivers/media/usb/uvc/uvc_queue.c | 15 ++- > drivers/media/usb/uvc/uvc_v4l2.c | 11 --- >

Re: [PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2019-02-28 Thread Hans Verkuil
On 2/26/19 4:33 AM, Alexandre Courbot wrote: > Hi, sorry for the delayed reply! > > On Wed, Feb 13, 2019 at 8:04 PM Paul Kocialkowski > wrote: >> >> Hi, >> >> On Wed, 2019-02-13 at 10:57 +0100, Hans Verkuil wrote: >>> On 2/13/19 10:20 AM, Paul Kocial

Re: [Intel-gfx] BUG: KASAN: use-after-free in intel_hdmi_destroy+0x79/0x80

2019-02-25 Thread Hans Verkuil
Hi Jani, On 2/25/19 2:40 PM, Jani Nikula wrote: On Fri, 22 Feb 2019, Randy Dunlap wrote: This is 5.0-rc7 on an old Toshiba Portege laptop. No hdmi or other external video. Linux dragon.dunlab 5.0.0-rc7mod #3 SMP PREEMPT Wed Feb 20 00:05:17 PST 2019 x86_64 x86_64 x86_64 GNU/Linux on openSUSE

Re: [PATCH 2/3] media: vicodec: avoic clang frame size warning

2019-02-19 Thread Hans Verkuil
On 2/19/19 6:01 PM, Arnd Bergmann wrote: > Clang-9 makes some different inlining decisions compared to gcc, which > leads to a warning about a possible stack overflow problem when building > with CONFIG_KASAN, including when setting asan-stack=0, which avoids > most other frame overflow warnings: >

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Hans Verkuil
On 2/15/19 5:27 PM, Nicolas Dufresne wrote: > Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : >> Hi Stanimir, >> >> I never paid much attention to this patch series since others were busy >> discussing it and I had a lot of other things on my plate, bu

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Hans Verkuil
ec as well (clearly I never realized that at the time). So, just to make it unambiguous: Nacked-by: Hans Verkuil Now, I plan to work on adding stateful codec checks to v4l2-compliance. I had hoped to do some of that already, but didn't manage to find time this week. I hope to have somethin

Re: [PATCH] media: cedrus: Forbid setting new formats on busy queues

2019-02-14 Thread Hans Verkuil
On 2/14/19 10:18 AM, Paul Kocialkowski wrote: > Hi, > > On Thu, 2019-02-14 at 09:59 +0100, Hans Verkuil wrote: >> On 2/14/19 9:37 AM, Paul Kocialkowski wrote: >>> Check that our queues are not busy before setting the format or return >>> EBUSY if that's

Re: [PATCH] media: cedrus: Forbid setting new formats on busy queues

2019-02-14 Thread Hans Verkuil
On 2/14/19 9:37 AM, Paul Kocialkowski wrote: > Check that our queues are not busy before setting the format or return > EBUSY if that's the case. This ensures that our format can't change > once buffers are allocated for the queue. > > Signed-off-by: Paul Kocialkowski > --- > drivers/staging/med

Re: [RESEND PATCH v4,1/3] media: dt-bindings: media: add 'assigned-clocks' to vcodec examples

2019-02-13 Thread Hans Verkuil
Hi Yunfei Dong, Why is this series resent? Patches 1 and 3 have been merged in our media master tree already. Regards, Hans On 2/14/19 3:24 AM, Yunfei Dong wrote: > Fix MTK binding document for MT8173 dtsi changed in order > to use standard CCF interface. > MT8173 SoC from Mediatek. >

Re: [PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2019-02-13 Thread Hans Verkuil
On 2/13/19 10:20 AM, Paul Kocialkowski wrote: > Hi, > > On Wed, 2019-02-13 at 09:59 +0100, Hans Verkuil wrote: >> On 2/13/19 6:58 AM, Alexandre Courbot wrote: >>> On Wed, Feb 13, 2019 at 2:53 PM Alexandre Courbot >>> wrote: >>>> [snip] >>>

Re: [PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2019-02-13 Thread Hans Verkuil
On 2/13/19 6:58 AM, Alexandre Courbot wrote: > On Wed, Feb 13, 2019 at 2:53 PM Alexandre Courbot > wrote: >> [snip] >> +Buffers used as reference frames can be queued back to the ``CAPTURE`` >> queue as >> +soon as all the frames they are affecting have been queued to the ``OUTPUT`` >> +queue. T

Re: 答复: [PATCH 1/4] media: cec-notifier: fix possible object reference leak

2019-02-12 Thread Hans Verkuil (hansverk)
> Regards, > > Wen > > ________ > 发件人: Hans Verkuil (hansverk) > 发送时间: 2019年2月11日 10:57 > 收件人: Wen Yang; Hans Verkuil; Mauro Carvalho Chehab > 抄送: Linux Media Mailing List; LKML > 主题: Re: [PATCH 1/4] media: cec-notifier: fix possible obj

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Hans Verkuil
On 2/11/19 4:16 PM, Hans Verkuil wrote: > Hi Maxime, > > A quick review below. Note that I am no expert on the codec details, so > I leave that to others. I'm mainly concentrating on the structs, flags, etc. > > On 2/11/19 3:39 PM, Maxime Ripard wrote: >> From:

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Hans Verkuil
Hi Maxime, A quick review below. Note that I am no expert on the codec details, so I leave that to others. I'm mainly concentrating on the structs, flags, etc. On 2/11/19 3:39 PM, Maxime Ripard wrote: > From: Pawel Osciak > > Stateless video codecs will require both the H264 metadata and slices

Re: [PATCH 1/4] media: cec-notifier: fix possible object reference leak

2019-02-11 Thread Hans Verkuil (hansverk)
On 11/02/2019 11:38, Hans Verkuil (hansverk) wrote: > On 09/02/2019 03:48, Wen Yang wrote: >> put_device() should be called in cec_notifier_release(), >> since the dev is being passed down to cec_notifier_get_conn(), >> which holds reference. On cec_notifier destruction,

Re: [PATCH 4/4] media: tegra-cec: fix possible object reference leak

2019-02-11 Thread Hans Verkuil (hansverk)
On 09/02/2019 03:55, Wen Yang wrote: > The call to of_parse_phandle() returns a node pointer with refcount > incremented thus it must be explicitly decremented here after the last > usage. > The of_find_device_by_node() takes a reference to the underlying device > structure, we also should release

Re: [PATCH 1/4] media: cec-notifier: fix possible object reference leak

2019-02-11 Thread Hans Verkuil (hansverk)
On 09/02/2019 03:48, Wen Yang wrote: > put_device() should be called in cec_notifier_release(), > since the dev is being passed down to cec_notifier_get_conn(), > which holds reference. On cec_notifier destruction, it > should drop the reference to the device. > > Fixes: 6917a7b77413 ("[media] med

Re: [PATCH v3] [media] v4l: add I / P frame min max QP definitions

2019-02-08 Thread Hans Verkuil
On 1/30/19 10:11 AM, Fish Lin wrote: > Add following V4L2 QP parameters for H.264: > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP > * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP > > These controls will limit QP ra

Re: [PATCH v5] media: vimc: Add vimc-streamer for stream control

2019-02-07 Thread Hans Verkuil
Hi Lucas, On 2/7/19 9:48 PM, Lucas A. M. Magalhaes wrote: > Add a linear pipeline logic for the stream control. It's created by > walking backwards on the entity graph. When the stream starts it will > simply loop through the pipeline calling the respective process_frame > function of each entity.

Re: [PATCH v4] media: vimc: Add vimc-streamer for stream control

2019-02-07 Thread Hans Verkuil
Hi Lucas, On 1/22/19 2:05 AM, Lucas A. M. Magalhaes wrote: > Add a linear pipeline logic for the stream control. It's created by > walking backwards on the entity graph. When the stream starts it will > simply loop through the pipeline calling the respective process_frame > function of each entity

Re: [PATCH v10 0/4] Media Device Allocator API

2019-02-05 Thread Hans Verkuil
On 2/5/19 7:10 PM, shuah wrote: > On 2/1/19 2:21 AM, Hans Verkuil wrote: >> On 2/1/19 1:46 AM, shuah wrote: >>> Hi Hans, >>> >>> On 1/30/19 12:42 AM, Hans Verkuil wrote: >>>> On 1/30/19 2:50 AM, shuah wrote: >>>>> On 1/29/19 2:43

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-05 Thread Hans Verkuil
On 2/5/19 10:31 AM, Tomasz Figa wrote: > On Tue, Feb 5, 2019 at 6:00 PM Hans Verkuil wrote: >> >> On 2/5/19 7:26 AM, Tomasz Figa wrote: >>> On Fri, Feb 1, 2019 at 12:18 AM Nicolas Dufresne >>> wrote: >>>> >>>> Le jeudi 31 janvier 2019

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-05 Thread Hans Verkuil
On 2/5/19 7:26 AM, Tomasz Figa wrote: > On Fri, Feb 1, 2019 at 12:18 AM Nicolas Dufresne wrote: >> >> Le jeudi 31 janvier 2019 à 22:34 +0900, Tomasz Figa a écrit : >>> On Thu, Jan 31, 2019 at 9:42 PM Philipp Zabel >>> wrote: Hi Nicolas, On Wed, 2019-01-30 at 10:32 -0500, Nicolas D

Re: [PATCH][media-next] media: vb2: remove unused variable i

2019-02-01 Thread Hans Verkuil
On 02/01/2019 07:06 PM, Colin King wrote: > From: Colin Ian King > > Variable i is declared and never used. Fix this by removing it. A fix for this is already pending in a pull request. Regards, Hans > > Signed-off-by: Colin Ian King > --- > drivers/media/common/videobuf2/videobuf2

Re: [PATCH v10 0/4] Media Device Allocator API

2019-02-01 Thread Hans Verkuil
On 2/1/19 1:46 AM, shuah wrote: > Hi Hans, > > On 1/30/19 12:42 AM, Hans Verkuil wrote: >> On 1/30/19 2:50 AM, shuah wrote: >>> On 1/29/19 2:43 AM, Hans Verkuil wrote: >>>> On 1/29/19 12:48 AM, shuah wrote: >>>>> Hi Hans, >>>>

Re: [PATCH v3 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-31 Thread Hans Verkuil
On 1/31/19 1:44 PM, Philipp Zabel wrote: > On Thu, 2019-01-31 at 13:30 +0100, Hans Verkuil wrote: >> On 1/31/19 11:45 AM, Hans Verkuil wrote: >>> On 1/24/19 11:04 AM, Tomasz Figa wrote: >>>> Due to complexity of the video decoding process, the V4L2 drivers of >>

Re: [PATCH v3 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-31 Thread Hans Verkuil
On 1/31/19 1:30 PM, Hans Verkuil wrote: > On 1/31/19 11:45 AM, Hans Verkuil wrote: >> On 1/24/19 11:04 AM, Tomasz Figa wrote: >>> Due to complexity of the video decoding process, the V4L2 drivers of >>> stateful decoder hardware require specific sequences of V4L2 A

Re: [PATCH v3 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-31 Thread Hans Verkuil
On 1/31/19 11:45 AM, Hans Verkuil wrote: > On 1/24/19 11:04 AM, Tomasz Figa wrote: >> Due to complexity of the video decoding process, the V4L2 drivers of >> stateful decoder hardware require specific sequences of V4L2 API calls >> to be followed. These include c

Re: [PATCH v3 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-31 Thread Hans Verkuil
On 1/24/19 11:04 AM, Tomasz Figa wrote: > Due to complexity of the video decoding process, the V4L2 drivers of > stateful decoder hardware require specific sequences of V4L2 API calls > to be followed. These include capability enumeration, initialization, > decoding, seek, pause, dynamic resolution

Re: [PATCH v2] [media] v4l: add I / P frame min max QP definitions

2019-01-29 Thread Hans Verkuil
On 1/30/19 8:45 AM, Fish Lin wrote: > Add following V4L2 QP parameters for H.264: > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP > * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP > > These controls will limit QP ran

Re: [PATCH v10 0/4] Media Device Allocator API

2019-01-29 Thread Hans Verkuil
On 1/30/19 2:50 AM, shuah wrote: > On 1/29/19 2:43 AM, Hans Verkuil wrote: >> On 1/29/19 12:48 AM, shuah wrote: >>> Hi Hans, >>> >>> On 1/28/19 5:03 AM, Hans Verkuil wrote: >>>> Hi Shuah, >>>> >>>> On 1/24/19 9:32 PM, Shuah

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-29 Thread Hans Verkuil
Hi Tomasz, Some comments below. Nothing major, so I think a v4 should be ready to be merged. On 1/24/19 11:04 AM, Tomasz Figa wrote: > Due to complexity of the video encoding process, the V4L2 drivers of > stateful encoder hardware require specific sequences of V4L2 API calls > to be followed. Th

Re: [PATCH v3 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-29 Thread Hans Verkuil
; +- Osciak, Pawel > + > + - Documented the memory-to-memory decoder interface. > + > - Osciak, Pawel > >- Designed and documented the multi-planar API. > @@ -92,7 +100,7 @@ Authors, in alphabetical order: > >- Designed and documented the VIDIOC_LOG_STATUS

Re: [PATCH v10 0/4] Media Device Allocator API

2019-01-29 Thread Hans Verkuil
On 1/29/19 12:48 AM, shuah wrote: > Hi Hans, > > On 1/28/19 5:03 AM, Hans Verkuil wrote: >> Hi Shuah, >> >> On 1/24/19 9:32 PM, Shuah Khan wrote: >>> Media Device Allocator API to allows multiple drivers share a media device. >>> This API solves a ver

Re: devicetree: media: Documentation of Bt.656 Bus DT bindings

2019-01-28 Thread Hans Verkuil
+Sakari On 1/24/19 3:53 AM, Ken Sloat wrote: > There are a number of v4l2 subdevices in the kernel that support a > Bt.656 bus also known as "embedded sync." Previously in older versions > of the kernel (and in the current 4.14 LTS kernel), the standard way > to enable this in device tree on a par

Re: [PATCH v10 0/4] Media Device Allocator API

2019-01-28 Thread Hans Verkuil
d struct > device as the key. Once the media device is allocated by a driver, other > drivers can get a reference to it. The media device is released when all > the references are released. > > - This patch series is tested on 5.0-rc3 and addresses comments on > v9 series from H

Re: [PATCH v3 0/2] Document memory-to-memory video codec interfaces

2019-01-24 Thread Hans Verkuil
On 01/24/19 11:04, Tomasz Figa wrote: > Late happy new year everyone. It's been a while, but here is the v3 of > the stateful mem2mem codec interfaces documentation. Sorry for taking so > long time to respin. (Again.) > > This series attempts to add the documentation of what was discussed > during

Re: [PATCH v9 0/4] Media Device Allocator API

2019-01-23 Thread Hans Verkuil
On 1/24/19 2:35 AM, shuah wrote: > On 1/21/19 7:46 AM, Hans Verkuil wrote: >> Hi Shuah, >> >> On 12/18/2018 06:59 PM, sh...@kernel.org wrote: >>> From: Shuah Khan >>> >>> Media Device Allocator API to allows multiple drivers share a media device

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-23 Thread Hans Verkuil
On 01/23/19 10:52, Tomasz Figa wrote: > On Mon, Nov 12, 2018 at 10:23 PM Hans Verkuil wrote: >> >> On 10/22/2018 04:49 PM, Tomasz Figa wrote: >>> Due to complexity of the video encoding process, the V4L2 drivers of >>> stateful encoder hardware require specific s

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-23 Thread Hans Verkuil
On 01/23/19 11:00, Tomasz Figa wrote: > On Sat, Nov 17, 2018 at 8:37 PM Hans Verkuil wrote: >> >> On 11/17/2018 05:18 AM, Nicolas Dufresne wrote: >>> Le lundi 12 novembre 2018 à 14:23 +0100, Hans Verkuil a écrit : >>>> On 10/22/2018 04:49 PM, Tomasz Figa wro

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-23 Thread Hans Verkuil
On 01/23/2019 06:27 AM, Tomasz Figa wrote: > On Tue, Jan 22, 2019 at 11:47 PM Hans Verkuil wrote: >> >> On 01/22/19 11:02, Tomasz Figa wrote: >>> On Mon, Nov 12, 2018 at 8:37 PM Hans Verkuil wrote: >>>> >>>> Hi Tomasz, >>>> >

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-22 Thread Hans Verkuil
On 01/22/19 11:02, Tomasz Figa wrote: > On Mon, Nov 12, 2018 at 8:37 PM Hans Verkuil wrote: >> >> Hi Tomasz, >> >> A general note for the stateful and stateless patches: they describe specific >> use-cases of the more generic Codec Interface, and as such sho

Re: [PATCH v2] media: docs-rst: Document m2m stateless video decoder interface

2019-01-22 Thread Hans Verkuil
On 01/22/2019 07:26 AM, Alexandre Courbot wrote: > Documents the protocol that user-space should follow when > communicating with stateless video decoders. > > The stateless video decoding API makes use of the new request and tags > APIs. While it has been implemented with the Cedrus driver so far

Re: [PATCH v9 0/4] Media Device Allocator API

2019-01-21 Thread Hans Verkuil
Hi Shuah, On 12/18/2018 06:59 PM, sh...@kernel.org wrote: > From: Shuah Khan > > Media Device Allocator API to allows multiple drivers share a media device. > This API solves a very common use-case for media devices where one physical > device (an USB stick) provides both audio and video. When s

Re: [PATCH v9 4/4] sound/usb: Use Media Controller API to share media resources

2019-01-19 Thread Hans Verkuil
On 01/19/2019 02:03 AM, shuah wrote: > On 1/18/19 2:54 PM, shuah wrote: >> On 1/18/19 1:36 AM, Hans Verkuil wrote: >>> On 12/18/18 6:59 PM, sh...@kernel.org wrote: >>>> From: Shuah Khan >>>> >>>> Media Device Allocator API to allows mult

Re: [PATCH] media: fsl-viu: Use proper check for presence of {out,in}_be32()

2019-01-18 Thread Hans Verkuil
>> above checks work. >> >> Fixes: 29d750686331a1a9 ("media: fsl-viu: allow building it with >> COMPILE_TEST") >> Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Hans Verkuil > > Should this go through the media tree or powerpc tree?

Re: [RFC PATCH] media/doc: Allow sizeimage to be set by v4l clients

2019-01-18 Thread Hans Verkuil
On 1/16/19 1:37 PM, Stanimir Varbanov wrote: > This changes v4l2_pix_format and v4l2_plane_pix_format sizeimage > field description to allow v4l clients to set bigger image size > in case of variable length compressed data. > > Signed-off-by: Stanimir Varbanov > --- > Documentation/media/uapi/v4

Re: [PATCH v9 4/4] sound/usb: Use Media Controller API to share media resources

2019-01-18 Thread Hans Verkuil
On 12/18/18 6:59 PM, sh...@kernel.org wrote: > From: Shuah Khan > > Media Device Allocator API to allows multiple drivers share a media device. > This API solves a very common use-case for media devices where one physical > device (an USB stick) provides both audio and video. When such media devi

Re: [alsa-devel] [PATCH v9 4/4] sound/usb: Use Media Controller API to share media resources

2019-01-11 Thread Hans Verkuil
On 1/11/19 3:57 PM, shuah wrote: > On 12/19/18 6:51 AM, Takashi Iwai wrote: >> On Tue, 18 Dec 2018 18:59:39 +0100, >> sh...@kernel.org wrote: >>> >>> From: Shuah Khan >>> >>> Media Device Allocator API to allows multiple drivers share a media device. >>> This API solves a very common use-case for

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Hans Verkuil
On 01/09/19 15:42, Paul Kocialkowski wrote: > Hi, > > On Wed, 2019-01-09 at 15:29 +0100, Hans Verkuil wrote: >> On 01/09/19 15:19, Paul Kocialkowski wrote: >>> It was reported that some cases of interleaved video decoding require >>> using the current destinati

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Hans Verkuil
On 01/09/19 15:19, Paul Kocialkowski wrote: > It was reported that some cases of interleaved video decoding require > using the current destination buffer as a reference. However, this is > no longer possible after the move to vb2_find_timestamp because only > dequeued and done buffers are consider

Re: [PATCH] media: imx: queue subdev events to reachable video devices

2019-01-08 Thread Hans Verkuil
On 12/09/18 20:57, Steve Longerbeam wrote: > From: Steve Longerbeam > > Forward events from a sub-device to its list of reachable video > devices. > > Note this will queue the event to a video device even if there is > no actual _enabled_ media path from the sub-device to the video device. > So

[PATCH v6 3/2] MAINTAINERS: added include/trace/events/pwc.h

2018-12-12 Thread Hans Verkuil
Added include/trace/events/pwc.h to the list of files. Signed-off-by: Hans Verkuil --- Will include this patch as part of the pull request. --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e9f1710ed13..3ce9533bca26 100644 --- a/MAINTAINERS

Re: [PATCH v7 2/2] media: platform: Add Aspeed Video Engine driver

2018-12-11 Thread Hans Verkuil
On 12/11/18 5:41 PM, Eddie James wrote: >> Running checkpatch.pl --strict over the patch gives me three 'CHECK' items >> they you should also address: >> >> CHECK: struct mutex definition without comment >> #312: FILE: drivers/media/platform/aspeed-video.c:222: >> +   struct mutex video_lock

Re: [PATCH v7 2/2] media: platform: Add Aspeed Video Engine driver

2018-12-11 Thread Hans Verkuil
On 12/10/18 11:26 PM, Eddie James wrote: > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting a service processor, the Video Engine can capture > the host processor graphics output

Re: [PATCH] media: vimc: add configfs API to configure the topology

2018-12-10 Thread Hans Verkuil
On 12/10/18 5:14 PM, Helen Koike wrote: > Hi Hans, > > On 12/10/18 9:31 AM, Hans Verkuil wrote: >> On 12/7/18 7:22 PM, Helen Koike wrote: > >> >> The previewer is effectively similar to a debayer block. > > You mean the image it outputs? Yes. It takes a

Re: [PATCH] media: vimc: add configfs API to configure the topology

2018-12-10 Thread Hans Verkuil
On 12/7/18 7:22 PM, Helen Koike wrote: > Add API to allow userspace to create any type of topology in vimc using > basic system calls such as mkdir/rmdir/read/write. > > Signed-off-by: Helen Koike > > --- > Hi, > > This patch introduces the configufs API for configuring the topology in > vimc w

Re: Configure video PAL decoder into media pipeline

2018-12-07 Thread Hans Verkuil
On 12/07/2018 12:51 PM, Jagan Teki wrote: > Hi, > > We have some unconventional setup for parallel CSI design where analog > input data is converted into to digital composite using PAL decoder > and it feed to adv7180, camera sensor. > > Analog input => Video PAL Decoder => ADV7180 => IPU-CSI0

Re: [PATCH 2/5] media: dt-bindings: Add binding for si470x radio

2018-12-07 Thread Hans Verkuil
Please combine 2/5 with 5/5. No need to have two patches for these bindings. Regards, Hans On 12/05/2018 04:47 PM, Paweł Chmiel wrote: > Add device tree bindings for si470x family radio receiver driver. > > Signed-off-by: Paweł Chmiel > --- > .../devicetree/bindings/media/si470x.txt

Re: [PATCH v4] media: vivid: Improve timestamping

2018-12-07 Thread Hans Verkuil
Hi Gabriel, On 12/02/2018 02:45 PM, Gabriel Francisco Mandaji wrote: > Simulate a more precise timestamp by calculating it based on the > current framerate. > > Signed-off-by: Gabriel Francisco Mandaji > --- > Changes in v2: > - fix spelling > - end of exposure is offset by 90% of the fr

Re: [PATCH 1/6] media: v4l2-subdev: stub v4l2_subdev_get_try_format() ??

2018-12-07 Thread Hans Verkuil
On 12/06/2018 09:30 AM, jacopo mondi wrote: > Hi Lubomir, > > On Tue, Dec 04, 2018 at 04:01:43PM +0100, Lubomir Rintel wrote: >> On Mon, 2018-12-03 at 14:48 +0100, jacopo mondi wrote: >>> Hi Lubomir, >>> >>> thanks for the patches >>> >>> On Wed, Nov 28, 2018 at 06:19:13PM +0100, Lubomir Rintel

Re: [PATCH v4] media: vivid: Improve timestamping

2018-12-03 Thread Hans Verkuil
On 12/02/2018 09:43 PM, Arnd Bergmann wrote: > On Sun, Dec 2, 2018 at 2:47 PM Gabriel Francisco Mandaji > wrote: > >> @@ -667,10 +653,28 @@ static void vivid_overlay(struct vivid_dev *dev, >> struct vivid_buffer *buf) >> } >> } >> >> +static void vivid_cap_update_frame_period(struct viv

Re: [PATCH] media: videobuf2-core: fix use after free in vb2_mmap

2018-11-17 Thread Hans Verkuil
Same patch was already posted and is waiting to be merged: https://patchwork.linuxtv.org/patch/52944/ Regards, Hans On 11/17/2018 12:42 AM, Sudip Mukherjee wrote: > When we are using __find_plane_by_offset() to find the matching plane > number and the buffer, the queue is not locked. So

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-11-15 Thread Hans Verkuil
On 10/22/2018 04:48 PM, Tomasz Figa wrote: > Due to complexity of the video decoding process, the V4L2 drivers of > stateful decoder hardware require specific sequences of V4L2 API calls > to be followed. These include capability enumeration, initialization, > decoding, seek, pause, dynamic resolut

Re: [PATCH v4 2/2] media: platform: Add Aspeed Video Engine driver

2018-10-12 Thread Hans Verkuil
On 10/05/2018 09:57 PM, Eddie James wrote: > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting a service processor, the Video Engine can capture > the host processor graphics outp

Re: [PATCH v3 0/3] Add Amlogic video decoder driver

2018-10-01 Thread Hans Verkuil
On 09/28/2018 04:28 PM, Maxime Jourdan wrote: > Hi everyone, > > This patch series adds support for the Amlogic video decoder, > as well as the corresponding dt bindings for GXBB/GXL/GXM chips. > > It features decoding for the following formats: > - MPEG 1 > - MPEG 2 > > The following formats wi

Re: gpio regression in linux-next

2018-09-17 Thread Hans Verkuil
On 09/17/2018 02:49 PM, Heikki Krogerus wrote: > Hi, > > I hit a BUG while attempting to unload fusb302 driver module on my > Intel CHT board (GPDWin). I bisected it to commit: > > 461c1a7d4733 ("gpiolib: override irq_enable/disable") Does your linux-next have this patch: https://patchw

Re: [PATCH v2 2/2] media: platform: Add Aspeed Video Engine driver

2018-09-14 Thread Hans Verkuil
On 09/14/2018 05:22 PM, Eddie James wrote: >>> +static int aspeed_video_allocate_cma(struct aspeed_video *video) >>> +{ >>> + video->srcs[0].virt = dma_alloc_coherent(video->dev, >>> +VE_SRC_BUFFER_SIZE, >>> +

Re: [RFC PATCH] media: docs-rst: Document m2m stateless video decoder interface

2018-09-10 Thread Hans Verkuil
Hi Alexandre, Thank you very much for working on this, much appreciated! On 08/31/2018 09:47 AM, Alexandre Courbot wrote: > This patch documents the protocol that user-space should follow when > communicating with stateless video decoders. It is based on the > following references: > > * The cur

Re: [PATCH 0/2] Document memory-to-memory video codec interfaces

2018-09-10 Thread Hans Verkuil
Hi Tomasz, On 07/24/2018 04:06 PM, Tomasz Figa wrote: > This series attempts to add the documentation of what was discussed > during Media Workshops at LinuxCon Europe 2012 in Barcelona and then > later Embedded Linux Conference Europe 2014 in Düsseldorf and then > eventually written down by Pawel

Re: v4.19-rc0: compile problem in ./include/media/cec.h:82:24:

2018-08-22 Thread Hans Verkuil
On 22/08/18 23:12, Pavel Machek wrote: > Hi! > >> I'm getting this in -rc0: >> >> CC drivers/gpu/drm/ttm/ttm_tt.o >> In file included from ./include/media/cec-notifier.h:13:0, >>from drivers/gpu/drm/i915/intel_drv.h:42, >> from >> dri

Re: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC

2018-08-02 Thread Hans Verkuil
On 08/03/2018 12:58 AM, Mauro Carvalho Chehab wrote: > Em Tue, 24 Jul 2018 11:35:59 +0200 > Arnd Bergmann escreveu: > >> Without the MFD driver, we run into a link error: > > Weird... I'm not seeing this driver at the media tree... was it merged via > some other tree? Yes, it's going via the mf

Re: [PATCH 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2018-07-25 Thread Hans Verkuil
On 24/07/18 16:06, Tomasz Figa wrote: > Due to complexity of the video encoding process, the V4L2 drivers of > stateful encoder hardware require specific sequences of V4L2 API calls > to be followed. These include capability enumeration, initialization, > encoding, encode parameters change, drain a

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-07-25 Thread Hans Verkuil
g format on ``OUTPUT`` queue may change the set of formats Setting -> Setting the > + supported/advertised on the ``CAPTURE`` queue. In particular, it also > + means that ``CAPTURE`` format may be reset and the client must not that -> that the > + rely on the previously se

Re: [PATCH v7 6/6] [media] cxusb: add analog mode support for Medion MD95700

2018-07-17 Thread Hans Verkuil
On 10/07/18 23:48, Maciej S. Szmigiero wrote: > Hi Hans, > > On 04.07.2018 11:33, Hans Verkuil wrote: >> Hi Maciej, >> >> On 02/07/18 23:23, Maciej S. Szmigiero wrote: > (..) >>> +static int cxusb_medion_v_queue_setup(struct vb2_queue *q, >>>

Re: [PATCH v7 0/6] Add ChromeOS EC CEC Support

2018-06-11 Thread Hans Verkuil
On 11/06/18 10:56, Neil Armstrong wrote: > Hi Lee, > > On 11/06/2018 08:03, Lee Jones wrote: >> On Fri, 08 Jun 2018, Hans Verkuil wrote: >>> On 08/06/18 10:17, Neil Armstrong wrote: >>>> On 08/06/2018 09:53, Hans Verkuil wrote: >>>>> On 06/01

Re: [PATCH v2 1/2] media: v4l2-ctrl: Add control for VP9 profile

2018-06-11 Thread Hans Verkuil
s Dufresne wrote: >> >> >> >> Le ven. 8 juin 2018 08:56, Stanimir Varbanov >> a écrit : >>> >>> Hi Hans, >>> >>> On 06/08/2018 12:29 PM, Hans Verkuil wrote: >>>> On 05/30/2018 09:16 AM, Keiichi Watanabe wrote: >>

Re: [PATCH v2] media: staging: tegra-vde: Reset memory client

2018-05-28 Thread Hans Verkuil
Hi Dmitry, On 05/26/2018 04:27 PM, Dmitry Osipenko wrote: > DMA requests must be blocked before resetting VDE HW, otherwise it is > possible to get a memory corruption or a machine hang. Use the reset > control provided by the Memory Controller to block DMA before resetting > the VDE HW. > > Sign

Re: [PATCH] media: v4l2-ctrl: Add control for VP9 profile

2018-05-25 Thread Hans Verkuil
On 17/05/18 11:53, Keiichi Watanabe wrote: > Add a new control V4L2_CID_MPEG_VIDEO_VP9_PROFILE for selecting desired > profile for VP9 encoder and querying for supported profiles by VP9 encoder > or decoder. > > An existing control V4L2_CID_MPEG_VIDEO_VPX_PROFILE cannot be > used for querying sinc

Re: [PATCH 2/3] gspca_zc3xx: Fix power line frequency settings for OV7648

2018-05-25 Thread Hans Verkuil
On 24/05/18 17:09, Ondrej Zary wrote: > Power line frequency settings for OV7648 sensor contain autogain > and exposure commands, affecting unrelated controls. Remove them. > > Signed-off-by: Ondrej Zary > --- > drivers/media/usb/gspca/zc3xx.c | 17 ++--- > 1 file changed, 10 inserti

Re: [PATCH v6 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-24 Thread Hans Verkuil
On 24/05/18 11:57, Neil Armstrong wrote: > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong > Reviewed-by: Enric Balletbo i Serra For whatever it is worth: Acked-by: Hans Ve

Re: [PATCH v6 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Hans Verkuil
On 24/05/18 11:57, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > > Signed-off-by: Neil Armstrong > Tested-by: Enric Balletbo i Serra Reviewed-by: Hans Verkuil Thanks! Hans &

Re: [PATCH v5 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Hans Verkuil
On 24/05/18 10:54, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > > Signed-off-by: Neil Armstrong > Tested-by: Enric Balletbo i Serra > --- > include/linux/mfd/cros_ec_commands.h | 85 >

Re: [PATCH v5 6/6] media: platform: Add ChromeOS EC CEC driver

2018-05-24 Thread Hans Verkuil
or name. > > Signed-off-by: Neil Armstrong > Reviewed-by: Enric Balletbo i Serra Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile | 2 + > drivers/media/platf

Re: [PATCH v5 1/6] media: cec-notifier: Get notifier by device and connector name

2018-05-24 Thread Hans Verkuil
ed-off-by: Neil Armstrong Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/media/cec/cec-notifier.c | 11 --- > include/media/cec-notifier.h | 27 --- > 2 files changed, 32 insertions(+), 6 deletions(-) > > diff --git a/d

Re: [PATCH v10 08/16] v4l: mark unordered formats

2018-05-23 Thread Hans Verkuil
On 23/05/18 12:30, Ezequiel Garcia wrote: > On Tue, 2018-05-22 at 13:55 +0200, Hans Verkuil wrote: >> On 21/05/18 18:59, Ezequiel Garcia wrote: >>> From: Gustavo Padovan >>> >>> Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, >>> mark

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Hans Verkuil
On 22/05/18 18:22, Ezequiel Garcia wrote: >>> @@ -1615,7 +1762,12 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) >>> return; >>> >>> vb->state = VB2_BUF_STATE_DEQUEUED; >>> - >>> + if (vb->in_fence) { >>> + if (dma_fence_remove_callback(vb->in_fence, &vb->fence_cb))

Re: [PATCH v10 13/16] vb2: add out-fence support to QBUF

2018-05-22 Thread Hans Verkuil
- Return fence_fd to userpace only in the QBUF ioctl. > - Rework implementation to avoid storing the sync_file >as state, which is not really needed. > > v10: - use -EIO for fence error (Hans Verkuil) > - add comment around fence context creation (Hans Verkuil) >

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Hans Verkuil
ected enqueue conditioin > - schedule a vb2_start_streaming work from the fence callback > > v12: fixed dvb_vb2.c usage of vb2_core_qbuf. > > v11: - minor doc/comments fixes (Hans Verkuil) > - reviewed the in-fence path at __fill_v4l2_buffer() > > v10: - ren

Re: [PATCH v10 11/16] vb2: add explicit fence user API

2018-05-22 Thread Hans Verkuil
, that should be used > when sending an in-fence to the kernel to be waited on, and > V4L2_BUF_FLAG_OUT_FENCE, to ask the kernel to give back an out-fence. > > v8: return -1 if new flags are set. > v7: minor fixes on the Documentation (Hans Verkuil) > > v6: big improvement o

<    3   4   5   6   7   8   9   10   11   12   >