On Tuesday, October 15, 2013 3:40 AM, Thierry Reding wrote:
On Mon, Oct 14, 2013 at 02:57:48PM -0700, H Hartley Sweeten wrote:
Remove the non-standard EP93xx pwm driver in drivers/misc and add
pwm - PWM
OK
a new driver for the PWM chips on the EP93xx platforms based on the
PWM framework
: 97f4289ad08cffe55de06d4ac4f89ac540450aee
Author: H Hartley Sweeten hswee...@visionengravers.com
AuthorDate: Fri Aug 30 11:06:17 2013 -0700
Committer: Greg Kroah-Hartman gre...@linuxfoundation.org
CommitDate: Tue Sep 17 07:47:40 2013 -0700
staging: comedi: drivers: use comedi_dio_update_state
Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wednesday, November 27, 2013 9:39 AM, Hartley Sweeten wrote:
On Tuesday, November 26, 2013 7:57 PM, Dave Jones wrote:
Introduced in commit b3ff824a81e8.
Signed-off-by: Dave Jones da...@fedoraproject.org
diff --git a/drivers/staging/comedi/drivers/pcl730.c
b/drivers/staging/comedi
Hartley Sweeten hswee...@visionengravers.com
Thanks
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Monday, October 14, 2013 3:01 PM, Ryan Mallon wrote:
On 15/10/13 08:35, H Hartley Sweeten wrote:
Convert ep93xx to use the OHCI platform driver and remove the
ohci-ep93xx bus glue driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Alan Stern st
On Tuesday, October 15, 2013 8:50 AM, Olof Johansson wrote:
On Mon, Oct 14, 2013 at 2:35 PM, H Hartley Sweeten
hartl...@visionengravers.com wrote:
Convert ep93xx to use the OHCI platform driver and remove the
ohci-ep93xx bus glue driver.
Signed-off-by: H Hartley Sweeten hswee
On Saturday, March 01, 2014 3:28 AM, Chase Southwood wrote:
Subject: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_*
helper functions in hwdrv_apci1564.c
This patch introduces a handful of outl and inl helper functions with the
ultimate goal of improving code readability
On Wednesday, March 05, 2014 11:57 PM, Fred Akers wrote:
Refactor this function to remove an extra indent level
Signed-off-by: Fred Akers kni...@botops.net
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
Thanks
--
To unsubscribe from this list: send the line unsubscribe linux
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
Thanks
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
On Thursday, March 06, 2014 12:25 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Additionally, the
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital output registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Additionally,
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
watchdog registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Additionally, the
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
timer registers such that they are all the real offsets to each register,
rather than a mix of real offsets and adders to those offsets.
Additionally, the defines
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Signed-off-by:
On Friday, March 07, 2014 1:32 AM, Chase Southwood wrote:
On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten
hartl...@visionengravers.com wrote:
This one is incomplete and breaks the build.
Be sure to do a build after each patch to make sure it works.
Hartley,
I'm sorry
On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote:
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
being used incorrectly in the
i_APCI1564_Reset() function. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
Much better, thanks!
For the 5 patch series:
Reviewed-by: H Hartley
On Tuesday, March 11, 2014 10:33 AM, Fred Akers wrote:
This patch fixes a few function names that are very long and are
not in the correct naming style
Signed-off-by: Fred Akers kni...@botops.net
---
This is v2 of [PATCH] Staging: comedi: apci_1564: Fix long CamelCase
function names
On Tuesday, March 11, 2014 10:49 AM, Joe Perches wrote:
On Tue, 2014-03-11 at 17:42 +, Hartley Sweeten wrote:
On Tuesday, March 11, 2014 10:33 AM, Fred Akers wrote:
This patch fixes a few function names that are very long and are
not in the correct naming style
[]
diff --git a/drivers
tree and you compile tested it,
for both patches:
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote:
This patch fixes a few function names that are very long and are
not in the correct naming style
Signed-off-by: Fred Akers kni...@botops.net
Fred,
I pulled Greg's staging tree to see if your patches apply.
Patch 1/2 is ok but patch 2/2
On Wednesday, February 12, 2014 8:29 PM, Chase Southwood wrote:
In this if-else conditional statement, if (chan 16), but
(data[0] == INSN_CONFIG_DIO_QUERY), the function does not return early,
but the else-branch does not get executed either. As a result, mask
would be used uninitialized in
On Friday, February 14, 2014 4:50 AM, Ian Abbott wrote:
On 2014-02-13 18:25, Hartley Sweeten wrote:
On Wednesday, February 12, 2014 8:29 PM, Chase Southwood wrote:
In this if-else conditional statement, if (chan 16), but
(data[0] == INSN_CONFIG_DIO_QUERY), the function does not return early
On Saturday, October 19, 2013 2:22 PM, Greg KH wrote:
On Thu, Oct 17, 2013 at 01:29:11PM -0700, H Hartley Sweeten wrote:
Convert ep93xx to use the OHCI platform driver and remove the
ohci-ep93xx bus glue driver.
Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB
is still
On Saturday, October 19, 2013 2:22 PM, Greg KH wrote:
On Thu, Oct 17, 2013 at 01:29:11PM -0700, H Hartley Sweeten wrote:
Convert ep93xx to use the OHCI platform driver and remove the
ohci-ep93xx bus glue driver.
Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB
is still
Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
.
---
drivers/staging/comedi/drivers/ni_daq_700.c | 53
+++--
1 file changed, 43 insertions(+), 10 deletions(-)
Ian,
I couple nitpicks on this patch but nothing big. Ignore all of these
comments if you wish.
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
diff
analog inputs.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_daq_700.c | 51
++---
1 file changed, 25 insertions(+), 26 deletions(-)
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send
the user.
Remove the send_sig() usage in this driver.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23
--
1 file
...@mev.co.uk
Cc: H Hartley Sweeeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5 -
1 file changed, 5 deletions(-)
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux
a private data struct specifically for
addi_apci_1564 containing only the fields it will actually use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564
Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c
b/drivers/staging/comedi/drivers
chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
The structure of _much_ of this code was taken from/based on the similar
code found in addi_apci_1032.c. As such, I would appreciate as much
review I can get to make sure what
ui_InterruptStatus_1564 to ctrl, and change the return
from IRQ_RETVAL(1) to IRQ_HANDLED.
We also check the device is asserting the shared interrupt line and check
that interrupts have been enabled.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley
On Tuesday, January 14, 2014 8:59 PM, Greg KH wrote:
Sleep for at least 10, as I think that's the smallest time delay you can
sleep for anyway (meaning it will be that long no matter what number you
put there less than 10, depending on the hardware used of course.)
A bit off topic here but I
On Wednesday, January 15, 2014 10:52 AM, Chase Southwood wrote:
This patch for ni_mio_common.c changes out a while loop for a timeout,
which is preferred.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Changed from simple clean-up to swapping a timeout in for a while loop.
/comedi/drivers/pcmmio.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
Hello Chase,
This was already fixed, and merged into linux-next, by
commit 4bb82d647dad7be06341ffdb9f07a56a387e213f
Author: H Hartley Sweeten hswee...@visionengravers.com
Date: Tue Nov 26 10
On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote:
create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
Hello Rostislav,
As pointed out by Dan Carpenter, you need to add a change log and
Signed-off-by lines to this patch.
Overall this looks pretty good. Comments below.
diff
On Saturday, April 26, 2014 7:04 AM, Christian Engelmayer wrote:
Some board pointer are assigned twice via comedi_board() in the comedi low
level driver attach functions. Remove the duplicate assignment from the
variable definition where the pointer is not used anyway until assigned later
in
chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
2: Incorrect patch title fixed.
Ian and Hartley,
The auto_attach() function is starting to look much better now. My next
patchset
will be geared towards only allocating subdevices
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote:
Thanks so much, I greatly appreciate the review. I'll fix the
changelog for patch 4 and send once more (as I assume that's easier
for Greg). Also, I should know better about the cover letter as
well...I was once told not to send
On Friday, May 02, 2014 9:50 AM, Ian Abbott wrote:
On 2014-05-02 15:57, Brilliantov Kirill Vladimirovich wrote:
Signed-off-by: Brilliantov Kirill Vladimirovich brillian...@inbox.ru
---
drivers/staging/comedi/drivers/ni_stc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
.
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-by: Chase Southwood chase.southw...@yahoo.com
Cc: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
---
Compile tested only.
Looks good.
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux
On Friday, April 25, 2014 1:17 AM, Chase Southwood wrote:
This board does not have analog inputs. Remove the subdevice init for
them.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
Looks good
On Friday, April 25, 2014 1:18 AM, Chase Southwood wrote:
The board supported by this driver does not have analog outputs. Remove
the subdevice init for it.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee
sure it's taken
care of
before I move on!
Sorry, I thought I already responded to this...
Looks good now.
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
the driver's use of the struct addi_private, so that it may
eventually use a much slimmer specialized private struct instead, as the
other addi_apci_* drivers do.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
This is a (small) first
On Tuesday, April 15, 2014 11:58 PM, Chase Southwood wrote:
We can remove this function from the boardinfo and move the code from
hwdrv_apci1564.c into addi_apci_1564.c since it is the only reset function
used by the driver. The function was also messy and failed to reset a few
registers,
On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote:
Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c. The
function was very messy and failed to reset a couple registers, these
issues were fixed on the move.
The commit message needs updated. You are no longer moving
On Wednesday, April 16, 2014 4:53 PM, Chase Southwood wrote:
On Wednesday, April 16, 2014 6:36 PM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote:
Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c. The
function
On Friday, June 20, 2014 4:20 AM, Geert Uytterhoeven wrote:
On Fri, Jun 20, 2014 at 1:12 PM, Ian Abbott abbo...@mev.co.uk wrote:
drivers/staging/comedi/drivers/ni_atmio.c:318:38: error: macro
writew passed 3 arguments, but takes just 2
Thanks, but Hartley has already fixed it and Greg has
On Tuesday, July 22, 2014 12:23 PM, Joe Perches wrote:
On Tue, 2014-07-22 at 17:30 +, Hartley Sweeten wrote:
Joe,
I think this is a false positive, at least the check message appears
incorrect:
CHECK: No space is necessary after a cast
#66: FILE: arch/arm/mach-ep93xx/include/mach
by timer/counter/watchdog subdevices is the new order.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 34
+++--
1 file
On Sunday, July 27, 2014 11:45 AM, Greg Kroah-Hartman wrote:
On Fri, Jul 25, 2014 at 06:23:10PM +, Hartley Sweeten wrote:
On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote:
`dio200_detach()` in amplc_dio200.c calls
`amplc_dio200_common_detach()` in amplc_dio200_common.c, followed
On Tuesday, July 29, 2014 4:58 AM, Ian Abbott wrote:
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 151
++
1 file changed, 58 insertions(+), 93 deletions(-)
diff --git
deletions(-)
Other than my comment about patch 13, this looks ok.
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Wednesday, July 30, 2014 7:28 AM, Ian Abbott wrote:
On 2014-07-30 15:09, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote:
On 2014-07-30 14:41, Dan Carpenter wrote:
On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 32
++---
1 file changed, 29 insertions(+), 3 deletions(-)
Thanks for fixing this!
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
positions.
Change the range tables to include all possible ranges, regardless of
jumper positions. Then there is no need to have options to control
setting up the range tables and the legacy attach mechanism can be
removed.
Also, tidy the code up a bit.
Looks good.
Reviewed-by: H Hartley
On Thursday, July 31, 2014 1:28 PM, Hartley Sweeten wrote:
On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote:
The amplc_pci224 driver retains a legacy attach mechanism via the
`COMEDI_DEVCONFIG` ioctl and the comedi driver attach hook, but
usually attaches PCI devices automatically via
On Friday, July 25, 2014 2:05 AM, Ian Abbott wrote:
Use preferred style for copyright and driver description comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pc236.c | 92
++--
1 file changed, 46 insertions(+), 46
On Friday, July 25, 2014 2:05 AM, Ian Abbott wrote:
The amplc_pc236 driver supports both ISA cards (Amplicon PC36AT) and PCI
cards (PCI236). I plan to split it into separate drivers with a module for
common code, but let's reorganise it a bit first.
The driver still supports manual
On Friday, July 25, 2014 10:37 AM, Hartley Sweeten wrote:
On Friday, July 25, 2014 2:05 AM, Ian Abbott wrote:
The amplc_pc236 driver supports both ISA cards (Amplicon PC36AT) and PCI
cards (PCI236). I plan to split it into separate drivers with a module for
common code, but let's reorganise
Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote:
`dio200_detach()` in amplc_dio200.c calls
`amplc_dio200_common_detach()` in amplc_dio200_common.c, followed by
`comedi_legacy_detach()` in ../drivers.c. Both of those functions
call `free_irq()` if `dev-irq` is non-zero. The second call
...@mev.co.uk
---
v2: Use C99 syntax for amplc_pci224_pci_table[] initializer. Thanks to
Hartley for finding that!
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
Thanks,
Hartley
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
? sizeof(int) : sizeof(short);
The samples are really 'unsigned' types but I guess it doesn't matter here.
+}
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Monday, October 20, 2014 7:11 AM, Ian Abbott wrote:
As a follow-up to commit 6cab7a37f5c04 (staging: comedi: (regression)
channel list must be set for COMEDI_CMD ioctl), Hartley Sweeten pointed
out another couple of bugs stemming from commit 6cab7a37f5c04 (staging:
comedi: comedi_fops
On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote:
On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote:
Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 (staging: comedi:
amplc_pci230: refactor iobase addresses) removed some parentheses
(presumably to keep the line withing
On Thursday, September 11, 2014 2:38 PM, Greg Kroah-Hartman wrote:
On Thu, Sep 11, 2014 at 05:57:34PM +, Hartley Sweeten wrote:
Just wanted to give you a heads up on this series and the ones I have
posted. The series are:
From Ian, [PATCH 00/48] staging: comedi: avoid using comedi_board
()... ;-)
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
);
};
-static inline const void *comedi_board(const struct comedi_device *dev)
-{
- return dev-board_ptr;
-}
-
/*
* function prototypes
*/
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
++
3 files changed, 22 insertions(+), 27 deletions(-)
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
All the exported functions in the comedi_fc module have been migrated
to the core comedi module and renamed, so it is now just a dummy
module. Remove it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/Kconfig
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
The comedi_fc module contains a few functions useful to Comedi
drivers. Their functionality is being migrated to the core comedi
module and renamed to start with the prefix `comedi_`. As part of this
migration, move
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
The comedi_fc module contains a few functions useful to Comedi
drivers. Their functionality is being migrated to the core comedi
module and renamed to start with the prefix `comedi_`. As part of this
migration, move
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
The comedi_fc module contains a few functions useful to Comedi
drivers. Their functionality is being migrated to the core comedi
module and renamed to start with the prefix `comedi_`. As part of this
migration, move
not problems with this.
And, patch 11 does have a conflict with your ... use dma_alloc_coherent...
patches.
But,
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On Wednesday, October 08, 2014 8:09 AM, Ian Abbott wrote:
`do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly
call the Comedi subdevice's `do_cmd()` handler with a NULL channel list
pointer. This is a regression as the `do_cmd()` handler has never been
expected to deal
Instruments PCI-20001C carrier
PCI-20001, PCI-20006 and PCI-20341
This seems appropriate.
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf��^jǫy�m��@A�a���
0��h���i
On Thursday, October 02, 2014 10:26 AM, Rostislav Lisovy wrote:
Since egrep -irn ioremap drivers/staging/comedi/drivers | wc -l
shows 39 does it mean that this should be added to all the other
drivers as well?
The others are actually pci_ioremap_bar() and those drivers depend on PCI.
I don't
On Thursday, October 30, 2014 5:42 AM, Ian Abbott wrote:
If a Comedi asynchronous command has been set up for data transfer in
the write direction on the current read subdevice (for those
subdevices that support both directions), don't allow the read file
operation as that would mess with the
On Thursday, October 30, 2014 5:43 AM, Ian Abbott wrote:
If a Comedi asynchronous command has been set up for data transfer in
the read direction on the current write subdevice (for those
subdevices that support both directions), don't allow the write file
operation as that would mess with the
On Thursday, October 30, 2014 1:28 PM, Ian Abbott wrote:
On 30/10/14 18:05, Hartley Sweeten wrote:
On Thursday, October 30, 2014 5:42 AM, Ian Abbott wrote:
[snip]
add_wait_queue(async-wait_head, wait);
while (nbytes 0 !retval) {
@@ -2249,6 +2253,10 @@ static ssize_t comedi_read
. The current test used the `SDF_CMD_READ` and `SDF_CMD_WRITE`
subdevice flags to check the direction, which is ambiguous if both flags
are set. Update it to use the `CMDF_WRITE` command flag instead.
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list
Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
(s, data))
writew(s-state, dev-mmio + ICP_MULTI_DO);
- data[1] = readw(dev-mmio + ICP_MULTI_DI);
+ data[1] = s-state;
return insn-n;
}
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe
On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote:
The Comedi core module doesn't need support for PCI, USB or PCMCIA.
Only the low-level Comedi drivers need it. Split the support for these
bus types out of the core comedi module and into new modules,
comedi_pci, comedi_usb, and
made the drivers
hard to read...
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On Tuesday, September 09, 2014 3:26 AM, Ian Abbott wrote:
The `comedi_board` inline function takes a single parameter of type
`struct comedi_device *` and merely returns the value of the `board_ptr`
member therein. This is somewhat superfluous as the member can be
accessed directly.
Replace
On Monday, September 01, 2014 4:04 AM, Ian Abbott wrote:
Continue to clean up the amplc_pci230 driver code and remove the legacy
attach mechanism, since it isn't very useful for this driver (see PATCH
05/28).
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from
entries. Return an error from the
Comedi driver attach handler `a2150_attach()` if the probed board
index is beyond the end of the array.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line
Hartley Sweeten hswee...@visionengravers.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
to use dev-class_dev as well, for consistency.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
Hmm.. I thought I caught all of these.
Thanks
Reviewed-by: H Hartley Sweeten hswee
On Tuesday, September 16, 2014 12:44 AM, Ian Abbott wrote:
On 15/09/14 19:21, Hartley Sweeten wrote:
Other than I think the comedi_fc.c functions should be migrated to
comedi_buf.c instead of drivers.c I have not problems with this.
I think it's debatable. The only one of the three functions
only have the current scan position in bytes currently,
so convert that to a sample position.)
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: H Hartley Sweeten hswee
1 - 100 of 1421 matches
Mail list logo
