RE: [PATCH 0/5] staging: comedi: split bus support into separate modules

On Friday, October 31, 2014 3:09 PM, Ian Abbott wrote: On 31/10/14 18:19, Hartley Sweeten wrote: On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote: The Comedi core module doesn't need support for PCI, USB or PCMCIA. Only the low-level Comedi drivers need it. Split the support

RE: [PATCH 1/3] staging: comedi: usbduxsigma: updated contact details and status

On Friday, October 10, 2014 12:33 PM, Bernd Porr wrote: I've updated my contact details of the driver. I've also tested it thoroughly and it works perfectly. I've changed the status to stable. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten hswee

RE: [PATCH 2/3] staging: comedi: usbdux: updated contact details / comments

On Friday, October 10, 2014 12:34 PM, Bernd Porr wrote: I've updated my contact details and removed obsolete comments. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux

RE: [PATCH 3/3] staging: comedi: usbduxfast: updated address details

On Friday, October 10, 2014 12:35 PM, Bernd Porr wrote: Updated the range of years, e-mail and added driver desription as usually done in comedi. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send

RE: [PATCH] staging: comedi: (regression) channel list must be set for COMEDI_CMD ioctl

On Thursday, October 09, 2014 2:03 AM, Ian Abbott wrote: On 09/10/14 00:13, Hartley Sweeten wrote: On Wednesday, October 08, 2014 8:09 AM, Ian Abbott wrote: `do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly call the Comedi subdevice's `do_cmd()` handler with a NULL

RE: [PATCH 3/3] staging: comedi: usbduxfast: updated address details

On Tuesday, October 14, 2014 9:51 AM, Hartley Sweeten wrote: On Friday, October 10, 2014 12:35 PM, Bernd Porr wrote: Updated the range of years, e-mail and added driver desription as usually done in comedi. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten

RE: [PATCH 0/3] staging: comedi: cb_pcimdas: support PCIe-DAS1602/16

changed, 46 insertions(+), 40 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] staging: comedi: drivers: comedi_bond.c: Changed from using strncat to strlcat

); + strlcat(devpriv-name, buf, + sizeof(devpriv-name)); } } Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

RE: [PATCH 0/2] staging: comedi: per-file read/write subdevice choice

then use the new ioctls to change the read/write subdevice and use them without having the open the comediX_subdY devices. If this is correct it seems like a good idea. Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com Also, does this mean we can get rid of comedi_alloc_subdevice_minor

RE: [PATCH 0/5] staging: comedi: split bus support into separate modules

drivers to #include different headers. (But then, comedi_pci.h could #include linux/pci.h for example.) Hartley, any objection to me applying this series? No objections... Just questions... ;-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com Hartley -- To unsubscribe from this list

RE: [PATCH] staging: comedi: addi_apci_1032: add comedi driver comment

--- drivers/staging/comedi/drivers/addi_apci_1032.c | 78 +++-- 1 file changed, 48 insertions(+), 30 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

RE: [PATCH 0/5] staging: comedi: 8255.[ch]: reformat comments

insertions(+), 89 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

RE: [PATCH 0/3] staging: comedi: 8253.h: reformat comments

++- 1 file changed, 48 insertions(+), 44 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: [PATCH RFC] staging: comedi: dt282x: condition with no effect - if identical to else

On Tuesday, February 03, 2015 8:13 AM, Ian Abbott wrote: On 03/02/15 12:38, Nicholas Mc Guire wrote: The if and the else branch code are identical - so the condition has no effect on the effective code - this patch removes the condition and the duplicated code. Signed-off-by: Nicholas Mc

RE: [PATCH] net: ep93xx_eth: Delete unnecessary checks before the function call kfree

); - if (ep-tx_buf[i] != NULL) - kfree(ep-tx_buf[i]); + kfree(ep-tx_buf[i]); } dma_free_coherent(dev, sizeof(struct ep93xx_descs), ep-descs, Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Thanks -- To unsubscribe from

RE: [PATCH 00/10] staging: comedi: introduce comedi_pcmcia.h header

/ni_daq_dio24.c| 6 +-- drivers/staging/comedi/drivers/ni_labpc_cs.c | 6 +-- drivers/staging/comedi/drivers/ni_mio_cs.c | 6 +-- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 7 +-- 10 files changed, 63 insertions(+), 70 deletions(-) Reviewed-by: H Hartley Sweeten hswee

RE: [PATCH 0/9] staging: comedi: introduce comedi_usb.h header

-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH v2 0/6] staging: comedi: comedi_compat32.[ch] fix and tidy up

Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH 0/6] staging: comedi: reformat comedi_fops and range comments

insertions(+), 221 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

RE: [PATCH v2] staging: comedi: drivers: addi-data: hwdrv_apci1500: Removed variables that is never used

On Wednesday, January 28, 2015 2:49 PM, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist

RE: [PATCH 1/7] staging: comedi: comedi_compat32.c: fix COMEDI_CMD copy back

On Tuesday, January 27, 2015 8:59 AM, Ian Abbott wrote: On 27/01/15 15:50, Ian Abbott wrote: `do_cmd_ioctl()` in comedi_fops.c handles the `COMEDI_CMD` ioctl. This returns `-EAGAIN` if it has copied a modified `struct comedi_cmd` back to user-space. (This occurs when the low-level Comedi

RE: [PATCH 00/45] staging: comedi: fix up some driver comments

of the ADDI-DATA drivers are missing the comedi comment block: But, this is a great start to getting them cleaned up. Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

RE: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header

do not need to include them explicitly. Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header

On Tuesday, March 10, 2015 9:25 AM, Joe Perches wrote: On Tue, 2015-03-10 at 16:10 +, Ian Abbott wrote: comedidev.h includes PCI-specific stuff that gets included by all comedi drivers including non-PCI ones. Separate it out into its own header comedi_pci.h. Make the new header include

RE: [PATCH 0/7] staging: comedi: comedi_fops: some runflag and event handling changes

prefer. Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

RE: [PATCH] staging: comedi: make comedi_internal.h self-reliant

that it doesn't break... :-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

RE: [PATCH 00/60] staging: comedi: comedi_fc.h removal

) staging: comedi: remove comedi_fc.h Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

RE: [PATCH 62/86] staging/comedi: use uapi/linux/pci_ids.h directly

On Sunday, March 29, 2015 10:35 AM, Ian Abbott wrote: On 29/03/15 14:42, Michael S. Tsirkin wrote: Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin m...@redhat.com

RE: [PATCH 7/7] staging: comedi: comedi_fops: extend spin-lock scope in comedi_event()

On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote: `comedi_event()` is called from low-level drivers to handle comedi asynchronous command event flags. As a safety check, it checks the subdevice's run flags to make sure an asynchronous command is running. It can also change the run flags to

RE: [PATCH 7/7] staging: comedi: comedi_fops: extend spin-lock scope in comedi_event()

On Tuesday, March 31, 2015 2:43 AM, Ian Abbott wrote: On 30/03/15 17:47, Hartley Sweeten wrote: On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote: `comedi_event()` is called from low-level drivers to handle comedi asynchronous command event flags. As a safety check, it checks

RE: [PATCH] comedi: Change error return code for if statement in the function,cb_pcimdas_ai_rinsn

On Tuesday, February 24, 2015 9:13 PM, Nicholas Krause wrote: This changes us using the incorrect error,-ETIMEOUT when checking if the channel we are allocating to on the device structure pointer passed to this function is greater then the maximum available channels for this device to the

RE: [PATCH 0/2] staging: comedi: hide subdevice runflags stuff

/comedi/drivers.c | 2 +- .../staging/comedi/drivers/amplc_dio200_common.c | 6 ++-- 5 files changed, 45 insertions(+), 23 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

RE: [PATCH 0/8] staging: comedi: mite: some clean-ups

/comedi/drivers/mite.c | 110 +- drivers/staging/comedi/drivers/mite.h | 88 ++- 2 files changed, 101 insertions(+), 97 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send

RE: [PATCH 0/6] staging: comedi: gsc_hpdi: some clean-ups

MODULE_DESCRIPTION() drivers/staging/comedi/drivers/gsc_hpdi.c | 184 +- 1 file changed, 80 insertions(+), 104 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

RE: Question about the function,ni_stc_dma_channel_select_bitfield

On Wednesday, May 06, 2015 7:06 AM, nick wrote: On 2015-05-06 05:10 AM, Ian Abbott wrote: On 06/05/15 01:22, nick wrote: Greetings All, I am wondering if in the function,ni_stc_dma_channel_select_bitfield the line: return 1 channel; is guaranteed to be below the threshold that guarantees

RE: rtc: ep93xx: Use readl/writel for io

On Tuesday, May 19, 2015 1:40 PM, Alexandre Belloni wrote: On 21/03/2012 at 10:55:31 -0700, hartleys wrote : Drivers should not be using the __raw_* io accessors. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Alessandro Zummo a.zu...@towertech.it Rebased and applied

RE: [PATCH 00/32] staging: comedi: das08: tidy up

, 188 insertions(+), 193 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

RE: [PATCH] staging: comedi: addi_watchdog.h: don't include ../comedidev.h

the structure type incompletely and don't bother including the header file. Signed-off-by: Ian Abbott abbo...@mev.co.uk Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

RE: [PATCH 0/4] staging: comedi: 8255: fix cleanup and split module

insertions(+), 235 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

RE: [PATCH 0/6] staging: comedi: amplc_dio200*: minor source cleanups

insertions(+), 80 deletions(-) Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

RE: [PATCH] staging: comedi: comedi_8254.h: make self-reliant

. Signed-off-by: Ian Abbott abbo...@mev.co.uk Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] staging: comedi: comedi_isadma.h: make self-reliant

linux/types.h to declare it. (Also, that indirectly takes care of the use of `NULL`.) It uses `struct comedi_device *` in various function prototypes, so add an incomplete declaration of `struct comedi_device`. Signed-off-by: Ian Abbott abbo...@mev.co.uk Reviewed-by: H Hartley Sweeten hswee

RE: [PATCH V2] Watchdog: Fix parent of watchdog_devices

, nowayout); For ep93xx_wdt.c, use whichever tag you prefer: Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com Acked-by: H Hartley Sweeten hswee...@visionengravers.com Thanks, Hartley -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

RE: [PATCH] staging: comedi: improve comedi_check_chanlist() documentation

, unsigned int *chanlist) { Thanks, Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

RE: [PATCH] ARM/EP93xx/timer: Migrate to new 'set-state' interface

, for example: ONESHOT_STOPPED. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: [PATCH 0/6] staging: comedi: usbduxsigma: fix some problems in command handling

: remove unused convert timing for AO 6) staging: comedi: usbduxsigma: round down AO scan_begin_arg at step 4. drivers/staging/comedi/drivers/usbduxsigma.c | 139 +++ 1 file changed, 54 insertions(+), 85 deletions(-) Reviewed-by: H Hartley Sweeten hswee

RE: [PATCH 00/16] staging: comedi: comedi_test: enhancements

; drivers/staging/comedi/drivers/comedi_test.c | 565 > ++++++++++++--- > 1 file changed, 416 insertions(+), 149 deletions(-) Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

RE: [PATCH] comedi: ii_pci20kc: Fix coding style - use BIT macro

On Monday, November 09, 2015 9:26 AM, Ranjith wote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith This has already been fixed in by: commit c98f4011ebd41ab9ff15e1c52acc446e1ee7e191 staging:

RE: [PATCH] comedi: me_daq: Fix coding style - use BIT macro

On Monday, November 09, 2015 10:14 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith This has already been fixed. Please base your patches on linux-next or Greg Kroah-Hartman's

RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

On Monday, November 09, 2015 8:17 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith > --- > drivers/staging/comedi/drivers/comedi_parport.c |4 ++-- > 1 file changed, 2

RE: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro

On Monday, November 09, 2015 8:09 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith > --- > drivers/staging/comedi/drivers/pcmmio.c | 44 > +++ > 1

RE: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro

On Monday, November 16, 2015 10:09 AM, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator, usleep_range is preferred over > udelay - coding style issue > > Signed-off-by: Ranjith Thangavel > --- >

RE: [PATCH 0/2] staging: comedi: comedidev.h: fix some checkpatch issues

gt; > 1) staging: comedi: comedidev.h: add comments to spin-lock and mutex > 2) staging: comedi: comedidev.h: spaces preferred around that '*' > > drivers/staging/comedi/comedidev.h | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Thanks! Reviewed-by: H H

RE: [PATCH 00/10] staging: comedi: some comedi_read() changes

taging: comedi: return error on "read" if no command set up > 09) staging: comedi: simplify returned errors for comedi_read() > 10) staging: comedi: check for more errors for zero-length read > > drivers/staging/comedi/comedi_fops.c | 68 > +---

RE: [PATCH 0/6] staging: comedi: fix some minor issues with file poll op

_buf.c | 19 +-- > drivers/staging/comedi/comedi_fops.c | 17 + > drivers/staging/comedi/comedi_internal.h | 1 + > 3 files changed, 23 insertions(+), 14 deletions(-) Thanks! Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> --

RE: [PATCH 6/6] staging: comedi: don't use mutex when polling file

On Friday, October 09, 2015 4:27 AM, Ian Abbott wrote: > The main mutex in a comedi device can get held for quite a while when > processing comedi instructions, so for performance reasons, the "read" > and "write" file operations do not use it; they use use the > `attach_lock` rwsemaphore to

RE: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro

On Wednesday, November 18, 2015 9:42 AM, Ian Abbott wrote: > On 16/11/15 17:18, Ranjith Thangavel wrote: [snip] >> -#define DMM32AT_AI_CFG_SCINT_20US (0 << 4) >> -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4) >> -#define DMM32AT_AI_CFG_SCINT_10US (2 << 4) >> -#define DMM32AT_AI_CFG_SCINT_5US

RE: [PATCH] staging: comedi: comedi_usb.c: improve function documentation

On Wednesday, September 30, 2015 9:37 AM, Ian Abbott wrote: > Expand the descriptions of the functions and document the return values. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> -- To unsubscribe from thi

RE: [PATCH] staging: comedi: comedi_pci.c: Fix kernel-doc Return tags

On Wednesday, September 30, 2015 8:44 AM, Ian Abbott wrote: > Fix the 'Return' tags in the kernel-doc comments as they currently say > 'Returns', which is not recognized by kernel-doc. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> Reviewed-by: H Hartley Sweeten <hswee..

RE: [PATCH] staging: comedi: comedi_pcmcia.c: improve function documentation

On Wednesday, September 30, 2015 9:11 AM, Ian Abbott wrote: > Expand the descriptions of the functions and document the return values. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> -- To unsubscribe from thi

RE: [PATCH] staging: comedi: comedi_fops.c: Tweak kernel-doc for consistency

eturn values sections. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

RE: [PATCH 00/11] staging: comedi: comedidev.h: Documentation changes

changed, 516 insertions(+), 101 deletions(-) Thanks, Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH 0/2] staging: comedi: comedi_buf.c: Documentation changes

- > 1 file changed, 88 insertions(+), 18 deletions(-) Thanks, Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH] staging: comedi: comedi_pci.c: improve function documentation

On Wednesday, September 23, 2015 11:36 AM, Ian Abbott wrote: > Expand the descriptions of the functions and document the return values. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> Thanks, Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> -- To unsubscribe

RE: [PATCH 1/8] staging: comedi: rearrange comedi_write() code

On Wednesday, November 18, 2015 10:55 AM, Ian Abbott wrote: > Rearrange the code in `comedi_write()` to reduce the amount of > indentation. The code never reiterates the `while` loop once `count` > has become non-zero, so we can check that in the `while` condition to > save an indentation level.

RE: [PATCH 0/2] staging: comedi: s526: add counter register macros

replace counter mode bitfield struct > 2) staging: comedi: s526: add macros for counter control reg values > > drivers/staging/comedi/drivers/s526.c | 197 > ++ > 1 file changed, 130 insertions(+), 67 deletions(-) Thanks! This one has bugged me.

RE: [PATCH 0/8] staging: comedi: some comedi_write() changes

letions(-) Ian, Other than the minor nit-pick in patch 1 about the 'count == 0' when becoming non-busy (the same situation is in comedi_read), this looks good to me. It also makes the 'write' look more like the 'read'. Thanks, Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.c

RE: [PATCH 5/5] Staging: comedi: Prefer using the BIT macro issue in dmm32at.c

On Tuesday, June 07, 2016 4:51 AM, Ravishankar Karkala Mallikarjunayya wrote: > Subject: [PATCH 5/5] Staging: comedi: Prefer using the BIT macro issue in > dmm32at.c Please don't add random patches to a series. You started this series with 1/4, 2/4, 3/4 and 4/4 then added a 5/5. Also, please

RE: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue

On Friday, June 17, 2016 9:02 PM, Greg KH wrote: >> The patch looks fine (although this odd-ball Comedi driver shouldn't really >> be sending signals to a user-space task!). > > Yeah, that's really odd, fixing that would be nice... This is the last addi-data driver that does this. It's on my list

RE: [PATCH 4/5] rtc: m48t86: move m48t86.h to platform_data

On Sunday, June 26, 2016 3:03 PM, Alexandre Belloni wrote: > m48t86.h belongs to include/linux/platform_data/ > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> > --- > Cc: Hartley Sweeten <hswee...@visionengravers.com> > Cc: Ryan Mallon <r

RE: [PATCH 2/2] STAGING: COMEDI: Wrap line over 80 characters

On Monday, February 01, 2016 5:26 AM, Ian Abbott wrote: > On 01/02/16 01:06, Pablo G. Gallardo wrote: >> This patch wraps lines over 80 characters. >> >> Signed-off-by: Pablo G. Gallardo >> --- >> drivers/staging/comedi/comedi_pcmcia.h | 3 ++- >> 1 file changed, 2

RE: [PATCH] staging/comedi/dt282x: avoid integer overflow warning

On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote: > gcc-6 warns about passing negative signed integer into swab16() > in the dt282x driver: > The warning makes sense, though the code is correct as far as I > can tell. > > This disambiguates the operation by making the constant expressions

RE: [PATCH] staging/comedi/dt282x: avoid integer overflow warning

On Tuesday, March 15, 2016 2:50 PM, Arnd Bergmann wrote: > On Tuesday 15 March 2016 21:35:40 Hartley Sweeten wrote: >> On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote: >>> gcc-6 warns about passing negative signed integer into swab16() >>> in the dt282x driver:

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 3:41 AM, Ian Abbott wrote: > On 06/04/16 10:41, Ian Abbott wrote: >> On 06/04/16 02:21, Hartley Sweeten wrote: >>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>>> The variable unipolar was never used. >>&g

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: > The variable unipolar was never used. > > Signed-off-by: Sudip Mukherjee > --- > > There may be a chance that reading from DAS1800_CONTROL_C is necessary > before reading from DAS1800_STATUS. If that is

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukher

RE: [PATCH v2] staging/comedi/dt282x: avoid integer overflow warning

t; This disambiguates the operation by making the constant expressions > we pass here explicitly 'unsigned', which helps to avoid the warning. > > As pointed out by Hartley Sweeten, scripts/checkpatch.pl notices that > the shifts here are rather unreadable, though the suggested BIT() > m

RE: [PATCH] staging: comedi: drivers: remove bogus ni_mio_c_common.c

s/staging/comedi/drivers/ni_mio_c_common.c > deleted file mode 100644 > index e69de29..000 Weird. Good catch. Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>

RE: [PATCH v2] staging/comedi/dt282x: avoid integer overflow warning

On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote: > On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote: >> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote: >> >> Is this a gcc-6 specific issue? Seems line this warning should be showing >> up in a

RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro

di: comedi.h: Fix comment for struct comedi_krange > > drivers/staging/comedi/comedi.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Thanks for fixing this. I noticed the same issue yesterday. Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>

RE: [PATCH 04/20] staging: comedi: drivers: re-do macros for PLX PCI 9080 LASxRR values

On Friday, May 20, 2016 10:18 AM, Ian Abbott wrote: > On 20/05/16 17:37, Hartley Sweeten wrote: >> On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: >>> Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in >>> "plx9080.h", using the prefix

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> _REG_ format. Personally I prefer the format to b

RE: [PATCH v2 06/14] staging: comedi: daqboard2000: rename register offset macros

On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> > Reviewed-by: H Hartley Sweeten <hswee...@visionengr

RE: [PATCH v2 12/14] staging: comedi: daqboard2000: rename reference DACs register macros

On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros that define values for the reference DACs register to > avoid CamelCase, and to make it clearer which register they are > associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value > `0x80` that triggers setting

RE: [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset macros

On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> > Reviewed-by: H Hartley Sweeten <hswee...@visionengr

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros in "plx9080.h" that define the offsets of registers, > following the pattern `PLX_REG_`, where `` is the register > name from the PLX PCI 9080 Data Book. > > Add defines for the "Mailbox" registers, and add parameterized macros

RE: [PATCH 04/20] staging: comedi: drivers: re-do macros for PLX PCI 9080 LASxRR values

On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in > "plx9080.h", using the prefix `PLX_LASRR_`. Make use of the `BIT(x)` > and `GENMASK(h,l)` macros to define the values. > > Define a macro `PLX_LASRR_PREFETCH` for the

RE: [PATCH 05/14] staging: comedi: daqboard2000: rename serial EEPROM register macros

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining values for the Serial EEPROM Control Register > to avoid CamelCase. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/drivers/daqboard2000.c | 26 +- > 1 file

RE: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Remove some commented out code. Some of it uses constructs that don't > exist in the driver, and probably come from the source code for the MS > Windows driver. > > Signed-off-by: Ian Abbott > --- >

RE: [PATCH 06/14] staging: comedi: daqboard2000: rename register offset macros

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > --- > Other CamelCase issues in this patch will be dealt with by later >

RE: [PATCH 14/14] staging: comedi: daqboard2000: prefer usleep_range()

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > The checkpatch.pl warns about two `udelay(x)` calls, one of 100 > microseconds, and one of 10 microseconds. The 100 microseconds one is > used when waiting for FPGA to become ready to accept firmware, and is > not that critical, so replace it

RE: [PATCH 00/14] staging: comedi: daqboard2000: checkpatch clean-ups

ons(-) Ian, I had a couple comments on patches 1, 5, 6, and 14 but they are really just nitpicks. If you prefer to leave this series as-is: Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> Thanks for going through this one, it's annoyed me... Hartley

RE: [PATCH] staging: comedi: ni_mio_common: fix AO inttrig backwards compatibility

G_EXT); +* in that case, the internal trigger is being used as a pre-trigger +* before the external trigger. +*/ + if (cmd->start_src == TRIG_INT && trig_num != cmd->start_arg) return -EINVAL; But, either way: Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> Thanks!

RE: [PATCH RESEND] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

rious reboot. > > Do not pull ts72xx.h, but instead locally define what we need to disable > the watchdog. > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> > --- > Arnd, this is a recent, so you can queue this up, thanks! Reviewed-by: H Hartley Sweeten <hswee..

RE: [PATCH 2/2] watchdog: ts72xx_wdt: convert driver to watchdog core

On Monday, January 30, 2017 12:02 PM, Guenter Roeck wrote: > On Mon, Jan 30, 2017 at 09:55:48AM -0700, H Hartley Sweeten wrote: >> Cleanup this driver and convert it to use the watchdog framework API. >> >> Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com

RE: [PATCH 1/2] watchdog: ep93xx_wdt: cleanup and let the core handle the heartbeat

On Monday, January 30, 2017 11:55 AM, Guenter Roeck wrote: > On Mon, Jan 30, 2017 at 09:55:47AM -0700, H Hartley Sweeten wrote: >> Cleanup this driver and remove the 200ms heartbeat timer. The core now >> has the ability to handle the heartbeat. >> >> Signed-off-b

RE: [PATCH 02/35] ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn

CLK, open drain has no effect\n"); > + pr_warn("scl != EECLK, open drain has no effect\n"); > > __raw_writel((data->sda_is_open_drain << 1) | >(data->scl_is_open_drain << 0), For the ep93xx part: Acked-by: H Hartley Sweeten <hswee...@visionengravers.com>

RE: [PATCH 2/2] FPGA: Add TS-7300 FPGA manager

On Monday, December 12, 2016 9:02 AM, Alan Tull wrote: > On Sun, 11 Dec 2016, Florian Fainelli wrote: >> Add support for loading bitstreams on the Altera Cyclone II FPGA >> populated on the TS-7300 board. This is done through the configuration >> and data registers offered through a memory

RE: [PATCH] drivers: staging: comedi: fix function prototypes

On Thursday, December 15, 2016 4:47 AM, Ian Abbott wrote: > On 14/12/16 16:14, Hartley Sweeten wrote: >> On December 14, 2016 6:42 AM, Piotr Gregor wrote: >>> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); >>> +struct pci_dev *comedi_to_pci_de

RE: [PATCH] drivers: staging: comedi: fix function prototypes

; > Looks good, thanks! > > Reviewed-by: Ian Abbott <abbo...@mev.co.uk> Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>

<    1   2   3   4   5   6   7   8   9   10   >