Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

lways prefer a > non-weak definition over the weak one, independent of link order. > > Fixes: 688b744d8bc8 ("kgdb: fix signedness mixmatches, add statics, add > declaration to header") > Signed-off-by: Bjorn Helgaas > CC: Harvey Harrison Reviewed-by: Harvey Har

Re: [PATCH v1 08/10] kgdb: Remove weak from kgdb_arch_pc() declaration

, independent of link order. Fixes: 688b744d8bc8 (kgdb: fix signedness mixmatches, add statics, add declaration to header) Signed-off-by: Bjorn Helgaas bhelg...@google.com CC: Harvey Harrison harvey.harri...@gmail.com Reviewed-by: Harvey Harrison harvey.harri...@gmail.com This was likely simply an error

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 12:50:31 -0400 > Nick Krause wrote: > >> I am have this discussion with other kernel developers and just >> because I send out one patch as a newbie like this doesn't mean I >> don't known C. > > It's not just one

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt rost...@goodmis.org wrote: On Thu, 24 Jul 2014 12:50:31 -0400 Nick Krause xerofo...@gmail.com wrote: I am have this discussion with other kernel developers and just because I send out one patch as a newbie like this doesn't mean I don't known

Re: [PATCH 7/8] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s

On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones wrote: > > The aim is to make the code that little more readable. > > Signed-off-by: Lee Jones > --- > > #define MAX(a, b) (((a) < (b)) ? (b) : (a)) Not part of your patch, but probably a good idea to switch to the generic MAX macro, this one is

Re: [PATCH 7/8] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 x)'s

On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones lee.jo...@linaro.org wrote: The aim is to make the code that little more readable. Signed-off-by: Lee Jones lee.jo...@linaro.org --- #define MAX(a, b) (((a) (b)) ? (b) : (a)) Not part of your patch, but probably a good idea to switch to the

Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

On Wed, Mar 6, 2013 at 4:32 PM, Viresh Kumar wrote: > clk[cluster] = clk_get_sys(name, NULL); > - if (!IS_ERR(clk[cluster])) { > + if (!IS_ERR_OR_NULL(clk[cluster])) { > pr_debug("%s: clk: %p & freq table: %p, cluster: %d\n", >

Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

On Wed, Mar 6, 2013 at 4:32 PM, Viresh Kumar viresh.ku...@linaro.org wrote: clk[cluster] = clk_get_sys(name, NULL); - if (!IS_ERR(clk[cluster])) { + if (!IS_ERR_OR_NULL(clk[cluster])) { pr_debug(%s: clk: %p freq table: %p, cluster: %d\n,

[PATCH] cifs: remove GLOBAL_EXTERN macro

) Remove GLOBAL_EXTERN Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Steven, here is a revised patch that has a bit more thought behind it. fs/cifs/cifsfs.c | 31 - fs/cifs/cifsglob.h | 76 2 files chang

[PATCH] fbcon: replace mono_col macro with static inline

-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/video/console/fbcon.h | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/video/console/fbcon.h b/drivers/video/console/fbcon.h index 3706307..51a6bf4 100644 --- a/drivers/video/console/fbcon.h

[PATCH] fbcon: replace mono_col macro with static inline

-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/video/console/fbcon.h | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/video/console/fbcon.h b/drivers/video/console/fbcon.h index 3706307..51a6bf4 100644 --- a/drivers/video/console/fbcon.h +++ b

[PATCH] cifs: remove GLOBAL_EXTERN macro

) Remove GLOBAL_EXTERN Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Steven, here is a revised patch that has a bit more thought behind it. fs/cifs/cifsfs.c | 31 - fs/cifs/cifsglob.h | 76 2 files changed, 64

[PATCH] radeon: fix integer as NULL pointer warnings in radeon_mem.c

: Using plain integer as NULL pointer drivers/char/drm/radeon_mem.c:177:53: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/drm/radeon_mem.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH] video: add a clamp() macro to kernel.h and replace two existing defs

Clamps a value to be within a given range with strict typechecking. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- akpm: I've submitted a clamp_t version previously for use in libata. You may want to just roll this into that one so clamp/clamp_t go in together. drivers/media/video

[PATCH] md: fix integer as NULL pointer warnings in md.c

drivers/md/md.c:734:16: warning: Using plain integer as NULL pointer drivers/md/md.c:1115:16: warning: Using plain integer as NULL pointer Add some braces to match the else-block as well. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/md/md.c |8 1 files chan

[PATCH] smack: fix integer as NULL pointer warning in smack_lsm.c

security/smack/smack_lsm.c:1257:16: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- security/smack/smack_lsm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/security/smack/smack_lsm.c b/security/smack/smack

[PATCH 6/6] block: fix shadowed variable warning in blk-map.c

Introduced between 2.6.25-rc2 and -rc3 block/blk-map.c:154:14: warning: symbol 'bio' shadows an earlier one block/blk-map.c:110:13: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- block/blk-map.c |6 +++--- 1 files changed, 3 insertions(+), 3 del

[PATCH 4/6] smack: make functions static

-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- security/smack/smackfs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 358c92c..cb26951 100644 --- a/security/smack/smackfs.c +++ b/security/smack/sma

[PATCH 3/6] agp: fix shadowed variable warning in amd-k7-agp.c

Introduced between 2.6.25-rc2 and -rc3 drivers/char/agp/amd-k7-agp.c:439:6: warning: symbol 'cap_ptr' shadows an earlier one drivers/char/agp/amd-k7-agp.c:414:5: originally declared here cap_ptr is never used again in this function, don't bother redeclaring. Signed-off-by: Harvey Harrison

[PATCH 5/6] block: remove extern on function definition

Intoduced between 2.6.25-rc2 and -rc3 block/blk-settings.c:319:12: warning: function 'blk_queue_dma_drain' with external linkage has definition Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- block/blk-settings.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 1/6] markers: make marker_debug static

Introduced between 2.6.25-rc2 and -rc3 kernel/marker.c:31:11: warning: symbol 'marker_debug' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/marker.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/mark

[PATCH 2/6] xen: make blkif_getgeo static

Introduced between 2.6.25-rc2 and -rc3 drivers/block/xen-blkfront.c:139:5: warning: symbol 'blkif_getgeo' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/block/xen-blkfront.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 1/6] markers: make marker_debug static

Introduced between 2.6.25-rc2 and -rc3 kernel/marker.c:31:11: warning: symbol 'marker_debug' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- kernel/marker.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/marker.c b

[PATCH 2/6] xen: make blkif_getgeo static

Introduced between 2.6.25-rc2 and -rc3 drivers/block/xen-blkfront.c:139:5: warning: symbol 'blkif_getgeo' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/block/xen-blkfront.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 3/6] agp: fix shadowed variable warning in amd-k7-agp.c

Introduced between 2.6.25-rc2 and -rc3 drivers/char/agp/amd-k7-agp.c:439:6: warning: symbol 'cap_ptr' shadows an earlier one drivers/char/agp/amd-k7-agp.c:414:5: originally declared here cap_ptr is never used again in this function, don't bother redeclaring. Signed-off-by: Harvey Harrison

[PATCH 5/6] block: remove extern on function definition

Intoduced between 2.6.25-rc2 and -rc3 block/blk-settings.c:319:12: warning: function 'blk_queue_dma_drain' with external linkage has definition Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- block/blk-settings.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 6/6] block: fix shadowed variable warning in blk-map.c

Introduced between 2.6.25-rc2 and -rc3 block/blk-map.c:154:14: warning: symbol 'bio' shadows an earlier one block/blk-map.c:110:13: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- block/blk-map.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 4/6] smack: make functions static

-off-by: Harvey Harrison [EMAIL PROTECTED] --- security/smack/smackfs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 358c92c..cb26951 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c

[PATCH] smack: fix integer as NULL pointer warning in smack_lsm.c

security/smack/smack_lsm.c:1257:16: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- security/smack/smack_lsm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index

[PATCH] md: fix integer as NULL pointer warnings in md.c

drivers/md/md.c:734:16: warning: Using plain integer as NULL pointer drivers/md/md.c:1115:16: warning: Using plain integer as NULL pointer Add some braces to match the else-block as well. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/md/md.c |8 1 files changed, 4

[PATCH] video: add a clamp() macro to kernel.h and replace two existing defs

Clamps a value to be within a given range with strict typechecking. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- akpm: I've submitted a clamp_t version previously for use in libata. You may want to just roll this into that one so clamp/clamp_t go in together. drivers/media/video/bt8xx

[PATCH] radeon: fix integer as NULL pointer warnings in radeon_mem.c

: Using plain integer as NULL pointer drivers/char/drm/radeon_mem.c:177:53: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/drm/radeon_mem.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char

[PATCHv2 2/2] char: fix possible double-unlock in esp.c

ock Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/esp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/esp.c b/drivers/char/esp.c index 01fbddd..0a33d09 100644 --- a/drivers/char/esp.c +++ b/drivers/char/esp.c @@ -2030,10 +2030,10

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

[PATCH 2/2] char: fix possible double-unlock in specialix.c

Noticed by sparse, trivial to see: drivers/char/specialix.c:2112:3: warning: context imbalance in 'sx_throttle' - unexpected unlock Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- And with the torrent of warnings fixed, here we find a double-unlock. drivers/char/specialix.c |

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

[PATCH] char: static functions and integer as NULL pointer fixes in epca.c

' was not declared. Should it be static? drivers/char/epca.c:2881:12: warning: symbol 'init_PCI' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/epca.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/ep

[PATCH] char: fix sparse shadowed variable warnings in cyclades.c

/char/cyclades.c:2750:7: warning: symbol '_y' shadows an earlier one drivers/char/cyclades.c:2750:7: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/cyclades.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH] char: fix sparse variable shadowing and int as NULL pointer in rocket.c

pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/rocket.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c index 72f2892..2778d64 100644 --- a/drivers/char/rocket.c +++ b/drivers/char/ro

[PATCH 2/2] char: fix possible double-unlock in esp.c

ock Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/esp.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/char/esp.c b/drivers/char/esp.c index 01fbddd..2b14814 100644 --- a/drivers/char/esp.c +++ b/drivers/char/esp.c @@ -2030,16

[PATCH 1/2] char: fix sparse shadowed variable warnings in esp.c

an earlier one drivers/char/esp.c:1517:16: originally declared here drivers/char/esp.c:1631:17: warning: symbol 'flags' shadows an earlier one drivers/char/esp.c:1517:16: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/esp.c |6 -- 1 files chan

[PATCH 1/2] char: fix sparse shadowed variable warnings in esp.c

an earlier one drivers/char/esp.c:1517:16: originally declared here drivers/char/esp.c:1631:17: warning: symbol 'flags' shadows an earlier one drivers/char/esp.c:1517:16: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/esp.c |6 -- 1 files changed, 0

[PATCH 2/2] char: fix possible double-unlock in esp.c

Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/esp.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/char/esp.c b/drivers/char/esp.c index 01fbddd..2b14814 100644 --- a/drivers/char/esp.c +++ b/drivers/char/esp.c @@ -2030,16 +2030,17 @@ static

[PATCH] char: fix sparse variable shadowing and int as NULL pointer in rocket.c

pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/rocket.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c index 72f2892..2778d64 100644 --- a/drivers/char/rocket.c +++ b/drivers/char/rocket.c

[PATCH] char: fix sparse shadowed variable warnings in cyclades.c

/char/cyclades.c:2750:7: warning: symbol '_y' shadows an earlier one drivers/char/cyclades.c:2750:7: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/cyclades.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/cyclades.c

[PATCH] char: static functions and integer as NULL pointer fixes in epca.c

' was not declared. Should it be static? drivers/char/epca.c:2881:12: warning: symbol 'init_PCI' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/epca.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/epca.c b

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

[PATCH 2/2] char: fix possible double-unlock in specialix.c

Noticed by sparse, trivial to see: drivers/char/specialix.c:2112:3: warning: context imbalance in 'sx_throttle' - unexpected unlock Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- And with the torrent of warnings fixed, here we find a double-unlock. drivers/char/specialix.c |1 - 1

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

[PATCHv2 2/2] char: fix possible double-unlock in esp.c

Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/esp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/esp.c b/drivers/char/esp.c index 01fbddd..0a33d09 100644 --- a/drivers/char/esp.c +++ b/drivers/char/esp.c @@ -2030,10 +2030,10 @@ static void

Re: linux-next: first tree

On Thu, 2008-02-21 at 16:12 -0800, Randy Dunlap wrote: > Frank Seidel wrote: > > Randy Dunlap wrote: > >> I'd like to see tarballs too, please... > > > > Hi, i'll provide tars of the current linux-next tree reachable > > via my http://linux-next.f-seidel.de wiki ("Tar Downloads"). > > Is that

Re: [PATCH] saa7146: fix sparse warnings

On Thu, 2008-02-21 at 21:19 +, Al Viro wrote: > On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote: > > Could you please use more descriptive names? NULL noise removal > is not the same as shadowing or endianness annotations or endianness > fixes or __user/__io

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 21:29 +0100, Johannes Berg wrote: > > Clean, or did you specifically mean bitwise-clean? > > bitwise-clean. But I don't do full-mac drivers so most of what you quote > I don't compile, and the mac80211-based drivers only have few problems. > This wasn't meant as any sort

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 21:09 +0100, Johannes Berg wrote: > > > In any case, I would love to have __CHECK_ENDIAN__ enabled by default at > > > least on the wireless code (just caught another bug with it...) > > > > I should then add support for something like: > > > > checkflags-y :=

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 13:42 +0100, Johannes Berg wrote: > >> [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the > >> net/mac80211/Makefile] > > > I would prefer it to be kernel wide enabled. > > Tried a defconfig build. > > Hm. I tend to think there was a reason for this, since this is

[PATCH] eicon: fix sparse integer as NULL pointer warnings

/eicon/message.c:9147:16: warning: Using plain integer as NULL pointer drivers/isdn/hardware/eicon/message.c:9173:14: warning: Using plain integer as NULL pointer drivers/isdn/hardware/eicon/divasmain.c:396:23: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EM

[PATCH] avm: fix sparse warning using integer as NULL pointer

drivers/isdn/hardware/avm/c4.c:1294:37: warning: Using plain integer as NULL pointer drivers/isdn/hardware/avm/c4.c:1296:33: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/isdn/hardware/avm/b1.c | 10 +- driver

[PATCH] capi: fix sparse warnings using integer as NULL pointer

/capidrv.c:2341:33: warning: Using plain integer as NULL pointer drivers/isdn/capi/capifs.c:192:37: warning: Using plain integer as NULL pointer drivers/isdn/capi/capifs.c:194:33: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/isd

[PATCH] saa7146: fix sparse warnings

/saa7146_fops.c:275:12: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/media/common/saa7146_core.c |8 drivers/media/common/saa7146_fops.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/d

[PATCH] saa7146: fix sparse warnings

/saa7146_fops.c:275:12: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/media/common/saa7146_core.c |8 drivers/media/common/saa7146_fops.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media

[PATCH] capi: fix sparse warnings using integer as NULL pointer

/capidrv.c:2341:33: warning: Using plain integer as NULL pointer drivers/isdn/capi/capifs.c:192:37: warning: Using plain integer as NULL pointer drivers/isdn/capi/capifs.c:194:33: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/isdn/capi

[PATCH] avm: fix sparse warning using integer as NULL pointer

drivers/isdn/hardware/avm/c4.c:1294:37: warning: Using plain integer as NULL pointer drivers/isdn/hardware/avm/c4.c:1296:33: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/isdn/hardware/avm/b1.c | 10 +- drivers/isdn

[PATCH] eicon: fix sparse integer as NULL pointer warnings

/eicon/message.c:9147:16: warning: Using plain integer as NULL pointer drivers/isdn/hardware/eicon/message.c:9173:14: warning: Using plain integer as NULL pointer drivers/isdn/hardware/eicon/divasmain.c:396:23: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 13:42 +0100, Johannes Berg wrote: [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the net/mac80211/Makefile] I would prefer it to be kernel wide enabled. Tried a defconfig build. Hm. I tend to think there was a reason for this, since this is actually explicitly

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 21:09 +0100, Johannes Berg wrote: In any case, I would love to have __CHECK_ENDIAN__ enabled by default at least on the wireless code (just caught another bug with it...) I should then add support for something like: checkflags-y := -D__CHECK_ENDIAN__ to

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 21:29 +0100, Johannes Berg wrote: Clean, or did you specifically mean bitwise-clean? bitwise-clean. But I don't do full-mac drivers so most of what you quote I don't compile, and the mac80211-based drivers only have few problems. This wasn't meant as any sort of

Re: [PATCH] saa7146: fix sparse warnings

On Thu, 2008-02-21 at 21:19 +, Al Viro wrote: On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote: Could you please use more descriptive names? NULL noise removal is not the same as shadowing or endianness annotations or endianness fixes or __user/__iomem annotations/fixes

Re: linux-next: first tree

On Thu, 2008-02-21 at 16:12 -0800, Randy Dunlap wrote: Frank Seidel wrote: Randy Dunlap wrote: I'd like to see tarballs too, please... Hi, i'll provide tars of the current linux-next tree reachable via my http://linux-next.f-seidel.de wiki (Tar Downloads). Is that what you were

acpi: new sparse warnings in 2.6.25-rc2

Introduced between 2.6.25-rc1 and -rc2. drivers/acpi/executer/exregion.c:369:8: warning: incorrect type in argument 3 (different type sizes) drivers/acpi/executer/exregion.c:369:8:expected unsigned int [usertype] *value drivers/acpi/executer/exregion.c:369:8:got unsigned long long

[PATCH] markers: fix sparse warnings in markers.c

char can be unsigned kernel/marker.c:64:20: error: dubious one-bit signed bitfield kernel/marker.c:65:14: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Introduced between -rc1 and -rc2 kernel/marker.c |4 ++-- 1 files changed, 2 inse

Re: [PATCH 1/2] moxa: make functions static

On Thu, 2008-02-21 at 00:12 +0100, Jiri Slaby wrote: > On 02/20/2008 11:14 PM, Harvey Harrison wrote: > > All were forward declared static already. > > > Thanks, but I have similar fixes for both issues you address in my tree. I'll > post it in few days. Great. Harvey -

Re: sparse - make __CHECK_ENDIAN__ default enabled?

On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: > Hi Harvey. > > Can I ask you to look into the worst offenders so we > can make -D__CHECK_ENDIAN__ enabled per default > in the kernel. > Or maybe we should do it anyway? >From a quick test, the same places that spew sparse warnings, spew

Re: sparse - make __CHECK_ENDIAN__ default enabled?

On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: > Hi Harvey. > > Can I ask you to look into the worst offenders so we > can make -D__CHECK_ENDIAN__ enabled per default > in the kernel. > Or maybe we should do it anyway? Well, I've got the worst of fs and drivers/ata done so far, still

[PATCH 2/2] moxa: fix sparse warnings

drivers/char/moxa.c:873:26: warning: Using plain integer as NULL pointer drivers/char/moxa.c:2037:49: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/moxa.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 1/2] moxa: make functions static

'MoxaPortSendBreak' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/moxa.c | 52 +- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/char/moxa.c b/drivers/char/moxa.c index 6

[PATCH] char: make functions static in synclinkmp.c

'write_control_reg' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/synclinkmp.c | 120 ++-- 1 files changed, 60 insertions(+), 60 deletions(-) diff --git a/drivers/char/synclinkmp.c b/driver

[PATCH] nfs: fix sparse warnings

/callback_xdr.c:270:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:281:6: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Rollup patches 1-4. fs/nfs/callback_xdr.c |6 +++--- fs/nfs/delegation.c |2 +- fs/nfs/i

[PATCH 1/2] nfsd: fix sparse warnings

: warning: symbol 'idtoname_parse' was not declared. Should it be static? fs/nfsd/vfs.c:1156:1: warning: symbol 'nfsd_create_setattr' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfsd/auth.c|1 + fs/nfsd/nfs4idmap.c |2

[PATCH 2/2] nfsd: fix sparse warning in vfs.c

fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfsd/vfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 0265310..17ac51b 100644 --- a/fs/nfsd/vfs.c

[PATCH 4/4] nfs: fix sparse warnings in callback_xdr.c

fs/nfs/callback_xdr.c:257:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:270:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:281:6: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> ---

[PATCH 3/4] nfs: fix sparse warning in idmap.c

fs/nfs/idmap.c:312:12: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfs/idmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index 8ae5dba..86147b0 100644 --- a/fs/nfs/i

[PATCH 2/4] nfs: fix sparse warning in delegation.c

fs/nfs/delegation.c:52:34: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfs/delegation.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c index b9eadd1..00a5e44

[PATCH 1/4] nfs: fix sparse warning in nfs4state.c

fs/nfs/nfs4state.c:788:34: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfs/nfs4state.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index 6233eb5..b962397

[PATCH] ata: use clamp_t macro to avoid sparse warnings

Nesting min_t/max_t macros produces many shadowed variable warnings due to use of __x. Add a clamp_t macro to linux/kernel.h and use it in the FIT macro. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/linux/kernel.h |9 + include/linux/libata.h |2 +- 2

[PATCH] ata: use clamp_t macro to avoid sparse warnings

Nesting min_t/max_t macros produces many shadowed variable warnings due to use of __x. Add a clamp_t macro to linux/kernel.h and use it in the FIT macro. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- include/linux/kernel.h |9 + include/linux/libata.h |2 +- 2 files

[PATCH 1/4] nfs: fix sparse warning in nfs4state.c

fs/nfs/nfs4state.c:788:34: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/nfs/nfs4state.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index 6233eb5..b962397 100644 --- a/fs

[PATCH 2/4] nfs: fix sparse warning in delegation.c

fs/nfs/delegation.c:52:34: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/nfs/delegation.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c index b9eadd1..00a5e44 100644

[PATCH 3/4] nfs: fix sparse warning in idmap.c

fs/nfs/idmap.c:312:12: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/nfs/idmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index 8ae5dba..86147b0 100644 --- a/fs/nfs/idmap.c

[PATCH 4/4] nfs: fix sparse warnings in callback_xdr.c

fs/nfs/callback_xdr.c:257:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:270:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:281:6: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/nfs/callback_xdr.c

[PATCH 1/2] nfsd: fix sparse warnings

: warning: symbol 'idtoname_parse' was not declared. Should it be static? fs/nfsd/vfs.c:1156:1: warning: symbol 'nfsd_create_setattr' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/nfsd/auth.c|1 + fs/nfsd/nfs4idmap.c |2 +- fs

[PATCH 2/2] nfsd: fix sparse warning in vfs.c

fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/nfsd/vfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 0265310..17ac51b 100644 --- a/fs/nfsd/vfs.c +++ b/fs

[PATCH] nfs: fix sparse warnings

/callback_xdr.c:270:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:281:6: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Rollup patches 1-4. fs/nfs/callback_xdr.c |6 +++--- fs/nfs/delegation.c |2 +- fs/nfs/idmap.c

[PATCH] char: make functions static in synclinkmp.c

'write_control_reg' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/synclinkmp.c | 120 ++-- 1 files changed, 60 insertions(+), 60 deletions(-) diff --git a/drivers/char/synclinkmp.c b/drivers/char/synclinkmp.c

[PATCH 1/2] moxa: make functions static

'MoxaPortSendBreak' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/moxa.c | 52 +- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/char/moxa.c b/drivers/char/moxa.c index 64b7b2b

[PATCH 2/2] moxa: fix sparse warnings

drivers/char/moxa.c:873:26: warning: Using plain integer as NULL pointer drivers/char/moxa.c:2037:49: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/moxa.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: sparse - make __CHECK_ENDIAN__ default enabled?

On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: Hi Harvey. Can I ask you to look into the worst offenders so we can make -D__CHECK_ENDIAN__ enabled per default in the kernel. Or maybe we should do it anyway? Well, I've got the worst of fs and drivers/ata done so far, still weeping

Re: sparse - make __CHECK_ENDIAN__ default enabled?

On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: Hi Harvey. Can I ask you to look into the worst offenders so we can make -D__CHECK_ENDIAN__ enabled per default in the kernel. Or maybe we should do it anyway? From a quick test, the same places that spew sparse warnings, spew lots

Re: [PATCH 1/2] moxa: make functions static

On Thu, 2008-02-21 at 00:12 +0100, Jiri Slaby wrote: On 02/20/2008 11:14 PM, Harvey Harrison wrote: All were forward declared static already. Thanks, but I have similar fixes for both issues you address in my tree. I'll post it in few days. Great. Harvey -- To unsubscribe from

acpi: new sparse warnings in 2.6.25-rc2

Introduced between 2.6.25-rc1 and -rc2. drivers/acpi/executer/exregion.c:369:8: warning: incorrect type in argument 3 (different type sizes) drivers/acpi/executer/exregion.c:369:8:expected unsigned int [usertype] *value drivers/acpi/executer/exregion.c:369:8:got unsigned long long

[PATCH] markers: fix sparse warnings in markers.c

char can be unsigned kernel/marker.c:64:20: error: dubious one-bit signed bitfield kernel/marker.c:65:14: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Introduced between -rc1 and -rc2 kernel/marker.c |4 ++-- 1 files changed, 2 insertions(+), 2

  1   2   3   4   5   6   7   8   >