Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-03 Thread Heiko Carstens
> > > We're piece-wise enabling rseq across architectures anyway, and when the > > > relevant maintains do this, they can have a look at their > > > {get,put}_user() implementations and fix them. > > > > > > If you rely on get_user(u64) working, that means microblaze is already > > > broken, but

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-03 Thread Heiko Carstens
On Tue, Jul 03, 2018 at 10:14:49AM +0200, Peter Zijlstra wrote: > On Mon, Jul 02, 2018 at 10:30:09PM -0400, Mathieu Desnoyers wrote: > > > Use "get_user()". It works for 64-bit objects too, and it will be > > > atomic in the 32-bit sub-parts on a 32-bit architecture. > > > > Is it really ? Last

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-03 Thread Heiko Carstens
On Tue, Jul 03, 2018 at 10:14:49AM +0200, Peter Zijlstra wrote: > On Mon, Jul 02, 2018 at 10:30:09PM -0400, Mathieu Desnoyers wrote: > > > Use "get_user()". It works for 64-bit objects too, and it will be > > > atomic in the 32-bit sub-parts on a 32-bit architecture. > > > > Is it really ? Last

Re: Restartable Sequences system call merged into Linux

2018-06-13 Thread Heiko Carstens
On Mon, Jun 11, 2018 at 03:49:18PM -0400, Mathieu Desnoyers wrote: > Hi! > > Good news! The restartable sequences (rseq) system call is now merged into > the master > branch of the Linux kernel within the 4.18 merge window: > >

Re: Restartable Sequences system call merged into Linux

2018-06-13 Thread Heiko Carstens
On Mon, Jun 11, 2018 at 03:49:18PM -0400, Mathieu Desnoyers wrote: > Hi! > > Good news! The restartable sequences (rseq) system call is now merged into > the master > branch of the Linux kernel within the 4.18 merge window: > >

Re: [PATCH v2 10/10] vfio: ccw: Let user wait when busy on IO

2018-05-25 Thread Heiko Carstens
On Fri, May 25, 2018 at 12:21:18PM +0200, Pierre Morel wrote: > In the current implementation, we do not want to start a new SSCH > command before the last one ends. > > Currently the user needs to poll on the -EBUSY error to > wait before sending a new request. > > Let's be friendly with global

Re: [PATCH v2 10/10] vfio: ccw: Let user wait when busy on IO

2018-05-25 Thread Heiko Carstens
On Fri, May 25, 2018 at 12:21:18PM +0200, Pierre Morel wrote: > In the current implementation, we do not want to start a new SSCH > command before the last one ends. > > Currently the user needs to poll on the -EBUSY error to > wait before sending a new request. > > Let's be friendly with global

Re: [bisected] 051f3ca02e46 "Introduce NUMA identity node sched domain" breaks fake NUMA on s390

2018-05-14 Thread Heiko Carstens
On Mon, May 14, 2018 at 11:39:09AM +0200, Peter Zijlstra wrote: > On Sat, May 12, 2018 at 12:02:33PM +0200, Heiko Carstens wrote: > > Hello, > > > > Andre Wild reported that fake NUMA doesn't work on s390 anymore. Doesn't > > work means it crashed for Andre, or it i

Re: [bisected] 051f3ca02e46 "Introduce NUMA identity node sched domain" breaks fake NUMA on s390

2018-05-14 Thread Heiko Carstens
On Mon, May 14, 2018 at 11:39:09AM +0200, Peter Zijlstra wrote: > On Sat, May 12, 2018 at 12:02:33PM +0200, Heiko Carstens wrote: > > Hello, > > > > Andre Wild reported that fake NUMA doesn't work on s390 anymore. Doesn't > > work means it crashed for Andre, or it i

[bisected] 051f3ca02e46 "Introduce NUMA identity node sched domain" breaks fake NUMA on s390

2018-05-12 Thread Heiko Carstens
Hello, Andre Wild reported that fake NUMA doesn't work on s390 anymore. Doesn't work means it crashed for Andre, or it is in an endless loop within init_sched_groups_capacity() for me (sg != sd->groups is always true). I could reproduce this with a very simple setup with only two nodes, where

[bisected] 051f3ca02e46 "Introduce NUMA identity node sched domain" breaks fake NUMA on s390

2018-05-12 Thread Heiko Carstens
Hello, Andre Wild reported that fake NUMA doesn't work on s390 anymore. Doesn't work means it crashed for Andre, or it is in an endless loop within init_sched_groups_capacity() for me (sg != sd->groups is always true). I could reproduce this with a very simple setup with only two nodes, where

Re: [PATCH] s390: remove no-op macro VMLINUX_SYMBOL()

2018-05-09 Thread Heiko Carstens
On Wed, May 09, 2018 at 04:51:39PM +0900, Masahiro Yamada wrote: > VMLINUX_SYMBOL() is no-op unless CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX > is defined. It has ever been selected only by BLACKFIN and METAG. > VMLINUX_SYMBOL() is unneeded for s390-specific code. > > Signed-off-by: Masahiro Yamada

Re: [PATCH] s390: remove no-op macro VMLINUX_SYMBOL()

2018-05-09 Thread Heiko Carstens
On Wed, May 09, 2018 at 04:51:39PM +0900, Masahiro Yamada wrote: > VMLINUX_SYMBOL() is no-op unless CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX > is defined. It has ever been selected only by BLACKFIN and METAG. > VMLINUX_SYMBOL() is unneeded for s390-specific code. > > Signed-off-by: Masahiro Yamada

Re: [PATCH v3 04/17] y2038: s390: Remove unneeded ipc uapi header files

2018-04-20 Thread Heiko Carstens
ode 100644 arch/s390/include/uapi/asm/msgbuf.h > delete mode 100644 arch/s390/include/uapi/asm/sembuf.h > delete mode 100644 arch/s390/include/uapi/asm/shmbuf.h FWIW, Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com>

Re: [PATCH v3 04/17] y2038: s390: Remove unneeded ipc uapi header files

2018-04-20 Thread Heiko Carstens
clude/uapi/asm/msgbuf.h > delete mode 100644 arch/s390/include/uapi/asm/sembuf.h > delete mode 100644 arch/s390/include/uapi/asm/shmbuf.h FWIW, Acked-by: Heiko Carstens

[GIT PULL] s390 updates for 4.16 merge window

2018-02-09 Thread Heiko Carstens
): s390/cmf: fix kerneldoc s390/docs: mention subchannel types s390/docs: reword airq section Heiko Carstens (2): s390/runtime instrumentation: provide uapi header file s390/runtime_instrumentation: re-add signum system call parameter Hendrik Brueckner (2): s390

[GIT PULL] s390 updates for 4.16 merge window

2018-02-09 Thread Heiko Carstens
): s390/cmf: fix kerneldoc s390/docs: mention subchannel types s390/docs: reword airq section Heiko Carstens (2): s390/runtime instrumentation: provide uapi header file s390/runtime_instrumentation: re-add signum system call parameter Hendrik Brueckner (2): s390

Re: [PATCH 08/20] s390/kconfig: Remove ARCH_WANTS_PROT_NUMA_PROT_NONE select

2018-02-04 Thread Heiko Carstens
On Mon, Feb 05, 2018 at 02:21:20AM +0100, Ulf Magnusson wrote: > The ARCH_WANTS_PROT_NUMA_PROT_NONE symbol was removed by > commit 6a33979d5bd7 ("mm: remove misleading ARCH_USES_NUMA_PROT_NONE"), > but S390 still selects it. > > Remove the ARCH_WANTS_PROT_NUMA_PROT_NONE select from the S390

Re: [PATCH 08/20] s390/kconfig: Remove ARCH_WANTS_PROT_NUMA_PROT_NONE select

2018-02-04 Thread Heiko Carstens
On Mon, Feb 05, 2018 at 02:21:20AM +0100, Ulf Magnusson wrote: > The ARCH_WANTS_PROT_NUMA_PROT_NONE symbol was removed by > commit 6a33979d5bd7 ("mm: remove misleading ARCH_USES_NUMA_PROT_NONE"), > but S390 still selects it. > > Remove the ARCH_WANTS_PROT_NUMA_PROT_NONE select from the S390

Re: [PATCH 8/8] kprobes/s390: Fix %p uses in error messages

2018-01-27 Thread Heiko Carstens
On Thu, Jan 25, 2018 at 02:30:32PM +0900, Masami Hiramatsu wrote: > Remove %p because the kprobe will be dumped in > dump_kprobe(). > > Signed-off-by: Masami Hiramatsu > --- > arch/s390/kernel/kprobes.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 8/8] kprobes/s390: Fix %p uses in error messages

2018-01-27 Thread Heiko Carstens
On Thu, Jan 25, 2018 at 02:30:32PM +0900, Masami Hiramatsu wrote: > Remove %p because the kprobe will be dumped in > dump_kprobe(). > > Signed-off-by: Masami Hiramatsu > --- > arch/s390/kernel/kprobes.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 4/6] s390: add system call to run tasks with modified branch prediction

2018-01-17 Thread Heiko Carstens
On Wed, Jan 17, 2018 at 12:55:06PM +0100, Martin Schwidefsky wrote: > On Wed, 17 Jan 2018 12:14:52 +0100 > Christian Borntraeger wrote: > > > On 01/17/2018 11:03 AM, Florian Weimer wrote: > > > On 01/17/2018 10:48 AM, Martin Schwidefsky wrote: > > >> rc =

Re: [PATCH 4/6] s390: add system call to run tasks with modified branch prediction

2018-01-17 Thread Heiko Carstens
On Wed, Jan 17, 2018 at 12:55:06PM +0100, Martin Schwidefsky wrote: > On Wed, 17 Jan 2018 12:14:52 +0100 > Christian Borntraeger wrote: > > > On 01/17/2018 11:03 AM, Florian Weimer wrote: > > > On 01/17/2018 10:48 AM, Martin Schwidefsky wrote: > > >> rc = syscall(__NR_s390_modify_bp);

Re: [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls

2018-01-15 Thread Heiko Carstens
On Mon, Jan 15, 2018 at 08:38:17PM +0100, Eugene Syromiatnikov wrote: > For some reason, the implementation of some 16-bit ID system calls > (namely, setuid16/setgid16 and setfsuid16/setfsgid16) used type cast > instead of low2highgid/low2highuid macros for converting [GU]IDs, which > led to

Re: [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls

2018-01-15 Thread Heiko Carstens
On Mon, Jan 15, 2018 at 08:38:17PM +0100, Eugene Syromiatnikov wrote: > For some reason, the implementation of some 16-bit ID system calls > (namely, setuid16/setgid16 and setfsuid16/setfsgid16) used type cast > instead of low2highgid/low2highuid macros for converting [GU]IDs, which > led to

Re: [PATCH] s390: fix setgid16/setuid16 handling of -1

2018-01-15 Thread Heiko Carstens
On Mon, Jan 15, 2018 at 12:52:42PM +0100, Eugene Syromiatnikov wrote: > For some reason, the implementation of these two 16-bit ID system calls > used cast instead of low2highgid/low2highuid macros for converting [GU]IDs, > which leads to incorrect handling of value of -1 (which ought to be >

Re: [PATCH] s390: fix setgid16/setuid16 handling of -1

2018-01-15 Thread Heiko Carstens
On Mon, Jan 15, 2018 at 12:52:42PM +0100, Eugene Syromiatnikov wrote: > For some reason, the implementation of these two 16-bit ID system calls > used cast instead of low2highgid/low2highuid macros for converting [GU]IDs, > which leads to incorrect handling of value of -1 (which ought to be >

Re: [PATCH 0/3] S390-DASD: Fine-tuning for some function implementations

2017-12-14 Thread Heiko Carstens
On Thu, Dec 14, 2017 at 11:34:01AM +0100, SF Markus Elfring wrote: > > Date: Wed, 10 May 2017 19:43:21 +0200 > > > > A few update suggestions were taken into account > > from static source code analysis. > > > > Markus Elfring (3): > > Adjust buffer output in dasd_hosts_print() > > Fix typos

Re: [PATCH 0/3] S390-DASD: Fine-tuning for some function implementations

2017-12-14 Thread Heiko Carstens
On Thu, Dec 14, 2017 at 11:34:01AM +0100, SF Markus Elfring wrote: > > Date: Wed, 10 May 2017 19:43:21 +0200 > > > > A few update suggestions were taken into account > > from static source code analysis. > > > > Markus Elfring (3): > > Adjust buffer output in dasd_hosts_print() > > Fix typos

Re: [PATCH 39/45] arch/s390: remove duplicate includes

2017-12-14 Thread Heiko Carstens
On Sun, Dec 10, 2017 at 11:56:57PM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Signed-off-by: Pravin Shedge > --- >

Re: [PATCH 39/45] arch/s390: remove duplicate includes

2017-12-14 Thread Heiko Carstens
On Sun, Dec 10, 2017 at 11:56:57PM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Signed-off-by: Pravin Shedge > --- > arch/s390/kernel/kprobes.c | 1 - > 1 file

Re: [PATCH] s390/decompressor: add fortify_panic as x86 has.

2017-12-13 Thread Heiko Carstens
our console driver. If that would ever trigger the result would be an endless loop (error() would call the console driver again). This would repeat until we hit an addressing exception or code gets overwritten due to the ever increasing stack. At some point we simply have to trust the code. That

Re: [PATCH] s390/decompressor: add fortify_panic as x86 has.

2017-12-13 Thread Heiko Carstens
ss loop (error() would call the console driver again). This would repeat until we hit an addressing exception or code gets overwritten due to the ever increasing stack. At some point we simply have to trust the code. That's also why I disabled FORTIFY_SOURCE for a couple of other files which contain

Re: [PATCH] fs/proc/kcore.c: use probe_kernel_read() instead of memcpy()

2017-12-07 Thread Heiko Carstens
On Wed, Dec 06, 2017 at 04:43:50PM -0800, Andrew Morton wrote: > On Sat, 2 Dec 2017 14:27:39 +0100 Heiko Carstens <heiko.carst...@de.ibm.com> > wrote: > > > git commit df04abfd181a ("fs/proc/kcore.c: Add bounce buffer for ktext > > data") added a bou

Re: [PATCH] fs/proc/kcore.c: use probe_kernel_read() instead of memcpy()

2017-12-07 Thread Heiko Carstens
On Wed, Dec 06, 2017 at 04:43:50PM -0800, Andrew Morton wrote: > On Sat, 2 Dec 2017 14:27:39 +0100 Heiko Carstens > wrote: > > > git commit df04abfd181a ("fs/proc/kcore.c: Add bounce buffer for ktext > > data") added a bounce buffer to avoid hardened usercopy &g

Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption

2017-12-06 Thread Heiko Carstens
On Wed, Dec 06, 2017 at 08:44:53AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 07:15:34PM +0100, Heiko Carstens wrote: > > On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Dec 05, 2017 at 05:02:32PM +, Ben Hutchings wrote: >

Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption

2017-12-06 Thread Heiko Carstens
On Wed, Dec 06, 2017 at 08:44:53AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 07:15:34PM +0100, Heiko Carstens wrote: > > On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Dec 05, 2017 at 05:02:32PM +, Ben Hutchings wrote: >

Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption

2017-12-06 Thread Heiko Carstens
On Wed, Dec 06, 2017 at 08:44:53AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 07:15:34PM +0100, Heiko Carstens wrote: > > On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Dec 05, 2017 at 05:02:32PM +, Ben Hutchings wrote: >

Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption

2017-12-06 Thread Heiko Carstens
On Wed, Dec 06, 2017 at 08:44:53AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 07:15:34PM +0100, Heiko Carstens wrote: > > On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Dec 05, 2017 at 05:02:32PM +, Ben Hutchings wrote: >

Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption

2017-12-05 Thread Heiko Carstens
let me > > > know. > > > > > > ------ > > > > > > From: Heiko Carstens <heiko.carst...@de.ibm.com> > > > > > > commit d6e646ad7cfa7034d280459b2b2546288f247144 upstream. > > [...] > > > --- a/arch/s

Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption

2017-12-05 Thread Heiko Carstens
let me > > > know. > > > > > > ------ > > > > > > From: Heiko Carstens > > > > > > commit d6e646ad7cfa7034d280459b2b2546288f247144 upstream. > > [...] > > > --- a/arch/s390/kernel/runtime_instr.c > >

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-12-04 Thread Heiko Carstens
On Mon, Dec 04, 2017 at 10:19:28PM +0100, Thomas Gleixner wrote: > +3. Syntax: > + > + A is either an SPDX short form license > + identifier found on the SPDX License List, or when multiple licenses > + apply, an expression consisting of keywords "AND", "OR", and "WITH" > + separating

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-12-04 Thread Heiko Carstens
On Mon, Dec 04, 2017 at 10:19:28PM +0100, Thomas Gleixner wrote: > +3. Syntax: > + > + A is either an SPDX short form license > + identifier found on the SPDX License List, or when multiple licenses > + apply, an expression consisting of keywords "AND", "OR", and "WITH" > + separating

Re: maxcpus confusion

2017-12-04 Thread Heiko Carstens
On Fri, Dec 01, 2017 at 12:58:47PM -0800, Randy Dunlap wrote: > Hi, > > I used "maxcpus=1" on a recent x86 boot (4.15-rc1) and got 4 CPUs (all of > them AFAICT). When I use "nr_cpus=1", I do get a hard limit of one CPU. > > > A few boot log excerpts: > > [0.00] smpboot: Allowing 8

Re: maxcpus confusion

2017-12-04 Thread Heiko Carstens
On Fri, Dec 01, 2017 at 12:58:47PM -0800, Randy Dunlap wrote: > Hi, > > I used "maxcpus=1" on a recent x86 boot (4.15-rc1) and got 4 CPUs (all of > them AFAICT). When I use "nr_cpus=1", I do get a hard limit of one CPU. > > > A few boot log excerpts: > > [0.00] smpboot: Allowing 8

[PATCH] fs/proc/kcore.c: use probe_kernel_read() instead of memcpy()

2017-12-02 Thread Heiko Carstens
daa ("mm: Hardened usercopy") Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> --- fs/proc/kcore.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index 4bc85cb8be6a..e8a93bc8285d 100644 --- a/

[PATCH] fs/proc/kcore.c: use probe_kernel_read() instead of memcpy()

2017-12-02 Thread Heiko Carstens
daa ("mm: Hardened usercopy") Signed-off-by: Heiko Carstens --- fs/proc/kcore.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index 4bc85cb8be6a..e8a93bc8285d 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c

Re: [PATCH 0/2] Fix boot regression for s390 and remove break_lock

2017-12-02 Thread Heiko Carstens
On Tue, Nov 28, 2017 at 06:42:17PM +, Will Deacon wrote: > Hi all, > > The following two patches do the following: > > 1. Fix boot breakage reported on s390 caused by a8a217c22116 > 2. Kill off the break_lock field entirely, since it's not actually > that useful > > I didn't go the

Re: [PATCH 0/2] Fix boot regression for s390 and remove break_lock

2017-12-02 Thread Heiko Carstens
On Tue, Nov 28, 2017 at 06:42:17PM +, Will Deacon wrote: > Hi all, > > The following two patches do the following: > > 1. Fix boot breakage reported on s390 caused by a8a217c22116 > 2. Kill off the break_lock field entirely, since it's not actually > that useful > > I didn't go the

Re: [PATCH v3] s390/virtio: add BSD license to virtio-ccw

2017-11-29 Thread Heiko Carstens
On Tue, Nov 28, 2017 at 02:51:19PM +0100, Cornelia Huck wrote: > On Tue, 28 Nov 2017 15:17:52 +0200 > "Michael S. Tsirkin" wrote: > > > The original intent of the virtio header relicensing > > from 2008 was to make sure anyone can implement compatible > > devices/drivers. The

Re: [PATCH v3] s390/virtio: add BSD license to virtio-ccw

2017-11-29 Thread Heiko Carstens
On Tue, Nov 28, 2017 at 02:51:19PM +0100, Cornelia Huck wrote: > On Tue, 28 Nov 2017 15:17:52 +0200 > "Michael S. Tsirkin" wrote: > > > The original intent of the virtio header relicensing > > from 2008 was to make sure anyone can implement compatible > > devices/drivers. The virtio-ccw was

Re: [FIX] perf tools broken for s/390

2017-11-29 Thread Heiko Carstens
On Tue, Nov 28, 2017 at 11:46:11AM -0300, Arnaldo Carvalho de Melo wrote: > Hi, > > While preparing a pull request to Ingo for this merge window, I > noticed a regression in one of my cross build containers, specifically: > > ubuntu:16.04-x-s390: FAIL > > LINK

Re: [FIX] perf tools broken for s/390

2017-11-29 Thread Heiko Carstens
On Tue, Nov 28, 2017 at 11:46:11AM -0300, Arnaldo Carvalho de Melo wrote: > Hi, > > While preparing a pull request to Ingo for this merge window, I > noticed a regression in one of my cross build containers, specifically: > > ubuntu:16.04-x-s390: FAIL > > LINK

Re: [PATCH v2 2/2] s390/virtio: add BSD license to virtio-ccw

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 07:02:41PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 24, 2017 at 05:53:01PM +0100, Heiko Carstens wrote: > > > > Is there any reason to add the whole BSD 3 clause license text? I'd > > > > prefer > > > > if it would be just the s

Re: [PATCH v2 2/2] s390/virtio: add BSD license to virtio-ccw

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 07:02:41PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 24, 2017 at 05:53:01PM +0100, Heiko Carstens wrote: > > > > Is there any reason to add the whole BSD 3 clause license text? I'd > > > > prefer > > > > if it would be just the s

Re: [PATCH v2 2/2] s390/virtio: add BSD license to virtio-ccw

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 06:21:11PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 24, 2017 at 03:09:18PM +0100, Heiko Carstens wrote: > > On Fri, Nov 24, 2017 at 07:21:09AM +0200, Michael S. Tsirkin wrote: > > > The original intent of the virtio header relicensing > > >

Re: [PATCH v2 2/2] s390/virtio: add BSD license to virtio-ccw

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 06:21:11PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 24, 2017 at 03:09:18PM +0100, Heiko Carstens wrote: > > On Fri, Nov 24, 2017 at 07:21:09AM +0200, Michael S. Tsirkin wrote: > > > The original intent of the virtio header relicensing > > >

Re: [PATCH v2 2/2] s390/virtio: add BSD license to virtio-ccw

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 07:21:09AM +0200, Michael S. Tsirkin wrote: > The original intent of the virtio header relicensing > from 2008 was to make sure anyone can implement compatible > devices/drivers. The virtio-ccw was omitted by mistake. > > We have an ack from the only contributor as well as

Re: [PATCH v2 2/2] s390/virtio: add BSD license to virtio-ccw

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 07:21:09AM +0200, Michael S. Tsirkin wrote: > The original intent of the virtio header relicensing > from 2008 was to make sure anyone can implement compatible > devices/drivers. The virtio-ccw was omitted by mistake. > > We have an ack from the only contributor as well as

Re: [PATCH 0/9] drivers/s390/ license text cleanup

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 12:45:41PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 24, 2017 at 12:23:39PM +0100, Heiko Carstens wrote: > > On Tue, Nov 14, 2017 at 06:37:59PM +0100, Greg Kroah-Hartman wrote: > > > Hi all, > > > > > > Here are 9 patches again

Re: [PATCH 0/9] drivers/s390/ license text cleanup

2017-11-24 Thread Heiko Carstens
On Fri, Nov 24, 2017 at 12:45:41PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 24, 2017 at 12:23:39PM +0100, Heiko Carstens wrote: > > On Tue, Nov 14, 2017 at 06:37:59PM +0100, Greg Kroah-Hartman wrote: > > > Hi all, > > > > > > Here are 9 patches again

Re: [PATCH 0/9] drivers/s390/ license text cleanup

2017-11-24 Thread Heiko Carstens
On Tue, Nov 14, 2017 at 06:37:59PM +0100, Greg Kroah-Hartman wrote: > Hi all, > > Here are 9 patches against linux-next of today that add SPDX identifiers > to the remaining files that do not currently have them, and then it > cleans up the various different ways that the license text boilerplate

Re: [PATCH 0/9] drivers/s390/ license text cleanup

2017-11-24 Thread Heiko Carstens
On Tue, Nov 14, 2017 at 06:37:59PM +0100, Greg Kroah-Hartman wrote: > Hi all, > > Here are 9 patches against linux-next of today that add SPDX identifiers > to the remaining files that do not currently have them, and then it > cleans up the various different ways that the license text boilerplate

Re: [PATCH v1] mm: relax deferred struct page requirements

2017-11-16 Thread Heiko Carstens
with CONFIG_MEMORY_HOTPLUG disabled. > > Signed-off-by: Pavel Tatashin <pasha.tatas...@oracle.com> > --- > arch/powerpc/Kconfig | 1 - > arch/s390/Kconfig| 1 - > arch/x86/Kconfig | 1 - > mm/Kconfig | 7 +-- > 4 files changed, 1 insertion(+)

Re: [PATCH v1] mm: relax deferred struct page requirements

2017-11-16 Thread Heiko Carstens
with CONFIG_MEMORY_HOTPLUG disabled. > > Signed-off-by: Pavel Tatashin > --- > arch/powerpc/Kconfig | 1 - > arch/s390/Kconfig| 1 - > arch/x86/Kconfig | 1 - > mm/Kconfig | 7 +-- > 4 files changed, 1 insertion(+), 9 deletions(-) For s390 the s390 bit: Acked-by: Heiko Carstens

Re: [PATCH 3/3] zfcp: drop open coded assignments of timer_list.function

2017-11-16 Thread Heiko Carstens
On Thu, Nov 16, 2017 at 01:38:18PM +0100, Steffen Maier wrote: > If this has not been picked/merged yet (it's not in Linus' tree yet), > could you please drop it because it's buggy? > > This would buy me time to come up with a proper solution, > otherwise I would be forced to fix it within

Re: [PATCH 3/3] zfcp: drop open coded assignments of timer_list.function

2017-11-16 Thread Heiko Carstens
On Thu, Nov 16, 2017 at 01:38:18PM +0100, Steffen Maier wrote: > If this has not been picked/merged yet (it's not in Linus' tree yet), > could you please drop it because it's buggy? > > This would buy me time to come up with a proper solution, > otherwise I would be forced to fix it within

Re: [PATCH 5/9] s390: net: add SPDX identifiers to the remaining files

2017-11-14 Thread Heiko Carstens
dmann <j...@linux.vnet.ibm.com> > Cc: Ursula Braun <ubr...@linux.vnet.ibm.com> > Cc: Martin Schwidefsky <schwidef...@de.ibm.com> > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Kate Stewart <kstew...@linuxfo

Re: [PATCH 5/9] s390: net: add SPDX identifiers to the remaining files

2017-11-14 Thread Heiko Carstens
nn > Cc: Ursula Braun > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman > --- > diff --git a/drivers/s390/net/fsm.c b/drivers/s390/net/fsm.c > index 8c14c6c3ad3d..

Re: [GIT PULL] locking changes for v4.15

2017-11-13 Thread Heiko Carstens
On Mon, Nov 13, 2017 at 12:42:44PM -0800, Linus Torvalds wrote: > On Sun, Nov 12, 2017 at 11:31 PM, Ingo Molnar wrote: > > > > Please pull the latest locking-core-for-linus git tree from: > > Ok, this clashed pretty badly with the s390 update which had big > locking changes to

Re: [GIT PULL] locking changes for v4.15

2017-11-13 Thread Heiko Carstens
On Mon, Nov 13, 2017 at 12:42:44PM -0800, Linus Torvalds wrote: > On Sun, Nov 12, 2017 at 11:31 PM, Ingo Molnar wrote: > > > > Please pull the latest locking-core-for-linus git tree from: > > Ok, this clashed pretty badly with the s390 update which had big > locking changes to use the generic

[GIT PULL] s390 updates for v4.15

2017-11-12 Thread Heiko Carstens
pt: Enable special header file flag for AU CPRP s390/zcrypt: Introduce QACT support for AP bus devices. s390/archrandom: Reconsider s390 arch random implementation s390/zcrypt: Rework struct ap_qact_ap_info. Heiko Carstens (31): s390: convert release_thread() into a sta

[GIT PULL] s390 updates for v4.15

2017-11-12 Thread Heiko Carstens
pt: Enable special header file flag for AU CPRP s390/zcrypt: Introduce QACT support for AP bus devices. s390/archrandom: Reconsider s390 arch random implementation s390/zcrypt: Rework struct ap_qact_ap_info. Heiko Carstens (31): s390: convert release_thread() into a sta

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Heiko Carstens
On Wed, Nov 08, 2017 at 06:59:21PM +0200, Michael S. Tsirkin wrote: > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > well. The s390 ones need to be BSD as well. > > Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi > header files with a

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Heiko Carstens
On Wed, Nov 08, 2017 at 06:59:21PM +0200, Michael S. Tsirkin wrote: > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > well. The s390 ones need to be BSD as well. > > Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi > header files with a

Re: [tip:x86/fpu] bitops: Add clear/set_bit32() to linux/bitops.h

2017-11-05 Thread Heiko Carstens
On Tue, Oct 17, 2017 at 09:21:46AM -0700, tip-bot for Andi Kleen wrote: > Commit-ID: cbe96375025e14fc76f9ed42ee5225120d7210f8 > Gitweb: > https://git.kernel.org/tip/cbe96375025e14fc76f9ed42ee5225120d7210f8 > Author: Andi Kleen > AuthorDate: Fri, 13 Oct 2017

Re: [tip:x86/fpu] bitops: Add clear/set_bit32() to linux/bitops.h

2017-11-05 Thread Heiko Carstens
On Tue, Oct 17, 2017 at 09:21:46AM -0700, tip-bot for Andi Kleen wrote: > Commit-ID: cbe96375025e14fc76f9ed42ee5225120d7210f8 > Gitweb: > https://git.kernel.org/tip/cbe96375025e14fc76f9ed42ee5225120d7210f8 > Author: Andi Kleen > AuthorDate: Fri, 13 Oct 2017 14:56:41 -0700 > Committer:

[PATCH] s390/mm: fix pud table accounting

2017-11-03 Thread Heiko Carstens
e is no "mm->nr_pmds" anymore. Cc: Kirill A. Shutemov <kirill.shute...@linux.intel.com> Cc: Michal Hocko <mho...@suse.com> Cc: Gerald Schaefer <gerald.schae...@de.ibm.com> Cc: Martin Schwidefsky <schwidef...@de.ibm.com> Signed-off-by: Heiko Carstens <heiko.carst

[PATCH] s390/mm: fix pud table accounting

2017-11-03 Thread Heiko Carstens
e is no "mm->nr_pmds" anymore. Cc: Kirill A. Shutemov Cc: Michal Hocko Cc: Gerald Schaefer Cc: Martin Schwidefsky Signed-off-by: Heiko Carstens --- arch/s390/include/asm/mmu_context.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/s390/include/asm/mmu_c

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Heiko Carstens
On Sat, Sep 30, 2017 at 12:36:12PM +0200, Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens <heiko.carst...@de.ibm.com> wrote: > > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > > Similar to __down_write_killable(

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Heiko Carstens
On Sat, Sep 30, 2017 at 12:36:12PM +0200, Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens wrote: > > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > > Similar to __down_write_killable(), and read killable primitive.

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Heiko Carstens
On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > Similar to __down_write_killable(), and read killable primitive. > > Signed-off-by: Kirill Tkhai > --- > arch/s390/include/asm/rwsem.h | 18 -- > 1 file changed, 16 insertions(+), 2

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Heiko Carstens
On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > Similar to __down_write_killable(), and read killable primitive. > > Signed-off-by: Kirill Tkhai > --- > arch/s390/include/asm/rwsem.h | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] s390/char: Fix cdev_add usage

2017-09-18 Thread Heiko Carstens
On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote: > Function cdev_add does set cdev->dev, so there is no point in setting > it prior to calling this function. > > Signed-off-by: Jean Delvare <jdelv...@suse.de> > Cc: Martin Schwidefsky <schwidef...@de.ib

Re: [PATCH v2] s390/char: Fix cdev_add usage

2017-09-18 Thread Heiko Carstens
On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote: > Function cdev_add does set cdev->dev, so there is no point in setting > it prior to calling this function. > > Signed-off-by: Jean Delvare > Cc: Martin Schwidefsky > Cc: Heiko Carstens > --- > Untested

Re: [PATCH] samples/kprobes: Add s390 case in kprobe example module

2017-09-15 Thread Heiko Carstens
On Thu, Sep 14, 2017 at 02:11:15PM +0200, Johannes Thumshirn wrote: > Add info prints in sample kprobe handlers for S/390 > > Signed-off-by: Johannes Thumshirn > --- > samples/kprobes/kprobe_example.c | 8 > 1 file changed, 8 insertions(+) Applied, thanks!

Re: [PATCH] samples/kprobes: Add s390 case in kprobe example module

2017-09-15 Thread Heiko Carstens
On Thu, Sep 14, 2017 at 02:11:15PM +0200, Johannes Thumshirn wrote: > Add info prints in sample kprobe handlers for S/390 > > Signed-off-by: Johannes Thumshirn > --- > samples/kprobes/kprobe_example.c | 8 > 1 file changed, 8 insertions(+) Applied, thanks!

Re: BUG: using __this_cpu_read() in preemptible [00000000] code: mm_percpu_wq/7

2017-08-16 Thread Heiko Carstens
Tejun, can you make any sense of the below? It _looks_ like a bug in the workqueue code. Andre's testcase is also doing cpu hotplug until we finally see a workqueue.c warning. On Wed, Jul 12, 2017 at 10:44:54AM -0500, Christopher Lameter wrote: > On Wed, 7 Jun 2017, Andre Wild wrote: > > > I'm

Re: BUG: using __this_cpu_read() in preemptible [00000000] code: mm_percpu_wq/7

2017-08-16 Thread Heiko Carstens
Tejun, can you make any sense of the below? It _looks_ like a bug in the workqueue code. Andre's testcase is also doing cpu hotplug until we finally see a workqueue.c warning. On Wed, Jul 12, 2017 at 10:44:54AM -0500, Christopher Lameter wrote: > On Wed, 7 Jun 2017, Andre Wild wrote: > > > I'm

Re: [RFT 00/13] constify s390 ccw_device_id

2017-08-15 Thread Heiko Carstens
On Tue, Aug 15, 2017 at 04:05:31PM +0530, Arvind Yadav wrote: > ccw_device_id are not supposed to change at runtime. All functions > working with ccw_device_id provided by work with > const ccw_device_id. So mark ccw_device_id member of struct ccw driver > as const. And change all driver

Re: [RFT 00/13] constify s390 ccw_device_id

2017-08-15 Thread Heiko Carstens
On Tue, Aug 15, 2017 at 04:05:31PM +0530, Arvind Yadav wrote: > ccw_device_id are not supposed to change at runtime. All functions > working with ccw_device_id provided by work with > const ccw_device_id. So mark ccw_device_id member of struct ccw driver > as const. And change all driver

Re: Fwd: struct pt_regs missing in /usr/include/ tree for eBPF program compile

2017-08-14 Thread Heiko Carstens
On Fri, Aug 04, 2017 at 05:28:38PM +0200, Daniel Borkmann wrote: > From: Thomas-Mich Richter > Date: Wed, Aug 2, 2017 at 1:22 AM > [...] > >I work on the perf tool and its bpf support for IBM s390 and came across a > >strange issue compiling

Re: Fwd: struct pt_regs missing in /usr/include/ tree for eBPF program compile

2017-08-14 Thread Heiko Carstens
On Fri, Aug 04, 2017 at 05:28:38PM +0200, Daniel Borkmann wrote: > From: Thomas-Mich Richter > Date: Wed, Aug 2, 2017 at 1:22 AM > [...] > >I work on the perf tool and its bpf support for IBM s390 and came across a > >strange issue compiling tools/testing/selftests/bpf/test_verifier.c on s390x. >

Re: [PATCH] s390/crypto: make cca_public_sec and cca_token_hdr const

2017-08-08 Thread Heiko Carstens
On Sun, Aug 06, 2017 at 11:22:27AM +0530, Bhumika Goyal wrote: > Declare cca_public_sec and cca_token_hdr structures as const as they are > only used during copy operations. > > Signed-off-by: Bhumika Goyal > --- > drivers/s390/crypto/zcrypt_cca_key.h | 6 +++--- > 1 file

Re: [PATCH] s390/crypto: make cca_public_sec and cca_token_hdr const

2017-08-08 Thread Heiko Carstens
On Sun, Aug 06, 2017 at 11:22:27AM +0530, Bhumika Goyal wrote: > Declare cca_public_sec and cca_token_hdr structures as const as they are > only used during copy operations. > > Signed-off-by: Bhumika Goyal > --- > drivers/s390/crypto/zcrypt_cca_key.h | 6 +++--- > 1 file changed, 3

Re: Re: drivers/s390/char/keyboard.c NULL pointer reference

2017-08-05 Thread Heiko Carstens
On Sat, Aug 05, 2017 at 09:44:45AM +0800, sohu0106 wrote: > > > I don't understand a bit,My idea is > > in userland > > fd=open("tty3270",O_RDONLY) > ... > ret=ioctl(fd,KDGKBDIACR,NULL) > ... > > then here > drivers/s390/char/keyboard.c > 477 > case KDGKBDIACR: > { >

Re: Re: drivers/s390/char/keyboard.c NULL pointer reference

2017-08-05 Thread Heiko Carstens
On Sat, Aug 05, 2017 at 09:44:45AM +0800, sohu0106 wrote: > > > I don't understand a bit,My idea is > > in userland > > fd=open("tty3270",O_RDONLY) > ... > ret=ioctl(fd,KDGKBDIACR,NULL) > ... > > then here > drivers/s390/char/keyboard.c > 477 > case KDGKBDIACR: > { >

Re: drivers/s390/char/keyboard.c NULL pointer reference

2017-08-04 Thread Heiko Carstens
On Thu, Aug 03, 2017 at 09:57:38PM +0800, sohu0106 wrote: > > > Local users able to send the NULL arg argument to kbd_ioctl(), which could > cause kernel crash > > > > > diff --git a/keyboard.c  > b/keyboard.c > index ba0e4f9..3ec16b1 100644 > --- a/keyboard.c > +++ b/keyboard.c > @@ -456,6

Re: drivers/s390/char/keyboard.c NULL pointer reference

2017-08-04 Thread Heiko Carstens
On Thu, Aug 03, 2017 at 09:57:38PM +0800, sohu0106 wrote: > > > Local users able to send the NULL arg argument to kbd_ioctl(), which could > cause kernel crash > > > > > diff --git a/keyboard.c  > b/keyboard.c > index ba0e4f9..3ec16b1 100644 > --- a/keyboard.c > +++ b/keyboard.c > @@ -456,6

Re: drivers/s390/char/keyboard.c kernel stack infoleak

2017-08-04 Thread Heiko Carstens
On Fri, Aug 04, 2017 at 11:09:24AM +0200, Thomas Huth wrote: > Hi, > > On 03.08.2017 15:59, sohu0106 wrote: > > > > The stack object "kbdiacr" has a total size of 4 bytes. Its last 1 bytes > > are padding bytes after "result" which are not initialized and leaked to > > userland via

<    1   2   3   4   5   6   7   8   9   10   >