[PATCH 2/2] drivers core: remove assert_held_device_hotplug()

2017-03-09 Thread Heiko Carstens
The last caller of assert_held_device_hotplug() is gone, so remove it again. Cc: Dan Williams Cc: Michal Hocko Cc: "Rafael J. Wysocki" Cc: Vladimir Davydov Cc: Ben Hutchings Cc: Gerald Schaefer Cc: Martin Schwidefsky Cc: Sebastian Ott Signed-off-by: Heiko Carstens --- dr

[PATCH 0/2] mm: add private lock to serialize memory hotplug operations

2017-03-09 Thread Heiko Carstens
These two patches are supposed to hopefully fix a memory hotplug problem reported by Sebastian Ott. Heiko Carstens (2): mm: add private lock to serialize memory hotplug operations drivers core: remove assert_held_device_hotplug() drivers/base/core.c| 5 - include/linux/device.h | 1

[PATCH 0/2] mm: add private lock to serialize memory hotplug operations

2017-03-09 Thread Heiko Carstens
These two patches are supposed to hopefully fix a memory hotplug problem reported by Sebastian Ott. Heiko Carstens (2): mm: add private lock to serialize memory hotplug operations drivers core: remove assert_held_device_hotplug() drivers/base/core.c| 5 - include/linux/device.h | 1

Re: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT

2017-03-09 Thread Heiko Carstens
On Wed, Mar 08, 2017 at 03:11:10PM +0100, Michal Hocko wrote: > On Wed 08-03-17 09:23:40, Heiko Carstens wrote: > > On Tue, Mar 07, 2017 at 04:48:40PM +0100, Michal Hocko wrote: > > > From: Michal Hocko <mho...@suse.com> > > > > > > __GFP_REPEAT has a

Re: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT

2017-03-09 Thread Heiko Carstens
On Wed, Mar 08, 2017 at 03:11:10PM +0100, Michal Hocko wrote: > On Wed 08-03-17 09:23:40, Heiko Carstens wrote: > > On Tue, Mar 07, 2017 at 04:48:40PM +0100, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > __GFP_REPEAT has a rather weak seman

Re: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT

2017-03-08 Thread Heiko Carstens
t;) has missed this one but the situation is very > same here. > > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> > Signed-off-by: Michal Hocko <mho...@suse.com> > --- > arch/s390/mm/pgalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) FWIW: Acked-b

Re: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT

2017-03-08 Thread Heiko Carstens
s one but the situation is very > same here. > > Cc: Heiko Carstens > Signed-off-by: Michal Hocko > --- > arch/s390/mm/pgalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) FWIW: Acked-by: Heiko Carstens If you want, this can be routed via the s390 tree, whatever you prefer.

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-03-06 Thread Heiko Carstens
Hello Dan, > > If you look at commit 5e33bc4165f3 ("driver core / ACPI: Avoid device hot > > remove locking issues") then lock_device_hotplug_sysfs() was introduced to > > avoid a different subtle deadlock, but it also sleeps uninterruptible, but > > not for more than 5ms ;) > > > > However I'm

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-03-06 Thread Heiko Carstens
Hello Dan, > > If you look at commit 5e33bc4165f3 ("driver core / ACPI: Avoid device hot > > remove locking issues") then lock_device_hotplug_sysfs() was introduced to > > avoid a different subtle deadlock, but it also sleeps uninterruptible, but > > not for more than 5ms ;) > > > > However I'm

Re: [PATCH 1/3] futex: remove duplicated code

2017-03-03 Thread Heiko Carstens
| 36 ++ Looks good to me and still boots on s390. Therefore for the s390 bits: Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com> Thanks!

Re: [PATCH 1/3] futex: remove duplicated code

2017-03-03 Thread Heiko Carstens
++ Looks good to me and still boots on s390. Therefore for the s390 bits: Acked-by: Heiko Carstens Thanks!

[BUG 4.9/4.10] crash in __d_lookup() due to corrupted dentry_hashtable

2017-03-03 Thread Heiko Carstens
Hello Al, Gustavo reported the crash below within __d_lookup() on s390. I'm wondering if you can make any sense of it: Unable to handle kernel pointer dereference in virtual kernel address space Failing address: f000 TEID: f803 Fault in home space mode while using kernel

[BUG 4.9/4.10] crash in __d_lookup() due to corrupted dentry_hashtable

2017-03-03 Thread Heiko Carstens
Hello Al, Gustavo reported the crash below within __d_lookup() on s390. I'm wondering if you can make any sense of it: Unable to handle kernel pointer dereference in virtual kernel address space Failing address: f000 TEID: f803 Fault in home space mode while using kernel

Re: [PATCHv2 00/14] set_memory_* functions header refactor

2017-03-02 Thread Heiko Carstens
ly go through the -mm tree so I'd like Acks where > appropriate. > > As always, feedback appreciated. For the s390 bits: Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com>

Re: [PATCHv2 00/14] set_memory_* functions header refactor

2017-03-02 Thread Heiko Carstens
ly go through the -mm tree so I'd like Acks where > appropriate. > > As always, feedback appreciated. For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-03-01 Thread Heiko Carstens
On Wed, Mar 01, 2017 at 07:52:18AM -0800, Dan Williams wrote: > On Wed, Mar 1, 2017 at 4:51 AM, Heiko Carstens > <heiko.carst...@de.ibm.com> wrote: > > Since it is anything but obvious why Dan wrote in changelog of b5d24fda9c3d > > ("mm, devm_memremap_pages:

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-03-01 Thread Heiko Carstens
On Wed, Mar 01, 2017 at 07:52:18AM -0800, Dan Williams wrote: > On Wed, Mar 1, 2017 at 4:51 AM, Heiko Carstens > wrote: > > Since it is anything but obvious why Dan wrote in changelog of b5d24fda9c3d > > ("mm, devm_memremap_pages: hold device_hotplug lock over >

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-03-01 Thread Heiko Carstens
On Tue, Feb 28, 2017 at 12:57:29PM +0100, Heiko Carstens wrote: > On Mon, Feb 27, 2017 at 05:20:31PM +0100, Michal Hocko wrote: > > [CC Rafael] > > > > I've got lost in the acpi indirection (again). I can see > > acpi_device_hotplug calling lock_device_hotplug() but i

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-03-01 Thread Heiko Carstens
On Tue, Feb 28, 2017 at 12:57:29PM +0100, Heiko Carstens wrote: > On Mon, Feb 27, 2017 at 05:20:31PM +0100, Michal Hocko wrote: > > [CC Rafael] > > > > I've got lost in the acpi indirection (again). I can see > > acpi_device_hotplug calling lock_device_hotplug() but i

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-02-28 Thread Heiko Carstens
On Mon, Feb 27, 2017 at 05:20:31PM +0100, Michal Hocko wrote: > [CC Rafael] > > I've got lost in the acpi indirection (again). I can see > acpi_device_hotplug calling lock_device_hotplug() but i cannot find a > path down to add_memory() which might call add_memory_resource. But the > patch below

Re: [PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-02-28 Thread Heiko Carstens
On Mon, Feb 27, 2017 at 05:20:31PM +0100, Michal Hocko wrote: > [CC Rafael] > > I've got lost in the acpi indirection (again). I can see > acpi_device_hotplug calling lock_device_hotplug() but i cannot find a > path down to add_memory() which might call add_memory_resource. But the > patch below

Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

2017-02-28 Thread Heiko Carstens
On Mon, Feb 27, 2017 at 04:43:04PM +0100, Michal Hocko wrote: > On Mon 27-02-17 12:25:10, Heiko Carstens wrote: > > On Mon, Feb 27, 2017 at 11:02:09AM +0100, Vitaly Kuznetsov wrote: > > > A couple of other thoughts: > > > 1) Having all newly added memory online A

Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

2017-02-28 Thread Heiko Carstens
On Mon, Feb 27, 2017 at 04:43:04PM +0100, Michal Hocko wrote: > On Mon 27-02-17 12:25:10, Heiko Carstens wrote: > > On Mon, Feb 27, 2017 at 11:02:09AM +0100, Vitaly Kuznetsov wrote: > > > A couple of other thoughts: > > > 1) Having all newly added memory online A

Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

2017-02-27 Thread Heiko Carstens
On Mon, Feb 27, 2017 at 11:02:09AM +0100, Vitaly Kuznetsov wrote: > A couple of other thoughts: > 1) Having all newly added memory online ASAP is probably what people > want for all virtual machines. This is not true for s390. On s390 we have "standby" memory that a guest sees and potentially may

Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

2017-02-27 Thread Heiko Carstens
On Mon, Feb 27, 2017 at 11:02:09AM +0100, Vitaly Kuznetsov wrote: > A couple of other thoughts: > 1) Having all newly added memory online ASAP is probably what people > want for all virtual machines. This is not true for s390. On s390 we have "standby" memory that a guest sees and potentially may

Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t

2017-02-20 Thread Heiko Carstens
On Mon, Feb 20, 2017 at 02:24:24PM +0100, Heiko Carstens wrote: > > @@ -361,7 +361,7 @@ debug_info_create(const char *name, int pages_per_area, > > int nr_areas, > > debug_area_last = rc; > > rc->next = NULL; > > > > - debug_info_get(

Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t

2017-02-20 Thread Heiko Carstens
On Mon, Feb 20, 2017 at 02:24:24PM +0100, Heiko Carstens wrote: > > @@ -361,7 +361,7 @@ debug_info_create(const char *name, int pages_per_area, > > int nr_areas, > > debug_area_last = rc; > > rc->next = NULL; > > > > - debug_info_get(

Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t

2017-02-20 Thread Heiko Carstens
On Mon, Feb 20, 2017 at 01:06:18PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t

2017-02-20 Thread Heiko Carstens
On Mon, Feb 20, 2017 at 01:06:18PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

Re: [PATCH 0/3] s390: audit and remove needless module.h includes

2017-02-12 Thread Heiko Carstens
On Thu, Feb 09, 2017 at 03:20:22PM -0500, Paul Gortmaker wrote: > Paul Gortmaker (3): > s390: kernel: Audit and remove any unnecessary uses of module.h > s390: mm: Audit and remove any unnecessary uses of module.h > s390: Audit and remove any remaining unnecessary uses of module.h Applied,

Re: [PATCH 0/3] s390: audit and remove needless module.h includes

2017-02-12 Thread Heiko Carstens
On Thu, Feb 09, 2017 at 03:20:22PM -0500, Paul Gortmaker wrote: > Paul Gortmaker (3): > s390: kernel: Audit and remove any unnecessary uses of module.h > s390: mm: Audit and remove any unnecessary uses of module.h > s390: Audit and remove any remaining unnecessary uses of module.h Applied,

Re: [RFC][PATCH] treewide: Move set_memory_* functions away from cacheflush.h

2017-02-09 Thread Heiko Carstens
100644 arch/arm64/include/asm/set_memory.h > create mode 100644 arch/s390/include/asm/set_memory.h > create mode 100644 arch/x86/include/asm/set_memory.h For s390: Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com>

Re: [RFC][PATCH] treewide: Move set_memory_* functions away from cacheflush.h

2017-02-09 Thread Heiko Carstens
ude/asm/set_memory.h > create mode 100644 arch/s390/include/asm/set_memory.h > create mode 100644 arch/x86/include/asm/set_memory.h For s390: Acked-by: Heiko Carstens

Re: [PATCHv3 1/2] arch: Move CONFIG_DEBUG_RODATA and CONFIG_SET_MODULE_RONX to be common

2017-02-07 Thread Heiko Carstens
/parisc/Kconfig.debug | 11 -- > arch/s390/Kconfig | 5 ++--- > arch/s390/Kconfig.debug| 3 --- > arch/x86/Kconfig | 5 ++--- > arch/x86/Kconfig.debug | 11 -- > 13 files changed, 51

Re: [PATCHv3 1/2] arch: Move CONFIG_DEBUG_RODATA and CONFIG_SET_MODULE_RONX to be common

2017-02-07 Thread Heiko Carstens
> arch/s390/Kconfig | 5 ++--- > arch/s390/Kconfig.debug| 3 --- > arch/x86/Kconfig | 5 ++--- > arch/x86/Kconfig.debug | 11 -- > 13 files changed, 51 insertions(+), 68 deletions(-) For the s390 bits: Acked-by: Heiko Carstens

[PATCH 1/3] memblock: let memblock_type_name know about physmem type

2017-01-20 Thread Heiko Carstens
Since commit 70210ed950b5 ("mm/memblock: add physical memory list") the memblock structure knows about a physical memory list. memblock_type_name() should return "physmem" instead of "unknown" if the name of the physmem memblock_type is being asked for. Signed-off-b

[PATCH 1/3] memblock: let memblock_type_name know about physmem type

2017-01-20 Thread Heiko Carstens
Since commit 70210ed950b5 ("mm/memblock: add physical memory list") the memblock structure knows about a physical memory list. memblock_type_name() should return "physmem" instead of "unknown" if the name of the physmem memblock_type is being asked for. Signed-o

[PATCH 3/3] memblock: embed memblock type name within struct memblock_type

2017-01-20 Thread Heiko Carstens
it a name. Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> --- arch/s390/kernel/crash_dump.c | 1 + include/linux/memblock.h | 1 + mm/memblock.c | 35 +++ 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/arc

[PATCH 2/3] memblock: also dump physmem list within __memblock_dump_all

2017-01-20 Thread Heiko Carstens
Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> --- mm/memblock.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/memblock.c b/mm/memblock.c index acbfa1d2..fbaaf713827c 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1709,6 +1709,9 @@ void __init_memblock __memblo

[PATCH 0/3] memblock: physical memory list cleanups

2017-01-20 Thread Heiko Carstens
e structure in order to hopefully make the code a bit more easier and to get rid of a bit of code duplication. Thanks, Heiko Heiko Carstens (3): memblock: let memblock_type_name know about physmem type memblock: also dump physmem list within __memblock_dump_all memblock: embed memblock typ

[PATCH 2/3] memblock: also dump physmem list within __memblock_dump_all

2017-01-20 Thread Heiko Carstens
Signed-off-by: Heiko Carstens --- mm/memblock.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/memblock.c b/mm/memblock.c index acbfa1d2..fbaaf713827c 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1709,6 +1709,9 @@ void __init_memblock __memblock_dump_all(void) mem

[PATCH 0/3] memblock: physical memory list cleanups

2017-01-20 Thread Heiko Carstens
e structure in order to hopefully make the code a bit more easier and to get rid of a bit of code duplication. Thanks, Heiko Heiko Carstens (3): memblock: let memblock_type_name know about physmem type memblock: also dump physmem list within __memblock_dump_all memblock: embed memblock typ

[PATCH 3/3] memblock: embed memblock type name within struct memblock_type

2017-01-20 Thread Heiko Carstens
it a name. Signed-off-by: Heiko Carstens --- arch/s390/kernel/crash_dump.c | 1 + include/linux/memblock.h | 1 + mm/memblock.c | 35 +++ 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390

Re: [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA

2017-01-19 Thread Heiko Carstens
On Thu, Jan 19, 2017 at 10:56:46AM +, Mark Rutland wrote: > > +config HARDENED_PAGE_MAPPINGS > > + bool "Mark kernel mappings with stricter permissions (RO/W^X)" > > + default y > > + depends on ARCH_HAS_HARDENED_MAPPINGS > > + help > > + If this is set, kernel text and rodata

Re: [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA

2017-01-19 Thread Heiko Carstens
On Thu, Jan 19, 2017 at 10:56:46AM +, Mark Rutland wrote: > > +config HARDENED_PAGE_MAPPINGS > > + bool "Mark kernel mappings with stricter permissions (RO/W^X)" > > + default y > > + depends on ARCH_HAS_HARDENED_MAPPINGS > > + help > > + If this is set, kernel text and rodata

Re: [PATCH 2/2] security: Change name of CONFIG_DEBUG_SET_MODULE_RONX

2017-01-19 Thread Heiko Carstens
On Thu, Jan 19, 2017 at 11:11:18AM +, Mark Rutland wrote: > > +config HARDENED_MODULE_MAPPINGS > > + bool "Mark module mappings with stricter permissions (RO/W^X)" > > + default y > > + depends on ARCH_HAS_HARDENED_MODULE_MAPPINGS > > + help > > + If this is set, module text and

Re: [PATCH 2/2] security: Change name of CONFIG_DEBUG_SET_MODULE_RONX

2017-01-19 Thread Heiko Carstens
On Thu, Jan 19, 2017 at 11:11:18AM +, Mark Rutland wrote: > > +config HARDENED_MODULE_MAPPINGS > > + bool "Mark module mappings with stricter permissions (RO/W^X)" > > + default y > > + depends on ARCH_HAS_HARDENED_MODULE_MAPPINGS > > + help > > + If this is set, module text and

Re: [RFC 1/4] mm: remove unused TASK_SIZE_OF()

2017-01-01 Thread Heiko Carstens
#define TASK_MAX_SIZE(1UL << 53) > > #define STACK_TOP(1UL << (test_thread_flag(TIF_31BIT) ? 31:42)) FWIW, for the s390 part: Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com>

Re: [RFC 1/4] mm: remove unused TASK_SIZE_OF()

2017-01-01 Thread Heiko Carstens
(1UL << 53) > > #define STACK_TOP(1UL << (test_thread_flag(TIF_31BIT) ? 31:42)) FWIW, for the s390 part: Acked-by: Heiko Carstens

Re: [RFC] minimum gcc version for kernel: raise to gcc-4.3 or 4.6?

2016-12-20 Thread Heiko Carstens
On Fri, Dec 16, 2016 at 11:00:27PM +0100, Arnd Bergmann wrote: > On Friday, December 16, 2016 6:00:43 PM CET Sebastian Andrzej Siewior wrote: > > On 2016-12-16 11:56:21 [+0100], Arnd Bergmann wrote: > > > The original gcc-4.3 release was in early 2008. If we decide to still > > > support that, we

Re: [RFC] minimum gcc version for kernel: raise to gcc-4.3 or 4.6?

2016-12-20 Thread Heiko Carstens
On Fri, Dec 16, 2016 at 11:00:27PM +0100, Arnd Bergmann wrote: > On Friday, December 16, 2016 6:00:43 PM CET Sebastian Andrzej Siewior wrote: > > On 2016-12-16 11:56:21 [+0100], Arnd Bergmann wrote: > > > The original gcc-4.3 release was in early 2008. If we decide to still > > > support that, we

Re: [PATCH 1/2] s390/zcore: Remove unneeded linux/miscdevice.h include

2016-12-16 Thread Heiko Carstens
On Thu, Dec 15, 2016 at 03:18:23PM +0100, Corentin Labbe wrote: > drivers/s390/char/zcore.c does not contain any miscdevice so the > inclusion of linux/miscdevice.h is uncessary. > > Signed-off-by: Corentin Labbe > --- > drivers/s390/char/zcore.c | 1 - > 1 file

Re: [PATCH 1/2] s390/zcore: Remove unneeded linux/miscdevice.h include

2016-12-16 Thread Heiko Carstens
On Thu, Dec 15, 2016 at 03:18:23PM +0100, Corentin Labbe wrote: > drivers/s390/char/zcore.c does not contain any miscdevice so the > inclusion of linux/miscdevice.h is uncessary. > > Signed-off-by: Corentin Labbe > --- > drivers/s390/char/zcore.c | 1 - > 1 file changed, 1 deletion(-) Applied,

Re: linux-next: Tree for Dec 14

2016-12-14 Thread Heiko Carstens
to Linus' tree): 4498 > > 4320 files changed, 189429 insertions(+), 94239 deletions(-) > > New s390 build failure today: > > http://kisskb.ellerman.id.au/kisskb/buildresult/12883922/ > > I reproduced it locally using the older korg s390 toolchain. > > Reverting this and

Re: linux-next: Tree for Dec 14

2016-12-14 Thread Heiko Carstens
files changed, 189429 insertions(+), 94239 deletions(-) > > New s390 build failure today: > > http://kisskb.ellerman.id.au/kisskb/buildresult/12883922/ > > I reproduced it locally using the older korg s390 toolchain. > > Reverting this and the file compiles fine: >

Re: linux-next: manual merge of the kvms390 tree with the s390 tree

2016-11-23 Thread Heiko Carstens
On Wed, Nov 23, 2016 at 09:24:17AM +0100, Christian Borntraeger wrote: > On 11/23/2016 04:45 AM, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the kvms390 tree got a conflict in: > > > > arch/s390/include/asm/facilities_src.h > > > > between commit: > > > >

Re: linux-next: manual merge of the kvms390 tree with the s390 tree

2016-11-23 Thread Heiko Carstens
On Wed, Nov 23, 2016 at 09:24:17AM +0100, Christian Borntraeger wrote: > On 11/23/2016 04:45 AM, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the kvms390 tree got a conflict in: > > > > arch/s390/include/asm/facilities_src.h > > > > between commit: > > > >

Re: [PATCH v2] tile: handle __ro_after_init like parisc does

2016-11-14 Thread Heiko Carstens
On Mon, Nov 14, 2016 at 01:12:05PM -0800, Kees Cook wrote: > At some point here, I want to collect all the arch maintainers and > discuss the options for correctly reflecting the three data > memory-protection needs we have: > > - always read-only > - read-only after init > - read-only except

Re: [PATCH v2] tile: handle __ro_after_init like parisc does

2016-11-14 Thread Heiko Carstens
On Mon, Nov 14, 2016 at 01:12:05PM -0800, Kees Cook wrote: > At some point here, I want to collect all the arch maintainers and > discuss the options for correctly reflecting the three data > memory-protection needs we have: > > - always read-only > - read-only after init > - read-only except

[PATCH] mm/pkeys: generate pkey system call code only if ARCH_HAS_PKEYS is selected

2016-11-14 Thread Heiko Carstens
not wired up the system calls less unreachable code will be generated. Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> --- mm/mprotect.c | 4 1 file changed, 4 insertions(+) diff --git a/mm/mprotect.c b/mm/mprotect.c index 11936526b08b..a06e91c4de29 100644 --- a/mm/mprotect.c ++

[PATCH] mm/pkeys: generate pkey system call code only if ARCH_HAS_PKEYS is selected

2016-11-14 Thread Heiko Carstens
not wired up the system calls less unreachable code will be generated. Signed-off-by: Heiko Carstens --- mm/mprotect.c | 4 1 file changed, 4 insertions(+) diff --git a/mm/mprotect.c b/mm/mprotect.c index 11936526b08b..a06e91c4de29 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -484,6 +484,8

Re: [PATCHv2 0/2] THREAD_INFO_IN_TASK prep work for arm64+s390

2016-11-11 Thread Heiko Carstens
Hi Mark, > On Wed, Nov 02, 2016 at 03:56:26PM +, Mark Rutland wrote: > > On Wed, Oct 26, 2016 at 06:43:05PM +0100, Mark Rutland wrote: > > > Heiko and I have been working on THREAD_INFO_IN_TASK for s390 and arm64 > > > respectively, and we're both targetting v4.10. > > > > > > These are the

Re: [PATCHv2 0/2] THREAD_INFO_IN_TASK prep work for arm64+s390

2016-11-11 Thread Heiko Carstens
Hi Mark, > On Wed, Nov 02, 2016 at 03:56:26PM +, Mark Rutland wrote: > > On Wed, Oct 26, 2016 at 06:43:05PM +0100, Mark Rutland wrote: > > > Heiko and I have been working on THREAD_INFO_IN_TASK for s390 and arm64 > > > respectively, and we're both targetting v4.10. > > > > > > These are the

Re: [PATCH] mm: only enable sys_pkey* when ARCH_HAS_PKEYS

2016-11-08 Thread Heiko Carstens
On Tue, Nov 08, 2016 at 12:39:28PM +0100, Arnd Bergmann wrote: > On Tuesday, November 8, 2016 10:30:42 AM CET Heiko Carstens wrote: > > Three architectures (parisc, powerpc, s390) decided to ignore the system > > calls completely, but still have the pkey code linked into the k

Re: [PATCH] mm: only enable sys_pkey* when ARCH_HAS_PKEYS

2016-11-08 Thread Heiko Carstens
On Tue, Nov 08, 2016 at 12:39:28PM +0100, Arnd Bergmann wrote: > On Tuesday, November 8, 2016 10:30:42 AM CET Heiko Carstens wrote: > > Three architectures (parisc, powerpc, s390) decided to ignore the system > > calls completely, but still have the pkey code linked into the k

Re: [PATCH] mm: only enable sys_pkey* when ARCH_HAS_PKEYS

2016-11-08 Thread Heiko Carstens
On Tue, Nov 08, 2016 at 10:41:12AM +, Russell King - ARM Linux wrote: > On Tue, Nov 08, 2016 at 10:30:42AM +0100, Heiko Carstens wrote: > > Two architectures (arm, mips) have wired them up and thus allocated system > > call numbers, even though they don't have ARCH_HAS_PKEYS s

Re: [PATCH] mm: only enable sys_pkey* when ARCH_HAS_PKEYS

2016-11-08 Thread Heiko Carstens
On Tue, Nov 08, 2016 at 10:41:12AM +, Russell King - ARM Linux wrote: > On Tue, Nov 08, 2016 at 10:30:42AM +0100, Heiko Carstens wrote: > > Two architectures (arm, mips) have wired them up and thus allocated system > > call numbers, even though they don't have ARCH_HAS_PKEYS s

Re: [PATCH] mm: only enable sys_pkey* when ARCH_HAS_PKEYS

2016-11-08 Thread Heiko Carstens
On Fri, Nov 04, 2016 at 11:44:59PM +, Mark Rutland wrote: > On Wed, Nov 02, 2016 at 12:15:50PM -0700, Dave Hansen wrote: > > On 10/31/2016 05:08 PM, Mark Rutland wrote: > > > When an architecture does not select CONFIG_ARCH_HAS_PKEYS, the pkey_alloc > > > syscall will return -ENOSPC for all

Re: [PATCH] mm: only enable sys_pkey* when ARCH_HAS_PKEYS

2016-11-08 Thread Heiko Carstens
On Fri, Nov 04, 2016 at 11:44:59PM +, Mark Rutland wrote: > On Wed, Nov 02, 2016 at 12:15:50PM -0700, Dave Hansen wrote: > > On 10/31/2016 05:08 PM, Mark Rutland wrote: > > > When an architecture does not select CONFIG_ARCH_HAS_PKEYS, the pkey_alloc > > > syscall will return -ENOSPC for all

Re: [PATCH] s390: remove unneeded dependency for gen_facilities

2016-11-07 Thread Heiko Carstens
@@ define filechk_facilities.h > $(obj)/gen_facilities > endef > > -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c > - > include/generated/facilities.h: $(obj)/gen_facilities FORCE > $(call filechk,facilities.h) Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com> Martin, can you pick this one up too, please?

Re: [PATCH] s390: remove unneeded dependency for gen_facilities

2016-11-07 Thread Heiko Carstens
s.h > $(obj)/gen_facilities > endef > > -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c > - > include/generated/facilities.h: $(obj)/gen_facilities FORCE > $(call filechk,facilities.h) Acked-by: Heiko Carstens Martin, can you pick this one up too, please?

Re: [PATCH] tile: handle RO_AFTER_INIT_DATA

2016-11-07 Thread Heiko Carstens
On Mon, Nov 07, 2016 at 02:50:27PM -0500, Chris Metcalf wrote: > This is the minimal change to handle RO_AFTER_INIT_DATA. > The tile architecture already marks RO_DATA as read-only in > the kernel, so grouping RO_AFTER_INIT_DATA with RO_DATA, as is > done by default, means the kernel faults in

Re: [PATCH] tile: handle RO_AFTER_INIT_DATA

2016-11-07 Thread Heiko Carstens
On Mon, Nov 07, 2016 at 02:50:27PM -0500, Chris Metcalf wrote: > This is the minimal change to handle RO_AFTER_INIT_DATA. > The tile architecture already marks RO_DATA as read-only in > the kernel, so grouping RO_AFTER_INIT_DATA with RO_DATA, as is > done by default, means the kernel faults in

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-07 Thread Heiko Carstens
On Mon, Nov 07, 2016 at 02:13:06PM +0100, Paul Bolle wrote: > It took me some time to figure out that gen_facilities is only used to > generate a small header file (generated/facilities.h). And that header's only > goal is to define FACILITIES_ALS and FACILITIES_KVM. > > Pasted below is an

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-07 Thread Heiko Carstens
On Mon, Nov 07, 2016 at 02:13:06PM +0100, Paul Bolle wrote: > It took me some time to figure out that gen_facilities is only used to > generate a small header file (generated/facilities.h). And that header's only > goal is to define FACILITIES_ALS and FACILITIES_KVM. > > Pasted below is an

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-06 Thread Heiko Carstens
f > > This check can be removed by merging the two files. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > --- Both patches: Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com> Martin, can you please pick them up?

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-06 Thread Heiko Carstens
f > > This check can be removed by merging the two files. > > Signed-off-by: Masahiro Yamada > --- Both patches: Acked-by: Heiko Carstens Martin, can you please pick them up?

Re: [PATCH 11/25] s390/smp: Convert to hotplug state machine

2016-11-04 Thread Heiko Carstens
> - rc = sysfs_create_group(>kobj, _online_attr_group); > - if (rc) > - goto out_online; > - } > + > rc = topology_cpu_init(c); Please don't add whitespace :) If you fix the minor nits both s390 related patches ar

Re: [PATCH 11/25] s390/smp: Convert to hotplug state machine

2016-11-04 Thread Heiko Carstens
> - rc = sysfs_create_group(>kobj, _online_attr_group); > - if (rc) > - goto out_online; > - } > + > rc = topology_cpu_init(c); Please don't add whitespace :) If you fix the minor nits both s390 related patches are Acked-by: Heiko Carstens Thanks!

Re: [PATCH 10/25] s390/smp: Make cpu notifier symetric

2016-11-04 Thread Heiko Carstens
OWN_PREPARE allows us to convert it to a symetric hotplug state in the > next step. > > Cc: Martin Schwidefsky <schwidef...@de.ibm.com> > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> > Cc: linux-s...@vger.kernel.org > Signed-off-by: Thomas Gleixner <t...@linutroni

Re: [PATCH 10/25] s390/smp: Make cpu notifier symetric

2016-11-04 Thread Heiko Carstens
s us to convert it to a symetric hotplug state in the > next step. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s...@vger.kernel.org > Signed-off-by: Thomas Gleixner > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/s390/kernel/smp.c | 3 ++- > 1 file chan

[PATCH] percpu: use notrace variant of preempt_disable/preempt_enable

2016-11-03 Thread Heiko Carstens
Reported-and-bisected-by: Sebastian Ott <seb...@linux.vnet.ibm.com> Tested-by: Sebastian Ott <seb...@linux.vnet.ibm.com> Fixes: 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap like events do") Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> --- in

[PATCH] percpu: use notrace variant of preempt_disable/preempt_enable

2016-11-03 Thread Heiko Carstens
Reported-and-bisected-by: Sebastian Ott Tested-by: Sebastian Ott Fixes: 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap like events do") Signed-off-by: Heiko Carstens --- include/asm-generic/percpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 0/9] s390: remove modular usage from non-modular code

2016-10-31 Thread Heiko Carstens
On Sun, Oct 30, 2016 at 04:37:23PM -0400, Paul Gortmaker wrote: > My ongoing audit looking for non-modular code that needlessly uses > modular macros (vs. built-in equivalents) and/or has dead code > relating to module unloading that can never be executed led to the > creation of these s390

Re: [PATCH 0/9] s390: remove modular usage from non-modular code

2016-10-31 Thread Heiko Carstens
On Sun, Oct 30, 2016 at 04:37:23PM -0400, Paul Gortmaker wrote: > My ongoing audit looking for non-modular code that needlessly uses > modular macros (vs. built-in equivalents) and/or has dead code > relating to module unloading that can never be executed led to the > creation of these s390

[tip:x86/urgent] sched/core, x86: Make struct thread_info arch specific again

2016-10-20 Thread tip-bot for Heiko Carstens
Commit-ID: c8061485a0d7569a865a3cc3c63347b0f42b3765 Gitweb: http://git.kernel.org/tip/c8061485a0d7569a865a3cc3c63347b0f42b3765 Author: Heiko Carstens <heiko.carst...@de.ibm.com> AuthorDate: Wed, 19 Oct 2016 19:28:11 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate:

[tip:x86/urgent] sched/core, x86: Make struct thread_info arch specific again

2016-10-20 Thread tip-bot for Heiko Carstens
Commit-ID: c8061485a0d7569a865a3cc3c63347b0f42b3765 Gitweb: http://git.kernel.org/tip/c8061485a0d7569a865a3cc3c63347b0f42b3765 Author: Heiko Carstens AuthorDate: Wed, 19 Oct 2016 19:28:11 +0100 Committer: Ingo Molnar CommitDate: Thu, 20 Oct 2016 13:27:47 +0200 sched/core, x86: Make

Re: [PATCH 3/3] thread_info: include for THREAD_INFO_IN_TASK

2016-10-20 Thread Heiko Carstens
h cases work, this patch includes , but only > when CONFIG_THREAD_INFO_IN_TASK is selected. > > Signed-off-by: Mark Rutland <mark.rutl...@arm.com> > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: Andy Lutomirski <l...@kernel.org> > Cc: Heiko Carste

Re: [PATCH 3/3] thread_info: include for THREAD_INFO_IN_TASK

2016-10-20 Thread Heiko Carstens
h cases work, this patch includes , but only > when CONFIG_THREAD_INFO_IN_TASK is selected. > > Signed-off-by: Mark Rutland > Cc: Andrew Morton > Cc: Andy Lutomirski > Cc: Heiko Carstens > Cc: Kees Cook > --- > include/linux/thread_info.h | 1 + > 1 file change

Re: [PATCH v2 1/1] s390/spinlock: Provide vcpu_is_preempted

2016-10-19 Thread Heiko Carstens
On Wed, Oct 19, 2016 at 08:56:36AM +0200, Christian Borntraeger wrote: > On 09/29/2016 05:51 PM, Christian Borntraeger wrote: > > this implements the s390 backend for commit > > "kernel/sched: introduce vcpu preempted check interface" > > by reworking the existing smp_vcpu_scheduled into > >

Re: [PATCH v2 1/1] s390/spinlock: Provide vcpu_is_preempted

2016-10-19 Thread Heiko Carstens
On Wed, Oct 19, 2016 at 08:56:36AM +0200, Christian Borntraeger wrote: > On 09/29/2016 05:51 PM, Christian Borntraeger wrote: > > this implements the s390 backend for commit > > "kernel/sched: introduce vcpu preempted check interface" > > by reworking the existing smp_vcpu_scheduled into > >

Re: [PATCH v3] s390/spinlock: Provide vcpu_is_preempted

2016-10-19 Thread Heiko Carstens
| 9 +++-- > arch/s390/lib/spinlock.c | 25 - > 3 files changed, 23 insertions(+), 19 deletions(-) Acked-by: Heiko Carstens <heiko.carst...@de.ibm.com>

Re: [PATCH v3] s390/spinlock: Provide vcpu_is_preempted

2016-10-19 Thread Heiko Carstens
-- > arch/s390/lib/spinlock.c | 25 - > 3 files changed, 23 insertions(+), 19 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH] thread_info: include for THREAD_INFO_IN_TASK (WAS: [PATCH 2/3] sched/preempt: include asm/current.h)

2016-10-18 Thread Heiko Carstens
On Mon, Oct 17, 2016 at 06:33:15PM +0100, Mark Rutland wrote: > On Mon, Oct 17, 2016 at 03:48:13PM +0100, Mark Rutland wrote: > > On Fri, Oct 14, 2016 at 11:42:25AM +0100, Mark Rutland wrote: > > > When CONFIG_THREAD_INFO_IN_TASK is selected, the current_thread_info() > > > macro relies on current

Re: [PATCH] thread_info: include for THREAD_INFO_IN_TASK (WAS: [PATCH 2/3] sched/preempt: include asm/current.h)

2016-10-18 Thread Heiko Carstens
On Mon, Oct 17, 2016 at 06:33:15PM +0100, Mark Rutland wrote: > On Mon, Oct 17, 2016 at 03:48:13PM +0100, Mark Rutland wrote: > > On Fri, Oct 14, 2016 at 11:42:25AM +0100, Mark Rutland wrote: > > > When CONFIG_THREAD_INFO_IN_TASK is selected, the current_thread_info() > > > macro relies on current

Re: [PATCH 2/3] sched/preempt: include asm/current.h

2016-10-14 Thread Heiko Carstens
On Fri, Oct 14, 2016 at 12:25:56AM +0100, Mark Rutland wrote: > Hi, > > On Thu, Oct 13, 2016 at 01:57:11PM +0200, Heiko Carstens wrote: > > The generic preempt code needs to include . Otherwise > > compilation fails if THREAD_INFO_IN_TASK is selected and the generic >

Re: [PATCH 2/3] sched/preempt: include asm/current.h

2016-10-14 Thread Heiko Carstens
On Fri, Oct 14, 2016 at 12:25:56AM +0100, Mark Rutland wrote: > Hi, > > On Thu, Oct 13, 2016 at 01:57:11PM +0200, Heiko Carstens wrote: > > The generic preempt code needs to include . Otherwise > > compilation fails if THREAD_INFO_IN_TASK is selected and the generic >

[PATCH 3/3] s390: move thread_info into task_struct

2016-10-13 Thread Heiko Carstens
This is the s390 variant of commit 15f4eae70d36 ("x86: Move thread_info into task_struct"). Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> --- arch/s390/Kconfig | 1 + arch/s390/include/asm/lowcore.h | 2 +- arch/s390/include/asm/th

[PATCH 3/3] s390: move thread_info into task_struct

2016-10-13 Thread Heiko Carstens
This is the s390 variant of commit 15f4eae70d36 ("x86: Move thread_info into task_struct"). Signed-off-by: Heiko Carstens --- arch/s390/Kconfig | 1 + arch/s390/include/asm/lowcore.h | 2 +- arch/s390/include/asm/thread_info.h | 11 arch/s390/

[PATCH 2/3] sched/preempt: include asm/current.h

2016-10-13 Thread Heiko Carstens
*)current) Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> --- include/asm-generic/preempt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/asm-generic/preempt.h b/include/asm-generic/preempt.h index c1cde3577551..66fcd6cd7fc6 100644 --- a/include/asm-generic/preempt.h

<    1   2   3   4   5   6   7   8   9   10   >