[tip:locking/core] s390/uaccess, locking/static_keys: employ static_branch_likely()

2015-08-03 Thread tip-bot for Heiko Carstens
Commit-ID: ed79e946732e5311934d7f404b3b4e702e45cb97 Gitweb: http://git.kernel.org/tip/ed79e946732e5311934d7f404b3b4e702e45cb97 Author: Heiko Carstens heiko.carst...@de.ibm.com AuthorDate: Wed, 29 Jul 2015 08:31:24 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Mon, 3 Aug 2015

Re: [PATCH -v2 0/8] jump_label: Another (better) static_key interface

2015-07-29 Thread Heiko Carstens
e. You may include the s390 patch below, so the conversion to the new interface happens when your code gets merged: >From 3c9b5a2b9a90d6bb2b41f381f5f89b3657fe4ea5 Mon Sep 17 00:00:00 2001 From: Heiko Carstens Date: Wed, 29 Jul 2015 08:31:24 +0200 Subject: [PATCH] s390/uaccess: employ static_branch_

Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface

2015-07-29 Thread Heiko Carstens
3 > -- > kernel/jump_label.c | 35 ++-- > 9 files changed, 294 insertions(+), 39 deletions(-) for the s390 part: Acked-by: Heiko Carstens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface

2015-07-29 Thread Heiko Carstens
part: Acked-by: Heiko Carstens heiko.carst...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH -v2 0/8] jump_label: Another (better) static_key interface

2015-07-29 Thread Heiko Carstens
patch below, so the conversion to the new interface happens when your code gets merged: From 3c9b5a2b9a90d6bb2b41f381f5f89b3657fe4ea5 Mon Sep 17 00:00:00 2001 From: Heiko Carstens heiko.carst...@de.ibm.com Date: Wed, 29 Jul 2015 08:31:24 +0200 Subject: [PATCH] s390/uaccess: employ

Re: [RFC][PATCH 5/7] jump_label: Rework update logic

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 06:30:05PM +0200, Peter Zijlstra wrote: > On Mon, Jul 27, 2015 at 12:47:14PM +0200, Peter Zijlstra wrote: > > @@ -68,13 +63,8 @@ void static_key_slow_inc(struct static_k > > return; > > > > jump_label_lock(); > > + if (atomic_inc_and_test(>enabled)) > >

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 12:50:36PM +0200, Peter Zijlstra wrote: > On Mon, Jul 27, 2015 at 12:47:55PM +0200, Peter Zijlstra wrote: > > On Mon, Jul 27, 2015 at 12:20:46PM +0200, Heiko Carstens wrote: > > > On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote:

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 12:45:10PM +0200, Peter Zijlstra wrote: > --- a/arch/s390/include/asm/jump_label.h > +++ b/arch/s390/include/asm/jump_label.h > +static __always_inline bool arch_static_branch_jump(struct static_key *key, > bool branch) > +{ > + asm_volatile_goto("0: brcl 15,

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote: > > +static __always_inline bool arch_static_branch_jump(struct static_key > > *key, bool branch) > > +{ > > + asm_volatile_goto("0: j %l[l_yes]\n" > > Looking at the s390 version of jump_label_make_branch(), this should > have

Re: [RFC][PATCH 5/7] jump_label: Rework update logic

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 06:30:05PM +0200, Peter Zijlstra wrote: On Mon, Jul 27, 2015 at 12:47:14PM +0200, Peter Zijlstra wrote: @@ -68,13 +63,8 @@ void static_key_slow_inc(struct static_k return; jump_label_lock(); + if (atomic_inc_and_test(key-enabled))

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 12:50:36PM +0200, Peter Zijlstra wrote: On Mon, Jul 27, 2015 at 12:47:55PM +0200, Peter Zijlstra wrote: On Mon, Jul 27, 2015 at 12:20:46PM +0200, Heiko Carstens wrote: On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote: +static __always_inline bool

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 12:45:10PM +0200, Peter Zijlstra wrote: --- a/arch/s390/include/asm/jump_label.h +++ b/arch/s390/include/asm/jump_label.h +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch) +{ + asm_volatile_goto(0: brcl 15, %l[l_yes]\n +

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

2015-07-27 Thread Heiko Carstens
On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote: +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch) +{ + asm_volatile_goto(0: j %l[l_yes]\n Looking at the s390 version of jump_label_make_branch(), this should have been:

Re: [RFC PATCH] sched, s390: Fix the fallout of increasing the offset of 'thread_struct' within 'task_struct'

2015-07-20 Thread Heiko Carstens
On Mon, Jul 20, 2015 at 07:41:55AM -0700, Guenter Roeck wrote: > Commit 0c8c0f03e3a2 ("x86/fpu, sched: Dynamically allocate 'struct fpu'") > moved the thread_struct to the bottom of task_struct. As a result, the > offset is now too large to be used in an immediate stfpc operation on s390, >

Re: [GIT PULL] x86 fixes

2015-07-20 Thread Heiko Carstens
On Sat, Jul 18, 2015 at 05:18:10AM +0200, Ingo Molnar wrote: > Linus, > > Please pull the latest x86-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > x86-urgent-for-linus > ># HEAD: 5aaeb5c01c5b6c0be7b7aadbf3ace9f3a4458c3d x86/fpu, sched:

Re: [GIT PULL] x86 fixes

2015-07-20 Thread Heiko Carstens
On Sat, Jul 18, 2015 at 05:18:10AM +0200, Ingo Molnar wrote: Linus, Please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus # HEAD: 5aaeb5c01c5b6c0be7b7aadbf3ace9f3a4458c3d x86/fpu, sched: Introduce

Re: [RFC PATCH] sched, s390: Fix the fallout of increasing the offset of 'thread_struct' within 'task_struct'

2015-07-20 Thread Heiko Carstens
On Mon, Jul 20, 2015 at 07:41:55AM -0700, Guenter Roeck wrote: Commit 0c8c0f03e3a2 (x86/fpu, sched: Dynamically allocate 'struct fpu') moved the thread_struct to the bottom of task_struct. As a result, the offset is now too large to be used in an immediate stfpc operation on s390, resulting in

Re: [RFC][PATCH 19/24] s390: Provide atomic_{or,xor,and}

2015-07-10 Thread Heiko Carstens
On Fri, Jul 10, 2015 at 12:22:10PM +0200, Peter Zijlstra wrote: > On Fri, Jul 10, 2015 at 09:17:09AM +0200, Heiko Carstens wrote: > > > +static inline __deprecated void atomic_set_mask(unsigned int mask, > > > atomic_t *v) > > > { > > > - __ATOMIC_LOOP(v,

Re: [RFC][PATCH 19/24] s390: Provide atomic_{or,xor,and}

2015-07-10 Thread Heiko Carstens
, atomic_t *v) > +static inline __deprecated void atomic_set_mask(unsigned int mask, atomic_t > *v) > { > - __ATOMIC_LOOP(v, mask, __ATOMIC_OR, __ATOMIC_NO_BARRIER); > + atomic_or(mask, v); > } If you insist on the __deprecated (no problem with that), I'd like to appl

Re: [RFC][PATCH 19/24] s390: Provide atomic_{or,xor,and}

2015-07-10 Thread Heiko Carstens
to the s390 tree so I can convert all users. I would like to avoid to see tons of warnings. Besides that: Acked-by: Heiko Carstens heiko.carst...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [RFC][PATCH 19/24] s390: Provide atomic_{or,xor,and}

2015-07-10 Thread Heiko Carstens
On Fri, Jul 10, 2015 at 12:22:10PM +0200, Peter Zijlstra wrote: On Fri, Jul 10, 2015 at 09:17:09AM +0200, Heiko Carstens wrote: +static inline __deprecated void atomic_set_mask(unsigned int mask, atomic_t *v) { - __ATOMIC_LOOP(v, mask, __ATOMIC_OR, __ATOMIC_NO_BARRIER

Re: [PATCH V3 2/5] mm: mlock: Add new mlock, munlock, and munlockall system calls

2015-07-08 Thread Heiko Carstens
On Tue, Jul 07, 2015 at 01:03:40PM -0400, Eric B Munson wrote: > With the refactored mlock code, introduce new system calls for mlock, > munlock, and munlockall. The new calls will allow the user to specify > what lock states are being added or cleared. mlock2 and munlock2 are > trivial at the

Re: [PATCH V3 2/5] mm: mlock: Add new mlock, munlock, and munlockall system calls

2015-07-08 Thread Heiko Carstens
On Tue, Jul 07, 2015 at 01:03:40PM -0400, Eric B Munson wrote: With the refactored mlock code, introduce new system calls for mlock, munlock, and munlockall. The new calls will allow the user to specify what lock states are being added or cleared. mlock2 and munlock2 are trivial at the

Re: smp_store_mb() oddity..

2015-07-01 Thread Heiko Carstens
smp_store_mb() users really are about SMP ordering, not IO > ordering, change them all to be consistent. > > Cc: Tony Luck > Cc: Benjamin Herrenschmidt > Cc: Heiko Carstens > Suggested-by: Linus Torvalds > Signed-off-by: Peter Zijlstra (Intel) > --- > diff --git a/arc

Re: smp_store_mb() oddity..

2015-07-01 Thread Heiko Carstens
are about SMP ordering, not IO ordering, change them all to be consistent. Cc: Tony Luck tony.l...@intel.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Heiko Carstens heiko.carst...@de.ibm.com Suggested-by: Linus Torvalds torva...@linux-foundation.org Signed-off-by: Peter

Re: [PATCH] s390/process: Delete an unnecessary check before the function call "kfree"

2015-06-25 Thread Heiko Carstens
On Thu, Jun 25, 2015 at 12:02:28PM +0200, walter harms wrote: > > Am 24.06.2015 22:48, schrieb SF Markus Elfring: > > From: Markus Elfring > > Date: Wed, 24 Jun 2015 22:40:30 +0200 > > > > The kfree() function tests whether its argument is NULL and then > > returns immediately. Thus the test

Re: [PATCH] s390/process: Delete an unnecessary check before the function call kfree

2015-06-25 Thread Heiko Carstens
On Thu, Jun 25, 2015 at 12:02:28PM +0200, walter harms wrote: Am 24.06.2015 22:48, schrieb SF Markus Elfring: From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 24 Jun 2015 22:40:30 +0200 The kfree() function tests whether its argument is NULL and then returns immediately.

Re: [PATCH V2] s390/sclp: pass timeout as HZ independent value

2015-05-30 Thread Heiko Carstens
t; Link: http://lkml.org/lkml/2015/5/29/235 > Signed-off-by: Nicholas Mc Guire > --- > > V2: timeout clarified by Heiko Carstens and > set to 500ms (HZ/2). And thanks for the test-config hints. > > drivers/s390/char/sclp_sdias.c |3 +-- > 1 file changed, 1 inser

Re: [PATCH V2] s390/sclp: pass timeout as HZ independent value

2015-05-30 Thread Heiko Carstens
://lkml.org/lkml/2015/5/29/235 Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- V2: timeout clarified by Heiko Carstens heiko.carst...@de.ibm.com and set to 500ms (HZ/2). And thanks for the test-config hints. drivers/s390/char/sclp_sdias.c |3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Fri, May 29, 2015 at 04:16:46PM +0200, Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Michael Holzheu wrote: > > > On Fri, 29 May 2015 13:49:36 +0200 > > Nicholas Mc Guire wrote: > > > > > On Fri, 29 May 2015, Heiko Carstens wrote: > > > > &

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Fri, May 29, 2015 at 11:51:54AM +0200, Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Heiko Carstens wrote: > > Yes, the orginal code seems to be broken. Since I've no idea what the > > intended > > timeout value should be, let's simply ask Michael, who wrote this cod

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Wed, May 27, 2015 at 07:04:43PM +0200, Nicholas Mc Guire wrote: > schedule_timeout takes a timeout in jiffies but the code currently is > passing in a constant SDIAS_SLEEP_TICKS which sounds like it should be > in jiffies but it is actually not and thus makes this timeout HZ > dependent, to fix

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Wed, May 27, 2015 at 07:04:43PM +0200, Nicholas Mc Guire wrote: schedule_timeout takes a timeout in jiffies but the code currently is passing in a constant SDIAS_SLEEP_TICKS which sounds like it should be in jiffies but it is actually not and thus makes this timeout HZ dependent, to fix

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Fri, May 29, 2015 at 11:51:54AM +0200, Nicholas Mc Guire wrote: On Fri, 29 May 2015, Heiko Carstens wrote: Yes, the orginal code seems to be broken. Since I've no idea what the intended timeout value should be, let's simply ask Michael, who wrote this code eight years ago ;) While

Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value

2015-05-29 Thread Heiko Carstens
On Fri, May 29, 2015 at 04:16:46PM +0200, Nicholas Mc Guire wrote: On Fri, 29 May 2015, Michael Holzheu wrote: On Fri, 29 May 2015 13:49:36 +0200 Nicholas Mc Guire der.h...@hofr.at wrote: On Fri, 29 May 2015, Heiko Carstens wrote: On Fri, May 29, 2015 at 11:51:54AM +0200

Re: [PATCH trivial] s390/mm: s/specifiation/specification/, s/an specification/a specification/

2015-05-21 Thread Heiko Carstens
On Thu, May 21, 2015 at 02:00:47PM +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > arch/s390/include/asm/pgtable.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index

Re: [PATCH trivial] s390/mm: s/specifiation/specification/, s/an specification/a specification/

2015-05-21 Thread Heiko Carstens
On Thu, May 21, 2015 at 02:00:47PM +0200, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- arch/s390/include/asm/pgtable.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/include/asm/pgtable.h

Re: [PATCH 08/12] s390/sclp: Use DECLARE_BITMAP

2015-05-20 Thread Heiko Carstens
On Tue, May 19, 2015 at 06:37:56PM -0700, Joe Perches wrote: > Use the generic mechanism to declare a bitmap instead of unsigned long. > > Signed-off-by: Joe Perches > --- > drivers/s390/char/sclp_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- To unsubscribe

Re: [PATCH 08/12] s390/sclp: Use DECLARE_BITMAP

2015-05-20 Thread Heiko Carstens
On Tue, May 19, 2015 at 06:37:56PM -0700, Joe Perches wrote: Use the generic mechanism to declare a bitmap instead of unsigned long. Signed-off-by: Joe Perches j...@perches.com --- drivers/s390/char/sclp_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- To

Re: [PATCH] force inlining of spinlock ops

2015-05-15 Thread Heiko Carstens
On Wed, May 13, 2015 at 04:09:18PM +0200, Denys Vlasenko wrote: > On 05/13/2015 12:43 PM, Ingo Molnar wrote: > > We only know that the net effect is +70 bytes. Does that come out of: > > > > - large fluctuations such as -1000-1000+1000+1070, which happens to > >net out into a small net

Re: [PATCH] force inlining of spinlock ops

2015-05-15 Thread Heiko Carstens
On Wed, May 13, 2015 at 04:09:18PM +0200, Denys Vlasenko wrote: On 05/13/2015 12:43 PM, Ingo Molnar wrote: We only know that the net effect is +70 bytes. Does that come out of: - large fluctuations such as -1000-1000+1000+1070, which happens to net out into a small net number?

[PATCH] KVM: remove pointless cpu hotplug messages

2015-05-05 Thread Heiko Carstens
remove this superfluous message. Signed-off-by: Heiko Carstens --- virt/kvm/kvm_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 90977418aeb6..5fb52af5b975 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2882,18 +2882,12

[PATCH] KVM: remove pointless cpu hotplug messages

2015-05-05 Thread Heiko Carstens
remove this superfluous message. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com --- virt/kvm/kvm_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 90977418aeb6..5fb52af5b975 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm

Re: [PATCH 3.10 00/65] 3.10.77-stable review

2015-05-04 Thread Heiko Carstens
On Mon, May 04, 2015 at 11:54:52AM +0200, Jiri Slaby wrote: > On 05/04/2015, 10:09 AM, Heiko Carstens wrote: > > sections.h > > 7f8998c7aef3ac9c5f3f2943e083dfa6302e90d0 > > "nosave: consolidate __nosave_{begin,end} in " > > I have added this to 3.1

Re: [PATCH 3.10 00/65] 3.10.77-stable review

2015-05-04 Thread Heiko Carstens
On Sun, May 03, 2015 at 09:40:11PM -0700, Guenter Roeck wrote: > On 05/03/2015 12:49 PM, Guenter Roeck wrote: > >On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote: > >>This is the start of the stable review cycle for the 3.10.77 release. > >>There are 65 patches in this series, all will be posted

Re: [PATCH 3.10 00/65] 3.10.77-stable review

2015-05-04 Thread Heiko Carstens
On Sun, May 03, 2015 at 09:40:11PM -0700, Guenter Roeck wrote: On 05/03/2015 12:49 PM, Guenter Roeck wrote: On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.10.77 release. There are 65 patches in this series, all will be posted as a

Re: [PATCH 3.10 00/65] 3.10.77-stable review

2015-05-04 Thread Heiko Carstens
On Mon, May 04, 2015 at 11:54:52AM +0200, Jiri Slaby wrote: On 05/04/2015, 10:09 AM, Heiko Carstens wrote: sections.h 7f8998c7aef3ac9c5f3f2943e083dfa6302e90d0 nosave: consolidate __nosave_{begin,end} in asm/sections.h I have added this to 3.12, except the arm part (does not have

Re: [PATCH v2] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-27 Thread Heiko Carstens
On Sat, Apr 25, 2015 at 08:50:49AM -0400, Rik van Riel wrote: > On 04/25/2015 05:43 AM, Heiko Carstens wrote: > > ...the READ_ONCE() doesn't give you any guarantees about reading > > tsk->acct_timexpd in an atomic way. > > Well, actually you don't need atomic semantic

Re: [PATCH v2] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-27 Thread Heiko Carstens
On Sat, Apr 25, 2015 at 08:50:49AM -0400, Rik van Riel wrote: On 04/25/2015 05:43 AM, Heiko Carstens wrote: ...the READ_ONCE() doesn't give you any guarantees about reading tsk-acct_timexpd in an atomic way. Well, actually you don't need atomic semantics, but only to make sure

Re: [PATCH v2] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-25 Thread Heiko Carstens
On Fri, Apr 24, 2015 at 11:16:53AM -0400, Rik van Riel wrote: > V2: introduce signed_cputime_t to deal with 64 bit cputime_t on > 32 bit architectures, and use READ_ONCE to ensure the value > is always read atomically (Heiko Karstens) Erm, that's not what I said ;) READ_ONCE() only fixes

Re: [PATCH v2] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-25 Thread Heiko Carstens
On Fri, Apr 24, 2015 at 11:16:53AM -0400, Rik van Riel wrote: V2: introduce signed_cputime_t to deal with 64 bit cputime_t on 32 bit architectures, and use READ_ONCE to ensure the value is always read atomically (Heiko Karstens) Erm, that's not what I said ;) READ_ONCE() only fixes the

Re: [PATCH] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-24 Thread Heiko Carstens
On Thu, Apr 23, 2015 at 09:57:13PM -0400, Rik van Riel wrote: > diff --git a/kernel/tsacct.c b/kernel/tsacct.c > index 975cb49e32bf..0b967f116a6b 100644 > --- a/kernel/tsacct.c > +++ b/kernel/tsacct.c > @@ -126,23 +126,29 @@ static void __acct_update_integrals(struct task_struct > *tsk, >

Re: [PATCH] context_tracking: remove local_irq_save from __acct_update_integrals

2015-04-24 Thread Heiko Carstens
On Thu, Apr 23, 2015 at 09:57:13PM -0400, Rik van Riel wrote: diff --git a/kernel/tsacct.c b/kernel/tsacct.c index 975cb49e32bf..0b967f116a6b 100644 --- a/kernel/tsacct.c +++ b/kernel/tsacct.c @@ -126,23 +126,29 @@ static void __acct_update_integrals(struct task_struct *tsk, if

Re: [PATCH 07/25] s390: Use bool function return values of true/false not 1/0

2015-03-31 Thread Heiko Carstens
On Mon, Mar 30, 2015 at 04:46:05PM -0700, Joe Perches wrote: > Use the normal return values for bool functions > > Signed-off-by: Joe Perches > --- > arch/s390/include/asm/dma-mapping.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/include/asm/dma-mapping.h

Re: [PATCH 07/25] s390: Use bool function return values of true/false not 1/0

2015-03-31 Thread Heiko Carstens
On Mon, Mar 30, 2015 at 04:46:05PM -0700, Joe Perches wrote: Use the normal return values for bool functions Signed-off-by: Joe Perches j...@perches.com --- arch/s390/include/asm/dma-mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/1] livepatch: add support on s390

2015-03-27 Thread Heiko Carstens
On Fri, Mar 27, 2015 at 10:29:28AM +0100, Jiri Kosina wrote: > On Fri, 27 Mar 2015, Heiko Carstens wrote: > > > On Thu, Mar 26, 2015 at 07:24:58PM +0100, Jiri Kosina wrote: > > > On Thu, 26 Mar 2015, Jiri Slaby wrote: > > > > > > > This is a tr

Re: [PATCH 1/1] livepatch: add support on s390

2015-03-27 Thread Heiko Carstens
On Thu, Mar 26, 2015 at 07:24:58PM +0100, Jiri Kosina wrote: > On Thu, 26 Mar 2015, Jiri Slaby wrote: > > > This is a trivial port from kGraft. Module relocations are not > > supported. > > > > Signed-off-by: Jiri Slaby > > --- > > [v2] return ENOSYS > > [v3] proper return value from

Re: [PATCH 1/1] livepatch: add support on s390

2015-03-27 Thread Heiko Carstens
On Thu, Mar 26, 2015 at 07:24:58PM +0100, Jiri Kosina wrote: On Thu, 26 Mar 2015, Jiri Slaby wrote: This is a trivial port from kGraft. Module relocations are not supported. Signed-off-by: Jiri Slaby jsl...@suse.cz --- [v2] return ENOSYS [v3] proper return value from

Re: [PATCH 1/1] livepatch: add support on s390

2015-03-27 Thread Heiko Carstens
On Fri, Mar 27, 2015 at 10:29:28AM +0100, Jiri Kosina wrote: On Fri, 27 Mar 2015, Heiko Carstens wrote: On Thu, Mar 26, 2015 at 07:24:58PM +0100, Jiri Kosina wrote: On Thu, 26 Mar 2015, Jiri Slaby wrote: This is a trivial port from kGraft. Module relocations are not supported

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-25 Thread Heiko Carstens
On Tue, Feb 24, 2015 at 06:41:50PM +0200, Ameen Ali wrote: > avoid out-of-bounds-read by checking count before indexing. > > Signed-off-by : Ameen Ali > --- > drivers/s390/block/dcssblk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/block/dcssblk.c

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

2015-02-25 Thread Heiko Carstens
On Tue, Feb 24, 2015 at 06:41:50PM +0200, Ameen Ali wrote: avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: s390: references to MARCH_G5

2015-02-20 Thread Heiko Carstens
On Fri, Feb 20, 2015 at 09:54:48AM +0100, Paul Bolle wrote: > Your commit c5f43f0a70fc ("s390: remove 31 bit support") is included in > today's linux-next (ie, next-20150220). I noticed because a script I use > to check linux-next spotted a problem with it. > > That commit removed the Kconfig

Re: s390: references to MARCH_G5

2015-02-20 Thread Heiko Carstens
On Fri, Feb 20, 2015 at 09:54:48AM +0100, Paul Bolle wrote: Your commit c5f43f0a70fc (s390: remove 31 bit support) is included in today's linux-next (ie, next-20150220). I noticed because a script I use to check linux-next spotted a problem with it. That commit removed the Kconfig symbol

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-29 Thread Heiko Carstens
On Wed, Jan 28, 2015 at 06:57:54AM -0500, Steven Rostedt wrote: > On Wed, 28 Jan 2015 06:36:45 +0100 > Heiko Carstens wrote: > > > On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: > > > On Tue, 27 Jan 2015 07:19:42 +0100 > > > Dominik Vogt wrote:

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-29 Thread Heiko Carstens
On Wed, Jan 28, 2015 at 06:57:54AM -0500, Steven Rostedt wrote: On Wed, 28 Jan 2015 06:36:45 +0100 Heiko Carstens heiko.carst...@de.ibm.com wrote: On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: On Tue, 27 Jan 2015 07:19:42 +0100 Dominik Vogt v...@linux.vnet.ibm.com

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-27 Thread Heiko Carstens
On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: > On Tue, 27 Jan 2015 07:19:42 +0100 > Dominik Vogt wrote: > > > While the kernel may use only profiling or hotpatch at the same > > time, Gcc is able to generate both for the same function. > > Understood, but would that be

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-27 Thread Heiko Carstens
On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: On Tue, 27 Jan 2015 07:19:42 +0100 Dominik Vogt v...@linux.vnet.ibm.com wrote: While the kernel may use only profiling or hotpatch at the same time, Gcc is able to generate both for the same function. Understood, but would

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 10:22:26AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 16:03:19 +0100 > Heiko Carstens wrote: > > > Actually they should be mutually exclusive. I just merged them "just in > > case". > > > > So something like this &g

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 09:37:01AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 13:54:53 +0100 > Heiko Carstens wrote: > > > gcc supports an s390 specific function attribute called "hotpatch". > > It can be used to specify the number of halfwords that shal

[PATCH/RFC 3/3] s390/ftrace: hotpatch support for function tracing

2015-01-26 Thread Heiko Carstens
overhead for supporting function tracing is close to zero, while the original code did show a significant performance impact. Signed-off-by: Heiko Carstens --- arch/s390/Kconfig | 1 - arch/s390/Makefile | 10 ++ arch/s390/include/asm/ftrace.h | 15

[PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
introduce a nohotpatch define, depending on CC_USING_HOTPATCH, and add it to the existing notrace define. Signed-off-by: Heiko Carstens --- include/linux/compiler.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux/compil

[PATCH/RFC 1/3] ftrace: allow architectures to specify ftrace compile options

2015-01-26 Thread Heiko Carstens
different option should be used for code generation. Signed-off-by: Heiko Carstens --- Makefile| 6 +- kernel/Makefile | 4 ++-- kernel/events/Makefile | 2 +- kernel/locking/Makefile | 8 kernel/sched/Makefile | 2 +- kernel/trace/Makefile | 4 ++-- li

[PATCH/RFC 0/3] ftrace: allow arch specific compile options

2015-01-26 Thread Heiko Carstens
number of halfwords before/after the beginning of a function is not yet upstream, but should be soon. Heiko Carstens (3): ftrace: allow architectures to specify ftrace compile options ftrace: introduce nohotpatch function attribute s390/ftrace: hotpatch support for functio

Re: [PATCH 07/32] s390: use %*pb[l] to print bitmaps including cpumasks and nodemasks

2015-01-26 Thread Heiko Carstens
ting through '%*pb[l]' > cpumask, nodemask: implement cpumask/nodemask_pr_args() > > Please wait till the forementioned patches are merged to mainline > before applying to subsystem trees. > > Signed-off-by: Tejun Heo > Cc: Andrew Morton > Cc: Martin Schwidefsky &g

[PATCH/RFC 1/3] ftrace: allow architectures to specify ftrace compile options

2015-01-26 Thread Heiko Carstens
option should be used for code generation. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com --- Makefile| 6 +- kernel/Makefile | 4 ++-- kernel/events/Makefile | 2 +- kernel/locking/Makefile | 8 kernel/sched/Makefile | 2 +- kernel/trace/Makefile

[PATCH/RFC 0/3] ftrace: allow arch specific compile options

2015-01-26 Thread Heiko Carstens
before/after the beginning of a function is not yet upstream, but should be soon. Heiko Carstens (3): ftrace: allow architectures to specify ftrace compile options ftrace: introduce nohotpatch function attribute s390/ftrace: hotpatch support for function tracing Makefile

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 09:37:01AM -0500, Steven Rostedt wrote: On Mon, 26 Jan 2015 13:54:53 +0100 Heiko Carstens heiko.carst...@de.ibm.com wrote: gcc supports an s390 specific function attribute called hotpatch. It can be used to specify the number of halfwords that shall be added before

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 10:22:26AM -0500, Steven Rostedt wrote: On Mon, 26 Jan 2015 16:03:19 +0100 Heiko Carstens heiko.carst...@de.ibm.com wrote: Actually they should be mutually exclusive. I just merged them just in case. So something like this #ifdef CC_USING_HOTPATCH

[PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
a nohotpatch define, depending on CC_USING_HOTPATCH, and add it to the existing notrace define. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com --- include/linux/compiler.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux

[PATCH/RFC 3/3] s390/ftrace: hotpatch support for function tracing

2015-01-26 Thread Heiko Carstens
overhead for supporting function tracing is close to zero, while the original code did show a significant performance impact. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com --- arch/s390/Kconfig | 1 - arch/s390/Makefile | 10 ++ arch/s390/include/asm

Re: [PATCH 07/32] s390: use %*pb[l] to print bitmaps including cpumasks and nodemasks

2015-01-26 Thread Heiko Carstens
: implement cpumask/nodemask_pr_args() Please wait till the forementioned patches are merged to mainline before applying to subsystem trees. Signed-off-by: Tejun Heo t...@kernel.org Cc: Andrew Morton a...@linux-foundation.org Cc: Martin Schwidefsky schwidef...@de.ibm.com Cc: Heiko Carstens

Re: [Resend Patch v4 14/16] smp, s390: Kill SMP single function call interrupt

2015-01-23 Thread Heiko Carstens
On Fri, Jan 23, 2015 at 05:21:42PM +0800, Jiang Liu wrote: > On 2015/1/23 14:54, Heiko Carstens wrote: > > On Fri, Jan 23, 2015 at 01:36:53PM +0800, Jiang Liu wrote: > >> Commit 9a46ad6d6df3b54 "smp: make smp_call_function_many() use logic > >> similar to smp_cal

Re: [Resend Patch v4 14/16] smp, s390: Kill SMP single function call interrupt

2015-01-23 Thread Heiko Carstens
On Fri, Jan 23, 2015 at 05:21:42PM +0800, Jiang Liu wrote: On 2015/1/23 14:54, Heiko Carstens wrote: On Fri, Jan 23, 2015 at 01:36:53PM +0800, Jiang Liu wrote: Commit 9a46ad6d6df3b54 smp: make smp_call_function_many() use logic similar to smp_call_function_single() has unified the way

Re: [Resend Patch v4 14/16] smp, s390: Kill SMP single function call interrupt

2015-01-22 Thread Heiko Carstens
terrupt > is needed for architecture specific code to support generic SMP function > call interfaces, so kill the redundant single function call interrupt. > > Signed-off-by: Jiang Liu > Acked-by: Heiko Carstens Is this really the patch I acked, whenever that was? Because the patch description

Re: [Resend Patch v4 14/16] smp, s390: Kill SMP single function call interrupt

2015-01-22 Thread Heiko Carstens
specific code to support generic SMP function call interfaces, so kill the redundant single function call interrupt. Signed-off-by: Jiang Liu jiang@linux.intel.com Acked-by: Heiko Carstens heiko.carst...@de.ibm.com Is this really the patch I acked, whenever that was? Because the patch

Re: [PATCH] s390: char: Free memory on error path.

2015-01-20 Thread Heiko Carstens
Signed-off-by: Heiko Carstens --- drivers/s390/char/hmcdrv_ftp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s390/char/hmcdrv_ftp.c b/drivers/s390/char/hmcdrv_ftp.c index 4bd63322fc29..d4b61d9088fb 100644 --- a/drivers/s390/char/hmcdrv_ftp.c +++ b/drive

Re: [PATCH] s390: char: Free memory on error path.

2015-01-20 Thread Heiko Carstens
patch Signed-off-by: Christophe Jaillet christophe.jail...@wanadoo.fr Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com --- drivers/s390/char/hmcdrv_ftp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s390/char/hmcdrv_ftp.c b/drivers/s390/char/hmcdrv_ftp.c

Re: [PATCH] [linux-next] s390: Dump check for CONFIG_ZFCPDUMP

2015-01-19 Thread Heiko Carstens
On Fri, Jan 16, 2015 at 10:35:05AM +0100, Paul Bolle wrote: > Commit 725908110a1f ("s390: add SMT support") added a check for > CONFIG_ZFCPDUMP. But the Kconfig symbol ZFCPDUMP was removed in v3.16 > through commit bf28a5970de3 ("s390/dump: Remove CONFIG_ZFCPDUMP"). So > this check will always

Re: [PATCH] [linux-next] s390: Dump check for CONFIG_ZFCPDUMP

2015-01-19 Thread Heiko Carstens
On Fri, Jan 16, 2015 at 10:35:05AM +0100, Paul Bolle wrote: Commit 725908110a1f (s390: add SMT support) added a check for CONFIG_ZFCPDUMP. But the Kconfig symbol ZFCPDUMP was removed in v3.16 through commit bf28a5970de3 (s390/dump: Remove CONFIG_ZFCPDUMP). So this check will always evaluate to

Re: [PATCH 1/1] scripts/recordmcount.pl: There is no -m32 option on Super-H

2015-01-18 Thread Heiko Carstens
On Sun, Jan 18, 2015 at 12:36:15AM +0100, Michael Karcher wrote: > Signed-Off-By: Michael Karcher > --- > scripts/recordmcount.pl | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl > index 56ea99a..537c38c 100755 > ---

Re: [PATCH 1/1] scripts/recordmcount.pl: There is no -m32 option on Super-H

2015-01-18 Thread Heiko Carstens
On Sun, Jan 18, 2015 at 12:36:15AM +0100, Michael Karcher wrote: Signed-Off-By: Michael Karcher ker...@mkarcher.dialup.fu-berlin.de --- scripts/recordmcount.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl index 56ea99a..537c38c 100755

[tip:locking/core] softirq/preempt: Add missing current-> preempt_disable_ip update

2015-01-14 Thread tip-bot for Heiko Carstens
Commit-ID: 0f1ba9a2cea52896448ef4e14a4cb1880b8e5bee Gitweb: http://git.kernel.org/tip/0f1ba9a2cea52896448ef4e14a4cb1880b8e5bee Author: Heiko Carstens AuthorDate: Wed, 7 Jan 2015 10:04:41 +0100 Committer: Ingo Molnar CommitDate: Wed, 14 Jan 2015 15:16:21 +0100 softirq/preempt: Add

[tip:locking/core] softirq/preempt: Add missing current- preempt_disable_ip update

2015-01-14 Thread tip-bot for Heiko Carstens
Commit-ID: 0f1ba9a2cea52896448ef4e14a4cb1880b8e5bee Gitweb: http://git.kernel.org/tip/0f1ba9a2cea52896448ef4e14a4cb1880b8e5bee Author: Heiko Carstens heiko.carst...@de.ibm.com AuthorDate: Wed, 7 Jan 2015 10:04:41 +0100 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 14 Jan 2015

Re: [PATCH RFT] s390: move cacheinfo sysfs to generic cacheinfo infrastructure

2015-01-08 Thread Heiko Carstens
to userspace via sysfs") > > Signed-off-by: Sudeep Holla > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux...@de.ibm.com > Cc: linux-s...@vger.kernel.org > --- > arch/s390/kernel/cache.c | 388 > +++ > 1 file

Re: [PATCH RFT] s390: move cacheinfo sysfs to generic cacheinfo infrastructure

2015-01-08 Thread Heiko Carstens
) Signed-off-by: Sudeep Holla sudeep.ho...@arm.com Cc: Martin Schwidefsky schwidef...@de.ibm.com Cc: Heiko Carstens heiko.carst...@de.ibm.com Cc: linux...@de.ibm.com Cc: linux-s...@vger.kernel.org --- arch/s390/kernel/cache.c | 388 +++ 1 file

[PATCH/resend] softirq/preempt: add missing current->preempt_disable_ip update

2015-01-07 Thread Heiko Carstens
ssing update of current->preempt_disable_ip to __local_bh_disable_ip() as well. Signed-off-by: Heiko Carstens --- kernel/softirq.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 501baa9ac1be..edd51027e3ab 100644 --- a/ker

Re: [PATCH v2 38/40] s390: macro whitespace fixes

2015-01-07 Thread Heiko Carstens
On Tue, Jan 06, 2015 at 05:45:38PM +0200, Michael S. Tsirkin wrote: > While working on arch/s390/include/asm/uaccess.h, I noticed > that a couple of macros within this header are made harder to read > because they violate a coding style rule: space is missing after comma. > > Fix it up. > >

Re: [PATCH] s390: crypto: aes_s390: Remove 'const' to avoid compiler warnings

2015-01-07 Thread Heiko Carstens
On Thu, Jan 01, 2015 at 10:56:02PM +0800, Chen Gang wrote: > In aes_encrypt() and aes_decrypt(), need let 'sctx->key' be modified, > so remove 'const' for it. The related warnings: ... > > Signed-off-by: Chen Gang > --- > arch/s390/crypto/aes_s390.c |4 ++-- > 1 file changed, 2

[PATCH/resend] softirq/preempt: add missing current-preempt_disable_ip update

2015-01-07 Thread Heiko Carstens
-preempt_disable_ip to __local_bh_disable_ip() as well. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com --- kernel/softirq.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 501baa9ac1be..edd51027e3ab 100644 --- a/kernel/softirq.c

Re: [PATCH] s390: crypto: aes_s390: Remove 'const' to avoid compiler warnings

2015-01-07 Thread Heiko Carstens
On Thu, Jan 01, 2015 at 10:56:02PM +0800, Chen Gang wrote: In aes_encrypt() and aes_decrypt(), need let 'sctx-key' be modified, so remove 'const' for it. The related warnings: ... Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- arch/s390/crypto/aes_s390.c |4 ++-- 1 file

<    5   6   7   8   9   10   11   12   13   14   >