On Sat, Nov 28, 2020 at 09:11:57PM +0530, Souptick Joarder wrote:
> Kernel test robot generates below warning ->
>
> >> arch/s390/kernel/vdso64/getcpu.c:8:5: warning: no previous prototype
> >> for function '__s390_vdso_getcpu' [-Wmissing-prototypes]
>int __s390_vdso_getcpu(unsigned *cpu, unsi
Hi Linus,
please pull one important s390 fix for 5.10-rc6.
Thanks,
Heiko
The following changes since commit 78d732e1f326f74f240d416af9484928303d9951:
s390/cpum_sf.c: fix file permission for cpum_sfb_size (2020-11-12 12:10:36
+0100)
are available in the Git repository at:
git://git.kernel
On Wed, Dec 16, 2020 at 06:52:59PM +0100, Peter Zijlstra wrote:
> On Tue, Dec 15, 2020 at 02:47:24PM -0500, Steven Rostedt wrote:
> > On Tue, 15 Dec 2020 20:01:52 +0100
> > Heiko Carstens wrote:
> >
> > > Hello,
> > >
> > > the ftrace stack trace
avoid rare interrupt stack corruption.
- Simplify udelay() and just let it busy loop instead of implementing a
complex logic.
- arch_cpu_idle() cleanup.
- Some other minor improvements.
--------
Heiko Carstens (10):
s390: always cl
Cc: Vasily Gorbik
Cc: Christian Borntraeger
Cc: "David S. Miller"
Fixes: b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2")
Signed-off-by: Heiko Carstens
---
arch/arm64/include/asm/unistd32.h | 2 +-
arch/mips/kernel/syscalls/syscall_n32.tbl | 2 +-
arch/s390/kerne
On Tue, Dec 01, 2020 at 08:14:41PM +0100, Peter Zijlstra wrote:
> On Tue, Dec 01, 2020 at 06:57:37PM +, Mark Rutland wrote:
> > On Tue, Dec 01, 2020 at 07:15:06PM +0100, Peter Zijlstra wrote:
> > > On Tue, Dec 01, 2020 at 03:55:19PM +0100, Peter Zijlstra wrote:
> > > > On Tue, Dec 01, 2020 at 0
> > But but but...
> >
> > do_idle() # IRQs on
> > local_irq_disable();# IRQs off
> > defaul_idle_call() # IRQs off
> lockdep_hardirqs_on(); # IRQs off, but lockdep things they're on
> > arch_cpu_idle() # IRQs off
> > enabled_wa
On Wed, Dec 02, 2020 at 10:38:05AM +0100, Peter Zijlstra wrote:
> On Wed, Dec 02, 2020 at 08:54:27AM +0100, Heiko Carstens wrote:
> > > > But but but...
> > > >
> > > > do_idle() # IRQs on
> > > > local_irq_disabl
On Wed, Dec 02, 2020 at 10:21:16AM +0100, Peter Zijlstra wrote:
> On Tue, Dec 01, 2020 at 08:18:56PM +0100, Heiko Carstens wrote:
> OK, so with a little help from s390/PoO and Sven, the code removed skips
> the TRACE_IRQS_OFF when IRQs were enabled in the old PSW (the previous
On Wed, Dec 02, 2020 at 11:16:05AM +, Mark Rutland wrote:
> On Wed, Dec 02, 2020 at 11:56:49AM +0100, Heiko Carstens wrote:
> > From 7bd86fb3eb039a4163281472ca79b9158e726526 Mon Sep 17 00:00:00 2001
> > From: Heiko Carstens
> > Date: Wed, 2 Dec 2020 11:46:01 +0100
>
.
>
> Cc: Heiko Carstens
> Cc: Vasily Gorbik
> Cc: David Hildenbrand
> Cc: linux-s...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual
> ---
> arch/s390/mm/extmem.c | 5 +
> arch/s390/mm/vmem.c | 13 +
d error return code ERANGE with E2BIG
>
> Changes in RFC V1:
>
> https://lore.kernel.org/linux-mm/1606098529-7907-1-git-send-email-anshuman.khand...@arm.com/
>
> Cc: Heiko Carstens
> Cc: Vasily Gorbik
> Cc: Catalin Marinas
> Cc: Will Deacon
> Cc: Ard Biesh
On Thu, Dec 03, 2020 at 06:03:00AM +0530, Anshuman Khandual wrote:
> >> diff --git a/arch/s390/mm/extmem.c b/arch/s390/mm/extmem.c
> >> index 5060956b8e7d..cc055a78f7b6 100644
> >> --- a/arch/s390/mm/extmem.c
> >> +++ b/arch/s390/mm/extmem.c
> >> @@ -337,6 +337,11 @@ __segment_load (char *name, int
On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote:
> From: Peter Zijlstra
>
> [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ]
>
> We call arch_cpu_idle() with RCU disabled, but then use
> local_irq_{en,dis}able(), which invokes tracing, which relies on RCU.
>
> Switch all
)
- fix lockdep irq state tracing
- fix logical vs physical CPU address confusion in PCI code
Alexander Gordeev (1):
s390/pci: fix CPU address in MSI for directed IRQ
Heiko
On Mon, Mar 01, 2021 at 08:01:33PM +0800, Wang Qing wrote:
> The copy_to_user() function returns the number of bytes remaining to be
> copied, but we want to return -EFAULT if the copy doesn't complete.
>
> Signed-off-by: Wang Qing
> ---
> drivers/s390/cio/vfio_ccw_ops.c | 4 ++--
> 1 file chang
On Mon, Mar 01, 2021 at 08:08:21PM +0800, Wang Qing wrote:
> The copy_to_user() function returns the number of bytes remaining to be
> copied, but we want to return -EFAULT if the copy doesn't complete.
>
> Signed-off-by: Wang Qing
> ---
> drivers/s390/crypto/vfio_ap_ops.c | 2 +-
> 1 file chang
On Wed, Jan 20, 2021 at 03:39:14PM +0100, Christian Borntraeger wrote:
> On 20.01.21 14:42, Heiko Carstens wrote:
> > On Tue, Jan 19, 2021 at 11:25:01AM +0100, Christian Borntraeger wrote:
> >>> + if (user_mode(regs)) {
> >>> +
On Tue, Jan 19, 2021 at 11:25:01AM +0100, Christian Borntraeger wrote:
> > + if (user_mode(regs)) {
> > + send_sig(SIGSEGV, current, 0);
> > + return;
> > + } else
> > + panic("Unexpected PGM 0x3d with TEID bit 61=0");
>
> u
90: remove IBM_PARTITION and CONFIGFS_FS from zfcpdump defconfig
Eric Farman (1):
s390/cio: return -EFAULT if copy_to_user() fails
Heiko Carstens (4):
s390/time,idle: get rid of unsigned long long
s390/topology: remove always false if check
s390,alpha: make TMPFS_INODE64
On Mon, Mar 01, 2021 at 01:07:26PM -0500, Eric Farman wrote:
>
>
> On 3/1/21 8:13 AM, Heiko Carstens wrote:
> > On Mon, Mar 01, 2021 at 08:01:33PM +0800, Wang Qing wrote:
> > > The copy_to_user() function returns the number of bytes remaining to be
> > > copied,
| 5 -
> mm/Kconfig | 9
> 15 files changed, 48 insertions(+), 122 deletions(-)
for the s390 bits:
Acked-by: Heiko Carstens
"inode64" in the mount options and thus passes it in the
> options for the remount.
>
>
> So prevent CONFIG_TMPFS_INODE64 from being selected on s390.
>
> Link:
> https://lkml.kernel.org/r/20210205230620.518245-1-seth.fors...@canonical.com
> Fixes: ea3271f7196
Hello,
the ftrace stack tracer kernel selftest is able to trigger the warning
below from time to time. This looks like there is an ordering problem
in __local_bh_enable_ip():
first there is a call to lockdep_softirqs_on() and afterwards
preempt_count_sub() is ftraced before it was able to modify
p
On Wed, Dec 16, 2020 at 06:52:59PM +0100, Peter Zijlstra wrote:
> On Tue, Dec 15, 2020 at 02:47:24PM -0500, Steven Rostedt wrote:
> > On Tue, 15 Dec 2020 20:01:52 +0100
> > Heiko Carstens wrote:
> >
> > > Hello,
> > >
> > > the ftrace stack trace
s390/crypto: add arch_get_random_long() support
Heiko Carstens (15):
s390: fix system call exit path
s390/mm: extend default vmalloc area size to 512GB
s390/mm: let vmalloc area size depend on physical memory size
s390: update defconfigs
s390/mm: remove unused clear
On Mon, Feb 24, 2014 at 05:04:57PM -0500, Tom Rini wrote:
> On 02/24/2014 05:02 PM, Joe Perches wrote:
> > On Mon, 2014-02-24 at 16:52 -0500, Tom Rini wrote:
> >> I've been lead to
> >> believe that most cases now people should be using regmap instead, which
> >> just leaves the case of having to m
On Mon, Nov 04, 2013 at 10:43:39AM +0100, Michael Opdenacker wrote:
> This removes the HAVE_MARCH_Z900_FEATURES and
> HAVE_MARCH_Z990_FEATURES Kconfig parameters,
> which were no longer used anywhere in the source code
> and Makefiles.
>
> Actually, HAVE_MARCH_Z990_FEATURES is no longer used
> aft
On Wed, Feb 26, 2014 at 06:13:06PM -0800, Josh Triplett wrote:
> The unconditionally built keyboard driver, drivers/s390/char/keyboard.c,
> requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build
> error.
>
> Signed-off-by: Josh Triplett
> ---
> arch/s390/Kconfig | 1 +
> 1 file ch
away.
Cc: Geert Uytterhoeven
Cc: Finn Thain
Signed-off-by: Heiko Carstens
---
arch/s390/Kconfig | 1 +
include/linux/futex.h | 4
init/Kconfig | 7 +++
kernel/futex.c| 37 -
4 files changed, 36 insertions(+), 13 deletions
Hi Andrew,
your patch "mm-per-thread-vma-caching-fix-5" in linux-next (see below) breaks
s390:
[ 10.101173] kernel BUG at mm/vmacache.c:76!
[ 10.101206] illegal operation: 0001 [#1] SMP DEBUG_PAGEALLOC
[ 10.101210] Modules linked in:
[ 10.101212] CPU: 3 PID: 2286 Comm: ifup-eth Not taint
On Wed, Mar 19, 2014 at 07:47:52AM +0100, Peter Zijlstra wrote:
> As per the existing implementation; implement the new one using
> smp_mb().
>
> AFAICT the s390 compare-and-swap does imply a barrier, however there
> are some immediate ops that seem to be singly-copy atomic and do not
> imply a ba
Hi all,
we plan to remove 31 bit kernel support of the s390 architecture in the
Linux kernel sources.
The reason for this is quite simple: the current 31 bit kernel was broken
for nearly a year before somebody noticed.
Keeping the 31 bit kernel support adds extra maintenance and development
effo
On Wed, Feb 19, 2014 at 04:06:11PM +, Sudeep Holla wrote:
> From: Sudeep Holla
>
> This patch removes the redundant sysfs cacheinfo code by making use of
> the newly introduced generic cacheinfo infrastructure.
>
> Signed-off-by: Sudeep Holla
> Cc: Martin Schwidefsky
On Thu, Feb 20, 2014 at 01:33:56PM +, Sudeep Holla wrote:
> Thanks, this info was helpful and looks like it's stupid mistake I did. I
> deleted a line unknowingly while trying to minimise the diff for
> show_cacheinfo.
> The below fix-up must work IIUC the issue. I will squash this in my next
nsion.
This was introduced with 56e41d3c5aa84 "merge compat sys_ipc instances".
Signed-off-by: Heiko Carstens
---
arch/s390/kernel/compat_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/compat_linux.c b/arch/s390/kernel/compa
ires that the caller of a function performed
zero and/or sign extension to 64 bit of all parameters.
Cc: sta...@vger.kernel.org # v3.10+
Signed-off-by: Heiko Carstens
---
fs/dcookies.c | 2 +-
include/linux/compat.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
ven't been converted from
unsigned long to compat_ulong_t.
This is needed for architectures where the ABI requires that the caller of
a function performed zero and/or sign extension to 64 bit of all parameters.
Cc: sta...@vger.kernel.org # v3.10+
Signed-off-by: Heiko Carstens
---
fs/read_writ
by the new x86 32 bit ABI which actually uses 64 bit
registers and therefore passes 64 bit values to the kernel. (?)
Heiko Carstens (3):
fs/compat: fix parameter handling for compat readv/writev syscalls
fs/compat: fix lookup_dcookie() parameter handling
s390/compat: change parameter
This was discovered with glibc's tst-fanotify test case.
Reported-by: Andreas Krebbel
Cc: "James E.J. Bottomley"
Cc: "David S. Miller"
Cc: Benjamin Herrenschmidt
Cc: Ingo Molnar
Cc: Ralf Baechle
Cc: sta...@vger.kernel.org # v3.10+
Signed-off-by: Heiko Carstens
---
fs/
Hi Roberto,
your patch 3ce1217d6cd5 "ima: define template fields library and new helpers"
causes s390 to crash on boot:
IMA: No TPM chip found, activating TPM-bypass!
Unable to handle kernel pointer dereference at virtual kernel address
00842000
Oops: 0004 [#1] SMP
Modules linked in:
On Fri, Nov 22, 2013 at 02:28:33PM +0100, Roberto Sassu wrote:
> On 11/22/2013 12:48 PM, Heiko Carstens wrote:
> >Hi Roberto,
> >
> >your patch 3ce1217d6cd5 "ima: define template fields library and new helpers"
> >causes s390 to crash on boot:
> >
>
Add missing "inline" statement to prevent couple of compiler warnings:
In file included from security/integrity/integrity_audit.c:16:0:
security/integrity/integrity.h:149:12: warning: 'integrity_init_keyring'
defined but not used [-Wunused-function]
Signed-off-by: Heiko Car
On Fri, Nov 22, 2013 at 05:23:49PM +0100, Roberto Sassu wrote:
> Another problem that I found is that strsep()
> modifies the source buffer by replacing the separator
> character with '\0'. In particular, this function
> modifies static data initialized at the beginning
> of the ima_template.c file
a config for this.
So I just committed the patch below... it compiles and doesn't crash
immediately, so must be good.
It will be merged during the next merge window.
>From 8c539d10400ee2efe000d324497a0661a2143dbf Mon Sep 17 00:00:00 2001
From: Heiko Carstens
Date: Fri, 11 Oct 2013 08:55:57
On Fri, Oct 11, 2013 at 05:34:19PM +0900, Namhyung Kim wrote:
> Hi Heiko,
>
> On Fri, 11 Oct 2013 09:21:56 +0200, Heiko Carstens wrote:
> > On Fri, Oct 11, 2013 at 12:17:17AM -0400, Steven Rostedt wrote:
> >> Isn't there a way we could pass the state? Hmm, I think
0/broadcast", O_RDONLY) = 5
[pid 2495] lseek(5, 0, SEEK_END) = 4096
[pid 2495] lseek(5, 0, SEEK_SET) = 0
[pid 2495] read(5, "ff:ff:ff:ff:ff:ff\n", 4096) = 18
[pid 2495] close(5)= 0
Tested-by: Heiko Carstens
--
To unsubscribe from this list:
On Fri, Nov 29, 2013 at 04:33:02PM +0100, Xose Vazquez Perez wrote:
> In current models, maximum number of active cores is 101.
>
> Cc: Martin Schwidefsky
> Cc: Heiko Carstens
> Cc:
> Cc:
> Cc:
> Signed-off-by: Xose Vazquez Perez
> ---
> arch/s390/Kconfig |
On Tue, Jul 29, 2014 at 03:19:47PM +0200, Rickard Strandqvist wrote:
> > It is guaranteed that the string ch->id always fits into CTCM_ID_SIZE.
> > What's in this case the benefit of replacing strncpy() by strlcpy()
> > here?
>
> If it is really so! It can just as well replacing it with strcpy...
hash
shift when the function returns. Afterwards correctly set futex_hashsize.
Fixes a crash on s390 where the requested allocation size was 4MB but only 1MB
was allocated.
Signed-off-by: Heiko Carstens
---
kernel/futex.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kern
On Sat, Sep 27, 2014 at 08:25:30AM +0200, Michael Opdenacker wrote:
> Remove the below Kconfig parameters, which are no longer
> used anywhere in the source code and Makefiles:
>
> HAVE_MARCH_Z900_FEATURES
> HAVE_MARCH_Z990_FEATURES
>
> Signed-off-by: Michael Opdenacker
What I wrote you a year
On Tue, Sep 16, 2014 at 01:17:44AM -0700, Dave Hansen wrote:
> >> The sysfs effects here cause an issue with the hwloc tool where
> >> it gets confused and thinks there are more sockets than are
> >> physically present.
> >
> > Meh, so then we need another mask.
>
> s390 has this concept of a "bo
On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote:
> This patch add a macro named NICE_TO_RLIMIT in prio.h to
> convert nice value [19,-20] to rlimit style value [1,40].
>
> Signed-off-by: Dongsheng Yang
> ---
> include/linux/sched/prio.h | 5 +
> 1 file changed, 5 insertions(+)
On Tue, Mar 11, 2014 at 04:20:24PM +0800, Dongsheng Yang wrote:
> On 03/11/2014 04:17 PM, Heiko Carstens wrote:
> >On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote:
> >>+#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1)
> >Where is MAX_NICE defined?
On Sun, Apr 27, 2014 at 05:35:43PM -0400, Jeff Mahoney wrote:
> This fixes:
> arch/s390/appldata/appldata_mem.c:135:2: error: implicit declaration of
> function 'kzalloc' [-Werror=implicit-function-declaration]
> arch/s390/appldata/appldata_mem.c:141:3: error: implicit declaration of
> function '
On Mon, May 19, 2014 at 06:31:15AM +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Delete unnecessary local variable whose value is always 0 and that hides
> the fact that the result is always 0.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://
On Sun, Feb 16, 2014 at 06:15:27PM +0100, Paul Bolle wrote:
> The Kconfig symbols HAVE_MARCH_Z900_FEATURES and
> HAVE_MARCH_Z990_FEATURES were added in v3.5. They have never been used.
> Apparently they are not needed. They can safely be removed.
>
No, I want to keep them, so there is a config sy
On Mon, Feb 17, 2014 at 09:50:40AM +0100, Paul Bolle wrote:
> On Mon, 2014-02-17 at 09:20 +0100, Heiko Carstens wrote:
> > On Sun, Feb 16, 2014 at 06:15:27PM +0100, Paul Bolle wrote:
> > No, I want to keep them, so there is a config symbol for each cpu generation
> > and we
Hi Sudeep,
> > Please have a look at these two commits which should describe why things
> > are as they are on s390:
> >
> > 881730ad365130f64b5c70c40904b04eb3b79de3
> > "s390/cache: expose cpu cache topology via sysfs"
> > 6668022c7bde3fdc96d3d257294a7216c7a46829
> > "s390/cache: add cpu cache
alls.sh will catch it and
> inform us about it during our next kernel build.
>
> If you add it to x86_64 only, bad luck for anyone else ;-)
Also it would be nice if somebody would pick up the patch below as well :)
>From 97cdc756ca508f2200ae0cebf1cf1f1b8daa711b Mon Sep 17 00:00:
gt; select VIRT_CPU_ACCOUNTING
> select VIRT_TO_BUS
> + select ARCH_HAS_SG_CHAIN
>
Acked-by: Heiko Carstens
FWIW, it would have been nice to keep the list of selected configs sorted.
However no need to resend.
--
To unsubscribe from this list: send the line "unsubscrib
On Sun, Mar 23, 2014 at 03:09:24PM -, Thomas Gleixner wrote:
> del_timer() does not wait for a possible running callback to
> complete. So the call side might free request and the associated
> objects while on another cpu the timer handler runs.
[...]
>
> - del_timer(&timeout);
> +
On Sun, Mar 23, 2014 at 03:09:25PM -, Thomas Gleixner wrote:
> Otherwise we leak a tracking object when DEBUG_OBJECTS is enabled.
> drivers/s390/net/lcs.c |1 +
> 1 file changed, 1 insertion(+)
>
> Index: tip/drivers/s390/net/lcs.c
> =
On Sun, Mar 23, 2014 at 03:09:25PM -, Thomas Gleixner wrote:
> Otherwise we leak a tracking object when DEBUG_OBJECTS is enabled.
>
[...]
> del_timer_sync(&timeout);
> + destroy_timer_on_stack(&timeout);
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscrib
On Wed, Jun 18, 2014 at 02:29:31PM -0700, Andrew Morton wrote:
> On Mon, 16 Jun 2014 11:04:50 +0200 Heiko Carstens
> wrote:
>
> > These two patches are supposed to "fix" failed order-4 memory
> > allocations which have been observed when reading /proc/stat.
>
On Sat, Jul 26, 2014 at 04:30:47PM +0200, Rickard Strandqvist wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/s390/char/sclp_async.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff
patches, I think.
But they don't apply against Linus' master tree and I wouldn't know which
tree these patches are against.
But anyway, it all looks good ;)
Acked-by: Heiko Carstens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
s. So if Sasha could confirm
that reverting the patch actually does fix the crash, please revert the
commit, unless somebody else can make sense of the report of course.
I'm still wondering how Sasha could reproduce the crash.
Thanks,
Heiko
On Sun, Jul 06, 2014 at 12:04:20PM +0200, Heiko Carsten
On Fri, Jul 04, 2014 at 05:12:35PM +0200, Helge Deller wrote:
> This patch affects big endian architectures only.
>
> On those with 32bit userspace and 64bit kernel (CONFIG_COMPAT=y) the
> 64bit mask parameter is correctly constructed out of two 32bit values in
> the compat_fanotify_mark() functio
On Fri, Jul 04, 2014 at 10:55:13AM -0400, Sasha Levin wrote:
> On 07/03/2014 05:37 PM, David Rientjes wrote:
> > On Wed, 2 Jul 2014, Sasha Levin wrote:
> >
> >>> Hi all,
> >>>
> >>> While fuzzing with trinity inside a KVM tools guest running the latest
> >>> -next
> >>> kernel I've stumbled on th
On Mon, Jul 07, 2014 at 03:54:37PM +0200, Helge Deller wrote:
> Hi Heiko,
> > So for sys_fanotify_mark everything is fine on s390, and probably most other
> > architectures as well. Having a 64 bit syscall parameter indeed does work,
> > if all the architecture specific details have been correctly
On Thu, Jul 03, 2014 at 02:00:46PM +0200, Vojtech Pavlik wrote:
> Add support for DYNAMIC_FTRACE_WITH_REGS to 64-bit and 31-bit s390
> architectures. This is required for kGraft and kpatch to work on s390.
>
> It's done by adding a _regs variant of ftrace_caller that preserves
> registers and puts
On Tue, Jun 10, 2014 at 10:46:20AM -0700, Kees Cook wrote:
> This makes sure format strings can't accidentally leak into kernel
> interface names.
>
> Signed-off-by: Kees Cook
> ---
> drivers/s390/block/dcssblk.c |2 +-
> drivers/s390/char/vmlogrdr.c |2 +-
> drivers/s390/crypto/
[full quote, since I added Al to cc]
On Mon, Jun 09, 2014 at 04:11:59PM +0800, Ian Kent wrote:
> On Wed, 2014-05-28 at 15:37 -0700, Andrew Morton wrote:
> > On Wed, 28 May 2014 11:01:53 +0200 Heiko Carstens
> > wrote:
> >
> > > Now, /proc/stat uses single_open()
On Wed, Jun 11, 2014 at 11:52:31PM -0700, David Rientjes wrote:
> On Thu, 12 Jun 2014, Ian Kent wrote:
> > > > +static void seq_alloc(struct seq_file *m)
> > > > +{
> > > > + m->size = PAGE_SIZE;
> > > > + m->buf = kmalloc(m->size, GFP_KERNEL | __GFP_NOWARN);
> > > > + if (!m->buf
On Thu, Jun 12, 2014 at 09:27:41AM +0200, Heiko Carstens wrote:
> On Wed, Jun 11, 2014 at 11:52:31PM -0700, David Rientjes wrote:
> > On Thu, 12 Jun 2014, Ian Kent wrote:
> > > > > +static void seq_alloc(struct seq_file *m)
> > > > > +{
> > > >
On Thu, Jun 12, 2014 at 03:00:17PM +0200, Stefan Bader wrote:
> When reading from /proc/stat we allocate a large buffer to maximise
> the chances of the results being from a single run and thus internally
> consistent. This currently is sized at 128 * num_possible_cpus() which,
> in the face of ke
lt we get less code, less bugs, and much more sanity checking.
Thanks,
Heiko
Heiko Carstens (44):
compat: let architectures define __ARCH_WANT_COMPAT_SYS_GETDENTS64
compat: add COMPAT_SYSCALL_DEFINE0 macro
s390/compat: convert to COMPAT_SYSCALL_DEFINEx part 1
Hi all,
I'm just wondering why /proc/stat is a single_open() seq_file and not a
regular seq_file with an iterator (say 48 online cpus for each iteration
or something similar).
Of course, in theory, the "intr" line may be very long as well...
With the current implementation everything must fit in
On Wed, May 21, 2014 at 07:32:29AM -0700, Christoph Hellwig wrote:
> On Wed, May 21, 2014 at 02:25:21PM +0200, Heiko Carstens wrote:
> > Hi all,
> >
> > I'm just wondering why /proc/stat is a single_open() seq_file and not a
> > regular seq_file with an itera
>] do_filp_open+0x46/0xa8
[62129.701616] [<0027541c>] do_sys_open+0x114/0x1f0
[62129.701618] [<005b1c1c>] sysc_tracego+0x14/0x1a
Signed-off-by: Heiko Carstens
---
fs/proc/stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/stat.c b/fs/proc/stat.
changes like e.g. that the cpu iterator
handles 32 cpus in a batch to avoid lots of iterations.
With this patch it should not happen anymore that reading /proc/stat
fails because of a failing high order memory allocation.
Signed-off-by: KAMEZAWA Hiroyuki
Signed-off-by: Heiko Carstens
---
fs/
On Wed, May 28, 2014 at 03:37:04PM -0700, Andrew Morton wrote:
> On Wed, 28 May 2014 11:01:53 +0200 Heiko Carstens
> wrote:
> > With this patch it should not happen anymore that reading /proc/stat
> > fails because of a failing high order memory allocation.
>
> So this
tly leading potentially to inconsistent data. This is
still the case after the change, however because of the iterator interface,
and the additional latencies we get with that, the per cpu statistics may
get more inconsistent than before.
If this is really an issue re
On Wed, Jun 04, 2014 at 11:31:11PM +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> This was partly found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/s390/scsi/zfcp_aux.c |1 +
>
cpus.
Signed-off-by: Heiko Carstens
---
fs/proc/stat.c | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/fs/proc/stat.c b/fs/proc/stat.c
index 9d231e9e5f0e..bf2d03f8fd3e 100644
--- a/fs/proc/stat.c
+++ b/fs/proc/stat.c
@@ -184,29 +184,11 @@ static int show
tions also work if memory
is fragmented.
This approach seems to be simpler and less intrusive than changing
/proc/stat to use an interator. Also it "fixes" other users as well,
which use seq_file's single_open() interface.
Heiko Carstens (2):
proc/stat: convert to single_open_size(
_last+0x382/0x10d0
[62129.701612] [<00287570>] path_openat+0xc8/0x4f8
[62129.701614] [<00288bde>] do_filp_open+0x46/0xa8
[62129.701616] [<0027541c>] do_sys_open+0x114/0x1f0
[62129.701618] [<005b1c1c>] sysc_tracego+0x14/0x1a
Signed-off-by:
On Tue, Jun 24, 2014 at 04:52:22PM -0700, David Rientjes wrote:
> On Mon, 23 Jun 2014, Andrew Morton wrote:
> > On Sat, 21 Jun 2014 11:10:58 +0200 Heiko Carstens
> > wrote:
> > > On Wed, Jun 18, 2014 at 02:29:31PM -0700, Andrew Morton wrote:
> > > > I'm
On Tue, Jun 24, 2014 at 08:06:55AM -0700, Davidlohr Bueso wrote:
> On Mon, 2014-06-23 at 08:58 +0200, Peter Zijlstra wrote:
> > While I like the general idea; does anyone have a better name for this?
> > So in particular, the difference is that on s390:
> >
> > cpu_relax()- yields
On Sun, Jan 26, 2014 at 08:54:18AM -0200, Jose Alonso wrote:
>
> I observed that there are for_each macros that do an extra memory access
> beyond the defined area.
> Normally this does not cause problems.
> But, this can cause exceptions. For example: if the area is allocated at
> the end of a pa
om before the different compat lookup_dcookie() versions have
been merged.
The declaration is now in include/linux/compat.h
The build error was reported by Fenguang's build bot.
Signed-off-by: Heiko Carstens
---
arch/tile/include/asm/compat.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/ti
There is not a single user in the whole kernel.
Besides that this_cpu_xor() is broken anyway since it gets
translated to this_cpu_or() (see __pcpu_size_call() line).
So instead of fixing an unused definition just remove it.
Signed-off-by: Heiko Carstens
---
include/linux/percpu.h | 32
o patches only remove the generic and x86 variant. It doesn't
touch s390 since it would only generate a merge conflict later on.
I will take care of s390 anyway if the consensus is that it should be
removed.
Heiko Carstens (2):
percpu: remove this_cpu_xor() implementation
x86: remove this_c
Remove the unused x86 implementation of this_cpu_xor().
Signed-off-by: Heiko Carstens
---
arch/x86/include/asm/percpu.h | 8
1 file changed, 8 deletions(-)
diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
index 0da5200..604e13d 100644
--- a/arch/x86/include
On Tue, Oct 22, 2013 at 03:29:46PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
>
> Signed-off-by: Joe Perches
> ---
> arch/s390/appldata/appldata_base.c | 10 +-
> arch/s390/kernel/debug.c | 2 +-
> arch/s390/mm/cmm.c |
y default]
return !memcmp(uuid, empty_zero_page, BTRFS_UUID_SIZE);
^
In fact there seem to be two more incorrect usages in the kernel. The patch
below is not really tested.
>From c2a9d3a453629466f0528aacbc6cbecc4247cff5 Mon Sep 17 00:00:00 2001
From: Heiko Carstens
Date: Fri, 15 Nov 2
On Fri, Nov 15, 2013 at 02:42:08PM +0100, Geert Uytterhoeven wrote:
> On Fri, Nov 15, 2013 at 2:40 PM, Chris Mason wrote:
> > Quoting Chris Mason (2013-11-15 07:21:31)
> >> Quoting Heiko Carstens (2013-11-15 06:32:16)
> >> > On Thu, Nov 14, 2013 at 12:19:52PM -0500,
On Fri, Feb 07, 2014 at 04:49:18PM +, Sudeep Holla wrote:
> From: Sudeep Holla
>
> This patch removes the redundant sysfs cacheinfo code by making use of
> the newly introduced generic cacheinfo infrastructure.
>
> Signed-off-by: Sudeep Holla
> Cc: Martin Schwidefsky
On Fri, Feb 07, 2014 at 04:49:18PM +, Sudeep Holla wrote:
> From: Sudeep Holla
>
> This patch removes the redundant sysfs cacheinfo code by making use of
> the newly introduced generic cacheinfo infrastructure.
>
> Signed-off-by: Sudeep Holla
[...]
> -static ssize_t shared_cpu_map_func(st
501 - 600 of 1083 matches
Mail list logo
