Re: [PATCH V2 4/6] Thermal: Remove the cooling_cpufreq_list.

2012-10-30 Thread Hongbo Zhang
On 30 October 2012 09:03, Amit Kachhap amit.kach...@linaro.org wrote: On 26 October 2012 12:39, hongbo.zhang hongbo.zh...@linaro.org wrote: From: hongbo.zhang hongbo.zh...@linaro.com Problem of using this list is that the cpufreq_get_max_state callback will be called when register cooling

Re: [PATCH V2 2/6] Thermal: make sure cpufreq cooling register after cpufreq driver

2012-10-30 Thread Hongbo Zhang
On 29 October 2012 12:42, Amit Kachhap amit.kach...@linaro.org wrote: On 24 October 2012 17:28, hongbo.zhang hongbo.zh...@linaro.org wrote: From: hongbo.zhang hongbo.zh...@linaro.com The cpufreq works as a cooling device, so the cooling layer should check if the cpufreq driver is

Re: [PATCH V3 5/5] Thermal: Add ST-Ericsson DB8500 thermal properties and platform data.

2012-11-05 Thread Hongbo Zhang
On 31 October 2012 10:18, viresh kumar viresh.ku...@linaro.org wrote: On Tue, Oct 30, 2012 at 10:19 PM, hongbo.zhang hongbo.zh...@linaro.org wrote: From: hongbo.zhang hongbo.zh...@linaro.com Just a minor comment below. This patch adds device tree properties for ST-Ericsson DB8500 thermal

Re: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-11-06 Thread Hongbo Zhang
@@ +/* + * db8500_cpufreq_cooling.c - DB8500 cpufreq works as cooling device. + * + * Copyright (C) 2012 ST-Ericsson + * Copyright (C) 2012 Linaro Ltd. + * + * Author: Hongbo Zhang hongbo.zh...@linaro.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms

Re: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-11-06 Thread Hongbo Zhang
On 6 November 2012 18:17, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 1 November 2012 09:52, Zhang, Rui rui.zh...@intel.com wrote: -Original Message- From: hongbo.zhang [mailto:hongbo.zh...@linaro.org] Sent: Wednesday, October 31, 2012 12:49 AM To: linaro-...@lists.linaro.org

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-22 Thread Hongbo Zhang
..bb065d4 --- /dev/null +++ b/drivers/thermal/db8500_cpufreq_cooling.c @@ -0,0 +1,118 @@ +/* + * db8500_cpufreq_cooling.c - db8500 cpufreq works as cooling device. + * + * Copyright (C) 2012 ST-Ericsson + * Copyright (C) 2012 Linaro Ltd. + * + * Author: Hongbo Zhang hognbo.zh...@stericsson.com

Re: [PATCH 1/5] Thermal: do bind operation after thermal zone or cooling device register returns.

2012-10-23 Thread Hongbo Zhang
Hi Francesco, I found out more points about this issue. [1] cdev should be ready when get_max_state callback be called, otherwise parameter cdev is useless, imagine there may be cases that get_max_state call back is shared by more than one cooling devices of same kind, like this:

Re: [PATCH 1/5] Thermal: do bind operation after thermal zone or cooling device register returns.

2012-10-23 Thread Hongbo Zhang
On 24 October 2012 06:13, Francesco Lavra francescolavra...@gmail.com wrote: Hi, On 10/23/2012 10:23 AM, Hongbo Zhang wrote: Hi Francesco, I found out more points about this issue. [1] cdev should be ready when get_max_state callback be called, otherwise parameter cdev is useless, imagine

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-23 Thread Hongbo Zhang
On 23 October 2012 02:51, Francesco Lavra francescolavra...@gmail.com wrote: On 10/22/2012 02:02 PM, Hongbo Zhang wrote: [...] +static irqreturn_t prcmu_low_irq_handler(int irq, void *irq_data) +{ + struct db8500_thermal_zone *pzone = irq_data; + struct db8500_thsens_platform_data

Re: [PATCH V2 6/6] Thermal: Add ST-Ericsson DB8500 thermal properties and platform data.

2012-10-24 Thread Hongbo Zhang
On 24 October 2012 22:32, Joe Perches j...@perches.com wrote: On Wed, 2012-10-24 at 19:58 +0800, hongbo.zhang wrote: This patch adds device tree properties for ST-Ericsson DB8500 thermal driver, also adds the platform data to support the old fashion. Just a trivial note: diff --git

Re: [PATCH V2 6/6] Thermal: Add ST-Ericsson DB8500 thermal properties and platform data.

2012-10-24 Thread Hongbo Zhang
[...] /* + * Thermal Sensor + */ + +static struct resource db8500_thsens_resources[] = { + { + .name = IRQ_HOTMON_LOW, + .start = IRQ_PRCMU_HOTMON_LOW, + .end= IRQ_PRCMU_HOTMON_LOW, + .flags = IORESOURCE_IRQ, +

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
[...] +/* Callback to get temperature changing trend */ +static int db8500_sys_get_trend(struct thermal_zone_device *thermal, + int trip, enum thermal_trend *trend) +{ + struct db8500_thermal_zone *pzone = thermal-devdata; + + *trend = pzone-trend; + +

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 16:41, Viresh Kumar viresh.ku...@linaro.org wrote: On 25 October 2012 13:56, Hongbo Zhang hongbo.zh...@linaro.org wrote: While replying to mails, don't remove lines like above. They help identifying who wrote what. [...] +/* Callback to get temperature changing trend

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 17:33, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 25 October 2012 16:41, Viresh Kumar viresh.ku...@linaro.org wrote: On 25 October 2012 13:56, Hongbo Zhang hongbo.zh...@linaro.org wrote: While replying to mails, don't remove lines like above. They help identifying who

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 17:42, Viresh Kumar viresh.ku...@linaro.org wrote: On 25 October 2012 15:03, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 25 October 2012 16:41, Viresh Kumar viresh.ku...@linaro.org wrote: Just paste my current pieces of codes here: static struct

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 18:11, Viresh Kumar viresh.ku...@linaro.org wrote: On 25 October 2012 15:34, Viresh Kumar viresh.ku...@linaro.org wrote: On 25 October 2012 15:26, Hongbo Zhang hongbo.zh...@linaro.org wrote: This is what your prcmu driver's routines are doing: int

Re: [PATCH V2 4/6] Thermal: Remove the cooling_cpufreq_list

2012-10-25 Thread Hongbo Zhang
On 26 October 2012 03:14, Francesco Lavra francescolavra...@gmail.com wrote: Hi, Hongbo Zhang wrote: Problem of using this list is that the cpufreq_get_max_state callback will be called when register cooling device by thermal_cooling_device_register, but this list isn't ready at this moment

Re: [PATCH V5 0/2] Upstream ST-Ericsson thermal driver

2012-11-09 Thread Hongbo Zhang
Hi Rui Zhang, Please have a look at this patch set. Since the previous 1/5, 2/5, 3/5 have been accepted, I'd like to send these last two updated patches with Reviewed-by added in this new thread. Thanks. On 9 November 2012 19:29, hongbo.zhang hongbo.zh...@linaro.org wrote: From: hongbo.zhang

Re: [PATCH V3 3/5] Thermal: Remove the cooling_cpufreq_list.

2012-11-09 Thread Hongbo Zhang
On 7 November 2012 14:54, Zhang Rui rui.zh...@intel.com wrote: On Tue, 2012-10-30 at 17:48 +0100, hongbo.zhang wrote: From: hongbo.zhang hongbo.zh...@linaro.com Problem of using this list is that the cpufreq_get_max_state callback will be called when register cooling device by

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-18 Thread Hongbo Zhang
) 2012 Linaro Ltd. + * + * Author: Hongbo Zhang hognbo.zh...@stericsson.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-18 Thread Hongbo Zhang
On 18 October 2012 16:07, Viresh Kumar viresh.ku...@linaro.org wrote: On 18 October 2012 13:05, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 17 October 2012 23:23, Viresh Kumar viresh.ku...@linaro.org wrote: On 16 October 2012 17:14, hongbo.zhang hongbo.zh...@linaro.org wrote: +static

[PATCH v8 0/5] Add ST-Ericsson AB8500 HWMON driver

2013-04-03 Thread Hongbo Zhang
by Samuel, so won't send it again. - Add another new patch ab8500_btemp: export two symblols as [2/2] of this patch set. Hongbo Zhang (5): ab8500_btemp: make ab8500_btemp_get* interfaces public ab8500: power: eliminate CamelCase warning of some variables ab8500: power: add const attributes

[PATCH v8 1/5] ab8500_btemp: make ab8500_btemp_get* interfaces public

2013-04-03 Thread Hongbo Zhang
Make ab8500_btemp_get_temp interface public, export it and also export the ab8500_btemp_get, ab8500_btemp_get_batctrl_temp interfaces, so that the ab8500 hwmon driver can use them. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_btemp.c | 5 - include

[PATCH v8 2/5] ab8500: power: eliminate CamelCase warning of some variables

2013-04-03 Thread Hongbo Zhang
Some AB8500 power related variable names don't comply with kernel coding rules, any new patch using these variables will result in CamelCase warnings from checkpatch.pl, this patch re-name these variables. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 24

[PATCH v8 3/5] ab8500: power: add const attributes to some data arrays

2013-04-03 Thread Hongbo Zhang
This patch adds const attributes to AB8500 power and temperature related read-only data arrays. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 20 ++-- drivers/power/ab8500_fg.c | 4 ++-- include/linux/mfd/abx500.h| 6 +++--- 3

[PATCH v8 4/5] ab8500: power: export abx500_res_to_temp tables for hwmon

2013-04-03 Thread Hongbo Zhang
This patch exports the thermistor resistance-to-temperature tables, so that the hwmon driver can access them, and also adds the corresponding table size variables. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 20 ++-- include/linux/power

[PATCH v8 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-04-03 Thread Hongbo Zhang
the same common layer abx500.c. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- Documentation/hwmon/ab8500 | 22 ++ Documentation/hwmon/abx500 | 28 +++ drivers/hwmon/Kconfig | 13 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon/ab8500.c | 206 +++ drivers

[PATCH v6 0/5] Add ST-Ericsson AB8500 HWMON driver

2013-03-26 Thread Hongbo Zhang
to abx500 for hwmon driver has been merged by Samuel, so won't send it again. - Add another new patch ab8500_btemp: export two symblols as [2/2] of this patch set. Hongbo Zhang (5): ab8500_btemp: make ab8500_btemp_get* interfaces public ab8500: power: eliminate CamelCase warning of some

[PATCH v6 1/5] ab8500_btemp: make ab8500_btemp_get* interfaces public

2013-03-26 Thread Hongbo Zhang
Make ab8500_btemp_get_temp interface public, export it and also export the ab8500_btemp_get, ab8500_btemp_get_batctrl_temp interfaces, so that the ab8500 hwmon driver can use them. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org Acked-by: Anton Vorontsov an...@enomsg.org --- drivers/power

[PATCH v6 2/5] ab8500: power: eliminate CamelCase warning of some variables

2013-03-26 Thread Hongbo Zhang
Some AB8500 power related variable names don't comply with kernel coding rules, any new patch using these variables will result in CamelCase warnings from checkpatch.pl, this patch re-name these variables. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 24

[PATCH v6 3/5] ab8500: power: add const attributes to some data arrays

2013-03-26 Thread Hongbo Zhang
This patch adds const attributes to AB8500 power and temperature related read-only data arrays. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 18 +- drivers/power/ab8500_fg.c | 4 ++-- include/linux/mfd/abx500.h| 6 +++--- 3

[PATCH v6 4/5] ab8500: power: export abx500_res_to_temp tables for hwmon

2013-03-26 Thread Hongbo Zhang
This patch exports the thermistor resistance-to-temperature tables, so that the hwmon driver can access them, and also adds the corresponding table size variables. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 16 ++-- include/linux/power

[PATCH v6 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-03-26 Thread Hongbo Zhang
the same common layer abx500.c. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- Documentation/hwmon/ab8500| 22 ++ Documentation/hwmon/abx500| 28 +++ drivers/hwmon/Kconfig | 13 ++ drivers/hwmon/Makefile| 1 + drivers/hwmon/ab8500.c| 206

Re: [PATCH v6 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-03-26 Thread Hongbo Zhang
On 26 March 2013 23:23, Guenter Roeck li...@roeck-us.net wrote: On Tue, Mar 26, 2013 at 03:06:59PM +0800, Hongbo Zhang wrote: Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for all ABX500s

[PATCH v7 0/5] Add ST-Ericsson AB8500 HWMON driver

2013-03-27 Thread Hongbo Zhang
] of this patch set. Hongbo Zhang (5): ab8500_btemp: make ab8500_btemp_get* interfaces public ab8500: power: eliminate CamelCase warning of some variables ab8500: power: add const attributes to some data arrays ab8500: power: export abx500_res_to_temp tables for hwmon hwmon: add ST

[PATCH v7 1/5] ab8500_btemp: make ab8500_btemp_get* interfaces public

2013-03-27 Thread Hongbo Zhang
Make ab8500_btemp_get_temp interface public, export it and also export the ab8500_btemp_get, ab8500_btemp_get_batctrl_temp interfaces, so that the ab8500 hwmon driver can use them. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org Acked-by: Anton Vorontsov an...@enomsg.org --- drivers/power

[PATCH v7 2/5] ab8500: power: eliminate CamelCase warning of some variables

2013-03-27 Thread Hongbo Zhang
Some AB8500 power related variable names don't comply with kernel coding rules, any new patch using these variables will result in CamelCase warnings from checkpatch.pl, this patch re-name these variables. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 24

[PATCH v7 3/5] ab8500: power: add const attributes to some data arrays

2013-03-27 Thread Hongbo Zhang
This patch adds const attributes to AB8500 power and temperature related read-only data arrays. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 18 +- drivers/power/ab8500_fg.c | 4 ++-- include/linux/mfd/abx500.h| 6 +++--- 3

[PATCH v7 4/5] ab8500: power: export abx500_res_to_temp tables for hwmon

2013-03-27 Thread Hongbo Zhang
This patch exports the thermistor resistance-to-temperature tables, so that the hwmon driver can access them, and also adds the corresponding table size variables. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/power/ab8500_bmdata.c | 20 ++-- include/linux/power

[PATCH v7 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-03-27 Thread Hongbo Zhang
the same common layer abx500.c. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- Documentation/hwmon/ab8500 | 22 ++ Documentation/hwmon/abx500 | 28 +++ drivers/hwmon/Kconfig | 13 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon/ab8500.c | 206 +++ drivers

Re: [PATCH v7 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-03-27 Thread Hongbo Zhang
On 28 March 2013 03:48, Guenter Roeck li...@roeck-us.net wrote: On Wed, Mar 27, 2013 at 03:13:32PM +0800, Hongbo Zhang wrote: Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for all ABX500s

[PATCH 0/2] Add ST-Ericsson AB8500 HWMON driver

2013-01-30 Thread Hongbo Zhang
These patches are against the v3.8-rc4. Guenter Roeck, Jean Delvare, Please help to have a look at this. Samuel Ortiz, Please review 1/2 and leave your Acked-by: if no problem, I think these patches should be merged into HWMON tree. Thanks for all. Hongbo Zhang (2): ARM: ux500: rename ab8500

[PATCH 1/2] ARM: ux500: rename ab8500 to abx500 for hwmon driver

2013-01-30 Thread Hongbo Zhang
We are using a generic abx500 hwmon layer, so rename specific ab8500 to generic abx500 for hwmon device and driver matching. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/mfd/ab8500-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd

[PATCH 2/2] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-01-30 Thread Hongbo Zhang
the same common layer abx500.c. Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org --- drivers/hwmon/Kconfig | 13 + drivers/hwmon/Makefile | 1 + drivers/hwmon/ab8500.c | 160 drivers/hwmon/abx500.c | 681 + drivers/hwmon/abx500.h

Re: [PATCH 1/2] ARM: ux500: rename ab8500 to abx500 for hwmon driver

2013-01-31 Thread Hongbo Zhang
On 30 January 2013 23:45, Samuel Ortiz sa...@linux.intel.com wrote: Hi Hongbo, On Wed, Jan 30, 2013 at 06:21:27PM +0800, Hongbo Zhang wrote: We are using a generic abx500 hwmon layer, so rename specific ab8500 to generic abx500 for hwmon device and driver matching. Signed-off-by: Hongbo

Re: [PATCH 2/2] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-01-31 Thread Hongbo Zhang
Guenter, Thank you so much for all the comments, will re-send a v2 iteration soon. On 31 January 2013 02:37, Guenter Roeck li...@roeck-us.net wrote: On Wed, Jan 30, 2013 at 06:21:28PM +0800, Hongbo Zhang wrote: Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 chips

Re: [PATCH 0/8] Thermal Framework Enhancements

2012-12-21 Thread Hongbo Zhang
On 21 December 2012 16:30, R, Durgadoss durgados...@intel.com wrote: Hi Ni, -Original Message- From: Wei Ni [mailto:w...@nvidia.com] Sent: Friday, December 21, 2012 1:36 PM To: R, Durgadoss Cc: Zhang, Rui; linux...@vger.kernel.org; linux-kernel@vger.kernel.org;

Re: [PATCH 4/8] Thermal: Add Thermal_trip sysfs node

2012-12-26 Thread Hongbo Zhang
On 18 December 2012 17:29, Durgadoss R durgados...@intel.com wrote: This patch adds a thermal_trip directory under /sys/class/thermal/zoneX. This directory contains the trip point values for sensors bound to this zone. Signed-off-by: Durgadoss R durgados...@intel.com ---

Re: [PATCH V5 2/2] Thermal: Add ST-Ericsson DB8500 thermal properties and platform data.

2012-11-14 Thread Hongbo Zhang
On 13 November 2012 04:46, Linus Walleij linus.wall...@linaro.org wrote: On Mon, Nov 12, 2012 at 7:07 AM, Zhang Rui rui.zh...@intel.com wrote: On Fri, 2012-11-09 at 19:29 +0800, hongbo.zhang wrote: From: hongbo.zhang hongbo.zh...@linaro.com This patch adds device tree properties for

Re: [PATCH V5 1/2] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-11-15 Thread Hongbo Zhang
On 15 November 2012 16:13, Zhang Rui rui.zh...@intel.com wrote: On Fri, 2012-11-09 at 19:29 +0800, hongbo.zhang wrote: From: hongbo.zhang hongbo.zh...@linaro.com This driver is based on the thermal management framework in thermal_sys.c. A thermal zone device is created with the trip points to

Re: [PATCH V5 1/2] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-11-15 Thread Hongbo Zhang
: On Thu, 2012-11-15 at 16:32 +0800, Hongbo Zhang wrote: On 15 November 2012 16:13, Zhang Rui rui.zh...@intel.com wrote: On Fri, 2012-11-09 at 19:29 +0800, hongbo.zhang wrote: From: hongbo.zhang hongbo.zh...@linaro.com This driver is based on the thermal management framework

Re: [PATCH V5 1/2] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-11-15 Thread Hongbo Zhang
On 15 November 2012 18:17, Viresh Kumar viresh.ku...@linaro.org wrote: On 15 November 2012 14:53, Hongbo Zhang hongbo.zh...@linaro.org wrote: this is a driver for ST-Ericsson u8500 board(Snowball), with a ARM core inside. so you should compile like this: make ARCH=arm CROSS_COMPILE=arm

Re: [PATCH v5 4/4] DMA: Freescale: eliminate a compiling warning

2013-07-24 Thread Hongbo Zhang
On 07/25/2013 03:33 AM, Scott Wood wrote: On 07/24/2013 01:21:09 AM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com The variable cookie is initialized in a list_for_each_entry loop, if(unlikely) the list is empty, this variable will be used uninitialized, so

Re: [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine

2013-07-29 Thread Hongbo Zhang
On 07/29/2013 06:59 PM, Vinod Koul wrote: On Mon, Jul 29, 2013 at 06:49:01PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi Vinod, Dan, Scott and Leo, please have a look at these V7 patches. The dma relates changes look okay to me. I need someone

Re: [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-07-29 Thread Hongbo Zhang
On 07/30/2013 06:10 AM, Scott Wood wrote: On 07/29/2013 05:49:03 AM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds the device tree nodes for them. Signed-off-by: Hongbo Zhang

Re: [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-08-22 Thread Hongbo Zhang
On 08/22/2013 07:16 AM, Stephen Warren wrote: On 08/21/2013 05:00 PM, Scott Wood wrote: On Wed, 2013-08-21 at 16:40 -0600, Stephen Warren wrote: On 07/29/2013 04:49 AM, hongbo.zh...@freescale.com wrote: +- reg : registers mapping for channel +- interrupts

Re: [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-08-26 Thread Hongbo Zhang
On 08/23/2013 11:17 AM, Hongbo Zhang wrote: On 08/22/2013 07:16 AM, Stephen Warren wrote: On 08/21/2013 05:00 PM, Scott Wood wrote: On Wed, 2013-08-21 at 16:40 -0600, Stephen Warren wrote: On 07/29/2013 04:49 AM, hongbo.zh...@freescale.com wrote: +- reg : registers

Re: [PATCH v8 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-08-28 Thread Hongbo Zhang
On 08/27/2013 07:35 PM, Mark Rutland wrote: On Tue, Aug 27, 2013 at 11:42:02AM +0100, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds the device tree nodes for them. Signed-off

Re: [PATCH v8 1/3] DMA: Freescale: revise device tree binding document

2013-08-28 Thread Hongbo Zhang
On 08/27/2013 07:25 PM, Mark Rutland wrote: On Tue, Aug 27, 2013 at 11:42:01AM +0100, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com This patch updates the discription of each type of DMA controller and its channels, it is preparation for adding another new DMA

Re: [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine

2013-08-20 Thread Hongbo Zhang
On 07/29/2013 06:59 PM, Vinod Koul wrote: On Mon, Jul 29, 2013 at 06:49:01PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi Vinod, Dan, Scott and Leo, please have a look at these V7 patches. The dma relates changes look okay to me. I need someone

Re: [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine

2013-08-21 Thread Hongbo Zhang
/20/2013 04:15 PM, Vinod Koul wrote: On Tue, Aug 20, 2013 at 04:33:46PM +0800, Hongbo Zhang wrote: On 07/29/2013 06:59 PM, Vinod Koul wrote: On Mon, Jul 29, 2013 at 06:49:01PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi Vinod, Dan, Scott and Leo

Re: [PATCH V2 1/2] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-07-11 Thread Hongbo Zhang
On 07/10/2013 12:48 AM, Scott Wood wrote: On 07/05/2013 01:27:05 AM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch add the device tree nodes for them. Signed-off-by: Hongbo Zhang

Re: [PATCH V2 1/2] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-07-17 Thread Hongbo Zhang
On 07/15/2013 09:31 PM, Kumar Gala wrote: On Jul 5, 2013, at 1:27 AM, hongbo.zh...@freescale.com hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch add the device tree nodes for them

Re: [PATCH v9 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-10 Thread Hongbo Zhang
Mark? ping. On 09/03/2013 05:01 PM, Hongbo Zhang wrote: On 09/02/2013 11:58 PM, Mark Rutland wrote: Hi, On Fri, Aug 30, 2013 at 12:26:19PM +0100, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines

Re: [PATCH v11 3/3] DMA: Freescale: update driver to support 8-channel DMA engine

2013-11-04 Thread Hongbo Zhang
Hi Vinod Koul and Dan Williams, Ping? On 10/17/2013 01:56 PM, Hongbo Zhang wrote: Hi Vinod, I have gotten ACK from Mark for both the 1/3 and 2/3 patches. Thanks. On 09/26/2013 05:33 PM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com This patch adds support

Re: [PATCH v9 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-16 Thread Hongbo Zhang
On 09/13/2013 01:15 AM, Mark Rutland wrote: On Tue, Sep 03, 2013 at 10:01:50AM +0100, Hongbo Zhang wrote: On 09/02/2013 11:58 PM, Mark Rutland wrote: Hi, On Fri, Aug 30, 2013 at 12:26:19PM +0100, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ

Re: [PATCH v11 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-10-15 Thread Hongbo Zhang
On 10/15/2013 09:38 PM, Mark Rutland wrote: On Tue, Oct 08, 2013 at 04:22:07AM +0100, Hongbo Zhang wrote: Hi Mark, Stephen and other DT maintainers? The 1/3 had already been acked by Mark, and please have a further look at this patch 2/3. The DMA maintainer Vinod needs ack for the DT related

Re: [PATCH v11 3/3] DMA: Freescale: update driver to support 8-channel DMA engine

2013-10-16 Thread Hongbo Zhang
Hi Vinod, I have gotten ACK from Mark for both the 1/3 and 2/3 patches. Thanks. On 09/26/2013 05:33 PM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com This patch adds support to 8-channel DMA engine, thus the driver works for both the new 8-channel

Re: [PATCH v11 3/3] DMA: Freescale: update driver to support 8-channel DMA engine

2013-11-11 Thread Hongbo Zhang
On 11/08/2013 10:45 AM, Dan Williams wrote: On Mon, Nov 4, 2013 at 6:31 PM, Hongbo Zhang hongbo.zh...@freescale.com wrote: Hi Vinod Koul and Dan Williams, Ping? Not much to review from the dmaengine side, just one question below. It would be helpful if you can send these to the new dmaengine

Re: [PATCH v11 3/3] DMA: Freescale: update driver to support 8-channel DMA engine

2013-11-11 Thread Hongbo Zhang
On 11/12/2013 08:09 AM, Dan Williams wrote: On Mon, Nov 11, 2013 at 1:12 AM, Hongbo Zhang hongbo.zh...@freescale.com wrote: diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 49e8fbd..16a9a48 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1261,7 +1261,9 @@ static

Re: [PATCH v11 0/3] DMA: Freescale: Add support for 8-channel DMA engine

2013-11-13 Thread Hongbo Zhang
On 11/13/2013 04:57 PM, Vinod Koul wrote: On Thu, Sep 26, 2013 at 05:33:40PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi DMA and DT maintainers, please have a look at these V11 patches. Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines

Re: [PATCH 0/7] DMA: Freescale: driver cleanups and enhancements

2014-02-25 Thread Hongbo Zhang
Hi Vinod, How about these patches? Thanks. On 01/16/2014 01:47 PM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Hi Vinod Koul and Dan Williams, Please have a look at these patches. Note that patch 2~6 had beed sent out for upstream before, but were together

Re: [PATCH v11 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-10-07 Thread Hongbo Zhang
: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds the device tree nodes for them. Signed-off-by: Hongbo Zhang hongbo.zh...@freescale.com --- .../devicetree/bindings/powerpc/fsl/dma.txt| 70

Re: [PATCHv6 02/16] drivers: thermal: introduce device tree parser

2013-10-08 Thread Hongbo Zhang
On 09/25/2013 10:15 PM, Eduardo Valentin wrote: On 25-09-2013 03:13, Hongbo Zhang wrote: On 09/19/2013 05:35 AM, Eduardo Valentin wrote: [...] + +/*** sensor API ***/ + You are introducing new concept here, the original framework and drivers cannot use this, right? any further plan

Re: [PATCH 2/2] fsl: set wakeup sources

2013-09-06 Thread Hongbo Zhang
Sorry linux-kernel subscribers, This is for team internal review, linux-kernel is cced due to my carelessness, omit this mail please. On 09/06/2013 02:46 PM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Some devices can work as wakeup sources, they should

Re: [PATCH v8 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-08-28 Thread Hongbo Zhang
On 08/28/2013 08:51 PM, Mark Rutland wrote: On Wed, Aug 28, 2013 at 07:54:01AM +0100, Hongbo Zhang wrote: On 08/27/2013 07:35 PM, Mark Rutland wrote: On Tue, Aug 27, 2013 at 11:42:02AM +0100, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4

Re: [PATCH v9 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-03 Thread Hongbo Zhang
On 09/02/2013 11:58 PM, Mark Rutland wrote: Hi, On Fri, Aug 30, 2013 at 12:26:19PM +0100, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds the device tree nodes for them. Signed-off

Re: [PATCH 2/2] DMA: Freescale: update driver to support 8-channel DMA engine

2013-07-02 Thread Hongbo Zhang
On 07/03/2013 07:13 AM, Scott Wood wrote: On 06/30/2013 10:46:18 PM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com This patch adds support to 8-channel DMA engine, thus the driver works for both the new 8-channel and the legacy 4-channel DMA engines. Signed

Re: [PATCH 1/2] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-07-02 Thread Hongbo Zhang
hmm...add the devicetree-disc...@lists.ozlabs.org into list. Note that we are discussing a better naming for this new compatible property in the corresponding [PATCH 2/2], so I will resend a v2 of this patch. On 07/01/2013 11:46 AM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang

Re: [PATCH 1/2] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-07-03 Thread Hongbo Zhang
On 07/03/2013 11:53 AM, Hongbo Zhang wrote: hmm...add the devicetree-disc...@lists.ozlabs.org into list. Note that we are discussing a better naming for this new compatible property in the corresponding [PATCH 2/2], so I will resend a v2 of this patch. On 07/01/2013 11:46 AM, hongbo.zh

Re: [PATCH 05/21] cpuidle: make __cpuidle_driver_init() return void

2013-09-23 Thread Hongbo Zhang
On 09/22/2013 09:20 AM, Viresh Kumar wrote: __cpuidle_driver_init() doesn't return anything except zero and so doesn't really need a return type other than void. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpuidle/driver.c | 8 ++-- 1 file changed, 2 insertions(+), 6

Re: [RFC PATCH] thermal: add generic cpu hotplug cooling device

2013-09-23 Thread Hongbo Zhang
On 09/21/2013 06:15 AM, Zoran Markovic wrote: This patch implements a generic CPU hotplug cooling device. The implementation scales down the number of running CPUs when temperature increases through a thermal trip point and prevents booting CPUs until thermal conditions are restored. Upon

Re: [PATCHv6 02/16] drivers: thermal: introduce device tree parser

2013-09-24 Thread Hongbo Zhang
On 09/23/2013 06:40 PM, Mark Rutland wrote: Hi Eduardo, Apologies for having taken so long to get back you on this. I have several comments on the binding and the way it's parsed. On Wed, Sep 18, 2013 at 10:35:36PM +0100, Eduardo Valentin wrote: This patch introduces a device tree bindings

Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-24 Thread Hongbo Zhang
On 09/24/2013 01:04 AM, Stephen Warren wrote: On 09/18/2013 04:15 AM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds the device tree nodes for them. diff --git a/Documentation

Re: [PATCHv6 02/16] drivers: thermal: introduce device tree parser

2013-09-24 Thread Hongbo Zhang
and reply it for further concerns. On 24-09-2013 04:11, Hongbo Zhang wrote: On 09/23/2013 06:40 PM, Mark Rutland wrote: Hi Eduardo, Apologies for having taken so long to get back you on this. I have several comments on the binding and the way it's parsed. On Wed, Sep 18, 2013 at 10:35:36PM

Re: [PATCHv6 02/16] drivers: thermal: introduce device tree parser

2013-09-25 Thread Hongbo Zhang
On 09/19/2013 05:35 AM, Eduardo Valentin wrote: [...] + +/*** sensor API ***/ + You are introducing new concept here, the original framework and drivers cannot use this, right? any further plan to update original framework for this new feature? +static struct thermal_zone_device *

Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-25 Thread Hongbo Zhang
On 09/25/2013 01:31 AM, Stephen Warren wrote: On 09/24/2013 04:30 AM, Hongbo Zhang wrote: On 09/24/2013 01:04 AM, Stephen Warren wrote: On 09/18/2013 04:15 AM, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Freescale QorIQ T4 and B4 introduce new 8-channel

Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-25 Thread Hongbo Zhang
On 09/26/2013 10:28 AM, David Gibson wrote: On Wed, Sep 25, 2013 at 08:46:32PM -0500, Scott Wood wrote: On Wed, 2013-09-25 at 15:35 +0800, Hongbo Zhang wrote: By the way, I know maybe it is difficult, but why not introduce a document of maintaining rules for the dt binding docs? we have

Re: [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver

2014-05-08 Thread Hongbo Zhang
On 05/07/2014 04:31 PM, Shevchenko, Andriy wrote: On Sun, 2014-05-04 at 18:22 +0800, Hongbo Zhang wrote: On 05/03/2014 12:46 AM, Vinod Koul wrote: On Fri, Apr 18, 2014 at 04:17:51PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com This patch adds

Re: [PATCH v4 6/8] DMA: Freescale: change descriptor release process for supporting async_tx

2014-05-08 Thread Hongbo Zhang
On 05/03/2014 12:50 AM, Vinod Koul wrote: On Fri, Apr 18, 2014 at 04:17:49PM +0800, hongbo.zh...@freescale.com wrote: This need review from Dan ... Dan, could you please have a look at this? thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver

2014-05-21 Thread Hongbo Zhang
On 05/21/2014 11:45 AM, Vinod Koul wrote: On Thu, May 08, 2014 at 05:52:37PM +0800, Hongbo Zhang wrote: On 05/07/2014 04:31 PM, Shevchenko, Andriy wrote: On Sun, 2014-05-04 at 18:22 +0800, Hongbo Zhang wrote: On 05/03/2014 12:46 AM, Vinod Koul wrote: On Fri, Apr 18, 2014 at 04:17:51PM +0800

Re: [PATCH 1/2] Documentation: move all DMA documentations into Documentaion/dma

2014-01-16 Thread Hongbo Zhang
Learned, will try, I didn't like this long patch either. Thanks. On 01/16/2014 06:43 PM, Andy Shevchenko wrote: On Thu, 2014-01-16 at 18:37 +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Since there are already seven DMA documentations under the top

Re: [PATCH resend 1/2] Documentation: move all DMA documentations into Documentaion/dma

2014-01-20 Thread Hongbo Zhang
On 01/20/2014 12:29 PM, Vinod Koul wrote: On Sat, Jan 18, 2014 at 11:59:13AM -0600, Rob Landley wrote: On 01/16/14 09:59, Vinod Koul wrote: On Thu, Jan 16, 2014 at 06:50:04PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com Since there are already seven

Re: [PATCH] DTS: DMA: Fix DMA3 interrupts

2013-12-12 Thread Hongbo Zhang
On 12/11/2013 02:33 AM, Scott Wood wrote: On Tue, 2013-12-10 at 18:33 +0800, Hongbo Zhang wrote: Scott, This issue is due to the non-continuous MPIC register, I think there is two ways to fix it. The first one is as what we are discussing, in fact the Bman/Qman DT author had introduced

Re: [PATCH] DTS: DMA: Fix DMA3 interrupts

2013-12-10 Thread Hongbo Zhang
not for interrupts */ mpic_assign_isu(mpic, i, mpic-paddr + addr_off); } // Add this end mpic_init(mpic); } On 12/07/2013 03:21 AM, Scott Wood wrote: On Fri, 2013-11-29 at 16:07 +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com MPIC registers

Re: [PATCH 3/7] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-03-27 Thread Hongbo Zhang
On 03/11/2014 07:06 PM, Vinod Koul wrote: On Thu, Jan 16, 2014 at 01:47:22PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com There are several places where descriptors are freed using identical code. This patch puts this code into a function to reduce

Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-03-28 Thread Hongbo Zhang
On 03/26/2014 03:01 PM, Vinod Koul wrote: On Thu, 2014-01-16 at 13:47 +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com The usage of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking required

Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-05-04 Thread Hongbo Zhang
On 05/03/2014 12:51 AM, Vinod Koul wrote: On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com The usage of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking

Re: [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver

2014-05-04 Thread Hongbo Zhang
On 05/03/2014 12:46 AM, Vinod Koul wrote: On Fri, Apr 18, 2014 at 04:17:51PM +0800, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang hongbo.zh...@freescale.com This patch adds suspend resume functions for Freescale DMA driver. .prepare callback is used to stop further descriptors from

Re: [PATCH v3 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-04-17 Thread Hongbo Zhang
On 04/14/2014 09:40 PM, Andy Shevchenko wrote: On Fri, 2014-04-11 at 16:14 +0800, Hongbo Zhang wrote: On 04/10/2014 07:29 PM, Andy Shevchenko wrote: On Thu, 2014-04-10 at 15:10 +0800, hongbo.zh...@freescale.com wrote: [] @@ -819,8 +826,7 @@ static void fsldma_cleanup_descriptor(struct

  1   2   3   >