Return silently instead of falling into error when running
out of available buffers when restarting capture.
Capture will be restarted when new buffers will be
provided by V4L2 client.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 7 ++-
1 file changed, 2
Return silently instead of falling into error when running
out of available buffers when restarting capture.
Capture will be restarted when new buffers will be
provided by V4L2 client.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 7 ++-
1 file changed, 2
Minor non-functional fixes around comments, variable namings
and trace point enhancement.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
Revisit and fix DCMI buffers handling.
Hugues Fruchet (4):
media: stm32-dcmi: do not fall into error on buffer starvation
media: stm32-dcmi: return buffer in error state on dma error
media: stm32-dcmi: clarify state logic on buffer starvation
media: stm32-dcmi: revisit buffer list
Cleanup "active" field usage and enhance list management
to avoid exceptions when releasing buffers on error or
stopping streaming.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 65 +++
1 file changed, 31 insertions(+), 34
Return buffer to V4L2 in error state if DMA error occurs.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index a3fbfac
Introduce WAIT_FOR_BUFFER state instead of "active" field checking
to manage buffer starvation case.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/s
Minor non-functional fixes around comments, variable namings
and trace point enhancement.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
Revisit and fix DCMI buffers handling.
Hugues Fruchet (4):
media: stm32-dcmi: do not fall into error on buffer starvation
media: stm32-dcmi: return buffer in error state on dma error
media: stm32-dcmi: clarify state logic on buffer starvation
media: stm32-dcmi: revisit buffer list
Cleanup "active" field usage and enhance list management
to avoid exceptions when releasing buffers on error or
stopping streaming.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 65 +++
1 file changed, 31 insertions(+), 34
Return buffer to V4L2 in error state if DMA error occurs.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index a3fbfac
Introduce WAIT_FOR_BUFFER state instead of "active" field checking
to manage buffer starvation case.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/s
DCMI can capture 5Mp raw frames, increase limit accordingly.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform
DCMI can capture 5Mp raw frames, increase limit accordingly.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform
Implements runtime & system sleep power management ops.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 80 ---
1 file changed, 64 insertions(+), 16 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/m
Implements runtime & system sleep power management ops.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 80 ---
1 file changed, 64 insertions(+), 16 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/m
, this slows down
system and lead to more overrun errors. Use a counter
instead and log errors at stop streaming.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
version 2:
- typo: remove blank line at the end of stop_streaming()
drivers/media/platform/stm32/stm32-dcmi.
, this slows down
system and lead to more overrun errors. Use a counter
instead and log errors at stop streaming.
Signed-off-by: Hugues Fruchet
---
version 2:
- typo: remove blank line at the end of stop_streaming()
drivers/media/platform/stm32/stm32-dcmi.c | 29 +++--
1
Add DCMI JPEG support.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
version 2:
- Removed V4L2_FMT_FLAG_COMPRESSED flag setting already set by V4L2 core
See https://www.mail-archive.com/linux-media@vger.kernel.org/msg126825.html
drivers/media/platform/stm32/stm32-dcmi.c
Add DCMI JPEG support.
Signed-off-by: Hugues Fruchet
---
version 2:
- Removed V4L2_FMT_FLAG_COMPRESSED flag setting already set by V4L2 core
See https://www.mail-archive.com/linux-media@vger.kernel.org/msg126825.html
drivers/media/platform/stm32/stm32-dcmi.c | 193
Hi Hans,
Yes depends on 'fix lock scheme', I'll send a v2 of this jpeg commit for
unneeded V4L2_FMT_FLAG_COMPRESSED.
Best regards,
Hugues.
On 02/26/2018 03:17 PM, Hans Verkuil wrote:
> On 02/22/2018 10:51 AM, Hugues Fruchet wrote:
>> Add DCMI JPEG support.
>
> Does th
Hi Hans,
Yes depends on 'fix lock scheme', I'll send a v2 of this jpeg commit for
unneeded V4L2_FMT_FLAG_COMPRESSED.
Best regards,
Hugues.
On 02/26/2018 03:17 PM, Hans Verkuil wrote:
> On 02/22/2018 10:51 AM, Hugues Fruchet wrote:
>> Add DCMI JPEG support.
>
> Does th
lock management.
On 02/26/2018 02:56 PM, Hans Verkuil wrote:
> On 02/22/2018 10:49 AM, Hugues Fruchet wrote:
>> Fix lock scheme leading to spurious freeze.
>
> Can you elaborate a bit more? It's hard to review since you don't
> describe what was wrong and why this fixes the
lock management.
On 02/26/2018 02:56 PM, Hans Verkuil wrote:
> On 02/22/2018 10:49 AM, Hugues Fruchet wrote:
>> Fix lock scheme leading to spurious freeze.
>
> Can you elaborate a bit more? It's hard to review since you don't
> describe what was wrong and why this fixes the
Fix unnecessary parentheses in if conditions.
Detected by checkpatch.pl --strict.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform
Fix unnecessary parentheses in if conditions.
Detected by checkpatch.pl --strict.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers
Add DCMI JPEG support.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 195 +++---
1 file changed, 148 insertions(+), 47 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/pl
Add DCMI JPEG support.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 195 +++---
1 file changed, 148 insertions(+), 47 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index
Fix lock scheme leading to spurious freeze.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
version 2:
- dcmi_buf_queue() refactor to avoid to have "else" after "return"
(warning detected by checkpatch.pl --strict -f stm32-dcmi.c)
drivers/media/platfo
Fix lock scheme leading to spurious freeze.
Signed-off-by: Hugues Fruchet
---
version 2:
- dcmi_buf_queue() refactor to avoid to have "else" after "return"
(warning detected by checkpatch.pl --strict -f stm32-dcmi.c)
drivers/media/platform/stm
, this slows down
system and lead to more overrun errors. Use a counter
instead and log errors at stop streaming.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
version 2:
- Minor: remove extra line at end of dcmi_stop_streaming()
drivers/media/platform/stm32/stm32-dcmi.
, this slows down
system and lead to more overrun errors. Use a counter
instead and log errors at stop streaming.
Signed-off-by: Hugues Fruchet
---
version 2:
- Minor: remove extra line at end of dcmi_stop_streaming()
drivers/media/platform/stm32/stm32-dcmi.c | 29
Thanks Hans,
v2 sent, rebased on your helpers !
Best regards,
Hugues.
On 02/07/2018 06:52 PM, Hans Verkuil wrote:
> On 02/07/2018 06:43 PM, Hugues Fruchet wrote:
>> Add g/s_parm framerate support by calling subdev
>> g/s_frame_interval ops.
>> This allows user to con
Thanks Hans,
v2 sent, rebased on your helpers !
Best regards,
Hugues.
On 02/07/2018 06:52 PM, Hans Verkuil wrote:
> On 02/07/2018 06:43 PM, Hugues Fruchet wrote:
>> Add g/s_parm framerate support by calling subdev
>> g/s_frame_interval ops.
>> This allows user to con
Add g/s_parm framerate support by calling subdev
g/s_frame_interval ops.
This allows user to control sensor framerate by
calling ioctl G/S_PARM.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
version 2:
- Rebase on Hans branch to use new helpers:
See https://www.mail-archi
Add g/s_parm framerate support by calling subdev
g/s_frame_interval ops.
This allows user to control sensor framerate by
calling ioctl G/S_PARM.
Signed-off-by: Hugues Fruchet
---
version 2:
- Rebase on Hans branch to use new helpers:
See https://www.mail-archive.com/linux-media
Add g/s_parm framerate support by calling subdev
g/s_frame_interval ops.
This allows user to control sensor framerate by
calling ioctl G/S_PARM.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 49 +++
Add g/s_parm framerate support by calling subdev
g/s_frame_interval ops.
This allows user to control sensor framerate by
calling ioctl G/S_PARM.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 49 +++
1 file changed, 49 insertions
, this slows down
system and lead to more overrun errors. Use a counter
instead and log errors at stop streaming.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 30 --
1 file changed, 12 insertions(+), 18 del
, this slows down
system and lead to more overrun errors. Use a counter
instead and log errors at stop streaming.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers
Fix lock scheme leading to spurious freeze.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 57 ++-
1 file changed, 25 insertions(+), 32 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcm
Fix lock scheme leading to spurious freeze.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 57 ++-
1 file changed, 25 insertions(+), 32 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32
Remove some redundant code and fix/enhance some
error trace points.
Hugues Fruchet (3):
media: stm32-dcmi: remove redundant capture enable
media: stm32-dcmi: remove redundant clear of interrupt flags
media: stm32-dcmi: improve error trace points
drivers/media/platform/stm32/stm32-dcmi.c
Remove some redundant code and fix/enhance some
error trace points.
Hugues Fruchet (3):
media: stm32-dcmi: remove redundant capture enable
media: stm32-dcmi: remove redundant clear of interrupt flags
media: stm32-dcmi: improve error trace points
drivers/media/platform/stm32/stm32-dcmi.c
Remove redundant capture enable already done
in dcmi_start_capture().
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/pl
Remove redundant capture enable already done
in dcmi_start_capture().
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index
It is already cleared in dcmi_irq_callback().
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
It is already cleared in dcmi_irq_callback().
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index abc79d8..dfab867 100644
Fix some missing "\n".
Trace error returned by subdev streamon/streamoff.
Remove extra "0x" unneeded with %pad formatter.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 16 +---
1 file changed, 9
Fix some missing "\n".
Trace error returned by subdev streamon/streamoff.
Remove extra "0x" unneeded with %pad formatter.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
ink of this proposal ?
Best regards,
Hugues.
On 01/04/2018 01:19 AM, Andi Kleen wrote:
> On Wed, Jan 03, 2018 at 09:40:04AM +, Hugues FRUCHET wrote:
>> Hi Andi,
>> Thanks for the patch but I would suggest to use strlcpy instead, this
>> will guard msg.name overwriting and add the
ink of this proposal ?
Best regards,
Hugues.
On 01/04/2018 01:19 AM, Andi Kleen wrote:
> On Wed, Jan 03, 2018 at 09:40:04AM +, Hugues FRUCHET wrote:
>> Hi Andi,
>> Thanks for the patch but I would suggest to use strlcpy instead, this
>> will guard msg.name overwriting and add the
Hi Andi,
Thanks for the patch but I would suggest to use strlcpy instead, this
will guard msg.name overwriting and add the NULL termination in case
of truncation:
- memcpy(msg.name, name, sizeof(msg.name));
- msg.name[sizeof(msg.name) - 1] = 0;
+ strlcpy(msg.name, name,
Hi Andi,
Thanks for the patch but I would suggest to use strlcpy instead, this
will guard msg.name overwriting and add the NULL termination in case
of truncation:
- memcpy(msg.name, name, sizeof(msg.name));
- msg.name[sizeof(msg.name) - 1] = 0;
+ strlcpy(msg.name, name,
blished by the Free Software Foundation; either version 2 of
> - * the License, or (at your option) any later version.
>*/
> #ifndef _C8SECTPFE_DVB_H_
> #define _C8SECTPFE_DVB_H_
> diff --git a/drivers/media/platform/sti/cec/stih-cec.c
> b/drivers/media/platform/
/media/platform/sti/cec/stih-cec.c
> b/drivers/media/platform/sti/cec/stih-cec.c
> index 70160df36de9..d34099f75990 100644
> --- a/drivers/media/platform/sti/cec/stih-cec.c
> +++ b/drivers/media/platform/sti/cec/stih-cec.c
> @@ -1,11 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
&g
On 08/04/2017 02:00 PM, Hans Verkuil wrote:
> On 28/07/17 12:05, Hugues Fruchet wrote:
>> Ensure that we start with default pixel format and resolution
>> when opening a new instance.
>
> Why? The format is persistent in V4L2 and (re)opening the video device
> sho
On 08/04/2017 02:00 PM, Hans Verkuil wrote:
> On 28/07/17 12:05, Hugues Fruchet wrote:
>> Ensure that we start with default pixel format and resolution
>> when opening a new instance.
>
> Why? The format is persistent in V4L2 and (re)opening the video device
> sho
Hi Hans, thanks for reviewing
On 08/04/2017 02:26 PM, Hans Verkuil wrote:
> On 28/07/17 12:05, Hugues Fruchet wrote:
>> Implements g_/s_selection crop support by using DCMI crop
>> hardware feature.
>> User can first get the maximum supported resolution of the sensor
>
Hi Hans, thanks for reviewing
On 08/04/2017 02:26 PM, Hans Verkuil wrote:
> On 28/07/17 12:05, Hugues Fruchet wrote:
>> Implements g_/s_selection crop support by using DCMI crop
>> hardware feature.
>> User can first get the maximum supported resolution of the sensor
>
50, Failed: 1, Warnings: 0
Hugues Fruchet (5):
[media] stm32-dcmi: catch dma submission error
[media] stm32-dcmi: revisit control register handling
[media] stm32-dcmi: cleanup variable/fields namings
[media] stm32-dcmi: set default format at open()
[media] stm32-dcmi: g_/s_selection cr
50, Failed: 1, Warnings: 0
Hugues Fruchet (5):
[media] stm32-dcmi: catch dma submission error
[media] stm32-dcmi: revisit control register handling
[media] stm32-dcmi: cleanup variable/fields namings
[media] stm32-dcmi: set default format at open()
[media] stm32-dcmi: g_/s_selection cr
Simplify bits handling of DCMI_CR register.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/pl
Ensure that we start with default pixel format and resolution
when opening a new instance.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 49 ++-
1 file changed, 28 insertions(+), 21 deletions(-)
diff
Simplify bits handling of DCMI_CR register.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
Ensure that we start with default pixel format and resolution
when opening a new instance.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 49 ++-
1 file changed, 28 insertions(+), 21 deletions(-)
diff --git a/drivers/media/platform
() resolution
user request is adjusted to match crop request resolution.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 367 +-
1 file changed, 363 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform
() resolution
user request is adjusted to match crop request resolution.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 367 +-
1 file changed, 363 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers
Test cookie return by dmaengine_submit() and return error if any.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform
Test cookie return by dmaengine_submit() and return error if any.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index
Uniformize "pixfmt" variables to "pix".
Change "current_fmt" & "dcmi_fmt" variables to variables
with "sd_" prefix to explicitly refer to subdev format.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/platfor
Uniformize "pixfmt" variables to "pix".
Change "current_fmt" & "dcmi_fmt" variables to variables
with "sd_" prefix to explicitly refer to subdev format.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c |
Fix missing mutex_destroy() when probe fails and
when driver is removed.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/i2c/ov9650.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
Fix missing mutex_destroy() when probe fails and
when driver is removed.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov9650.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index e8dea28..6ffb460 100644
Here is a bunch of small fixes found when upstreaming
the OV9655 sensor driver based on OV9650 driver:
- Fix coding style (checkpatch --strict)
- Fix missing mutex_destroy, see
http://www.mail-archive.com/linux-media@vger.kernel.org/msg115245.html
Hugues Fruchet (2):
[media] ov9650: fix coding
Here is a bunch of small fixes found when upstreaming
the OV9655 sensor driver based on OV9650 driver:
- Fix coding style (checkpatch --strict)
- Fix missing mutex_destroy, see
http://www.mail-archive.com/linux-media@vger.kernel.org/msg115245.html
Hugues Fruchet (2):
[media] ov9650: fix coding
Fix a bunch of coding style issues detected
by checkpatch --strict.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/i2c/ov9650.c | 59 ++
1 file changed, 33 insertions(+), 26 deletions(-)
diff --git a/drivers/media/i2c/ov
Fix a bunch of coding style issues detected
by checkpatch --strict.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov9650.c | 59 ++
1 file changed, 33 insertions(+), 26 deletions(-)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c
On 07/20/2017 10:37 AM, H. Nikolaus Schaller wrote:
> Hi,
>
>> Am 18.07.2017 um 21:52 schrieb Sakari Ailus <sakari.ai...@iki.fi>:
>>
>> On Tue, Jul 18, 2017 at 12:53:12PM +, Hugues FRUCHET wrote:
>>>
>>>
>>> On 07/18/2017 02:
On 07/20/2017 10:37 AM, H. Nikolaus Schaller wrote:
> Hi,
>
>> Am 18.07.2017 um 21:52 schrieb Sakari Ailus :
>>
>> On Tue, Jul 18, 2017 at 12:53:12PM +, Hugues FRUCHET wrote:
>>>
>>>
>>> On 07/18/2017 02:17 PM, H. Nikolaus Schaller wrote:
On 07/18/2017 02:17 PM, H. Nikolaus Schaller wrote:
> Hi,
>
>> Am 18.07.2017 um 13:59 schrieb Hans Verkuil <hverk...@xs4all.nl>:
>>
>> On 12/07/17 22:01, Sylwester Nawrocki wrote:
>>> Hi Hugues,
>>>
>>> On 07/03/2017 11:16 AM, Hugue
On 07/18/2017 02:17 PM, H. Nikolaus Schaller wrote:
> Hi,
>
>> Am 18.07.2017 um 13:59 schrieb Hans Verkuil :
>>
>> On 12/07/17 22:01, Sylwester Nawrocki wrote:
>>> Hi Hugues,
>>>
>>> On 07/03/2017 11:16 AM, Hugues Fruchet wrote:
>>>>
Hi Sakari, thks for review.
On 07/09/2017 01:06 AM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Mon, Jul 03, 2017 at 11:16:04AM +0200, Hugues Fruchet wrote:
>> Allows use of device tree configuration data.
>> If no device tree data is there, configuration is taken from platf
Hi Sakari, thks for review.
On 07/09/2017 01:06 AM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Mon, Jul 03, 2017 at 11:16:04AM +0200, Hugues Fruchet wrote:
>> Allows use of device tree configuration data.
>> If no device tree data is there, configuration is taken from platf
Acked-by: Hugues Fruchet <hugues.fruc...@st.com>
On 07/06/2017 10:05 PM, Gustavo A. R. Silva wrote:
> Check for vb2_ops structures that are only stored in the ops field of a
> vb2_queue structure. That field is declared const, so vb2_ops structures
> that have this property
Acked-by: Hugues Fruchet
On 07/06/2017 10:05 PM, Gustavo A. R. Silva wrote:
> Check for vb2_ops structures that are only stored in the ops field of a
> vb2_queue structure. That field is declared const, so vb2_ops structures
> that have this property can be declared as c
Acked-by: Hugues Fruchet <hugues.fruc...@st.com>
On 07/06/2017 10:14 PM, Gustavo A. R. Silva wrote:
> Check for vb2_ops structures that are only stored in the ops field of a
> vb2_queue structure. That field is declared const, so vb2_ops structures
> that have this property
Acked-by: Hugues Fruchet
On 07/06/2017 10:14 PM, Gustavo A. R. Silva wrote:
> Check for vb2_ops structures that are only stored in the ops field of a
> vb2_queue structure. That field is declared const, so vb2_ops structures
> that have this property can be declared as c
Hi Sylwester,
Do you have the possibility to check for non-regression of this patchset
on 9650/52 camera ?
Best regards,
Hugues.
On 07/03/2017 11:16 AM, Hugues Fruchet wrote:
> This patchset enables OV9655 camera support.
>
> OV9655 support has been tested using STM32F4DIS-CAM extens
Hi Sylwester,
Do you have the possibility to check for non-regression of this patchset
on 9650/52 camera ?
Best regards,
Hugues.
On 07/03/2017 11:16 AM, Hugues Fruchet wrote:
> This patchset enables OV9655 camera support.
>
> OV9655 support has been tested using STM32F4DIS-CAM extens
On 07/05/2017 04:03 PM, Rob Herring wrote:
> On Mon, Jul 03, 2017 at 11:16:02AM +0200, Hugues Fruchet wrote:
>> From: "H. Nikolaus Schaller" <h...@goldelico.com>
>>
>> This adds documentation of device tree bindings
>> for the OV965X family camera sens
On 07/05/2017 04:03 PM, Rob Herring wrote:
> On Mon, Jul 03, 2017 at 11:16:02AM +0200, Hugues Fruchet wrote:
>> From: "H. Nikolaus Schaller"
>>
>> This adds documentation of device tree bindings
>> for the OV965X family camera sensor module.
>>
>&g
of hsync.
Nevertheless seems OK if I check OMAP3 ISP register:
CCDC SYN_MODE=0x00071704
#define ISPCCDC_SYN_MODE_VDPOL (1 << 2)
#define ISPCCDC_SYN_MODE_HDPOL (1 << 3)
seems well that vertical is 1 and horizontal is 0.
BR,
Hugues.
On 07/03/2017 11:14 A
of hsync.
Nevertheless seems OK if I check OMAP3 ISP register:
CCDC SYN_MODE=0x00071704
#define ISPCCDC_SYN_MODE_VDPOL (1 << 2)
#define ISPCCDC_SYN_MODE_HDPOL (1 << 3)
seems well that vertical is 1 and horizontal is 0.
BR,
Hugues.
On 07/03/2017 11:14
Switch i2c device id to lower case as it is
done for other omnivision cameras.
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/i2c/ov9650.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov
Switch i2c device id to lower case as it is
done for other omnivision cameras.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov9650.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index 2de2fbb..1e4e99e
Add optional analog power supply and clock gating.
Signed-off-by: H. Nikolaus Schaller <h...@goldelico.com>
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
drivers/media/i2c/ov9650.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drive
Add optional analog power supply and clock gating.
Signed-off-by: H. Nikolaus Schaller
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov9650.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index
From: "H. Nikolaus Schaller" <h...@goldelico.com>
This adds documentation of device tree bindings
for the OV965X family camera sensor module.
Signed-off-by: H. Nikolaus Schaller <h...@goldelico.com>
Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com>
---
.../d
From: "H. Nikolaus Schaller"
This adds documentation of device tree bindings
for the OV965X family camera sensor module.
Signed-off-by: H. Nikolaus Schaller
Signed-off-by: Hugues Fruchet
---
.../devicetree/bindings/media/i2c/ov965x.txt | 45 ++
1 file c
101 - 200 of 376 matches
Mail list logo
