Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Ian Campbell
On Tue, 2014-02-11 at 13:53 -0800, Luis R. Rodriguez wrote: > Cc'ing kvm folks as they may have a shared interest on the shared > physical case with the bridge (non NAT). > > On Tue, Feb 11, 2014 at 12:43 AM, Ian Campbell > wrote: > > On Mon, 2014-02-10 at 14:29 -0800, Lu

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Ian Campbell
On Tue, 2014-02-11 at 13:53 -0800, Luis R. Rodriguez wrote: Cc'ing kvm folks as they may have a shared interest on the shared physical case with the bridge (non NAT). On Tue, Feb 11, 2014 at 12:43 AM, Ian Campbell ian.campb...@citrix.com wrote: On Mon, 2014-02-10 at 14:29 -0800, Luis R

Re: [PATCH] arm: document "mach-virt" platform.

2014-02-03 Thread Ian Campbell
On Sun, 2014-02-02 at 20:56 -0800, Christoffer Dall wrote: > On Thu, Jan 30, 2014 at 11:54:46AM -0500, Christopher Covington wrote: > > Hi Ian, > > > > On 01/30/2014 11:11 AM, Ian Campbell wrote: > > > mach-virt has existed for a while but it is not writte

Re: [PATCH] arm: document mach-virt platform.

2014-02-03 Thread Ian Campbell
On Sun, 2014-02-02 at 20:56 -0800, Christoffer Dall wrote: On Thu, Jan 30, 2014 at 11:54:46AM -0500, Christopher Covington wrote: Hi Ian, On 01/30/2014 11:11 AM, Ian Campbell wrote: mach-virt has existed for a while but it is not written down what it actually consists

Re: [PATCH] arm: document "mach-virt" platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 18:28 +0100, Arnd Bergmann wrote: > On Thursday 30 January 2014, Ian Campbell wrote: > > mach-virt has existed for a while but it is not written down what it > > actually > > consists of. Although it seems a bit unusual to document a binding for an >

Re: [PATCH] arm: document "mach-virt" platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 17:24 +, Marc Zyngier wrote: > >> I'm afraid I disagree with most of the above. The whole point of > >> mach-virt is to provide a shell for DT platforms. None of this hardware > >> is mandated. Instead, all the necessary information should be described > >> in DT. > > >

Re: [PATCH] arm: document "mach-virt" platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 17:13 +, Marc Zyngier wrote: > Hi Ian, > > On 30/01/14 16:11, Ian Campbell wrote: > > mach-virt has existed for a while but it is not written down what it > > actually > > consists of. Although it seems a bit unusual to document a binding

Re: [PATCH] arm: document "mach-virt" platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 11:54 -0500, Christopher Covington wrote: > > +++ b/Documentation/devicetree/bindings/arm/mach-virt.txt > > @@ -0,0 +1,32 @@ > > +* Mach-virt "Dummy Virtual Machine" platform > > + > > +"mach-virt" is the smallest, dumbest platform possible, to be used as > > +a guest for

[PATCH] arm: document "mach-virt" platform.

2014-01-30 Thread Ian Campbell
. I've done my best to capture the requirements based on the git log and my memory/understanding. While here remove the xenvm dts example, the Xen tools will now build a suitable mach-virt compatible dts when launching the guest. Signed-off-by: Ian Campbell Cc: Rob Herring Cc: Pawel Moll Cc

[PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
. I've done my best to capture the requirements based on the git log and my memory/understanding. While here remove the xenvm dts example, the Xen tools will now build a suitable mach-virt compatible dts when launching the guest. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 11:54 -0500, Christopher Covington wrote: +++ b/Documentation/devicetree/bindings/arm/mach-virt.txt @@ -0,0 +1,32 @@ +* Mach-virt Dummy Virtual Machine platform + +mach-virt is the smallest, dumbest platform possible, to be used as +a guest for Xen, KVM and other

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 17:13 +, Marc Zyngier wrote: Hi Ian, On 30/01/14 16:11, Ian Campbell wrote: mach-virt has existed for a while but it is not written down what it actually consists of. Although it seems a bit unusual to document a binding for an entire platform since mach-virt

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 17:24 +, Marc Zyngier wrote: I'm afraid I disagree with most of the above. The whole point of mach-virt is to provide a shell for DT platforms. None of this hardware is mandated. Instead, all the necessary information should be described in DT. Add support

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 18:28 +0100, Arnd Bergmann wrote: On Thursday 30 January 2014, Ian Campbell wrote: mach-virt has existed for a while but it is not written down what it actually consists of. Although it seems a bit unusual to document a binding for an entire platform since mach-virt

[PATCH REPOST] of: Add vendor prefix for Xen hypervisor

2014-01-29 Thread Ian Campbell
I suppose vendors of virtual hardware ought to be listed here as well. Signed-off-by: Ian Campbell Acked-by: Stefano Stabellini Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Kumar Gala Cc: Stephen Warren Acked-by: Stephen Warren Cc: devicet...@vger.kernel.org --- v2: rebased

[PATCH REPOST] of: Add vendor prefix for Xen hypervisor

2014-01-29 Thread Ian Campbell
I suppose vendors of virtual hardware ought to be listed here as well. Signed-off-by: Ian Campbell ian.campb...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc

Re: [PATCH] xen/gnttab: Use phys_addr_t to describe the grant frame base address

2014-01-28 Thread Ian Campbell
ugh. > Signed-off-by: Julien Grall Acked-by: Ian Campbell -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] xen/gnttab: Use phys_addr_t to describe the grant frame base address

2014-01-28 Thread Ian Campbell
julien.gr...@linaro.org Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-27 Thread Ian Campbell
On Sat, 2014-01-25 at 13:07 -0800, Matt Wilson wrote: > On Fri, Jan 24, 2014 at 03:36:22PM +0000, Ian Campbell wrote: > > On Fri, 2014-01-24 at 09:21 +0000, Ian Campbell wrote: > > > On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: > > > > From: Matt Rusht

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-27 Thread Ian Campbell
On Sat, 2014-01-25 at 13:07 -0800, Matt Wilson wrote: On Fri, Jan 24, 2014 at 03:36:22PM +, Ian Campbell wrote: On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote: On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: From: Matt Rushton mrush...@amazon.com Currently

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Ian Campbell
On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote: > On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: > > From: Matt Rushton > > > > Currently shrink_free_pagepool() is called before the pages used for > > persistent grants are released via free_persiste

Re: [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Ian Campbell
is > torn down. This may well be the explanation for the memory leak I was observing on ARM last night. I'll give it a go and let you know. > Cc: Konrad Rzeszutek Wilk > Cc: "Roger Pau Monné" > Cc: Ian Campbell > Cc: David Vrabel > Cc: linux-kernel@vger.kernel.org

Re: [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Ian Campbell
is torn down. This may well be the explanation for the memory leak I was observing on ARM last night. I'll give it a go and let you know. Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Roger Pau Monné roger@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: David Vrabel david.vra

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Ian Campbell
On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote: On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: From: Matt Rushton mrush...@amazon.com Currently shrink_free_pagepool() is called before the pages used for persistent grants are released via free_persistent_gnts

Re: [Xen-devel] [PATCH v4] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-22 Thread Ian Campbell
> CONFIG_CPU_V6 > - implement sync_cmpxchg using __cmpxchg8 and __cmpxchg16 > > Signed-off-by: Stefano Stabellini Acked-by: Ian Campbell -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [Xen-devel] [PATCH v4] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-22 Thread Ian Campbell
- implement sync_cmpxchg using __cmpxchg8 and __cmpxchg16 Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] ARM: orion: provide C-style interrupt handler for MULTI_IRQ_HANDLER

2014-01-20 Thread Ian Campbell
On Thu, 2014-01-16 at 13:49 -0500, Jason Cooper wrote: > > @Ian: Thanks for hunting this down, please keep bothering us with > > bug reports :) > > Yes, please! No worries there -- it seem Debian has quite a few people who use kirkwood based systems and will report bugs when they find them...

Re: [PATCH] ARM: orion: provide C-style interrupt handler for MULTI_IRQ_HANDLER

2014-01-20 Thread Ian Campbell
On Thu, 2014-01-16 at 13:49 -0500, Jason Cooper wrote: @Ian: Thanks for hunting this down, please keep bothering us with bug reports :) Yes, please! No worries there -- it seem Debian has quite a few people who use kirkwood based systems and will report bugs when they find them... Thanks

Re: [PATCH] ARM: orion: provide C-style interrupt handler for MULTI_IRQ_HANDLER

2014-01-16 Thread Ian Campbell
ll Dove non-DT boards are affected and fixed by this patch. > > > > Signed-off-by: Sebastian Hesselbarth > > Tested-by: Ian Campbell > > Reported-by: Ian Campbell > > Fixes: 2326f04321a9 ("ARM: kirkwood: convert to DT irqchip and clocksource") > > Fixe

Re: [PATCH] ARM: orion: provide C-style interrupt handler for MULTI_IRQ_HANDLER

2014-01-16 Thread Ian Campbell
...@gmail.com Tested-by: Ian Campbell i...@hellion.org.uk Reported-by: Ian Campbell i...@hellion.org.uk Fixes: 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) Fixes: f07d73e33d0e (ARM: dove: convert to DT irqchip and clocksource) --- Compared to the two patch version sent

Re: [Xen-devel] [PATCH v2] xen-blkfront: remove type check from blkfront_setup_discard

2014-01-13 Thread Ian Campbell
On Mon, 2014-01-13 at 13:16 +, Jan Beulich wrote: > >>> On 13.01.14 at 14:00, Ian Campbell wrote: > > On Mon, 2014-01-13 at 12:34 +, Jan Beulich wrote: > >> >>> On 13.01.14 at 13:01, Olaf Hering wrote: > >> > On Mon, Jan 13, Jan Beulich wr

Re: [Xen-devel] [PATCH v2] xen-blkfront: remove type check from blkfront_setup_discard

2014-01-13 Thread Ian Campbell
On Mon, 2014-01-13 at 12:34 +, Jan Beulich wrote: > >>> On 13.01.14 at 13:01, Olaf Hering wrote: > > On Mon, Jan 13, Jan Beulich wrote: > > > >> You can't do this in one go - the first two and the last one may be > >> set independently (and are independent in their meaning), and > >> hence

Re: [Xen-devel] [PATCH v2] xen-blkfront: remove type check from blkfront_setup_discard

2014-01-13 Thread Ian Campbell
On Mon, 2014-01-13 at 12:34 +, Jan Beulich wrote: On 13.01.14 at 13:01, Olaf Hering o...@aepfle.de wrote: On Mon, Jan 13, Jan Beulich wrote: You can't do this in one go - the first two and the last one may be set independently (and are independent in their meaning), and hence need

Re: [Xen-devel] [PATCH v2] xen-blkfront: remove type check from blkfront_setup_discard

2014-01-13 Thread Ian Campbell
On Mon, 2014-01-13 at 13:16 +, Jan Beulich wrote: On 13.01.14 at 14:00, Ian Campbell ian.campb...@citrix.com wrote: On Mon, 2014-01-13 at 12:34 +, Jan Beulich wrote: On 13.01.14 at 13:01, Olaf Hering o...@aepfle.de wrote: On Mon, Jan 13, Jan Beulich wrote: You can't do

Re: [PATCH v8 4/6] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2014-01-09 Thread Ian Campbell
On Thu, 2014-01-09 at 12:13 +, Catalin Marinas wrote: > On Wed, Jan 08, 2014 at 06:49:56PM +, Stefano Stabellini wrote: > > arch/arm64/Kconfig | 20 > > arch/arm64/kernel/Makefile |1 + > > 2 files changed, 21 insertions(+) > [...] > > diff --git

Re: [PATCH v8 3/6] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2014-01-09 Thread Ian Campbell
count_process_tick for stolen > ticks accounting. > > Signed-off-by: Stefano Stabellini > Acked-by: Christopher Covington Acked-by: Ian Campbell > CC: li...@arm.linux.org.uk > CC: will.dea...@arm.com > CC: n...@linaro.org > CC: marc.zyng...@arm.com > CC: c.

Re: [PATCH v8 3/6] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2014-01-09 Thread Ian Campbell
for stolen ticks accounting. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Christopher Covington c...@codeaurora.org Acked-by: Ian Campbell ian.campb...@citrix.com CC: li...@arm.linux.org.uk CC: will.dea...@arm.com CC: n...@linaro.org CC: marc.zyng...@arm.com CC

Re: [PATCH v8 4/6] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2014-01-09 Thread Ian Campbell
On Thu, 2014-01-09 at 12:13 +, Catalin Marinas wrote: On Wed, Jan 08, 2014 at 06:49:56PM +, Stefano Stabellini wrote: arch/arm64/Kconfig | 20 arch/arm64/kernel/Makefile |1 + 2 files changed, 21 insertions(+) [...] diff --git

Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call

2014-01-06 Thread Ian Campbell
On Mon, 2014-01-06 at 11:00 +, David Vrabel wrote: > On 06/01/14 10:00, Ian Campbell wrote: > > On Thu, 2014-01-02 at 13:53 +, David Vrabel wrote: > >> On 19/12/13 15:03, Levente Kurusa wrote: > >>> This is required so that we give up the last reference to

Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call

2014-01-06 Thread Ian Campbell
On Thu, 2014-01-02 at 13:53 +, David Vrabel wrote: > On 19/12/13 15:03, Levente Kurusa wrote: > > This is required so that we give up the last reference to the device. > > > > Signed-off-by: Levente Kurusa > > --- > > drivers/xen/xenbus/xenbus_probe.c | 4 +++- > > 1 file changed, 3

Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call

2014-01-06 Thread Ian Campbell
On Thu, 2014-01-02 at 13:53 +, David Vrabel wrote: On 19/12/13 15:03, Levente Kurusa wrote: This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa le...@linux.com --- drivers/xen/xenbus/xenbus_probe.c | 4 +++- 1 file changed, 3

Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call

2014-01-06 Thread Ian Campbell
On Mon, 2014-01-06 at 11:00 +, David Vrabel wrote: On 06/01/14 10:00, Ian Campbell wrote: On Thu, 2014-01-02 at 13:53 +, David Vrabel wrote: On 19/12/13 15:03, Levente Kurusa wrote: This is required so that we give up the last reference to the device. Signed-off-by: Levente

Re: [Xen-devel] [PATCH v11 02/12] xen/pvh: Define what an PVH guest is.

2013-12-18 Thread Ian Campbell
On Wed, 2013-12-18 at 11:58 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 18, 2013 at 04:01:03PM +0000, Ian Campbell wrote: > > On Wed, 2013-12-18 at 14:55 +, Stefano Stabellini wrote: > > > On Wed, 18 Dec 2013, Stefano Stabellini wrote: > > > > On Tue, 17 D

Re: [Xen-devel] [PATCH v11 02/12] xen/pvh: Define what an PVH guest is.

2013-12-18 Thread Ian Campbell
On Wed, 2013-12-18 at 14:55 +, Stefano Stabellini wrote: > On Wed, 18 Dec 2013, Stefano Stabellini wrote: > > On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: > > > From: Mukesh Rathor > > > > > > Which is a PV guest with auto page translation enabled > > > and with vector callback. It is a

Re: [Xen-devel] [PATCH] allow xenfb initialization for hvm guests

2013-12-18 Thread Ian Campbell
> guests, they are not affected. and if a toolstack did I think it would be reasonable to expect the kernel to at least try and drive it! > Signed-off-by: Stefano Stabellini Acked-by: Ian Campbell -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [Xen-devel] [PATCH] allow xenfb initialization for hvm guests

2013-12-18 Thread Ian Campbell
, they are not affected. and if a toolstack did I think it would be reasonable to expect the kernel to at least try and drive it! Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux

Re: [Xen-devel] [PATCH v11 02/12] xen/pvh: Define what an PVH guest is.

2013-12-18 Thread Ian Campbell
On Wed, 2013-12-18 at 14:55 +, Stefano Stabellini wrote: On Wed, 18 Dec 2013, Stefano Stabellini wrote: On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: From: Mukesh Rathor mukesh.rat...@oracle.com Which is a PV guest with auto page translation enabled and with vector

Re: [Xen-devel] [PATCH v11 02/12] xen/pvh: Define what an PVH guest is.

2013-12-18 Thread Ian Campbell
On Wed, 2013-12-18 at 11:58 -0500, Konrad Rzeszutek Wilk wrote: On Wed, Dec 18, 2013 at 04:01:03PM +, Ian Campbell wrote: On Wed, 2013-12-18 at 14:55 +, Stefano Stabellini wrote: On Wed, 18 Dec 2013, Stefano Stabellini wrote: On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote

Re: [PATCH v2 9/9] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c

2013-12-16 Thread Ian Campbell
tback/netback.c:218:14: warning: no previous prototype for > ‘xenvif_count_frag_slots’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett Acked-by: Ian Campbell > --- > > This revision fixes the following issues of the previous revis

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-12-16 Thread Ian Campbell
On Thu, 2013-12-12 at 22:08 +, Zoltan Kiss wrote: > On 28/11/13 17:43, Ian Campbell wrote: > > On Thu, 2013-11-28 at 17:37 +, Zoltan Kiss wrote: > > Routing/firewalling domUs is as valid as bridging. There is nothing in > > the slightest bit suboptimal about it. >

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-12-16 Thread Ian Campbell
On Thu, 2013-12-12 at 22:08 +, Zoltan Kiss wrote: On 28/11/13 17:43, Ian Campbell wrote: On Thu, 2013-11-28 at 17:37 +, Zoltan Kiss wrote: Routing/firewalling domUs is as valid as bridging. There is nothing in the slightest bit suboptimal about it. If this use case regresses

Re: [PATCH v2 9/9] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c

2013-12-16 Thread Ian Campbell
: warning: no previous prototype for ‘xenvif_count_frag_slots’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org Acked-by: Ian Campbell ian.campb...@citrix.com --- This revision fixes the following issues

Re: [Xen-devel] [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-12 Thread Ian Campbell
On Tue, 2013-12-03 at 15:40 +, Julien Grall wrote: > On ARM (32 bits and 64 bits), the double-word is 8-bytes aligned. This will > result on different structure from Xen and Linux repositories. > > As Linux is using __packed__ attribute, it must have a 4-bytes padding before > each "id"

Re: [Xen-devel] [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-12 Thread Ian Campbell
On Tue, 2013-12-03 at 15:40 +, Julien Grall wrote: On ARM (32 bits and 64 bits), the double-word is 8-bytes aligned. This will result on different structure from Xen and Linux repositories. As Linux is using __packed__ attribute, it must have a 4-bytes padding before each id field.

Re: [PATCH] xen/arm64: do not call the swiotlb functions twice

2013-12-09 Thread Ian Campbell
page-coherent.h. > > Signed-off-by: Stefano Stabellini > CC: catalin.mari...@arm.com > CC: will.dea...@arm.com Tested-by: Ian Campbell Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH] xen/arm64: do not call the swiotlb functions twice

2013-12-09 Thread Ian Campbell
Stabellini stefano.stabell...@eu.citrix.com CC: catalin.mari...@arm.com CC: will.dea...@arm.com Tested-by: Ian Campbell ian.campb...@citrix.com Ian. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 13:00 +, David Vrabel wrote: > On 03/12/13 21:14, Konrad Rzeszutek Wilk wrote: > > > > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' > > but unfortunatly the xen-blkfront driver is using it, so we > > cannot do it. > &

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 09:28 +, Ian Campbell wrote: > This could probably even be semi automated by producing a script to feed > to gdb which run through all of the options and diffing the result. > > If I could have the moon on a stick I would have a tool such as this >

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:18 +, Stefano Stabellini wrote: > On Wed, 4 Dec 2013, Ian Campbell wrote: > > On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: > > > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > > On Wed, 2013-12-04 at 10:51 +

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: > On Wed, 4 Dec 2013, Ian Campbell wrote: > > On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: > > > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > > &

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > +bool xen_has_pv_devices(void) > > > +{ > > > + if (!xen_domain()) > > > + return false; > > > + > > > + if (xen_hvm_do

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
ul_unplug=never', >in which case bail out and don't load PV drivers. > - if running in HVM, and if PCI device 5853:0001 (xen_platform_pci) >does not exist, then bail out and not load PV drivers. > > P.S. > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug'

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-04 Thread Ian Campbell
On Tue, 2013-12-03 at 15:11 -0500, Konrad Rzeszutek Wilk wrote: > > > If Konrad and Boris agree that breaking the kernel's ABI in this way is > > > acceptable in this specific case, I'll defer to them. > > > > My opinion as Xen on ARM hypervisor maintainer is that this is the right > > thing to

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-04 Thread Ian Campbell
On Tue, 2013-12-03 at 15:11 -0500, Konrad Rzeszutek Wilk wrote: If Konrad and Boris agree that breaking the kernel's ABI in this way is acceptable in this specific case, I'll defer to them. My opinion as Xen on ARM hypervisor maintainer is that this is the right thing to do in this

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
drivers. P.S. Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' but unfortunatly the xen-blkfront driver is using it, so we cannot do it. It might still be nice to expose a suitable semantic interface (i.e. some relevant predicate) rather than the raw value for blkfront to use

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: +bool xen_has_pv_devices(void) +{ + if (!xen_domain()) + return false; + + if (xen_hvm_domain()) { + /* User requested no unplug, so no PV drivers

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: +bool xen_has_pv_devices(void) +{ + if (!xen_domain

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:18 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 09:28 +, Ian Campbell wrote: This could probably even be semi automated by producing a script to feed to gdb which run through all of the options and diffing the result. If I could have the moon on a stick I would have a tool such as this running against

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 13:00 +, David Vrabel wrote: On 03/12/13 21:14, Konrad Rzeszutek Wilk wrote: Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' but unfortunatly the xen-blkfront driver is using it, so we cannot do it. I had a look at what blkfront was using

Re: [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 16:32 +, One Thousand Gnomes wrote: > > > How does the patch ensure new kernels on existing hypervisor versions > > > don't break ? > > > > As Ian said on the thread "xen-block: correctly define structures in > > public headers" (see thread

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:51 +, One Thousand Gnomes wrote: > > > If Konrad and Boris agree that breaking the kernel's ABI in this way is > > > acceptable in this specific case, I'll defer to them. > > > > My opinion as Xen on ARM hypervisor maintainer is that this is the right > > thing to do

Re: [Xen-devel] [PATCH] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:28 +, Julien Grall wrote: > On 12/03/2013 03:15 PM, Jan Beulich wrote: > On 03.12.13 at 16:09, Julien Grall wrote: > >> --- a/include/xen/interface/io/blkif.h > >> +++ b/include/xen/interface/io/blkif.h > >> @@ -146,7 +146,7 @@ struct

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:11 +, David Vrabel wrote: > On 03/12/13 13:41, Ian Campbell wrote: > > On Tue, 2013-12-03 at 11:59 +, David Vrabel wrote: > >> On 03/12/13 11:08, Ian Campbell wrote: > >>> On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: >

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:59 +, David Vrabel wrote: > On 03/12/13 11:08, Ian Campbell wrote: > > On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: > >> On 03/12/13 10:57, Roger Pau Monne wrote: > >>> Using __packed__ on the public interface is not correct

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:11 +, Jan Beulich wrote: > >>> On 03.12.13 at 12:05, Ian Campbell wrote: > > On Tue, 2013-12-03 at 11:57 +0100, Roger Pau Monne wrote: > >> Using __packed__ on the public interface is not correct, this > >> structures sho

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: > On 03/12/13 10:57, Roger Pau Monne wrote: > > Using __packed__ on the public interface is not correct, this > > structures should be compiled using the native ABI, and __packed__ > > should only be used in the backend counterpart of those

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:57 +0100, Roger Pau Monne wrote: > Using __packed__ on the public interface is not correct, this > structures should be compiled using the native ABI, and __packed__ > should only be used in the backend counterpart of those structures > (which needs to handle different

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:57 +0100, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using the native ABI, and __packed__ should only be used in the backend counterpart of those structures (which needs to handle different ABIs).

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: On 03/12/13 10:57, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using the native ABI, and __packed__ should only be used in the backend counterpart of those

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:11 +, Jan Beulich wrote: On 03.12.13 at 12:05, Ian Campbell ian.campb...@citrix.com wrote: On Tue, 2013-12-03 at 11:57 +0100, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using the native ABI

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:59 +, David Vrabel wrote: On 03/12/13 11:08, Ian Campbell wrote: On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: On 03/12/13 10:57, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:11 +, David Vrabel wrote: On 03/12/13 13:41, Ian Campbell wrote: On Tue, 2013-12-03 at 11:59 +, David Vrabel wrote: On 03/12/13 11:08, Ian Campbell wrote: On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: On 03/12/13 10:57, Roger Pau Monne wrote

Re: [Xen-devel] [PATCH] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:28 +, Julien Grall wrote: On 12/03/2013 03:15 PM, Jan Beulich wrote: On 03.12.13 at 16:09, Julien Grall julien.gr...@linaro.org wrote: --- a/include/xen/interface/io/blkif.h +++ b/include/xen/interface/io/blkif.h @@ -146,7 +146,7 @@ struct

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:51 +, One Thousand Gnomes wrote: If Konrad and Boris agree that breaking the kernel's ABI in this way is acceptable in this specific case, I'll defer to them. My opinion as Xen on ARM hypervisor maintainer is that this is the right thing to do in this

Re: [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 16:32 +, One Thousand Gnomes wrote: How does the patch ensure new kernels on existing hypervisor versions don't break ? As Ian said on the thread xen-block: correctly define structures in public headers (see thread https://lkml.org/lkml/2013/12/3/155), the

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-11-28 Thread Ian Campbell
On Thu, 2013-11-28 at 17:37 +, Zoltan Kiss wrote: > On 07/11/13 10:52, Ian Campbell wrote: > > On Fri, 2013-11-01 at 19:00 +, Zoltan Kiss wrote: > >> On 01/11/13 10:50, Ian Campbell wrote: > >>> Does this always avoid copying when bridging/openvswitching/forwa

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-11-28 Thread Ian Campbell
On Thu, 2013-11-28 at 17:37 +, Zoltan Kiss wrote: On 07/11/13 10:52, Ian Campbell wrote: On Fri, 2013-11-01 at 19:00 +, Zoltan Kiss wrote: On 01/11/13 10:50, Ian Campbell wrote: Does this always avoid copying when bridging/openvswitching/forwarding (e.g. masquerading etc

Re: [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic

2013-11-25 Thread Ian Campbell
plicit-function-declaration] > tcph->check = ~csum_ipv6_magic(>saddr, > > Signed-off-by: Andy Whitcroft Acked-by: Ian Campbell Thanks! > --- > drivers/net/xen-netback/netback.c | 1 + > 1 file changed, 1 insertion(+) > > Found while trying to couple la

Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq

2013-11-25 Thread Ian Campbell
On Wed, 2013-11-20 at 15:24 +0530, Laxman Dewangan wrote: > On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote: > > Hi, > > > > Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs > > earlier) split the suspend/resume of the irqs into two parts. > > > > The early-irqs

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-11-25 Thread Ian Campbell
t #address-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Gernot V

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-11-25 Thread Ian Campbell
Adding PCIe MSI support" this platform does not use address-cells=2. Signed-off-by: Ian Campbell Acked-by: Josh Boyer Cc: Rupjyoti Sarmah Cc: Tirumala R Marri Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: devicet...@vger.kernel.org (open list:OPEN FIRMWARE AND...) Cc: linuxppc-...@lists.

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-11-25 Thread Ian Campbell
this platform does not use address-cells=2. Signed-off-by: Ian Campbell ian.campb...@citrix.com Acked-by: Josh Boyer jwbo...@gmail.com Cc: Rupjyoti Sarmah rsar...@apm.com Cc: Tirumala R Marri tma...@apm.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-11-25 Thread Ian Campbell
-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Benjamin Herrenschmidt b

Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq

2013-11-25 Thread Ian Campbell
On Wed, 2013-11-20 at 15:24 +0530, Laxman Dewangan wrote: On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote: Hi, Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs earlier) split the suspend/resume of the irqs into two parts. The early-irqs get resumed

Re: [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic

2013-11-25 Thread Ian Campbell
-declaration] tcph-check = ~csum_ipv6_magic(ipv6h-saddr, Signed-off-by: Andy Whitcroft a...@canonical.com Acked-by: Ian Campbell ian.campb...@citrix.com Thanks! --- drivers/net/xen-netback/netback.c | 1 + 1 file changed, 1 insertion(+) Found while trying to couple latest kernels

Re: [Xen-devel] [PATCH 4/4] xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart.

2013-11-22 Thread Ian Campbell
graft 8 <20130528152156.gb3...@phenom.dumpdata.com> prune 8 <20130528181149.ga27...@phenom.dumpdata.com> thanks On Thu, 2013-11-21 at 17:52 +, David Vrabel wrote: > > Fixes-Bug: http://bugs.xenproject.org/xen/bug/8 > > This bug link has no useful information in it. Looks like the intention

Re: [Xen-devel] [PATCH 4/4] xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart.

2013-11-22 Thread Ian Campbell
graft 8 20130528152156.gb3...@phenom.dumpdata.com prune 8 20130528181149.ga27...@phenom.dumpdata.com thanks On Thu, 2013-11-21 at 17:52 +, David Vrabel wrote: Fixes-Bug: http://bugs.xenproject.org/xen/bug/8 This bug link has no useful information in it. Looks like the intention was for

Re: [Xen-devel] [PATCH] xen-gnttab: do not add m2p override entries for blkback mappings

2013-11-13 Thread Ian Campbell
On Tue, 2013-11-12 at 17:48 -0800, Anthony Liguori wrote: > See http://article.gmane.org/gmane.linux.kernel/1590932 for a full > analysis of current users. Silly nit: Please can you include the message ID in case this goes away, or use a URL which includes the ID already so it can be translated

Re: [Xen-devel] [PATCH] xen-gnttab: do not add m2p override entries for blkback mappings

2013-11-13 Thread Ian Campbell
On Tue, 2013-11-12 at 17:48 -0800, Anthony Liguori wrote: See http://article.gmane.org/gmane.linux.kernel/1590932 for a full analysis of current users. Silly nit: Please can you include the message ID in case this goes away, or use a URL which includes the ID already so it can be translated if

<    1   2   3   4   5   6   7   8   9   10   >