Re: [PATCH v3 1/2] xen/balloon: set a mapping for ballooned out pages

2013-07-24 Thread Ian Campbell
On Wed, 2013-07-24 at 10:58 -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jul 24, 2013 at 12:05:05PM +0100, Stefano Stabellini wrote: > > On Tue, 23 Jul 2013, Konrad Rzeszutek Wilk wrote: > > > On Tue, Jul 23, 2013 at 07:00:09PM +0100, Ian Campbell wrote: > > > > On

Re: [PATCH v3 1/2] xen/balloon: set a mapping for ballooned out pages

2013-07-24 Thread Ian Campbell
On Wed, 2013-07-24 at 10:58 -0400, Konrad Rzeszutek Wilk wrote: On Wed, Jul 24, 2013 at 12:05:05PM +0100, Stefano Stabellini wrote: On Tue, 23 Jul 2013, Konrad Rzeszutek Wilk wrote: On Tue, Jul 23, 2013 at 07:00:09PM +0100, Ian Campbell wrote: On Tue, 2013-07-23 at 18:27 +0100, Stefano

Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 13:44 -0500, Rob Herring wrote: > On 07/23/2013 01:09 PM, Ian Campbell wrote: > > On Tue, 2013-07-23 at 10:59 -0700, Stephen Warren wrote: > > > >> I think the solution is to introduce some new shared/common location for > >> shared/common *

Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 10:59 -0700, Stephen Warren wrote: > I think the solution is to introduce some new shared/common location for > shared/common *.dtsi files, into the kernel tree, in the interim. > > When *.dts move out of the kernel, this common location can simply be > consumed as part of

Re: [PATCH v3 1/2] xen/balloon: set a mapping for ballooned out pages

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 18:27 +0100, Stefano Stabellini wrote: > +static int __cpuinit balloon_cpu_notify(struct notifier_block *self, > + unsigned long action, void *hcpu) > +{ > + int cpu = (long)hcpu; > + switch (action) { > + case CPU_UP_PREPARE: > +

Re: [PATCH v3 1/2] xen/balloon: set a mapping for ballooned out pages

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 18:27 +0100, Stefano Stabellini wrote: +static int __cpuinit balloon_cpu_notify(struct notifier_block *self, + unsigned long action, void *hcpu) +{ + int cpu = (long)hcpu; + switch (action) { + case CPU_UP_PREPARE: +

Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 10:59 -0700, Stephen Warren wrote: I think the solution is to introduce some new shared/common location for shared/common *.dtsi files, into the kernel tree, in the interim. When *.dts move out of the kernel, this common location can simply be consumed as part of the

Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 13:44 -0500, Rob Herring wrote: On 07/23/2013 01:09 PM, Ian Campbell wrote: On Tue, 2013-07-23 at 10:59 -0700, Stephen Warren wrote: I think the solution is to introduce some new shared/common location for shared/common *.dtsi files, into the kernel tree

Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled

2013-07-19 Thread Ian Campbell
On Fri, 2013-07-19 at 11:06 +0100, Stefano Stabellini wrote: > On Fri, 19 Jul 2013, Ian Campbell wrote: > > On Fri, 2013-07-19 at 10:52 +0100, Stefano Stabellini wrote: > > > On Fri, 19 Jul 2013, Ian Campbell wrote: > > > > On Thu, 2013-07-18 at 17:15 +0100, Julie

Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled

2013-07-19 Thread Ian Campbell
On Fri, 2013-07-19 at 10:52 +0100, Stefano Stabellini wrote: > On Fri, 19 Jul 2013, Ian Campbell wrote: > > On Thu, 2013-07-18 at 17:15 +0100, Julien Grall wrote: > > > On 17 July 2013 14:25, Stefano Stabellini > > > wrote: > > > > On Mon, 15 Jul

Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled

2013-07-19 Thread Ian Campbell
On Thu, 2013-07-18 at 17:15 +0100, Julien Grall wrote: > On 17 July 2013 14:25, Stefano Stabellini > wrote: > > On Mon, 15 Jul 2013, Julien Grall wrote: > >> Even if uncompress debug is disabled, some board will continue to print > >> information during uncompress step. > > > > Are you talking

Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled

2013-07-19 Thread Ian Campbell
On Thu, 2013-07-18 at 17:15 +0100, Julien Grall wrote: On 17 July 2013 14:25, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Mon, 15 Jul 2013, Julien Grall wrote: Even if uncompress debug is disabled, some board will continue to print information during uncompress step.

Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled

2013-07-19 Thread Ian Campbell
On Fri, 2013-07-19 at 10:52 +0100, Stefano Stabellini wrote: On Fri, 19 Jul 2013, Ian Campbell wrote: On Thu, 2013-07-18 at 17:15 +0100, Julien Grall wrote: On 17 July 2013 14:25, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Mon, 15 Jul 2013, Julien Grall wrote

Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled

2013-07-19 Thread Ian Campbell
On Fri, 2013-07-19 at 11:06 +0100, Stefano Stabellini wrote: On Fri, 19 Jul 2013, Ian Campbell wrote: On Fri, 2013-07-19 at 10:52 +0100, Stefano Stabellini wrote: On Fri, 19 Jul 2013, Ian Campbell wrote: On Thu, 2013-07-18 at 17:15 +0100, Julien Grall wrote: On 17 July 2013 14:25

Re: kernel panic in skb_copy_bits

2013-07-04 Thread Ian Campbell
On Thu, 2013-07-04 at 02:34 -0700, Eric Dumazet wrote: > On Thu, 2013-07-04 at 09:59 +0100, Ian Campbell wrote: > > On Thu, 2013-07-04 at 16:55 +0800, Joe Jin wrote: > > > > > > Another way is add new page flag like PG_send, when sendpage() be called, > > >

Re: kernel panic in skb_copy_bits

2013-07-04 Thread Ian Campbell
On Thu, 2013-07-04 at 16:55 +0800, Joe Jin wrote: > On 07/01/13 16:11, Ian Campbell wrote: > > On Mon, 2013-07-01 at 11:18 +0800, Joe Jin wrote: > >>> A workaround is to turn off O_DIRECT use by Xen as that ensures > >>> the pages are copied. Xen 4.3 does this

Re: kernel panic in skb_copy_bits

2013-07-04 Thread Ian Campbell
On Thu, 2013-07-04 at 16:55 +0800, Joe Jin wrote: On 07/01/13 16:11, Ian Campbell wrote: On Mon, 2013-07-01 at 11:18 +0800, Joe Jin wrote: A workaround is to turn off O_DIRECT use by Xen as that ensures the pages are copied. Xen 4.3 does this by default. I believe fixes

Re: kernel panic in skb_copy_bits

2013-07-04 Thread Ian Campbell
On Thu, 2013-07-04 at 02:34 -0700, Eric Dumazet wrote: On Thu, 2013-07-04 at 09:59 +0100, Ian Campbell wrote: On Thu, 2013-07-04 at 16:55 +0800, Joe Jin wrote: Another way is add new page flag like PG_send, when sendpage() be called, set the bit, when page be put, clear the bit

Re: [Xen-devel] [PATCH RFC] xen/arm: domain kernel: Small fixes for making suspendable for arm

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 16:59 +0100, Stefano Stabellini wrote: > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 2c3bdce..77309f7 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -1469,6 +1469,9 @@ config ARCH_NO_VIRT_TO_BUS > > config ISA_DMA_API > > bool > >

[PATCH] pinctrl: am33xx dt binding: correct include path

2013-07-03 Thread Ian Campbell
Using #include is a bit odd. It happens to work because the DTC flags include -Iarch/FOO/boot/dts as well as arch/FOO/boot/dts/include and arch/FOO/boot/dts/include/dt-bindings is a symlink to include/dt-bindings. Signed-off-by: Ian Campbell Cc: Grant Likely Cc: Linus Walleij Cc: linux-kernel

[PATCH] pinctrl: am33xx dt binding: correct include path

2013-07-03 Thread Ian Campbell
Using #include include/... is a bit odd. It happens to work because the DTC flags include -Iarch/FOO/boot/dts as well as arch/FOO/boot/dts/include and arch/FOO/boot/dts/include/dt-bindings is a symlink to include/dt-bindings. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Grant Likely

Re: [Xen-devel] [PATCH RFC] xen/arm: domain kernel: Small fixes for making suspendable for arm

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 16:59 +0100, Stefano Stabellini wrote: diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2c3bdce..77309f7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1469,6 +1469,9 @@ config ARCH_NO_VIRT_TO_BUS config ISA_DMA_API bool +config

Re: kernel panic in skb_copy_bits

2013-07-01 Thread Ian Campbell
On Mon, 2013-07-01 at 11:18 +0800, Joe Jin wrote: > > A workaround is to turn off O_DIRECT use by Xen as that ensures > > the pages are copied. Xen 4.3 does this by default. > > > > I believe fixes for this are in 4.3 and 4.2.2 if using the > > qemu upstream DM. Note these aren't real fixes, just

Re: kernel panic in skb_copy_bits

2013-07-01 Thread Ian Campbell
On Mon, 2013-07-01 at 11:18 +0800, Joe Jin wrote: A workaround is to turn off O_DIRECT use by Xen as that ensures the pages are copied. Xen 4.3 does this by default. I believe fixes for this are in 4.3 and 4.2.2 if using the qemu upstream DM. Note these aren't real fixes, just a

Re: [PATCH next] xen: Convert printks to pr_

2013-06-28 Thread Ian Campbell
On Fri, 2013-06-28 at 03:21 -0700, Joe Perches wrote: > Convert printks to pr_ (excludes printk(KERN_DEBUG...) > to be more consistent throughout the xen subsystem. > > Add pr_fmt with KBUILD_MODNAME or "xen:" KBUILD_MODNAME > Coalesce formats and add missing word spaces > Add missing newlines >

Re: [PATCH next] xen: Use more current logging styles

2013-06-28 Thread Ian Campbell
umns. > > Signed-off-by: Joe Perches Acked-by: Ian Campbell > --- > drivers/net/xen-netback/netback.c | 7 +++ > drivers/net/xen-netfront.c| 28 +--- > 2 files changed, 16 insertions(+), 19 deletions(-) > > diff --git a/drivers/n

Re: [PATCH next] xen: Use more current logging styles

2013-06-28 Thread Ian Campbell
-by: Joe Perches j...@perches.com Acked-by: Ian Campbell ian.campb...@citrix.com --- drivers/net/xen-netback/netback.c | 7 +++ drivers/net/xen-netfront.c| 28 +--- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/net/xen-netback

Re: [PATCH next] xen: Convert printks to pr_level

2013-06-28 Thread Ian Campbell
On Fri, 2013-06-28 at 03:21 -0700, Joe Perches wrote: Convert printks to pr_level (excludes printk(KERN_DEBUG...) to be more consistent throughout the xen subsystem. Add pr_fmt with KBUILD_MODNAME or xen: KBUILD_MODNAME Coalesce formats and add missing word spaces Add missing newlines

Re: [Xen-devel] [PATCH v4 5/6] arm64/xen: introduce CONFIG_XEN on ARM64

2013-06-06 Thread Ian Campbell
On Thu, 2013-06-06 at 10:27 +0100, Catalin Marinas wrote: > On Thu, Jun 06, 2013 at 10:03:39AM +0100, Ian Campbell wrote: > > On Wed, 2013-06-05 at 18:02 +0100, Stefano Stabellini wrote: > > > + * the second in r1/x1, the third in r2/x2 and the fourth in r3/x3. > > &g

Re: [Xen-devel] [PATCH v4 5/6] arm64/xen: introduce CONFIG_XEN on ARM64

2013-06-06 Thread Ian Campbell
ere. If you fix the typo and clarify the fifth argument or not as you wish: Acked-by: Ian Campbell Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [Xen-devel] [PATCH v4 5/6] arm64/xen: introduce CONFIG_XEN on ARM64

2013-06-06 Thread Ian Campbell
or not as you wish: Acked-by: Ian Campbell ian.campb...@citrix.com Ian. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [Xen-devel] [PATCH v4 5/6] arm64/xen: introduce CONFIG_XEN on ARM64

2013-06-06 Thread Ian Campbell
On Thu, 2013-06-06 at 10:27 +0100, Catalin Marinas wrote: On Thu, Jun 06, 2013 at 10:03:39AM +0100, Ian Campbell wrote: On Wed, 2013-06-05 at 18:02 +0100, Stefano Stabellini wrote: + * the second in r1/x1, the third in r2/x2 and the fourth in r3/x3. + * Considering that Xen hypercalls

Re: [PATCH v3 6/6] MAINTAINERS: add myself as arm64/xen maintainer

2013-06-05 Thread Ian Campbell
On Wed, 2013-06-05 at 13:15 +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini Acked-by: Ian Campbell > --- > MAINTAINERS |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index fd

Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64

2013-06-05 Thread Ian Campbell
Stabellini Acked-by: Ian Campbell > [] > +#define HYPERCALL_SIMPLE(hypercall) \ > +ENTRY(HYPERVISOR_##hypercall)\ > + mov x16, #__HYPERVISOR_##hypercall; \ > + hvc XEN_IMM;

Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64

2013-06-05 Thread Ian Campbell
...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com [] +#define HYPERCALL_SIMPLE(hypercall) \ +ENTRY(HYPERVISOR_##hypercall)\ + mov x16, #__HYPERVISOR_##hypercall; \ + hvc XEN_IMM;\ + ret

Re: [PATCH v3 6/6] MAINTAINERS: add myself as arm64/xen maintainer

2013-06-05 Thread Ian Campbell
On Wed, 2013-06-05 at 13:15 +0100, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b

Re: [PATCH v2 2/5] arm64/xen: introduce asm/xen header files on arm64

2013-06-04 Thread Ian Campbell
/xen/events.h is slightly different, so introduce a different file > here (use xchg to implement xchg_xen_ulong and pass regs->pstate to > raw_irqs_disabled_flags). > > Also introduce asm/hypervisor.h and asm/sync_bitops.h. > > Signed-off-by: Stefano Stabellini Acked-by: Ia

Re: [PATCH v2 4/5] arm64/xen: use XEN_IO_PROTO_ABI_ARM on ARM64

2013-06-04 Thread Ian Campbell
On Mon, 2013-06-03 at 16:33 +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini Acked-by: Ian Campbell > --- > include/xen/interface/io/protocols.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/xen/interface/i

Re: [PATCH v2 1/5] arm/xen: define xen_remap as ioremap_cached

2013-06-04 Thread Ian Campbell
On Mon, 2013-06-03 at 16:33 +0100, Stefano Stabellini wrote: > Define xen_remap as ioremap_cache (MT_MEMORY and MT_DEVICE_CACHED end up > having the same AttrIndx encoding). The entries in static struct mem_type mem_types[] look entirely different to me. What am I missing?

Re: [PATCH v2 1/5] arm/xen: define xen_remap as ioremap_cached

2013-06-04 Thread Ian Campbell
On Mon, 2013-06-03 at 16:33 +0100, Stefano Stabellini wrote: Define xen_remap as ioremap_cache (MT_MEMORY and MT_DEVICE_CACHED end up having the same AttrIndx encoding). The entries in static struct mem_type mem_types[] look entirely different to me. What am I missing?

Re: [PATCH v2 4/5] arm64/xen: use XEN_IO_PROTO_ABI_ARM on ARM64

2013-06-04 Thread Ian Campbell
On Mon, 2013-06-03 at 16:33 +0100, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com --- include/xen/interface/io/protocols.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH v2 2/5] arm64/xen: introduce asm/xen header files on arm64

2013-06-04 Thread Ian Campbell
different, so introduce a different file here (use xchg to implement xchg_xen_ulong and pass regs-pstate to raw_irqs_disabled_flags). Also introduce asm/hypervisor.h and asm/sync_bitops.h. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb

Re: [Xen-devel] [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 17:25 +0100, Catalin Marinas wrote: > On Mon, Jun 03, 2013 at 04:33:44PM +0100, Stefano Stabellini wrote: > > --- /dev/null > > +++ b/arch/arm64/xen/hypercall.S > ... > > +/* > > + * The Xen hypercall calling convention is very similar to the ARM AEBI > > + * procedure

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Ian Campbell
considered sufficient then it is OK by me to apply Tested-by: Ian Campbell to this change too. > > Reported-by: Ian Campbell > Signed-off-by: Stephen Warren > --- > This is a fix for 3.10. > > scripts/dtc/dtc-lexer.l |2 +- > scripts/dtc/dtc-lexer

Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote: > On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote: > >Currently I see: > > DTC arch/powerpc/boot/kilauea.dtb > >Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C1000 has > >inva

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-06-03 Thread Ian Campbell
t #address-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Gernot V

[PATCH] powerpc/boot: Ignore .dtb files.

2013-06-03 Thread Ian Campbell
Signed-off-by: Ian Campbell Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-...@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org --- arch/powerpc/boot/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/boot/.gitignore b/arch/powerpc/boot/.gitignore index

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
Adding PCIe MSI support" this platform does not use address-cells=2. Signed-off-by: Ian Campbell Cc: Rupjyoti Sarmah Cc: Tirumala R Marri Cc: Josh Boyer Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-...@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org --- arch/powerpc/boot/dt

Re: DTB build failure due to preproccessing

2013-06-03 Thread Ian Campbell
On Fri, 2013-05-31 at 17:31 +0100, Grant Likely wrote: > On Fri, May 31, 2013 at 5:04 PM, Stephen Warren wrote: > > On 05/31/2013 05:48 AM, Grant Likely wrote: > >> --- > >> commit d01dccdcb3ea8233b09efb9c24db9f057fbd3b37 > >> Author: Grant Likely > >> Date: Fri May 31 12:45:18 2013 +0100 > >>

Re: DTB build failure due to preproccessing

2013-06-03 Thread Ian Campbell
On Fri, 2013-05-31 at 17:31 +0100, Grant Likely wrote: On Fri, May 31, 2013 at 5:04 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 05/31/2013 05:48 AM, Grant Likely wrote: --- commit d01dccdcb3ea8233b09efb9c24db9f057fbd3b37 Author: Grant Likely grant.lik...@linaro.org Date: Fri

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
this platform does not use address-cells=2. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rupjyoti Sarmah rsar...@apm.com Cc: Tirumala R Marri tma...@apm.com Cc: Josh Boyer jwbo...@linux.vnet.ibm.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org

[PATCH] powerpc/boot: Ignore .dtb files.

2013-06-03 Thread Ian Campbell
Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org --- arch/powerpc/boot/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-06-03 Thread Ian Campbell
-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Benjamin Herrenschmidt b

Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote: On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote: Currently I see: DTC arch/powerpc/boot/kilauea.dtb Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has invalid length (12 bytes) (#address-cells == 1

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Ian Campbell
-by: Ian Campbell ian.campb...@citrix.com to this change too. Reported-by: Ian Campbell ian.campb...@citrix.com Signed-off-by: Stephen Warren swar...@nvidia.com --- This is a fix for 3.10. scripts/dtc/dtc-lexer.l |2 +- scripts/dtc/dtc-lexer.lex.c_shipped | 232

Re: [Xen-devel] [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 17:25 +0100, Catalin Marinas wrote: On Mon, Jun 03, 2013 at 04:33:44PM +0100, Stefano Stabellini wrote: --- /dev/null +++ b/arch/arm64/xen/hypercall.S ... +/* + * The Xen hypercall calling convention is very similar to the ARM AEBI + * procedure calling

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: > Hrm. Is this a "that's not in the kernel's copy yet" problem? BTW I'm using dtc.git 4e76ec796c90d44d417f82d9db2d67cfe575f8ed and not the kernel copy. dtc-lexer.l in my HEAD is identical to the current master

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: > > > > > > Line 374 is the "IDSEL 0x16..." line here: > > > interrupt-map = < > > > /* IRQ mapping for pci slots and ALI M1533 > > >... > > >

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 12:48 +0100, Grant Likely wrote: > On Fri, 31 May 2013 11:29:30 +0100, Ian Campbell > wrote: > > This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is > > actually a more general issue: > > > > $ make ARCH=power

DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is actually a more general issue: $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux- virtex440-ml510.dtb CC scripts/mod/devicetable-offsets.s GEN scripts/mod/devicetable-offsets.h

[PATCH] powerpc/fsl-booke: Rename b4qds.dts -> b4qds.dtsi.

2013-05-31 Thread Ian Campbell
1 make: *** [b4qds.dtb] Error 2 I spotted in build tests of device-tree.git, announcement https://lkml.org/lkml/2013/4/24/209, which builds *.dts. Probably no one would do this this in real life on linux.git but it still seems worth fixing. Signed-off-by: Ian Campbell Cc: Shaveta Leekha

[PATCH] kbuild: make sure we clean up DTB temporary files

2013-05-31 Thread Ian Campbell
Various temporary files used when building DTB files were not suffixed with .tmp and therefore were not cleaned up by "make clean". Signed-off-by: Ian Campbell Cc: Michal Marek Cc: Stephen Warren Cc: Rob Herring Cc: Grant Likely Cc: linux-kbu...@vger.kernel.org Cc: li

[PATCH] kbuild: make sure we clean up DTB temporary files

2013-05-31 Thread Ian Campbell
Various temporary files used when building DTB files were not suffixed with .tmp and therefore were not cleaned up by make clean. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Michal Marek mma...@suse.cz Cc: Stephen Warren swar...@nvidia.com Cc: Rob Herring rob.herr...@calxeda.com Cc

[PATCH] powerpc/fsl-booke: Rename b4qds.dts - b4qds.dtsi.

2013-05-31 Thread Ian Campbell
1 make: *** [b4qds.dtb] Error 2 I spotted in build tests of device-tree.git, announcement https://lkml.org/lkml/2013/4/24/209, which builds *.dts. Probably no one would do this this in real life on linux.git but it still seems worth fixing. Signed-off-by: Ian Campbell ian.campb

DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is actually a more general issue: $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux- virtex440-ml510.dtb CC scripts/mod/devicetable-offsets.s GEN scripts/mod/devicetable-offsets.h

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 12:48 +0100, Grant Likely wrote: On Fri, 31 May 2013 11:29:30 +0100, Ian Campbell ian.campb...@citrix.com wrote: This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is actually a more general issue: $ make ARCH=powerpc CROSS_COMPILE

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: Line 374 is the IDSEL 0x16... line here: interrupt-map = /* IRQ mapping for pci slots and ALI M1533 ... * management

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: Hrm. Is this a that's not in the kernel's copy yet problem? BTW I'm using dtc.git 4e76ec796c90d44d417f82d9db2d67cfe575f8ed and not the kernel copy. dtc-lexer.l in my HEAD is identical to the current master

Re: [Xen-devel] [PATCH-v2] xen: Don't call arch_trigger_all_cpu_backtrace in dom0(pvm)

2013-05-15 Thread Ian Campbell
On Wed, 2013-05-15 at 16:40 +0800, Zhenzhong Duan wrote: > On 2013-04-10 00:36, Ian Campbell wrote: > > On Mon, 2013-04-08 at 08:42 +0100, Jan Beulich wrote: > >>>>> On 07.04.13 at 07:54, Zhenzhong Duan wrote: > >>> nmi isn't supported in dom0, fal

Re: [Xen-devel] [PATCH-v2] xen: Don't call arch_trigger_all_cpu_backtrace in dom0(pvm)

2013-05-15 Thread Ian Campbell
On Wed, 2013-05-15 at 16:40 +0800, Zhenzhong Duan wrote: On 2013-04-10 00:36, Ian Campbell wrote: On Mon, 2013-04-08 at 08:42 +0100, Jan Beulich wrote: On 07.04.13 at 07:54, Zhenzhong Duan zhenzhong.d...@oracle.com wrote: nmi isn't supported in dom0, fallback to general all cpu backtrace

Re: [RFC] device-tree.git automatic sync from linux.git

2013-05-13 Thread Ian Campbell
On Mon, 2013-05-13 at 08:02 +0100, Michal Simek wrote: > Just small overview it is a Xilinx soft core cpu where you can even setup > some parameters for core itself - multiplier, divider, BS, fpu, cache sizes, > etc. > You have to also compose the whole system and every platform/configuration is

Re: [RFC] device-tree.git automatic sync from linux.git

2013-05-13 Thread Ian Campbell
On Mon, 2013-05-13 at 08:02 +0100, Michal Simek wrote: Just small overview it is a Xilinx soft core cpu where you can even setup some parameters for core itself - multiplier, divider, BS, fpu, cache sizes, etc. You have to also compose the whole system and every platform/configuration is

Re: [Xen-devel] [PATCH v3 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c

2013-05-09 Thread Ian Campbell
> > > - use the new common functions in arch/ia64/xen/time.c. > > > > > > Signed-off-by: Stefano Stabellini > > > Acked-by: Ian Campbell > > > CC: konrad.w...@oracle.com > > > > On the generic and x86 side it looks OK to me. I presume you di

Re: [Xen-devel] [PATCH v3 4/4] xen/arm: account for stolen ticks

2013-05-09 Thread Ian Campbell
On Wed, 2013-05-08 at 18:03 +0100, Stefano Stabellini wrote: > > What if we have Xen support enabled but don't run as a Xen guest? > > That's fine as long as the Xen runstate_memory_area interface is > available. > Usually I am a great fun of feature flags, so that every feature can be >

Re: [Xen-devel] [PATCH v3 4/4] xen/arm: account for stolen ticks

2013-05-09 Thread Ian Campbell
On Wed, 2013-05-08 at 18:03 +0100, Stefano Stabellini wrote: What if we have Xen support enabled but don't run as a Xen guest? That's fine as long as the Xen runstate_memory_area interface is available. Usually I am a great fun of feature flags, so that every feature can be dynamically

Re: [Xen-devel] [PATCH v3 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c

2013-05-09 Thread Ian Campbell
/ia64/xen/time.c. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: konrad.w...@oracle.com On the generic and x86 side it looks OK to me. I presume you did a sanity check on x86 to make sure nothing was off? Yep

Re: [PATCH 2/3] xen/arm: do not handle VCPUOP_register_vcpu_info failures

2013-05-08 Thread Ian Campbell
n if > -later ones fail to. */ > - per_cpu(xen_vcpu, cpu) = vcpup; > - } > + if (err) > + BUG(); AKA BUG_ON(err); Acked-by: Ian Campbell > + per_cpu(xen_vcpu, cpu) = vcpup; > + > return 0; > } > -- To uns

Re: [PATCH 2/3] xen/arm: do not handle VCPUOP_register_vcpu_info failures

2013-05-08 Thread Ian Campbell
to. */ - per_cpu(xen_vcpu, cpu) = vcpup; - } + if (err) + BUG(); AKA BUG_ON(err); Acked-by: Ian Campbell ian.campb...@citrix.com + per_cpu(xen_vcpu, cpu) = vcpup; + return 0; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/arm: account for stolen ticks

2013-05-07 Thread Ian Campbell
> > > @@ -301,6 +320,10 @@ static int __init xen_init_events(void) > > > > > > on_each_cpu(xen_percpu_init, NULL, 0); > > > > > > + pv_time_ops.steal_clock = xen_stolen_accounting; > > > + static_key_slow_inc(_steal_enabled); > > > + static_key_slow_inc(_steal_rq_enabled); > > > > We don't

Re: [Xen-devel] [PATCH RFC v2 2/4] arm: introduce CONFIG_PARAVIRT and pv_time_ops

2013-05-07 Thread Ian Campbell
On Tue, 2013-05-07 at 13:15 +0100, Stefano Stabellini wrote: > On Tue, 7 May 2013, Ian Campbell wrote: > > On Mon, 2013-05-06 at 15:51 +0100, Stefano Stabellini wrote: > > > Introduce CONFIG_PARAVIRT on ARM. > > > > What about PARAVIRT_TIME_ACCOUNTING? I'm not su

Re: [Xen-devel] [PATCH 2/4] xen/vcpu: Document the xen_vcpu_info and xen_vcpu

2013-05-07 Thread Ian Campbell
On Mon, 2013-05-06 at 14:04 +0100, Konrad Rzeszutek Wilk wrote: > They are important structures and it is not clear at first > look what they are for. > > The xen_vcpu is a pointer. By default it points to the shared_info > structure (at the CPU offset location). However if the >

Re: [Xen-devel] [PATCH RFC v2 2/4] arm: introduce CONFIG_PARAVIRT and pv_time_ops

2013-05-07 Thread Ian Campbell
On Mon, 2013-05-06 at 15:51 +0100, Stefano Stabellini wrote: > Introduce CONFIG_PARAVIRT on ARM. What about PARAVIRT_TIME_ACCOUNTING? I'm not sure what it is but it looks like a more lightweight version of pv stolen time? > The only paravirt interface supported is pv_time_ops.steal_clock. > No

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/arm: account for stolen ticks

2013-05-07 Thread Ian Campbell
On Mon, 2013-05-06 at 15:51 +0100, Stefano Stabellini wrote: > Register the runstate_memory_area with the hypervisor. > Use pv_time_ops.steal_clock to account for stolen ticks. > > Signed-off-by: Stefano Stabellini > --- > arch/arm/xen/enlighten.c | 23 +++ > 1 files

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/arm: account for stolen ticks

2013-05-07 Thread Ian Campbell
@@ -301,6 +320,10 @@ static int __init xen_init_events(void) on_each_cpu(xen_percpu_init, NULL, 0); + pv_time_ops.steal_clock = xen_stolen_accounting; + static_key_slow_inc(paravirt_steal_enabled); + static_key_slow_inc(paravirt_steal_rq_enabled); We don't seem to

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 16:47 +0100, Daniel Kiper wrote: > > > > > Do not forget that guest may change target itself. > > > > > > > > Yes it can, and that can fail either due to maxmem or due to ENOMEM, and > > > > the kernel needs prepared to deal with that when it happens. > > > > > > Sure but why

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 14:47 +0100, Daniel Kiper wrote: > On Fri, May 03, 2013 at 02:21:24PM +0100, Ian Campbell wrote: > > On Fri, 2013-05-03 at 14:00 +0100, Daniel Kiper wrote: > > > On Fri, May 03, 2013 at 09:15:32AM +0100, Ian Campbell wrote: > > > > On Thu, 201

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 14:00 +0100, Daniel Kiper wrote: > On Fri, May 03, 2013 at 09:15:32AM +0100, Ian Campbell wrote: > > On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek Wilk wrote: > > > On Thu, May 02, 2013 at 12:34:32PM +0100, Stefano Stabellini wrote: > > [...]

Re: [Xen-devel] [PATCH 2/3] xen: move do_stolen_accounting to drivers/xen/time.c

2013-05-03 Thread Ian Campbell
On Thu, 2013-05-02 at 19:49 +0100, Christopher Covington wrote: > Hi Stefano, > > On 05/01/2013 03:27 PM, Stefano Stabellini wrote: > > Move do_stolen_accounting, xen_vcpu_stolen and related functions and > > static variables to common code (drivers/xen/time.c). > > > > Signed-off-by: Stefano

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek Wilk wrote: > On Thu, May 02, 2013 at 12:34:32PM +0100, Stefano Stabellini wrote: > > On Tue, 30 Apr 2013, Daniel Kiper wrote: > > > > > > > +/* > > > > > > > + * Extra internal memory reserved by libxl. > > > > > > > + * Check

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Tue, 2013-04-30 at 19:58 +0100, Daniel Kiper wrote: > On Tue, Apr 30, 2013 at 02:44:18PM +0100, Ian Campbell wrote: > > On Tue, 2013-04-30 at 13:59 +0100, Daniel Kiper wrote: > > > On Mon, Apr 29, 2013 at 03:44:09PM +0100, Ian Campbell wrote: > > > > On Mon, 201

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Tue, 2013-04-30 at 19:58 +0100, Daniel Kiper wrote: On Tue, Apr 30, 2013 at 02:44:18PM +0100, Ian Campbell wrote: On Tue, 2013-04-30 at 13:59 +0100, Daniel Kiper wrote: On Mon, Apr 29, 2013 at 03:44:09PM +0100, Ian Campbell wrote: On Mon, 2013-04-29 at 12:37 +0100, Daniel Kiper wrote

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek Wilk wrote: On Thu, May 02, 2013 at 12:34:32PM +0100, Stefano Stabellini wrote: On Tue, 30 Apr 2013, Daniel Kiper wrote: +/* + * Extra internal memory reserved by libxl. + * Check tools/libxl/libxl_memory.txt file in Xen

Re: [Xen-devel] [PATCH 2/3] xen: move do_stolen_accounting to drivers/xen/time.c

2013-05-03 Thread Ian Campbell
On Thu, 2013-05-02 at 19:49 +0100, Christopher Covington wrote: Hi Stefano, On 05/01/2013 03:27 PM, Stefano Stabellini wrote: Move do_stolen_accounting, xen_vcpu_stolen and related functions and static variables to common code (drivers/xen/time.c). Signed-off-by: Stefano Stabellini

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 14:00 +0100, Daniel Kiper wrote: On Fri, May 03, 2013 at 09:15:32AM +0100, Ian Campbell wrote: On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek Wilk wrote: On Thu, May 02, 2013 at 12:34:32PM +0100, Stefano Stabellini wrote: [...] The xapi guys, CC'ed, might

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 14:47 +0100, Daniel Kiper wrote: On Fri, May 03, 2013 at 02:21:24PM +0100, Ian Campbell wrote: On Fri, 2013-05-03 at 14:00 +0100, Daniel Kiper wrote: On Fri, May 03, 2013 at 09:15:32AM +0100, Ian Campbell wrote: On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 16:47 +0100, Daniel Kiper wrote: Do not forget that guest may change target itself. Yes it can, and that can fail either due to maxmem or due to ENOMEM, and the kernel needs prepared to deal with that when it happens. Sure but why we would like to fail

Re: [Xen-devel] [PATCH 3/3] xen/arm: account for stolen ticks

2013-05-02 Thread Ian Campbell
On Thu, 2013-05-02 at 11:54 +0100, Stefano Stabellini wrote: > On Thu, 2 May 2013, Ian Campbell wrote: > > On Thu, 2013-05-02 at 11:38 +0100, Stefano Stabellini wrote: > > > On Thu, 2 May 2013, Ian Campbell wrote: > > > > On Wed, 2013-05-01 at 20:27 +0100, Stefano St

Re: [Xen-devel] [PATCH 3/3] xen/arm: account for stolen ticks

2013-05-02 Thread Ian Campbell
On Thu, 2013-05-02 at 11:38 +0100, Stefano Stabellini wrote: > On Thu, 2 May 2013, Ian Campbell wrote: > > On Wed, 2013-05-01 at 20:27 +0100, Stefano Stabellini wrote: > > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > > > index d30042e..8f040a0

Re: [Xen-devel] [PATCH 3/3] xen/arm: account for stolen ticks

2013-05-02 Thread Ian Campbell
On Wed, 2013-05-01 at 20:27 +0100, Stefano Stabellini wrote: > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index d30042e..8f040a0 100644 > --- a/arch/arm/xen/enlighten.c > +++ b/arch/arm/xen/enlighten.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include

Re: [Xen-devel] [PATCH 1/3] arm_arch_timer: introduce arch_timer_stolen_ticks

2013-05-02 Thread Ian Campbell
On Wed, 2013-05-01 at 21:36 +0100, Christopher Covington wrote: > Hi Stefano, > > On 05/01/2013 03:27 PM, Stefano Stabellini wrote: > > Introduce a function, called arch_timer_stolen_ticks, called from the > > arch_timer interrupt handler to account for stolen ticks. > > [...] > > > diff --git

<    1   2   3   4   5   6   7   8   9   10   >