Re: [linux-sunxi] [PATCH 2/2] ARM: sun6i: Add SMP support for the Allwinner A31

2013-11-04 Thread Ian Campbell
Not a comment on the patch, or even A31, but a question about how the SMP boot process works on sunxi generally... On Sun, 2013-11-03 at 10:30 +0100, Maxime Ripard wrote: The A31 is a quad Cortex-A7. Add the logic to use the IPs used to control the CPU configuration and the CPU power so that we

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

2013-11-05 Thread Ian Campbell
On Tue, 2013-11-05 at 16:01 +0100, Roger Pau Monné wrote: On 05/11/13 15:56, Konrad Rzeszutek Wilk wrote: On Tue, Nov 05, 2013 at 03:47:08PM +0100, Roger Pau Monné wrote: On 05/11/13 13:36, David Vrabel wrote: On 05/11/13 11:24, Roger Pau Monne wrote: IMHO there's no reason to set a m2p

Re: [Xen-devel] [PATCH] grant-table: don't set m2p override if kmap_ops is not set

2013-11-06 Thread Ian Campbell
On Tue, 2013-11-05 at 12:53 -0800, Anthony Liguori wrote: Yes, you are completely right, then I have to figure out why blkback works fine with this patch applied (or at least it seems to work fine). blkback also works for me when testing a similar patch. I'm still confused. One thing

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-11-07 Thread Ian Campbell
On Fri, 2013-11-01 at 19:00 +, Zoltan Kiss wrote: On 01/11/13 10:50, Ian Campbell wrote: Does this always avoid copying when bridging/openvswitching/forwarding (e.g. masquerading etc)? For both domU-domU and domU-physical NIC? I've tested the domU-domU, domU-physical with bridge

Re: [PATCH v9 03/18] arm/xen,arm64/xen: introduce p2m

2013-11-07 Thread Ian Campbell
On Fri, 2013-10-25 at 11:51 +0100, Stefano Stabellini wrote: Introduce physical to machine and machine to physical tracking mechanisms based on rbtrees for arm/xen and arm64/xen. We need it because any guests on ARM are an autotranslate guests, therefore a physical address is potentially

Re: [PATCH 3.8 23/91] xen-netback: Don't destroy the netdev until the vif is shut down

2013-11-08 Thread Ian Campbell
On Thu, 2013-11-07 at 18:14 -0800, Kamal Mostafa wrote: 3.8.13.13 -stable review patch. If anyone has any objections, please let me know. This patch caused a regression in the 3.10 stable tree. Two additional patches were needed, see: http://www.spinics.net/lists/netdev/msg256637.html

Re: [linux-sunxi] [PATCH 2/2] ARM: sun6i: Add SMP support for the Allwinner A31

2013-11-08 Thread Ian Campbell
On Fri, 2013-11-08 at 09:40 +0100, Maxime Ripard wrote: I'm trying to work out if we can make this work with the requirement which both Xen and KVM have to enter the kernel in NS-HYP mode. The way this works on e.g. vexpress is (roughly) that u-boot wakes up the secondary CPUs from the

Re: [Xen-devel] [PATCH 4/4] xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart.

2013-11-22 Thread Ian Campbell
graft 8 20130528152156.gb3...@phenom.dumpdata.com prune 8 20130528181149.ga27...@phenom.dumpdata.com thanks On Thu, 2013-11-21 at 17:52 +, David Vrabel wrote: Fixes-Bug: http://bugs.xenproject.org/xen/bug/8 This bug link has no useful information in it. Looks like the intention was for

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-11-25 Thread Ian Campbell
this platform does not use address-cells=2. Signed-off-by: Ian Campbell ian.campb...@citrix.com Acked-by: Josh Boyer jwbo...@gmail.com Cc: Rupjyoti Sarmah rsar...@apm.com Cc: Tirumala R Marri tma...@apm.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-11-25 Thread Ian Campbell
-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Benjamin Herrenschmidt b

Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq

2013-11-25 Thread Ian Campbell
On Wed, 2013-11-20 at 15:24 +0530, Laxman Dewangan wrote: On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote: Hi, Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs earlier) split the suspend/resume of the irqs into two parts. The early-irqs get resumed

Re: [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic

2013-11-25 Thread Ian Campbell
-declaration] tcph-check = ~csum_ipv6_magic(ipv6h-saddr, Signed-off-by: Andy Whitcroft a...@canonical.com Acked-by: Ian Campbell ian.campb...@citrix.com Thanks! --- drivers/net/xen-netback/netback.c | 1 + 1 file changed, 1 insertion(+) Found while trying to couple latest kernels

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-11-28 Thread Ian Campbell
On Thu, 2013-11-28 at 17:37 +, Zoltan Kiss wrote: On 07/11/13 10:52, Ian Campbell wrote: On Fri, 2013-11-01 at 19:00 +, Zoltan Kiss wrote: On 01/11/13 10:50, Ian Campbell wrote: Does this always avoid copying when bridging/openvswitching/forwarding (e.g. masquerading etc

Re: [PATCH] xen/arm: pfn_to_mfn and mfn_to_pfn return the argument if nothing is in the p2m

2013-11-11 Thread Ian Campbell
is the pfn corresponding to an mfn. Fix the regression by switching to the old behavior. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com I tripped over this on Friday and my local hack was identical, hence also: Tested-by: Ian

Re: [linux-sunxi] [PATCH 2/2] ARM: sun6i: Add SMP support for the Allwinner A31

2013-11-11 Thread Ian Campbell
On Sun, 2013-11-10 at 11:03 +0100, Maxime Ripard wrote: Hi Ian, On Fri, Nov 08, 2013 at 10:25:55AM +, Ian Campbell wrote: On Fri, 2013-11-08 at 09:40 +0100, Maxime Ripard wrote: I'm trying to work out if we can make this work with the requirement which both Xen and KVM have

Re: [Xen-devel] [PATCH] xen-gnttab: do not add m2p override entries for blkback mappings

2013-11-13 Thread Ian Campbell
On Tue, 2013-11-12 at 17:48 -0800, Anthony Liguori wrote: See http://article.gmane.org/gmane.linux.kernel/1590932 for a full analysis of current users. Silly nit: Please can you include the message ID in case this goes away, or use a URL which includes the ID already so it can be translated if

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:57 +0100, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using the native ABI, and __packed__ should only be used in the backend counterpart of those structures (which needs to handle different ABIs).

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: On 03/12/13 10:57, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using the native ABI, and __packed__ should only be used in the backend counterpart of those

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:11 +, Jan Beulich wrote: On 03.12.13 at 12:05, Ian Campbell ian.campb...@citrix.com wrote: On Tue, 2013-12-03 at 11:57 +0100, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using the native ABI

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 11:59 +, David Vrabel wrote: On 03/12/13 11:08, Ian Campbell wrote: On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: On 03/12/13 10:57, Roger Pau Monne wrote: Using __packed__ on the public interface is not correct, this structures should be compiled using

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:11 +, David Vrabel wrote: On 03/12/13 13:41, Ian Campbell wrote: On Tue, 2013-12-03 at 11:59 +, David Vrabel wrote: On 03/12/13 11:08, Ian Campbell wrote: On Tue, 2013-12-03 at 11:01 +, David Vrabel wrote: On 03/12/13 10:57, Roger Pau Monne wrote

Re: [Xen-devel] [PATCH] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:28 +, Julien Grall wrote: On 12/03/2013 03:15 PM, Jan Beulich wrote: On 03.12.13 at 16:09, Julien Grall julien.gr...@linaro.org wrote: --- a/include/xen/interface/io/blkif.h +++ b/include/xen/interface/io/blkif.h @@ -146,7 +146,7 @@ struct

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 15:51 +, One Thousand Gnomes wrote: If Konrad and Boris agree that breaking the kernel's ABI in this way is acceptable in this specific case, I'll defer to them. My opinion as Xen on ARM hypervisor maintainer is that this is the right thing to do in this

Re: [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-03 Thread Ian Campbell
On Tue, 2013-12-03 at 16:32 +, One Thousand Gnomes wrote: How does the patch ensure new kernels on existing hypervisor versions don't break ? As Ian said on the thread xen-block: correctly define structures in public headers (see thread https://lkml.org/lkml/2013/12/3/155), the

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-04 Thread Ian Campbell
On Tue, 2013-12-03 at 15:11 -0500, Konrad Rzeszutek Wilk wrote: If Konrad and Boris agree that breaking the kernel's ABI in this way is acceptable in this specific case, I'll defer to them. My opinion as Xen on ARM hypervisor maintainer is that this is the right thing to do in this

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
drivers. P.S. Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' but unfortunatly the xen-blkfront driver is using it, so we cannot do it. It might still be nice to expose a suitable semantic interface (i.e. some relevant predicate) rather than the raw value for blkfront to use

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: +bool xen_has_pv_devices(void) +{ + if (!xen_domain()) + return false; + + if (xen_hvm_domain()) { + /* User requested no unplug, so no PV drivers

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: +bool xen_has_pv_devices(void) +{ + if (!xen_domain

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:18 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013, Ian Campbell wrote: On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: On Wed, 4 Dec 2013

Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 09:28 +, Ian Campbell wrote: This could probably even be semi automated by producing a script to feed to gdb which run through all of the options and diffing the result. If I could have the moon on a stick I would have a tool such as this running against

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 13:00 +, David Vrabel wrote: On 03/12/13 21:14, Konrad Rzeszutek Wilk wrote: Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' but unfortunatly the xen-blkfront driver is using it, so we cannot do it. I had a look at what blkfront was using

Re: [PATCH net-next v7 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy

2014-03-12 Thread Ian Campbell
On Sat, 2014-03-08 at 18:57 -0500, David Miller wrote: From: Zoltan Kiss zoltan.k...@citrix.com Date: Sat, 8 Mar 2014 14:37:50 + Maybe you mixed up mine with that? But that's also not eligible to be applied yet. I can always revert the series if there are major objections. Zoltan

Re: [PATCH net-next v7 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy

2014-03-13 Thread Ian Campbell
On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: A long known problem of the upstream netback implementation that on the TX path (from guest to Dom0) it copies the whole packet from guest memory into Dom0. That simply became a bottleneck with 10Gb NICs, and generally it's a huge

Re: [PATCH net-next v7 4/9] xen-netback: Introduce TX grant mapping

2014-03-13 Thread Ian Campbell
Pulling out this one comment for the attention on the core Xen/Linux maintainers. On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: [...] @@ -343,8 +347,26 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid, vif-pending_prod = MAX_PENDING_REQS; for (i = 0; i

Re: [PATCH net-next v7 4/9] xen-netback: Introduce TX grant mapping

2014-03-13 Thread Ian Campbell
On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: @@ -135,13 +146,31 @@ struct xenvif { pending_ring_idx_t pending_cons; u16 pending_ring[MAX_PENDING_REQS]; struct pending_tx_info pending_tx_info[MAX_PENDING_REQS]; + grant_handle_t grant_tx_handle[MAX_PENDING_REQS];

Re: [PATCH net-next v7 8/9] xen-netback: Timeout packets in RX path

2014-03-13 Thread Ian Campbell
On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: @@ -557,12 +577,25 @@ void xenvif_disconnect(struct xenvif *vif) void xenvif_free(struct xenvif *vif) { int i, unmap_timeout = 0; + /* Here we want to avoid timeout messages if an skb can be legitimatly legitimately + *

Re: [PATCH net-next v7 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy

2014-03-13 Thread Ian Campbell
On Wed, 2014-03-12 at 15:40 +, Ian Campbell wrote: On Sat, 2014-03-08 at 18:57 -0500, David Miller wrote: From: Zoltan Kiss zoltan.k...@citrix.com Date: Sat, 8 Mar 2014 14:37:50 + Maybe you mixed up mine with that? But that's also not eligible to be applied yet. I can

Re: [PATCH net-next] xen-netback: Schedule NAPI from dealloc thread instead of callback

2014-03-13 Thread Ian Campbell
, right? I think so, and therefore: Acked-by: Ian Campbell ian.campb...@citrix.com Ian. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [Xen-devel] [PATCH net-next v7 4/9] xen-netback: Introduce TX grant mapping

2014-03-13 Thread Ian Campbell
On Thu, 2014-03-13 at 10:56 +, David Vrabel wrote: On 13/03/14 10:33, Ian Campbell wrote: On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: @@ -135,13 +146,31 @@ struct xenvif { pending_ring_idx_t pending_cons; u16 pending_ring[MAX_PENDING_REQS]; struct pending_tx_info

Re: [PATCH net-next v7 4/9] xen-netback: Introduce TX grant mapping

2014-03-13 Thread Ian Campbell
On Thu, 2014-03-13 at 13:17 +, Zoltan Kiss wrote: On 13/03/14 10:33, Ian Campbell wrote: On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: @@ -135,13 +146,31 @@ struct xenvif { pending_ring_idx_t pending_cons; u16 pending_ring[MAX_PENDING_REQS]; struct pending_tx_info

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-24 Thread Ian Campbell
On Fri, 2014-02-21 at 01:19 +, Zoltan Kiss wrote: I don't know if the guest expects that slots for the same packet comes back at the same time. I don't think the guest is allowed to assume that. In particular they aren't allowed to assume the the slots will be freed in the order they were

Re: [Xen-devel] [PATCH v2] xen-blkfront: remove type check from blkfront_setup_discard

2014-01-13 Thread Ian Campbell
On Mon, 2014-01-13 at 12:34 +, Jan Beulich wrote: On 13.01.14 at 13:01, Olaf Hering o...@aepfle.de wrote: On Mon, Jan 13, Jan Beulich wrote: You can't do this in one go - the first two and the last one may be set independently (and are independent in their meaning), and hence need

Re: [Xen-devel] [PATCH v2] xen-blkfront: remove type check from blkfront_setup_discard

2014-01-13 Thread Ian Campbell
On Mon, 2014-01-13 at 13:16 +, Jan Beulich wrote: On 13.01.14 at 14:00, Ian Campbell ian.campb...@citrix.com wrote: On Mon, 2014-01-13 at 12:34 +, Jan Beulich wrote: On 13.01.14 at 13:01, Olaf Hering o...@aepfle.de wrote: On Mon, Jan 13, Jan Beulich wrote: You can't do

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-13 Thread Ian Campbell
On Wed, 2014-02-12 at 14:05 -0800, Luis R. Rodriguez wrote: I meant the PV protocol extension which allows guests (netfront) to register to receive multicast frames across the PV ring -- i.e. for multicast to work from the guests PoV. Not quite sure I understand, ipv6 works on guests so

Re: [Xen-devel] [RFC v2 3/4] xen-netback: use a random MAC address

2014-02-18 Thread Ian Campbell
On Mon, 2014-02-17 at 10:29 +, David Vrabel wrote: On 15/02/14 02:59, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com The purpose of using a static MAC address of FE:FF:FF:FF:FF:FF was to prevent our backend interfaces from being used by the bridge and nominating

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-18 Thread Ian Campbell
On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: This patch contains the new definitions necessary for grant mapping. Is this just adding a bunch of (currently) unused functions? That's a slightly odd way to structure a series. They don't seem to be generic helpers or anything so it would

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-18 Thread Ian Campbell
On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: + spinlock_t dealloc_lock; + spinlock_t response_lock; Please add comments to both of these describing what bits of the datastructure they are locking. You might find it is clearer to group the locks and the things they

Re: [PATCH net-next v5 2/9] xen-netback: Change TX path from grant copy to mapping

2014-02-18 Thread Ian Campbell
On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: This patch changes the grant copy on the TX patch to grant mapping Both this and the previous patch had a single sentence commit message (I count them together since they are split weirdly and are a single logical change to my eyes). Really

Re: [PATCH net-next v5 4/9] xen-netback: Change RX path for mapped SKB fragments

2014-02-18 Thread Ian Campbell
On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: Re the Subject: change how? Perhaps handle foreign mapped pages on the guest RX path would be clearer. RX path need to know if the SKB fragments are stored on pages from another domain. Does this not need to be done either before the

Re: [Xen-devel] [RFC v2 4/4] xen-netback: skip IPv4 and IPv6 interfaces

2014-02-19 Thread Ian Campbell
On Tue, 2014-02-18 at 12:16 -0800, Luis R. Rodriguez wrote: On Mon, Feb 17, 2014 at 6:36 AM, Zoltan Kiss zoltan.k...@citrix.com wrote: Also, the backend is not necessarily Dom0, you can connect two guests with backend/frontend pairs. Can you elaborate a bit more on this type of setup? The

Re: [Xen-devel] [RFC v2 0/4] net: bridge / ip optimizations for virtual net backends

2014-02-19 Thread Ian Campbell
On Tue, 2014-02-18 at 11:43 -0800, Luis R. Rodriguez wrote: New motivation: removing IPv4 and IPv6 from the backend interfaces can save up a lot of boiler plate run time code, triggers from ever taking place, and simplifying the backend interaces. If there is no use for IPv4 and IPv6

Re: [PATCH net-next v5 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy

2014-02-19 Thread Ian Campbell
On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: A long known problem of the upstream netback implementation that on the TX path (from guest to Dom0) it copies the whole packet from guest memory into Dom0. That simply became a bottleneck with 10Gb NICs, and generally it's a huge

Re: [Xen-devel] [RFC v2 1/4] bridge: enable interfaces to opt out from becoming the root bridge

2014-02-19 Thread Ian Campbell
On Tue, 2014-02-18 at 13:02 -0800, Luis R. Rodriguez wrote: On Sun, Feb 16, 2014 at 10:57 AM, Stephen Hemminger step...@networkplumber.org wrote: On Fri, 14 Feb 2014 18:59:37 -0800 Luis R. Rodriguez mcg...@do-not-panic.com wrote: From: Luis R. Rodriguez mcg...@suse.com It doesn't

Re: [Xen-devel] [PATCH net-next v5 2/9] xen-netback: Change TX path from grant copy to mapping

2014-02-19 Thread Ian Campbell
On Tue, 2014-02-18 at 18:46 +, David Vrabel wrote: On 18/02/14 17:40, Ian Campbell wrote: On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: @@ -344,8 +346,26 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid, vif-pending_prod = MAX_PENDING_REQS

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-19 Thread Ian Campbell
On Tue, 2014-02-18 at 20:36 +, Zoltan Kiss wrote: On 18/02/14 17:06, Ian Campbell wrote: On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: This patch contains the new definitions necessary for grant mapping. Is this just adding a bunch of (currently) unused functions? That's

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-20 Thread Ian Campbell
On Wed, 2014-02-19 at 19:54 +, Zoltan Kiss wrote: On 19/02/14 10:05, Ian Campbell wrote: On Tue, 2014-02-18 at 20:36 +, Zoltan Kiss wrote: On 18/02/14 17:06, Ian Campbell wrote: On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: This patch contains the new definitions necessary

Re: [PATCH 2/2] arm/xen: Don't use xen DMA ops when the device is protected by an IOMMU

2014-02-20 Thread Ian Campbell
On Thu, 2014-02-20 at 16:21 +, Julien Grall wrote: Only Xen is able to know if a device can safely avoid to use xen-swiotlb. This patch introduce a new property protected-devices for the hypervisor node which list device which the IOMMU are been correctly programmed by Xen. During Linux

Re: [PATCH 2/2] arm/xen: Don't use xen DMA ops when the device is protected by an IOMMU

2014-02-20 Thread Ian Campbell
Adding the -spec list for the generic IOMMU binding question. On Thu, 2014-02-20 at 16:21 +, Julien Grall wrote: diff --git a/Documentation/devicetree/bindings/arm/xen.txt b/Documentation/devicetree/bindings/arm/xen.txt index 0f7b9c2..ee25a57 100644 ---

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Ian Campbell
On Tue, 2014-02-11 at 13:53 -0800, Luis R. Rodriguez wrote: Cc'ing kvm folks as they may have a shared interest on the shared physical case with the bridge (non NAT). On Tue, Feb 11, 2014 at 12:43 AM, Ian Campbell ian.campb...@citrix.com wrote: On Mon, 2014-02-10 at 14:29 -0800, Luis R

Re: [PATCH net-next] xen-netback: Stop using xenvif_tx_pending_slots_available

2014-03-21 Thread Ian Campbell
On Thu, 2014-03-20 at 19:32 +, Zoltan Kiss wrote: Since the early days TX stops if there isn't enough free pending slots to consume a maximum sized (slot-wise) packet. Probably the reason for that is to avoid the case when we don't have enough free pending slot in the ring to finish the

Re: [PATCH net-next] xen-netback: Follow-up patch for grant mapping series

2014-03-21 Thread Ian Campbell
On Thu, 2014-03-20 at 19:32 +, Zoltan Kiss wrote: Ian made some late comments about the grant mapping series, I incorporated the outcomes into this patch. Additional comments, refactoring etc. I don't know how davem feels about merging these kinds of thing into one patch but from my point

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/arm: account for stolen ticks

2013-05-07 Thread Ian Campbell
@@ -301,6 +320,10 @@ static int __init xen_init_events(void) on_each_cpu(xen_percpu_init, NULL, 0); + pv_time_ops.steal_clock = xen_stolen_accounting; + static_key_slow_inc(paravirt_steal_enabled); + static_key_slow_inc(paravirt_steal_rq_enabled); We don't seem to

Re: [PATCH 2/3] xen/arm: do not handle VCPUOP_register_vcpu_info failures

2013-05-08 Thread Ian Campbell
to. */ - per_cpu(xen_vcpu, cpu) = vcpup; - } + if (err) + BUG(); AKA BUG_ON(err); Acked-by: Ian Campbell ian.campb...@citrix.com + per_cpu(xen_vcpu, cpu) = vcpup; + return 0; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [Xen-devel] [PATCH v3 4/4] xen/arm: account for stolen ticks

2013-05-09 Thread Ian Campbell
On Wed, 2013-05-08 at 18:03 +0100, Stefano Stabellini wrote: What if we have Xen support enabled but don't run as a Xen guest? That's fine as long as the Xen runstate_memory_area interface is available. Usually I am a great fun of feature flags, so that every feature can be dynamically

Re: [Xen-devel] [PATCH v3 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c

2013-05-09 Thread Ian Campbell
/ia64/xen/time.c. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: konrad.w...@oracle.com On the generic and x86 side it looks OK to me. I presume you did a sanity check on x86 to make sure nothing was off? Yep

Re: [PATCH v2 1/2] xen/balloon: Notify a host about a guest memory size limit

2013-04-29 Thread Ian Campbell
On Mon, 2013-04-29 at 12:37 +0100, Daniel Kiper wrote: Notify a host about a guest memory size limit. Idea of this patch was discussed with Ian Campbell and Ian Jackson. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- drivers/xen/balloon.c | 25 + 1

Re: [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-04-29 Thread Ian Campbell
On Mon, 2013-04-29 at 12:37 +0100, Daniel Kiper wrote: This patch enforces on target limit statically defined in Linux Kernel source and limit defined by hypervisor or host. This way the balloon driver should not attempt to populate pages above given limits because they may fail.

Re: [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-04-30 Thread Ian Campbell
On Tue, 2013-04-30 at 13:59 +0100, Daniel Kiper wrote: On Mon, Apr 29, 2013 at 03:44:09PM +0100, Ian Campbell wrote: On Mon, 2013-04-29 at 12:37 +0100, Daniel Kiper wrote: This patch enforces on target limit statically defined in Linux Kernel source and limit defined by hypervisor

Re: [Xen-devel] [PATCH 2/3] xen: move do_stolen_accounting to drivers/xen/time.c

2013-05-02 Thread Ian Campbell
On Wed, 2013-05-01 at 20:27 +0100, Stefano Stabellini wrote: Move do_stolen_accounting, xen_vcpu_stolen and related functions and static variables to common code (drivers/xen/time.c). Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb

Re: [Xen-devel] [PATCH 1/3] arm_arch_timer: introduce arch_timer_stolen_ticks

2013-05-02 Thread Ian Campbell
On Wed, 2013-05-01 at 21:36 +0100, Christopher Covington wrote: Hi Stefano, On 05/01/2013 03:27 PM, Stefano Stabellini wrote: Introduce a function, called arch_timer_stolen_ticks, called from the arch_timer interrupt handler to account for stolen ticks. [...] diff --git

Re: [Xen-devel] [PATCH 3/3] xen/arm: account for stolen ticks

2013-05-02 Thread Ian Campbell
On Wed, 2013-05-01 at 20:27 +0100, Stefano Stabellini wrote: diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index d30042e..8f040a0 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -14,6 +14,7 @@ #include xen/xen-ops.h #include asm/xen/hypervisor.h

Re: [Xen-devel] [PATCH 3/3] xen/arm: account for stolen ticks

2013-05-02 Thread Ian Campbell
On Thu, 2013-05-02 at 11:38 +0100, Stefano Stabellini wrote: On Thu, 2 May 2013, Ian Campbell wrote: On Wed, 2013-05-01 at 20:27 +0100, Stefano Stabellini wrote: diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index d30042e..8f040a0 100644 --- a/arch/arm/xen

Re: [Xen-devel] [PATCH 3/3] xen/arm: account for stolen ticks

2013-05-02 Thread Ian Campbell
On Thu, 2013-05-02 at 11:54 +0100, Stefano Stabellini wrote: On Thu, 2 May 2013, Ian Campbell wrote: On Thu, 2013-05-02 at 11:38 +0100, Stefano Stabellini wrote: On Thu, 2 May 2013, Ian Campbell wrote: On Wed, 2013-05-01 at 20:27 +0100, Stefano Stabellini wrote: diff --git a/arch

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Tue, 2013-04-30 at 19:58 +0100, Daniel Kiper wrote: On Tue, Apr 30, 2013 at 02:44:18PM +0100, Ian Campbell wrote: On Tue, 2013-04-30 at 13:59 +0100, Daniel Kiper wrote: On Mon, Apr 29, 2013 at 03:44:09PM +0100, Ian Campbell wrote: On Mon, 2013-04-29 at 12:37 +0100, Daniel Kiper wrote

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek Wilk wrote: On Thu, May 02, 2013 at 12:34:32PM +0100, Stefano Stabellini wrote: On Tue, 30 Apr 2013, Daniel Kiper wrote: +/* + * Extra internal memory reserved by libxl. + * Check tools/libxl/libxl_memory.txt file in Xen

Re: [Xen-devel] [PATCH 2/3] xen: move do_stolen_accounting to drivers/xen/time.c

2013-05-03 Thread Ian Campbell
On Thu, 2013-05-02 at 19:49 +0100, Christopher Covington wrote: Hi Stefano, On 05/01/2013 03:27 PM, Stefano Stabellini wrote: Move do_stolen_accounting, xen_vcpu_stolen and related functions and static variables to common code (drivers/xen/time.c). Signed-off-by: Stefano Stabellini

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 14:00 +0100, Daniel Kiper wrote: On Fri, May 03, 2013 at 09:15:32AM +0100, Ian Campbell wrote: On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek Wilk wrote: On Thu, May 02, 2013 at 12:34:32PM +0100, Stefano Stabellini wrote: [...] The xapi guys, CC'ed, might

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 14:47 +0100, Daniel Kiper wrote: On Fri, May 03, 2013 at 02:21:24PM +0100, Ian Campbell wrote: On Fri, 2013-05-03 at 14:00 +0100, Daniel Kiper wrote: On Fri, May 03, 2013 at 09:15:32AM +0100, Ian Campbell wrote: On Thu, 2013-05-02 at 19:04 +0100, Konrad Rzeszutek

Re: [Xen-devel] [PATCH v2 2/2] xen/balloon: Enforce various limits on target

2013-05-03 Thread Ian Campbell
On Fri, 2013-05-03 at 16:47 +0100, Daniel Kiper wrote: Do not forget that guest may change target itself. Yes it can, and that can fail either due to maxmem or due to ENOMEM, and the kernel needs prepared to deal with that when it happens. Sure but why we would like to fail

Re: [PATCH v2 1/5] arm/xen: define xen_remap as ioremap_cached

2013-06-04 Thread Ian Campbell
On Mon, 2013-06-03 at 16:33 +0100, Stefano Stabellini wrote: Define xen_remap as ioremap_cache (MT_MEMORY and MT_DEVICE_CACHED end up having the same AttrIndx encoding). The entries in static struct mem_type mem_types[] look entirely different to me. What am I missing?

Re: [PATCH v2 4/5] arm64/xen: use XEN_IO_PROTO_ABI_ARM on ARM64

2013-06-04 Thread Ian Campbell
On Mon, 2013-06-03 at 16:33 +0100, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com --- include/xen/interface/io/protocols.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH v2 2/5] arm64/xen: introduce asm/xen header files on arm64

2013-06-04 Thread Ian Campbell
different, so introduce a different file here (use xchg to implement xchg_xen_ulong and pass regs-pstate to raw_irqs_disabled_flags). Also introduce asm/hypervisor.h and asm/sync_bitops.h. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb

Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64

2013-06-05 Thread Ian Campbell
...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com [] +#define HYPERCALL_SIMPLE(hypercall) \ +ENTRY(HYPERVISOR_##hypercall)\ + mov x16, #__HYPERVISOR_##hypercall; \ + hvc XEN_IMM;\ + ret

Re: [PATCH v3 6/6] MAINTAINERS: add myself as arm64/xen maintainer

2013-06-05 Thread Ian Campbell
On Wed, 2013-06-05 at 13:15 +0100, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b

Re: [Xen-devel] [PATCH v4 5/6] arm64/xen: introduce CONFIG_XEN on ARM64

2013-06-06 Thread Ian Campbell
or not as you wish: Acked-by: Ian Campbell ian.campb...@citrix.com Ian. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [Xen-devel] [PATCH v4 5/6] arm64/xen: introduce CONFIG_XEN on ARM64

2013-06-06 Thread Ian Campbell
On Thu, 2013-06-06 at 10:27 +0100, Catalin Marinas wrote: On Thu, Jun 06, 2013 at 10:03:39AM +0100, Ian Campbell wrote: On Wed, 2013-06-05 at 18:02 +0100, Stefano Stabellini wrote: + * the second in r1/x1, the third in r2/x2 and the fourth in r3/x3. + * Considering that Xen hypercalls

[PATCH] kbuild: make sure we clean up DTB temporary files

2013-05-31 Thread Ian Campbell
Various temporary files used when building DTB files were not suffixed with .tmp and therefore were not cleaned up by make clean. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Michal Marek mma...@suse.cz Cc: Stephen Warren swar...@nvidia.com Cc: Rob Herring rob.herr...@calxeda.com Cc

[PATCH] powerpc/fsl-booke: Rename b4qds.dts - b4qds.dtsi.

2013-05-31 Thread Ian Campbell
1 make: *** [b4qds.dtb] Error 2 I spotted in build tests of device-tree.git, announcement https://lkml.org/lkml/2013/4/24/209, which builds *.dts. Probably no one would do this this in real life on linux.git but it still seems worth fixing. Signed-off-by: Ian Campbell ian.campb

DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is actually a more general issue: $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux- virtex440-ml510.dtb CC scripts/mod/devicetable-offsets.s GEN scripts/mod/devicetable-offsets.h

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 12:48 +0100, Grant Likely wrote: On Fri, 31 May 2013 11:29:30 +0100, Ian Campbell ian.campb...@citrix.com wrote: This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is actually a more general issue: $ make ARCH=powerpc CROSS_COMPILE

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: Line 374 is the IDSEL 0x16... line here: interrupt-map = /* IRQ mapping for pci slots and ALI M1533 ... * management

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: Hrm. Is this a that's not in the kernel's copy yet problem? BTW I'm using dtc.git 4e76ec796c90d44d417f82d9db2d67cfe575f8ed and not the kernel copy. dtc-lexer.l in my HEAD is identical to the current master

Re: DTB build failure due to preproccessing

2013-06-03 Thread Ian Campbell
On Fri, 2013-05-31 at 17:31 +0100, Grant Likely wrote: On Fri, May 31, 2013 at 5:04 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 05/31/2013 05:48 AM, Grant Likely wrote: --- commit d01dccdcb3ea8233b09efb9c24db9f057fbd3b37 Author: Grant Likely grant.lik...@linaro.org Date: Fri

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
this platform does not use address-cells=2. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rupjyoti Sarmah rsar...@apm.com Cc: Tirumala R Marri tma...@apm.com Cc: Josh Boyer jwbo...@linux.vnet.ibm.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org

[PATCH] powerpc/boot: Ignore .dtb files.

2013-06-03 Thread Ian Campbell
Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org --- arch/powerpc/boot/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-06-03 Thread Ian Campbell
-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Benjamin Herrenschmidt b

Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote: On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote: Currently I see: DTC arch/powerpc/boot/kilauea.dtb Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has invalid length (12 bytes) (#address-cells == 1

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Ian Campbell
-by: Ian Campbell ian.campb...@citrix.com to this change too. Reported-by: Ian Campbell ian.campb...@citrix.com Signed-off-by: Stephen Warren swar...@nvidia.com --- This is a fix for 3.10. scripts/dtc/dtc-lexer.l |2 +- scripts/dtc/dtc-lexer.lex.c_shipped | 232

Re: [Xen-devel] [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 17:25 +0100, Catalin Marinas wrote: On Mon, Jun 03, 2013 at 04:33:44PM +0100, Stefano Stabellini wrote: --- /dev/null +++ b/arch/arm64/xen/hypercall.S ... +/* + * The Xen hypercall calling convention is very similar to the ARM AEBI + * procedure calling

Re: [Xen-devel] [PATCH v6 1/4] arm: introduce psci_smp_ops

2013-04-22 Thread Ian Campbell
On Fri, 2013-04-19 at 18:06 +0100, Stefano Stabellini wrote: On Fri, 19 Apr 2013, Nicolas Pitre wrote: On Fri, 19 Apr 2013, Ian Campbell wrote: On Fri, 2013-04-19 at 16:47 +0100, Nicolas Pitre wrote: No one should be probing registers without making sure it is safe to do so

<    1   2   3   4   5   6   7   8   9   10   >