[RFC] device-tree.git automatic sync from linux.git

2013-04-24 Thread Ian Campbell
Hi, First off apologies for the large CC list -- I think this catches the arch list for all the arches with device tree source in the tree. Various folks have expressed an interest in eventually splitting the device tree bindings out of the Linux git repository into a separate tree. This should

Re: [Xen-devel] [PATCH v6 1/4] arm: introduce psci_smp_ops

2013-04-25 Thread Ian Campbell
On Mon, 2013-04-22 at 17:07 +0100, Nicolas Pitre wrote: Sure there are ways to screw up Xen support from within this hook, but that can be achieved in many other places. Will Xen take over every possible hooks in the kernel to prevent that from happening? In the majority of the other cases

Re: [PATCH v4 2/7] xen/arm: SMP support

2013-04-25 Thread Ian Campbell
On Wed, 2013-04-24 at 20:28 +0100, Stefano Stabellini wrote: Map vcpu_info using VCPUOP_register_vcpu_info on secondary cpus. Call enable_percpu_irq on every cpu. Changed in v2: - move the percpu variable argument fix to a separate patch; - remove unused variable. Signed-off-by:

Re: [PATCH v4 4/7] xen/arm: implement HYPERVISOR_vcpu_op

2013-04-25 Thread Ian Campbell
On Wed, 2013-04-24 at 20:28 +0100, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Ian Campbell ian.campb...@citrix.com --- arch/arm/include/asm/xen/hypercall.h |1 + arch/arm/xen/enlighten.c |1 + arch/arm/xen

Re: [PATCH v4 1/7] xen/arm: actually pass a non-NULL percpu pointer to request_percpu_irq

2013-04-25 Thread Ian Campbell
On Wed, 2013-04-24 at 20:28 +0100, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Ian Campbell ian.camjpb...@citrix.com CC: sta...@vger.kernel.org --- arch/arm/xen/enlighten.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH v4 2/7] xen/arm: SMP support

2013-04-25 Thread Ian Campbell
@@ -216,6 +245,8 @@ static int __init xen_guest_init(void) * is required to use VCPUOP_register_vcpu_info to place vcpu info * for secondary CPUs as they are brought up. */ per_cpu(xen_vcpu, 0) = HYPERVISOR_shared_info-vcpu_info[0]; + for_each_online_cpu(i) +

Re: [PATCH v4 2/7] xen/arm: SMP support

2013-04-26 Thread Ian Campbell
On Thu, 2013-04-25 at 19:45 +0100, Stefano Stabellini wrote: On Thu, 25 Apr 2013, Ian Campbell wrote: @@ -216,6 +245,8 @@ static int __init xen_guest_init(void) * is required to use VCPUOP_register_vcpu_info to place vcpu info * for secondary CPUs

Re: [PATCH v4 2/7] xen/arm: SMP support

2013-04-26 Thread Ian Campbell
On Fri, 2013-04-26 at 11:27 +0100, Stefano Stabellini wrote: On Fri, 26 Apr 2013, Ian Campbell wrote: On Thu, 2013-04-25 at 19:45 +0100, Stefano Stabellini wrote: On Thu, 25 Apr 2013, Ian Campbell wrote: @@ -216,6 +245,8 @@ static int __init xen_guest_init(void

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-11-01 Thread Ian Campbell
On Wed, 2013-10-30 at 00:50 +, Zoltan Kiss wrote: This patch series use SKBTX_DEV_ZEROCOPY flags to tell the stack it needs to know when the skb is freed up. Does this always avoid copying when bridging/openvswitching/forwarding (e.g. masquerading etc)? For both domU-domU and domU-physical

Re: [Xen-devel] [PATCH v3] p2m: use GNTTABOP_unmap_and_duplicate if available

2013-11-04 Thread Ian Campbell
On Mon, 2013-11-04 at 16:38 +0100, Roger Pau Monne wrote: The new GNTTABOP_unmap_and_duplicate operation I don't see this op in mainline Xen anywhere... Was it part of Stefano's original swiotlb for ARM stuff? If so we've dropped that approach for ARM and the new solution doesn't require

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Mon, 2013-10-21 at 20:57 +0200, Daniel Kiper wrote: On Mon, Oct 21, 2013 at 09:54:38AM -0400, Peter Jones wrote: On Mon, Oct 21, 2013 at 02:57:56PM +0200, Daniel Kiper wrote: Hi, During work on multiboot2 protocol support for Xen it was discovered that memory map passed via

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 10:31 +0100, Jan Beulich wrote: On 22.10.13 at 11:26, Ian Campbell ian.campb...@citrix.com wrote: AIUI efilinux is somewhat badly named and does not use the Linux Boot Protocol (i.e. the (b)zImage stuff with real mode entry point) either. It actually loads

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 09:42 -0400, Konrad Rzeszutek Wilk wrote: Looking at the Fedora GRUB2 source, the 'struct linux_kernel_header' is defined in the linux/Documentation/x86/boot.txt and hpa is pretty strict about making it backwards compatible. It also seems to support Xen!

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 10:09 -0400, Konrad Rzeszutek Wilk wrote: So it can be booted the same way as xen.efi. But my understanding is that folks prefer a bootloader instead of loading the bzImage in an NVRAM of a platform with pre-set parameters. Hence that mechanism is not used by the

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 10:57 -0400, Konrad Rzeszutek Wilk wrote: That 'that' is a standard PE/COFF image? Could you please point me to the code that does that in GRUB2? As I said earlier in the thread, it's a patch which is being carried by all the distros. It is not in upstream grub. For

Re: [Xen-devel] EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 15:24 +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 10:09 -0400, Konrad Rzeszutek Wilk wrote: So it can be booted the same way as xen.efi. But my understanding is that folks prefer a bootloader instead of loading the bzImage in an NVRAM of a platform with pre-set

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 14:18 +, Woodhouse, David wrote: I wonder why Linux can't make the EFI calls to fetch them itself? It can. It does. It prefers to. This is what the EFI boot stub is all about. Good, this is what I thought, glad to see I'm not talking out my behind for once!

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 18:01 +0200, Daniel Kiper wrote: On Tue, Oct 22, 2013 at 03:42:42PM +, Woodhouse, David wrote: On Tue, 2013-10-22 at 16:32 +0100, Matthew Garrett wrote: There are two problems with this: 1) The kernel will only boot if it's signed with a key in db, not a

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 12:24 -0400, Konrad Rzeszutek Wilk wrote: On Tue, Oct 22, 2013 at 04:21:47PM +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 10:57 -0400, Konrad Rzeszutek Wilk wrote: That 'that' is a standard PE/COFF image? Could you please point me to the code that does

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Ian Campbell
On Tue, 2013-10-22 at 18:25 +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 22.10.2013 18:14, Daniel Kiper wrote: Are you (going to be) in Edinburgh? Matthew was just explaining a bunch of this stuff to me, it might be useful for you to get it from the horses mouth instead of

Re: [Xen-devel] EFI and multiboot2 devlopment work for Xen

2013-10-23 Thread Ian Campbell
On Tue, 2013-10-22 at 12:26 -0400, Konrad Rzeszutek Wilk wrote: It can (at least in Linux). There are two entry points in the Linux kernel and - one when it is launched from 'linuxefi' (See efi_stub_entry in arch/x86/boot/compressed/head_64.S), the other when it is launched from an EFI shell

Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.

2013-10-24 Thread Ian Campbell
On Thu, 2013-10-24 at 17:30 +0100, Julien Grall wrote: I'm sure the solution move xen call earlier will come up in few mails, so there was a discussion for swiotlb few weeks ago (https://lkml.org/lkml/2013/8/29/609). And the final decision was to avoid specific Xen call in arch_setup. It

Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.

2013-10-26 Thread Ian Campbell
On Fri, 2013-10-25 at 15:38 -0400, Konrad Rzeszutek Wilk wrote: On Thu, Oct 24, 2013 at 05:43:54PM +0100, Ian Campbell wrote: But stepping back how/why is this function called on x86 when not running under Xen? Wouldn't the use have to be using console=hvc or earlyprintk=xen or something

Re: [RFC] device-tree.git automatic sync from linux.git

2013-05-13 Thread Ian Campbell
On Mon, 2013-05-13 at 08:02 +0100, Michal Simek wrote: Just small overview it is a Xilinx soft core cpu where you can even setup some parameters for core itself - multiplier, divider, BS, fpu, cache sizes, etc. You have to also compose the whole system and every platform/configuration is

Re: [Xen-devel] [PATCH-v2] xen: Don't call arch_trigger_all_cpu_backtrace in dom0(pvm)

2013-05-15 Thread Ian Campbell
On Wed, 2013-05-15 at 16:40 +0800, Zhenzhong Duan wrote: On 2013-04-10 00:36, Ian Campbell wrote: On Mon, 2013-04-08 at 08:42 +0100, Jan Beulich wrote: On 07.04.13 at 07:54, Zhenzhong Duan zhenzhong.d...@oracle.com wrote: nmi isn't supported in dom0, fallback to general all cpu backtrace

Re: [Xen-devel] [PATCH] net/core: Order-3 frag allocator causes SWIOTLB bouncing under Xen

2013-09-05 Thread Ian Campbell
On Wed, 2013-09-04 at 17:11 -0400, Konrad Rzeszutek Wilk wrote: On Wed, Sep 04, 2013 at 02:00:40PM -0700, Eric Dumazet wrote: Maybe you could add proper infrastructure to deal with Xen limitations. I think Ian posted at some point an sysctl patch for that (more for debugging that anything

Re: [PATCH v5 05/13] xen/arm,arm64: move Xen initialization earlier

2013-09-06 Thread Ian Campbell
On Thu, 2013-09-05 at 17:59 +0100, Stefano Stabellini wrote: On Thu, 5 Sep 2013, Catalin Marinas wrote: On Thu, Aug 29, 2013 at 07:32:26PM +0100, Stefano Stabellini wrote: Move Xen initialization earlier, before any DMA requests can be made. Signed-off-by: Stefano Stabellini

Re: [PATCH v4 10/10] xen/arm,arm64: enable SWIOTLB_XEN

2013-08-29 Thread Ian Campbell
On Wed, 2013-08-28 at 21:07 +0100, Stefano Stabellini wrote: On Thu, 15 Aug 2013, Ian Campbell wrote: On Thu, 2013-08-15 at 12:10 +0100, Stefano Stabellini wrote: At the moment always rely on swiotlb-xen, but when Xen starts supporting hardware IOMMUs we'll be able to avoid

[PATCH] MAINTAINERS: change my DT related maintainer address

2013-08-30 Thread Ian Campbell
o...@lixom.net Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Ian Campbell ian.campb...@citrix.com --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8197fbd..b140c81 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH] pinctrl: am33xx dt binding: correct include path

2013-07-03 Thread Ian Campbell
Using #include include/... is a bit odd. It happens to work because the DTC flags include -Iarch/FOO/boot/dts as well as arch/FOO/boot/dts/include and arch/FOO/boot/dts/include/dt-bindings is a symlink to include/dt-bindings. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Grant Likely

Re: [Xen-devel] [PATCH RFC] xen/arm: domain kernel: Small fixes for making suspendable for arm

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 16:59 +0100, Stefano Stabellini wrote: diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2c3bdce..77309f7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1469,6 +1469,9 @@ config ARCH_NO_VIRT_TO_BUS config ISA_DMA_API bool +config

Re: kernel panic in skb_copy_bits

2013-07-04 Thread Ian Campbell
On Thu, 2013-07-04 at 16:55 +0800, Joe Jin wrote: On 07/01/13 16:11, Ian Campbell wrote: On Mon, 2013-07-01 at 11:18 +0800, Joe Jin wrote: A workaround is to turn off O_DIRECT use by Xen as that ensures the pages are copied. Xen 4.3 does this by default. I believe fixes

Re: kernel panic in skb_copy_bits

2013-07-04 Thread Ian Campbell
On Thu, 2013-07-04 at 02:34 -0700, Eric Dumazet wrote: On Thu, 2013-07-04 at 09:59 +0100, Ian Campbell wrote: On Thu, 2013-07-04 at 16:55 +0800, Joe Jin wrote: Another way is add new page flag like PG_send, when sendpage() be called, set the bit, when page be put, clear the bit

Re: [linux-sunxi] [PATCH V3: Add Smp support for Allwinner A20. 1/3] Add smp support for Allwinner A20(sunxi 7i).

2013-09-22 Thread Ian Campbell
On Sun, 2013-09-22 at 20:21 +0800, Fan Rong wrote: + /* Set boot addr */ + paddr = virt_to_phys(sun7i_secondary_startup); + writel(paddr, sunxi7i_cc_base + SUN7I_CPUCFG_BOOTADDR); This means that the secondary cores will miss out on any setup which the bootloader might have done

Re: [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i).

2013-09-23 Thread Ian Campbell
On Sun, 2013-09-22 at 23:31 +0800, cinifr wrote: On Sunday, 22 September 2013, Ian Campbell i...@hellion.org.uk wrote: On Sun, 2013-09-22 at 20:21 +0800, Fan Rong wrote: + /* Set boot addr */ + paddr = virt_to_phys(sun7i_secondary_startup); + writel(paddr

Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-09-24 Thread Ian Campbell
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote: On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote: Currently I see: DTC arch/powerpc/boot/kilauea.dtb Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has invalid length (12 bytes) (#address-cells == 1

Re: [PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-09-24 Thread Ian Campbell
On Mon, 2013-06-03 at 12:00 +0100, Ian Campbell wrote: This fixes a warning: DTC arch/powerpc/boot/virtex440-ml507.dtb Warning (reg_format): reg property in /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1

Re: [PATCH v3 1/2] xen/balloon: set a mapping for ballooned out pages

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 18:27 +0100, Stefano Stabellini wrote: +static int __cpuinit balloon_cpu_notify(struct notifier_block *self, + unsigned long action, void *hcpu) +{ + int cpu = (long)hcpu; + switch (action) { + case CPU_UP_PREPARE: +

Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 10:59 -0700, Stephen Warren wrote: I think the solution is to introduce some new shared/common location for shared/common *.dtsi files, into the kernel tree, in the interim. When *.dts move out of the kernel, this common location can simply be consumed as part of the

Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-23 Thread Ian Campbell
On Tue, 2013-07-23 at 13:44 -0500, Rob Herring wrote: On 07/23/2013 01:09 PM, Ian Campbell wrote: On Tue, 2013-07-23 at 10:59 -0700, Stephen Warren wrote: I think the solution is to introduce some new shared/common location for shared/common *.dtsi files, into the kernel tree

Re: [PATCH 3/3] x86, platform, kconfig: add virtconfig defconfig helper

2014-06-10 Thread Ian Campbell
On Mon, 2014-06-09 at 19:15 +0200, Luis R. Rodriguez wrote: On Sat, Jun 07, 2014 at 11:04:30AM +0200, Borislav Petkov wrote: On Fri, Jun 06, 2014 at 04:11:09PM -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com This lets you use: make virtconfig

Re: [PATCH 3/3] x86, platform, kconfig: add virtconfig defconfig helper

2014-06-10 Thread Ian Campbell
On Tue, 2014-06-10 at 11:01 +0200, Borislav Petkov wrote: On Tue, Jun 10, 2014 at 09:35:39AM +0100, Ian Campbell wrote: Actually what I meant was to *replace* kvmconfig with virtconfig and then add the Xen stuff to it, i.e. to have a single thing to maintain for all virt platforms, rather

Re: [PATCH] arm: document mach-virt platform.

2014-02-03 Thread Ian Campbell
On Sun, 2014-02-02 at 20:56 -0800, Christoffer Dall wrote: On Thu, Jan 30, 2014 at 11:54:46AM -0500, Christopher Covington wrote: Hi Ian, On 01/30/2014 11:11 AM, Ian Campbell wrote: mach-virt has existed for a while but it is not written down what it actually consists

Re: [PATCH] ARM: orion: provide C-style interrupt handler for MULTI_IRQ_HANDLER

2014-01-20 Thread Ian Campbell
On Thu, 2014-01-16 at 13:49 -0500, Jason Cooper wrote: @Ian: Thanks for hunting this down, please keep bothering us with bug reports :) Yes, please! No worries there -- it seem Debian has quite a few people who use kirkwood based systems and will report bugs when they find them... Thanks

Re: [Xen-devel] [PATCH v4] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-22 Thread Ian Campbell
- implement sync_cmpxchg using __cmpxchg8 and __cmpxchg16 Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Ian Campbell
is torn down. This may well be the explanation for the memory leak I was observing on ARM last night. I'll give it a go and let you know. Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Roger Pau Monné roger@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: David Vrabel david.vra

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Ian Campbell
On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote: On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: From: Matt Rushton mrush...@amazon.com Currently shrink_free_pagepool() is called before the pages used for persistent grants are released via free_persistent_gnts

Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call

2014-01-06 Thread Ian Campbell
On Thu, 2014-01-02 at 13:53 +, David Vrabel wrote: On 19/12/13 15:03, Levente Kurusa wrote: This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa le...@linux.com --- drivers/xen/xenbus/xenbus_probe.c | 4 +++- 1 file changed, 3

Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call

2014-01-06 Thread Ian Campbell
On Mon, 2014-01-06 at 11:00 +, David Vrabel wrote: On 06/01/14 10:00, Ian Campbell wrote: On Thu, 2014-01-02 at 13:53 +, David Vrabel wrote: On 19/12/13 15:03, Levente Kurusa wrote: This is required so that we give up the last reference to the device. Signed-off-by: Levente

Re: [PATCH v8 3/6] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2014-01-09 Thread Ian Campbell
for stolen ticks accounting. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Christopher Covington c...@codeaurora.org Acked-by: Ian Campbell ian.campb...@citrix.com CC: li...@arm.linux.org.uk CC: will.dea...@arm.com CC: n...@linaro.org CC: marc.zyng...@arm.com CC

Re: [PATCH v8 4/6] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2014-01-09 Thread Ian Campbell
On Thu, 2014-01-09 at 12:13 +, Catalin Marinas wrote: On Wed, Jan 08, 2014 at 06:49:56PM +, Stefano Stabellini wrote: arch/arm64/Kconfig | 20 arch/arm64/kernel/Makefile |1 + 2 files changed, 21 insertions(+) [...] diff --git

Re: [PATCH] ARM: orion: provide C-style interrupt handler for MULTI_IRQ_HANDLER

2014-01-16 Thread Ian Campbell
...@gmail.com Tested-by: Ian Campbell i...@hellion.org.uk Reported-by: Ian Campbell i...@hellion.org.uk Fixes: 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) Fixes: f07d73e33d0e (ARM: dove: convert to DT irqchip and clocksource) --- Compared to the two patch version sent

Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-12-16 Thread Ian Campbell
On Thu, 2013-12-12 at 22:08 +, Zoltan Kiss wrote: On 28/11/13 17:43, Ian Campbell wrote: On Thu, 2013-11-28 at 17:37 +, Zoltan Kiss wrote: Routing/firewalling domUs is as valid as bridging. There is nothing in the slightest bit suboptimal about it. If this use case regresses

Re: [PATCH v2 9/9] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c

2013-12-16 Thread Ian Campbell
: warning: no previous prototype for ‘xenvif_count_frag_slots’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org Acked-by: Ian Campbell ian.campb...@citrix.com --- This revision fixes the following issues

Re: [Xen-devel] [PATCH] allow xenfb initialization for hvm guests

2013-12-18 Thread Ian Campbell
, they are not affected. and if a toolstack did I think it would be reasonable to expect the kernel to at least try and drive it! Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux

Re: [Xen-devel] [PATCH v11 02/12] xen/pvh: Define what an PVH guest is.

2013-12-18 Thread Ian Campbell
On Wed, 2013-12-18 at 14:55 +, Stefano Stabellini wrote: On Wed, 18 Dec 2013, Stefano Stabellini wrote: On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: From: Mukesh Rathor mukesh.rat...@oracle.com Which is a PV guest with auto page translation enabled and with vector

Re: [Xen-devel] [PATCH v11 02/12] xen/pvh: Define what an PVH guest is.

2013-12-18 Thread Ian Campbell
On Wed, 2013-12-18 at 11:58 -0500, Konrad Rzeszutek Wilk wrote: On Wed, Dec 18, 2013 at 04:01:03PM +, Ian Campbell wrote: On Wed, 2013-12-18 at 14:55 +, Stefano Stabellini wrote: On Wed, 18 Dec 2013, Stefano Stabellini wrote: On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-27 Thread Ian Campbell
On Sat, 2014-01-25 at 13:07 -0800, Matt Wilson wrote: On Fri, Jan 24, 2014 at 03:36:22PM +, Ian Campbell wrote: On Fri, 2014-01-24 at 09:21 +, Ian Campbell wrote: On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: From: Matt Rushton mrush...@amazon.com Currently

Re: [PATCH] xen/gnttab: Use phys_addr_t to describe the grant frame base address

2014-01-28 Thread Ian Campbell
julien.gr...@linaro.org Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH REPOST] of: Add vendor prefix for Xen hypervisor

2014-01-29 Thread Ian Campbell
I suppose vendors of virtual hardware ought to be listed here as well. Signed-off-by: Ian Campbell ian.campb...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc

[PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
. I've done my best to capture the requirements based on the git log and my memory/understanding. While here remove the xenvm dts example, the Xen tools will now build a suitable mach-virt compatible dts when launching the guest. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 11:54 -0500, Christopher Covington wrote: +++ b/Documentation/devicetree/bindings/arm/mach-virt.txt @@ -0,0 +1,32 @@ +* Mach-virt Dummy Virtual Machine platform + +mach-virt is the smallest, dumbest platform possible, to be used as +a guest for Xen, KVM and other

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 17:13 +, Marc Zyngier wrote: Hi Ian, On 30/01/14 16:11, Ian Campbell wrote: mach-virt has existed for a while but it is not written down what it actually consists of. Although it seems a bit unusual to document a binding for an entire platform since mach-virt

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 17:24 +, Marc Zyngier wrote: I'm afraid I disagree with most of the above. The whole point of mach-virt is to provide a shell for DT platforms. None of this hardware is mandated. Instead, all the necessary information should be described in DT. Add support

Re: [PATCH] arm: document mach-virt platform.

2014-01-30 Thread Ian Campbell
On Thu, 2014-01-30 at 18:28 +0100, Arnd Bergmann wrote: On Thursday 30 January 2014, Ian Campbell wrote: mach-virt has existed for a while but it is not written down what it actually consists of. Although it seems a bit unusual to document a binding for an entire platform since mach-virt

Re: [Xen-devel] [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64

2013-12-12 Thread Ian Campbell
On Tue, 2013-12-03 at 15:40 +, Julien Grall wrote: On ARM (32 bits and 64 bits), the double-word is 8-bytes aligned. This will result on different structure from Xen and Linux repositories. As Linux is using __packed__ attribute, it must have a 4-bytes padding before each id field.

Re: [PATCH] xen/arm64: do not call the swiotlb functions twice

2013-12-09 Thread Ian Campbell
Stabellini stefano.stabell...@eu.citrix.com CC: catalin.mari...@arm.com CC: will.dea...@arm.com Tested-by: Ian Campbell ian.campb...@citrix.com Ian. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH net-next] Revert xen-netback: Aggregate TX unmap operations

2014-03-24 Thread Ian Campbell
effect, whilst with certain frontends it causes significant performance regression. That's a shame -- do you have any insight into why? Signed-off-by: Zoltan Kiss zoltan.k...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line

Re: [PATCH net-next] xen-netback: Follow-up patch for grant mapping series

2014-03-24 Thread Ian Campbell
On Fri, 2014-03-21 at 19:31 +, Zoltan Kiss wrote: On 21/03/14 09:41, Ian Campbell wrote: On Thu, 2014-03-20 at 19:32 +, Zoltan Kiss wrote: Ian made some late comments about the grant mapping series, I incorporated the outcomes into this patch. Additional comments, refactoring etc

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread Ian Campbell
On Wed, 2014-03-26 at 12:56 +0900, SeongJae Park wrote: Fix following trivial build warning: drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’: drivers/net/xen-netback/netback.c:1585:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has

Re: [PATCH net-next] xen-netback: Grant copy the header instead of map and memcpy

2014-03-27 Thread Ian Campbell
On Wed, 2014-03-26 at 21:18 +, Zoltan Kiss wrote: An old inefficiency of the TX path that we are grant mapping the first slot, and then copy the header part to the linear area. Instead, doing a grant copy for that header straight on is more reasonable. Especially because there are ongoing

Re: [PATCH net-next] xen-netback: Grant copy the header instead of map and memcpy

2014-03-27 Thread Ian Campbell
On Thu, 2014-03-27 at 12:46 +, Zoltan Kiss wrote: On 27/03/14 11:35, Ian Campbell wrote: On Wed, 2014-03-26 at 21:18 +, Zoltan Kiss wrote: An old inefficiency of the TX path that we are grant mapping the first slot, and then copy the header part to the linear area. Instead, doing

Re: [Xen-devel] [PATCH] grant-table, xen-netback: Introduce helper functions for grant copy operations

2014-04-04 Thread Ian Campbell
On Thu, 2014-04-03 at 10:48 +0100, David Vrabel wrote: On 03/04/14 09:12, Paul Durrant wrote: Zoltan Kiss wrote: Create helper functions for grant copy operations and use them in netback. [...] --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@

Re: [Xen-devel] [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating.

2014-04-09 Thread Ian Campbell
On Tue, 2014-04-08 at 14:53 -0400, Konrad Rzeszutek Wilk wrote: On Tue, Apr 08, 2014 at 08:18:48PM +0200, Roger Pau Monné wrote: On 08/04/14 19:25, kon...@kernel.org wrote: From: Konrad Rzeszutek Wilk konrad.w...@oracle.com When we migrate an HVM guest, by default our shared_info can

Re: [Xen-devel] [PATCH] drivers: net: xen-netfront: remove unused arrays

2014-04-16 Thread Ian Campbell
On Tue, 2014-04-15 at 18:54 +0100, David Vrabel wrote: On 15/04/14 18:39, Vincenzo Maffione wrote: This patch removes some unused arrays from the netfront private data structure. Also removes an unused address variable. Signed-off-by: Vincenzo Maffione v.maffi...@gmail.com Huh. I

Re: [PATCH net-next v2 1/2] xen-netback: Rename map ops

2014-04-01 Thread Ian Campbell
On Mon, 2014-03-31 at 16:08 +0100, Zoltan Kiss wrote: Rename identifiers to state explicitly that they refer to map ops. Signed-off-by: Zoltan Kiss zoltan.k...@citrix.com On the understanding that this is a pure rename: Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from

Re: [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy

2014-04-01 Thread Ian Campbell
On Mon, 2014-03-31 at 16:08 +0100, Zoltan Kiss wrote: check_frags: - for (i = start; i nr_frags; i++) { + for (i = 0; i nr_frags; i++, gop_map++) { int j, newerr; pending_idx = frag_get_pending_idx(shinfo-frags[i]); - tx_info =

Re: [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy

2014-04-02 Thread Ian Campbell
On Tue, 2014-04-01 at 19:55 +0100, Zoltan Kiss wrote: @@ -1389,7 +1393,7 @@ static int xenvif_tx_submit(struct xenvif *vif) txp = vif-pending_tx_info[pending_idx].req; /* Check the remap error code. */ -if (unlikely(xenvif_tx_check_gop(vif, skb,

Re: [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy

2014-04-02 Thread Ian Campbell
On Tue, 2014-04-01 at 20:09 +0100, Zoltan Kiss wrote: On 01/04/14 12:40, Ian Campbell wrote: On Mon, 2014-03-31 at 16:08 +0100, Zoltan Kiss wrote: check_frags: - for (i = start; i nr_frags; i++) { + for (i = 0; i nr_frags; i++, gop_map++) { int j, newerr

Re: [Xen-devel] [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy

2014-04-02 Thread Ian Campbell
On Wed, 2014-04-02 at 14:11 +0100, David Vrabel wrote: I'd be in favour of a patch that: - renamed gnttab_map_refs() to gnttab_batch_map_pages() - refactored it to call gnttab_batch_map(). - added documentation But I don't see why this would be a prerequisite for this series. No, I

Re: [PATCH net-next v3 1/2] xen-netback: Rename map ops

2014-04-03 Thread Ian Campbell
On Wed, 2014-04-02 at 18:04 +0100, Zoltan Kiss wrote: Rename identifiers to state explicitly that they refer to map ops. Signed-off-by: Zoltan Kiss zoltan.k...@citrix.com --- v3: - rename xenvif_tx_create_gop to xenvif_tx_create_map_op You can retain my ack from v2. -- To unsubscribe

Re: [PATCH net-next v3 2/2] xen-netback: Grant copy the header instead of map and memcpy

2014-04-03 Thread Ian Campbell
On Thu, 2014-04-03 at 09:07 +0100, Paul Durrant wrote: -Original Message- From: Zoltan Kiss Sent: 02 April 2014 18:05 To: Ian Campbell; Wei Liu; xen-de...@lists.xenproject.org Cc: Paul Durrant; net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jonathan Davies; Zoltan Kiss

Re: [PATCH next] xen: Use more current logging styles

2013-06-28 Thread Ian Campbell
-by: Joe Perches j...@perches.com Acked-by: Ian Campbell ian.campb...@citrix.com --- drivers/net/xen-netback/netback.c | 7 +++ drivers/net/xen-netfront.c| 28 +--- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/net/xen-netback

Re: [PATCH next] xen: Convert printks to pr_level

2013-06-28 Thread Ian Campbell
On Fri, 2013-06-28 at 03:21 -0700, Joe Perches wrote: Convert printks to pr_level (excludes printk(KERN_DEBUG...) to be more consistent throughout the xen subsystem. Add pr_fmt with KBUILD_MODNAME or xen: KBUILD_MODNAME Coalesce formats and add missing word spaces Add missing newlines

Re: kernel panic in skb_copy_bits

2013-07-01 Thread Ian Campbell
On Mon, 2013-07-01 at 11:18 +0800, Joe Jin wrote: A workaround is to turn off O_DIRECT use by Xen as that ensures the pages are copied. Xen 4.3 does this by default. I believe fixes for this are in 4.3 and 4.2.2 if using the qemu upstream DM. Note these aren't real fixes, just a

Re: [PATCH v7 15/33] net: xen-netback - set name assign type

2014-07-10 Thread Ian Campbell
On Thu, 2014-07-10 at 10:17 +0200, Tom Gundersen wrote: The name contains then xen handle, which is not guaranteed to be stable between restarts, so label this NET_NAME_ENUM. FWIW the N'th interface for domain with domid D will always be named vifD.N. If you reboot domain D then it's domid

Re: [PATCH v7 15/33] net: xen-netback - set name assign type

2014-07-10 Thread Ian Campbell
On Thu, 2014-07-10 at 12:46 +0200, Tom Gundersen wrote: On Thu, Jul 10, 2014 at 11:01 AM, Ian Campbell ian.campb...@citrix.com wrote: On Thu, 2014-07-10 at 10:17 +0200, Tom Gundersen wrote: The name contains then xen handle, which is not guaranteed to be stable between restarts, so label

Re: [RFC PATCH 3/9] irqchip: GIC: Convert to EOImode == 1

2014-06-25 Thread Ian Campbell
On Wed, 2014-06-25 at 19:26 +0530, Anup Patel wrote: Ian had send-out a patch long time back to extend GIC dt-bindings for addressing this issue. (http://www.spinics.net/lists/arm-kernel/msg283767.html) I've been meaning to revisit this. Since that original patch I've been wondering if some

Re: [RFC PATCH 3/9] irqchip: GIC: Convert to EOImode == 1

2014-06-25 Thread Ian Campbell
On Wed, 2014-06-25 at 15:24 +0100, Marc Zyngier wrote: Ian had send-out a patch long time back to extend GIC dt-bindings for addressing this issue. (http://www.spinics.net/lists/arm-kernel/msg283767.html) Wow. That's really horrible. Blimey! Ian, you owe me a few beers, just so I can

Re: [PATCH net-next] xen-netback: Adding debugfs io_ring_qX files

2014-07-02 Thread Ian Campbell
On Mon, 2014-06-30 at 21:33 +0100, Zoltan Kiss wrote: This patch adds debugfs capabilities to netback. There used to be a similar patch floating around for classic kernel, but it used procfs. It is based on a very similar blkback patch. It creates xen-netback/[vifname]/io_ring_q[queueno]

Re: [PATCH net-next] xen-netback: Adding debugfs io_ring_qX files

2014-07-02 Thread Ian Campbell
On Wed, 2014-07-02 at 19:43 +0100, Zoltan Kiss wrote: On 02/07/14 11:56, Ian Campbell wrote: On Mon, 2014-06-30 at 21:33 +0100, Zoltan Kiss wrote: This patch adds debugfs capabilities to netback. There used to be a similar patch floating around for classic kernel, but it used procfs

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

2014-08-20 Thread Ian Campbell
On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote: The rest of the Xen device drivers use an module alias to load devices when they shop up in XenBus. show. MODULE_LICENSE(Dual BSD/GPL); MODULE_ALIAS(xen-backend:pci); +MODULE_ALIAS(xen:pci); Isn't that xen-backend:pci

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

2014-08-20 Thread Ian Campbell
On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote: On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote: On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote: The rest of the Xen device drivers use an module alias to load devices when they shop up in XenBus

Re: [PATCH v5 2/6] xen/arm: remove outer_*_range call

2014-10-24 Thread Ian Campbell
On Thu, 2014-10-23 at 18:27 +0100, Stefano Stabellini wrote: Dom0 is not actually capable of issuing outer_inv_range or outer_clean_range calls. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from

Re: [PATCH v5 3/6] xen/arm: introduce xen_is_dma_coherent

2014-10-24 Thread Ian Campbell
to know that arm_coherent_dma_ops is the only possible one which doesn't set the hooks you were checking before. Either way this should be mentioned in the commit log. With that done: Acked-by: Ian Campbell ian.campb...@citrix.com --- Changes in v5: - introduce xen_is_dma_coherent as a xen

Re: [PATCH v5 4/6] xen/arm/arm64: merge xen/mm32.c into xen/mm.c

2014-10-24 Thread Ian Campbell
from the xen_dma wrappers in page-coherent.h to handle non-coherent devices. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v5 5/6] xen/arm/arm64: introduce xen_arch_need_swiotlb

2014-10-24 Thread Ian Campbell
you added. Looks like you have ts=4 or something. The actual changes look ok though, so with the coding style fixed you can add: Acked-by: Ian Campbell ian.campb...@citrix.com --- Changes in v5: - fix indentation. --- arch/arm/include/asm/xen/page.h |4 arch/arm/xen/mm.c

Re: [PATCH v4 3/7] [RFC] arm/arm64: introduce is_dma_coherent

2014-10-25 Thread Ian Campbell
On Sat, 2014-10-25 at 14:29 +0100, Stefano Stabellini wrote: Your suggestions and looking more at the code gave me another idea, that I think is clean and at the same time suitable for 3.18. What do you think of the following? It is simple, self-contained and doesn't need a new flag in

Re: [PATCH v4 1/7] xen/arm: remove handling of XENFEAT_grant_map_identity

2014-10-20 Thread Ian Campbell
On Fri, 2014-10-10 at 12:51 +0100, Stefano Stabellini wrote: The feature has been removed from Xen. Also Linux cannot use it on ARM32 without CONFIG_ARM_LPAE. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Acked-by: Ian

Re: [PATCH v4 4/7] xen/arm: use is_dma_coherent

2014-10-20 Thread Ian Campbell
...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

<    1   2   3   4   5   6   7   8   9   10   >