Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-05 Thread Inki Dae
es valid for both > the boards? We don't need to consider tm2e board with two reasones, 1. there is no tm2e board support in mainline 2. the panel on tm2 would be a little bit different from one on tm2e Thanks, Inki Dae > > Andi > >

Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-04 Thread Inki Dae
2017년 01월 05일 15:55에 Andrzej Hajda 이(가) 쓴 글: > On 04.01.2017 15:44, Rob Herring wrote: >> On Wed, Jan 04, 2017 at 05:15:10PM +0900, Hoegeun Kwon wrote: >>> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel >>> driver. This panel has 1440x2560 resolution in 5.7-inch physical >>>

Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-04 Thread Inki Dae
2017년 01월 05일 15:55에 Andrzej Hajda 이(가) 쓴 글: > On 04.01.2017 15:44, Rob Herring wrote: >> On Wed, Jan 04, 2017 at 05:15:10PM +0900, Hoegeun Kwon wrote: >>> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel >>> driver. This panel has 1440x2560 resolution in 5.7-inch physical >>>

Re: [PATCH v4 1/3] drm/exynos: mic: Add mode_set callback function

2017-01-03 Thread Inki Dae
2017년 01월 04일 15:58에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get videomode struct through

Re: [PATCH v4 1/3] drm/exynos: mic: Add mode_set callback function

2017-01-03 Thread Inki Dae
2017년 01월 04일 15:58에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get videomode struct through

Re: [PATCH v2] dma-buf: Wait on the reservation object when sync'ing before CPU access

2016-12-18 Thread Inki Dae
2016년 08월 16일 01:02에 Daniel Vetter 이(가) 쓴 글: > On Mon, Aug 15, 2016 at 04:42:18PM +0100, Chris Wilson wrote: >> Rendering operations to the dma-buf are tracked implicitly via the >> reservation_object (dmabuf->resv). This is used to allow poll() to >> wait upon outstanding rendering (or just

Re: [PATCH v2] dma-buf: Wait on the reservation object when sync'ing before CPU access

2016-12-18 Thread Inki Dae
2016년 08월 16일 01:02에 Daniel Vetter 이(가) 쓴 글: > On Mon, Aug 15, 2016 at 04:42:18PM +0100, Chris Wilson wrote: >> Rendering operations to the dma-buf are tracked implicitly via the >> reservation_object (dmabuf->resv). This is used to allow poll() to >> wait upon outstanding rendering (or just

Re: [PATCH] exynos-drm: Fix error messages to print flags and size

2016-10-19 Thread Inki Dae
2016-10-06 22:09 GMT+09:00 Tobias Jakobi <tjak...@math.uni-bielefeld.de>: > Hello, > > I think this patch was never picked up. So just a short 'ping' from my side. > Oops. one I missed. Will pick it up soon. Thanks, Inki Dae > With best wishes, > Tobias > &

Re: [PATCH] exynos-drm: Fix error messages to print flags and size

2016-10-19 Thread Inki Dae
2016-10-06 22:09 GMT+09:00 Tobias Jakobi : > Hello, > > I think this patch was never picked up. So just a short 'ping' from my side. > Oops. one I missed. Will pick it up soon. Thanks, Inki Dae > With best wishes, > Tobias > > > Shuah Khan wrote: >> Fix exyno

Re: [PATCH V2] gpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

2016-10-19 Thread Inki Dae
Will pick it up soon. Thanks, Inki Dae 2016-10-19 19:04 GMT+09:00 Arvind Yadav <arvind.yadav...@gmail.com>: > Free memory mapping, if hdmi_probe is not successful. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> > --- > drivers/gpu/drm/exynos/exynos_hd

Re: [PATCH V2] gpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

2016-10-19 Thread Inki Dae
Will pick it up soon. Thanks, Inki Dae 2016-10-19 19:04 GMT+09:00 Arvind Yadav : > Free memory mapping, if hdmi_probe is not successful. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/exynos/exynos_hdmi.c |5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-19 Thread Inki Dae
Hi Shuah, 2016-10-13 8:11 GMT+09:00 Shuah Khan <shua...@osg.samsung.com>: > Hi Inki, > > On 08/15/2016 10:40 PM, Inki Dae wrote: > >>> >>> okay the very first commit that added IOMMU support >>> introduced the code that rejects non-contig gem

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-19 Thread Inki Dae
Hi Shuah, 2016-10-13 8:11 GMT+09:00 Shuah Khan : > Hi Inki, > > On 08/15/2016 10:40 PM, Inki Dae wrote: > >>> >>> okay the very first commit that added IOMMU support >>> introduced the code that rejects non-contig gem memory

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-15 Thread Inki Dae
Hi Shuah, 2016년 08월 13일 02:52에 Shuah Khan 이(가) 쓴 글: > On 08/12/2016 11:28 AM, Shuah Khan wrote: >> On 08/10/2016 05:05 PM, Shuah Khan wrote: >>> On 08/10/2016 04:59 PM, Inki Dae wrote: >>>> Hi Shuah, >>>> >>>> 2016년 08월 11일 02:30에 Shua

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-15 Thread Inki Dae
Hi Shuah, 2016년 08월 13일 02:52에 Shuah Khan 이(가) 쓴 글: > On 08/12/2016 11:28 AM, Shuah Khan wrote: >> On 08/10/2016 05:05 PM, Shuah Khan wrote: >>> On 08/10/2016 04:59 PM, Inki Dae wrote: >>>> Hi Shuah, >>>> >>>> 2016년 08월 11일 02:30에 Shua

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-10 Thread Inki Dae
other DMA devices. Even though IOMMU support is disabled, other framework based DMA drivers can use IOMMU - i.e., GPU driver - and they can use non-contiguous GEM buffer through UMM. (DMABUF) So GEM allocation type is not dependent on IOMMU. Thanks, Inki Dae > allocate non-contiguous mem

Re: [PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-10 Thread Inki Dae
other DMA devices. Even though IOMMU support is disabled, other framework based DMA drivers can use IOMMU - i.e., GPU driver - and they can use non-contiguous GEM buffer through UMM. (DMABUF) So GEM allocation type is not dependent on IOMMU. Thanks, Inki Dae > allocate non-contiguous mem

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-12 Thread Inki Dae
2016년 06월 10일 09:24에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae <inki@samsung.com> wrote: > > [snip] > >>> I know that removing .trg_type is enough but I also removed those lines >>> be

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-12 Thread Inki Dae
2016년 06월 10일 09:24에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae wrote: > > [snip] > >>> I know that removing .trg_type is enough but I also removed those lines >>> because the fields are not

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-09 Thread Inki Dae
Hi Javier, 2016년 06월 09일 09:17에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > Thanks for your feedback. > > On 06/08/2016 07:09 PM, Inki Dae wrote: >> Hi Javier, >> >> 2016년 06월 02일 23:20에 Javier Martinez Canillas 이(가) 쓴 글: >>> Commit a6f75

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-09 Thread Inki Dae
Hi Javier, 2016년 06월 09일 09:17에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > Thanks for your feedback. > > On 06/08/2016 07:09 PM, Inki Dae wrote: >> Hi Javier, >> >> 2016년 06월 02일 23:20에 Javier Martinez Canillas 이(가) 쓴 글: >>> Commit a6f75

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-08 Thread Inki Dae
.lcdblk_mic_bypass_shift = 11, > - .trg_type = I80_HW_TRG, > .has_shadowcon = 1, > .has_vidoutcon = 1, > .has_vtsel = 1, > .has_mic_bypass = 1, > .has_dp_clk = 1, > - .has_hw_trigger = 1, > - .has_trigger_per_te = 1, We don't need to remove

Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-08 Thread Inki Dae
t = 11, > - .trg_type = I80_HW_TRG, > .has_shadowcon = 1, > .has_vidoutcon = 1, > .has_vtsel = 1, > .has_mic_bypass = 1, > .has_dp_clk = 1, > - .has_hw_trigger = 1, > - .has_trigger_per_te = 1, We don't need to remove above two lines. It would

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-04-03 Thread Inki Dae
2016년 03월 31일 23:10에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 31, 2016 at 7:26 AM, Inki Dae <daei...@gmail.com> wrote: >> Hi Daniel, >> >> 2016-03-31 19:56 GMT+09:00 Daniel Stone <dan...@fooishbar.org>: >>> Hi Inki, >>> >>> On 31 March 2016 at

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-04-03 Thread Inki Dae
2016년 03월 31일 23:10에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 31, 2016 at 7:26 AM, Inki Dae wrote: >> Hi Daniel, >> >> 2016-03-31 19:56 GMT+09:00 Daniel Stone : >>> Hi Inki, >>> >>> On 31 March 2016 at 11:05, Inki Dae wrote: >>>> 2016년 03월 31

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
course this should only be used for shared buffers, e.g. > explicit syncing in an android client running on top of implicitly synced > ozone/kms. Good idea. I hope fence things of mainline would be more discussed so could be considered for many cases. Thanks, Inki Dae > -Daniel > --

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
only be used for shared buffers, e.g. > explicit syncing in an android client running on top of implicitly synced > ozone/kms. Good idea. I hope fence things of mainline would be more discussed so could be considered for many cases. Thanks, Inki Dae > -Daniel > -- > Daniel V

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
Hi Daniel, 2016-03-31 19:56 GMT+09:00 Daniel Stone <dan...@fooishbar.org>: > Hi Inki, > > On 31 March 2016 at 11:05, Inki Dae <inki@samsung.com> wrote: >> 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: >>> On 31 March 2016 at 08:45, Inki Dae <inki@samsu

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
Hi Daniel, 2016-03-31 19:56 GMT+09:00 Daniel Stone : > Hi Inki, > > On 31 March 2016 at 11:05, Inki Dae wrote: >> 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: >>> On 31 March 2016 at 08:45, Inki Dae wrote: >>>> As of now, it seems that this wouldn't be opti

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
Hi Daniel, 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 31 March 2016 at 08:45, Inki Dae <inki@samsung.com> wrote: >> 2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: >>> On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae <inki@samsung.com> wrote: >

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
Hi Daniel, 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 31 March 2016 at 08:45, Inki Dae wrote: >> 2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: >>> On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote: >>>> In addition, I wonder how explic

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: > On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae <inki@samsung.com> wrote: >> >> In addition, I wonder how explicit and implicit fences could coexist >> together. >> Rob said, >> "Implicit sync ofc

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Inki Dae
2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: > On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote: >> >> In addition, I wonder how explicit and implicit fences could coexist >> together. >> Rob said, >> "Implicit sync ofc remains the default, but userspace cou

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-28 Thread Inki Dae
Hi Daniel, 2016년 03월 28일 22:26에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 28 March 2016 at 02:26, Inki Dae <inki@samsung.com> wrote: >> 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: >>> Second, really. Vulkan avoids implicit sync entirely, and exposes >>&g

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-28 Thread Inki Dae
Hi Daniel, 2016년 03월 28일 22:26에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 28 March 2016 at 02:26, Inki Dae wrote: >> 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: >>> Second, really. Vulkan avoids implicit sync entirely, and exposes >>> fence-like primitives throug

Re: [PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-28 Thread Inki Dae
Hi Javier, Thanks for your patch set. Will merge them if there is no issue. Thanks, Inki Dae 2016년 03월 29일 10:28에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > This patch series contains some fixes for the Kconfig symbol dependencies > of the Exynos DRM driver. Th

Re: [PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-28 Thread Inki Dae
Hi Javier, Thanks for your patch set. Will merge them if there is no issue. Thanks, Inki Dae 2016년 03월 29일 10:28에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > This patch series contains some fixes for the Kconfig symbol dependencies > of the Exynos DRM driver. Th

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-27 Thread Inki Dae
Hi Rob and Daniel, 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: > Hi all, > > On 25 March 2016 at 11:58, Rob Clark <robdcl...@gmail.com> wrote: >> On Thu, Mar 24, 2016 at 7:49 PM, Inki Dae <inki@samsung.com> wrote: >>> It's definitely different ca

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-27 Thread Inki Dae
Hi Rob and Daniel, 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: > Hi all, > > On 25 March 2016 at 11:58, Rob Clark wrote: >> On Thu, Mar 24, 2016 at 7:49 PM, Inki Dae wrote: >>> It's definitely different case. This tries to add new user-space interfaces >>&g

Re: [patch 2/2] drm/exynos: mic: remove some dead code

2016-03-25 Thread Inki Dae
egmap_write function, ret = regmap_write(mic->sysreg, ); if (ret) ... Thanks, Inki Dae > } > > static int mic_sw_reset(struct exynos_mic *mic) > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >

Re: [patch 2/2] drm/exynos: mic: remove some dead code

2016-03-25 Thread Inki Dae
al &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX); > > regmap_write(mic->sysreg, DSD_CFG_MUX, val); > - if (ret) > - DRM_ERROR("mic: Failed to read system register\n"); I think we missed to keep return value from regmap_write function, ret = regmap_wr

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
2016년 03월 25일 00:40에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 24, 2016 at 4:18 AM, Inki Dae <inki@samsung.com> wrote: >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> >>>

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
2016년 03월 25일 00:40에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 24, 2016 at 4:18 AM, Inki Dae wrote: >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan >>> >>> Hi, >>> >>> This is a first proposal to d

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
Hi Guestavo, 2016년 03월 24일 23:39에 Gustavo Padovan 이(가) 쓴 글: > Hi Inki, > > 2016-03-24 Inki Dae <inki@samsung.com>: > >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan <gustavo.pado...@collabora.co.

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
Hi Guestavo, 2016년 03월 24일 23:39에 Gustavo Padovan 이(가) 쓴 글: > Hi Inki, > > 2016-03-24 Inki Dae : > >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan >>> >>> Hi, >>> >>> This is a firs

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
of view. Is there anyone who can explan why Android specific thing is tried to spread into Linux DRM? Was there any consensus to use Android sync driver - which uses explicit sync interfaces - as Linux standard? Thanks, Inki Dae > > /** > * struct fence_collection - aggregate f

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
lan why Android specific thing is tried to spread into Linux DRM? Was there any consensus to use Android sync driver - which uses explicit sync interfaces - as Linux standard? Thanks, Inki Dae > > /** > * struct fence_collection - aggregate fences together > * @num_fence

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
2016년 03월 23일 08:39에 Russell King - ARM Linux 이(가) 쓴 글: > On Wed, Mar 23, 2016 at 08:09:33AM +0900, Inki Dae wrote: >> In this case, someone else may send an email again like you "who is going to >> merge?" >> That would be why we need a maintainer. >>

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
2016년 03월 23일 08:39에 Russell King - ARM Linux 이(가) 쓴 글: > On Wed, Mar 23, 2016 at 08:09:33AM +0900, Inki Dae wrote: >> In this case, someone else may send an email again like you "who is going to >> merge?" >> That would be why we need a maintainer. >>

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
2016년 03월 23일 07:52에 Heiko Stübner 이(가) 쓴 글: > Am Mittwoch, 23. März 2016, 07:44:59 schrieb Inki Dae: >> + Ajay kumar with Samsung email >> >> Hi, >> >> 2016년 03월 23일 07:12에 Heiko Stübner 이(가) 쓴 글: >>> Hi, >>> >>> Am Dienstag, 22. März

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
2016년 03월 23일 07:52에 Heiko Stübner 이(가) 쓴 글: > Am Mittwoch, 23. März 2016, 07:44:59 schrieb Inki Dae: >> + Ajay kumar with Samsung email >> >> Hi, >> >> 2016년 03월 23일 07:12에 Heiko Stübner 이(가) 쓴 글: >>> Hi, >>> >>> Am Dienstag, 22. März

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
and have pull-request again. But it seems a little late. Dave had already pull-request. To Ajay, How about adding you as a drm bridge maintainer? DRM SoC driver maintainers would need a person who can manage the drm bridge relevant pathes. Thanks, Inki Dae > > Thanks > Heiko > >

Re: Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-22 Thread Inki Dae
, How about adding you as a drm bridge maintainer? DRM SoC driver maintainers would need a person who can manage the drm bridge relevant pathes. Thanks, Inki Dae > > Thanks > Heiko > >

Re: [PATCH v8 01/17] drm: exynos: dp: convert to drm bridge mode

2016-03-22 Thread Inki Dae
y: Javier Martinez Canillas <jav...@osg.samsung.com> > Signed-off-by: Yakir Yang <y...@rock-chips.com> Acked-by: Inki Dae <inki@samsung.com> Thanks, Inki Dae > --- > Changes in v8: None > Changes in v7: None > Changes in v6: > - Fix the wrong code i

Re: [PATCH v8 01/17] drm: exynos: dp: convert to drm bridge mode

2016-03-22 Thread Inki Dae
y: Javier Martinez Canillas > Signed-off-by: Yakir Yang Acked-by: Inki Dae Thanks, Inki Dae > --- > Changes in v8: None > Changes in v7: None > Changes in v6: > - Fix the wrong code in previous series, and test on Samsung snow Chromebook > su

Re: [PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP

2016-01-25 Thread Inki Dae
iginal auther, Gustavo Padovan, posted runtime pm support. However, it seems missing this one. Thanks, Inki Dae > -static int exynos_mixer_suspend(struct device *dev) > +static int __maybe_unused exynos_mixer_suspend(struct device *dev) > { > struct mixer_context *ctx = dev_g

Re: [PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP

2016-01-25 Thread Inki Dae
in all cases and >> also looks nicer. >> >> Signed-off-by: Arnd Bergmann >> Fixes: ("drm/exynos: add pm_runtime to Mixer") > > Dear Inki, > > Ping? On 4.5-rc1 this is still broken. Can you apply this for fixes > for current rc-cycle? Got it.

Re: [PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP

2016-01-25 Thread Inki Dae
dified it to PM since original auther, Gustavo Padovan, posted runtime pm support. However, it seems missing this one. Thanks, Inki Dae > -static int exynos_mixer_suspend(struct device *dev) > +static int __maybe_unused exynos_mixer_suspend(struct device *dev) > { > struct mi

Re: [PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP

2016-01-25 Thread Inki Dae
es the right thing in all cases and >> also looks nicer. >> >> Signed-off-by: Arnd Bergmann <a...@arndb.de> >> Fixes: ("drm/exynos: add pm_runtime to Mixer") > > Dear Inki, > > Ping? On 4.5-rc1 this is still broken. Can you apply this for

Re: [PATCH] drm/exynos: fix spelling errors

2015-10-12 Thread Inki Dae
Hi, Ingi. Merged. Thanks for your first patch to drm world. :) This patch isn't trivial so will go to next. Thanks, Inki Dae 2015년 10월 02일 17:59에 Ingi Kim 이(가) 쓴 글: > This patch fixes spelling errors in drm fimc/gsc > inavild -> invaild > > Signed-off-by: Ingi Kim > --- &

Re: [PATCH] drm/exynos: fix spelling errors

2015-10-12 Thread Inki Dae
Hi, Ingi. Merged. Thanks for your first patch to drm world. :) This patch isn't trivial so will go to next. Thanks, Inki Dae 2015년 10월 02일 17:59에 Ingi Kim 이(가) 쓴 글: > This patch fixes spelling errors in drm fimc/gsc > inavild -> invaild > > Signed-off-by: Ingi Kim <ing

Re: linux-next: rebase of the drm-exynos tree

2015-08-17 Thread Inki Dae
tree) and you should continue your work from there. Right, I had requested git-pull. Will do re-base on top of Dave's tree. Thanks, Inki Dae > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: linux-next: build failure after merge of the drm-exynos tree

2015-08-17 Thread Inki Dae
_mixer.c:473:30: error: 'struct >>> exynos_drm_plane' has no member named 'mode_height' >>> mixer_cfg_rgb_fmt(ctx, plane->mode_height); >>> ^ >>> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_setup_scale': >>>

Re: linux-next: rebase of the drm-exynos tree

2015-08-17 Thread Inki Dae
from there. Right, I had requested git-pull. Will do re-base on top of Dave's tree. Thanks, Inki Dae -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: linux-next: build failure after merge of the drm-exynos tree

2015-08-17 Thread Inki Dae
...@canb.auug.org.au Date: Fri Aug 14 12:06:53 2015 +1000 Merge remote-tracking branch 'drm-exynos/exynos-drm/for-next And today, I re-based exynos-drm/for-next on top of mainline. Could you update and try to build it again? Thanks, Inki Dae -- To unsubscribe from this list: send the line

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-24 Thread Inki Dae
On 2015년 07월 22일 19:08, Inki Dae wrote: > On 2015년 07월 22일 17:42, Joonyoung Shim wrote: >> On 07/22/2015 05:22 PM, Inki Dae wrote: >>> On 2015년 07월 22일 17:12, Joonyoung Shim wrote: >>>> On 07/22/2015 01:55 PM, Inki Dae wrote: >>>>> On 2015년 07월 22일 11:0

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

2015-07-24 Thread Inki Dae
On 2015년 07월 22일 19:08, Inki Dae wrote: On 2015년 07월 22일 17:42, Joonyoung Shim wrote: On 07/22/2015 05:22 PM, Inki Dae wrote: On 2015년 07월 22일 17:12, Joonyoung Shim wrote: On 07/22/2015 01:55 PM, Inki Dae wrote: On 2015년 07월 22일 11:02, Joonyoung Shim wrote: On 07/21/2015 10:19 PM, Krzysztof

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-22 Thread Inki Dae
On 2015년 07월 22일 17:42, Joonyoung Shim wrote: > On 07/22/2015 05:22 PM, Inki Dae wrote: >> On 2015년 07월 22일 17:12, Joonyoung Shim wrote: >>> On 07/22/2015 01:55 PM, Inki Dae wrote: >>>> On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >>>>> On 07/21/2015 1

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-22 Thread Inki Dae
On 2015년 07월 22일 17:12, Joonyoung Shim wrote: > On 07/22/2015 01:55 PM, Inki Dae wrote: >> On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >>> On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >>>> Hi, >>>> >>>> Today's linux-next (next-

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

2015-07-22 Thread Inki Dae
On 2015년 07월 22일 17:12, Joonyoung Shim wrote: On 07/22/2015 01:55 PM, Inki Dae wrote: On 2015년 07월 22일 11:02, Joonyoung Shim wrote: On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: Hi, Today's linux-next (next-20150721) encounters boot failures on Exynos Octa (Exynos5422) based boards

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

2015-07-22 Thread Inki Dae
On 2015년 07월 22일 17:42, Joonyoung Shim wrote: On 07/22/2015 05:22 PM, Inki Dae wrote: On 2015년 07월 22일 17:12, Joonyoung Shim wrote: On 07/22/2015 01:55 PM, Inki Dae wrote: On 2015년 07월 22일 11:02, Joonyoung Shim wrote: On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: Hi, Today's linux

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-21 Thread Inki Dae
sible and then we can remove >> drm_iommu_attach_device_if_possible and clear_channels function pointer. >> >> Signed-off-by: Joonyoung Shim >> Tested-by: Marek Szyprowski >> Signed-off-by: Inki Dae >> >> :04 04 83379efbf4960f58d68

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

2015-07-21 Thread Inki Dae
. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Tested-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Inki Dae inki@samsung.com :04 04 83379efbf4960f58d680371628ec04387935bd53 da03c338b88e7cb6bda895b3dd52d78d9b6eba30 M drivers Config: exynos Boot log

Re: linux-next: build failure after merge of the drm-exynos tree

2015-06-23 Thread Inki Dae
On 2015년 06월 24일 10:21, Inki Dae wrote: > Hi Dave and Stephen, > > On 2015년 06월 24일 10:01, Stephen Rothwell wrote: >> Hi Dave, >> >> On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell >> wrote: >>> >>> After merging the drm-exynos tree, today'

Re: linux-next: build failure after merge of the drm-exynos tree

2015-06-23 Thread Inki Dae
i for today. As you know, I posted below patch which fixes the build error, [PATCH] of: fix a build error to f_graph_get_endpoint_by_regs function However, I think we need Acked-by from device tree maintainer to merge it to drm-next. Thanks, Inki Dae > -- To unsubscribe from

Re: linux-next: build failure after merge of the drm-exynos tree

2015-06-23 Thread Inki Dae
to merge it to drm-next. Thanks, Inki Dae -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-exynos tree

2015-06-23 Thread Inki Dae
On 2015년 06월 24일 10:21, Inki Dae wrote: Hi Dave and Stephen, On 2015년 06월 24일 10:01, Stephen Rothwell wrote: Hi Dave, On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the drm-exynos tree, today's linux-next build (x86_64 allmodconfig

Re: linux-next: build failure after merge of the drm-exynos tree

2015-06-22 Thread Inki Dae
ic" when defining of_graph_get_endpoint_by_regs function, a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers") For this, I will fix and post it soon. Thanks, Inki Dae > > drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs'

Re: linux-next: build failure after merge of the drm-exynos tree

2015-06-22 Thread Inki Dae
of_graph_get_endpoint_by_regs function, a0f7001c18ca (of: add helper for getting endpoint node of specific identifiers) For this, I will fix and post it soon. Thanks, Inki Dae drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs': adv7604.c:(.text+0x586c): multiple definition

Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj

2015-06-19 Thread Inki Dae
On 2015년 06월 19일 14:46, Krzysztof Kozlowski wrote: > 2015-06-19 14:28 GMT+09:00 Inki Dae : >> On 2015년 06월 19일 14:23, Krzysztof Kozlowski wrote: >>> The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in >>> 2a3098ff6c21 ("drm/exynos: ad

Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj

2015-06-19 Thread Inki Dae
On 2015년 06월 19일 14:46, Krzysztof Kozlowski wrote: 2015-06-19 14:28 GMT+09:00 Inki Dae inki@samsung.com: On 2015년 06월 19일 14:23, Krzysztof Kozlowski wrote: The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in 2a3098ff6c21 (drm/exynos: add userptr feature for g2d module

Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj

2015-06-18 Thread Inki Dae
mapped to multiple > user-space VMAs so 'vma' field does not look useful anyway. Krzysztof, The vma member would be removed by below patch, http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > --- > dri

Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj

2015-06-18 Thread Inki Dae
so 'vma' field does not look useful anyway. Krzysztof, The vma member would be removed by below patch, http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html Thanks, Inki Dae Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/gpu/drm/exynos

Re: [RFT PATCH v2 2/3] drm/exynos: Constify exynos_drm_crtc_ops

2015-05-11 Thread Inki Dae
rm_crtc.h:24: + const struct exynos_drm_crtc_ops *ops, I modified and merged all patches. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > New patch. > --- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- > drivers/gpu/drm/exyno

Re: [RFT PATCH v2 2/3] drm/exynos: Constify exynos_drm_crtc_ops

2015-05-11 Thread Inki Dae
: + const struct exynos_drm_crtc_ops *ops, I modified and merged all patches. Thanks, Inki Dae Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com --- Changes since v1: New patch. --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- drivers/gpu/drm/exynos

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
2015-05-04 21:43 GMT+09:00 Krzysztof Kozlowski : > 2015-05-04 20:34 GMT+09:00 Daniel Stone : >> Hi, >> >> On 4 May 2015 at 08:43, Inki Dae wrote: >>> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>>> Selecting CONFIG_FB_S3C disables CONFIG_D

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
2015-05-04 20:34 GMT+09:00 Daniel Stone : > Hi, > > On 4 May 2015 at 08:43, Inki Dae wrote: >> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >>> error: >> >> No, eDP has

Re: [PATCH] drm/exynos: mixer: Constify platform_device_id

2015-05-04 Thread Inki Dae
On 2015년 05월 02일 00:56, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. Applied. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- > 1 file chang

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
rm_crtc *crtc, bool enable); > +#else > +static inline void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool > enable) {}; > +#endif So above codes are unnecessary. It's really not good to add #ifdef ~ #endif. Thanks, Inki Dae > > #endif /* _EXYNOS_DRM_FIMD_H_ *

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
exynos_drm_crtc *crtc, bool enable) {}; +#endif So above codes are unnecessary. It's really not good to add #ifdef ~ #endif. Thanks, Inki Dae #endif /* _EXYNOS_DRM_FIMD_H_ */ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] drm/exynos: mixer: Constify platform_device_id

2015-05-04 Thread Inki Dae
On 2015년 05월 02일 00:56, Krzysztof Kozlowski wrote: The platform_device_id is not modified by the driver and core uses it as const. Applied. Thanks, Inki Dae Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com --- drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- 1 file changed, 1

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
2015-05-04 20:34 GMT+09:00 Daniel Stone dan...@fooishbar.org: Hi, On 4 May 2015 at 08:43, Inki Dae inki@samsung.com wrote: On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build error: No, eDP has no any dependency

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Inki Dae
2015-05-04 21:43 GMT+09:00 Krzysztof Kozlowski k.kozlowsk...@gmail.com: 2015-05-04 20:34 GMT+09:00 Daniel Stone dan...@fooishbar.org: Hi, On 4 May 2015 at 08:43, Inki Dae inki@samsung.com wrote: On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: Selecting CONFIG_FB_S3C disables

Re: [RFT PATCHv2] drm/exynos: Enable DP clock to fix display on Exynos5250 and other

2015-04-07 Thread Inki Dae
or this suggested Andrzej Hajda: the DP clock was disabled. > This clock is required by Display Port and is enabled by bootloader. > However when FIMD driver probing was deferred, the display power domain > was turned off. This effectively reset the value of DP clock enable > register.

Re: [RFT PATCHv2] drm/exynos: Enable DP clock to fix display on Exynos5250 and other

2015-04-07 Thread Inki Dae
: the DP clock was disabled. This clock is required by Display Port and is enabled by bootloader. However when FIMD driver probing was deferred, the display power domain was turned off. This effectively reset the value of DP clock enable register. Applied. Thanks, Inki Dae When exynos-dp

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-09 Thread Inki Dae
On 2015년 03월 07일 00:07, Javier Martinez Canillas wrote: > Hello Inki, > > On 03/06/2015 02:32 PM, Inki Dae wrote: >>> >>> Another interesting data point is that the error in next-20150303 for >>> these 2 boards was the NULL pointer dereference in exynos_plane

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-09 Thread Inki Dae
On 2015년 03월 07일 00:07, Javier Martinez Canillas wrote: Hello Inki, On 03/06/2015 02:32 PM, Inki Dae wrote: Another interesting data point is that the error in next-20150303 for these 2 boards was the NULL pointer dereference in exynos_plane_destroy that I got with 4.0-rc2 (when IOMMU

Re: [PATCH] drm/exynos: Check for NULL dereference of crtc

2015-03-07 Thread Inki Dae
On 2015년 03월 06일 23:04, Charles Keepax wrote: > On Fri, Mar 06, 2015 at 10:13:42PM +0900, Inki Dae wrote: >> On 2015년 02월 18일 02:14, Charles Keepax wrote: >>> The commit "drm/exynos: remove exynos_plane_dpms" (d9ea6256) removed the >>> use of the enabled flag,

Re: [PATCH] drm/exynos: Check for NULL dereference of crtc

2015-03-07 Thread Inki Dae
On 2015년 03월 06일 23:04, Charles Keepax wrote: On Fri, Mar 06, 2015 at 10:13:42PM +0900, Inki Dae wrote: On 2015년 02월 18일 02:14, Charles Keepax wrote: The commit drm/exynos: remove exynos_plane_dpms (d9ea6256) removed the use of the enabled flag, which means that the code may attempt to call

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-06 Thread Inki Dae
250-arndale failed to boot with next-20150304 [13] > while exynos5422-odroidxu3 booted successfully and there were no changes > for the exynos drm driver between next-20150303 and next-20150304. > > Another interesting data point is that the error in next-20150303 for > these 2 boards

<    1   2   3   4   >