that approach.
FYI, I have made the changes and they are now upstream in Babeltrace as of
commit 12c8a1a3121ed7125e8758065c44658d8eda1333
Author: Jérémie Galarneau jeremie.galarn...@efficios.com
Date: Tue Jul 29 16:51:51 2014 -0400
Add stream packet header accessors
Stream packet contexts may
Some btrfs tracepoints are not properly namespaced. The
tracepoint names should be prefixed with the subsystem's name
as suggested in tracepoint.h
Cc: Chris Mason c...@fb.com
Cc: Steven Rostedt rost...@goodmis.org
Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com
---
fs/btrfs
)
- pr_err(CTF stream %d flush
failed\n, i);
- }
- }
+ for (cpu = 0; cpu MAX_CPUS; cpu++)
+ flush_stream(cw, cpu);
}
fprintf(stderr,
--
Jérémie Galarneau
EfficiOS Inc.
http
that code has convinced me to introduce
int bt_ctf_validate_identifier(const char *identifier);
commit 654c1444b546fd79b209288b93ed4e87d9bb8a2b
Author: Jérémie Galarneau jeremie.galarn...@efficios.com
Date: Fri Jan 23 16:24:52 2015 -0500
Add utility function to validate CTF identifiers
)
error path
thanks,
jirka
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 21, 2015 at 8:38 PM, Wang Nan wangn...@huawei.com wrote:
On 2015/1/21 23:56, Jérémie Galarneau wrote:
On Wed, Jan 21, 2015 at 9:11 AM, Jiri Olsa jo...@redhat.com wrote:
On Wed, Jan 21, 2015 at 11:23:54AM +0800, Wang Nan wrote:
Some parameters of syscall tracepoints named as 'nr
-convert-bt.c
create mode 100644 tools/perf/util/data-convert-bt.h
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Sun, Jan 25, 2015 at 8:43 AM, Jiri Olsa jo...@redhat.com wrote:
On Fri, Jan 16, 2015 at 11:46:36AM -0500, Jérémie Galarneau wrote:
On Fri, Jan 16, 2015 at 10:26 AM, Alexandre Montplaisir
alexmon...@voxpopuli.im wrote:
On 2015-01-15 03:57 PM, Alexandre Montplaisir wrote:
Hi,
I'm
, that seem usefull.. I always redirected this to ' /tmp/krava'
never got enough will to make it nice and generic ;-)
thanks,
jirka
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
end as well. I pushed a fix
addressing this issue in Babeltrace master as of 5ca83563.
This scenario has also been added to Babeltrace's regression test suite.
Jérémie
Stopping at this to process other patches, will be back to this after
reducing the queue,
- Arnaldo
--
Jérémie Galarneau
looking into it and will keep you posted.
Jérémie
Stopping at this to process other patches, will be back to this after
reducing the queue,
- Arnaldo
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
err;
+ }
+
+ bt_ctf_event_put(event);
+
priv-event_class = event_class;
evsel-priv = priv;
return 0;
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
class: in bt_ctf_stream_class_add_event_class()
Signed-off-by: Philippe Proulx eeppelitel...@gmail.com
Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com
Jérémie
On Mon, Apr 13, 2015 at 4:30 PM, Jérémie Galarneau
jeremie.galarn...@efficios.com wrote:
On Fri, Apr 10
; \
} \
} while (0)
--
1.9.3
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
Hi He,
This commit should fix the problem:
commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334
Author: Jérémie Galarneau jeremie.galarn...@efficios.com
Date: Thu Apr 9 14:57:44 2015 -0400
Fix: Allow the addition of environment fields to a frozen trace
Commit 7f800dc7 introduced
/hypermail/linux/kernel/1602.1/03800.html
CC-ing the people who were CC-ed on the original patch.
Signed-off-by: Jérémie Galarneau <jeremie.galarn...@efficios.com>
Cc: Wang Nan <wangn...@huawei.com>
Cc: Philippe Proulx <philippe.pro...@efficios.com>
Cc: David S. Miller <
distributions
and gcc versions.
Signed-off-by: Jérémie Galarneau
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Alexander Shishkin
---
tools/perf/util/data-convert-bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util
Hi Arnaldo,
Anything I can do to help you with this patch?
Thanks,
Jérémie
On 5 September 2018 at 12:09, Jiri Olsa wrote:
> On Wed, Aug 29, 2018 at 04:16:48PM -0400, Jérémie Galarneau wrote:
>> Building the perf CTF converter fails with gcc 4.8.4
>> on Ubuntu 14.04 with the
Could take some time. However I
> wanted first to make sure it make sense to continue that approach.
>
FYI, I have made the changes and they are now upstream in Babeltrace as of
commit 12c8a1a3121ed7125e8758065c44658d8eda1333
Author: Jérémie Galarneau
Date: Tue Jul 29 16:51:51 2014 -
/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/userspace/protected-creat
[2] https://lkml.org/lkml/2018/4/10/840
[3] https://lore.kernel.org/lkml/20180416175918.GA13494@beast/
[4]
https://github.com/lttng/lttng-tools/commit/cf86ff2c4ababd01fea7ab2c9c289cb7c0a1bcd5
--
Jérémie Galarneau
EfficiOS
distributions
and gcc versions.
Signed-off-by: Jérémie Galarneau
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Alexander Shishkin
---
tools/perf/util/data-convert-bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util
Hi Arnaldo,
Anything I can do to help you with this patch?
Thanks,
Jérémie
On 5 September 2018 at 12:09, Jiri Olsa wrote:
> On Wed, Aug 29, 2018 at 04:16:48PM -0400, Jérémie Galarneau wrote:
>> Building the perf CTF converter fails with gcc 4.8.4
>> on Ubuntu 14.04 with the
t char *input, const char
> *path)
> if (!session)
> goto free_writer;
>
> + ordered_events__set_alloc_size(>ordered_events,
> + 100*1024*1024);
> +
> /* CTF writer env/clock setup */
&
tf-data/") at util/data-convert-bt.c:992
> #13 0x004479cf in cmd_data_convert (argc=,
> argv=, prefix=) at builtin-data.c:77
> #14 0x0046f365 in run_builtin (p=p@entry=0x8345a0 ,
> argc=argc@entry=3, argv=argv@entry=0x7fffe2d0) at perf.c:370
> #15 0x004
in handle_internal_command (argv=0x7fffe2d0,
> argc=3) at perf.c:429
> #16 run_argv (argv=0x7fffe050, argcp=0x7fffe05c) at perf.c:473
> #17 main (argc=3, argv=0x7fffe2d0) at perf.c:588
> (gdb)
>
I was able to reproduce this on my end as well. I pushed a fix
addressing
Hi He,
This commit should fix the problem:
commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334
Author: Jérémie Galarneau
Date: Thu Apr 9 14:57:44 2015 -0400
Fix: Allow the addition of environment fields to a frozen trace
Commit 7f800dc7 introduced a behavior change which made
ric_types(struct ctf_writer *cw,
> struct perf_evsel *evsel,
> do {\
> pr2(" field '%s'\n", n); \
> if (bt_ctf_event_class_add_field(cl, t, n)) { \
> - pr_err("Failed to add field '%s;\n", n);\
> + pr_err("Failed to add field '%s';\n", n); \
> return -1; \
> } \
> } while (0)
> --
> 1.9.3
>
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
t; - field->name);
>> + /* Check name duplication */
>> + name = field->name;
>
> could you please put this in separated function like 'get_field_name(..)'
> so we dont polute this function even more
>
> name
| 9 +-
>>> tools/perf/builtin-data.c | 119 ++
>>> tools/perf/builtin.h |1 +
>>> tools/perf/command-list.txt |1 +
>>> tools/perf/co
On Wed, Jan 21, 2015 at 8:38 PM, Wang Nan wrote:
> On 2015/1/21 23:56, Jérémie Galarneau wrote:
>> On Wed, Jan 21, 2015 at 9:11 AM, Jiri Olsa wrote:
>>> On Wed, Jan 21, 2015 at 11:23:54AM +0800, Wang Nan wrote:
>>>> Some parameters of syscall tracepoints named as
/* if failed, we may hit a keywork. try again with a '_' prefix */
>>> +if (ret) {
>>> +name = change_name(name, field->name, -1);
>>> +if (!name) {
>>> +pr_err("Failed to alloc name for '_%s'\n",
>
Some btrfs tracepoints are not properly namespaced. The
tracepoint names should be prefixed with the subsystem's name
as suggested in tracepoint.h
Cc: Chris Mason
Cc: Steven Rostedt
Signed-off-by: Jérémie Galarneau
---
fs/btrfs/delayed-ref.c | 6 +++---
fs/btrfs/extent-tree.c
gt; @@ -833,6 +834,14 @@ static int add_event(struct ctf_writer *cw, struct
> perf_evsel *evsel)
> if (!priv)
> goto err;
>
> + event = bt_ctf_event_create(event_class);
> + if (!event) {
> + pr_err("Failed to crea
stream
class: in bt_ctf_stream_class_add_event_class()
Signed-off-by: Philippe Proulx
Signed-off-by: Jérémie Galarneau
Jérémie
On Mon, Apr 13, 2015 at 4:30 PM, Jérémie Galarneau
wrote:
> On Fri, Apr 10, 2015 at 8:37 AM, Jiri Olsa wrote:
>> On Fri, Apr 10, 2015 at 02:0
On Sun, Jan 25, 2015 at 8:43 AM, Jiri Olsa wrote:
> On Fri, Jan 16, 2015 at 11:46:36AM -0500, Jérémie Galarneau wrote:
>> On Fri, Jan 16, 2015 at 10:26 AM, Alexandre Montplaisir
>> wrote:
>> > On 2015-01-15 03:57 PM, Alexandre Montplaisir wrote:
>> >>
&
E) OUTPUT=$(OUTPUT_FEATURES)
>> CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS)
>> $(FEATURE_CHECK_LDFLAGS-$(1))" -C config/feature-checks test-$1.bin
>> >/dev/null 2>/dev/null && echo 1 ||
>> + feature-$(1) := $(s
/hypermail/linux/kernel/1602.1/03800.html
CC-ing the people who were CC-ed on the original patch.
Signed-off-by: Jérémie Galarneau
Cc: Wang Nan
Cc: Philippe Proulx
Cc: David S. Miller
Cc: Alexei Starovoitov
Cc: Brendan Gregg
Cc: David S. Miller
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Namhyu
Commit-ID: c04c859f439fb4de9039246370d60a07b9b5bcb5
Gitweb: https://git.kernel.org/tip/c04c859f439fb4de9039246370d60a07b9b5bcb5
Author: Jérémie Galarneau
AuthorDate: Wed, 29 Aug 2018 16:16:48 -0400
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 19 Sep 2018 10:25:13 -0300
perf
Commit-ID: c04c859f439fb4de9039246370d60a07b9b5bcb5
Gitweb: https://git.kernel.org/tip/c04c859f439fb4de9039246370d60a07b9b5bcb5
Author: Jérémie Galarneau
AuthorDate: Wed, 29 Aug 2018 16:16:48 -0400
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 19 Sep 2018 10:25:13 -0300
perf
39 matches
Mail list logo
