Looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 10/31/2012 07:21 AM, Sergei Trofimovich wrote:
From: Sergei Trofimovich sly...@gentoo.org
Found by gcc:
linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1
Hi Maya,
I tested with dw-mmc controller.
It's look good to me.
Tested-by: Jaehoon Chung jh80.ch...@samsung.com
On 11/07/2012 01:28 PM, me...@codeaurora.org wrote:
Hi Jaehoon,
Any update on this patch review and testing?
Thanks,
Maya
On Mon, October 15, 2012 11:53 pm, Jaehoon Chung
I didn't understand why defer the probe?
I think that some board can't control vqmmc or vmmc.
Best Regards,
Jaehoon Chung
On 10/23/2012 04:18 PM, Pavan Kunapuli wrote:
vmmc and vqmmc regulators control the voltage to
the host and device. Defer the probe if either of
them is not registered
-card_tasklet);
tasklet_kill(host-finish_tasklet);
+out_vmmc:
+ if (host-vmmc)
+ regulator_put(host-vmmc);
If fall down to untasklet, need not to disable regulator for vmmc?
Best Regards,
Jaehoon Chung
return ret;
}
--
To unsubscribe from this list: send the line
Great..Thanks Arnd and Chris.
Best Regards,
Jaehoon Chung
On 11/08/2012 11:35 PM, Chris Ball wrote:
Hi Arnd,
On Thu, Nov 08 2012, Arnd Bergmann wrote:
The patch dw_mmc: fix multiple drv_data NULL dereferences has
unfortunately clashed with my mmc: dw_mmc: constify
dw_mci_idmac_ops
Hi Tushar,
Could you make one patch? Why do you separate patches?
Best Regards,
Jaehoon Chung
On 11/09/2012 08:39 PM, Tushar Behera wrote:
Documents/CodingStyle Chapter 3 recommends usage of braces for both
if and else statements if any of the branches contains multiple
statements
Hi Maya,
I'm testing with your patch..but i need to have the more time for testing.
In now, it looks good to me. Thank you for working the idle bkops.
Best Regards,
Jaehoon Chung
---
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 172a768..ed040d5 100644
--- a/drivers
Looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 10/16/2012 05:43 PM, James Hogan wrote:
Commit 800d78bfccb3d38116abfda2a5b9c8afdbd5ea21 (mmc: dw_mmc: add
support for implementation specific callbacks) merged in v3.7-rc1.
The above commit introduced multiple NULL pointer
Hi,
your patch[1/3] is also Fixed lines 80chars.
Why do you separate with patch[1/6] and patch[3/6]?
Best Regards,
Jaehoon Chung
On 10/19/2012 01:31 AM, Sangho Yi wrote:
I fixed lines over 80 characters per line.
Signed-off-by: Sangho Yi antir...@gmail.com
---
drivers/mmc/core
Hi Thomas,
I think not good that added the samsung specific code into dw_mmc-pltfm.c
How about separating to dw-mmc-exynos.c?
Best Regards,
Jaehoon Chung
On 07/12/2012 09:54 PM, Thomas Abraham wrote:
This patch series adds device tree support for Synopsis Designware Mobile
Storage Host
Hi Doug,
You're right..it's something wrong.
Actually i didn't test with your patch, but your commit message is reasonable.
I will check until next week after test.
Best Regards,
Jaehoon Chung
On 03/27/2013 03:06 AM, Doug Anderson wrote:
Jaehoon,
On Mon, Mar 18, 2013 at 3:21 AM, Jaehoon
Looks good to me.
Reviewed-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 04/05/2013 05:18 PM, Jaehoon Chung wrote:
Hi Doug,
You're right..it's something wrong.
Actually i didn't test with your patch, but your commit message is reasonable.
I will check until
On 04/10/2013 04:02 PM, Seungwon Jeon wrote:
On Tuesday, April 09, 2013, Doug Anderson wrote:
Seungwon,
On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon tgih@samsung.com wrote:
I guess Doug are debugging it with wifi, right?
Yes, we're debugging it on the Samsung ARM Chromebook on a part
Regards,
Jaehoon Chung
Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Doug,
Great..i have found the problem like this.
I will check your patch..and share the result.
Best Regards,
Jaehoon Chung
On 03/16/2013 06:29 AM, Doug Anderson wrote:
On a flaky piece of hardware that seems good at generating CRC errors,
we have found that often times the CRC errors
Looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 03/12/2013 07:43 PM, James Hogan wrote:
Call the setpower platform callback in response to set_ios with
ios-power_mode == MMC_POWER_UP or MMC_POWER_OFF, instead of from the
card detect work
Hi James,
There is no reason that can't change the verid check position.
So this patch looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 03/12/2013 07:43 PM, James Hogan wrote:
host-data_offset is initialised at the end of the probe function
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 03/12/2013 07:53 PM, Markos Chandras wrote:
There is no reason to loop when handling an interrupt. The if clauses
will handle all of them sequentially. This also eliminates the extra loop
we used to take with no pending interrupts and we ended
or not?
If mmc_stop_bkops() is failed, then bkops is continuously running.
Best Regards,
Jaehoon Chung
+ }
+ }
ret = mmc_blk_part_switch(card, md);
if (ret) {
diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
index fadf52e..9d0c96a 100644
--- a/drivers/mmc/card
, But I think that need to check whether the host-sdio_irq_thread is
assigned or not.
Best Regards,
Jaehoon Chung
Thanks
Guennadi
Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com
---
Currently the kernel panic to refer NULL pointer about
host-sdio_irq_thread are occuring at the trats
Regards,
Jaehoon Chung
{ .compatible = samsung,exynos5250-dw-mshc,
.data = exynos5250_drv_data, },
{},
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
/showthread.php?t=1644364
https://plus.google.com/111398485184813224730/posts/21pTYfTsCkB#111398485184813224730/posts/21pTYfTsCkB
Signed-off-by: Ian Chen ian.cy.c...@samsung.com
Reviewed-by: Namjae Jeon linkinj...@gmail.com
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Reviewed-by: Linus Walleij
Hi Chris,
Could you merge this patch?
We want to prevent this problem at mainline kernel.
Best Regards,
Jaehoon Chung
On 08/29/2012 03:05 PM, IAN CHEN wrote:
For several MoviNAND, there are some known issue with secure option.
For these specific MoviNAND device, we skip secure option.
You
will be performed
without waiting for the next idle time.
Signed-off-by: Maya Erez me...@codeaurora.org
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
---
This patch depends on the following patch:
[PATCH v11] mmc: support BKOPS feature for eMMC
This patch is based on the periodic BKOPs
Before call the blk_queue_congestion_threshold(),
the blk_queue_congestion_threshold() is already called at
blk_queue_make_rquest().
Because this code is the duplicated, it has removed.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
with _SEC_
It's no problem.
Best Regards,
Jaehoon Chung
So, how about MMC_QUIRK_SECDISCARD_BROKEN which was used in
mmc_blk_issue_secdiscard_rq() naming, the function we skip.
Or, MMC_QUIRK_SECERASE_SECTRIM_BROKEN?
Regards,
Ian
-Original Message-
From: Linus Walleij [mailto:linus.wall
Hi Doug,
I didn't know what purpose is.
Why need to add the MMC_CAP2_NO_MMC?
If card is SD or SDIO, mmc_attach_mmc(host) should not be entered.
Could you explain to me in more detail?
Best Regards,
Jaehoon Chung
On 08/22/2012 01:05 PM, Doug Anderson wrote:
On some systems we need a way
On 07/20/2012 07:47 AM, Kukjin Kim wrote:
Thomas Abraham wrote:
On 19 July 2012 20:58, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Thomas,
I think not good that added the samsung specific code into dw_mmc-
pltfm.c
How about separating to dw-mmc-exynos.c?
I am not sure
On 07/24/2012 02:02 AM, Doug Anderson wrote:
The documentation for the dw_mmc part says that the low power
mode should normally only be set for MMC and SD memory and should
be turned off for SDIO cards that need interrupts detected.
The best place I could find to do this is when the SDIO
-enabled again in dw_mci_setup_bus().
+ */
+ dw_mci_disable_low_power(mmc_priv(mmc));
Just use the slot. slot is already assigned to mmc_priv(mmc)
Reviewed-by: Jaehoon Chung jh80.ch...@samsung.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
);
+ return -1;
+ }
+
+ return gpio;
gpio is int type, but return type is u32?
Best Regards,
Jaehoon Chung
+}
#else /* CONFIG_OF */
static u32 dw_mci_of_get_bus_wd(struct device *dev, u8 slot)
{
@@ -1811,6 +1840,10 @@ static struct device_node
*dw_mci_of_find_slot_node(struct
Hi All,
Sorry for reply..I didn't fully read about this patch history.
So i will resend the my opinion after reading the mail-history
Best Regards,
Jaehoon Chung
On 12/21/2012 06:56 PM, Ulf Hansson wrote:
On 21 December 2012 09:35, Maya Erez me...@codeaurora.org wrote:
Hi Ulf,
Thanks
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 08/23/2013 01:19 AM, Doug Anderson wrote:
The TMOUT register is initted to 0x at probe time but isn't
initted after suspend/resume. Add an init of this value.
No problems were observed without this (it will also get initted
Hi Doug,
If the clock-gating is enabled, then maybe it's continuously printed the kernel
message for Bus_speed.
Best Regards,
Jaehoon Chung
On 08/23/2013 01:19 AM, Doug Anderson wrote:
Previously the dw_mmc driver would ignore any requests to disable the
card's clock. This doesn't seem like
Hi Doug,
On 08/24/2013 05:40 AM, Doug Anderson wrote:
Jaehoon,
On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Doug,
If the clock-gating is enabled, then maybe it's continuously printed the
kernel message for Bus_speed.
Can you explain? I don't think
origin code rather than programming clock setting to
'0'?
Right, Dw-mmc controller can use the Low-power mode.
This mode is functionality like clock-gating. Well, i didn't know what benefit
we get, if set to 0.
Best Regards,
Jaehoon Chung
+} else if (slot-clock != host-current_speed
didn't have responsibility to ensure whether power is
enabled or not at probing time.
If just needed to balance vreg, then i think this function can be removed.
How about?
Also before using regulator_is_enabled(), i had found the hole for balancing
the vreg.
Best Regards,
Jaehoon Chung
On 08/21
Hi Georgi,
I found the you use the vreg-is_enabled.
why don't you use the regulator_is_enabled()? i think better that use this
function.
Is there a special reason that use the vreg-is_enabled?
Best Regards,
Jaehoon Chung
On 08/13/2013 11:06 PM, Georgi Djakov wrote:
This platform driver adds
Hi Doug,
I think these patch-set didn't base on latest mmc-next.
If you can rebase on latest mmc-next, it's helpful to me for testing.
Best Regards,
Jaehoon Chung
On 07/11/2013 12:42 AM, Doug Anderson wrote:
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up
looping around
Hi All,
I tested with Seungwon's patch and this patch.
I'm agreed with Seungwon's opinion.
Best Regards,
Jaehoon Chung
On 06/18/2013 09:36 PM, Seungwon Jeon wrote:
On Thursday, June 13, 2013, Doug Anderson wrote:
Seungwon,
On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon tgih@samsung.com
Hi Doug,
I'm researching for fixed-rate-clocks.
Maybe i misunderstood for using fixed-rate-clocks. :)
Best Regards,
Jaehoon Chung
On 06/19/2013 12:15 AM, Doug Anderson wrote:
Jaehoon,
On Mon, Jun 17, 2013 at 9:51 PM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Doug,
I have one
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 07/30/2013 10:33 PM, Seungwon Jeon wrote:
On Tue, July 30, 2013, Mark Brown wrote:
From: Mark Brown broo...@linaro.org
Use regulator_get_optional() to tell the core that requests for regulators
can fail in a real
-type is always MMC_TYPE_SDIO or
MMC_TYPE_SD_COMBO, isn't?
Best Regards,
Jaehoon Chung
+ }
+
+ if (clk_en_a != clk_en_a_old) {
+ mci_writel(host, CLKENA, clk_en_a);
+ mci_send_cmd(slot, SDMMC_CMD_UPD_CLK
On 10/17/2013 05:23 AM, James Hogan wrote:
Hi Doug,
On 16 October 2013 17:43, Doug Anderson diand...@chromium.org wrote:
On Wed, Oct 16, 2013 at 2:49 AM, James Hogan james.ho...@imgtec.com wrote:
We can't just use the standard host-lock since that lock is not irq
safe and
Hi, Felipe.
When you send the patch related with dw_mmc controller, could you use the
prefix mmc: dw_mmc:?
mmc: dw_mmc: fix possible build error
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 02/25/2014 11:57 PM, Felipe Balbi wrote:
Fix the following build
Hi,
You can refer to this.
http://comments.gmane.org/gmane.linux.kernel.mmc/23838
Best Regards,
Jaehoon Chung
On 02/19/2014 10:47 PM, Zhang Yi wrote:
Current code will exist when read eMMC 5.0, add support for it
Signed-off-by: Zhang Yi yix.x.zh...@gmail.com
---
mmc_cmds.c |3
ensure to set the clock-frequency value.
Best Regards,
Jaehoon Chung
On 06/08/2013 02:28 AM, Doug Anderson wrote:
As of now we rely on code outside of the driver to set the ciu clock
frequency. There's no reason to do that. Add support for setting up
the clock in the driver during probe
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 06/03/2013 07:58 AM, Heiko Stübner wrote:
dw_mci_pltfm_remove gets exported and used by dw_mmc-exynos, so should
not be static.
Signed-off-by: Heiko Stuebner he...@sntech.de
---
drivers/mmc/host/dw_mmc-pltfm.c |2 +-
1 files changed
On 06/03/2013 07:59 AM, Heiko Stübner wrote:
Cortex-A9 SoCs from Rockchip use a slightly modified variant of dw_mmc
controllers that seems to require the SDMMC_CMD_USE_HOLD_REG bit to
always be set.
There also seem to be no other modifications (additional register etc)
present, so to keep
Looks good to me. If you can add the usage example, it will be more helpful to
me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 06/07/2013 01:46 PM, Doug Anderson wrote:
As of now we rely on code outside of the driver to set the ciu clock
frequency. There's no reason to do that. Add
Hi Seungwon,
I didn't get the same result..In my case, it's working fine.
But as Bing's result, i will check more and share the result.
Best Regards,
Jaehoon Chung
On 06/26/2013 10:53 AM, Seungwon Jeon wrote:
Hi Jaehoon,
Do you have the same result?
Could you share the result?
Thanks
Hi Felipe,
I didn't understand this patch, why need to add set_power?
We can use to control the power with the fixed regulator.
Then we can also use the regulator framework.
And i know also control the module like wifi with rfkill.
In set_power, what is it controlled?
Best Regards,
Jaehoon Chung
regulator support.
We can use the regulator framework.
i think this callback function didn't need.
Best Regards,
Jaehoon Chung
I've seen this implementation in others mmc hosts, such as omap.
Which, however, doesn't yet mean, it's a good idea :)
Thanks
Guennadi
---
Guennadi Liakhovetski
Hi, Chanho.
I remembered Shawn Guo had posted this patch.
Do you resend it?
Best Regards,
Jaehoon Chung
On 09/06/2013 03:01 PM, Chanho Min wrote:
This patch supports non-blocking mmc request function for the sdchi driver.
(commit: aa8b683a7d392271ed349c6ab9f36b8c313794b7)
pre_req() runs
Hi, All.
This patch is working on progress?
I want to merge this patch for fixing dw-mmc controller problem.
If this patch didn't work on progress, i will send the patch based-on this
patch.
Best Regards,
Jaehoon Chung
On 05/14/2014 06:53 PM, Ulf Hansson wrote:
On 7 May 2014 12:06, Ludovic
dw-mmc controller can be support the multiple slot.
So each slot's property can be difference.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
---
arch/arm/boot/dts/exynos4412-odroidx.dts |2 +-
arch/arm/boot/dts/exynos4412-origen.dts |2 +-
arch/arm/boot/dts/exynos4412
This patch-set is fixed the dw-mmc controller problem.
dw-mmc controller have the slot, but mmc_of_parse didn't parse the slot
sub-node.
So dw-mmc controller didn't work correctly.
Jaehoon Chung (2):
mmc: dw_mmc: use the __mmc_of_parse to parse the slot node
ARM: dts: replace the broken-cd
-by: Ludovic Desroches ludovic.desroc...@atmel.com
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
---
drivers/mmc/core/host.c | 13 +
include/linux/mmc/host.h | 10 +-
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core
dw-mmc controller have the multiple slot.
Then it needs to parse the property for each slot.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
---
drivers/mmc/host/dw_mmc.c | 25 ++---
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/drivers/mmc/host
Hi, Ludovic.
I have sent the patch based on your RFC patch..how about?
If you have the comment or other opinion, let me know, plz.
https://patchwork.kernel.org/patch/4230101/
It needs to use your suggestion at dw-mmc controller, so i have posted it.
Best Regards,
Jaehoon Chung
On 05/26/2014
Hi,
On 05/26/2014 05:09 PM, Ludovic Desroches wrote:
On Fri, May 23, 2014 at 07:25:19PM +0900, Jaehoon Chung wrote:
From: Ludovic Desroches ludovic.desroc...@atmel.com
Some hosts manage several slots. In these case information such as the
bus width, chi detect and others are into the slot
Hi, Ulf.
On 05/26/2014 05:44 PM, Ulf Hansson wrote:
On 26 May 2014 10:38, Jaehoon Chung jh80.ch...@gmail.com wrote:
Hi,
On 05/26/2014 05:09 PM, Ludovic Desroches wrote:
On Fri, May 23, 2014 at 07:25:19PM +0900, Jaehoon Chung wrote:
From: Ludovic Desroches ludovic.desroc...@atmel.com
Some
)
continue;
if (slot-mmc-pm_flags MMC_PM_KEEP_POWER) {
dw_mci_set_ios(slot-mmc, slot-mmc-ios);
- dw_mci_setup_bus(slot, true);
If we need not to call dw_mci_setup_bus() at here,
the we can also remove the force_clkinit.
Best Regards,
Jaehoon Chung
.
host-bus_hz /= RK3288_CLKGEN_DIV;
Best Regards,
Jaehoon Chung
+
+ return 0;
+}
+
+static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios)
+{
+ int ret;
+ unsigned int cclkin;
+
+ /*
+ * cclkin: source clock of mmc controller.
+ * bus_hz
Looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 06/24/2014 10:57 PM, Tomasz Figa wrote:
For internal card detection mechanism it is required that the local I/O
clock is always running. However while current implementation accounts
for this, it does so incorrectly leading
Hi, Lukas.
I think it's reasonable. And CC'd Ulf.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 07/14/2014 05:10 PM, Lukáš Czerner wrote:
On Wed, 18 Jun 2014, Lukas Czerner wrote:
Date: Wed, 18 Jun 2014 13:18:07 +0200
From: Lukas Czerner lczer...@redhat.com
On 07/15/2014 11:54 AM, Fu, Zhonghui wrote:
Hi,
The data type of host is struct mmc_host, and there is not quirks
member in this structure.
Sorry for wrong typo.
You use the host-caps2 instead of host-quirks.
Best Regards,
Jaehoon Chung
Thanks,
Zhonghui
On 2014/7/14 21:26, Chris
, but left in an
unconditional wake_up_process() on that handler at resume-time.
Reported-by: Fu, Zhonghui zhonghui...@linux.intel.com
[Patch suggested by Jaehoon Chung]
Signed-off-by: Chris Ball ch...@printf.net
---
drivers/mmc/core/sdio.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion
Hi,
just use the MMC_CAP2_SDIO_IRQ_NOTHREAD?
if (!err host-sdio_irq !(host-quirks MMC_CAP2_SDIO_IRQ_NOTHREAD))
wake_up_process(host-sdio_irq_thread);
I didn't test this..but i believe that it will be fixed.
Best Regards,
Jaehoon Chung
On 07/04/2014 12:47 AM, Fu, Zhonghui wrote
);
+ }
+ }
If you enable the sdio_irq, I think it needs to check whether MMC_CAP_SDIO_IRQ
is set or not.
Best Regards,
Jaehoon Chung
+
mmc_release_host(host);
host-pm_flags = ~MMC_PM_KEEP_POWER;
-- 1.7.1
On 2014/7/15 12:40, Jaehoon Chung wrote:
From: Chris Ball ch
Looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 08/26/2014 03:19 AM, Doug Anderson wrote:
It's possible that mmc_of_parse() could return errors (possibly in
some future version it might return -EPROBE_DEFER even). Let's pass
those errors back
apply this one now, too? Do you want me to
repost?
It's good that it will be merged with it.
Best Regards,
Jaehoon Chung
-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hi, Doug.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 08/07/2014 02:09 AM, Doug Anderson wrote:
This series adds basic eMMC and SD card support for the rk3288-evb
board based on Addy's posted dw_mmc patch from:
https://patchwork.kernel.org/patch/4653631/
The series is a little
Hi,
I remembered that this patch was pushed at Ulf's tree.
Since dw_mci_idmac_reset() is located into #if CONFIG_MMC_DW_IDMAC,
it occurred the compiler error.
And it seems that didn't need to use IS_ENABLED() at there.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 07/31/2014 03:01 PM, Addy Ke wrote:
This patch focuses on clock setting for RK3288 mmc controller.
In RK3288 mmc controller, CLKDIV register can only be set 0 or 1,
and if DDR 8bit mode, CLKDIV register must
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 08/19/2014 01:36 PM, Addy Ke wrote:
To support HS200 and UHS-1, we need add a big hunk of code,
as shown in the following patches. So a separate file for
rockchip SOCs is suitable.
Signed-off-by: Addy Ke addy
Dear, Doug.
On 10/23/2014 01:36 AM, Doug Anderson wrote:
Hi,
On Sun, Oct 19, 2014 at 8:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi.
On 10/17/2014 09:44 PM, Alim Akhtar wrote:
Hi Doug,
On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson diand...@chromium.org
wrote:
Alim,
On Thu
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 10/11/2014 01:16 PM, Doug Anderson wrote:
In (28f92b5 mmc: core: Try other signal levels during power up) we can
see that there are times when it's valid to try several signal
voltages. Don't print an ugly error
Hi, Doug.
It looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 10/15/2014 01:39 AM, Doug Anderson wrote:
The set_ios function is called with a clock of 0 when the clock is
turning off. There's no reason to go through all the extra Rockchip
logic (whose goal is to make sure
will check this patch with 2.70a and other version.
Best Regards,
Jaehoon Chung
+
+ u32 des2; /*Buffer sizes */
+#define IDMAC_64ADDR_SET_BUFFER1_SIZE(d, s) \
+ ((d)-des2 = ((d)-des2 0x03ffe000) | ((s) 0x1fff))
+
+ u32 des3; /* Reserved
Hi, Doug.
Looks good to me.
Tested-by: Jaehoon Chung jh80.ch...@samsung.com
with exynos3/4 series.
Need to check exynos5 with using other card detect mechanism.
Best Regards,
Jaehoon Chung
On 10/15/2014 01:33 AM, Doug Anderson wrote:
The dw_mmc driver had a bunch of code that ran whenever
Hi, Doug.
Add one comment.
On 10/16/2014 05:19 PM, Jaehoon Chung wrote:
Hi, Doug.
Looks good to me.
Tested-by: Jaehoon Chung jh80.ch...@samsung.com
with exynos3/4 series.
Need to check exynos5 with using other card detect mechanism.
Best Regards,
Jaehoon Chung
On 10/15/2014 01
On 10/16/2014 08:09 PM, Vivek Gautam wrote:
Hi Prabu,
On Thu, Oct 16, 2014 at 4:09 PM, Prabu Thangamuthu prab...@synopsys.com
wrote:
Hi Jaehoon, Vivek, Alim,
Thanks for your review comments.
On Thu, Oct 16, 2014 at 12:20 PM, Jaehoon Chung jh80.ch...@samsung.com
wrote:
Hi, Prabu
5800 with HS200 and didn't notice any
difference in sequential read throughput.
Didn't affect the write throughput?
I tested this on exynos3/4 with DDR50 and HS200.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Tested-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Sonny Rao sonny
.
If you see some other requirement than the one I addressed in my email
to Jaehoon, please let me know.
I know there is no other requirement for detecting card.
So this patch can be applied after testing the above case(suspend/resume).
Best Regards,
Jaehoon Chung
Well, as most of the current CD
Doug,
On 09/05/2014 04:21 AM, Doug Anderson wrote:
Jaehoon,
On Wed, Sep 3, 2014 at 10:21 PM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Doug
On 09/03/2014 08:37 AM, Doug Anderson wrote:
On dw_mmc there's a small race if you happen to get a card detect
interrupt at just the wrong time
On 09/05/2014 06:22 AM, Stephen Boyd wrote:
On 09/04/14 03:53, Ulf Hansson wrote:
On 4 September 2014 07:06, Jaehoon Chung jh80.ch...@samsung.com wrote:
In dw-mmc.c, tuning_block values are same.
So I think we can move these value into generic header. how about?
Actually, I believe
;
+ } else {
+ card-ext_csd.partition_setting_completed = 0;
+ }
I remembered that Ulf mentioned these brackets can be removed.
Best Regards,
Jaehoon Chung
+
mmc_manage_enhanced_area(card, ext_csd);
mmc_manage_gp_partitions(card
0x45 ? Just example.:)
And Your first patch is applied for every Sandisk card, isn't?
Best Regards,
Jaehoon Chung
MMC_FIXUP(SEM02G, 0x45, CID_OEMID_ANY, add_quirk, MMC_QUIRK_INAND_CMD13) ?
If so, can I use :
if (card-quirks MMC_QUIRK_INAND_CMD38)
msleep(1);
In drivers/mmc/core
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 10/07/2014 03:11 AM, Doug Anderson wrote:
Sonny,
On Mon, Oct 6, 2014 at 10:53 AM, Sonny Rao sonny...@chromium.org wrote:
We've already got a reset of DMA after it's done. Add one before we
start DMA too. This fixes a data corruption
,
EXT_CSD_DDR_BUS_WIDTH_8,
@@ -1084,6 +1089,8 @@ static int mmc_select_hs400(struct mmc_card *card)
return err;
}
+ mmc_set_timing(card-host, MMC_TIMING_MMC_DDR52);
+
I didn't know why timing is set to ddr50.
Best Regards,
Jaehoon Chung
err = __mmc_switch(card
spec(6.6.5).
There is no mention that mode needs to change to DDR mode.
And i know HS400 mode is only support the 8bit buswidth.
If HS200 mode was set to 4bit buswidth, is HS400 working fine?
Best Regards,
Jaehoon Chung
-Original Message-
From: Jaehoon Chung [mailto:jh80.ch
method than now?
Best Regards,
Jaehoon Chung
+ sdio_int_bit = SDMMC_INT_SDIO_24BIT(slot-id);
+ else
+ sdio_int_bit = SDMMC_INT_SDIO(slot-id);
/* We must continue to set bit 28 in CMD until the change is complete */
if (host-state
Hi, Addy.
This patch is conflicted..Could you rebase on latest Ulf's tree?
Best Regards,
Jaehoon Chung
On 10/30/2014 07:50 PM, Addy Ke wrote:
The bit of sdio interrupt is 16 in designware implementation,
but it is 24 in RK3288. This patch add sdio_id0 for the number
of slot0 in the SDIO
on rock-chip board.
Best Regards,
Jaehoon Chung
Kind regards
Uffe
Signed-off-by: Addy Ke addy...@rock-chips.com
---
drivers/mmc/host/dw_mmc-rockchip.c | 13 +
drivers/mmc/host/dw_mmc.c | 12 +++-
drivers/mmc/host/dw_mmc.h | 2 ++
include/linux
Hi,
On 10/31/2014 09:46 AM, addy ke wrote:
Hi, Jaehoon
On 2014/10/30 19:02, Jaehoon Chung wrote:
Hi, Addy.
This patch is conflicted..Could you rebase on latest Ulf's tree?
I have not found ulf's tree in git.kernel.org.
I can't 'git clone git://git.kernel.org/pub/scm/linux/kernel/git/ulf
-slot0 = 8;
I have a question. (It's not important question)
You mentioned the sdio-irq bit used from 24 to 31, right?
Then what interrupts are used from 16 to 23 at RK3288? Just reserved?
Best Regards,
Jaehoon Chung
Signed-off-by: Addy Ke addy...@rock-chips.com
---
Changes in v2:
- rebase
Hi,
On 09/22/2014 02:48 AM, Pavel Machek wrote:
On Mon 2014-09-15 19:44:28, Jaehoon Chung wrote:
On 09/15/2014 07:08 PM, Jean-Michel Hautbois wrote:
Hi Jaehoon,
On 09/09/2014 09:26 PM, Jean-Michel Hautbois wrote:
Tested on a i.MX6 board, with Sandisk SDIN5D1-2G.
Without this patch, I/O
Hi, Addy.
On 11/18/2014 09:32 AM, Addy wrote:
On 2014年11月14日 21:18, Jaehoon Chung wrote:
Hi, Addy.
Did you use the DW_MCI_QUIRK_IDMAC_DTO?
I'm not sure, but i wonder if you get what result when you use above quirk.
DW_MCI_QUIRK_IDMAC_DTO is only for version2.0 or below
(+)
This seems quite sane to me.
Reviewed-by: Doug Anderson diand...@chromium.org
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
1 - 100 of 965 matches
Mail list logo
