hy: samsung: Add support for the Exynos5420 variant of
> the USB2 PHY")
> Signed-off-by: Marek Szyprowski
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> Vinod: this a fix to the patch merged yesterday. If you want me to resend
> a fixed initi
roduced aliases for mmcblk devices from commit fa2d0aa96941
> ("mmc: core: Allow setting slot index via device tree alias").
>
> Suggested-by: Markus Reichl
> Signed-off-by: Marek Szyprowski
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> arc
roduced aliases for mmcblk devices from commit fa2d0aa96941
> ("mmc: core: Allow setting slot index via device tree alias").
>
> Suggested-by: Markus Reichl
> Signed-off-by: Marek Szyprowski
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> arch/arm/b
est Regards,
Jaehoon Chung
>
> Signed-off-by: Tian Tao
> ---
> drivers/mmc/host/dw_mmc.c | 17 -
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 43c5795..a524443 100644
> -
Dear Jingoo,
On 10/24/20 12:12 PM, Jingoo Han wrote:
> On 10/23/20, 3:58 AM, Marek Szyprowski wrote:
>>
>> From: Jaehoon Chung
>>
>> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
>> dts: exynos: Remove Exynos5440"). Rework
sdhci_s3c'
> drivers/mmc/host/sdhci-s3c.c:139: warning: Function parameter or member
> 'no_divider' not described in 'sdhci_s3c_drv_data'
>
> Cc: Adrian Hunter
> Cc: Ben Dooks
> Cc: Jaehoon Chung
> Signed-off-by: Lee Jones
Reviewed-by: Jaehoon Chung
or member
> 'dev' not described in 'dw_mci_exynos_suspend_noirq'
> drivers/mmc/host/dw_mmc-exynos.c:200: warning: Function parameter or member
> 'dev' not described in 'dw_mci_exynos_resume_noirq'
>
> Cc: Jaehoon Chung
> Cc: Kukj
Hi Minas,
On 2/14/19 8:43 PM, Minas Harutyunyan wrote:
> Hi Jaehoon Chung,
>
> On 2/14/2019 2:04 PM, Jaehoon Chung wrote:
>> This patch is referred to Robert's patch
>> commit cf54772b913b ("usb: dwc2: call dwc2_is_controller_alive() under
>> spinlock&quo
ever trigger the usb interrupt.
Signed-off-by: Jaehoon Chung
---
drivers/usb/dwc2/hcd_intr.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
index 88b5dcf..8d3b155 100644
--- a/drivers/usb/dwc2/hcd_intr.c
+++ b/drivers
Hi,
On 05/02/2018 03:19 AM, Liming Sun wrote:
> This commit adds extension to the dw_mmc driver for Mellanox BlueField
> SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on
> this SoC.
Could you heck Shawn's comments? And add the minor comment.
>
> Cc: sta...@kernel.org
> Sign
ns.
> * Use timing field in each slot structure instead of common field in
>host structure.
> * Add locks to serialize access to registers.
Sorry for late. :(
Well, I will read the other comments..and reply soon.
Best Regards,
Jaehoon Chung
>
> NOTE: this patch is based off of v4.
On 03/15/2018 07:22 PM, Ulf Hansson wrote:
> On 23 February 2018 at 07:41, Jaehoon Chung wrote:
>> 'clock-freq-min-max' property had already deprecated.
>> Remove the 'clock-freq-min-max' property that is kept to maintain
>> the compatibility.
>&g
Dear Lorenzo,
On 03/13/2018 08:12 PM, Lorenzo Pieralisi wrote:
> Hi Jaehoon,
>
> On Thu, Dec 21, 2017 at 09:14:06PM +0900, Jaehoon Chung wrote:
>> PCI_EXYNOS has the dependency with SOC_EXYNOS5440.
>> It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other
gwoo.
https://patchwork.kernel.org/patch/9344477/
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Jinbum Park
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/boot/compressed/Makefile | 1 +
> arch/arm/vdso/Makefile| 1 +
> 3 files changed, 3 inserti
On 03/13/2018 01:53 PM, Jinbum Park wrote:
> To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected.
>
> Basic test has passed on Raspberry Pi2, Raspbian jessi lite with
> CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL.
>
> Signed-off-by: Jinbum Park
> ---
> arch/arm/Kconfig
bgcc and so
>> code gets compiled on all 32-bit platforms as opposed to usage
>> of DIV_ROUND_UP when we may only compile stuff on a very few arches.
>>
>> Lets cast this multiply to u64 type which prevents overflow.
>
> Reviewed-by: Jisheng Zhang
Acked-by: Jaeho
On 02/27/2018 08:36 PM, Jaehoon Chung wrote:
> On 02/27/2018 08:28 PM, Ulf Hansson wrote:
>> On 23 February 2018 at 07:30, Jaehoon Chung wrote:
>>> On 02/23/2018 10:40 AM, Shawn Lin wrote:
>>>> Hi Alexey,
>>>>
>>>> On 2018/2/23 3:45, Alexey
On 02/27/2018 08:28 PM, Ulf Hansson wrote:
> On 23 February 2018 at 07:30, Jaehoon Chung wrote:
>> On 02/23/2018 10:40 AM, Shawn Lin wrote:
>>> Hi Alexey,
>>>
>>> On 2018/2/23 3:45, Alexey Roslyakov wrote:
>>>> cur_slot and num_slots has
On 02/24/2018 01:16 AM, Andy Shevchenko wrote:
> On Fri, Feb 23, 2018 at 4:19 PM, Shawn Lin wrote:
>> On 2018/2/23 21:27, Andy Shevchenko wrote:
>>> On Fri, Feb 23, 2018 at 8:41 AM, Jaehoon Chung
>>> wrote:
>>>>
>>>> 'clock-freq-min-max&
Since 'num-slots' had already deprecated, remove the property in
device-tree file.
Signed-off-by: Jaehoon Chung
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
b/arch/
Since 'num-slots' had already deprecated, remove the property in
device-tree file.
Signed-off-by: Jaehoon Chung
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
b/arch/arm64/boot/dts/hisili
Since 'num-slots' had already deprecated, remove the property in
device-tree file.
Signed-off-by: Jaehoon Chung
---
arch/arm/boot/dts/lpc18xx.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi
index 7cae9c5e27db..10
Since 'num-slots' had already deprecated, remove the property in
device-tree file.
Signed-off-by: Jaehoon Chung
---
arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dts | 1 -
arch/arm/boot/dts/socfpga_arria5.dtsi | 1 -
arch/arm/boot/dts/socfpga_cyclone5.dtsi | 1 -
'clock-freq-min-max' property had already deprecated.
Remove the 'clock-freq-min-max' property that is kept to maintain
the compatibility.
Signed-off-by: Jaehoon Chung
---
.../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 4
drive
'num-slots' property had already deprecated.
Remove the 'nom-slots' property that is kept to maintain the compatibility.
Signed-off-by: Jaehoon Chung
---
Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 5 -
drivers/mmc/host/dw_mmc-pci.c
>
>> Fix this by adding a range check.
>>
>> Fixes: 7d92895208a008a2 ("mmc: dw_mmc-k3: Fix out-of-bounds access through
>> DT alias")
>
> Oops
>
> Fixes: 361c7fe9b02eee7e ("mmc: dw_mmc-k3: add sd support for hi3660")
Could you resen
On 01/03/2018 01:34 AM, Lorenzo Pieralisi wrote:
> On Wed, Dec 27, 2017 at 06:43:27PM +0900, Jaehoon Chung wrote:
>> pci-exynos had updated to use the PHY framework.
>> (drivers/phy/samsung/phy-exynos-pcie.c)
>> Removed the depreccated codes relevant to phy in pci-exynos.c.
&g
pci-exynos had updated to use the PHY framework.
(drivers/phy/samsung/phy-exynos-pcie.c)
Removed the depreccated codes relevant to phy in pci-exynos.c.
Instead, use the phy-exynos-pcie.c file.
Modified the binding documentation.
Signed-off-by: Jaehoon Chung
---
.../bindings/pci/samsung
On 12/27/2017 06:11 AM, Rob Herring wrote:
> On Thu, Dec 21, 2017 at 09:14:07PM +0900, Jaehoon Chung wrote:
>> Exynos5433 has the PCIe for WiFi.
>> Added the codes relevant to PCIe for supporting the exynos5433.
>> Also changed the binding documentation name to
>&g
Hi Jingoo,
On 12/22/2017 01:12 AM, Jingoo Han wrote:
> On Thursday, December 21, 2017 7:14 AM, Jaehoon Chung wrote:
>>
>> Exynos5433 has the PCIe for WiFi.
>> Added the codes relevant to PCIe for supporting the exynos5433.
>> Also changed the binding documentation
Exynos5433 has the PCIe for WiFi.
Add the codes relevant to PCIe for supporting the exynos5433.
Also changed the binding documentation name to
'samsung,exynos-pcie.txt'.
(It's not only exynos5440 anymore.)
Signed-off-by: Jaehoon Chung
---
...exynos5440-pcie.txt => samsung,exyn
Exynos5433 has the PCIe for WiFi.
Added the codes relevant to PCIe for supporting the exynos5433.
Also changed the binding documentation name to
'samsung,exynos-pcie.txt'.
(It's not only exynos5440 anymore.)
Signed-off-by: Jaehoon Chung
---
...exynos5440-pcie.txt => samsu
PCI_EXYNOS has the dependency with SOC_EXYNOS5440.
It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other
SoCs needs to use this driver.
Signed-off-by: Jaehoon Chung
---
drivers/pci/dwc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/dwc/Kc
eviewed by Shawn. I'm happy to re-post with
> collected tags or anything else you'd like. It would be nice to get
> the regression fixed sooner rather than later...
Sorry. I didn't find this email in my mail-box. so i lost this.
Current i'm reading the comment history..Sorry for late.
Best Regards,
Jaehoon Chung
>
> Thanks! :)
>
> -Doug
>
>
>
slots. If 0, the host->num_slots will be
> set to 1. So the logic of setting default num_slots seems already there. But
> correct me if I am wrong.
>
> Thanks,
> Liming
>
> -Original Message-
> From: Shawn Lin [mailto:shawn@rock-chips.com]
> Sent: Mon
nts.
>
> Major changes in v3:
> - solve review comments from Heiner Kallweit.
>*use the GENMASK and FIELD_PREP macros replace the bit shift operation.
>*use usleep_range() replace udelay() and mdelay().
>
> Major changes in v4:
> - solve review comments from Jaeho
Hi,
On 06/12/2017 11:27 PM, Jaehoon Chung wrote:
> Hi Li,
>
> On 2017년 06월 12일 16:46, liwei wrote:
>> Add sd card support for hi3660 soc
>>
>> Major changes in v3:
>> - solve review comments from Heiner Kallweit.
>>*use the GENMASK and FIELD_PREP
"clock-freq-min-max" was deprecated. There is only using in rv1108.dtsi.
Use the "max-frequency" for removiing "clock-freq-min-max" in future.
Signed-off-by: Jaehoon Chung
---
Changelog on V2:
- Rebased on Heiko's git repository (v4.13-armsoc/dts32 branch)
Hi,
On 06/06/2017 10:15 AM, Andy Yan wrote:
> Hi Jaehoon:
>
>
> 2017-06-01 12:43 GMT+08:00 Jaehoon Chung :
>
>> "clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi.
>> Use the "max-frequency" for removiing "clock-freq-mi
"clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi.
Use the "max-frequency" for removiing "clock-freq-min-max" in future.
Signed-off-by: Jaehoon Chung
---
arch/arm/boot/dts/rk1108.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(
On 05/27/2017 06:53 AM, David Woods wrote:
> Using the device_property interfaces allows the dw_mmc driver to work
> on platforms which run on either device tree or ACPI.
>
> Signed-off-by: David Woods
> Reviewed-by: Chris Metcalf
> Cc: sta...@vger.linux.org
Acked-by: Ja
previously used to
> print the message.
I think you are not using the latest kernel. which version do you use?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9
Could you check this?
Best Regards,
Jaehoon Chung
>
> Fixes
his). We probably wouldn't actually want to fully runtime
> suspend in this case though--at least not with the current
> dw_mci_runtime_resume() which basically fully resets the controller at
> resume time.
>
> Fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback")
card->ext_csd.generic_cmd6_time);
> + if (err && err != -EBADMSG)
> + pr_warn("%s: Enabling RST_N feature failed\n",
> + mmc_hostname(card->host));
> + }
If enabled hw-reset, it doesn't need to re-enable this bit.
i didn't check the mmc-util..
If mmc-util provides the changing this, the using mmc-util is better than this.
Best Regards,
Jaehoon Chung
> +
> if (!oldcard)
> host->card = card;
>
>
know ext_csd revision information,
attribute name might be more clearly.
e,g) ext_csd_rev?
It's my preference. :)
Best Regards,
Jaehoon Chung
> MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
> MMC_DEV_ATTR(life_time, "0x%02x 0x%02
There are same conditions for checking whether supporting clkscaling or
not.
When ufshcd is supporting clkscaling, active_reqs should be decreased by
two.
Signed-off-by: Jaehoon Chung
---
drivers/scsi/ufs/ufshcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b
so unconditional calls to
>>> reset_control_assert, with disabled RESET_CONTROLLER it will cause
>>> unexpected WARNs.
>>> Anyway if you change reset API as above I think you should remove all
>>> warns from reset stubs, because NULL reset is valid, but these warns are
>>> there for reason - contradiction.
>>
>> You are right, I have to let go of those, too.
>
>
> Until fixed, I have dropped the three changes from my next branch
> related to this. Please re-post when fixed.
I missed this patch. If resend the patch, i will check.
Best Regards,
Jaehoon Chung
>
> Kind regards
> Uffe
>
>>
>> regards
>> Philipp
>>
>
>
>
hen-Yu Tsai
> Cc: Sylwester Nawrocki
> Cc: Krzysztof Kozlowski
> Cc: Jaehoon Chung
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-arm-...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-o...@vger.kernel.org
> Cc: linux-renesas-...@vger.kernel.org
> Cc
Hi Vivek,
On 03/12/2017 06:18 PM, Vivek Gautam wrote:
> Hi Kishon,
>
>
> On Thu, Mar 9, 2017 at 5:26 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>> Make the "samsung" directory and
Hi All,
On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote:
> On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>> Make the "samsung" directory and move the Samsung specifi
Make the "samsung" directory and move the Samsung specific files to
there for maintaining the files relevant to Samsung.
Signed-off-by: Jaehoon Chung
---
drivers/phy/Kconfig | 96 +--
drivers/phy/Makefile
When it doesn't get the blk_base's resource, it was returned
the error about phy_base, not blk_base.
This patch is for fixing the wrong error return about blk_base.
Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY")
Signed-off-by: Jaehoon Chung
Even though using phy framework, it has to get the elbi_base.
Before this patch, elbi_base should be NULL pointer.
Fixes: e7cd7ef58e1f ("PCI: exynos: Support the PHY generic framework")
Signed-off-by: Jaehoon Chung
---
drivers/pci/dwc/pci-exynos.c | 8
1 file changed, 4
On 03/03/2017 08:38 PM, Sergio Prado wrote:
> On Fri, Mar 03, 2017 at 11:14:29AM +0900, Jaehoon Chung wrote:
>> On 03/02/2017 10:18 AM, Sergio Prado wrote:
>>> Allows configuring Samsung S3C24XX MMC/SD/SDIO controller using a device
>>> tree.
>>
Board Specific Properties:
> +- pinctrl-0: Should specify pin control groups used for this controller.
> +- pinctrl-names: Should contain only one value - "default".
> +
> +Optional Properties:
> +- bus-width: number of data lines (see mmc.txt)
> +- cd-gpios: gpio for ca
t s3c2440_compatible;
> +};
I didn't understand why this structure needs.
Before this patch,
host->is2440;
After this patch,
host->variant->s3c2440_compatible;
Just add the one pointer for checking s3c2400 compatible..
Is it really meaningful?
(I didn't read the previous
uot;, "config".
- Can know the purpose of use with reg-names.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
---
Changelog on V3:
- Split from the patches relevant to pcie
- Modify the commit-message
- Keep the original comment in dt-file
- Send this patch after applying the other
Dear Bjorn,
On 02/16/2017 06:11 AM, Bjorn Helgaas wrote:
> On Mon, Feb 13, 2017 at 05:26:09PM +0900, Jaehoon Chung wrote:
>> This patcheset is for using PHY generic framework.
>> Current pci-exyns doesn't use the phy framework since there haven't been on
>> PHY sub
Hi Vivek,
On 02/15/2017 02:24 PM, Vivek Gautam wrote:
>
> On 02/13/2017 01:56 PM, Jaehoon Chung wrote:
>> This patch adds support for Generic PHY framework about Exynos SoCs.
>> Current Exynos PCIe driver doesn't use the PHY framework.
>> It's making a diff
the dependency
- Removes the unnecessary codes
- Change the patch's sequence
- Based on latest PCI git repository.(next branch)
Jaehoon Chung (4):
Documetation: samsung-phy: add the exynos-pcie-phy binding
phy: phy-exynos-pcie: Add support for Exynos PCIe phy
Documetation: binding: modi
y, can see "mssing *config* reg space" message.
Because the getting configuration space address from range is old way.
NOTE: When use the "config" property, first name of 'reg-names' must be
set to "elbi". Otherwise driver can't maintain the backward c
Adds the exynos-pcie-phy binding for Exynos PCIe PHY.
This is for using generic PHY framework.
Signed-off-by: Jaehoon Chung
Acked-by: Rob Herring
---
Changelog on V3:
- None
Changelog on V2:
- Remove the child node.
- Add 2nd address to the parent reg prop.
Documentation/devicetree/bindings
PHY Exynos PCIe
driver.
Signed-off-by: Jaehoon Chung
Acked-by: Krzysztof Kozlowski
Reviewed-by: Jingoo Han
Reviewed-by: Pankaj Dubey
---
Changelog on V3:
- Remove the dependency abot PCI_EXYNOS
- Adds a depends on COMPILE_TEST
- Use the readl_poll_timeout() instead of while()
- Fixes const t
Switch the pci-exynos driver to generic PHY framework. At the same time
backward compatibility is preserved: Warning will be printed for old
DTB.
Refer to the binding file:
- Documentation/devictree/bindings/pci/samsung,exynos5440-pcie.txt
Signed-off-by: Jaehoon Chung
Acked-by: Krzysztof
On 02/01/2017 06:16 AM, Jingoo Han wrote:
> On Saturday, January 28, 2017 4:28 PM, Bjorn Helgaas wrote:
>> On Mon, Jan 16, 2017 at 03:31:33PM +0900, Jaehoon Chung wrote:
>>> Current pci-exynos.c is used for only EXYNOS5440.
>>> It's too complex to support t
Hi John,
On 01/23/2017 08:24 PM, John Keeping wrote:
> Hi,
>
> On Fri, 20 Jan 2017 15:08:57 +0900, Jaehoon Chung wrote:
>> On 01/17/2017 10:38 PM, Romain Perier wrote:
>>> In my case I can reproduce the issue on the rock2 and the firefly-rk3288. A
>>> workarou
After that, i will decide whether revert or not.
Best Regards,
Jaehoon Chung
>
> Thanks,
> Romain
>
>
> Le 17/01/2017 à 14:28, Romain Perier a écrit :
>> Hello,
>>
>> This commit also breaks reboot and poweroff (the pmic no longer turn the
>> power sup
Hi,
On 01/16/2017 05:37 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 04 January 2017 06:04 PM, Jaehoon Chung wrote:
>> This patch supports to use Generic Phy framework for Exynos PCIe phy.
>> When Exynos that supported the pcie want to use the PCIe,
>>
Just use the bitops api to operate the bit.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- None
Changelog on V2:
- None
drivers/pci/host/pci-exynos.c | 24
1 file changed, 12 insertions(+), 12 deletions
Remove the unnecessary variables(elbi/phy/block_base).
It needs one resource structure for assigning each resource.
So it replaces with one 'res' variable.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- None
Changelog on
:
- Changes the all pointer names as "ep" instead of "exynos_pcie"
Jaehoon Chung (5):
PCI: exynos: Rename all pointer names from "exynos_pcie" to "ep"
PCI: exynos: Replace the *_blk/*_phy/*_elb accessors
PCI: exynos: Remove the unnecessary variabl
There is no reason to maintain *_blk/phy/elbi_* as register accessors.
It can be replaced to one accessor for maintaining more easier.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- Split from previous [PATCH V2 1/4]
&quo
Removed the duplicated codes.
It can use the more simply than now.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- None
Changelog on V2:
- None
drivers/pci/host/pci-exynos.c | 22 --
1 file changed, 8 insertions
Rename the simple pointer name as "ep" instead of "exynos_pcie".
After applying this patch, it can save the 10 characthers within one
line.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- Split from pr
Removed the duplicated codes.
It can use the more simply than now.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V2:
- None
drivers/pci/host/pci-exynos.c | 22 --
1 file changed, 8 insertions(+), 14 deletions
Remove the unnecessary variables(elbi/phy/block_base).
It needs one resource structure for assigning each resource.
So it replaces with one 'res' variable.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V2:
- None
drivers/pc
There is no reason to maintain *_blk/phy/elbi_* as register accessors.
It can be replaced to one register accessor.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V2;
- Changes the all pointer names as "ep" instead of &q
Just use the bitops api to operate the bit.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V2:
- None
drivers/pci/host/pci-exynos.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers
Hi Bjorn,
On 01/12/2017 03:50 AM, Bjorn Helgaas wrote:
> Hi Jaehoon,
>
> On Mon, Dec 19, 2016 at 05:16:11PM +0900, Jaehoon Chung wrote:
>> There is no reason to maintain *_blk/phy/elbi_* as register accessors.
>> It can be replaced to one register accessor.
>>
>
rmation as needed.
>>> The fix is on the way,
>>>
>>> https://patchwork.kernel.org/patch/9498527/
>> Great - thanks for letting me know.
>
> Can you share the result ?
Sorry for late. If it's working fine, I will apply it on fixes.
Best Regards,
Jaehoon
Hi Vivek,
On 01/10/2017 03:07 PM, Vivek Gautam wrote:
> Hi Jaehoon,
>
>
> On 01/04/2017 06:04 PM, Jaehoon Chung wrote:
>> This patch supports to use Generic Phy framework for Exynos PCIe phy.
>> When Exynos that supported the pcie want to use the PCIe,
>> it need
dw_mci_setup_bus(slot, true);
>>
>> So the spamming message about
>>
>> "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n"
>>
>> will always be there, right? So you could append a new patch to shut
>> up it as I think it's useless no matter for system pm or rpm to print
>> it. How about?
>
> Fine, it's favourable with dev_vdbg if the dw_mmc rpm is enabled.
> Hi Jaehoon,
> What's your opinion? If you think this patch and shawn's advice are
> acceptable, I will send the v5 patch.
I don't agreed to use dev_vdbg()..but it needs not to display at everytime.
Hmm..It needs to consider more..because we needs to see the clock value when
it's initialized.
Best Regards,
Jaehoon Chung
>
> BR
> Ziyuan Xu
>
>>
>>> }
>>>
>>> /* Now that slots are all setup, we can enable card detect */
>>>
>>
>>
>
>
>
>
>
different Exynos SoC.
>
> No functional change intended.
>
> Signed-off-by: Niyas Ahmed S T
> Signed-off-by: Pankaj Dubey
> Acked-by: Krzysztof Kozlowski
> Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> This pat
On 01/05/2017 02:50 AM, Krzysztof Kozlowski wrote:
> On Wed, Jan 04, 2017 at 09:34:34PM +0900, Jaehoon Chung wrote:
>> This patch is for using PHY generic framework.
>> To maintain backward compatibility, check whether phy is supported or
>> not with 'using_phy'.
&
On 01/05/2017 02:58 AM, Krzysztof Kozlowski wrote:
> On Wed, Jan 04, 2017 at 09:34:35PM +0900, Jaehoon Chung wrote:
>> Add phy-pcie node for using Exynos5440 pcie.
>> And use the reg-names as "elbi" and "config".
>
> 'and' is only for joining
On 01/05/2017 02:52 AM, Krzysztof Kozlowski wrote:
> On Wed, Jan 04, 2017 at 09:34:32PM +0900, Jaehoon Chung wrote:
>> This patch supports to use Generic Phy framework for Exynos PCIe phy.
>> When Exynos that supported the pcie want to use the PCIe,
>> it needs to control the
hread+0x60/0x548)
> [6.329215] [] (worker_thread) from []
> (kthread+0x128/0x158)
> [6.336614] [] (kthread) from []
> (ret_from_fork+0x14/0x24)
> [6.343836] Code: e52de004 e8bd4000 e3035d00 e34c50c0 (e5909004)
> [6.349974] ---[ end trace b2215a1ef671f11e ]---
Doesn't it need Shawn's Signed-off tag?
Best Regards,
Jaehoon Chung
>
> ---
>
> Changes in v2:
> - update the commit message
> - use dw_mci_reset instead of dw_mci_ctrl_reset
>
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deleti
s are keeping better than changing.
When someone contribute the patches relevant to these, it can be also changed,
(It's more meaningful.)
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Ziyuan Xu
> ---
>
> drivers/mmc/host/dw_mmc.c | 33 +
Adds the exynos-pcie-phy binding for Exynos PCIe PHY.
This is for using generic PHY framework.
Signed-off-by: Jaehoon Chung
---
Changelog on V2:
- Remove the child node.
- Add 2nd address to the parent reg prop.
Documentation/devicetree/bindings/phy/samsung-phy.txt | 17 +
1
Add phy-pcie node for using Exynos5440 pcie.
And use the reg-names as "elbi" and "config".
Because the getting configuratioin space address from ranges is old way.
It also is helpful to distinguish more clearly.
Signed-off-by: Jaehoon Chung
---
Changelog on V2:
- Removes th
or removing the dependency
- Removes the unnecessary codes
- Change the patch's sequence
- Based on latest PCI git repository.(next branch)
Jaehoon Chung (5):
Documetation: samsung-phy: add the exynos-pcie-phy binding
phy: phy-exynos-pcie: Add support for Exynos PCIe phy
Documetation:
This patch is for using PHY generic framework.
To maintain backward compatibility, check whether phy is supported or
not with 'using_phy'.
And if someone use the old dt-file, display the "deprecated" message.
But it's still working fine with it.
Signed-off-by: Jaehoon C
y, can see "mssing *config* reg space" message.
Because the getting configuration space address from range is old way.
NOTE: When use the "config" property, first name of 'reg-names' must be
set to "elbi". Otherwise driver can't maintain the backward c
pcie.
So this driver is based on Exynos5440 PCIe.
In future, will support the Other exynos SoCs likes exynos5433, exynos7.
Signed-off-by: Jaehoon Chung
---
Changelog on V2:
- Not include the codes relevant to pci-exynos.
- Remove the getting child node.
drivers/phy/Kconfig | 9
On 01/04/2017 04:51 AM, Rob Herring wrote:
> On Wed, Dec 28, 2016 at 07:34:53PM +0900, Jaehoon Chung wrote:
>> According to using PHY framework, modified the exynos5440-pcie binding.
>> And use "config" property to follow the designware-pcie binding.
>
> You
On 01/04/2017 03:05 AM, Rob Herring wrote:
> On Wed, Dec 28, 2016 at 07:34:52PM +0900, Jaehoon Chung wrote:
>> Adds the exynos-pcie-phy binding for Exynos PCIe PHY.
>> This is for using generic PHY framework.
>>
>> Signed-off-by: Jaehoon Chung
>> ---
>&g
On 12/31/2016 12:56 AM, Krzysztof Kozlowski wrote:
> On Wed, Dec 28, 2016 at 07:34:50PM +0900, Jaehoon Chung wrote:
>> This patch is for using PHY generic framework.
>> When Exynos5440 had upstreamed, there was no PHY subsytem.
>> Now the using PHY framework is mandantory.
On 12/30/2016 11:44 AM, Randy Li wrote:
>
>
> On 12/30/2016 10:35 AM, Jaehoon Chung wrote:
>> On 12/30/2016 12:07 AM, ayaka wrote:
>>>
>>>
>>> On 12/29/2016 10:04 PM, Jaehoon Chung wrote:
>>>> Hi,
>>>>
>>>> On 12/29/20
On 12/30/2016 12:07 AM, ayaka wrote:
>
>
> On 12/29/2016 10:04 PM, Jaehoon Chung wrote:
>> Hi,
>>
>> On 12/29/2016 09:55 PM, ayaka wrote:
>>> [5.849733] rk_gmac-dwmac ff29.ethernet (unnamed net_device)
>>> (uninitialized): Enable RX Mitig
1 - 100 of 487 matches
Mail list logo
