Re: [PATCH net-next v6 2/5] net/lapb: support netdev events

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 10:39:35 +0100 Martin Schiller wrote: > This patch allows layer2 (LAPB) to react to netdev events itself and > avoids the detour via layer3 (X.25). > > 1. Establish layer2 on NETDEV_UP events, if the carrier is already up. > > 2. Call lapb_disconnect_request() on

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 15:45:05 -0600 Alex Elder wrote: > On 11/22/20 5:40 PM, Rikard Falkeborn wrote: > > These are only used as input arguments to qmi_handle_init() which > > accepts const pointers to both qmi_ops and qmi_msg_handler. Make them > > const to allow the compiler to put them in

Re: [PATCH net-next v3 1/2] lockdep: Introduce in_softirq lockdep assert

2020-11-25 Thread Jakub Kicinski
cs due to the BH > disabled confusion, so add a comment to emphasize that. > > And the softirq context can be interrupted by hard IRQ or NMI > context, lockdep_assert_in_softirq() need to assert about hard > IRQ or NMI context too. > > Suggested-by: Jakub Kicinski > S

Re: [RESEND PATCH v3] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 07:56:08 +0530 Anant Thazhemadam wrote: > On 05/11/20 5:54 am, Jakub Kicinski wrote: > > On Mon, 2 Nov 2020 23:09:46 +0530 Anant Thazhemadam wrote: > >> Currently, __usbnet_{read|write}_cmd() use usb_control_msg(). > >> However, this could lead

Re: [RFC PATCH bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-05 Thread Jakub Kicinski
On Wed, 4 Nov 2020 20:51:39 -0800 Andrii Nakryiko wrote: > Add kernel module listener that will load/validate and unload module BTF. > Module BTFs gets ID generated for them, which makes it possible to iterate > them with existing BTF iteration API. They are given their respective module's >

Re: [RFC PATCH bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 17:46:16 +0100 Greg Kroah-Hartman wrote: > On Thu, Nov 05, 2020 at 08:39:25AM -0800, Jakub Kicinski wrote: > > On Wed, 4 Nov 2020 20:51:39 -0800 Andrii Nakryiko wrote: > > > Add kernel module listener that will load/validate and unload module BTF. > &g

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 13:36:56 + George Cherian wrote: > > Now i am a little bit skeptic here, devlink health reporter infrastructure > > was > > never meant to deal with dump op only, the main purpose is to > > diagnose/dump and recover. > > > > especially in your use case where you only

[GIT PULL] Networking

2020-11-05 Thread Jakub Kicinski
, rather than waiting indefinitely Misc: - IPv6: reply ICMP error if the first fragment don't include all headers to improve compliance with RFC 8200 Signed-off-by: Jakub Kicinski Alexander Ovechkin (1): ip6_tunnel: set

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Jakub Kicinski
On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote: > If you report an error without recovering, devlink health will report a > bad device state > > $ ./devlink health >pci/0002:01:00.0: > reporter npa >state error error 1 recover 0 Actually, the counter in the driver is

Re: [PATCH net-next] net: udp: introduce UDP_MIB_MEMERRORS for udp_mem

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 02:16:11 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > When udp_memory_allocated is at the limit, __udp_enqueue_schedule_skb > will return a -ENOBUFS, and skb will be dropped in __udp_queue_rcv_skb > without any counters being done. It's hard to find out

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Jakub Kicinski
On Thu, 05 Nov 2020 15:52:32 -0800 Saeed Mahameed wrote: > On Thu, 2020-11-05 at 12:42 -0800, Jakub Kicinski wrote: > > On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote: > > > If you report an error without recovering, devlink health will > > > repo

Re: [PATCH net-next v2 00/19] net: phy: add support for shared interrupts (part 1)

2020-11-05 Thread Jakub Kicinski
On Sun, 1 Nov 2020 14:50:55 +0200 Ioana Ciornei wrote: > From: Ioana Ciornei > > This patch set aims to actually add support for shared interrupts in > phylib and not only for multi-PHY devices. While we are at it, > streamline the interrupt handling in phylib. Applied, thank you!

Re: [PATCH net-next v2 RESEND] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-05 Thread Jakub Kicinski
On Wed, 4 Nov 2020 10:19:22 +0800 Hayes Wang wrote: > Support ECM mode based on cdc_ether with relative mii functions, > when CONFIG_USB_RTL8152 is not set, or the device is not supported > by r8152 driver. > > Both r8152 and r8153_ecm would check the return value of > rtl8152_get_version() in

Re: [PATCH v3 net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-05 Thread Jakub Kicinski
On Wed, 4 Nov 2020 19:22:13 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjphase() to support PHC write phase mode. > > Changes since v1: > -Fix broken build > > Changes since v2: > -Fix trailing space > > Signed-off-by: Min Li > Please drop the empty line between

Re: [PATCH v8 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

2020-11-05 Thread Jakub Kicinski
On Tue, 3 Nov 2020 18:50:02 +1000 Pavana Sharma wrote: > Returning 0 is no more an error case with MV88E6393 family > which has serdes lane numbers 0, 9 or 10. > So with this change .serdes_get_lane will return lane number > or error (-ENODEV). > > Signed-off-by: Pavana Sharma >

Re: [PATCH v8 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-11-05 Thread Jakub Kicinski
On Tue, 3 Nov 2020 18:49:02 +1000 Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma Please always CC device tree maintainers and list on patches which touch bindings. Even if there is no need for review Rob has a bot which will catch any formatting

Re: [PATCH v8 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-05 Thread Jakub Kicinski
On Tue, 3 Nov 2020 18:50:38 +1000 Pavana Sharma wrote: > The Marvell 88E6393X device is a single-chip integration of a 11-port > Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers > and three 10-Gigabit interfaces. > > This patch adds functionalities specific to mv88e6393x

Re: [PATCH v2] net/x25: Fix null-ptr-deref in x25_connect

2020-11-06 Thread Jakub Kicinski
On Fri, 06 Nov 2020 07:23:05 +0100 Martin Schiller wrote: > On 2020-10-06 07:45, Martin Schiller wrote: > > This fixes a regression for blocking connects introduced by commit > > 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 > > disconnect"). > > > > The x25->neighbour is already

Re: [PATCH net-next v3 0/4] remove compat_alloc_user_space()

2020-11-06 Thread Jakub Kicinski
On Fri, 6 Nov 2020 22:48:18 +0100 Arnd Bergmann wrote: > On Fri, Nov 6, 2020 at 6:32 PM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > This is the third version of my seires, now spanning four patches > > instead of two, with a new approach for handling struct ifreq > > compatibility

Re: [PATCH net-next v4 0/5] bonding: rename bond components

2020-11-06 Thread Jakub Kicinski
On Fri, 6 Nov 2020 15:04:31 -0500 Jarod Wilson wrote: > The bonding driver's use of master and slave, while largely understood > in technical circles, poses a barrier for inclusion to some potential > members of the development and user community, due to the historical > context of masters and

Re: [V2] [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 06:58:16 -0800 Richard Cochran wrote: > On Sat, Nov 07, 2020 at 11:38:38AM +0800, Wang Qing wrote: > > We always have to update the value of ret, otherwise the error value > > may be the previous one. And ptp_clock_register() never return NULL > > when PTP_1588_CLOCK enable,

Re: [PATCH net-next 02/11] net: hns3: add support for 1us unit GL configuration

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 14:31:12 +0800 Huazhong Tan wrote: > For device whose version is above V3(include V3), the GL > configuration can set as 1us unit, so adds support for > configuring this field. > > Signed-off-by: Huazhong Tan Doesn't build. drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:

Re: [PATCH net-next 10/11] net: hns3: add ethtool priv-flag for EQ/CQ

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 14:31:20 +0800 Huazhong Tan wrote: > +static void hns3_update_cqe_mode(struct net_device *netdev, bool enable, > bool is_tx) Wrap this to 80 characters, please.

Re: [PATCH] netfilter: conntrack: fix -Wformat

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 23:55:50 -0800 Nick Desaulniers wrote: > -ntohs(tuple->src.u.icmp.id)); > +(__be16)ntohs(tuple->src.u.icmp.id)); Joe has a point, besides __be16 clearly is not the right type here, the result of ntohs is in host order.

Re: [PATCH net-next 0/2] net: axienet: Dynamically enable MDIO interface

2020-11-07 Thread Jakub Kicinski
On Tue, 3 Nov 2020 16:56:08 +0530 Radhey Shyam Pandey wrote: > This patchset dynamically enable MDIO interface. The background for this > change is coming from Cadence GEM controller(macb) in which MDC is active > only during MDIO read or write operations while the PHY registers are > read or

Re: [PATCH net-next] net: emaclite: Add error handling for of_address_ and phy read functions

2020-11-07 Thread Jakub Kicinski
On Tue, 3 Nov 2020 19:01:05 +0530 Radhey Shyam Pandey wrote: > From: Shravya Kumbham > > Add ret variable, conditions to check the return value and it's error > path for of_address_to_resource() and phy_read() functions. > > Addresses-Coverity: Event check_return value. > Signed-off-by: Shravya

Re: [PATCH] cxgb4: Fix the -Wmisleading-indentation warning

2020-11-07 Thread Jakub Kicinski
On Wed, 4 Nov 2020 13:24:04 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > Fix the gcc warning: > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c:2673:9: warning: this > 'for' clause does not guard... [-Wmisleading-indentation] > 2673 | for (i = 0; i < n; ++i) \ > >

Re: [PATCH v2] net: macvlan: remove redundant initialization in macvlan_dev_netpoll_setup

2020-11-07 Thread Jakub Kicinski
On Wed, 4 Nov 2020 20:54:04 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The initialization for err with 0 seems useless, as it is soon updated > with -ENOMEM. So, we can remove it. > > Changes since v1: > -Keep -ENOMEM still. > > Signed-off-by: Menglong Dong Applied.

Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 12:13:12 -0800 Randy Dunlap wrote: > On 11/6/20 8:11 AM, Vadym Kochan wrote: > > With CONFIG_BRIDGE=m the compilation fails: > > > > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in > > function `prestera_bridge_port_event': > >

Re: [PATCH v4 net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-07 Thread Jakub Kicinski
On Thu, 5 Nov 2020 22:52:07 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjphase() to support PHC write phase mode. > > Signed-off-by: Min Li > Acked-by: Richard Cochran Applied all 3, thanks.

Re: [RESEND PATCH] net: macb: fix NULL dereference due to no pcs_config method

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 10:26:59 +0100 Nicolas Ferre wrote: > On 05/11/2020 at 18:58, Parshuram Thombare wrote: > > This patch fixes NULL pointer dereference due to NULL pcs_config > > in pcs_ops. > > > > Reported-by: Nicolas Ferre > > Link: > >

Re: [PATCH V3] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 17:09:25 +0800 Yu Kuai wrote: > if of_find_device_by_node() succeed, fman_port_probe() doesn't have a > corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. > > Fixes: 0572054617f3 ("fsl/fman: fix dereference null

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-07 Thread Jakub Kicinski
On Fri, 06 Nov 2020 06:43:53 +0100 Martin Schiller wrote: > On 2020-11-05 16:06, Arnd Bergmann wrote: > > ... > > Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing > > list to Cc. When I last looked at the wan drivers, I think I concluded > > that this should still be kept

Re: [PATCH 2/2] selftests: pmtu.sh: improve the test result processing

2020-11-07 Thread Jakub Kicinski
On Thu, 5 Nov 2020 18:50:51 +0800 Po-Hsu Lin wrote: > This test will treat all non-zero return codes as failures, it will > make the pmtu.sh test script being marked as FAILED when some > sub-test got skipped. > > Improve the result processing by > * Only mark the whole test script as SKIP

Re: [PATCH net] ethtool: netlink: add missing netdev_features_change() call

2020-11-07 Thread Jakub Kicinski
On Thu, 05 Nov 2020 16:26:58 + Alexander Lobakin wrote: > After updating userspace Ethtool from 5.7 to 5.9, I noticed that > NETDEV_FEAT_CHANGE is no more raised when changing netdev features > through Ethtool. > That's because the old Ethtool ioctl interface always calls >

Re: [PATCH] net: atlantic: Remove unnecessary conversion to bool

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 10:57:59 +0800 xiakaixu1...@gmail.com wrote: > - cfg->is_qos = (tcs != 0 ? true : false); > + cfg->is_qos = (tcs != 0); !!tcs

Re: [PATCH] net: ipv4: remove redundant initialization in inet_rtm_deladdr

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 01:42:37 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The initialization for 'err' with '-EINVAL' is redundant and > can be removed, as it is updated soon. > > Signed-off-by: Menglong Dong How many changes like this are there in the kernel right now?

Re: [RFC net-next 00/28] ndo_ioctl rework

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 23:17:15 +0100 Arnd Bergmann wrote: > Any suggestions on how to proceed? I think the ndo_siocdevprivate > change is the most interesting here, and I would like to get > that merged. Splitting out / eliminating ioctl pass-thry in general seems like a nice clean up. How did you

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 08:48:28 -0300 Thadeu Lima de Souza Cascardo wrote: > On Fri, Oct 16, 2020 at 03:30:16PM -0700, Jakub Kicinski wrote: > > On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > > > From: Thadeu Lima de Souza Cascardo > > > > >

Re: [PATCH] mac80211: fix regression where EAPOL frames were sent in plaintext

2020-11-09 Thread Jakub Kicinski
On Sun, 08 Nov 2020 22:01:51 +0100 Johannes Berg wrote: > On Sun, 2020-11-08 at 20:34 +0100, Thomas Deutschmann wrote: > > > > > > Can we please get this applied to linux-5.10 and linux-5.9? > > It's tagged for that, so once it enters mainline will get picked up. > Should be soon now, I

Re: [PATCH 2/2] selftests: pmtu.sh: improve the test result processing

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 11:42:33 +0800 Po-Hsu Lin wrote: > On Sun, Nov 8, 2020 at 7:02 AM Jakub Kicinski wrote: > > > > On Thu, 5 Nov 2020 18:50:51 +0800 Po-Hsu Lin wrote: > > > This test will treat all non-zero return codes as failures, it will > > > make the

Re: [PATCH] net: udp: remove redundant initialization in udp_gro_complete

2020-11-09 Thread Jakub Kicinski
On Fri, 6 Nov 2020 01:42:39 -0500 menglong8.d...@gmail.com wrote: > { > __be16 newlen = htons(skb->len - nhoff); > struct udphdr *uh = (struct udphdr *)(skb->data + nhoff); > - int err = -ENOSYS; > + int err; > struct sock *sk; You can also move the err declaration

Re: [PATCH net-next v4 0/5] bonding: rename bond components

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 11:47:58 -0500 Jarod Wilson wrote: > On Fri, Nov 6, 2020 at 9:44 PM Jakub Kicinski wrote: > > On Fri, 6 Nov 2020 15:04:31 -0500 Jarod Wilson wrote: > > > The bonding driver's use of master and slave, while largely understood > > > in technic

Re: [PATCH net-next] net: stmmac: platform: use optional clk/reset get APIs

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 16:09:10 +0800 Jisheng Zhang wrote: > @@ -596,14 +595,10 @@ stmmac_probe_config_dt(struct platform_device *pdev, > const char **mac) > dev_dbg(>dev, "PTP rate %d\n", plat->clk_ptp_rate); > } > > - plat->stmmac_rst = devm_reset_control_get(>dev, > -

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 21:34:19 +0300 Dan Carpenter wrote: > Generally, I like them to be in chronological order. +1

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote: > A small detail (I think): the Signed-off-by of the sender (Geliang) > should be the last one in the list if I am not mistaken. > But I guess this is not blocking. > > Reviewed-by: Matthieu Baerts I take it you'd like me to apply patch

Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 14:31:17 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > This driver makes sure the underlying SPI bus is set to "mode 0" > by assigning SPI_MODE_0 to spi->mode. This overwrites all other > SPI mode flags. > > In some circumstances, this can break the underlying

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 18:09:09 -0300 Thadeu Lima de Souza Cascardo wrote: > On Mon, Nov 09, 2020 at 09:49:38AM -0800, Jakub Kicinski wrote: > > On Mon, 9 Nov 2020 08:48:28 -0300 Thadeu Lima de Souza Cascardo wrote: > > > On Fri, Oct 16, 2020 at 03:30:16PM -0700, Ja

Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 16:20:46 -0500 Sven Van Asbroeck wrote: > Is this a bug? If so, what should its Fixes commit be? The spi commit > upstream that enables SPI_CS_HIGH on my platform? I'd put two fixes tags one for the spi commit and one for the commit which introduced the assignment in the client

Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 16:29:19 -0500 Sven Van Asbroeck wrote: > On Mon, Nov 9, 2020 at 4:24 PM Jakub Kicinski wrote: > > > > the commit > > which introduced the assignment in the client driver. > > That's the commit which adds the initial driver to the tree, b

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 18:31:34 -0300 Thadeu Lima de Souza Cascardo wrote: > > Which paths are those (my memory of this code is waning)? I thought > > disconnect is only called from the user space side (shutdown syscall). > > The only other way to terminate the connection is to close the socket, > >

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 21:23:33 + (UTC) Matthieu Baerts wrote: > 09 Nov 2020 21:57:05 Jakub Kicinski : > > On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote: > >> A small detail (I think): the Signed-off-by of the sender (Geliang) > >> should be the l

Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:19:48 -0500 Sven Van Asbroeck wrote: > On Mon, Nov 9, 2020 at 5:04 PM Jakub Kicinski wrote: > > > > Yup > > Just a minute. Earlier in the thread, Andrew Lunn is suggesting I > create a new spi helper function, and cross-post to the spi group(s).

Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:27:28 -0500 Sven Van Asbroeck wrote: > On Mon, Nov 9, 2020 at 5:23 PM Jakub Kicinski wrote: > > > > Is it only broken for you in linux-next or just in the current 5.10 > > release? > > It's broken for me in the current 5.10 release. That

Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:39:22 -0500 Sven Van Asbroeck wrote: > What I already posted (as v1) should be the minimal fix. > Can we proceed on that basis? I'll follow up with the helper > after the net -> net-next merge, as you suggested. Well, you cut off the relevant part of my email where I said:

Re: [PATCH] sctp: Fix sending when PMTU is less than SCTP_DEFAULT_MINSEGMENT

2020-11-09 Thread Jakub Kicinski
On Fri, 6 Nov 2020 07:21:06 -0300 Marcelo Ricardo Leitner wrote: > On Fri, Nov 06, 2020 at 10:48:24AM +0100, Petr Malat wrote: > > On Fri, Nov 06, 2020 at 05:46:34AM -0300, Marcelo Ricardo Leitner wrote: > > > On Thu, Nov 05, 2020 at 11:39:47AM +0100, Petr Malat wrote: > > > > Function

Re: [PATCH net-next] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer

2020-11-09 Thread Jakub Kicinski
On Thu, 05 Nov 2020 21:29:01 + Alexander Lobakin wrote: > Similar to commit fda55eca5a33f > ("net: introduce skb_transport_header_was_set()"), avoid resetting > transport offsets that were already set by GRO layer. This not only > mirrors the behavior of __netif_receive_skb_core(), but also

Re: [PATCH v2 net-next] net: udp: introduce UDP_MIB_MEMERRORS for udp_mem

2020-11-09 Thread Jakub Kicinski
On Thu, 5 Nov 2020 20:49:14 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > When udp_memory_allocated is at the limit, __udp_enqueue_schedule_skb > will return a -ENOBUFS, and skb will be dropped in __udp_queue_rcv_skb > without any counters being done. It's hard to find out

Re: [PATCH net-next] bridge: mrp: Use hlist_head instead of list_head for mrp

2020-11-09 Thread Jakub Kicinski
On Fri, 6 Nov 2020 22:50:49 +0100 Horatiu Vultur wrote: > Replace list_head with hlist_head for MRP list under the bridge. > There is no need for a circular list when a linear list will work. > This will also decrease the size of 'struct net_bridge'. > > Signed-off-by: Horatiu Vultur Applied,

Re: [PATCH] net: udp: remove redundant initialization in udp_dump_one

2020-11-09 Thread Jakub Kicinski
On Fri, 6 Nov 2020 01:42:38 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The initialization for 'err' with '-EINVAL' is redundant and > can be removed, as it is updated soon and not used. > > Signed-off-by: Menglong Dong Applied, thanks.

Re: [PATCH] net: udp: remove redundant initialization in udp_send_skb

2020-11-09 Thread Jakub Kicinski
On Fri, 6 Nov 2020 01:42:40 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The initialization for 'err' with 0 is redundant and can be removed, > as it is updated by ip_send_skb and not used before that. > > Signed-off-by: Menglong Dong Applied.

Re: [PATCH v2 net] ethtool: netlink: add missing netdev_features_change() call

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 15:00:02 +0100 Michal Kubecek wrote: > On Sun, Nov 08, 2020 at 12:46:15AM +, Alexander Lobakin wrote: > > After updating userspace Ethtool from 5.7 to 5.9, I noticed that > > NETDEV_FEAT_CHANGE is no more raised when changing netdev features > > through Ethtool. > > That's

Re: [PATCH] docs: networking: phy: s/2.5 times faster/2.5 times as fast/

2020-11-09 Thread Jakub Kicinski
On Sat, 7 Nov 2020 23:08:21 +0100 Jonathan Neuschäfer wrote: > 2.5 times faster would be 3.5 Gbps (4.375 Gbaud after 8b/10b encoding). > > Signed-off-by: Jonathan Neuschäfer Applied, thanks!

Re: [PATCH] net/mlx4: Assign boolean values to a bool variable

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 11:33:17 +0200 Tariq Toukan wrote: > >>> ./drivers/net/ethernet/mellanox/mlx4/en_rx.c:687:1-17: WARNING: > >>> Assignment of 0/1 to bool variable > >>> > >>> Reported-by: Tosk Robot > >>> Signed-off-by: Kaixu Xia > > Reviewed-by: Tariq Toukan Applied, thanks.

Re: INFO: task hung in tls_sw_free_resources_tx

2019-08-19 Thread Jakub Kicinski
On Tue, 04 Dec 2018 00:48:02 -0800, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:6915bf3b002b net: phy: don't allow __set_phy_supported to .. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=177085a340 > kernel

Re: KASAN: slab-out-of-bounds Read in tls_write_space

2019-08-19 Thread Jakub Kicinski
On Tue, 25 Sep 2018 16:54:03 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:bd4d08daeb95 Merge branch 'net-dsa-b53-SGMII-modes-fixes' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=110b6a1a40 > kernel config:

Re: KASAN: use-after-free Read in tls_write_space

2019-08-19 Thread Jakub Kicinski
On Fri, 06 Jul 2018 00:36:02 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:1a84d7fdb5fc Merge branch 'mlxsw-Add-resource-scale-tests' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17dec75c40 > kernel

Re: general protection fault in tls_setsockopt

2019-08-19 Thread Jakub Kicinski
On Tue, 16 Jul 2019 16:58:06 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:a131c2bf Merge tag 'acpi-5.3-rc1-2' of git://git.kernel.or.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1603e9c060 > kernel

Re: [PATCH net-next] netdevsim: Fix build error without CONFIG_INET

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 20:08:25 +0800, YueHaibing wrote: > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Add CONFIG_INET Kconfig dependency to fix this. > >

Re: BUG: unable to handle kernel paging request in tls_prots

2019-08-19 Thread Jakub Kicinski
On Wed, 26 Jun 2019 03:17:05 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:904d88d7 qmi_wwan: Fix out-of-bounds read > git tree: net > console output: https://syzkaller.appspot.com/x/log.txt?x=14a8b865a0 > kernel config:

Re: WARNING: ODEBUG bug in tls_sw_free_resources_tx

2019-08-19 Thread Jakub Kicinski
On Tue, 06 Nov 2018 17:52:03 -0800, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:7c6c54b505b8 Merge branch 'i2c/for-next' of git://git.kern.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1276246d40 > kernel

Re: KASAN: use-after-free Read in tls_push_sg

2019-08-19 Thread Jakub Kicinski
On Fri, 17 May 2019 11:40:05 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:35c99ffa Merge tag 'for_linus' of git://git.kernel.org/pub.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=10ff3322a0 > kernel

Re: [PATCH v2 net-next] netdevsim: Fix build error without CONFIG_INET

2019-08-20 Thread Jakub Kicinski
end_check to avoid > dependencies on CONFIG_INET. > > Reported-by: Hulk Robot > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing Thank you! Acked-by: Jakub Kicinski

Re: [PATCH net-next v2 00/10] net: stmmac: Improvements for -next

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 15:42:41 +0200, Jose Abreu wrote: > Couple of improvements for -next tree. More info in commit logs. Code looks good to me now, thanks!

Re: [PATCH net-next 2/5] r8152: replace array with linking list for rx information

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 12:53:42 -0700, Jakub Kicinski wrote: > > @@ -744,6 +745,8 @@ struct r8152 { > > void (*autosuspend_en)(struct r8152 *tp, bool enable); > > } rtl_ops; > > > > + atomic_t rx_count; > > I wonder what the advantage

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Jakub Kicinski
On Tue, 6 Aug 2019 17:21:18 -0700, Tao Ren wrote: > Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base > MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabled. The logic > doesn't work for platforms with different BMC MAC offset: for example, > Facebook Yamp BMC's

Re: general protection fault in tls_tx_records

2019-08-08 Thread Jakub Kicinski
On Thu, 08 Aug 2019 09:44:06 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:ce96e791 Add linux-next specific files for 20190731 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=13ce4fd060 > kernel config:

Re: KASAN: use-after-free Read in tls_wait_data

2019-08-08 Thread Jakub Kicinski
On Thu, 08 Aug 2019 09:44:07 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:7b4980e0 Add linux-next specific files for 20190802 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=14a749b460 > kernel config:

Re: INFO: task hung in tls_sw_release_resources_tx

2019-08-15 Thread Jakub Kicinski
On Thu, 15 Aug 2019 22:14:19 +0800, Hillf Danton wrote: > On Thu, 15 Aug 2019 03:54:06 -0700 > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:6d5afe20 sctp: fix memleak in sctp_send_reset_streams > > git tree: net > > console output:

Re: [PATCH net-next v2 1/2] hinic: add rss support

2019-06-13 Thread Jakub Kicinski
On Tue, 11 Jun 2019 18:12:33 +, Xue Chaojing wrote: > This patch adds rss support for the HINIC driver. > > Signed-off-by: Xue Chaojing > +static int hinic_rss_init(struct hinic_dev *nic_dev) > +{ > + u8 default_rss_key[HINIC_RSS_KEY_SIZE] = { > + 0x6d, 0x5a, 0x56,

Re: [PATCH net-next 0/2] enable and use static_branch_deferred_inc

2019-06-13 Thread Jakub Kicinski
On Thu, 13 Jun 2019 11:08:14 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > 1. make static_branch_deferred_inc available if !CONFIG_JUMP_LABEL > 2. convert the existing STATIC_KEY_DEFERRED_FALSE user to this api Reviewed-by: Jakub Kicinski Thanks/sorry :)

Re: [PATCH net-next v2 1/2] hinic: add rss support

2019-06-13 Thread Jakub Kicinski
On Tue, 11 Jun 2019 18:12:33 +, Xue Chaojing wrote: > + for (i = 0; i < HINIC_RSS_INDIR_SIZE; i++) > + indir_tbl[i] = (i / HINIC_RSS_INDIR_SIZE) * nic_dev->num_rss + > + i % nic_dev->num_rss; This looks suspicious: i is in range [0,

Re: [PATCH] mt76_init_sband_2g: null check the allocation

2019-07-24 Thread Jakub Kicinski
On Tue, 23 Jul 2019 17:19:54 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Acked-by: Jakub Kicinski Thanks!

Re: [PATCH] mt7601u: null check the allocation

2019-07-24 Thread Jakub Kicinski
On Wed, 24 Jul 2019 09:17:36 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Ah, I replied to the wrong one.. Acked-by: Jakub Kicinski

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-03 Thread Jakub Kicinski
On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: > Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: > >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote: > >> >? Do we need such change there too or keep it as is, each action by itself > >> >and return what was performed ? >

Re: [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 09:15:24 + Henrik Bjoernlund wrote: > + rcu_read_lock(); > + b_port = rcu_dereference(mep->b_port); > + if (!b_port) > + return NULL; > + skb = dev_alloc_skb(CFM_CCM_MAX_FRAME_LENGTH); > + if (!skb) > + return NULL;

Re: [PATCHv2] selftests: rtnetlink: load fou module for kci_test_encap_fou()

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 17:10:39 +0800 Po-Hsu Lin wrote: > Hello David, > > do you need more information for this V2 patch? Something strange happened here, did you perhaps edit the patch manually and resend the same email? I think the Message-ID header may had been the same on v1 and v2 of your

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 11:04:50 +0200 Jiri Pirko wrote: > Thu, Sep 03, 2020 at 09:47:19PM CEST, k...@kernel.org wrote: > >On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: > >> Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: > >> >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote:

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Jakub Kicinski
On Wed, 2 Sep 2020 17:06:58 -0700 Xie He wrote: > PVC devices are virtual devices in this driver stacked on top of the > actual HDLC device. They are the devices normal users would use. > PVC devices have two types: normal PVC devices and Ethernet-emulating > PVC devices. > > When transmitting

Re: [PATCH net-next 8/9] net: ethernet: ti: ale: switch to use tables for vlan entry description

2020-09-04 Thread Jakub Kicinski
On Sat, 5 Sep 2020 02:09:23 +0300 Grygorii Strashko wrote: > The ALE VLAN entries are too much differ between different TI CPSW ALE > versions. So, handling them using flags, defines and get/set functions > became over-complicated. > > This patch introduces tables to describe the ALE VLAN entries

Re: [PATCH net-next 9/9] net: ethernet: ti: ale: add support for multi port k3 cpsw versions

2020-09-04 Thread Jakub Kicinski
On Sat, 5 Sep 2020 02:09:24 +0300 Grygorii Strashko wrote: > The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5 > CPSW ALE, but has more extended functions and different ALE VLAN entry > format. > > This patch adds support for for multi port TI J721E (CPSW9g) ALE variant.

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Jakub Kicinski
gt; > So no header will be prepended after ndo_start_xmit is called. > > There would not be any header prepended before ndo_start_xmit is > called, either, because there is no header_ops implemented in either > hdlc.c or hdlc_fr.c. Thank you for the detailed explanation. > On

Re: [PATCH] atm: eni: fix the missed pci_disable_device() for eni_init_one()

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 10:51:03 +0800 Jing Xiangfeng wrote: > eni_init_one() misses to call pci_disable_device() in an error path. > Jump to err_disable to fix it. > > Signed-off-by: Jing Xiangfeng Please make sure you add appropriate fixes tags, here: Fixes: ede58ef28e10 ("atm: remove deprecated

Re: [PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 06:42:57 -0500 Dan Murphy wrote: > Add the ability to advertise the Fiber connection if the strap or the > op-mode is configured for 100Base-FX. > > Auto negotiation is not supported on this PHY when in fiber mode. > > Signed-off-by: Dan Murphy Some comments, I'm not very

Re: [PATCH net-next v3 2/3] net: phy: dp83869: support Wake on LAN

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 06:42:58 -0500 Dan Murphy wrote: > This adds WoL support on TI DP83869 for magic, magic secure, unicast and > broadcast. > > Signed-off-by: Dan Murphy > --- > drivers/net/phy/dp83869.c | 128 ++ > 1 file changed, 128 insertions(+) > > diff

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: > +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) > +{ > + int val, count; > + > + if (cnt > DP83869_DOWNSHIFT_8_COUNT) > + return -E2BIG; ERANGE > + if (!cnt) > + return

Re: [PATCH] MAINTAINERS: repair reference in LYNX PCS MODULE

2020-09-05 Thread Jakub Kicinski
On Sat, 5 Sep 2020 12:37:00 +0200 Lukas Bulwahn wrote: > Commit 0da4c3d393e4 ("net: phy: add Lynx PCS module") added the files in > ./drivers/net/pcs/, but the new LYNX PCS MODULE section refers to > ./drivers/net/phy/. > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: > >

Re: [PATCH net-next v2 0/2] net: dsa: bcm_sf2: Ensure MDIO diversion is used

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 14:37:28 -0700 Florian Fainelli wrote: > Changes in v2: > > - export of_update_property() to permit building bcm_sf2 as a module > - provided a better explanation of the problem being solved after > explaining it to Andrew during the v1 review Applied, thanks everyone!

Re: [PATCH net v1 0/2] hinic: BugFixes

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 16:37:27 +0800 Luo bin wrote: > The bugs fixed in this patchset have been present since the following > commits: > patch #1: Fixes: 00e57a6d4ad3 ("net-next/hinic: Add Tx operation") > patch #2: Fixes: 5e126e7c4e52 ("hinic: add firmware update support") Applied.

Re: [PATCH net-next] caif: Remove duplicate macro SRVL_CTRL_PKT_SIZE

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 20:58:58 +0800 Wang Hai wrote: > Remove SRVL_CTRL_PKT_SIZE which is defined more than once. > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied, thanks.

<    6   7   8   9   10   11   12   13   14   15   >