Re: [PATCH net-next] NFC: digital: Remove two unused macroes

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 21:01:57 +0800 Wang Hai wrote: > DIGITAL_NFC_DEP_REQ_RES_TAILROOM is never used after it was introduced. > DIGITAL_NFC_DEP_REQ_RES_HEADROOM is no more used after below > commit e8e7f4217564 ("NFC: digital: Remove useless call to skb_reserve()") > Remove them. > > Reported-by:

Re: [PATCH net] hv_netvsc: Fix hibernation for mlx5 VF driver

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 19:52:18 -0700 Dexuan Cui wrote: > mlx5_suspend()/resume() keep the network interface, so during hibernation > netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence > netvsc_resume() should call netvsc_vf_changed() to switch the data path > back to the VF

Re: [PATCH net-next v3 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 22:21:58 +0800 Landen Chao wrote: > @@ -32,10 +33,13 @@ Required properties for the child nodes within ports > container: > > - reg: Port address described must be 6 for CPU port and from 0 to 5 for > user ports. > -- phy-mode: String, must be either "trgmii" or

Re: [PATCH net-next v3 2/6] net: dsa: mt7530: Extend device data ready for adding a new hardware

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 22:21:57 +0800 Landen Chao wrote: > +static bool > +mt7530_phy_mode_supported(struct dsa_switch *ds, int port, > + const struct phylink_link_state *state) > { > struct mt7530_priv *priv = ds->priv; > - u32 mcr_cur, mcr_new; > > switch

Re: [PATCH net-next v3 4/6] net: dsa: mt7530: Add the support of MT7531 switch

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 22:21:59 +0800 Landen Chao wrote: > +static int > +mt7531_cpu_port_config(struct dsa_switch *ds, int port) > +{ > + struct mt7530_priv *priv = ds->priv; > + phy_interface_t interface; > + int speed; > + > + switch (port) { > + case 5: > + if

Re: [PATCH net] hv_netvsc: Fix hibernation for mlx5 VF driver

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 03:05:48 + Dexuan Cui wrote: > > > @@ -2635,6 +2632,10 @@ static int netvsc_resume(struct hv_device *dev) > > > netvsc_devinfo_put(device_info); > > > net_device_ctx->saved_netvsc_dev_info = NULL; > > > > > > + vf_netdev = rtnl_dereference(net_device_ctx->vf_netdev); > >

Re: [PATCH net-next v2] net/packet: Remove unused macro BLOCK_PRIV

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 11:15:05 +0200 Willem de Bruijn wrote: > On Sat, Sep 5, 2020 at 10:53 AM Wang Hai wrote: > > > > BLOCK_PRIV is never used after it was introduced. > > So better to remove it. > > > > Reported-by: Hulk Robot > > Signed-off-by: Wang Hai > > Acked-by: Willem de Bruijn

Re: [PATCH net-next 0/2] net: two updates related to UDP GSO

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote: > There are two updates relates to UDP GSO. > #1 adds a new GSO type for UDPv6 > #2 adds check for UDP GSO when csum is disable in netdev_fix_features(). > > Changes since RFC V2: > - modifies the timing of setting UDP GSO type when doing UDP

Re: [PATCH net] net: macb: fix for pause frame receive enable bit

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 10:21:33 +0200 Parshuram Thombare wrote: > PAE bit of NCFGR register, when set, pauses transmission > if a non-zero 802.3 classic pause frame is received. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") > Signed-off-by: Parshuram Thombare Applied, thank you!

Re: [PATCH] net: Fix some comments

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 05:14:48 -0400 Miaohe Lin wrote: > Since commit 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to > invalidate dst entries"), we use blackhole_netdev to invalidate dst entries > instead of loopback device anymore. Also fix broken NETIF_F_HW_CSUM spell. > > Signed-off-by:

Re: [PATCH] net: Add a missing word

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 20:32:18 +0200 Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer Applied.

Re: [PATCH] enic: switch from 'pci_' to 'dma_' API

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 14:45:41 +0200 Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Jakub Kicinski
On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote: > Initialize the buffer before passing it to usb_read_cmd() function(s) to > fix the uninit-was-stored issue in asix_read_cmd(). > > Fixes: KMSAN: kernel-infoleak in raw_ioctl Regardless of the ongoing discussion - could you please make

Re: [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl

2020-08-25 Thread Jakub Kicinski
On Tue, 25 Aug 2020 12:18:44 + Ahmed Abdelsalam wrote: > + Enable the SRv6 encapsulation to inherit the DSCP value of the inner > IPv4 packet. > > + > + Default: FALSE (Do not

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: > On 8/17/2020 7:36 PM, Jiri Pirko wrote: > > Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: > >> Add devlink reload action to allow the user to request a specific reload > >> action. The action parameter is optional, if

Re: [PATCH bpf-next 2/6] bpf: sockmap: merge sockmap and sockhash update functions

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 10:24:32 +0100 Lorenz Bauer wrote: > --- a/net/core/sock_map.c > +++ b/net/core/sock_map.c > @@ -559,10 +559,12 @@ static bool sock_map_sk_state_allowed(const struct sock > *sk) > return false; > } > > -static int sock_map_update_elem(struct bpf_map *map, void *key, >

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 17:18:15 +0200 Jiri Pirko wrote: I will add counters on which reload were done. reload_down()/up() can return which actions were actually done and devlink will show counters. >>> Why a counter? Just return what was done over netlink reply. >> >> Such

Re: [PATCH 15/28] wireless: mediatek: mt7601u: phy: Fix misnaming when documented function parameter 'dac'

2020-08-19 Thread Jakub Kicinski
601u/phy.c:1216: warning: Excess function > parameter 'path' description in 'mt7601u_set_tx_dac' Acked-by: Jakub Kicinski

Re: [PATCH net-next] hinic: add debugfs support

2020-08-20 Thread Jakub Kicinski
On Thu, 20 Aug 2020 20:14:32 +0800 Luo bin wrote: > +static int hinic_dbg_help(struct hinic_dev *nic_dev, const char *cmd_buf) > +{ > + netif_info(nic_dev, drv, nic_dev->netdev, "Available commands:\n"); > + netif_info(nic_dev, drv, nic_dev->netdev, "sq info \n"); > +

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-02 Thread Jakub Kicinski
On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote: > >? Do we need such change there too or keep it as is, each action by itself > >and return what was performed ? > > Well, I don't know. User asks for X, X should be performed, not Y or Z. > So perhaps the return value is not needed. > Just

Re: [PATCH net-next v2 3/3] net: dp83869: Add speed optimization feature

2020-09-02 Thread Jakub Kicinski
On Wed, 2 Sep 2020 15:34:44 -0500 Dan Murphy wrote: > Set the speed optimization bit on the DP83869 PHY. > > Speed optimization, also known as link downshift, enables fallback to 100M > operation after multiple consecutive failed attempts at Gigabit link > establishment. Such a case could occur

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-17 Thread Jakub Kicinski
On Mon, 17 Aug 2020 12:37:40 +0300 Moshe Shemesh wrote: > Add devlink reload action to allow the user to request a specific reload > action. The action parameter is optional, if not specified then devlink > driver re-init action is used (backward compatible). > Note that when required to do

Re: [PATCH 08/20] ethernet: hinic: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Jakub Kicinski
On Mon, 17 Aug 2020 13:54:22 +0530 Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier

Re: [PATCH 06/20] ethernet: chelsio: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Jakub Kicinski
On Mon, 17 Aug 2020 13:54:20 +0530 Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier

Re: [PATCH v2] net: qrtr: fix usage of idr in port assignment to socket

2020-08-17 Thread Jakub Kicinski
On Mon, 17 Aug 2020 07:39:01 + Necip Fazil Yildiran wrote: > From: Necip Fazil Yildiran > > Passing large uint32 sockaddr_qrtr.port numbers for port allocation > triggers a warning within idr_alloc() since the port number is cast > to int, and thus interpreted as a negative number. This

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 15:14:10 +0800 Landen Chao wrote: > Add new support for MT7531: > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu > port 6 only supports SGMII interface. Cpu port 5 supports

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 12:06:13 +0300 Moshe Shemesh wrote: > Or maybe better than "live" say explicitly "no reset": > >     devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { > driver_reinit | fw_activate [--no_reset] } ] SGTM

Re: [PATCH v6 08/10] net: eth: altera: add support for ptp and timestamping

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 23:46:11 +0800 Ooi, Joyce wrote: > From: Dalon Westergreen > > Add support for the ptp clock used with the tse, and update > the driver to support timestamping when enabled. We also > enable debugfs entries for the ptp clock to allow some user > control and interaction with

Re: [PATCH v6 09/10] net: eth: altera: add msgdma prefetcher

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 23:46:12 +0800 Ooi, Joyce wrote: > From: Dalon Westergreen > > Add support for the mSGDMA prefetcher. The prefetcher adds support > for a linked list of descriptors in system memory. The prefetcher > feeds these to the mSGDMA dispatcher. This generates warnings on 32bit

Re: [PATCH net-next v1 3/3] hinic: add support to query function table

2020-08-28 Thread Jakub Kicinski
On Fri, 28 Aug 2020 11:16:22 +0800 luobin (L) wrote: > On 2020/8/28 3:44, Jakub Kicinski wrote: > > On Thu, 27 Aug 2020 19:13:21 +0800 Luo bin wrote: > >> + switch (idx) { > >> + case VALID: > >> + return funcfg_table_elem->dw0.bs.valid; >

Re: [PATCH] nfc: enforce CAP_NET_RAW for raw sockets When creating a raw AF_NFC socket, CAP_NET_RAW needs to be checked first.

2020-08-06 Thread Jakub Kicinski
On Thu, 6 Aug 2020 10:28:08 +0800 Qingyu Li wrote: Commit message is required. Perhaps shorten the subject and put more info here. > Signed-off-by: Qingyu Li > --- > net/nfc/rawsock.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/nfc/rawsock.c

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-08-06 Thread Jakub Kicinski
On Wed, 5 Aug 2020 13:02:58 +0200 Jiri Pirko wrote: > Tue, Aug 04, 2020 at 10:39:46PM CEST, k...@kernel.org wrote: > >AFAIU the per-driver default is needed because we went too low > >level with what the action constitutes. We need maintain the higher > >level actions. > > > >The user clearly did

Re: [PATCH v2 0/2 net] bitfield.h cleanups

2020-08-06 Thread Jakub Kicinski
On Thu, 6 Aug 2020 11:13:58 -0700 Jakub Kicinski wrote: > please repost the first patch only To be clear the second patch may need to wait for net-next since it's refactoring. That's why I suggest only posting patch 1 now, i.e. the fix.

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-06 Thread Jakub Kicinski
On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > Trying to use ktls on a system with 32-bit userspace and 64-bit kernel > results in a EOPNOTSUPP message during sendmsg: > > setsockopt(3, SOL_TLS, TLS_TX, …, 40) = 0 > sendmsg(3, …, msg_flags=0}, 0) = -1 EOPNOTSUPP (Operation not

Re: [PATCH v2 0/2 net] bitfield.h cleanups

2020-08-06 Thread Jakub Kicinski
On Wed, 5 Aug 2020 10:44:30 -0700 Nick Desaulniers wrote: > Hi David, > I read through > https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-often-do-changes-from-these-trees-make-it-to-the-mainline-linus-tree > and noticed http://vger.kernel.org/~davem/net-next.html. Since

Re: [PATCH net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated

2020-08-07 Thread Jakub Kicinski
On Thu, 6 Aug 2020 23:43:45 -0700 Ronak Doshi wrote: > 'Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support")' added support for encapsulation offload. However, while nit: no need for the quotes around commit xzy ("") > calculating tcp hdr length, it does not take into

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Jakub Kicinski
On Fri, 07 Aug 2020 14:27:48 +0200 Rouven Czerwinski wrote: > I just tested on my x86_64 workstation and these specific tests fail > there too, do they only work on 5.8? They were added in 5.8, but I am > running 5.7.11 here. It looks like these failures are not > MSG_CMSG_COMPAT related. > >

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: > > In that sense I don't like --live because it doesn't really say much. > > AFAIU it means 1) no link flap; 2) < 2 sec datapath downtime; 3) no > > configuration is lost in kernel or device (including netdev config, > > link config, flow

Re: [PATCHv3] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 11:50:10 +0800 Po-Hsu Lin wrote: > The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh > needs the fou module to work. Otherwise it will fail with: > > $ ip netns exec "$testns" ip fou add port ipproto 47 > RTNETLINK answers: No such file or directory

Re: [PATCH net-next] net: ethernet: dwmac: remove redundant null check before clk_disable_unprepare()

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 20:46:54 +0800 Zhang Changzhong wrote: > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH net-next] net: ethernet: fec: remove redundant null check before clk_disable_unprepare()

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 13:14:50 + Andy Duan wrote: > From: Zhang Changzhong Sent: Monday, September > 7, 2020 8:50 PM > > Because clk_prepare_enable() and clk_disable_unprepare() already checked > > NULL clock parameter, so the additional checks are unnecessary, just remove > > them. > > > >

Re: [PATCH net-next] net: stmmac: remove redundant null check before clk_disable_unprepare()

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 20:57:24 +0800 Zhang Changzhong wrote: > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH net-next] net: xilinx: remove redundant null check before clk_disable_unprepare()

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 13:14:05 + Radhey Shyam Pandey wrote: > > From: Zhang Changzhong > > Sent: Monday, September 7, 2020 6:32 PM > > To: Radhey Shyam Pandey ; da...@davemloft.net; > > k...@kernel.org; Michal Simek > > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject:

Re: [PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len'

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 22:12:07 +0800 Wang Hai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/dnet.c: In function dnet_start_xmit > drivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used > [-Wunused-but-set-variable] > > commit 4796417417a6

Re: [PATCH AUTOSEL 5.8 14/53] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 12:31:40 -0400 Sasha Levin wrote: > [ Upstream commit 9f13457377907fa253aef560e1a37e1ca4197f9b ] > @@ -2024,10 +2033,14 @@ static int do_reset(struct ibmvnic_adapter *adapter, > } else { > rc = reset_tx_pools(adapter); >

Re: [PATCH net] hinic: fix rewaking txq after netif_tx_disable

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 22:15:16 +0800 Luo bin wrote: > When calling hinic_close in hinic_set_channels, all queues are > stopped after netif_tx_disable, but some queue may be rewaken in > free_tx_poll by mistake while drv is handling tx irq. If one queue > is rewaken core may call hinic_xmit_frame to

Re: [PATCH net-next] rxrpc: Remove unused macro rxrpc_min_rtt_wlen

2020-09-07 Thread Jakub Kicinski
On Fri, 4 Sep 2020 21:08:37 +0800 Wang Hai wrote: > rxrpc_min_rtt_wlen is never used after it was introduced. > So better to remove it. > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied.

Re: linux-next: build warning after merge of the net-next tree

2020-09-07 Thread Jakub Kicinski
On Tue, 8 Sep 2020 13:00:00 +1000 Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > net/bridge/br_multicast.c: In function 'br_multicast_find_port': > net/bridge/br_multicast.c:1818:21: warning:

Re: [PATCH net v2] hv_netvsc: Fix hibernation for mlx5 VF driver

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 00:13:39 -0700 Dexuan Cui wrote: > mlx5_suspend()/resume() keep the network interface, so during hibernation > netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence > netvsc_resume() should call netvsc_vf_changed() to switch the data path > back to the VF

[PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-08 Thread Jakub Kicinski
U=n rcu_dereference_protected() compiles to nothing the compiler doesn't see the variable use. Prevent the warning by adding the condition as dead code. We need to un-hide the declaration of lockdep_tasklist_lock_is_held() and fix a bug the crept into a net/sched header. Signed-off-by: Jakub Kicinski --- incl

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-08 Thread Jakub Kicinski
On Tue, 8 Sep 2020 09:07:22 -0500 Dan Murphy wrote: > On 9/5/20 1:38 PM, Jakub Kicinski wrote: > > On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: > >> +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) > >> +{ > >> + in

Re: [PATCH v2] ptp: mark symbols static where possible

2020-09-18 Thread Jakub Kicinski
On Fri, 18 Sep 2020 14:10:13 +0800 Herrington wrote: > We get 1 warning when building kernel with W=1: > drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for > ‘pch_ch_control_read’ [-Wmissing-prototypes] > u32 pch_ch_control_read(struct pci_dev *pdev) > drivers/ptp/ptp_pch.c:193:6:

Re: [PATCH net-next RFC v5 02/15] devlink: Add reload action limit level

2020-09-23 Thread Jakub Kicinski
On Fri, 18 Sep 2020 19:06:38 +0300 Moshe Shemesh wrote: > Add reload action limit level to demand restrictions on actions. > Reload action limit levels supported: > none (default): No constrains on actions. Driver implementation may > include reset or downtime as needed to perform

Re: [PATCH net-next RFC v5 03/15] devlink: Add reload action stats

2020-09-23 Thread Jakub Kicinski
On Fri, 18 Sep 2020 19:06:39 +0300 Moshe Shemesh wrote: > Add reload action stats to hold the history per reload action type and > limit level. > > For example, the number of times fw_activate has been performed on this > device since the driver module was added or if the firmware activation >

Re: [PATCH net-next RFC v5 04/15] devlink: Add reload actions stats to dev get

2020-09-23 Thread Jakub Kicinski
On Fri, 18 Sep 2020 19:06:40 +0300 Moshe Shemesh wrote: > Expose devlink reload actions stats to the user through devlink dev > get command. > > Examples: > $ devlink dev show > pci/:82:00.0: > stats: > reload_action_stats: > driver_reinit 2 > fw_activate 1 >

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-24 Thread Jakub Kicinski
On Wed, 23 Sep 2020 22:49:37 -0700 Saeed Mahameed wrote: > 2) Another problematic scenario which i see is repeated in many > drivers: > > shutdown/suspend() > rtnl_lock() > netif_device_detach()//Mark !present; > stop()->carrier_off()->linkwatch_event() > // at this point device

Re: [PATCH net-next RFC v5 01/15] devlink: Add reload action option to devlink reload command

2020-09-24 Thread Jakub Kicinski
On Thu, 24 Sep 2020 22:01:42 +0300 Moshe Shemesh wrote: > On 9/23/2020 9:25 PM, Jakub Kicinski wrote: > >> Signed-off-by: Moshe Shemesh > >> @@ -3971,15 +3972,19 @@ static int mlx4_devlink_reload_up(struct devlink > >> *devlink, > >>int err; >

Re: [PATCH net-next RFC v5 02/15] devlink: Add reload action limit level

2020-09-24 Thread Jakub Kicinski
On Thu, 24 Sep 2020 22:29:55 +0300 Moshe Shemesh wrote: > >> @@ -3964,6 +3965,7 @@ static int mlx4_devlink_reload_down(struct devlink > >> *devlink, bool netns_change, > >> } > >> > >> static int mlx4_devlink_reload_up(struct devlink *devlink, enum > >> devlink_reload_action action, > >> +

Re: [PATCH] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-24 Thread Jakub Kicinski
On Thu, 24 Sep 2020 08:27:22 +0200 Wilken Gottwalt wrote: > Reposted and added netdev as suggested by Jakub Kicinski. Thanks! > --- If you want to add a comment like the above you need to place it under the '---' which git generates. Git removes everything after those lines. With the

Re: [PATCH net-next 01/11] atm: horizon: shut up clang null pointer arithmetic warning

2020-10-28 Thread Jakub Kicinski
On Mon, 26 Oct 2020 22:29:48 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Building a "W=1" kernel with clang produces a warning about > suspicous pointer arithmetic: > > drivers/atm/horizon.c:1844:52: warning: performing pointer arithmetic > on a null pointer has undefined behavior

Re: [PATCH v3] net: core: Use skb_is_gso() in skb_checksum_help()

2020-10-28 Thread Jakub Kicinski
On Tue, 27 Oct 2020 13:59:04 +0800 Yi Li wrote: > No functional changes, just minor refactoring. > > Signed-off-by: Yi Li Applied, thanks!

Re: [PATCH 4.19 018/264] chelsio/chtls: correct function return and return type

2020-10-28 Thread Jakub Kicinski
On Wed, 28 Oct 2020 07:58:04 +0100 Pavel Machek wrote: > > From: Vinay Kumar Yadav > > > > [ Upstream commit 8580a61aede28d441e1c80588803411ee86aa299 ] > > > > csk_mem_free() should return true if send buffer is available, > > false otherwise. > > > Fixes: 3b8305f5c844 ("crypto: chtls - wait

Re: [PATCH v5 3/3] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-10-28 Thread Jakub Kicinski
On Wed, 28 Oct 2020 10:09:50 +1000 Pavana Sharma wrote: > The Marvell 88E6393X device is a single-chip integration of a 11-port > Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers > and three 10-Gigabit interfaces. > > This patch adds functionalities specific to mv88e6393x

Re: [PATCH/RFC net-next v3] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-28 Thread Jakub Kicinski
On Tue, 27 Oct 2020 18:59:09 -0700 Moritz Fischer wrote: > Hi Jakub, > > On Tue, Oct 27, 2020 at 04:16:06PM -0700, Jakub Kicinski wrote: > > On Fri, 23 Oct 2020 13:28:34 -0700 Moritz Fischer wrote: > > > diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c > >

Re: [PATCH] mdio: use inline functions for to_mdio_device() etc

2020-10-28 Thread Jakub Kicinski
On Mon, 26 Oct 2020 17:51:09 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Nesting container_of() causes warnings with W=2, and doing this > in a header means we see a lot of them, like: > > In file included from drivers/net/mdio/of_mdio.c:11: > drivers/net/mdio/of_mdio.c: In function

Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.

2020-10-28 Thread Jakub Kicinski
On Mon, 26 Oct 2020 20:04:07 +0100 Thomas Bogendoerfer wrote: > > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > > > From: Thomas Bogendoerfer > > > > > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > > > Commit 6f2275433a2f wanted to shut down

Re: [PATCH] net/atm: use list_is_singular() in br2684_setfilt()

2020-10-28 Thread Jakub Kicinski
On Tue, 27 Oct 2020 00:57:00 +0800 Hui Su wrote: > list_is_singular() can tell whether a list has just one entry. > So we use list_is_singular() here. > > Signed-off-by: Hui Su > --- > net/atm/br2684.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/atm/br2684.c

Re: [RFC] wimax: move out to staging

2020-10-29 Thread Jakub Kicinski
On Wed, 28 Oct 2020 06:56:28 +0100 Greg Kroah-Hartman wrote: > On Tue, Oct 27, 2020 at 10:20:13PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > There are no known users of this driver as of October 2020, and it will > > be removed unless someone turns out to still need it in future

Re: [PATCH v2 net 0/5] net: ipa: minor bug fixes

2020-10-29 Thread Jakub Kicinski
On Wed, 28 Oct 2020 14:41:43 -0500 Alex Elder wrote: > This series fixes several bugs. They are minor, in that the code > currently works on supported platforms even without these patches > applied, but they're bugs nevertheless and should be fixed. By which you mean "it seems to work just fine

Re: [RFC] wimax: move out to staging

2020-10-29 Thread Jakub Kicinski
On Thu, 29 Oct 2020 17:26:09 +0100 Arnd Bergmann wrote: > n Thu, Oct 29, 2020 at 4:56 PM Jakub Kicinski wrote: > > On Wed, 28 Oct 2020 06:56:28 +0100 Greg Kroah-Hartman wrote: > > > On Tue, Oct 27, 2020 at 10:20:13PM +0100, Arnd Bergmann wrote: > > > > > &g

Re: [PATCH v3 net] gtp: fix an use-before-init in gtp_newlink()

2020-10-29 Thread Jakub Kicinski
On Tue, 27 Oct 2020 20:48:46 +0900 Masahiro Fujiwara wrote: > *_pdp_find() from gtp_encap_recv() would trigger a crash when a peer > sends GTP packets while creating new GTP device. > > RIP: 0010:gtp1_pdp_find.isra.0+0x68/0x90 [gtp] > > Call Trace: > > gtp_encap_recv+0xc2/0x2e0 [gtp] > ?

Re: [PATCH v2] netem: fix zero division in tabledist

2020-10-29 Thread Jakub Kicinski
On Wed, 28 Oct 2020 11:19:59 -0700 Stephen Hemminger wrote: > On Wed, 28 Oct 2020 17:07:31 + > Aleksandr Nogikh wrote: > > > From: Aleksandr Nogikh > > > > Currently it is possible to craft a special netlink RTM_NEWQDISC > > command that can result in jitter being equal to 0x8000. It

[GIT PULL] Networking

2020-10-29 Thread Jakub Kicinski
in current release - vsock: use ns_capable_noaudit() on socket create to suppress false positive audit messages Signed-off-by: Jakub Kicinski Aleksandr Nogikh (1): netem: fix zero division in tabledist Alex Elder (1

Re: [PATCH net] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-25 Thread Jakub Kicinski
On Fri, 25 Sep 2020 15:25:15 +0800 Willy Liu wrote: > There are two chip pins named TXDLY and RXDLY which actually adds the 2ns > delays to TXC and RXC for TXD/RXD latching. These two pins can config via > 4.7k-ohm resistor to 3.3V hw setting, but also config via software setting > (extension page

Re: [PATCH] net: macvlan: remove redundant initialization in macvlan_dev_netpoll_setup

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 06:53:11 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The initialization for err with 0 seems useless, as it is soon updated > with -ENOMEM. So, we can init err with -ENOMEM. > > Signed-off-by: Menglong Dong > --- > drivers/net/macvlan.c | 3 +-- > 1

Re: [PATCH v8 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 16:40:27 +0100 Andrea Parri (Microsoft) wrote: > From: Andres Beltran > > Currently, pointers to guest memory are passed to Hyper-V as > transaction IDs in netvsc. In the face of errors or malicious > behavior in Hyper-V, netvsc should not expose or trust the transaction >

Re: [PATCH v8 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 13:43:48 -0800 Jakub Kicinski wrote: > On Wed, 4 Nov 2020 16:40:27 +0100 Andrea Parri (Microsoft) wrote: > > From: Andres Beltran > > > > Currently, pointers to guest memory are passed to Hyper-V as > > transaction IDs in netvsc. In the

Re: [PATCH net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 11:01:47 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjphase() to support PHC write phase mode. > > Signed-off-by: Min Li This appears to break the build. Each patch must build, otherwise we're risking breaking builds when people bisect bugs with git

Re: [PATCH v1] lan743x: correctly handle chips with internal PHY

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 11:08:47 -0500 Sven Van Asbroeck wrote: > Tested-by: Sven Van Asbroeck # lan7430 > Signed-off-by: Sven Van Asbroeck Not a big deal but if you have to change the patch could you make sure your email address is spelled the same in the From line and other tags?

Re: [PATCH v2 net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-04 Thread Jakub Kicinski
On Wed, 4 Nov 2020 18:13:44 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjphase() to support PHC write phase mode. > > Changes since v1: > -Fix broken build One more trivial thing detected by checkpatch: ERROR: trailing whitespace #41: FILE:

Re: [RESEND PATCH v3] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-11-04 Thread Jakub Kicinski
On Mon, 2 Nov 2020 23:09:46 +0530 Anant Thazhemadam wrote: > Currently, __usbnet_{read|write}_cmd() use usb_control_msg(). > However, this could lead to potential partial reads/writes being > considered valid, and since most of the callers of > usbnet_{read|write}_cmd() don't take partial

Re: [PATCH net-next 0/6] net: ipa: tell GSI the IPA version

2020-11-04 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:53:54 -0600 Alex Elder wrote: > The GSI code that supports IPA avoids having knowledge about the > IPA layer it serves. One result of this is that Boolean flags are > used during GSI initialization to convey that certain hardware > version-dependent special behaviors should

Re: [PATCH net-next v2 1/2][RESEND] net: phy: adin: disable diag clock & disable standby mode in config_aneg

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 09:44:35 +0200 Alexandru Ardelean wrote: > When the PHY powers up, the diagnostics clock isn't enabled (bit 2 in > register PHY_CTRL_1 (0x0012)). > Also, the PHY is not in standby mode, so bit 13 in PHY_CTRL_3 (0x0017) is > always set at power up. > > The standby mode and the

Re: [PATCH -next] dpaa_eth: use false and true for bool variables

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 12:13:29 + Madalin Bucur wrote: > > Fix coccicheck warnings: > > > > ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable > > ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable > > > > Reported-by: Hulk Robot > > Signed-off-by: Zou Wei >

Re: [PATCH V2] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-04 Thread Jakub Kicinski
On Tue, 3 Nov 2020 19:23:23 +0800 Yu Kuai wrote: > --- a/drivers/net/ethernet/freescale/fman/fman_port.c > +++ b/drivers/net/ethernet/freescale/fman/fman_port.c > @@ -1792,20 +1792,21 @@ static int fman_port_probe(struct platform_device > *of_dev) > if (!fm_node) { >

Re: [PATCH -next] net/mlx5: simplify the return expression of mlx5_ec_init()

2020-09-22 Thread Jakub Kicinski
On Mon, 21 Sep 2020 22:52:30 -0700 Saeed Mahameed wrote: > On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote: > > Simplify the return expression. > > > > Signed-off-by: Qinglang Miao > > --- > > drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 6 +- > > 1 file changed, 1 insertion(+),

Re: [net-next PATCH 0/2] Add support for VLAN based flow distribution

2020-09-22 Thread Jakub Kicinski
> - Multi VLAN flow with same SDFN > - Single VLAN flow with multi SD > - Single VLAN flow with multi SDFN > All tests done for udp/tcp both v4 and v6 Reviewed-by: Jakub Kicinski

Re: [GIT] Networking

2020-09-22 Thread Jakub Kicinski
On Tue, 22 Sep 2020 15:02:24 -0700 Linus Torvalds wrote: > Pulled. Thanks! > (a) please put "git pull" somewhere in the email (lots of people just > put it in the subject by prepending it with "[GIT PULL]" but all I > really look for is "git" and "pull" anywhere in the email. You had the >

Re: [PATCH] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-23 Thread Jakub Kicinski
On Wed, 23 Sep 2020 09:52:09 +0200 Wilken Gottwalt wrote: > Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 > ethernet adapter. > > Signed-off-by: Wilken Gottwalt Please repost your patches and CC net...@vger.kernel.org.

Re: [PATCH net-next RFC v5 01/15] devlink: Add reload action option to devlink reload command

2020-09-23 Thread Jakub Kicinski
On Fri, 18 Sep 2020 19:06:37 +0300 Moshe Shemesh wrote: > Add devlink reload action to allow the user to request a specific reload > action. The action parameter is optional, if not specified then devlink > driver re-init action is used (backward compatible). > Note that when required to do

Re: KASAN vs RCU vs RT

2020-09-28 Thread Jakub Kicinski
On Sat, 26 Sep 2020 08:57:32 +0200 Dmitry Vyukov wrote: > On Sat, Sep 26, 2020 at 3:43 AM Jakub Kicinski wrote: > > > > Hi! > > > > I couldn't find this being reported in a quick search, so let me ask. > > > > With 5.9 I'm seeing a lot (well,

Re: [PATCH net v3] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-28 Thread Jakub Kicinski
On Mon, 28 Sep 2020 13:52:23 +0800 Willy Liu wrote: > diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c > old mode 100644 > new mode 100755 Please don't change the file mode to executable. Checkpatch should warn you about this.

Re: [PATCH v6 4/4] Bluetooth: Add toggle to switch off interleave scan

2020-09-28 Thread Jakub Kicinski
On Mon, 28 Sep 2020 15:41:21 +0800 Howard Chung wrote: > This patch add a configurable parameter to switch off the interleave > scan feature. > > Signed-off-by: Howard Chung > Reviewed-by: Alain Michaud This seems to cause new warnings on W=1 C=1 builds: In file included from

Re: [net PATCH] octeontx2-af: Fix enable/disable of default NPC entries

2020-09-28 Thread Jakub Kicinski
On Sat, 26 Sep 2020 12:27:00 +0530 Geetha sowjanya wrote: > From: Subbaraya Sundeep > > Packet replication feature present in Octeontx2 > is a hardware linked list of PF and its VF > interfaces so that broadcast packets are sent > to all interfaces present in the list. It is > driver job to add

Re: [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 12:42:55 +0200 Ondrej Zary wrote: > On Monday 12 October 2020, Jakub Kicinski wrote: > > On Sat, 10 Oct 2020 16:00:46 +0200 Ondrej Zary wrote: > > > When the router is rebooted without a power cycle, the USB device > > > remains connected but

Re: [net v4] net: dsa: microchip: fix race condition

2020-10-12 Thread Jakub Kicinski
itch() > has completed. > > Fixes: 7c6ff470aa86 ("net: dsa: microchip: add MIB counter reading support") > Signed-off-by: Christian Eggers > Reviewed-by: Florian Fainelli > Reviewed-by: Vladimir Oltean > Reviewed-by: Jakub Kicinski Now you went too far in the op

Re: [PATCH v2] net: korina: fix kfree of rx/tx descriptor array

2020-10-12 Thread Jakub Kicinski
On Sun, 11 Oct 2020 18:53:31 -0400 Willem de Bruijn wrote: > On Sun, Oct 11, 2020 at 6:04 PM Valentin Vidic wrote: > > kmalloc returns KSEG0 addresses so convert back from KSEG1 > > in kfree. Also make sure array is freed when the driver is > > unloaded from the kernel. > > > > Fixes: ef11291bcd5f

Re: [PATCH v1 net-next] net: stmmac: Enable EEE HW LPI timer with auto SW/HW switching

2020-10-12 Thread Jakub Kicinski
On Fri, 9 Oct 2020 00:11:23 +0800 Voon Weifeng wrote: > From: "Vineetha G. Jaya Kumaran" > > This patch enables the HW LPI Timer which controls the automatic entry > and exit of the LPI state. > The EEE LPI timer value is configured through ethtool. The driver will > auto select the LPI HW

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 18:59:28 +0300 Aleksandr Nogikh wrote: > On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > &g

Re: [PATCH] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 17:31:51 +0530 Reji Thomas wrote: > Currently End.X action doesn't consider the outgoing interface > while looking up the nexthop.This breaks packet path functionality > specifically while using link local address as the End.X nexthop. > The patch fixes this by enforcing End.X

<    7   8   9   10   11   12   13   14   15   16   >