Re: [PATCH 0/5] net: use semicolons rather than commas to separate statements

2020-10-13 Thread Jakub Kicinski
On Sun, 11 Oct 2020 12:34:53 +0200 Julia Lawall wrote: > These patches replace commas by semicolons. Commas introduce > unnecessary variability in the code structure and are hard to see. > This was done using the Coccinelle semantic patch > (http://coccinelle.lip6.fr/) shown below. Applied 3-5

Re: [PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 22:10:31 -0700 Deepa Dinamani wrote: > > On Mon, Oct 12, 2020 at 5:36 AM Christian Eggers wrote: > > > v2: > > > - > > > - integrated proposal from Willem de Bruijn > > > - added Reviewed-by: from Willem and Deepa > > You may add my > Acked-by: Deepa Dinamani

Re: [PATCH] net/af_unix: Remove unused old_pid variable

2020-10-13 Thread Jakub Kicinski
On Sun, 11 Oct 2020 18:35:27 +0300 Or Cohen wrote: > Commit 109f6e39fa07c48f5801 ("af_unix: Allow SO_PEERCRED > to work across namespaces.") introduced the old_pid variable > in unix_listen, but it's never used. > Remove the declaration and the call to put_pid. > > Signed-off-by: Or Cohen

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Jakub Kicinski
On Tue, 3 Nov 2020 10:32:41 +0100 Greg Kroah-Hartman wrote: > On Mon, Nov 02, 2020 at 11:47:18AM -0800, Jakub Kicinski wrote: > > On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote: > > > Jakub Kicinski > > > > Can you describe the use case in more detail?

Re: [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence

2020-11-03 Thread Jakub Kicinski
On Tue, 3 Nov 2020 08:35:09 +0100 Paul Menzel wrote: > According to *Developer's Certificate of Origin 1.1* [3], it’s my > understanding, that it is *not* required. The items (a), (b), and (c) > are connected by an *or*. > > > (b) The contribution is based upon previous work that, to

Re: [PATCH V2] net: ethernet: mscc: fix missing brace warning for old compilers

2020-11-03 Thread Jakub Kicinski
On Tue, 3 Nov 2020 10:55:19 +0800 Pujin Shi wrote: > For older versions of gcc, the array = {0}; will cause warnings: Please include the version of gcc which generates this warning here. > drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set': >

Re: [PATCH stable] net: sch_generic: fix the missing new qdisc assignment bug

2020-11-03 Thread Jakub Kicinski
aviod concurrent reset and enqueue op > for lockless qdisc") > Signed-off-by: Yunsheng Lin Acked-by: Jakub Kicinski

Re: [PATCH] net: ipv6: remove redundant blank in ip6_frags_ns_sysctl_register

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 22:24:03 +0800 Menglong Dong wrote: > From: Menglong Dong > > This blank seems redundant. > > Signed-off-by: Menglong Dong It is redundant but cleanup like this is not worth the potential conflicts when backporting fixes.

Re: [PATCH v2 net 1/1] ptp: idt82p33: add adjphase support

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 10:27:28 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjwritephase() to support PHC write phase mode. > > Changes since v1: > - Fix broken build on 32 bit machine due to 64 bit division. > > Signed-off-by: Min Li > --- > drivers/ptp/ptp_idt82p33.c |

Re: [PATCH v2 net 1/1] ptp: idt82p33: add adjphase support

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 10:27:28 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjwritephase() to support PHC write phase mode. > > Changes since v1: > - Fix broken build on 32 bit machine due to 64 bit division. Oh, and also please mark this as [PATCH net-next] in the subject,

Re: [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-11-03 Thread Jakub Kicinski
On Sat, 31 Oct 2020 11:10:38 -0700 Xie He wrote: > The main purpose of this series is the last patch. The previous 4 patches > are just code clean-ups so that the last patch will not make the code too > messy. The patches must be applied in sequence. > > The receiving code of this driver doesn't

Re: [PATCH v2 net-next 0/2] net: allow virtual netdevs to forward UDP L4 and fraglist GSO skbs

2020-11-03 Thread Jakub Kicinski
On Sun, 01 Nov 2020 13:16:32 + Alexander Lobakin wrote: > NETIF_F_GSO_UDP_L4 and NETIF_F_GSO_FRAGLIST allow drivers to offload > GSO UDP L4. This works well on simple setups, but when any logical > netdev (e.g. VLAN) is present, kernel stack always performs software > resegmentation which

Re: [PATCH v3] lan743x: fix for potential NULL pointer dereference with bare card

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote: > This is the 3rd revision of the patch fix for potential null pointer > dereference > with lan743x card. > > The simpliest way to reproduce: boot with bare lan743x and issue "ethtool > ethN" > commant where ethN is the interface with

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Jakub Kicinski
On Wed, 4 Nov 2020 01:39:52 + Hayes Wang wrote: > Jakub Kicinski > > Sent: Wednesday, November 4, 2020 12:16 AM > [...] > > > So no, please do not create such a common file, it is not needed or a > > > good idea. > > > > I wouldn't go that far

Re: [PATCH net-next v2] net: phy: realtek: Add support for RTL8221B-CG series

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 09:52:07 +0800 Willy Liu wrote: > Realtek single-port 2.5Gbps Ethernet PHYs are list as below: > RTL8226-CG: the 1st generation 2.5Gbps single port PHY > RTL8226B-CG/RTL8221B-CG: the 2nd generation 2.5Gbps single port PHY > RTL8221B-VB-CG: the 3rd generation 2.5Gbps single port

Re: [PATCH] forcedeth: fix excluded_middle.cocci warnings

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 09:38:30 +0100 (CET) Julia Lawall wrote: > From: kernel test robot > > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script") > CC: Denis

Re: [PATCH] net: dev_ioctl: remove redundant initialization of variable err

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 12:16:15 + Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value")

Re: [PATCH] octeontx2-pf: Fix sizeof() mismatch

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 13:46:01 + Colin King wrote: > From: Colin Ian King > > An incorrect sizeof() is being used, sizeof(u64 *) is not correct, > it should be sizeof(*sq->sqb_ptrs). > > Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues") > Addresses-Coverity: ("Sizeof not

Re: [PATCH net-next] net: ipa: restrict special reset to IPA v3.5.1

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:34:35 -0600 Alex Elder wrote: > With IPA v3.5.1, if IPA aggregation is active at the time an > underlying GSI channel reset is performed, some special handling > is required. > > There is logic in ipa_endpoint_reset() that arranges for that > special handling, but it's done

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-31 Thread Jakub Kicinski
On Fri, 30 Oct 2020 22:10:42 -0700 Xie He wrote: > > The usual way of getting rid of old code is to move it to staging/ > > for a few releases then delete it, like Arnd just did with wimax. > > Oh. OK. But I see "include/linux/if_frad.h" is included in > "net/socket.c", and there's still some

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 19:45:46 -0700 Hemant Kumar wrote: > +/* .driver_data stores max mtu */ > +static const struct mhi_device_id mhi_uci_match_table[] = { > + { .chan = "LOOPBACK", .driver_data = 0x1000}, > + {}, > +}; > +MODULE_DEVICE_TABLE(mhi, mhi_uci_match_table); I forgot to follow

Re: [PATCH] net: ethernet: ti: cpsw: disable PTPv1 hw timestamping advertisement

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 21:09:10 +0200 Grygorii Strashko wrote: > The TI CPTS does not natively support PTPv1, only PTPv2. But, as it > happens, the CPTS can provide HW timestamp for PTPv1 Sync messages, because > CPTS HW parser looks for PTP messageType id in PTP message octet 0 which > value is 0

Re: [PATCH net-next] selftests/net: timestamping: add ptp v2 support

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 21:09:31 +0200 Grygorii Strashko wrote: > The timestamping tool is supporting now only PTPv1 (IEEE-1588 2002) while > modern HW often supports also/only PTPv2. > > Hence timestamping tool is still useful for sanity testing of PTP drivers > HW timestamping capabilities it's

Re: [PATCH] net: atm: fix update of position index in lec_seq_next

2020-10-31 Thread Jakub Kicinski
On Tue, 27 Oct 2020 11:49:25 + Colin King wrote: > From: Colin Ian King > > The position index in leq_seq_next is not updated when the next > entry is fetched an no more entries are available. This causes > seq_file to report the following error: > > "seq_file: buggy .next function

Re: [PATCH net-next] net: ipa: avoid a bogus warning

2020-10-31 Thread Jakub Kicinski
On Sat, 31 Oct 2020 10:15:24 -0500 Alex Elder wrote: > The previous commit added support for IPA having up to six source > and destination resources. But currently nothing uses more than > four. (Five of each are used in a newer version of the hardware.) > > I find that in one of my build

Re: [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Jakub Kicinski
On Sat, 31 Oct 2020 15:47:28 -0400 Willem de Bruijn wrote: > On Sat, Oct 31, 2020 at 12:02 PM Xie He wrote: > > On Sat, Oct 31, 2020 at 8:18 AM Xie He wrote: > > > > Especially without that, I'm not sure this and the follow-on patch add > > > > much value. Minor code cleanups complicate

Re: [PATCH v2] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 18:52:56 +0530 Anant Thazhemadam wrote: > + return usb_control_msg_recv(dev->udev, 0, > + cmd, reqtype, value, index, data, size, > + USB_CTRL_GET_TIMEOUT, GFP_KERNEL); Please align continuation lines after the opening

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-31 Thread Jakub Kicinski
On Sat, 31 Oct 2020 22:41:30 +0100 Arnd Bergmann wrote: > On Sat, Oct 31, 2020 at 5:53 PM Jakub Kicinski wrote: > > > > On Fri, 30 Oct 2020 22:10:42 -0700 Xie He wrote: > > > > The usual way of getting rid of old code is to move it to staging/ > > > >

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 19:34:48 +0800 Yunsheng Lin wrote: > The current semantic for napi_consume_skb() is that caller need > to provide non-zero budget when calling from NAPI context, and > breaking this semantic will cause hard to debug problem, because > _kfree_skb_defer() need to run in atomic

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-10-31 Thread Jakub Kicinski
On Fri, 30 Oct 2020 11:23:08 +0800 Hayes Wang wrote: > Support ECM mode based on cdc_ether with relative mii functions, > when CONFIG_USB_RTL8152 is not set, or the device is not supported > by r8152 driver. > > Signed-off-by: Hayes Wang Can you describe the use case in more detail? AFAICT

Re: [RESEND PATCH v5] net: macb: add support for high speed interface

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 13:47:07 +0100 Parshuram Thombare wrote: > This patch adds support for 10GBASE-R interface to the linux driver for > Cadence's ethernet controller. > This controller has separate MAC's and PCS'es for low and high speed paths. > High speed PCS supports 100M, 1G, 2.5G, 5G and 10G

Re: [PATCH net-next 02/13] octeontx2-af: Verify MCAM entry channel and PF_FUNC

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:41:11 +0530 Naveen Mamindlapalli wrote: > From: Subbaraya Sundeep > > This patch adds support to verify the channel number sent by > mailbox requester before writing MCAM entry for Ingress packets. > Similarly for Egress packets, verifying the PF_FUNC sent by the > mailbox

Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit mask from KEX profile

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:41:12 +0530 Naveen Mamindlapalli wrote: > From: Subbaraya Sundeep > > Key Extraction(KEX) profile decides how the packet metadata such as > layer information and selected packet data bytes at each layer are > placed in MCAM search key. This patch reads the configured KEX

Re: [PATCH net-next 10/13] octeontx2-pf: Add support for SR-IOV management functions

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:41:19 +0530 Naveen Mamindlapalli wrote: > This patch adds support for ndo_set_vf_mac, ndo_set_vf_vlan > and ndo_get_vf_config handlers. The traffic redirection > based on the VF mac address or vlan id is done by installing > MCAM rules. Reserved RX_VTAG_TYPE7 in each NIXLF

Re: [net-next PATCH 0/3] Add devlink and devlink health reporters to

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 10:36:46 +0530 George Cherian wrote: > Add basic devlink and devlink health reporters. > Devlink health reporters are added for NPA and NIX blocks. > These reporters report the error count in respective blocks. > > Address Jakub's comment to add devlink support for error

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:14:32 +0800 Yunsheng Lin wrote: > On 2020/11/1 6:38, Jakub Kicinski wrote: > > On Thu, 29 Oct 2020 19:34:48 +0800 Yunsheng Lin wrote: > >> The current semantic for napi_consume_skb() is that caller need > >> to provide non-zero budget whe

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote: > Jakub Kicinski > > Can you describe the use case in more detail? > > > > AFAICT r8152 defines a match for the exact same device. > > Does it not mean that which driver is used will be somewhat random > > i

Re: [PATCH] net: ethernet: mscc: fix missing brace warning for old compilers

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 13:56:55 + Vladimir Oltean wrote: > On Mon, Nov 02, 2020 at 09:41:36PM +0800, Pujin Shi wrote: > > For older versions of gcc, the array = {0}; will cause warnings: > > > > drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set': > >

Re: [PATCH] net: ethernet: ti: cpsw: disable PTPv1 hw timestamping advertisement

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 19:02:27 -0700 Richard Cochran wrote: > On Sat, Oct 31, 2020 at 11:40:42AM -0700, Jakub Kicinski wrote: > > On Thu, 29 Oct 2020 21:09:10 +0200 Grygorii Strashko wrote: > > > The TI CPTS does not natively support PTPv1, only PTPv2. But, as it > >

Re: [PATCH net-next] selftests/net: timestamping: add ptp v2 support

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 19:01:41 -0700 Richard Cochran wrote: > On Sat, Oct 31, 2020 at 11:40:40AM -0700, Jakub Kicinski wrote: > > On Thu, 29 Oct 2020 21:09:31 +0200 Grygorii Strashko wrote: > > > The timestamping tool is supporting now only PTPv1 (IEEE-1588 2002) while >

Re: [PATCH] sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on big-endian platforms

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 10:27:17 -0300 Marcelo Ricardo Leitner wrote: > On Fri, Oct 30, 2020 at 02:26:33PM +0100, Petr Malat wrote: > > Commit 978aa0474115 ("sctp: fix some type cast warnings introduced since > > very beginning")' broke err reading from sctp_arg, because it reads the > > value as

Re: [PATCH v3 0/3] add ast2400/2500 phy-handle support

2020-11-02 Thread Jakub Kicinski
On Fri, 30 Oct 2020 16:37:04 +0300 Ivan Mikhaylov wrote: > This patch introduces ast2400/2500 phy-handle support with an embedded > MDIO controller. At the current moment it is not possible to set options > with this format on ast2400/2500: > > mac { > phy-handle = <>; > phy-mode =

Re: [PATCH net] net: dsa: qca8k: Fix port MTU setting

2020-11-02 Thread Jakub Kicinski
On Fri, 30 Oct 2020 19:47:33 +0100 Andrew Lunn wrote: > On Fri, Oct 30, 2020 at 06:33:15PM +, Jonathan McDowell wrote: > > The qca8k only supports a switch-wide MTU setting, and the code to take > > the max of all ports was only looking at the port currently being set. > > Fix to examine all

Re: [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence

2020-11-02 Thread Jakub Kicinski
On Tue, 3 Nov 2020 00:13:07 +0100 Paul Menzel wrote: > From: Jeffrey Townsend > > The ops field might no be defined, so add a check. This change should be first, otherwise AFAIU if someone builds the kernel in between the commits (e.g. for bisection) it will crash. > The patch is taken from

Re: [PATCH net-next v3 00/10] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

2020-11-02 Thread Jakub Kicinski
On Fri, 30 Oct 2020 22:06:57 +0200 Grygorii Strashko wrote: > This series adds multi-port support in mac-only mode (multi MAC mode) to TI > AM65x CPSW driver in preparation for enabling support for multi-port devices, > like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC. > > The

Re: [PATCH net-next 0/7] VLAN improvements for Ocelot switch

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 12:29:09 +0200 Vladimir Oltean wrote: > The main reason why I started this work is that deleting the bridge mdb > entries fails when the bridge is deleted, as described here: > https://lore.kernel.org/netdev/20201015173355.564934-1-vladimir.olt...@nxp.com/ > > In short, that

Re: [PATCH] sfp: Fix error handing in sfp_probe()

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 19:56:05 +0100 Andrew Lunn wrote: > On Sat, Oct 31, 2020 at 11:10:53AM +0800, YueHaibing wrote: > > gpiod_to_irq() never return 0, but returns negative in > > case of error, check it and set gpio_irq to 0. > > > > Fixes: 73970055450e ("sfp: add SFP module support") > >

Re: [PATCH] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 18:54:18 +0800 Yu Kuai wrote: > if of_find_device_by_node() succeed, fman_port_probe() doesn't have a > corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. > > Fixes: 0572054617f3 ("fsl/fman: fix dereference null

Re: [PATCH net-next] liquidio: cn68xx: Remove duplicated include

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 10:47:44 +0800 YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing Applied, thanks!

Re: [PATCH net-next] openvswitch: Use IS_ERR instead of IS_ERR_OR_NULL

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 14:01:53 +0800 YueHaibing wrote: > Fix smatch warning: > > net/openvswitch/meter.c:427 ovs_meter_cmd_set() warn: passing zero to > 'PTR_ERR' > > dp_meter_create() never returns NULL, use IS_ERR > instead of IS_ERR_OR_NULL to fix this. > > Signed-off-by: YueHaibing

Re: [PATCH net-next] net: hns3: Remove duplicated include

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 10:49:40 +0800 YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing Applied, thanks!

Re: [PATCH] net: dsa: mt7530: remove unneeded semicolon

2020-11-02 Thread Jakub Kicinski
On Sat, 31 Oct 2020 08:30:47 -0700 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Applied.

Re: [PATCH] net: stmmac: dwmac-meson8b: remove unneeded semicolon

2020-11-02 Thread Jakub Kicinski
On Sun, 1 Nov 2020 06:07:20 -0800 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Applied..

Re: [PATCH] tipc: remove unneeded semicolon

2020-11-02 Thread Jakub Kicinski
On Sun, 1 Nov 2020 07:58:22 -0800 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix ... and applied. Thanks! :)

Re: [PATCH] net/mlx4_core : remove unneeded semicolon

2020-11-02 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:31:57 +0200 Tariq Toukan wrote: > On 11/1/2020 4:05 PM, t...@redhat.com wrote: > > From: Tom Rix > > > > A semicolon is not needed after a switch statement. > > > > Signed-off-by: Tom Rix > > Reviewed-by: Tariq Toukan Applied.

Re: [PATCH] net: core: remove unneeded semicolon

2020-11-02 Thread Jakub Kicinski
On Sun, 1 Nov 2020 07:36:47 -0800 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Applied...

Re: [PATCH] ethtool: remove unneeded semicolon

2020-11-02 Thread Jakub Kicinski
On Sun, 1 Nov 2020 07:56:01 -0800 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Applied

Re: [PATCH v5 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling

2020-11-02 Thread Jakub Kicinski
On Thu, 29 Oct 2020 17:36:17 + Aleksandr Nogikh wrote: > From: Aleksandr Nogikh > > This patch series enables remote KCOV coverage collection during > 802.11 frames processing. These changes make it possible to perform > coverage-guided fuzzing in search of remotely triggerable bugs. > >

Re: [1/2] PCI-Express Non-Transparent Bridge Support

2012-10-07 Thread Jakub Kicinski
Hi, it's good to see some NTB code getting into mainline! I have a few comments though. On Tue, 02 Oct 2012 21:26:16 -, Jon Mason wrote: [...] >+/** >+ * ntb_write_local_spad() - write to the secondary scratchpad register >+ * @ndev: pointer to ntb_device instance >+ * @idx: index to the

Re: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 11:15:43 + Oleksandr Mazur wrote: > > Thinking about it again - if the action can be changed wouldn't it > > be best for the user to actually get a "HW condition hit" counter, > > which would increment regardless of SW config (incl. policers)? > > > Otherwise if admin

Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 14:52:35 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > The buffers in the lan743x driver's receive ring are always 9K, > even when the largest packet that can be received (the mtu) is > much smaller. This performs particularly badly on cpu archs > without dma

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 09:56:48 -0800 Shoaib Rao wrote: > On 1/25/21 3:36 PM, Jakub Kicinski wrote: > > On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: > >> From: Rao Shoaib > >> > >> TCP sockets allow SIGURG to be sent to the process hold

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote: > >> SO_OOBINLINE does not control the delivery of signal, It controls how > >> OOB Byte is delivered. It may not be obvious but this change does not > >> deliver any Byte, just a signal. So, as long as sendmsg flag contains > >> MSG_OOB, signal

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote: > On 1/29/21 12:18 PM, Jakub Kicinski wrote: > > On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: > >> The code does not care about the size of data -- All it does is that if > >> MSG_OOB is set it will del

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: > On 1/29/21 12:02 PM, Jakub Kicinski wrote: > > On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote: > >> Data was discarded because the flag was not supported, this patch > >> changes that but does not support any

Re: [PATCH net] net: hdlc_x25: Use qdisc to queue outgoing LAPB frames

2021-01-28 Thread Jakub Kicinski
On Wed, 27 Jan 2021 01:07:47 -0800 Xie He wrote: > An HDLC hardware driver may call netif_stop_queue to temporarily stop > the TX queue when the hardware is busy sending a frame, and after the > hardware has finished sending the frame, call netif_wake_queue to > resume the TX queue. > > However,

[GIT PULL] Networking for 5.11-rc6

2021-01-28 Thread Jakub Kicinski
Signed-off-by: Jakub Kicinski Brett Creeley (2): ice: Don't allow more channels than LAN MSI-X available ice: Fix MSI-X vector fallback logic Cong Wang (1): af_key: relax availability checks for skb size calculation

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > The current patchset only supports QMI channel so I'd request you to > > > revi

Re: [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 09:54:22 -0800 Randy Dunlap wrote: > On 2/3/21 7:15 AM, Bhaskar Chowdhury wrote: > > > > s/initialsation/initialisation/ > > s/specifiing/specifying/ > > > > Signed-off-by: Bhaskar Chowdhury > > Hi, > > $Subject has a typo/spello. This happens more than you'd think with

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Jakub Kicinski
On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > >> Jakub, Dave, Adding you both to get your reviews on this series. I've > >> provided an explanation above and in the previous iteration [1]. > > > >Let's be clear what the review would be for. Yet another QMI chardev > >or the

Re: [PATCH net] net: lapb: Copy the skb before sending a packet

2021-02-01 Thread Jakub Kicinski
On Mon, 1 Feb 2021 08:14:31 -0800 Xie He wrote: > On Mon, Feb 1, 2021 at 6:10 AM Julian Wiedmann wrote: > > This sounds a bit like you want skb_cow_head() ... ? > > Calling "skb_cow_head" before we call "skb_clone" would indeed solve > the problem of writes to our clones affecting clones in

Re: [PATCH] NET: usb: qmi_wwan: Adding support for Cinterion MV31

2021-02-01 Thread Jakub Kicinski
On Fri, 29 Jan 2021 14:30:01 +0100 Christoph Schemmel wrote: > Adding support for Cinterion MV31 with PID 0x00B7. > > T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 11 Spd=5000 MxCh= 0 > D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 > P: Vendor=1e2d ProdID=00b7 Rev=04.14 > S:

Re: [PATCH v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage

2021-02-01 Thread Jakub Kicinski
On Sun, 31 Jan 2021 12:11:16 + Alexander Lobakin wrote: > page_is_pfmemalloc() is used mostly by networking drivers to test > if a page can be considered for reusing/recycling. > It doesn't write anything to the struct page itself, so its sole > argument can be constified, as well as the first

Re: [PATCH v7 net-next 00/15] net: mvpp2: Add TX Flow Control support

2021-02-01 Thread Jakub Kicinski
On Sun, 31 Jan 2021 16:33:43 +0200 stef...@marvell.com wrote: > v6 --> v7 > - Reduce patch set from 18 to 15 patches > - Documentation change combined into a single patch > - RXQ and BM size change combined into a single patch > - Ring size change check moved into "add RXQ flow control

Re: [PATCH] r8169: Add support for another RTL8168FP

2021-02-01 Thread Jakub Kicinski
On Tue, 2 Feb 2021 00:47:35 +0800 Kai-Heng Feng wrote: > According to the vendor driver, the new chip with XID 0x54b is > essentially the same as the one with XID 0x54a, but it doesn't need the > firmware. > > So add support accordingly. > > Signed-off-by: Kai-Heng Feng Please rebase on top

Re: [PATCH] octeontx2-af: remove unneeded semicolon

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 15:46:58 -0800 Jesse Brandeburg wrote: > Yang Li wrote: > > > Eliminate the following coccicheck warning: > > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3: > > Unneeded semicolon > > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4: > >

Re: [PATCH] net/qrtr: restrict user-controlled length in qrtr_tun_write_iter()

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 15:20:59 +0600 Sabyrzhan Tasbolatov wrote: > syzbot found WARNING in qrtr_tun_write_iter [1] when write_iter length > exceeds KMALLOC_MAX_SIZE causing order >= MAX_ORDER condition. > > Additionally, there is no check for 0 length write. > > [1] > WARNING: mm/page_alloc.c:5011

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 08:09:38 +0100 Juergen Gross wrote: > Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") > xenvif_rx_ring_slots_available() is no longer called only from the rx > queue kernel thread, so it needs to access the rx queue with the > associated queue held. > >

Re: [PATCH net-next 3/6] net: ipa: drop packet if status has valid tag

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 15:29:44 -0600 Alex Elder wrote: > Introduce ipa_endpoint_status_tag(), which returns true if received > status indicates its tag field is valid. The endpoint parameter is > not yet used. > > Call this from ipa_status_drop_packet(), and drop the packet if the > status

Re: [PATCH] nfc/ftp: fix typo issue

2021-01-26 Thread Jakub Kicinski
On Sat, 23 Jan 2021 15:48:35 +0800 samirweng1979 wrote: > From: wengjianfeng > > change 'paquet' to 'packet' > > Signed-off-by: wengjianfeng s/ftp/fdp/ Applied, thanks.

Re: [PATCH] bridge: Use PTR_ERR_OR_ZERO instead if(IS_ERR(...)) + PTR_ERR

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 10:23:00 +0200 Nikolay Aleksandrov wrote: > On 25/01/2021 04:39, Jiapeng Zhong wrote: > > coccicheck suggested using PTR_ERR_OR_ZERO() and looking at the code. > > > > Fix the following coccicheck warnings: > > > > ./net/bridge/br_multicast.c:1295:7-13: WARNING:

Re: [PATCH net-next v2 0/2] dsa: add MT7530 GPIO support

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 12:43:20 +0800 DENG Qingfang wrote: > MT7530's LED controller can be used as GPIO controller. Add support for > it. I added back Rob's tag and all the missing tags which patchwork did not register. Damn thing is really flaky right now. Anyway.. Applied, thanks everyone!

Re: BUG: Incorrect MTU on GRE device if remote is unspecified

2021-01-27 Thread Jakub Kicinski
On Mon, 25 Jan 2021 22:10:10 +0200 Slava Bacherikov wrote: > Hi, I'd like to report a regression. Currently, if you create GRE > interface on the latest stable or LTS kernel (5.4 branch) with > unspecified remote destination it's MTU will be adjusted for header size > twice. For example: > > $ ip

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Jakub Kicinski
On Wed, 27 Jan 2021 08:08:29 +0100 Mike Looijmans wrote: > > Andrew, I don't get what you're saying. > > > > Here is what happens depending on the pre-existing state of the > > reset signal: > > > > Reset (previously asserted): ~~~|_||___ > > Reset (previously deasserted):

Re: [PATCH v4 net-next] vmxnet3: Remove buf_info from device accessible structures

2021-01-27 Thread Jakub Kicinski
On Tue, 26 Jan 2021 11:06:40 -0800 Ronak Doshi wrote: > buf_info structures in RX & TX queues are private driver data that > do not need to be visible to the device. Although there is physical > address and length in the queue descriptor that points to these > structures, their layout is not

Re: [PATCH v11 0/3] AX88796C SPI Ethernet Adapter

2021-01-27 Thread Jakub Kicinski
On Mon, 25 Jan 2021 17:54:03 +0100 Łukasz Stelmach wrote: > This is a driver for AX88796C Ethernet Adapter connected in SPI mode as > found on ARTIK5 evaluation board. The driver has been ported from a > v3.10.9 vendor kernel for ARTIK5 board. This one doesn't apply to net-next cleanly, please

Re: [PATCH v2 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action

2021-01-27 Thread Jakub Kicinski
On Mon, 25 Jan 2021 14:31:21 +0200 Oleksandr Mazur wrote: > Whenever query statistics is issued for trap with DROP action, > devlink subsystem would also fill-in statistics 'dropped' field. > In case if device driver did't register callback for hard drop > statistics querying, 'dropped' field will

Re: [PATCH net-next] cxgb4: remove redundant NULL check

2021-01-27 Thread Jakub Kicinski
On Wed, 27 Jan 2021 12:04:27 +0530 Raju Rangoju wrote: > On Tuesday, January 01/26/21, 2021 at 10:50:13 +0800, Yang Li wrote: > > Fix below warnings reported by coccicheck: > > ./drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c:323:3-9: WARNING: > > NULL check before some freeing functions is not

Re: [PATCH] net: phy: remove h from printk format specifier

2021-01-28 Thread Jakub Kicinski
On Mon, 25 Jan 2021 08:45:28 -0800 t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is

Re: [PATCH resend] e100: switch from 'pci_' to 'dma_' API

2021-01-28 Thread Jakub Kicinski
On Thu, 28 Jan 2021 21:45:02 + Nguyen, Anthony L wrote: > > drivers/net/ethernet/intel/e100.c | 92 - > > My apologies, this patch slipped through the cracks for me. I will send > it in my next net-next 1GbE series or Jakub you can take it directly if > you'd like.

Re: [PATCH v5 net-next 00/18] net: mvpp2: Add TX Flow Control support

2021-01-28 Thread Jakub Kicinski
On Thu, 28 Jan 2021 20:31:04 +0200 stef...@marvell.com wrote: > From: Stefan Chulski > > Armada hardware has a pause generation mechanism in GOP (MAC). > The GOP generate flow control frames based on an indication programmed in > Ports Control 0 Register. There is a bit per port. > However

Re: [PATCH net-next v2 0/4] bridge: mrp: Extend br_mrp_switchdev_*

2021-01-30 Thread Jakub Kicinski
On Wed, 27 Jan 2021 21:52:37 +0100 Horatiu Vultur wrote: > This patch series extends MRP switchdev to allow the SW to have a better > understanding if the HW can implement the MRP functionality or it needs > to help the HW to run it. There are 3 cases: > - when HW can't implement at all the

Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()

2021-01-30 Thread Jakub Kicinski
On Wed, 27 Jan 2021 20:11:23 + Alexander Lobakin wrote: > + * dev_page_is_reserved - check whether a page can be reused for network Rx > + * @page: the page to test > + * > + * A page shouldn't be considered for reusing/recycling if it was allocated > + * under memory pressure or at a distant

Re: [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument

2021-01-30 Thread Jakub Kicinski
On Wed, 27 Jan 2021 20:11:01 + Alexander Lobakin wrote: > The function only tests for page->index, so its argument should be > const. > > Signed-off-by: Alexander Lobakin > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h

Re: [PATCH net-next 2/2] net: ipv6: don't generate link local address on PUREIP device

2021-01-30 Thread Jakub Kicinski
On Thu, 28 Jan 2021 13:58:09 +0800 Rocco Yue wrote: > PUREIP device such as ccmni does not need kernel to generate > link-local address in any addr_gen_mode, generally, it shall > use the IPv6 Interface Identifier, as provided by the GGSN, > to create its IPv6 link-ocal Unicast Address. > >

Re: [PATCH v6 net-next] vmxnet3: Remove buf_info from device accessible structures

2021-01-29 Thread Jakub Kicinski
On Thu, 28 Jan 2021 11:38:34 -0800 Ronak Doshi wrote: > buf_info structures in RX & TX queues are private driver data that > do not need to be visible to the device. Although there is physical > address and length in the queue descriptor that points to these > structures, their layout is not

Re: [PATCH net] net: hdlc_x25: Use qdisc to queue outgoing LAPB frames

2021-01-30 Thread Jakub Kicinski
On Fri, 29 Jan 2021 06:56:10 +0100 Martin Schiller wrote: > On 2021-01-28 23:06, Xie He wrote: > > On Thu, Jan 28, 2021 at 11:47 AM Jakub Kicinski > > wrote: > >> > >> Noob question - could you point at or provide a quick guide to > >> layering

Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()

2021-01-30 Thread Jakub Kicinski
On Sat, 30 Jan 2021 15:42:29 + Alexander Lobakin wrote: > > On Wed, 27 Jan 2021 20:11:23 + Alexander Lobakin wrote: > > > + * dev_page_is_reserved - check whether a page can be reused for network > > > Rx > > > + * @page: the page to test > > > + * > > > + * A page shouldn't be

Re: [PATCH net] net: hdlc_x25: Use qdisc to queue outgoing LAPB frames

2021-01-30 Thread Jakub Kicinski
On Sat, 30 Jan 2021 06:29:20 -0800 Xie He wrote: > On Fri, Jan 29, 2021 at 5:36 PM Jakub Kicinski wrote: > > I'm still struggling to wrap my head around this. > > > > Did you test your code with lockdep enabled? Which Qdisc are you using? > > You're queuing the f

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-30 Thread Jakub Kicinski
On Sat, 30 Jan 2021 10:25:16 -0500 Willem de Bruijn wrote: > > @@ -894,12 +894,16 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id) > > struct gsi_channel *channel = >channel[channel_id]; > > int ret; > > > > - /* Enable the completion interrupt */ > > + /*

<    8   9   10   11   12   13   14   15   16   17   >