Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-10-30 Thread Jakub Kicinski
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote: > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver > that supports 10M single pair cable. > > The device supports both 2.4-V p2p and 1-V p2p output voltage as defined > by IEEE 802.3cg 10Base-T1L specfications. These

Re: [PATCH] fix for potential NULL pointer dereference with bare lan743x

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 03:28:45 +0300 Sergej Bauer wrote: > This is just a minor fix which prevents a kernel NULL pointer > dereference when using phy-less lan743x. > > Signed-off-by: Sergej Bauer I take you mean when the device is down netdev->phydev will be NULL? > diff --git

Re: [PATCH net-next v4] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 10:21:25 -0700 Moritz Fischer wrote: > The driver does not implement a shutdown handler which leads to issues > when using kexec in certain scenarios. The NIC keeps on fetching > descriptors which gets flagged by the IOMMU with errors like this: > > DMAR: DMAR:[DMA read]

Re: [PATCH v2 net 0/5] net: ipa: minor bug fixes

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 11:50:52 -0500 Alex Elder wrote: > On 10/29/20 11:11 AM, Jakub Kicinski wrote: > > On Wed, 28 Oct 2020 14:41:43 -0500 Alex Elder wrote: > >> This series fixes several bugs. They are minor, in that the code > >> currently works on suppo

Re: [PATCH v4 net-next] net: bridge: mcast: add support for raw L2 multicast groups

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 01:38:31 +0200 Vladimir Oltean wrote: > From: Nikolay Aleksandrov > > Extend the bridge multicast control and data path to configure routes > for L2 (non-IP) multicast groups. > > The uapi struct br_mdb_entry union u is extended with another variant, > mac_addr, which does

Re: [PATCH net-next] net: bridge: explicitly convert between mdb entry state and port group flags

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 01:48:15 +0200 Vladimir Oltean wrote: > When creating a new multicast port group, there is implicit conversion > between the __u8 state member of struct br_mdb_entry and the unsigned > char flags member of struct net_bridge_port_group. This implicit > conversion relies on the

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 04:27:37 +0200 Vladimir Oltean wrote: > + mc = devm_kzalloc(ocelot->dev, sizeof(*mc), GFP_KERNEL); > + if (!mc) > + return -ENOMEM; > + > + mc->entry_type = ocelot_classify_mdb(mdb->addr); > +

Re: [PATCH net-next 0/5] L2 multicast forwarding for Ocelot switch

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 04:27:33 +0200 Vladimir Oltean wrote: > This series enables the mscc_ocelot switch to forward raw L2 (non-IP) > mdb entries as configured by the bridge driver after this patch: > >

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 00:05:04 -0700 Xie He wrote: > I wish to deprecate the Frame Relay layer (dlci.c) in the kernel because > we already have a newer and better "HDLC Frame Relay" layer (hdlc_fr.c). > > Reasons why hdlc_fr.c is better than dlci.c include: > > 1. > dlci.c is dated 1997, while

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 13:59:07 +0100 Oleksij Rempel wrote: > On Mon, Nov 16, 2020 at 04:28:44PM -0800, Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 02:10:05 +0200 Vladimir Oltean wrote: > > > On Mon, Nov 16, 2020 at 04:02:13PM -0800, Jakub Kicinski wrote: > > > >

Re: [RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 14:24:38 +0800 Huazhong Tan wrote: > + ``ETHTOOL_A_COALESCE_USE_DIM`` boolusing DIM adaptive Sorry, I didn't get into the discussion on v1 in time. I'd prefer this to be an enum (u8 or u32) the values can already be: - device (HW / FW) - driver specific

Re: [Linux-kernel-mentees] [PATCH v5 net] rose: Fix Null pointer dereference in rose_send_frame()

2020-11-20 Thread Jakub Kicinski
line: > > rose_call = (ax25_address *)neigh->dev->dev_addr; > > Fix it by adding NULL checking for `rose_loopback_neigh->dev` > in rose_loopback_timer(). > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Suggested-by: Jakub Kicinski > Repo

Re: [PATCH net-next v5] net/tun: Call netdev notifiers

2020-11-20 Thread Jakub Kicinski
On Wed, 18 Nov 2020 07:39:19 +0100 Martin Schiller wrote: > Call netdev notifiers before and after changing the device type. > > Signed-off-by: Martin Schiller This is a fix, right? Can you give an example of something that goes wrong without this patch?

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote: > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote: > > > This series aims to fix almost all remaining fall-through warnings in > > >

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 20:01:49 +0200 Vladimir Oltean wrote: > On Thu, Nov 19, 2020 at 12:09:06PM +0100, Christian Eggers wrote: > > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > > immediately. Shouldn't store a pointer to freed memory. > > > > Signed-off-by: Christian

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 23:04:36 +0200 Vladimir Oltean wrote: > On Fri, Nov 20, 2020 at 12:59:21PM -0800, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 20:01:49 +0200 Vladimir Oltean wrote: > > > On Thu, Nov 19, 2020 at 12:09:06PM +0100, Christian Eggers wrote: > &g

Re: [PATCHv3 net-next 0/3] Add devlink and devlink health reporters to

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 11:57:58 +0530 George Cherian wrote: > Add basic devlink and devlink health reporters. > Devlink health reporters are added for NPA and NIX blocks. > These reporters report the error count in respective blocks. > > Address Jakub's comment to add devlink support for error

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 15:50:00 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The body of the if statement can be executed only when the variable > vlan_count equals to 32, so the condition of the while statement can > not be true and the while statement is dead code. Remove it. > >

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote: > Frankly, no, I don't know of any users, and that unfortunately includes > myself. I still have two cards in my stash, but they're 64-bit PCI-X, so > plugging them in would likely require taking a dremel to a 32-bit PCI > slot to make it

Re: [PATCH net-next 4/6] net: ipa: support retries on generic GSI commands

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 16:49:27 -0600 Alex Elder wrote: > + do > + ret = gsi_generic_command(gsi, channel_id, > + GSI_GENERIC_HALT_CHANNEL); > + while (ret == -EAGAIN && retries--); This may well be the first time I've seen someone write a do

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 22:34:46 +0200 Grygorii Strashko wrote: > The mdio_bus may have dependencies from GPIO controller and so got > deferred. Now it will print error message every time -EPROBE_DEFER is > returned which from: > __mdiobus_register() > |-devm_gpiod_get_optional() > without actually

Re: [PATCH net-next 4/6] net: ipa: support retries on generic GSI commands

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 21:31:09 -0600 Alex Elder wrote: > On 11/20/20 8:49 PM, Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 16:49:27 -0600 Alex Elder wrote: > >> + do > >> + ret = gsi_generic_command(gsi, channel_id, > >> +

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 17:52:27 +0100 Florian Westphal wrote: > Ido Schimmel wrote: > > Other suggestions? > > Aleksandr, why was this made into an skb extension in the first place? > > AFAIU this feature is usually always disabled at build time. > For debug builds (test farm /debug kernel etc)

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 19:12:21 +0100 Johannes Berg wrote: > > So I'm leaning towards reverting the whole thing. You can attach > > kretprobes and record the information you need in BPF maps. > > I'm not going to object to reverting it (and perhaps redoing it better > later), but I will point out

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 20:30:44 +0100 Johannes Berg wrote: > On Sat, 2020-11-21 at 10:35 -0800, Jakub Kicinski wrote: > > On Sat, 21 Nov 2020 19:12:21 +0100 Johannes Berg wrote: > > > > So I'm leaning towards reverting the whole thing. You can attach > > > > kret

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-21 Thread Jakub Kicinski
On Sat, 21 Nov 2020 21:58:37 +0100 Johannes Berg wrote: > On Sat, 2020-11-21 at 12:55 -0800, Jakub Kicinski wrote: > > It is more complicated. We can go back to an skb field if this work is > > expected to yield results for mac80211. Would you mind sending a patch? > > I

Re: [PATCH] cxgb4: Fix build failure when CONFIG_TLS=m

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 13:25:28 -0600 Tom Seewald wrote: > After commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") > whenever CONFIG_TLS=m and CONFIG_CHELSIO_T4=y, the following build > failure occurs: > > ld: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o: in function >

Re: [PATCH v2 net] ptp: clockmatrix: bug fix for idtcm_strverscmp

2020-11-21 Thread Jakub Kicinski
On Wed, 18 Nov 2020 22:50:24 -0500 min.li...@renesas.com wrote: > From: Min Li > > Feed kstrtou8 with NULL terminated string. > > Changes since v1: > -Only strcpy 15 characters to leave 1 space for '\0' > > Signed-off-by: Min Li > -static int idtcm_strverscmp(const char *ver1, const char

Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

2020-11-21 Thread Jakub Kicinski
On Thu, 19 Nov 2020 18:24:39 +0100 Yves-Alexis Perez wrote: > Starting with iOS 14 released in September 2020, connectivity using the > personal hotspot USB tethering function of iOS devices is broken. > > Communication between the host and the device (for example ICMP traffic > or DNS resolution

Re: [PATCH net] devlink: Fix reload stats structure

2020-11-21 Thread Jakub Kicinski
On Fri, 20 Nov 2020 15:40:37 +0200 Moshe Shemesh wrote: > Fix reload stats structure exposed to the user. Change stats structure > hierarchy to have the reload action as a parent of the stat entry and > then stat entry includes value per limit. This will also help to avoid > string concatenation

Re: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 01:50:03 + Hayes Wang wrote: > Jakub Kicinski > > Sent: Tuesday, November 17, 2020 1:03 AM > [...] > > > Yes, this fixes this issue, although I would prefer a separate Kconfig > > > entry for r8153_ecm with proper dependencies instead of

Re: [PATCH net] rsi_91x: fix error return code in rsi_reset_card()

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 11:07:34 +0800 Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 17ff2c794f39 ("rsi: reset device changes for 9116") > Reported-by: Hulk Robot > Signed-off-by: Zhang

Re: [PATCH v2] net: phy: mscc: fix excluded_middle.cocci warnings

2020-11-17 Thread Jakub Kicinski
On Mon, 16 Nov 2020 22:15:01 +0100 Antoine Tenart wrote: > Quoting Julia Lawall (2020-11-16 16:34:44) > > From: kernel test robot > > > > Condition !A || A && B is equivalent to !A || B. > > > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > > > Fixes: b76f0ea01312

Re: [PATCH net-next v1] lan743x: replace devicetree phy parse code with library function

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 03:09:56 +0100 Andrew Lunn wrote: > On Mon, Nov 16, 2020 at 12:01:55PM -0500, Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > > > The code in this driver which parses the devicetree to determine > > the phy/fixed link setup, can be replaced by a single library > >

Re: [PATCH net] net: b44: fix error return code in b44_init_one()

2020-11-17 Thread Jakub Kicinski
On Mon, 16 Nov 2020 20:13:43 -0800 Michael Chan wrote: > On Mon, Nov 16, 2020 at 7:01 PM Zhang Changzhong wrote: > > > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: 39a6f4bce6b4 ("b44: replace the ssb_dma API

Re: [PATCH net-next v5] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 07:36:26 +0100 Florian Westphal wrote: > Randy Dunlap wrote: > > The previous Kconfig patch led to some other build errors as > > reported by the 0day bot and my own overnight build testing. > > > > These are all in when KCOV is enabled but > > SKB_EXTENSIONS is not enabled,

Re: [PATCH V4 net-next 0/4] net: hns3: updates for -next

2020-11-17 Thread Jakub Kicinski
#5~#10 from this series, which needs more discussion. > V3 - fix a typo error in #1 reported by Jakub Kicinski. > rewrite #9 commit log. > remove #11 from this series. > V2 - reorder #2 & #3 to fix compiler error. > fix some checkpatch warnings in #10 & #11. Applied, thanks!

Re: [PATCH net-next 1/1] net: phy: Add additional logics on probing C45 PHY devices

2020-11-17 Thread Jakub Kicinski
On Thu, 12 Nov 2020 23:03:51 +0800 Wong Vee Khee wrote: > For clause 45 PHY, introduce additional logics in get_phy_c45_ids() to > check if there is at least one valid device ID, return 0 on true, and > -ENODEV otherwise. > > Signed-off-by: Wong Vee Khee I don't see any response to Andrew's

Re: [PATCH net-next V5] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-17 Thread Jakub Kicinski
On Fri, 13 Nov 2020 20:36:58 +0100 Dmytro Shytyi wrote: > Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly > generated hostID or stable privacy + privacy extensions). > The main problem is that SLAAC RA or PD allocates a /64 by the Wireless > carrier 4G, 5G to a mobile

Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 21:39:05 +0100 Marion & Christophe JAILLET wrote: > Le 17/11/2020 à 03:55, Zhang Changzhong a écrit : > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: 85eb5bc33717 ("net: atheros: switch

Re: [PATCH v4 00/27]Fix several bad kernel-doc markups

2020-11-17 Thread Jakub Kicinski
On Mon, 16 Nov 2020 11:17:56 +0100 Mauro Carvalho Chehab wrote: > Kernel-doc has always be limited to a probably bad documented > rule: > > The kernel-doc markups should appear *imediatelly before* the > function or data structure that it documents. Applied 1-3 to net-next, thanks!

Re: [PATCH] cxbgb4: Fix build failure when CHELSIO_TLS_DEVICE=n

2020-11-17 Thread Jakub Kicinski
On Sun, 15 Nov 2020 20:31:40 -0600 Tom Seewald wrote: > After commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") > building the kernel with CHELSIO_T4=y and CHELSIO_TLS_DEVICE=n results > in the following error: > > ld: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o: in function

Re: [PATCH net-next v3] net/tun: Call netdev notifiers

2020-11-17 Thread Jakub Kicinski
On Mon, 16 Nov 2020 11:41:21 +0100 Martin Schiller wrote: > Call netdev notifiers before and after changing the device type. > > Signed-off-by: Martin Schiller > --- > > Change from v2: > use subject_prefix 'net-next' to fix 'fixes_present' issue > > Change from v1: > fix 'subject_prefix' and

Re: [PATCH net-next] net/nfc/nci: Support NCI 2.x initial sequence

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 14:37:59 +0900 Bongsu Jeon wrote: > implement the NCI 2.x initial sequence to support NCI 2.x NFCC. > Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed. > If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work. > > In NCI 1.0, Initial sequence and

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 09:57:30 +0800 Yunsheng Lin wrote: > On 2020/11/3 3:41, Jakub Kicinski wrote: > > On Mon, 2 Nov 2020 11:14:32 +0800 Yunsheng Lin wrote: > >> On 2020/11/1 6:38, Jakub Kicinski wrote: > >>> On Thu, 29 Oct 2020 19:34:48 +0800 Yunsheng Lin wrote:

Re: [PATCH net-next V5] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 14:41:03 +0100 Dmytro Shytyi wrote: > > > @@ -2576,9 +2590,42 @@ int addrconf_prefix_rcv_add_addr(struct > > > u32 addr_flags, bool sllao, bool tokenized, > > > __u32 valid_lft, u32 prefered_lft) > > > { > > > -struct

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 16:57:57 +0100 Peter Zijlstra wrote: > On Wed, Nov 18, 2020 at 07:43:48AM -0800, Jakub Kicinski wrote: > > > TBH the last sentence I wrote isn't clear even to me at this point ;D > > > > Maybe using just the macros from preempt.h - lik

Re: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 18:36:22 +0100 Andrew Lunn wrote: > On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote: > > The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not > > needed, because the phy core will call genphy_config_aneg() if the > > .config_aneg is NULL. > > > >

Re: [PATCH v2 net-next] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer

2020-11-09 Thread Jakub Kicinski
On Mon, 09 Nov 2020 23:47:23 + Alexander Lobakin wrote: > Similar to commit fda55eca5a33f > ("net: introduce skb_transport_header_was_set()"), avoid resetting > transport offsets that were already set by GRO layer. This not only > mirrors the behavior of __netif_receive_skb_core(), but also

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-10 Thread Jakub Kicinski
On Tue, 10 Nov 2020 08:19:32 -0300 Thadeu Lima de Souza Cascardo wrote: > Yeah, I agree with your initial email. The patch I submitted for that fix > needs > rework, which is what I tried and failed so far. I need to get back to some > testing of my latest fix and find out what needs fixing

Re: [Linux-kernel-mentees] [PATCH v3 net] rose: Fix Null pointer dereference in rose_send_frame()

2020-11-10 Thread Jakub Kicinski
On Sun, 8 Nov 2020 00:48:35 +0530 Anmol Karn wrote: > + dev = rose_dev_get(dest); this calls dev_hold internally, you never release that reference in case ..neigh->dev is NULL > + if (rose_loopback_neigh->dev && dev) {

Re: [net-next,v2,2/5] seg6: improve management of behavior attributes

2020-11-10 Thread Jakub Kicinski
On Sat, 7 Nov 2020 16:31:36 +0100 Andrea Mayer wrote: > Depending on the attribute (i.e.: SEG6_LOCAL_SRH, SEG6_LOCAL_TABLE, etc), > the parse() callback performs some validity checks on the provided input > and updates the tunnel state (slwt) with the result of the parsing > operation. However,

Re: [net-next,v2,1/5] vrf: add mac header for tunneled packets when sniffer is attached

2020-11-10 Thread Jakub Kicinski
On Sat, 7 Nov 2020 16:31:35 +0100 Andrea Mayer wrote: > Before this patch, a sniffer attached to a VRF used as the receiving > interface of L3 tunneled packets detects them as malformed packets and > it complains about that (i.e.: tcpdump shows bogus packets). > > The reason is that a tunneled

Re: [net-next,v2,3/5] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-11-10 Thread Jakub Kicinski
On Sat, 7 Nov 2020 16:31:37 +0100 Andrea Mayer wrote: > We introduce two callbacks used for customizing the creation/destruction of > a SRv6 behavior. Such callbacks are defined in the new struct > seg6_local_lwtunnel_ops and hereafter we provide a brief description of > them: > > -

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-10 Thread Jakub Kicinski
On Sat, 7 Nov 2020 16:31:38 +0100 Andrea Mayer wrote: > SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. > > The SRv6 End.DT4 is used to implement IPv4 L3VPN use-cases in > multi-tenants environments. It decapsulates the received packets and it > performs IPv4 routing lookup in the

Re: [PATCH v2] net: ipv4: remove redundant initialization in inet_rtm_deladdr

2020-11-10 Thread Jakub Kicinski
On Sun, 8 Nov 2020 09:05:41 +0800 Menglong Dong wrote: > The initialization for 'err' with '-EINVAL' is redundant and > can be removed, as it is updated soon. > > Changes since v1: > - Remove redundant empty line > > Signed-off-by: Menglong Dong Applied, thanks.

Re: [PATCH v2] net: atlantic: Remove unnecessary conversion to bool

2020-11-10 Thread Jakub Kicinski
On Sun, 8 Nov 2020 09:11:59 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The '!=' expression itself is bool, no need to convert it to bool. > Fix the following coccicheck warning: > > ./drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1477:34-39: WARNING: > conversion to bool not

Re: [PATCH] net: pch_gbe: remove unneeded variable retval in __pch_gbe_suspend

2020-11-10 Thread Jakub Kicinski
On Sun, 8 Nov 2020 20:13:00 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > Fix the following coccicheck warning: > > ./drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2415:5-11: Unneeded > variable: "retval". Return "0" on line 2435 > > Reported-by: Tosk Robot >

Re: [PATCH net v4] lan743x: correctly handle chips with internal PHY

2020-11-10 Thread Jakub Kicinski
On Sun, 8 Nov 2020 12:12:24 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > Commit 6f197fb63850 ("lan743x: Added fixed link and RGMII support") > assumes that chips with an internal PHY will never have a devicetree > entry. This is incorrect: even for these chips, a devicetree

Re: [PATCH] net: sched: fix misspellings using misspell-fixer tool

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 02:02:17 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > Some typos are found out by misspell-fixer tool: > > $ misspell-fixer -rnv ./net/sched/ > ./net/sched/act_api.c:686 > ./net/sched/act_bpf.c:68 > ./net/sched/cls_rsvp.h:241 > ./net/sched/em_cmp.c:44 >

Re: [PATCH V3 net] net/ethernet: Fix error return when ptp_clock is ERROR

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 10:17:52 +0800 Wang Qing wrote: > We always have to update the value of ret, otherwise the error value > may be the previous one. And ptp_clock_register() never return NULL > when PTP_1588_CLOCK enable. > > Signed-off-by: Wang Qing Please add a Fixes tag as I requested in

Re: [PATCH V2 net-next 01/11] net: hns3: add support for configuring interrupt quantity limiting

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 11:22:29 +0800 Huazhong Tan wrote: > + if (rx_vector->tx_group.coal.ql_enable) Is this supposed to be rx_group, not tx? > + hns3_set_vector_coalesce_rx_ql(rx_vector, > +

Re: [PATCH V2 net-next 05/11] net: hns3: add support for dynamic interrupt moderation

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 11:22:33 +0800 Huazhong Tan wrote: > Add dynamic interrupt moderation support for the HNS3 driver. > > Signed-off-by: Huazhong Tan I'm slightly confused here. What does the adaptive moderation do in your driver/device if you still need DIM on top of it?

Re: [PATCH V2 net-next 09/11] net: hns3: add support for EQ/CQ mode configuration

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 11:22:37 +0800 Huazhong Tan wrote: > For device whose version is above V3(include V3), the GL can > select EQ or CQ mode, so adds support for it. > > In CQ mode, the coalesced timer will restart upon new completion, > while in EQ mode, the timer will not restart. > >

Re: [PATCH V2 net-next 11/11] net: hns3: add debugfs support for interrupt coalesce

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote: > Since user may need to check the current configuration of the > interrupt coalesce, so add debugfs support for query this info, > which includes DIM profile, coalesce configuration of both software > and hardware. > > Signed-off-by: Huazhong

Re: [PATCH net v5] net: Update window_clamp if SOCK_RCVBUF is set

2020-11-10 Thread Jakub Kicinski
On Tue, 10 Nov 2020 08:32:52 +0100 Eric Dumazet wrote: > On Tue, Nov 10, 2020 at 1:16 AM Mao Wenan wrote: > > When net.ipv4.tcp_syncookies=1 and syn flood is happened, > > cookie_v4_check or cookie_v6_check tries to redo what > > tcp_v4_send_synack or tcp_v6_send_synack did, > > rsk_window_clamp

Re: [PATCH][next] net: dsa: fix unintended sign extension on a u16 left shift

2020-11-10 Thread Jakub Kicinski
On Mon, 09 Nov 2020 14:27:52 +0100 Kurt Kanzenbach wrote: > On Mon Nov 09 2020, Colin King wrote: > > From: Colin Ian King > > > > The left shift of u16 variable high is promoted to the type int and > > then sign extended to a 64 bit u64 value. If the top bit of high is > > set then the upper 32

Re: [PATCH net v1] lan743x: fix "BUG: invalid wait context" when setting rx mode

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 15:38:28 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > In the net core, the struct net_device_ops -> ndo_set_rx_mode() > callback is called with the dev->addr_list_lock spinlock held. > > However, this driver's ndo_set_rx_mode callback eventually calls >

Re: [PATCH v8 6/6] Bluetooth: Add toggle to switch off interleave scan

2020-11-10 Thread Jakub Kicinski
On Tue, 10 Nov 2020 18:17:55 +0800 Howard Chung wrote: > This patch add a configurable parameter to switch off the interleave > scan feature. > > Reviewed-by: Alain Michaud > Signed-off-by: Howard Chung Please don't add new sparse warnings: net/bluetooth/mgmt_config.c:315:63: warning: cast to

Re: [PATCH] net: phy: mscc: fix excluded_middle.cocci warnings

2020-11-16 Thread Jakub Kicinski
On Sun, 15 Nov 2020 19:37:59 +0100 (CET) Julia Lawall wrote: > From: kernel test robot > > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script") > CC: Denis

Re: [PATCH net-next v4] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 15:31:21 +0100 Florian Westphal wrote: > > > @@ -4151,12 +4150,11 @@ enum skb_ext_id { > > > #if IS_ENABLED(CONFIG_MPTCP) > > > SKB_EXT_MPTCP, > > > #endif > > > -#if IS_ENABLED(CONFIG_KCOV) > > > SKB_EXT_KCOV_HANDLE, > > > -#endif > > > > I don't

Re: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 10:18:13 +0100 Marek Szyprowski wrote: > On 16.11.2020 07:52, Hayes Wang wrote: > > Avoid r8153_ecm is compiled as built-in, if r8152 driver is compiled > > as modules. Otherwise, the r8153_ecm would be used, even though the > > device is supported by r8152 driver. > > > >

Re: [PATCH net] net: phy: smsc: add missed clk_disable_unprepare in smsc_phy_probe()

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 10:26:07 +0100 Marco Felsch wrote: > > > The code right above looks highly questionable as well: > > > > > > priv->refclk = clk_get_optional(dev, NULL); > > > if (IS_ERR(priv->refclk)) > > > dev_err_probe(dev, PTR_ERR(priv->refclk), "Failed to

Re: [PATCH v6 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 16:33:26 +0100 Lukasz Stelmach wrote: > > Please make sure the new code builds cleanly with W=1 C=1 > > > > ../drivers/net/ethernet/asix/ax88796c_ioctl.c:221:19: warning: initialized > > field overwritten [-Woverride-init] > > 221 | .get_msglevel =

Re: [PATCH V3 net-next 06/10] net: hns3: add ethtool priv-flag for DIM

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 16:41:45 +0800 tanhuazhong wrote: > On 2020/11/15 2:54, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 11:33:14 +0800 Huazhong Tan wrote: > >> Add a control private flag in ethtool for enable/disable > >> DIM feature. > >> > >> S

Re: [PATCH net-next] MAINTAINERS: Add Martin Schiller as a maintainer for the X.25 stack

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 10:01:20 +0100 Martin Schiller wrote: > On 2020-11-14 12:10, Xie He wrote: > > Martin Schiller is an active developer and reviewer for the X.25 code. > > His company is providing products based on the Linux X.25 stack. > > So he is a good candidate for maintainers of the X.25

Re: linux-next: Tree for Nov 16 (net/core/stream.o)

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 09:46:21 -0800 Randy Dunlap wrote: > On 11/15/20 10:59 PM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20201113: > > on x86_64: > > # CONFIG_INET is not set > > ld: net/core/stream.o: in function `sk_stream_write_space': > stream.c:(.text+0x68): undefined

Re: [PATCH v4 bpf-next 3/5] kbuild: build kernel module BTFs if BTF is enabled and pahole supports it

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 12:34:17 -0800 Andrii Nakryiko wrote: > > This change, commit 5f9ae91f7c0d ("kbuild: Build kernel module BTFs if BTF > > is enabled and pahole > > supports it") currently in net-next, linux-next, etc. breaks the use-case > > of compiling only a specific > > kernel module

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Sun, 15 Nov 2020 08:35:33 +0100 Oleksij Rempel wrote: > +static const struct ar9331_mib_desc ar9331_mib[] = { > + MIB_DESC(1, 0x00, "RxBroad"), > + MIB_DESC(1, 0x04, "RxPause"), > + MIB_DESC(1, 0x08, "RxMulti"), > + MIB_DESC(1, 0x0c, "RxFcsErr"), > + MIB_DESC(1, 0x10,

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote: > > You must expose relevant statistics via the normal get_stats64 NDO > > before you start dumping free form stuff in ethtool -S. > > Completely agre

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote: > > > On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote: > > >

Re: [PATCH net] net: stmmac: dwmac-intel-plat: fix error return code in intel_eth_plat_probe()

2020-11-16 Thread Jakub Kicinski
On Fri, 13 Nov 2020 14:34:03 +0800 Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 9efc9b2b04c7 ("net: stmmac: Add dwmac-intel-plat for GBE driver") > Reported-by: Hulk Robot >

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 15:20:37 -0800 Florian Fainelli wrote: > >> Florian for you patch specifially - can't we use > >> netdev_for_each_lower_dev()? > > > > Looks like I forgot to respond here, yes we could do that because we do > > call netdev_upper_dev_link() in net/dsa/slave.c. Let me re-post

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Tue, 17 Nov 2020 01:27:31 +0200 Vladimir Oltean wrote: > > Note that I said _forwarded_. Frames are either forwarded by the HW or > > SW (former never hit the CPU, while the latter do hit the CPU or > > originate from it). > > Ah, you were just thinking out loud, I really did not understand

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 15:30:39 -0800 Florian Fainelli wrote: > > What about RMON/RFC2819 style etherStatsPkts65to127Octets? We have a > > number of switches supporting that style of counters, including the one > > that Oleksij is adding support for, apparently (but not all switches > > though). I

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Jakub Kicinski
On Tue, 17 Nov 2020 01:54:05 +0200 Vladimir Oltean wrote: > Yeah, I think Florian just wants netconsole to work in stable kernels, > which is a fair point. As for my 16-line patch that I suggested to him > in the initial reply, what do you think, would that be a "stable" > candidate? We would be

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Tue, 17 Nov 2020 02:10:05 +0200 Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 04:02:13PM -0800, Jakub Kicinski wrote: > > For a while now we have been pushing back on stats which have a proper > > interface to be added to ethtool -S. So I'd expect the list of stats > >

Re: [PATCH net-next 1/5] ptp: clockmatrix: bug fix for idtcm_strverscmp

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 14:27:26 -0500 min.li...@renesas.com wrote: > From: Min Li > > Feed kstrtou8 with NULL terminated string. Is this a fix? Does it need to be backported to stable? Also please add a cover letter for the series describing the overall goal of this work, what testing has been

Re: [PATCH v2 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 21:00:27 +0900 Bongsu jeon wrote: > From: Bongsu Jeon > > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon All patches in the series should have the same version. If the patch was not

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-30 Thread Jakub Kicinski
On Sat, 21 Nov 2020 18:09:41 +0200 Ido Schimmel wrote: > + Florian > > On Thu, Oct 29, 2020 at 05:36:19PM +, Aleksandr Nogikh wrote: > > From: Aleksandr Nogikh > > > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > > code that is not reachable during normal system

Re: [PATCHv5 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 19:32:49 +0530 George Cherian wrote: > Add devlink support to AF driver. Basic devlink support is added. > Currently info_get is the only supported devlink ops. > > devlink ouptput looks like this > # devlink dev > pci/0002:01:00.0 > # devlink dev info > pci/0002:01:00.0:

Re: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 19:32:50 +0530 George Cherian wrote: > Add health reporters for RVU NPA block. > NPA Health reporters handle following HW event groups > - GENERAL events > - ERROR events > - RAS events > - RVU event > An event counter per event is maintained in SW. > > Output: > #

Re: [PATCH 1/2] vxlan: Add needed_headroom for lower device

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 13:52:46 +0100 Sven Eckelmann wrote: > It was observed that sending data via batadv over vxlan (on top of > wireguard) reduced the performance massively compared to raw ethernet or > batadv on raw ethernet. A check of perf data showed that the > vxlan_build_skb was calling all

Re: [PATCH net-next v3] net/nfc/nci: Support NCI 2.x initial sequence

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 22:36:31 +0900 bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > implement the NCI 2.x initial sequence to support NCI 2.x NFCC. > Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed. > If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work. >

Re: [PATCH] net: bna: remove trailing semicolon in macro definition

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 08:55:50 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > --- > drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] net: wan: remove trailing semicolon in macro definition

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 08:57:34 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix This one looks fine, applied, thanks.

Re: [PATCH net-next v5] net/tun: Call netdev notifiers

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 07:18:07 +0100 Martin Schiller wrote: > On 2020-11-20 19:28, Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 07:39:19 +0100 Martin Schiller wrote: > >> Call netdev notifiers before and after changing the device type. > >> > >

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 03:17:54 -0800 Xie He wrote: > On Mon, Nov 23, 2020 at 2:38 AM Martin Schiller wrote: > > Well, one could argue that we would have to repair these drivers, but I > > don't think that will get us anywhere. > > Yeah... One problem I see with the Linux project is the lack of >

Re: [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 15:27:25 +0100 Peter Zijlstra wrote: > On Sat, Nov 21, 2020 at 11:06:15AM +0800, Yunsheng Lin wrote: > > The current semantic for napi_consume_skb() is that caller need > > to provide non-zero budget when calling from NAPI context, and > > breaking this semantic will cause hard

<    4   5   6   7   8   9   10   11   12   13   >