Re: [PATCH] scsi: ses: Fix out-of-bounds memory access in ses_enclosure_data_process()

2019-05-20 Thread James Bottomley
On Mon, 2019-05-20 at 10:41 -0400, Waiman Long wrote: [...] > > --- a/drivers/scsi/ses.c > > +++ b/drivers/scsi/ses.c > > @@ -605,9 +605,14 @@ static void ses_enclosure_data_process(struct > > enclosure_device *edev, > > /* these elements are optional */ > >

[GIT PULL] final round of SCSI updates for the 5.1+ merge window

2019-05-17 Thread James Bottomley
This is the final round of mostly small fixes in our initial submit. The fix for the read only regressions is the most extensive change and also intrudes outside of SCSI because the partition and read only handling is mostly in block. The specific problem is the inability to distinguish between d

Re: [GIT PULL] asm-generic: kill and improve nommu generic uaccess helpers

2019-05-16 Thread James Bottomley
On Thu, 2019-05-16 at 13:59 -0700, Linus Torvalds wrote: > On Thu, May 16, 2019 at 1:34 PM Arnd Bergmann wrote: > > > > > > I have reconfigured it locally now and pushed an identical tag with > > a > > new signature. Can you see if that gives you the same warning if > > you > > try to pull that?

Re: [PATCH v2 0/3] initramfs: add support for xattrs in the initial ram disk

2019-05-14 Thread James Bottomley
On Tue, 2019-05-14 at 18:39 -0500, Rob Landley wrote: > On 5/14/19 2:18 PM, James Bottomley wrote: > > > I think Rob is right here. If /init was statically built into > > > the kernel image, it has no more ability to compromise the kernel > > > than anything e

Re: [PATCH v2 0/3] initramfs: add support for xattrs in the initial ram disk

2019-05-14 Thread James Bottomley
On Tue, 2019-05-14 at 08:19 -0700, Andy Lutomirski wrote: > On Mon, May 13, 2019 at 5:47 AM Roberto Sassu om> wrote: > > On 5/13/2019 11:07 AM, Rob Landley wrote: [...] > > > > The only reason why opening .xattr-list works is that IMA is > > > > not yet initialized (late_initcall vs rootfs_initcal

Re: [RFC PATCH 2/7] x86/sci: add core implementation for system call isolation

2019-04-26 Thread James Bottomley
On Fri, 2019-04-26 at 10:40 -0700, Andy Lutomirski wrote: > > On Apr 26, 2019, at 8:19 AM, James Bottomley > npartnership.com> wrote: > > > > On Fri, 2019-04-26 at 08:07 -0700, Andy Lutomirski wrote: > > > > On Apr 26, 2019, at 7:57 AM, James Bottomley > &g

Re: [RFC PATCH 2/7] x86/sci: add core implementation for system call isolation

2019-04-26 Thread James Bottomley
On Fri, 2019-04-26 at 08:07 -0700, Andy Lutomirski wrote: > > On Apr 26, 2019, at 7:57 AM, James Bottomley > npartnership.com> wrote: > > > > > On Fri, 2019-04-26 at 07:46 -0700, Dave Hansen wrote: > > > > On 4/25/19 2:45 PM, Mike Rapoport wrote: > >

Re: [RFC PATCH 2/7] x86/sci: add core implementation for system call isolation

2019-04-26 Thread James Bottomley
On Fri, 2019-04-26 at 07:46 -0700, Dave Hansen wrote: > On 4/25/19 2:45 PM, Mike Rapoport wrote: > > After the isolated system call finishes, the mappings created > > during its execution are cleared. > > Yikes. I guess that stops someone from calling write() a bunch of > times on every filesyste

Re: [RFC PATCH 2/7] x86/sci: add core implementation for system call isolation

2019-04-26 Thread James Bottomley
On Fri, 2019-04-26 at 10:31 +0200, Ingo Molnar wrote: > * Mike Rapoport wrote: > > > When enabled, the system call isolation (SCI) would allow execution > > of the system calls with reduced page tables. These page tables are > > almost identical to the user page tables in PTI. The only addition >

Re: [PATCH v2 2/5 RFC] use event name instead of enum to make the call generic

2019-04-25 Thread James Bottomley
On Fri, 2019-04-26 at 08:34 +1000, James Morris wrote: > On Thu, 25 Apr 2019, Linus Torvalds wrote: > > > On Thu, Apr 25, 2019 at 10:19 AM prsriva > om> wrote: > > > > > > I will fix the comments and send out the patchset with a cover > > > letter. Thankyou for pointing this out. > > > > Please

Re: [PATCH v2] KEYS: Make use of platform keyring for module signature verify

2019-04-25 Thread James Bottomley
On Thu, 2019-04-25 at 07:55 -0400, Mimi Zohar wrote: > On Wed, 2019-04-24 at 14:33 +, Robert Holmes wrote: > > This patch completes commit 278311e417be ("kexec, KEYS: Make use of > > platform keyring for signature verify") which, while adding the > > platform keyring for bzImage verification, n

Re: linux-next: build failure after merge of the scsi-mkp tree

2019-04-09 Thread James Bottomley
On Tue, 2019-04-09 at 21:33 -0400, Martin K. Petersen wrote: > Stephen, > > > > I have reverted that commit for today. > > > > This has now migrated to the scsi tree. > > I have a fix in my tree but I haven't pushed it yet. It's upstream in both trees now. James

Re: linux-next: build warning after merge of the scsi tree

2019-04-04 Thread James Bottomley
On Thu, 2019-04-04 at 21:30 -0700, Bart Van Assche wrote: > On 4/4/19 8:25 PM, Stephen Rothwell wrote: > > Hi James, > > > > After merging the scsi tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: > > 'lpfc_

Re: [PATCH v2] tpm: Actually fail on TPM errors during "get random"

2019-04-01 Thread James Bottomley
On Mon, 2019-04-01 at 11:52 -0700, Kees Cook wrote: > @@ -559,6 +559,9 @@ int tpm1_get_random(struct tpm_chip *chip, u8 > *dest, size_t max) > rc = total ? (int)total : -EIO; > out: > tpm_buf_destroy(&buf); > +fail: > + if (rc > 0) > + rc = -EIO; > return rc; > }

Re: [PATCH] tpm: Actually fail on TPM errors during "get random"

2019-04-01 Thread James Bottomley
On Mon, 2019-04-01 at 11:32 -0700, Kees Cook wrote: [...] > --- a/drivers/char/tpm/tpm1-cmd.c > +++ b/drivers/char/tpm/tpm1-cmd.c > @@ -510,7 +510,7 @@ struct tpm1_get_random_out { > * > * Return: > * * number of bytes read > - * * -errno or a TPM return code otherwise > + * * -errno (positi

Re: Bad file pattern in MAINTAINERS section 'KEYS-TRUSTED'

2019-03-26 Thread James Bottomley
On Tue, 2019-03-26 at 09:59 -0500, Denis Kenzior wrote: > Hi James, > > On 03/26/2019 09:25 AM, James Bottomley wrote: > > Looking at the contents of linux/keys/trusted.h, it looks like the > > wrong decision to move it. The contents are way too improperly > > named &

Re: Bad file pattern in MAINTAINERS section 'KEYS-TRUSTED'

2019-03-26 Thread James Bottomley
On Tue, 2019-03-26 at 08:10 -0400, Mimi Zohar wrote: > Hi Jarrko, > > On Tue, 2019-03-26 at 13:37 +0200, Jarkko Sakkinen wrote: > > Mimi, > > > > Can you fix this and I can ack and send PR through my tree? > > Making the "trusted.h" include file public was part of David's "KEYS: > Support TPM-wr

Re: [PATCH v2] tpm: fix an invalid condition in tpm_common_poll

2019-03-20 Thread James Bottomley
On Tue, 2019-03-19 at 13:31 -0700, Tadeusz Struk wrote: > The poll condition should only check response_length, > because reads should only be issued if there is data to read. > The response_read flag only prevents double writes. > The problem was that the write set the response_read to false, > en

Re: [PATCH] tpm: fix a race between poll and write in tpm-dev-common

2019-03-18 Thread James Bottomley
On Mon, 2019-03-18 at 15:18 -0700, Tadeusz Struk wrote: > Since the poll returns EPOLLIN base on the state of two > variables, the response_read being false and the > response_length > 0 the poll needs to take the buffer_mutex > after it is woken up. > > Fixes: 9488585b21bef0df12 ("tpm: add suppor

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread James Bottomley
On Thu, 2019-03-14 at 19:42 -0400, Theodore Ts'o wrote: > On Thu, Mar 14, 2019 at 04:15:11PM -0700, James Bottomley wrote: > > On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > > > Usually fscrypt allows limited access to encrypted files even >

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread James Bottomley
On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > Usually fscrypt allows limited access to encrypted files even > if no key is available. > Encrypted filenames are shown and based on this names users > can unlink and move files. Shouldn't they be able to read/write and create as well

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 15:13 -0700, Eric Biggers wrote: > On Wed, Mar 13, 2019 at 02:04:29PM -0700, James Bottomley wrote: > > On Wed, 2019-03-13 at 13:25 -0700, Eric Biggers wrote: > > > On Wed, Mar 13, 2019 at 01:06:06PM -0700, James Bottomley wrote: > > > > On

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 13:25 -0700, Eric Biggers wrote: > On Wed, Mar 13, 2019 at 01:06:06PM -0700, James Bottomley wrote: > > On Wed, 2019-03-13 at 12:57 -0700, Eric Biggers wrote: [...] > > > fscrypt would allow the data to be stored encrypted on the local > > > disk

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 12:57 -0700, Eric Biggers wrote: > On Wed, Mar 13, 2019 at 12:17:52PM -0700, James Bottomley wrote: > > On Wed, 2019-03-13 at 14:58 -0400, Theodore Ts'o wrote: > > > On Wed, Mar 13, 2019 at 10:45:04AM -0700, James Bottomley wrote: > > > >

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 14:58 -0400, Theodore Ts'o wrote: > On Wed, Mar 13, 2019 at 10:45:04AM -0700, James Bottomley wrote: > > > If they can't break root, then the OS's user-id based access > > > control checks (or SELinux checks if you are using S

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 12:44 -0400, Theodore Ts'o wrote: > On Wed, Mar 13, 2019 at 08:36:34AM -0700, James Bottomley wrote: > > On Wed, 2019-03-13 at 11:16 -0400, Theodore Ts'o wrote: > > > So before we talk about how to make things work from a technical > > >

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 08:51 -0700, Eric Biggers wrote: > Hi James, > > On Wed, Mar 13, 2019 at 08:36:34AM -0700, James Bottomley wrote: > > On Wed, 2019-03-13 at 11:16 -0400, Theodore Ts'o wrote: > > > So before we talk about how to make things work from a technical

Re: overlayfs vs. fscrypt

2019-03-13 Thread James Bottomley
On Wed, 2019-03-13 at 11:16 -0400, Theodore Ts'o wrote: > So before we talk about how to make things work from a technical > perspective, we should consider what the use case happens to be, and > what are the security requirements. *Why* are we trying to use the > combination of overlayfs and fscr

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread James Bottomley
On Tue, 2019-03-12 at 12:59 -0400, Mimi Zohar wrote: > On Tue, 2019-03-12 at 07:42 -0700, James Bottomley wrote: > > On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > > > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > > > On Mon, 201

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread James Bottomley
On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > > e're having lots of problems with TPM commands timing out, and > > > we'

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-11 Thread James Bottomley
he default poll timings but it works flawlessly if I use the patch below. I think my nuvoton is a bit out of spec (it's a very early model that was software upgraded from 1.2 to 2.0) because no-one else on the list seems to see the problems I see, but perhaps you are. James --- >From 249

[GIT PULL] first round of SCSI updates for the 5.0+ merge window

2019-03-06 Thread James Bottomley
This is mostly update of the usual drivers: arcmsr, qla2xxx, lpfc, hisi_sas, target/iscsi and target/core. Additionally Christoph refactored gdth as part of the dma changes. The major mid-layer change this time is the removal of bidi commands and with them the whole of the osd/exofs driver and fi

[GIT PULL] SCSI fixes for 5.0-rc7

2019-03-02 Thread James Bottomley
Nine small fixes. The resume fix is a cosmetic removal of a warning with an incorrect condition causing it to alarm people wrongly. The other eight patches correct a thinko in Christoph Hellwig's DMA conversion series. Without it all these drivers end up with 32 bit DMA masks meaning they bounce

Re: [PATCH v2] scsi: smartpqi_init: Reporting 'logical unit failure'

2019-03-01 Thread James Bottomley
On Fri, 2019-03-01 at 15:43 +, Erwan Velu wrote: > Le 01/03/2019 à 16:26, James Bottomley a écrit : > > [...] > > Shouldn't this be a variant of sdev/scmd_printk? Otherwise it > > tells > > you what disk in the array terms is the problem but not what device

Re: [PATCH v2] scsi: smartpqi_init: Reporting 'logical unit failure'

2019-03-01 Thread James Bottomley
On Fri, 2019-03-01 at 15:58 +0100, Erwan Velu wrote: > + dev_err_ratelimited(&ctrl_info->pci_dev- > >dev, "received 'logical unit failure' from controller for scsi > %d:%d:%d:%d\n", > + ctrl_info- > >scsi_host->host_no, device-

[GIT PULL] SCSI fixes for 5.0-rc7

2019-02-22 Thread James Bottomley
Four small fixes: three in drivers and one in the core. The core fix is also minor in scope since the bug it fixes is only known to affect systems using SCSI reservations. Of the driver bugs, the libsas one is the most major because it can lead to multiple disks on the same expander not being ex

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-19 Thread James Bottomley
On Wed, 2019-02-20 at 11:04 +0800, Ian Kent wrote: > On Tue, 2019-02-19 at 18:20 -0800, James Bottomley wrote: > > On Tue, 2019-02-19 at 23:06 +, David Howells wrote: > > > James Bottomley wrote: > > > > > > > I thought we got agreement years ago that

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-19 Thread James Bottomley
On Tue, 2019-02-19 at 23:06 +, David Howells wrote: > James Bottomley wrote: > > > I thought we got agreement years ago that containers don't exist in > > Linux as a single entity: they're currently a collection of cgroups > > and namespaces some of whic

Re: [PATCH] scsi: mvumi: fix 32 bit shift of a 32 bit unsigned int

2019-02-18 Thread James Bottomley
On Mon, 2019-02-18 at 12:37 +0300, Dan Carpenter wrote: > On Sat, Feb 16, 2019 at 05:27:16PM +0100, Walter Harms wrote: > > Am 16.02.2019 15:44, schrieb Colin King: > > > From: Colin Ian King > > > > > > Currently m_sg->baseaddr_h (a 32 bit unsigned int) is being > > > shifted by a > > > total of

Re: [PATCH 4.4 091/143] scsi: aic94xx: fix module loading

2019-02-18 Thread James Bottomley
On Mon, 2019-02-18 at 14:43 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me > know. > > -- > > From: James Bottomley > > commit 42caa0edabd6a0a392ec36a5f0943924e4954311 upstream. > > T

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-17 Thread James Bottomley
Added containers and cgroups list, which somehow got lost since they might have a slight interest in a complete rewrite of the container API. On Fri, 2019-02-15 at 16:07 +, David Howells wrote: > Implement a kernel container object such that it contains the > following things: > > (1) Namesp

[GIT PULL] SCSI fixes for 5.0-rc

2019-02-15 Thread James Bottomley
delay before the affected systems allow logins after reboot. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Bill Kuzeja (1): scsi: qla2xxx: Fix panic from use after free in qla2x00_async_tm_cmd James Bottomley (1

Re: [LSF/MM TOPIC] FS, MM, and stable trees

2019-02-14 Thread James Bottomley
On Thu, 2019-02-14 at 20:50 -0500, Sasha Levin wrote: > On Wed, Feb 13, 2019 at 12:14:35PM -0800, James Bottomley wrote: > > On Wed, 2019-02-13 at 20:52 +0100, Greg KH wrote: > > > On Wed, Feb 13, 2019 at 02:25:12PM -0500, Sasha Levin wrote: > > > > On Wed, Feb 13,

Re: [LSF/MM TOPIC] FS, MM, and stable trees

2019-02-13 Thread James Bottomley
On Wed, 2019-02-13 at 20:52 +0100, Greg KH wrote: > On Wed, Feb 13, 2019 at 02:25:12PM -0500, Sasha Levin wrote: > > On Wed, Feb 13, 2019 at 10:18:03AM +0100, Greg KH wrote: > > > On Wed, Feb 13, 2019 at 11:01:25AM +0200, Amir Goldstein wrote: > > > > Best effort testing in timely manner is good, b

[PATCH] scsi: sd: fix entropy gathering for most rotational disks

2019-02-12 Thread James Bottomley
i: sd: Contribute to randomness when running rotational device") Cc: sta...@vger.kernel.org Signed-off-by: James Bottomley --- I updated this slightly over the original proposal so we set the flags even if the device doesn't have any VPD pages, so it should work for very old disks. di

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-12 Thread James Bottomley
On Mon, 2019-02-11 at 19:50 -0700, Jens Axboe wrote: > On 2/11/19 7:13 PM, James Bottomley wrote: > > On Mon, 2019-02-11 at 09:31 -0700, Jens Axboe wrote: > > > On 2/11/19 9:28 AM, James Bottomley wrote: > > > > On Mon, 2019-02-11 at 08:46 -0700, Jens Axboe wrote

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-11 Thread James Bottomley
On Tue, 2019-02-12 at 03:37 +, Elliott, Robert (Persistent Memory) wrote: > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Jens Axboe > > Sent: Monday, February 11, 2019 8:50 PM > > To: James Bot

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-11 Thread James Bottomley
On Mon, 2019-02-11 at 09:31 -0700, Jens Axboe wrote: > On 2/11/19 9:28 AM, James Bottomley wrote: > > On Mon, 2019-02-11 at 08:46 -0700, Jens Axboe wrote: > > > On 2/11/19 8:42 AM, James Bottomley wrote: > > > > On Mon, 2019-02-11 at 08:28 -0700, Jens Axboe wrote

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-11 Thread James Bottomley
On Mon, 2019-02-11 at 08:46 -0700, Jens Axboe wrote: > On 2/11/19 8:42 AM, James Bottomley wrote: > > On Mon, 2019-02-11 at 08:28 -0700, Jens Axboe wrote: > > > On 2/11/19 8:25 AM, James Bottomley wrote: > > > > On Sun, 2019-02-10 at 09:35 -0700, Jens Axboe wrote

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-11 Thread James Bottomley
On Mon, 2019-02-11 at 08:28 -0700, Jens Axboe wrote: > On 2/11/19 8:25 AM, James Bottomley wrote: > > On Sun, 2019-02-10 at 09:35 -0700, Jens Axboe wrote: > > > On 2/10/19 9:25 AM, James Bottomley wrote: > > > > On Sun, 2019-02-10 at 09:05 -0700, Jens Axboe wrote

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-11 Thread James Bottomley
On Sun, 2019-02-10 at 09:35 -0700, Jens Axboe wrote: > On 2/10/19 9:25 AM, James Bottomley wrote: > > On Sun, 2019-02-10 at 09:05 -0700, Jens Axboe wrote: > > > On 2/10/19 8:44 AM, James Bottomley wrote: > > > > On Sun, 2019-02-10 at 10:17 +0100, Mikael Pettersson

Re: [PATCH] MAINTAINERS: use tab instead of spaces

2019-02-10 Thread James Bottomley
On Sun, 2019-02-10 at 19:10 +0100, Lukas Bulwahn wrote: > Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen > as > further maintainer to the KEYS-TRUSTED section entry. So, we rectify > this > with this commit. > > The issue was detected when writing a script that parses MAINTAIN

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-10 Thread James Bottomley
On Sun, 2019-02-10 at 09:05 -0700, Jens Axboe wrote: > On 2/10/19 8:44 AM, James Bottomley wrote: > > On Sun, 2019-02-10 at 10:17 +0100, Mikael Pettersson wrote: > > > On Sat, Feb 9, 2019 at 7:19 PM James Bottomley > > > wrote: > > > > [...] > > >

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-10 Thread James Bottomley
On Sun, 2019-02-10 at 10:17 +0100, Mikael Pettersson wrote: > On Sat, Feb 9, 2019 at 7:19 PM James Bottomley > wrote: [...] > > I think the reason for this is that the block mq path doesn't feed > > the kernel entropy pool correctly, hence the need to install an > >

Re: [5.0-rc5 regression] "scsi: kill off the legacy IO path" causes 5 minute delay during boot on Sun Blade 2500

2019-02-09 Thread James Bottomley
On Sat, 2019-02-09 at 18:04 +0100, Mikael Pettersson wrote: > 4.20 and earlier kernels boot fine on my Sun Blade 2500 (UltraSPARC > IIIi), but the 5.0-rc kernels consistently experience a 5 minute > delay > late during boot, after enabling networking but before allowing user > logins. E.g. 5.0-rc5

[GIT PULL] SCSI fixes for 5.0-rc5

2019-02-08 Thread James Bottomley
here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Damien Le Moal (1): scsi: sd_zbc: Fix zone information messages David Disseldorp (1): scsi: target: make the pi_prot_format ConfigFS path readable James Bottomley (1): scsi: ai

Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon

2019-02-05 Thread James Bottomley
On Mon, 2019-02-04 at 15:37 +0200, Jarkko Sakkinen wrote: > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c > b/drivers/char/tpm/tpm_i2c_infineon.c > index 9086edc9066b..b9d5a1dda8d2 100644 > --- a/drivers/char/tpm/tpm_i2c_infineon.c > +++ b/drivers/char/tpm/tpm_i2c_infineon.c [...] > @@ -527,8 +5

[GIT PULL] SCSI fixes for 5.0-rc4

2019-02-01 Thread James Bottomley
Five minor bug fixes. The libfc one is a tiny memory leak, the zfcp one is an incorrect user visible parameter and the rest are on error legs or obscure features. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Dan Car

[GIT PULL] SCSI fixes for 5.0-rc3

2019-01-25 Thread James Bottomley
Six fixes, all of which appear to have user visible consequences. The DMA one is a regression fix from the merge window and of the others, four are driver specific and one specific to the target code. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-f

[GIT PULL] SCSI fixes for 5.0-rc2

2019-01-18 Thread James Bottomley
A set of 17 fixes. Most of these are minor or trivial. The one fix that may be serious is the isci one: the bug can cause hba parameters to be set from uninitialized memory. I don't think it's exploitable, but you never know. The patch is available here: git://git.kernel.org/pub/scm/linux/kern

Re: Getting weird TPM error after rebasing my tree to security/next-general

2019-01-18 Thread James Bottomley
On Fri, 2019-01-18 at 16:25 +0200, Jarkko Sakkinen wrote: > I get this on a Geminilake NUC after rebasing my maintainer trees: > > tpm tpm0: A TPM error (-1) occurred attempting the self test > > I checked the latest commit ID from drivers/char/tpm to make sure > that I did not put anything broke

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-18 Thread James Bottomley
On Fri, 2019-01-18 at 16:33 +0200, Jarkko Sakkinen wrote: > On Fri, Jan 11, 2019 at 07:28:58AM -0800, James Bottomley wrote: > > On Fri, 2019-01-11 at 16:02 +0200, Jarkko Sakkinen wrote: > > > On Tue, Jan 08, 2019 at 05:43:53PM -0800, Andy Lutomirski wrote: > > > >

Re: [PATCH v2 00/29] y2038: add time64 syscalls

2019-01-18 Thread James Bottomley
On Fri, 2019-01-18 at 11:57 -0500, Dennis Clarke wrote: > On 1/18/19 11:18 AM, Arnd Bergmann wrote: > > This is a minor update of the patches I posted last week, I > > would like to add this into linux-next now, but would still do > > changes if there are concerns about the contents. The first > >

Re: [PATCH 4/6] crypto: hkdf - RFC5869 Key Derivation Function

2019-01-13 Thread James Bottomley
On Sun, 2019-01-13 at 08:56 +0100, Stephan Müller wrote: > The question may arise why to plug the KDFs into RNGs. The answer is > quite simple: KDFs are a form of random number generator. In that > they take some input for initialization (aka seed, salt, key, > personalization string). Then they pr

Re: [PATCH] scsi: advansys: use struct_size() in kzalloc()

2019-01-11 Thread James Bottomley
On Fri, 2019-01-11 at 08:54 -0800, Matthew Wilcox wrote: > On Fri, Jan 11, 2019 at 08:41:43AM -0800, James Bottomley wrote: > > On Fri, 2019-01-11 at 16:46 +0100, Hannes Reinecke wrote: > > > > - asc_sg_head = kzalloc(sizeof(asc_scs

Re: [PATCH] scsi: advansys: use struct_size() in kzalloc()

2019-01-11 Thread James Bottomley
On Fri, 2019-01-11 at 16:46 +0100, Hannes Reinecke wrote: > On 1/4/19 10:22 PM, Gustavo A. R. Silva wrote: > > One of the more common cases of allocation size calculations is > > finding the > > size of a structure that has a zero-sized array at the end, along > > with memory > > for some number of

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-11 Thread James Bottomley
On Fri, 2019-01-11 at 16:02 +0200, Jarkko Sakkinen wrote: > On Tue, Jan 08, 2019 at 05:43:53PM -0800, Andy Lutomirski wrote: > > (Also, do we have a sensible story of how the TPM interacts with > > hibernation at all? Presumably we should at least try to replay > > the PCR operations that have occ

Re: PROBLEM: syzkaller found / pool corruption-overwrite / page in user-area or NULL

2019-01-10 Thread James Bottomley
On Thu, 2019-01-10 at 19:12 +, Esme wrote: > Sorry for the resend some mail servers rejected the mime type. > > Hi, I've been getting more into Kernel stuff lately and forged ahead > with some syzkaller bug finding. I played with reducing it further > as you can see from the attached c code b

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-09 Thread James Bottomley
On Wed, 2019-01-09 at 12:12 -0800, Andy Lutomirski wrote: > On Wed, Jan 9, 2019 at 11:46 AM James Bottomley > wrote: [...] > > > I’m not sure I follow. Here are the two properties I’d like to > > > see: > > > > > > 1. If you have an encrypted hibernat

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-09 Thread James Bottomley
On Wed, 2019-01-09 at 10:34 -0800, Andy Lutomirski wrote: > > > On Jan 8, 2019, at 10:49 PM, James Bottomley > > senpartnership.com> wrote: > > > > > > On Tue, 2019-01-08 at 17:43 -0800, Andy Lutomirski wrote: > > > [Adding Jarkko because this stuf

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-09 Thread James Bottomley
On Wed, 2019-01-09 at 08:05 +0100, Stephan Mueller wrote: > Am Mittwoch, 9. Januar 2019, 07:58:28 CET schrieb James Bottomley: > > Hi James, > > > On Wed, 2019-01-09 at 07:45 +0100, Stephan Mueller wrote: > > > Am Mittwoch, 9. Januar 2019, 01:44:31 CET sc

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-08 Thread James Bottomley
On Wed, 2019-01-09 at 07:45 +0100, Stephan Mueller wrote: > Am Mittwoch, 9. Januar 2019, 01:44:31 CET schrieb James Bottomley: > > Hi James, > > > Actually, it would be enormously helpful if we could reuse these > > pieces for the TPM as well. > > Could you ple

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-08 Thread James Bottomley
On Tue, 2019-01-08 at 17:43 -0800, Andy Lutomirski wrote: > [Adding Jarkko because this stuff relates to the TPM.] > > On Tue, Jan 8, 2019 at 4:44 PM James Bottomley > wrote: > > > > On Tue, 2019-01-08 at 15:54 -0800, Andy Lutomirski wrote: > > > > On Jan 7

Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

2019-01-08 Thread James Bottomley
On Tue, 2019-01-08 at 15:54 -0800, Andy Lutomirski wrote: > > On Jan 7, 2019, at 11:09 PM, Stephan Mueller > > wrote: > > > > Am Dienstag, 8. Januar 2019, 06:03:58 CET schrieb Herbert Xu: > > > > Hi Herbert, > > > > > Are we going to have multiple implementations for the same KDF? > > > If not

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

2018-12-30 Thread James Bottomley
On Sun, 2018-12-30 at 18:50 +0100, LEROY Christophe wrote: > Arnd Bergmann a écrit : > > On Sat, Dec 29, 2018 at 3:51 AM Michael Schmitz > > wrote: [...] > > > (On second thought - I don't want to speculate whether there's > > > weird compiler options that could result in the > > > nvram_check_ch

[GIT PULL] first round of SCSI updates for the 4.20+ merge window

2018-12-24 Thread James Bottomley
si: libfc: fc_rport: Mark expected switch fall-through scsi: hpsa: mark expected switch fall-throughs scsi: aacraid: Mark expected switch fall-through scsi: aacraid: Mark expected switch fall-throughs Himanshu Madhani (2): scsi: qla2xxx: Update driver version to 10.00.00.12-k

[GIT PULL] SCSI fixes for 4.20-rc7

2018-12-21 Thread James Bottomley
This is two simple target fixes and one discard related I/O starvation problem in sd. The discard problem occurs because the discard page doesn't have a mempool backing so if the allocation fails due to memory pressure, we then lose the forward progress we require if the writeout is on the same de

Re: [PATCH 03/10] SCSI: fcoe: convert to use BUS_ATTR_WO

2018-12-21 Thread James Bottomley
[scsi list cc added] On Fri, 2018-12-21 at 08:54 +0100, Greg Kroah-Hartman wrote: > We are trying to get rid of BUS_ATTR() and the usage of that in the > fcoe driver can be trivially converted to use BUS_ATTR_WO(), so use > that instead. > > At the same time remove a unneeded EXPORT_SYMBOL() marki

[GIT PULL] SCSI fixes for 4.20-rc7

2018-12-18 Thread James Bottomley
Three fixes: The t10-pi one is a regression from the 4.19 release, the qla2xxx one is a 4.20 merge window regression and the bnx2fc is a very old bug. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Dan Carpenter (1):

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread James Bottomley
On Mon, 2018-12-17 at 12:02 -0800, Linus Torvalds wrote: > On Mon, Dec 17, 2018 at 11:51 AM James Bottomley > wrote: > > > > If this is to replace Eric's patch, didn't you want to set > > token_mask to (1< > No, let's not add any extra code that is t

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread James Bottomley
On Mon, 2018-12-17 at 11:39 -0800, Linus Torvalds wrote: > On Mon, Dec 17, 2018 at 11:06 AM Linus Torvalds > wrote: > > > > Honestly, for being about "security", all of this code seems to be > > doing some really questionable things with all those Opt_xyz enums. > > Yeah, at least security/keys/

Re: [PATCH] scsi: qla2xxx: fix unused function warning

2018-12-10 Thread James Bottomley
On Mon, 2018-12-10 at 22:28 +0100, Arnd Bergmann wrote: > On Mon, Dec 10, 2018 at 10:01 PM Bart Van Assche > wrote: > > > > On Mon, 2018-12-10 at 21:51 +0100, Arnd Bergmann wrote: > > > In what seems to be a mismatch between the scsi-fixes branch and > > > the scsi-mkp/for-next branch, a newly in

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: [...] > > Well, I still think the ACPI setup is incorrect. What's in > > /sys/class/platform (should be directories of ACPI devices)? The > > TPM

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: [...] > > However, this makes me wonder about yours: > > > > > [0.003517] ACPI: TPM2 0x9E490ED8 34 (v03 LENOVO > > > TC- > > > S06 1300 AMI ) > > > > I thought the Lenovo "upgrade to 2.0" in fact disabled t

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / > tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via > UEFI setup). Kernel version is 4.19.1 Not that this helps you, but mine definitely works.

Re: [RFC PATCH 6/6] shiftfs: support nested shiftfs mounts

2018-11-02 Thread James Bottomley
On Fri, 2018-11-02 at 15:16 +0200, Amir Goldstein wrote: > On Fri, Nov 2, 2018 at 2:44 PM Seth Forshee om> wrote: > > > > On Fri, Nov 02, 2018 at 12:02:45PM +0200, Amir Goldstein wrote: > > > On Thu, Nov 1, 2018 at 11:49 PM Seth Forshee > > cal.com> wrote: > > > > > > > > shiftfs mounts cannot

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-11-02 Thread James Bottomley
On Fri, 2018-11-02 at 08:50 +1100, NeilBrown wrote: > Firstly, you gave an analytical response to what was, in my view, an > emotional observation. While I agree with your analysis, it is > largely irrelevant. It is not how people *feel* about kernel > development. > > You say that the code

Re: [PATCH v6 0/1] ns: introduce binfmt_misc namespace

2018-11-01 Thread James Bottomley
On Thu, 2018-11-01 at 04:51 +0100, Jann Horn wrote: > On Thu, Nov 1, 2018 at 3:59 AM James Bottomley > wrote: > > > > On Tue, 2018-10-16 at 11:52 +0200, Laurent Vivier wrote: > > > Hi, > > > > > > Any comment on this last version? > > >

Re: [PATCH v6 0/1] ns: introduce binfmt_misc namespace

2018-10-31 Thread James Bottomley
On Tue, 2018-10-16 at 11:52 +0200, Laurent Vivier wrote: > Hi, > > Any comment on this last version? > > Any chance to be merged? I've got a use case for this: I went to one of the Graphene talks in Edinburgh and it struck me that we seem to keep reinventing the type of sandboxing that qemu-use

Re: [PATCH] scsi: aic7xxx: Fix unintended sign extension issue

2018-10-25 Thread James Bottomley
On Thu, 2018-10-25 at 16:13 +0100, Colin King wrote: > From: Colin Ian King > > In the expression "ahc_inb(ahc, port+3) << 24", the initial value is > a u8, but is promoted to a signed int, then sign-extended to > uint64_t. Why is this, that's highly non intuitive? The compiler is supposed to p

Re: [Ksummit-discuss] [GIT PULL] code of conduct fixes for 4.19-rc8

2018-10-23 Thread James Bottomley
On Mon, 2018-10-22 at 22:10 +0100, Greg Kroah-Hartman wrote: > On Sat, Oct 20, 2018 at 01:15:14PM -0700, James Bottomley wrote: > > This is the series of patches which has been discussed on both > > ksummit-discuss and linux-kernel for the past few weeks. As Shuah > > said

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-22 Thread James Bottomley
On Mon, 2018-10-22 at 08:20 +1100, NeilBrown wrote: > On Sat, Oct 20 2018, Greg Kroah-Hartman wrote: > > > Hi all, > > > > As everyone knows by now, we added a new Code of Conduct to the > > kernel tree a few weeks ago. > > I wanted to stay detached from all this, but as remaining (publicly) > s

[GIT PULL] code of conduct fixes for 4.19-rc8

2018-10-20 Thread James Bottomley
This is the series of patches which has been discussed on both ksummit- discuss and linux-kernel for the past few weeks. As Shuah said when kicking off the process, it's designed as a starting point for the next phase of the discussion, not as the end point, so it's only really a set of minor upda

Re: [Ksummit-discuss] [PATCH 6/7] Code of Conduct: Change the contact email address

2018-10-20 Thread James Bottomley
On Sat, 2018-10-20 at 19:28 +0100, Alan Cox wrote: > > +to the circumstances. The Code of Conduct Committee is obligated > > to > > +maintain confidentiality with regard to the reporter of an > > incident. > > +Further details of specific enforcement policies may be posted > > +separately. > > Unf

Re: linux-next: build warning after merge of the scsi tree

2018-10-18 Thread James Bottomley
On Fri, 2018-10-19 at 15:50 +1100, Stephen Rothwell wrote: > Hi James, > > After merging the scsi tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > drivers/scsi/lpfc/lpfc_debugfs.c: In function > 'lpfc_debugfs_nodelist_open': > drivers/scsi/lpfc/lpfc_debugfs.c:

Re: [Ksummit-discuss] [PATCH v3 1/3] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-18 Thread James Bottomley
On Thu, 2018-10-18 at 19:49 +, tim.b...@sony.com wrote: > > -Original Message- > > From: Frank Rowand > > > > On 10/18/18 07:56, James Bottomley wrote: > > > On Wed, 2018-10-17 at 12:53 -0700, Frank Rowand wrote: > > >

Re: [Ksummit-discuss] [PATCH v3 1/3] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-18 Thread James Bottomley
On Wed, 2018-10-17 at 12:53 -0700, Frank Rowand wrote: > On 10/17/18 12:08, James Bottomley wrote: [...] > > > Trying to understand how you are understanding my comment vs what > > > I intended to communicate, it seems to me that you are focused on > > > the "whe

Re: [Ksummit-discuss] [PATCH v3 1/3] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-17 Thread James Bottomley
On Wed, 2018-10-17 at 11:49 -0700, Frank Rowand wrote: > On 10/16/18 19:41, James Bottomley wrote: > > On Tue, 2018-10-16 at 19:10 -0700, Frank Rowand wrote: [...] > > > Repeating my comment on version 1: > > > > > > My understanding of the concern behind th

Re: [Ksummit-discuss] [PATCH] code-of-conduct: Remove explicit list of discrimination factors

2018-10-17 Thread James Bottomley
On Wed, 2018-10-17 at 08:21 -0700, Josh Triplett wrote: > People in underrepresented and commonly marginalized groups, > especially those more commonly overlooked, don't always know if a > given group has taken their particular group into account or given > any thought to it. Explicit inclusion hel

Re: [Ksummit-discuss] [PATCH v3 1/3] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-16 Thread James Bottomley
On Tue, 2018-10-16 at 19:10 -0700, Frank Rowand wrote: > On 10/16/18 07:58, James Bottomley wrote: > > The current code of conduct has an ambiguity in the it considers > > publishing > > private information such as email addresses unacceptable > > behaviour. Since &g

<    1   2   3   4   5   6   7   8   9   10   >