[PATCH 9/9] MIPS: Allow shared IRQ for timer & perf counter

2015-01-27 Thread James Hogan
th shared interrupt handlers registered for both of them. Pre-R2 code should be unaffected. cp0_perfcount_irq will always be -1 and the timer handler will contnue to call into the perf counter handler. Signed-off-by: James Hogan Cc: Ralf Baechle Cc: linux-m...@linux-mips.org --- arch/mips/kerne

[PATCH 7/9] MIPS: perf: Allow sharing IRQ with timer

2015-01-27 Thread James Hogan
dlers that may be on the same IRQ line. Shared handlers must also have a unique device pointer so they can be individually removed, so &mipspmu is now passed in for that instead of NULL. Signed-off-by: James Hogan Cc: Ralf Baechle Cc: Arnaldo Carvalho de Melo Cc: Ingo Molnar Cc: Paul Mack

[PATCH 2/9] MIPS: Use CAUSEF_TI, CAUSEF_PCI constants

2015-01-27 Thread James Hogan
Use CAUSEF_TI and CAUSEF_PCI constants from asm/mipsregs.h rather than the magic values (1 << 30) and (1 << 26). Signed-off-by: James Hogan Cc: Ralf Baechle Cc: linux-m...@linux-mips.org --- arch/mips/kernel/cevt-r4k.c | 2 +- arch/mips/oprofile/op_model_mipsxx.c | 2

[PATCH 8/9] MIPS: OProfile: Allow sharing IRQ with timer

2015-01-27 Thread James Hogan
dlers that may be on the same IRQ line. Signed-off-by: James Hogan Cc: Ralf Baechle Cc: Robert Richter Cc: linux-m...@linux-mips.org Cc: oprofile-l...@lists.sf.net --- arch/mips/oprofile/op_model_mipsxx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/mips/opr

[PATCH 4/9] irqchip: mips-gic: Fix typo in comment

2015-01-27 Thread James Hogan
Fix typo in comment in gic_get_c0_perfcount_int: "erformance" -> "performance". Signed-off-by: James Hogan Cc: Ralf Baechle Cc: Andrew Bresticker Cc: Thomas Gleixner Cc: Jason Cooper Cc: linux-m...@linux-mips.org --- drivers/irqchip/irq-mips-gic.c | 2 +- 1 file cha

[PATCH 3/9] MIPS: Remove redundant IPTI==IPPCI logic

2015-01-27 Thread James Hogan
ile (mipsxx_init()). Signed-off-by: James Hogan Cc: Ralf Baechle Cc: linux-m...@linux-mips.org --- arch/mips/kernel/perf_event_mipsxx.c | 3 +-- arch/mips/oprofile/op_model_mipsxx.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/m

[PATCH 0/9] MIPS: Allow shared IRQ for timer & perf counter

2015-01-27 Thread James Hogan
Cc: Thomas Gleixner Cc: linux-m...@linux-mips.org Cc: oprofile-l...@lists.sf.net James Hogan (9): MIPS: cevt-r4k: Move handle_perf_irq() out of header MIPS: Use CAUSEF_TI, CAUSEF_PCI constants MIPS: Remove redundant IPTI==IPPCI logic irqchip: mips-gic: Fix typo in comment irqchip: mip

Re: [PATCH 1/3] MIPS: Add arch CDMM definitions and probing

2015-01-28 Thread James Hogan
Hi Maciej, On Wednesday 28 January 2015 23:09:17 Maciej W. Rozycki wrote: > On Tue, 27 Jan 2015, James Hogan wrote: > > > diff --git a/arch/mips/include/asm/cpu.h b/arch/mips/include/asm/cpu.h > > index 33866fce4d63..2086372fa72a 100644 > > --- a/arch/mips/include/asm/c

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread James Hogan
fall back to the default timeout value if watchdog_init_timeout() > fails. Whoops. Sorry about that. I wasn't aware that a timeout-sec value was expected. It isn't mentioned in the DT binding documentation for this device :-(. > > Signed-off-by: Andrew Bresticker > Cc:

Re: [PATCH] MIPS64: R6: R2 emulation bugfix

2015-04-29 Thread James Hogan
an we stick to STR(PTR) for consistency please? With that change made: Reviewed-by: James Hogan Please also add these tags: Fixes: b0a668fb2038 ("MIPS: kernel: mips-r2-to-r6-emul: Add R2 emulator for MIPS R6") Cc: # 4.0+ Thanks James > > Signed-off-by: Leonid Yegoshin > ---

Re: [PATCH] MIPS64: R6: R2 emulation bugfix

2015-04-29 Thread James Hogan
On 29/04/15 10:49, Maciej W. Rozycki wrote: > On Wed, 29 Apr 2015, James Hogan wrote: > >>> Error recovery pointers for fixups was improperly set as ".word" >>> which is unsuitable for MIPS64. >>> >>> Replaced by __stringify(PTR) >> &

Re: metag test failure in -next due to commit 'module: relocate module_init from init.h to module.h'

2015-06-05 Thread James Hogan
made it a quick one to figure out. Paul, please consider applying the patch below before the offending commit "module: relocate module_init from init.h to module.h", so as not to break bisection. Cheers James From e12856c559d7dff2ad4f6497996610e12e7c7e2d Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] MIPS: KVM: do not sign extend on unsigned MMIO load

2015-06-08 Thread James Hogan
Hi stable folk, On 08/05/15 15:16, James Hogan wrote: > On 07/05/15 13:47, Nicholas Mc Guire wrote: >> Fix possible unintended sign extension in unsigned MMIO loads by casting >> to uint16_t in the case of mmio_needed != 2. >> >> Signed-off-by: Nicholas Mc Guire >

Re: [PATCH 1/3] MIPS: R6: Use lightweight SYNC instruction in smp_* memory barriers

2015-06-02 Thread James Hogan
Hi Leonid, On 02/06/15 01:09, Leonid Yegoshin wrote: > This instructions were specifically designed to work for smp_*() sort of > memory barriers in MIPS R2/R3/R5 and R6. > > Unfortunately, it's description is very cryptic and is done in HW engineering > style which prevents use of it by SW. This

Re: [PATCH 2/3] MIPS: enforce LL-SC loop enclosing with SYNC (ACQUIRE and RELEASE)

2015-06-02 Thread James Hogan
Hi Leonid, On 02/06/15 01:09, Leonid Yegoshin wrote: > Many MIPS32 R2 and all MIPS R6 CPUs are out of order execution, so it > needs memory barriers in SMP environment. However, past cores may have > a pipeline short enough to ignore that requirements and problem may > never occurs until recently.

Re: [PATCH 3/3] MIPS: bugfix - replace smp_mb with release barrier function in unlocks

2015-06-02 Thread James Hogan
On 02/06/15 01:09, Leonid Yegoshin wrote: > Repleace smp_mb() in arch_write_unlock() and __clear_bit_unlock() to Replace. > smp_mb__before_llsc() call which does "release" barrier functionality. > > It seems like it was missed in commit f252ffd50c97dae87b45f1dbad24f71358ccfbd6 > during introduct

Re: [PATCH v1] MIPS: PCI: Use dev_printk() when possible

2018-05-23 Thread James Hogan
%s not available " > -"because of resource collisions\n", > -pci_name(dev)); > + pci_err(dev, "can't enable device: resource > collisions\n"); The pedantic side of me wants to point out that you could wrap tha

Re: [PATCH 3.16 091/254] MIPS: CPS: Fix r1 .set mt assembler warning

2018-03-01 Thread James Hogan
On Wed, Feb 28, 2018 at 03:20:18PM +, Ben Hutchings wrote: > 3.16.55-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: James Hogan > > commit 17278a91e04f858155d54bee5528ba4fbcec6f87 upstream.

Re: [PATCH v4 3/3] MIPS: use generic GCC library routines from lib/

2018-04-03 Thread James Hogan
On Thu, Mar 29, 2018 at 11:41:23AM +0100, Matt Redfearn wrote: > This commit removes several generic GCC library routines from > arch/mips/lib/ in favour of similar routines from lib/. > diff --git a/arch/mips/lib/Makefile b/arch/mips/lib/Makefile > index e84e12655fa8..6537e022ef62 100644 > --- a/

Re: [PATCH v4 1/3] Add notrace to lib/ucmpdi2.c

2018-04-03 Thread James Hogan
On Tue, Apr 03, 2018 at 02:51:06PM +0100, Matt Redfearn wrote: > On 29/03/18 22:59, Palmer Dabbelt wrote: > > Ah, thanks, I think I must have forgotten about this.  I assume these > > three are going through your tree? > > Yeah I think that's the plan - James will need your ack to patch 2 if > t

Re: [PATCH v5 3/3] MIPS: use generic GCC library routines from lib/

2018-04-03 Thread James Hogan
commit removes several generic GCC library routines from > arch/mips/lib/ in favour of similar routines from lib/. > > Signed-off-by: Antony Pavlov > [Matt Redfearn] Use GENERIC_LIB_* named Kconfig entries > Signed-off-by: Matt Redfearn > Cc: Palmer Dabbelt > Cc: Matt R

Re: [GIT PULL] arch: remove obsolete architecture ports

2018-04-04 Thread James Hogan
On Wed, Apr 04, 2018 at 10:38:41AM +0200, Arnd Bergmann wrote: > Also, now that the other architectures are gone, a lot of changes can > be done more easily that will be incompatible with a pure revert, so > the more time passes, the harder it will get to do that. Yes, and an out-of-tree arch port

Re: [PATCH v5 2/3] lib: Rename compiler intrinsic selects to GENERIC_LIB_*

2018-04-04 Thread James Hogan
On Tue, Apr 03, 2018 at 03:39:34PM -0700, Palmer Dabbelt wrote: > Sorry, I'm not sure if this is the right patch -- someone suggested acking > this, but it's already Review-By me and if I understand correctly it's going > through your tree. I'm a bit new to this, but if it helps then here's a >

Re: [PATCH V4 Resend] ZBOOT: fix stack protector in compressed boot phase

2018-03-28 Thread James Hogan
rt = (unsigned long)(&__image_begin); > zimage_size = (unsigned long)(&__image_end) - > (unsigned long)(&__image_begin); This looks good to me, though I've Cc'd Kees as apparently the original author from commit 8779657d29c0 ("stackprotector: Introduce CONF

Introducing a nanoMIPS port for Linux

2018-05-02 Thread James Hogan
rton, James Hogan, Matt Redfearn, Marcin Nowakowski [1] https://www.mips.com/press/new-mips-i7200-processor-core-delivers-unmatched-performance-and-efficiency-for-advanced-lte5g-communications-and-networking-ic-designs/ signature.asc Description: Digital signature

Re: [PATCH] KVM: fix spelling mistake: "cop_unsuable" -> "cop_unusable"

2018-05-14 Thread James Hogan
On Mon, May 14, 2018 at 06:23:50PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in debugfs_entries text > > Signed-off-by: Colin Ian King Adding KVM folk. Its a fairly trivial change so I'll just take it as a fix via the MIPS tree unless anybody objects.

Re: [PATCH 1/2] mips: xilfpga: stop generating useless dtb.o

2018-05-14 Thread James Hogan
On Wed, Apr 25, 2018 at 11:10:35PM +0200, Alexandre Belloni wrote: > a dtb.o is generated from nexys4ddr.dts but this is never used since it has > been moved to mips/generic with commit b35565bb16a5 ("MIPS: generic: Add > support > for MIPSfpga") > > Signed-off-by: Alexandre Belloni Both applie

Re: [PATCH] MIPS: Fix ptrace(2) PTRACE_PEEKUSR and PTRACE_POKEUSR accesses to o32 FGRs

2018-05-14 Thread James Hogan
On Mon, May 14, 2018 at 04:49:43PM +0100, Maciej W. Rozycki wrote: > Check the TIF_32BIT_FPREGS task setting of the tracee rather than the > tracer in determining the layout of floating-point general registers in > the floating-point context, correcting access to odd-numbered registers > for o32

Re: [PATCH v3 4/7] MIPS: perf: Fix perf with MT counting other threads

2018-05-16 Thread James Hogan
On Fri, Apr 20, 2018 at 11:23:06AM +0100, Matt Redfearn wrote: > diff --git a/arch/mips/kernel/perf_event_mipsxx.c > b/arch/mips/kernel/perf_event_mipsxx.c > index 7e2b7d38a774..fe50986e83c6 100644 > --- a/arch/mips/kernel/perf_event_mipsxx.c > +++ b/arch/mips/kernel/perf_event_mipsxx.c > @@ -323,

Re: [PATCH v3 5/7] MIPS: perf: Allocate per-core counters on demand

2018-05-16 Thread James Hogan
On Fri, Apr 20, 2018 at 11:23:07AM +0100, Matt Redfearn wrote: > Previously when performance counters are per-core, rather than > per-thread, the number available were divided by 2 on detection, and the > counters used by each thread in a core were "swizzled" to ensure > separation. However, this s

Re: [PATCH] MIPS: c-r4k: fix data corruption related to cache coherence.

2018-04-25 Thread James Hogan
Hi NeilBrown, On Wed, Apr 25, 2018 at 02:08:15PM +1000, NeilBrown wrote: > Cc: sta...@vger.kernel.org (v4.8) FYI my preferred form of this is: Cc: # 4.8+ > /* >* Either no secondary cache or the available caches don't have the >* subset property so we have to flush the pr

Re: [PATCH] MIPS: c-r4k: fix data corruption related to cache coherence.

2018-04-25 Thread James Hogan
On Thu, Apr 26, 2018 at 08:00:18AM +1000, NeilBrown wrote: > On Wed, Apr 25 2018, James Hogan wrote: > > So I'm thinking "!mips_cm_present()" should probably be replaced with > > "!r4k_op_needs_ipi(R4K_INDEX)" (and the comment updated to mention th

Re: [patch 06/26] metag: Use irq_set_affinity instead of homebrewn code

2014-02-24 Thread James Hogan
ive_irq() > > Signed-off-by: Thomas Gleixner > Cc: James Hogan > Cc: metag > --- > arch/metag/kernel/irq.c | 20 +++- > 1 file changed, 3 insertions(+), 17 deletions(-) > > Index: tip/arch/metag/kernel/irq.c > ===

Re: [PATCH] asm-generic: add sched_setattr/sched_getattr syscalls

2014-02-24 Thread James Hogan
On 17/02/14 18:44, Catalin Marinas wrote: > On Mon, Feb 03, 2014 at 03:33:37PM +0000, James Hogan wrote: >> Add the sched_setattr and sched_getattr syscalls to the generic syscall >> list, which is used by the following architectures: arc, arm64, c6x, >> hexagon, metag,

Re: [patch 06/26] metag: Use irq_set_affinity instead of homebrewn code

2014-02-25 Thread James Hogan
Hi Thomas, Sorry for delay, I didn't get a chance to try this earlier. On Monday 24 February 2014 15:24:55 Thomas Gleixner wrote: > On Mon, 24 Feb 2014, James Hogan wrote: > > On 23/02/14 21:40, Thomas Gleixner wrote: > > > There is no point in having an incomplete c

Re: [PATCH] seccomp: not compatible with ARM OABI

2013-11-07 Thread James Hogan
Hi, On 06/11/13 23:31, Kees Cook wrote: > diff --git a/arch/Kconfig b/arch/Kconfig > index af2cc6eabcc7..6eaca7d92399 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER > > config SECCOMP_FILTER > def_bool y > - depends on HAVE_ARC

Re: [PATCH] irq: Changed the return type of irq_chip.irq_startup() from unsigned int to int

2014-03-04 Thread James Hogan
On 04/03/14 10:57, Thomas Gleixner wrote: > The reason is the usage of commata instead of semicolons. You can work > around that with cocci, but that gets ugly > > Thanks, > > tglx > > --- a/drivers/gpio/gpio-tz1090.c > +++ b/drivers/gpio/gpio-tz1090.c > @@ -488,26 +488,26 @@ static i

[GIT PULL] Metag arch and asm-generic fixes for v3.14

2014-02-27 Thread James Hogan
). James Hogan (2): asm-generic: add sched_setattr/sched_getattr syscalls irq-metag*: stop set_affinity vectoring to offline cpus drivers/irqchip/irq-metag-ext.c | 2 +- drivers/irqchip/irq-metag.c | 2

Re: [PATCH V2] sparse: Allow override of sizeof(bool) warning

2014-02-27 Thread James Hogan
On 27/02/14 16:52, H. Peter Anvin wrote: > On 02/27/2014 08:10 AM, Dan Carpenter wrote: >> >> That last assumption has to change for the Meta architecture. >> >> https://lwn.net/Articles/522188/ >> >> On meta, the structs and unions are padded to 4 bytes unless they are >> explicitly marked as __pa

Re: [PATCH] irq: Changed the return type of irq_chip.irq_startup() from unsigned int to int

2014-02-28 Thread James Hogan
On Thursday 27 February 2014 18:21:19 Jean-Jacques Hiblot wrote: > arch/arm/mach-omap2/gpmc.c| 2 +- > arch/blackfin/mach-common/ints-priority.c | 2 +- > arch/ia64/hp/sim/hpsim_irq.c | 2 +- > arch/ia64/kernel/iosapic.c| 4 ++-- > arch/ia64/kernel/irq_

Re: [PATCH 12/44] metag: Use get_signal() signal_setup_done()

2014-03-03 Thread James Hogan
Hi Richard, On 02/03/14 23:57, Richard Weinberger wrote: > @@ -235,10 +230,8 @@ static void handle_signal(unsigned long sig, siginfo_t > *info, > static int do_signal(struct pt_regs *regs, int syscall) > { > unsigned int retval = 0, continue_addr = 0, restart_addr = 0; > - struct k_si

Re: [PATCH 12/44] metag: Use get_signal() signal_setup_done()

2014-03-18 Thread James Hogan
On 03/03/14 11:15, James Hogan wrote: > Hi Richard, > > On 02/03/14 23:57, Richard Weinberger wrote: >> @@ -235,10 +230,8 @@ static void handle_signal(unsigned long sig, siginfo_t >> *info, >> static int do_signal(struct pt_regs *regs, int syscall) >>

Re: [PATCH v2 1/7] sched: remove unused SCHED_INIT_NODE

2014-03-19 Thread James Hogan
On 18/03/14 17:56, Vincent Guittot wrote: > not used since new numa scheduler init sequence > > Signed-off-by: Vincent Guittot Applied to metag tree for v3.15, Thanks for spotting it. Cheers James > --- > arch/metag/include/asm/topology.h | 27 --- > 1 file changed, 2

drm/i915: XPS13 backlight regression in v3.14

2014-04-02 Thread James Hogan
Hi, I've noticed that v3.14 breaks the backlight on Dell XPS13. Reverting the following commit fixes the issue for me (i.e. the GUI brightness controls work again): bc0bb9fd1c78 drm/i915: remove QUIRK_NO_PCH_PWM_ENABLE It appears that in v3.14 (with the above patch): * intel_backlight/brightne

Re: [PATCH 08/20] of/fdt: consolidate built-in dtb section variables

2014-04-07 Thread James Hogan
On 03/04/14 23:16, Rob Herring wrote: > From: Rob Herring > > Unify the various architectures __dtb_start and __dtb_end definitions > moving them into of_fdt.h. > > Signed-off-by: Rob Herring > Cc: Vineet Gupta > Cc: James Hogan > Cc: Ralf Baechle > Cc: Jonas

Re: [Suggest] arch: metag: compiler: Are they compiler's issues?

2014-01-10 Thread James Hogan
On 10/01/14 15:57, Chen Gang wrote: > On 01/08/2014 11:01 PM, Chen Gang wrote: >> On 01/06/2014 06:31 PM, James Hogan wrote: >>> I suspect this is due to bad assumptions in the code. The metag ABI is >>> unusual in padding the size of structs to a 32bit boundary even if

Re: [Suggest] arch: metag: compiler: Are they compiler's issues?

2014-01-10 Thread James Hogan
On 10/01/14 16:20, Chen Gang wrote: > On 01/11/2014 12:02 AM, James Hogan wrote: >> On 10/01/14 15:57, Chen Gang wrote: >>> On 01/08/2014 11:01 PM, Chen Gang wrote: >>>> On 01/06/2014 06:31 PM, James Hogan wrote: >>>>> I suspect this is due to

[PATCH] arch: include/asm/Kbuild: fix preempt.h sort order

2013-11-29 Thread James Hogan
Commit a787870924db (sched, arch: Create asm/preempt.h) added the generic asm/preempt.h header, but took no notice of the sort order of various architecture's include/asm/Kbuild files. Move preempt.h into the correct sort position in files which are mostly already sorted. Signed-off-by:

Re: [PATCH v2 14/29] metag: use early_init_dt_scan

2013-11-08 Thread James Hogan
On 07/10/13 17:29, Rob Herring wrote: > From: Rob Herring > > Convert metag to use new early_init_dt_scan function. > > Signed-off-by: Rob Herring > Cc: James Hogan Acked-by: James Hogan Cheers James > --- > arch/metag/kernel/devtree.c | 7 +-- > 1 file

Re: [PATCH v2 22/29] of: remove early_init_dt_setup_initrd_arch

2013-11-08 Thread James Hogan
er > Cc: Aurelien Jacquiot > Cc: James Hogan > Cc: Michal Simek > Cc: Ralf Baechle > Cc: Jonas Bonn > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x...@kernel.org > Cc: Chr

Re: [PATCH v2 08/29] metag: use unflatten_and_copy_device_tree

2013-11-08 Thread James Hogan
On 07/10/13 17:29, Rob Herring wrote: > From: Rob Herring > > Use the common unflatten_and_copy_device_tree to copy the built-in FDT > out of init section. > > Signed-off-by: Rob Herring > Cc: James Hogan With Qais' suggestion of removing the extern void copy

Re: [PATCH v2 08/29] metag: use unflatten_and_copy_device_tree

2013-11-08 Thread James Hogan
On 08/11/13 17:26, Rob Herring wrote: > On Fri, Nov 8, 2013 at 7:12 AM, James Hogan wrote: >> On 07/10/13 17:29, Rob Herring wrote: >>> From: Rob Herring >>> >>> Use the common unflatten_and_copy_device_tree to copy the built-in FDT >>> out of ini

[GIT PULL] Metag architecture changes for v3.13

2013-11-11 Thread James Hogan
Carpenter. Dan Carpenter (1): metag: off by one in setup_bootmem_node() James Hogan (1): metag: handle low level kicks directly arch/metag/include/asm/tbx.h | 19 +++ arch/metag/kernel/setup.c| 6

Re: [PATCH 05/11] metag: use generic fixmap.h

2013-11-12 Thread James Hogan
On 12/11/13 13:22, Mark Salter wrote: > Signed-off-by: Mark Salter > CC: James Hogan > CC: linux-me...@vger.kernel.org Acked-by: James Hogan Thanks James > --- > arch/metag/include/asm/fixmap.h | 32 +--- > 1 file changed, 1 insertio

Re: [PATCH 2/2] mmc: dw_mmc: Protect read-modify-write of INTMASK with a lock

2013-10-16 Thread James Hogan
and then protect INTMASK modifications by the standard host > lock. This seemed like a bit more of a high-latency change. A probably lighter-weight alternative to that alternative is to just make the existing lock irq safe. Has this been considered? I'm not entirely convinced it's w

Re: [PATCH 2/2] mmc: dw_mmc: Protect read-modify-write of INTMASK with a lock

2013-10-16 Thread James Hogan
Hi Doug, On 16 October 2013 17:43, Doug Anderson wrote: > On Wed, Oct 16, 2013 at 2:49 AM, James Hogan wrote: >>> We can't just use the standard host->lock since that lock is not irq >>> safe and mmc_signal_sdio_irq() (called from interrupt context) calls >>

Re: [PATCH 1/9] dt: Handle passed/built-in DT selection in early_init_dt_scan()

2013-11-19 Thread James Hogan
On 19/11/13 11:12, Geert Uytterhoeven wrote: > Let early_init_dt_scan() fall-back to the built-in DT if no DT was passed, > or if it's invalid, so architectures don't have to duplicate this logic. > > Suggested-by: Rob Herring > Signed-off-by: Geert Uytterhoeven

Re: [PATCH 15/31] mips/kvm: Exception handling to leave and reenter guest mode.

2013-10-11 Thread James Hogan
Hi David, I know it's been a while since you posted this patchset, but thought you might appreciate the feedback anyway. Some of my comments/suggestions relate to portability with MIPS32. I don't object if you respond to those by just adding "depends on 64BIT" so that I & others can fix it up in

[RFC PATCH -next] Fix printk_once build errors due to __read_mostly

2013-10-30 Thread James Hogan
, which includes . The actual dependencies are all in macros so it doesn't actually seem to result in any build failures, but it's clearly less than ideal. Signed-off-by: James Hogan Cc: Joe Perches Cc: Andrew Morton Cc: linux-me...@vger.kernel.org --- This build failure was caught in today

Re: perf events ring buffer memory barrier on powerpc

2013-10-30 Thread James Hogan
Hi Peter, On 30/10/13 10:42, Peter Zijlstra wrote: > Subject: perf, tool: Add required memory barriers > > To match patch bf378d341e48 ("perf: Fix perf ring buffer memory > ordering") change userspace to also adhere to the ordering outlined. > > Most barrier implementations were gleaned from > a

Re: [PATCH V2] printk/cache: Mark printk_once test variable __read_mostly

2013-10-31 Thread James Hogan
CACHE_BYTES) > +#define L1_CACHE_ALIGN(x) __KERNEL_ALIGN(x, L1_CACHE_BYTES) I think that should be __ALIGN_KERNEL (same applies to commit message). Otherwise this patch looks good to me and builds all Meta defconfigs fine. Reviewed-by: James Hogan Thanks James -- To unsubscribe from this list:

[PATCH v10] fs: imgdafs: Add IMG DAFS filesystem for metag

2013-12-13 Thread James Hogan
Add the IMG Debug Adapter File System (DAFS) for metag, which uses SWITCH operations to communicate with a file server on a host computer via a JTAG debug adapter. Signed-off-by: James Hogan Cc: Alexander Viro Cc: linux-fsde...@vger.kernel.org Cc: linux-me...@vger.kernel.org --- I haven&#

[PATCH] clk: clk-divider: fix divisor > 255 bug

2013-12-16 Thread James Hogan
resultant clock rate to be too high. E.g. in my case an 11bit divider was supposed to divide 24.576 MHz down to 32.768KHz. The divisor was correctly calculated as 750 (0x2ee). This was masked to 238 (0xee) resulting in a frequency of 103.26KHz. Signed-off-by: James Hogan Cc: Rajendra Nayak Cc: Mike

Re: [PATCH] arch/metag/kernel/cachepart.c: fix failure check

2014-07-18 Thread James Hogan
On 17/07/14 16:58, Andrey Utkin wrote: > [linux-3.16-rc5/arch/metag/kernel/cachepart.c:102]: (style) Checking if > unsigned variable 'thread_cache_size' is less than zero. > > Source code is > > if (thread_cache_size < 0) > pr_emerg("Can't read %s cache size\n", >

Re: [PATCH v2 15/29] nios2: System calls handling

2014-07-18 Thread James Hogan
Hi, On 15/07/14 09:45, Ley Foon Tan wrote: > This patch adds support for system calls from userspaces. It uses the > asm-generic/unistd.h definitions with architecture spcific syscall. The > sys_call_table > is just an array defined in a C file and it contains pointers to the syscall > functions

[PATCH 1/3] asm-generic: Add renameat2 syscall

2014-04-23 Thread James Hogan
Add the renameat2 syscall to the generic syscall list, which is used by the following architectures: arc, arm64, c6x, hexagon, metag, openrisc, score, tile, unicore32. Signed-off-by: James Hogan Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: Vineet Gupta Cc: Catalin Marinas Cc: Will

[RFC 2/3] scripts/checksyscalls.sh: Make renameat optional

2014-04-23 Thread James Hogan
The new renameat2 syscall provides all the functionality of renameat with an additional flags argument, so make renameat optional so that future architectures can omit it without getting a warning. Signed-off-by: James Hogan Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org --- This patch

[PATCH 0/3] asm-generic: Add renameat2, drop renameat by default

2014-04-23 Thread James Hogan
these two and queue them for v3.16. James Hogan (3): asm-generic: Add renameat2 syscall scripts/checksyscalls.sh: Make renameat optional asm-generic: Drop renameat syscall from default list arch/arc/include/uapi/asm/unistd.h | 1 + arch/arm64/include/uapi/asm/unistd.h | 3 +++

[RFC 3/3] asm-generic: Drop renameat syscall from default list

2014-04-23 Thread James Hogan
s unistd.h prior to including asm-generic/unistd.h, and adjust all architectures using the generic syscall list to define it so that no in-tree architectures are affected. Signed-off-by: James Hogan Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: Vineet Gupta Cc: Catalin Marinas Cc: Will

Re: [PATCH 07/15] mips: add renameat2 syscall

2014-04-23 Thread James Hogan
(cc'ing linux-mips list) On 11 April 2014 11:25, Miklos Szeredi wrote: > From: Miklos Szeredi > > Signed-off-by: Miklos Szeredi > Cc: Ralf Baechle Identical to the patch I just sent to linux-mips, so: Reviewed-by: James Hogan Cheers James > --- > arch/mips/include

Re: [PATCH 15/15] asm-generic: add renameat2 syscall

2014-04-23 Thread James Hogan
Hi Miklos, On 11 April 2014 11:25, Miklos Szeredi wrote: > From: Miklos Szeredi > > Signed-off-by: Miklos Szeredi > Cc: Arnd Bergmann Acked-by: James Hogan [metag] Thanks James > --- > include/uapi/asm-generic/unistd.h | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list

2014-04-23 Thread James Hogan
On 23 April 2014 13:18, Arnd Bergmann wrote: > On Wednesday 23 April 2014, James Hogan wrote: >> The new renameat2 syscall provides all the functionality provided by the >> renameat syscall and adds flags, so future architectures won't need to >> include renameat

Re: [PATCH] slab: fix the type of the index on freelist index accessor

2014-04-24 Thread James Hogan
ad effect and make things > more easier. This fix was suggested and tested by Steven in his > original report. > > Reported-by: Steven King > Signed-off-by: Joonsoo Kim I also hit this problem on MIPS with v3.15-rc2 and 16K pages. With this patch it boots fine. Tested-by: James

Re: [PATCH] vfs: workaround gcc <4.6 build error in link_path_walk()

2014-09-17 Thread James Hogan
On 16/09/14 18:39, Al Viro wrote: > On Tue, Sep 16, 2014 at 01:07:35PM +0100, James Hogan wrote: >> Commit d6bb3e9075bb (vfs: simplify and shrink stack frame of >> link_path_walk()) introduced build problems with GCC versions older than >> 4.6 due to the initialisation of a m

Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP

2014-09-19 Thread James Hogan
e wrapped to 80 columns. Other than that, I've tested this on metag and can confirm that it fixes the following BUG which you would otherwise get during boot with Aaron's patches: BUG: failure at kernel/sched/core.c:2664/schedule_debug()! Kernel panic - not syncing: BUG! Tested-by: Jame

Re: [PATCH linux-next] net: batman-adv: use "__packed __aligned(2)" for each structure instead of "__packed(2)" region

2014-01-18 Thread James Hogan
On Saturday 18 January 2014 14:03:26 Antonio Quartulli wrote: > On 18/01/14 12:31, Chen Gang wrote: > > Unfortunately, not all compilers assumes the structures within a pack > > region also need be packed (e.g. metag), so need add a pack explicitly > > to satisfy all compilers. > > > > The related

Re: [PATCH linux-next] net: batman-adv: use "__packed __aligned(2)" for each structure instead of "__packed(2)" region

2014-01-20 Thread James Hogan
Hi Antonio, On 19/01/14 09:30, Antonio Quartulli wrote: > On 19/01/14 02:10, James Hogan wrote: >> It appears that the following gcc patch adds support for #pragma pack: >> http://gcc.gnu.org/ml/gcc-patches/2006-10/msg01115.html >> >> I gave it a quick spin on metag

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-20 Thread James Hogan
Hi Chen, On 19/01/14 10:07, Chen Gang wrote: > BTW: this patch is related with another patch which is discussing (so I > have cc that patch to you and Greg too): "if we could sure that it is a > compiler's feature issue, we will skip this patch". If you're referring to the #pragma pack portabilit

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-20 Thread James Hogan
On 20/01/14 12:30, Dan Carpenter wrote: > Ah. From so metag is a new arch and not a compiler like the changelog > says. > > On Mon, Jan 20, 2014 at 11:56:47AM +, James Hogan wrote: >> struct a { >> struct b { >> unsigned int x; >>

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-20 Thread James Hogan
On 20/01/14 13:01, Dan Carpenter wrote: > It would be easy enough to make the compiler complain about any union > which would normally have size which is not a multiple of 4. > > Warning: union will be padded with 2 bytes unless __attribute__((packed)). > > Otherwise you will be fighting this for

[GIT PULL] Metag architecture changes for v3.14

2014-01-20 Thread James Hogan
single function call IPI. Chen Gang (1): metag: topology: export 'cpu_core_map' Geert Uytterhoeven (1): metag/smp: Make boot_secondary() static James Hogan (2): metag: dma: remove dead code in dma_

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-21 Thread James Hogan
Hi Dan, On 20/01/14 21:13, Dan Carpenter wrote: > I made a quick and dirty sparse patch to check for this. I don't think > I will bother trying to send it to sparse upstream, but you can if you > want to. > > It found 289 unions which might need a __packed added. The lustre > unions were not in

Re: [PATCH V2] MIPS: bugfix of coherentio variable default setup

2014-09-11 Thread James Hogan
On 08/09/14 20:10, Leonid Yegoshin wrote: > diff --git a/arch/mips/include/asm/mach-generic/dma-coherence.h > b/arch/mips/include/asm/mach-generic/dma-coherence.h > index 7629c35..b4563df 100644 > --- a/arch/mips/include/asm/mach-generic/dma-coherence.h > +++ b/arch/mips/include/asm/mach-generic/d

[PATCH] tty/metag_da: Add console_poll module parameter

2014-09-12 Thread James Hogan
appending metag_da.console_poll to the kernel command line. Signed-off-by: James Hogan Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Guenter Roeck --- drivers/tty/metag_da.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/tty/metag_da.c b/drivers/tty/metag_da.c inde

[PATCH] vfs: workaround gcc <4.6 build error in link_path_walk()

2014-09-16 Thread James Hogan
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=159206 Fixes: d6bb3e9075bb (vfs: simplify and shrink stack frame of link_path_walk()) Signed-off-by: James Hogan Cc: Linus Torvalds Cc: Alexander Viro Cc: Geert Uytterhoeven Cc: linux-fsde...@vger.kernel.org Cc: linux-me...@vger.kernel.or

Re: [tip:sched/core] sched: Rework sched_domain topology definition

2014-05-16 Thread James Hogan
Hi Vincent, On 8 May 2014 11:43, tip-bot for Vincent Guittot wrote: > Commit-ID: 143e1e28cb40bed836b0a06567208bd7347c9672 > Gitweb: http://git.kernel.org/tip/143e1e28cb40bed836b0a06567208bd7347c9672 > Author: Vincent Guittot > AuthorDate: Fri, 11 Apr 2014 11:44:37 +0200 > Committer: In

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-01 Thread James Hogan
which didn't showed any problems yet. This also fixes a BUG on metag if the RLIMIT_STACK hard limit is increased beyond a safe value by root. E.g. when starting a process after running "ulimit -H -s unlimited" it will then attempt to use a stack size of the maximum 1GB which is far too

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-02 Thread James Hogan
On 01/05/14 18:50, James Bottomley wrote: > >> + >> +config MAX_STACK_SIZE_MB >> +int "Maximum user stack size (MB)" >> +default 80 >> +range 8 256 if METAG >> +range 8 2048 >> +depends on STACK_GROWSUP >> +help >> + This is the maximum stack size in Megabytes in the V

Re: [PATCH] compiler.h: don't use temporary variable in __compiletime_assert()

2014-05-13 Thread James Hogan
me_error_fallback which uses the potentially negative size array to trigger a conditional compiler error, so that sparse doesn't see it. Signed-off-by: James Hogan Cc: Johannes Berg Cc: Daniel Santos Cc: Luciano Coelho Cc: Peter Zijlstra Cc: Paul E. McKenney Cc: Andrew Morton --- It

Re: [PATCH 01/25] asm-generic: Change time_t and clock_t to 64 bit

2014-05-13 Thread James Hogan
Hi, On 13 May 2014 10:02, Ley Foon Tan wrote: > Use 64 bit time_t and clock_t as default. 32 bit users can provide > an override to define these as "long" if needed. > > Signed-off-by: Ley Foon Tan > --- > include/uapi/asm-generic/posix_types.h | 14 -- > 1 file changed, 12 insertio

Re: [PATCH 12/25] metag: Add 32 bit time_t and clock_t

2014-05-13 Thread James Hogan
Hi, On 13/05/14 10:04, Ley Foon Tan wrote: > Override time_t and clock_t in include/uapi/asm-generic. > > Signed-off-by: Ley Foon Tan > --- > arch/metag/include/asm/Kbuild | 1 - > arch/metag/include/uapi/asm/Kbuild| 1 + > arch/metag/include/uapi/asm/posix_types.h | 17 ++

Re: [PATCH 01/25] asm-generic: Change time_t and clock_t to 64 bit

2014-05-13 Thread James Hogan
Hi, On 13/05/14 10:32, Ley Foon Tan wrote: > On Tue, May 13, 2014 at 5:15 PM, James Hogan wrote: >> On 13 May 2014 10:02, Ley Foon Tan wrote: >>> /* >>> + * Use 64 bit time_t and clock_t as default. 32 bit users can provide an >>> override to >

Re: [PATCH 12/20] arch,metag: Fold atomic_ops

2014-05-13 Thread James Hogan
On 08/05/14 14:58, Peter Zijlstra wrote: > Many of the atomic op implementations are the same except for one > instruction; fold the lot into a few CPP macros and reduce LoC. > > This also prepares for easy addition of new ops. > > Cc: James Hogan > Cc: Linus Torvalds &

Re: [PATCH 01/25] asm-generic: Change time_t and clock_t to 64 bit

2014-05-13 Thread James Hogan
On 13/05/14 11:17, Ley Foon Tan wrote: > On Tue, May 13, 2014 at 5:50 PM, James Hogan wrote: >> Hi, >> >> On 13/05/14 10:32, Ley Foon Tan wrote: >>> On Tue, May 13, 2014 at 5:15 PM, James Hogan wrote: >>>> On 13 May 2014 10:02, Ley Foon Tan wrote:

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-13 Thread James Hogan
Hi Helge, On 04/05/14 08:28, Helge Deller wrote: > On 05/02/2014 04:48 PM, James Bottomley wrote: >> On Fri, 2014-05-02 at 12:54 +0100, James Hogan wrote: >>> On 01/05/14 18:50, James Bottomley wrote: >>>> >>>>> + >>>>> +confi

Re: [PATCH v6 2/3] ARM: sunxi: Add driver for sunxi IR controller

2014-05-13 Thread James Hogan
Hi Alexander, Just a few probe error handling suggestions... On 13/05/14 19:39, Alexander Bersenev wrote: > +static int sunxi_ir_probe(struct platform_device *pdev) > +{ > + int ret = 0; > + unsigned long tmp = 0; > + > + struct device *dev = &pdev->dev; > + struct device_node *dn

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-13 Thread James Hogan
Hi Helge, On 13/05/14 20:45, Helge Deller wrote: > On 05/13/2014 01:18 PM, James Hogan wrote: >> On 04/05/14 08:28, Helge Deller wrote: >>> On 05/02/2014 04:48 PM, James Bottomley wrote: >>>> On Fri, 2014-05-02 at 12:54 +0100, James Hogan wrote: >>>>

Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list

2014-05-14 Thread James Hogan
Hi Miklos, On 29/04/14 12:24, Szeredi Miklos wrote: > On Wed, Apr 23, 2014 at 2:41 PM, James Hogan wrote: > >> It appears Miklos Szeredi beat me to it with patch 1 (adding renameat2 >> syscall to asm-generic unistd.h), and will be submitting it to Linus >> at some point

Re: [PATCH 14/27] metag: Use common bits from generic tlb.h

2014-05-15 Thread James Hogan
On 14/05/14 19:59, Richard Weinberger wrote: > It is no longer needed to define them on our own. > > Cc: James Hogan > Cc: Richard Weinberger > Cc: linux-me...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Richard Weinberger Acked-by: James

Re: [RFC][PATCH 6/8] sched,idle: Avoid spurious wakeup IPIs

2014-05-15 Thread James Hogan
Hi Peter, On 09/05/14 15:51, James Hogan wrote: > On 09/05/14 15:15, Peter Zijlstra wrote: >> Most archs have (x86) hlt or (arm) wfi like idle instructions, and if >> that is your only possible idle function, you'll require the interrupt >> to wake up and there'

<    3   4   5   6   7   8   9   10   11   12   >